mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-30 11:50:47 +00:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
67 lines
1.7 KiB
Go
67 lines
1.7 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package forms
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestSubmitReviewForm_IsEmpty(t *testing.T) {
|
|
|
|
cases := []struct {
|
|
form SubmitReviewForm
|
|
expected bool
|
|
}{
|
|
// Approved PR with a comment shouldn't count as empty
|
|
{SubmitReviewForm{Type: "approve", Content: "Awesome"}, false},
|
|
|
|
// Approved PR without a comment shouldn't count as empty
|
|
{SubmitReviewForm{Type: "approve", Content: ""}, false},
|
|
|
|
// Rejected PR without a comment should count as empty
|
|
{SubmitReviewForm{Type: "reject", Content: ""}, true},
|
|
|
|
// Rejected PR with a comment shouldn't count as empty
|
|
{SubmitReviewForm{Type: "reject", Content: "Awesome"}, false},
|
|
|
|
// Comment review on a PR with a comment shouldn't count as empty
|
|
{SubmitReviewForm{Type: "comment", Content: "Awesome"}, false},
|
|
|
|
// Comment review on a PR without a comment should count as empty
|
|
{SubmitReviewForm{Type: "comment", Content: ""}, true},
|
|
}
|
|
|
|
for _, v := range cases {
|
|
assert.Equal(t, v.expected, v.form.HasEmptyContent())
|
|
}
|
|
}
|
|
|
|
func TestIssueLock_HasValidReason(t *testing.T) {
|
|
|
|
// Init settings
|
|
_ = setting.Repository
|
|
|
|
cases := []struct {
|
|
form IssueLockForm
|
|
expected bool
|
|
}{
|
|
{IssueLockForm{""}, true}, // an empty reason is accepted
|
|
{IssueLockForm{"Off-topic"}, true},
|
|
{IssueLockForm{"Too heated"}, true},
|
|
{IssueLockForm{"Spam"}, true},
|
|
{IssueLockForm{"Resolved"}, true},
|
|
|
|
{IssueLockForm{"ZZZZ"}, false},
|
|
{IssueLockForm{"I want to lock this issue"}, false},
|
|
}
|
|
|
|
for _, v := range cases {
|
|
assert.Equal(t, v.expected, v.form.HasValidReason())
|
|
}
|
|
}
|