mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-05-19 08:48:12 +00:00
534917d576
Fix #22066 # Purpose This PR fix the releases will be deleted when mirror repository sync the tags. # The problem In the previous implementation of #19125. All releases record in databases of one mirror repository will be deleted before sync. Ref: https://github.com/go-gitea/gitea/pull/19125/files#diff-2aa04998a791c30e5a02b49a97c07fcd93d50e8b31640ce2ddb1afeebf605d02R481 # The Pros This PR introduced a new method which will load all releases from databases and all tags on git data into memory. And detect which tags needs to be inserted, which tags need to be updated or deleted. Only tags releases(IsTag=true) which are not included in git data will be deleted, only tags which sha1 changed will be updated. So it will not delete any real releases include drafts. # The Cons The drawback is the memory usage will be higher than before if there are many tags on this repository. This PR defined a special release struct to reduce columns loaded from database to memory.
77 lines
1.8 KiB
Go
77 lines
1.8 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repository
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/modules/git"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_calcSync(t *testing.T) {
|
|
gitTags := []*git.Tag{
|
|
/*{
|
|
Name: "v0.1.0-beta", //deleted tag
|
|
Object: git.MustIDFromString(""),
|
|
},
|
|
{
|
|
Name: "v0.1.1-beta", //deleted tag but release should not be deleted because it's a release
|
|
Object: git.MustIDFromString(""),
|
|
},
|
|
*/
|
|
{
|
|
Name: "v1.0.0", // keep as before
|
|
Object: git.MustIDFromString("1006e6e13c73ad3d9e2d5682ad266b5016523485"),
|
|
},
|
|
{
|
|
Name: "v1.1.0", // retagged with new commit id
|
|
Object: git.MustIDFromString("bbdb7df30248e7d4a26a909c8d2598a152e13868"),
|
|
},
|
|
{
|
|
Name: "v1.2.0", // new tag
|
|
Object: git.MustIDFromString("a5147145e2f24d89fd6d2a87826384cc1d253267"),
|
|
},
|
|
}
|
|
|
|
dbReleases := []*shortRelease{
|
|
{
|
|
ID: 1,
|
|
TagName: "v0.1.0-beta",
|
|
Sha1: "244758d7da8dd1d9e0727e8cb7704ed4ba9a17c3",
|
|
IsTag: true,
|
|
},
|
|
{
|
|
ID: 2,
|
|
TagName: "v0.1.1-beta",
|
|
Sha1: "244758d7da8dd1d9e0727e8cb7704ed4ba9a17c3",
|
|
IsTag: false,
|
|
},
|
|
{
|
|
ID: 3,
|
|
TagName: "v1.0.0",
|
|
Sha1: "1006e6e13c73ad3d9e2d5682ad266b5016523485",
|
|
},
|
|
{
|
|
ID: 4,
|
|
TagName: "v1.1.0",
|
|
Sha1: "53ab18dcecf4152b58328d1f47429510eb414d50",
|
|
},
|
|
}
|
|
|
|
inserts, deletes, updates := calcSync(gitTags, dbReleases)
|
|
if assert.EqualValues(t, 1, len(inserts), "inserts") {
|
|
assert.EqualValues(t, *gitTags[2], *inserts[0], "inserts equal")
|
|
}
|
|
|
|
if assert.EqualValues(t, 1, len(deletes), "deletes") {
|
|
assert.EqualValues(t, 1, deletes[0], "deletes equal")
|
|
}
|
|
|
|
if assert.EqualValues(t, 1, len(updates), "updates") {
|
|
assert.EqualValues(t, *gitTags[1], *updates[0], "updates equal")
|
|
}
|
|
}
|