oliverpool
c81b26b0e5
refactor webhook *NewPost ( #20729 )
...
* refactor webhook *NewPost
* remove empty values
* always show errs.Message
* remove utils.IsValidSlackChannel
* move IsValidSlackChannel to services/webhook package
* binding: handle empty Message case
* make IsValidSlackChannel more strict
2022-08-11 17:48:23 +02:00
wxiaoguang
750a8465f5
A better go code formatter, and now make fmt can run in Windows ( #17684 )
...
* go build / format tools
* re-format imports
2021-11-17 20:34:35 +08:00
6543
dea7a5c5b9
just add some unit tests ( #16291 )
...
* code.gitea.io/gitea/routers/utils coverage: 100.0%
* code.gitea.io/gitea/routers/install 0% -> 5.0%
* ConvertUtf8ToUtf8mb4: make sure DBType is mysql
2021-06-29 22:00:02 +01:00
zeripath
aa4f9180e4
Clarify the suffices and prefixes of setting.AppSubURL and setting.AppURL ( #12999 )
...
Also removes some unnecessary uses of fmt.Sprintf and adds documentation
strings
Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-02-19 22:36:43 +01:00
zeripath
965861043a
Return the full rejection message and errors in flash errors ( #13221 )
...
Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-10-20 19:50:10 -04:00
kolaente
64133126cd
Update golangci-lint to version 1.31.0 ( #13102 )
...
This PR updates golangci-lint to the latest version 1.31.0.
The upgrade introduced a new check for which I've fixed or disabled most cases.
Signed-off-by: kolaente <k@knt.li>
2020-10-11 21:27:20 +01:00
zeripath
74bd9691c6
Re-attempt to delete temporary upload if the file is locked by another process ( #12447 )
...
Replace all calls to os.Remove/os.RemoveAll by retrying util.Remove/util.RemoveAll and remove circular dependencies from util.
Fix #12339
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
2020-08-11 21:05:34 +01:00
zeripath
089ccb0c80
Handle push rejection message in Merge & Web Editor ( #10373 )
...
* Handle push rejection message in Merge
* placate golangci-lint
* Fix sanitize, adjust message handling
* oops
* Oops
* Handle push-rejection in webeditor CRUD too
* Apply suggestions from code review
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-02-22 15:08:48 +02:00
Lanre Adelowo
be48397945
Slack webhook channel name cannot be empty or just contain an hashtag ( #4786 )
2018-09-10 10:31:08 -04:00
Sasha Varlamov
311c83ad17
Allow adding collaborators with (fullname) ( #3103 )
...
* Allow adding collaborators with (fullname)
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Refactor username suffix to utils pkg
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
2017-12-07 15:00:09 +08:00
