mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-26 09:50:41 +00:00
Backport #23462 by @sillyguodong Close #23440 Cause by #23189 In #23189, we should insert a comment record into db when pushing a commit to the PR, even if the PR is closed. But should skip sending any notification in this case. Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
This commit is contained in:
parent
527bbf67e8
commit
d73846f0b4
1 changed files with 4 additions and 1 deletions
|
@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// If the PR is closed, someone still push some commits to the PR,
|
||||||
|
// 1. We will insert comments of commits, but hidden until the PR is reopened.
|
||||||
|
// 2. We won't send any notification.
|
||||||
AddToTaskQueue(pr)
|
AddToTaskQueue(pr)
|
||||||
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
|
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
|
||||||
if err == nil && comment != nil {
|
if err == nil && comment != nil && !pr.Issue.IsClosed {
|
||||||
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
|
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue