jobs-sled: reorganize completion match

jobs-sled/src/lib.rs

@@ -133,22 +133,20 @@ impl background_jobs_core::Storage for Storage {
         };
 
         match result {
-            JobResult::Success => {
+            // successful jobs are removed
-                // ok
+            JobResult::Success => Ok(true),
-                Ok(true)
+            // Unregistered or Unexecuted jobs are restored as-is
-            }
             JobResult::Unexecuted | JobResult::Unregistered => {
-                // TODO: handle
+                self.insert(job)?;
-                Ok(true)
+                Ok(false)
             }
-            JobResult::Failure => {
+            // retryable failed jobs are restored
-                if job.prepare_retry() {
+            JobResult::Failure if job.prepare_retry() => {
-                    self.insert(job)?;
+                self.insert(job)?;
-                    Ok(false)
+                Ok(false)
-                } else {
-                    Ok(true)
-                }
             }
+            // dead jobs are removed
+            JobResult::Failure => Ok(true),
         }
     }
 }