mirrors/actix-web
1
0
Fork 0
mirror of https://github.com/actix/actix-web.git synced 2024-07-02 20:15:51 +00:00
Code Issues Projects Releases Wiki Activity
3932 commits 24 branches 479 tags 44 MiB
Commit graph

5 commits

Author SHA1 Message Date
Rob Ede 0a506bf2e9
cleanup top level doc comments 2021-01-15 05:38:50 +00:00
Otavio Salvador 7e0d898d5a Fix clippy warnings 
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
 2020-03-12 00:52:21 -03:00
Maksym Vorobiov 835a00599c rollback missed dependencies and CHANGES in crates except actix-http 2020-02-27 09:37:05 +09:00
Maksym Vorobiov d9c415e540 disable weird poll test until actix-web based on actix-http:2 2020-02-27 09:37:05 +09:00
Aaron Hill fe13789345
Use Pin<Box<S>> in BodyStream and SizedStream (#1328) 
Fixes #1321

A better fix would be to change `MessageBody` to take a `Pin<&mut
Self>`, rather than a `Pin<&mut Self>`. This will avoid requiring the
use of `Box` for all consumers by allowing the caller to determine how
to pin the `MessageBody` implementation (e.g. via stack pinning).

However, doing so is a breaking change that will affect every user of
`MessageBody`. By pinning the inner stream ourselves, we can fix the
undefined behavior without breaking the API.

I've included @sebzim4500's reproduction case as a new test case.
However, due to the nature of undefined behavior, this could pass (and
not segfault) even if underlying issue were to regress.

Unfortunately, until rust-lang/unsafe-code-guidelines#148 is resolved,
it's not even possible to write a Miri test that will pass when the bug
is fixed.

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
 2020-01-31 09:39:34 +09:00