1
0
Fork 0
mirror of https://github.com/actix/actix-web.git synced 2025-03-12 22:32:39 +00:00
Commit graph

674 commits

Author SHA1 Message Date
Rob Ede
1bfdfd1f41
implement parts as assoc method 2021-04-14 02:57:28 +01:00
Rob Ede
5202bf03c1
add some doc examples to response builder 2021-04-14 02:45:58 +01:00
Rob Ede
387c229f28
move response builder code to own file 2021-04-14 02:12:47 +01:00
Rob Ede
23e0c9b6e0
remove http-codes builders from actix-http () 2021-04-14 02:00:14 +01:00
Rob Ede
02ced426fd
add body to_bytes helper () 2021-04-13 13:34:22 +01:00
Rob Ede
4442535a45
clippy 2021-04-13 12:44:38 +01:00
Rob Ede
edd9f14752
remove unpin from body types () 2021-04-13 11:16:12 +01:00
Rob Ede
981c54432c
remove json and url encoded form support from -http () 2021-04-12 10:30:28 +01:00
Rob Ede
44c55dd036
remove cookie support from -http () 2021-04-09 18:07:10 +01:00
Rob Ede
e0b2246c68
prepare test release 0.1.0-beta.1 2021-04-02 10:03:01 +01:00
Rob Ede
6fb06a720a
prepare http release 3.0.0-beta.5 2021-04-02 09:27:11 +01:00
Rob Ede
c54a0713de
migrate integration testing to new crate () 2021-04-02 08:26:59 +01:00
Ibraheem Ahmed
50dc13f280
move typed headers and implement FromRequest ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
2021-04-01 16:42:18 +01:00
Rob Ede
c8ed8dd1a4
migrate to -utils beta 4 () 2021-04-01 15:26:13 +01:00
fakeshadow
c49fe79207
Simplify lifetime annotation in HttpServiceBuilder. Simplify PlStream () 2021-03-30 15:46:09 +01:00
Rob Ede
f66774e30b
remove From<OffsetDateTime> impl from HttpDate
fully removes time crate from public api of -http
2021-03-30 03:32:22 +01:00
fakeshadow
1281a748d0
merge H1ServiceHandler requests into HttpServiceHandler () 2021-03-30 03:06:16 +01:00
fakeshadow
222acfd070
Fix build for next actix-tls-beta release () 2021-03-29 13:45:48 +01:00
Rob Ede
e8ce73b496
update dep docs 2021-03-29 11:52:59 +01:00
Daniel Egger
f954a30c34
Fix typo in CHANGES.md () 2021-03-29 10:18:05 +01:00
fakeshadow
60f9cfbb2a
Refactor actix_http::h2::service module. Reduce loc. () 2021-03-26 18:24:51 +00:00
fakeshadow
6822bf2f58
Refactor actix_http::h1::service () 2021-03-26 16:15:04 +00:00
fakeshadow
2f7f1fa97a
fix broken pipe for h2 when client is instantly dropped () 2021-03-26 00:05:31 +00:00
fakeshadow
8c2ce2dedb
fix awc compress feature () 2021-03-25 22:47:37 +00:00
Rob Ede
3188ef5731
don't use rust annotation on code doc blocks 2021-03-25 08:45:52 +00:00
fakeshadow
351286486c
fix clippy warning on nightly ()
* fix clippy warning on nightly
2021-03-19 19:25:35 +08:00
Rob Ede
81942d31d6
fix new dyn trait lint 2021-03-19 02:03:09 +00:00
fakeshadow
b75b5114c3
refactor actix_http connection types and connector services () 2021-03-18 17:53:22 +00:00
Rob Ede
983b6904a7
unvendor openssl 2021-03-17 00:38:54 +00:00
Rob Ede
3dc2d145ef
import some traits as _ 2021-03-17 00:38:54 +00:00
fakeshadow
c8f6d37290
rename client io trait. reduce duplicate code () 2021-03-16 16:31:14 +00:00
fakeshadow
69dd1a9bd6
Remove ConnectionLifetime trait. Simplify Acquired handling () 2021-03-16 02:56:23 +00:00
fakeshadow
a55e87faaa
refactor actix_http::helpers to generic over bufmut trait () 2021-03-15 02:33:51 +00:00
fakeshadow
515d0e3fb4
change behavior of default upgrade handler () 2021-03-13 22:20:18 +00:00
fakeshadow
a2b0e86632
simplify connector generic type () 2021-03-10 23:57:32 +00:00
fakeshadow
d0c1f1a84c
remove actix_http::client::pool::Protocol () 2021-03-10 01:31:50 +00:00
Rob Ede
18c3783a1c
prepare actix-http-test release 3.0.0-beta.3 2021-03-09 23:35:42 +00:00
Rob Ede
fc31b091e4
prepare http release 3.0.0-beta.4 2021-03-08 23:07:40 +00:00
Rob Ede
effacf8fc8
fix ssl test 2021-03-08 20:51:50 +00:00
fakeshadow
5e81105317
remove ka timer from h2 dispatcher () 2021-03-08 20:00:20 +00:00
Rob Ede
2d3a0d6038
json method receives plain serialize () 2021-03-07 22:11:39 +00:00
fakeshadow
fe0b3f459f
remove localwaker from h1::payload () 2021-03-07 21:23:42 +00:00
Rob Ede
ca69b6577e
use iota for more content-length insertions () 2021-03-07 19:29:02 +00:00
fakeshadow
880b863f95
fix h1 client for handling expect header request () 2021-03-07 18:33:16 +00:00
fakeshadow
78384c3ff5
make actix_http::ws::Codec::new const () 2021-03-04 19:19:01 +00:00
Rob Ede
c1c4400c4a
fix h2 tests () 2021-03-04 13:27:54 +00:00
Rob Ede
cd652dca75
refactor websocket key hashing () 2021-02-28 19:55:34 +00:00
fakeshadow
badae2f8fd
add local_address bind for client builder () 2021-02-27 22:31:14 +00:00
fboulnois
1f34718ecd
Use once_cell instead of lazy_static () 2021-02-27 21:55:50 +00:00
Rob Ede
b95e1dda34
pin h2 to 0.3.0 2021-02-27 19:57:09 +00:00
Alex Rebert
5845b3965c
actix-http-test: minimize features of dependencies () 2021-02-22 12:00:08 +00:00
fakeshadow
aacec30ad1
reduce duplicate code () 2021-02-22 11:15:12 +00:00
fakeshadow
946cccaa1a
refactor awc::ClientBuilder () 2021-02-18 12:30:09 +00:00
fakeshadow
1838d9cd0f
remove unused method. reduce leaf future type () 2021-02-18 11:24:10 +00:00
fakeshadow
f62a982a51
simplify the match on h1 message type () 2021-02-18 10:38:27 +00:00
fakeshadow
dfa795ff9d
return poll in poll_flush () 2021-02-17 11:18:31 +00:00
fakeshadow
117025a96b
simplify client::connection::Connection trait () 2021-02-16 14:10:22 +00:00
Rob Ede
17b3e7e225
pool doc nits () 2021-02-16 09:08:30 +00:00
fakeshadow
c065729468
rework client connection pool () 2021-02-16 08:27:14 +00:00
Rob Ede
55db3ec65c
split up http body module 2021-02-15 12:20:43 +00:00
Rob Ede
0404b78b54
improve body size docs 2021-02-15 11:24:46 +00:00
fakeshadow
68d1bd88b1
remove unused flag upgrade () 2021-02-14 18:13:05 +00:00
fakeshadow
308b70b039
fix potential over read () 2021-02-14 17:36:18 +00:00
Rob Ede
7fa6333a0c
use rcgen for tls key generation () 2021-02-13 17:16:36 +00:00
Rob Ede
3279070f9f
optional cookies features () 2021-02-13 15:08:43 +00:00
fakeshadow
b37669cb3b
fix notify on drop () 2021-02-13 04:23:37 +00:00
Rob Ede
1e538bf73e
rework ci () 2021-02-12 21:53:21 +00:00
fakeshadow
366c032c36
refactor DateService () 2021-02-12 21:52:58 +00:00
fakeshadow
95113ad12f
do not self wake up when have a payload () 2021-02-12 20:33:13 +00:00
fakeshadow
ce9b2770e2
remove unused Dispatcher::new_timeout () 2021-02-12 10:37:28 +00:00
Rob Ede
4fc7d76759
s/websocket/WebSocket in docs 2021-02-12 00:27:20 +00:00
Rob Ede
81bef93e5e
add time parser year shift tests 2021-02-12 00:15:25 +00:00
Rob Ede
31d9ed81c5
change rustfmt line width to 96 2021-02-11 23:03:17 +00:00
Rob Ede
c1af5089b9
add 431 and 451 status codes 2021-02-11 22:58:40 +00:00
Rob Ede
77efc09362
hide httpmessage mod 2021-02-11 22:58:40 +00:00
Rob Ede
871ca5e4ae
stop claiming actor support 2021-02-11 22:58:40 +00:00
fakeshadow
ceace26ed4
remove unused flag POLLED () 2021-02-11 14:19:14 -08:00
fakeshadow
75a9a72e78
clean up poll_response. add comments () 2021-02-11 14:54:42 +00:00
fakeshadow
d9d0d1d1a2
reduce unsafe () 2021-02-10 23:11:12 +00:00
Rob Ede
ea5ce3befb
prepare actix-http 3.0.0-beta.3 release 2021-02-10 18:36:14 +00:00
Rob Ede
a290e58982
prepare beta 2 release set () 2021-02-10 12:10:03 +00:00
fakeshadow
dcad9724bc
ensure poll_flush on h1 connection disconnect () 2021-02-10 10:11:53 +00:00
Rob Ede
949d14ae2b
clean up header map () 2021-02-09 22:59:17 +00:00
fakeshadow
a6ed4aee84
add poll_flush after a non blocked write to h1 dispatcher () 2021-02-09 22:32:46 +00:00
fakeshadow
519d7f2b8a
add trust-dns optional feature for actix-http and awc () 2021-02-09 10:41:20 +00:00
fakeshadow
266cf0622c
reduce branch.remove deadcode for h1 dispatcher () 2021-02-07 22:48:27 +00:00
fakeshadow
dbc47c9122
optimize actix-http messages () 2021-02-07 20:19:10 +00:00
fakeshadow
4c243cbf89
simplify methods of awc::connect::Connect trait () 2021-02-07 18:56:39 +00:00
Alexander Jackson
deafb7c8b8
Improve impl ResponseError documentation ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
2021-02-07 04:54:41 +00:00
Rob Ede
9eaea6a2fd
tweak feature flags 2021-02-07 03:54:58 +00:00
fakeshadow
830fb2cdb2
properly drop h2 connection () 2021-02-07 03:51:36 +00:00
fakeshadow
7cfed73be8
fix memory usage for h1 and read bug on buffer size. () 2021-02-07 03:20:35 +00:00
fakeshadow
41bc04b1c4
Use immutable reference of service state. Update awc dns resolver. () 2021-02-07 01:00:40 +00:00
fakeshadow
20cf0094e5
fix master branch build. change web::block output type. () 2021-02-06 16:23:59 +00:00
Logan Magee
0c8196f8b0
Remove HttpResponseBuilder::json2() ()
It's not necessary to keep both json() and json2() around since the
former reduces the ownership of its parameter to a borrow only to pass
the reference to the latter. Users can instead borrow themselves when
passing an owned value: there doesn't need to be two separate functions.

This change also makes HttpResponseBuilder::json() take T: Deref so it
can accept both references and web extractors like web::Json.
2021-01-18 12:14:29 +00:00
Rob Ede
ee10148444
revive commented out tests () 2021-01-17 05:19:32 +00:00
fakeshadow
1c95fc2654
Refactor poll_keepalive for readability () 2021-01-16 00:15:06 +00:00
Rob Ede
0a506bf2e9
cleanup top level doc comments 2021-01-15 05:38:50 +00:00
Rob Ede
f976150b67
return option item from Extensions::insert () 2021-01-15 04:22:42 +00:00
Rob Ede
b1dd8d28bc
response header rework () 2021-01-15 02:11:10 +00:00
fakeshadow
d34a8689e5
Refactor h1 encoder () 2021-01-12 14:38:53 +00:00
fakeshadow
7affc6878e
simplify h1 dispatcher ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
2021-01-11 00:13:56 +00:00
fakeshadow
fe392abeb4
remove actix-threadpool.use actix_rt::task::spawn_blocking () 2021-01-09 16:04:19 +00:00
fakeshadow
f6cc829758
remove leaked box in REQUEST_POOL and RESPONSE_POOL () 2021-01-09 15:40:20 +00:00
Rob Ede
6575ee93f2
big clean up and docs improvmenet of types mod () 2021-01-09 13:17:19 +00:00
fakeshadow
188ee44f81
remove copyless dependency () 2021-01-07 21:55:00 +00:00
fakeshadow
a4c9aaf337
fix extra branch in h1 dispatcher timer () 2021-01-07 20:42:09 +00:00
Rob Ede
c09186a2c0
prepare v4 beta releases () 2021-01-07 20:02:08 +00:00
Rob Ede
dc23559f23
address clippy lints 2021-01-07 02:04:26 +00:00
fakeshadow
6d710629af
fix bug where upgrade future is not reset properly () 2021-01-07 00:57:34 +00:00
Rob Ede
85753130d9
fmt 2021-01-07 00:35:19 +00:00
Rob Ede
00ba8d5549
add http3 variant to protocol enum 2021-01-06 18:58:24 +00:00
Rob Ede
51e9e1500b
add docs to recent additions 2021-01-06 18:52:06 +00:00
fakeshadow
a03dbe2dcf
replace cloneable service with httpflow abstraction () 2021-01-06 18:43:52 +00:00
fakeshadow
93161df141
clean up body type () 2021-01-04 23:47:38 +00:00
fakeshadow
e567873326
optimize message pool release () 2021-01-04 13:03:46 +00:00
Rob Ede
7d632d0b7b
use ByteString as container for websocket text message () 2021-01-04 11:27:32 +00:00
Rob Ede
2d4a174420
fmt 2021-01-04 01:01:35 +00:00
Rob Ede
21f6c9d7a5
improve code readability 2021-01-04 00:49:02 +00:00
fakeshadow
32de9f8840
Tokio 1.0 ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
2021-01-03 23:47:04 +00:00
Rob Ede
1f202d40e4
optimize write_camel_case in h1 encoder () 2021-01-03 16:53:01 +00:00
Rob Ede
a1b00b2cd0
change unreleased year 2021-01-02 00:12:18 +00:00
Rob Ede
2a2a20c3e7
bump msrv to 1.46 () 2020-12-28 00:44:15 +00:00
Rob Ede
093d3a6c59
remove deprecated on_connect methods () 2020-12-27 23:23:30 +00:00
fakeshadow
f9fcf56d5c
reduce branch in actix_http::h1::codec () 2020-12-27 20:37:53 +00:00
fakeshadow
1032f04ded
remove unused actix_http::h1::OneRequest () 2020-12-26 12:46:36 +00:00
fakeshadow
ecf08d5156
Remove boxed future from h1 Dispatcher () 2020-12-24 19:15:17 +00:00
Rob Ede
2a7f2c1d59
dispatcher internals testing () 2020-12-23 01:28:17 +00:00
Logan Magee
4dccd092f3
Bump rand from 0.7.x to 0.8.x () 2020-12-22 23:45:31 +00:00
fakeshadow
95ccf1c9bc
replace actix_utils::oneshot with futures_channle::oneshot () 2020-12-21 16:42:20 +00:00
Aravinth Manivannan
fabc68659b
Intradoc links conversion ()
* switching to nightly for intra-doc links

* actix-files intra-doc conversion

* more specific Result

* intradoc conversion complete

* rm blank comments and readme doc link fixes

* macros and broken links
2020-12-13 13:28:39 +00:00
Juan Aguilar
542db82282
Simplify wake up of task () 2020-12-12 20:07:06 +00:00
Rob Ede
ae63eb8bb2
fix clippy warnings ()
* fix clippy warnings

* prevent CI fail status caused by codecov
2020-12-09 11:22:19 +00:00
Rob Ede
efc317d3b0
prepare actix-http and awc releases 2020-11-25 00:07:56 +00:00
Rob Ede
5af46775b8
refactor quality and use TryFrom instead of custom trait () 2020-11-24 11:37:05 +00:00
Rob Ede
70f4747a23
add method for getting accept type preference () 2020-11-24 10:08:57 +00:00
Yuki Okushi
4bfd5c2781
Upgrade serde_urlencoded to 0.7 () 2020-11-06 01:36:15 +09:00
Rob Ede
61b65aa64a
add common 1xx http response builders ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-11-02 18:23:18 +09:00
Sebastian Mayr
5468c3c410
Drop content length headers from 101 responses ()
Co-authored-by: Sebastian Mayr <smayr@atlassian.com>
2020-11-02 17:44:14 +09:00
Yuki Okushi
b6385c2b4e Remove CoC on actix-http as duplicated 2020-10-31 12:12:19 +09:00
Rob Ede
156c97cef2
prepare awc release 2.0.1 2020-10-30 02:50:53 +00:00
Rob Ede
798d744eef
prepare http release 2.1.0 2020-10-30 02:19:56 +00:00
Rob Ede
4cb833616a
deprecate builder if-x methods () 2020-10-30 02:10:05 +00:00
Rob Ede
9963a5ef54
expose on_connect v2 ()
Co-authored-by: Mikail Bagishov <bagishov.mikail@yandex.ru>
2020-10-30 02:03:26 +00:00
Augusto César Dias
7030bf5fe8
Adding app_data to ServiceConfig ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
Co-authored-by: Augusto <augusto@flowciety.de>
2020-10-26 17:02:45 +00:00
ghizzo01
20078fe603
Bump pin-project to 1.0 () 2020-10-25 19:41:44 +09:00
ghizzo01
f92742bdac
Bump base64 to 0.13 () 2020-10-19 18:24:22 +01:00
Rob Ede
e563025b16
always construct shortslice using debug checked new constructor () 2020-10-19 12:51:30 +01:00
Yuki Okushi
c2c71cc626
Fix/suppress clippy warnings () 2020-10-01 18:19:09 +09:00
Igor Aleksanov
f9e3f78e45
eemove non-relevant comment from actix-http README.md () 2020-09-20 17:21:53 +01:00
Rob Ede
64a2c13cdf
the big three point oh () 2020-09-11 13:50:10 +01:00
Rob Ede
bf53fe5a22
bump actix dependency to v0.10 () 2020-09-11 12:09:52 +01:00
Rob Ede
7787638f26
fix CI clippy warnings () 2020-09-10 14:46:35 +01:00
Rob Ede
059d1671d7
prepare release beta 4 () 2020-09-09 22:14:11 +01:00
Rob Ede
9d0534999d
bump connect and tls versions () 2020-09-09 09:20:54 +01:00
Rob Ede
9a9d4b182e
document all remaining unsafe usages ()
adds some debug assertions where appropriate
2020-09-03 10:00:24 +01:00
Rob Ede
8497b5f490
integrate with updated actix-{codec, utils} () 2020-08-24 10:13:35 +01:00
Yuki Okushi
ff2ca0f420
Update rustls to 0.18 () 2020-08-18 00:28:39 +09:00
Yuki Okushi
aa2bd6fbfb
http: Bump up to 2.0.0-beta.3 () 2020-08-14 19:42:14 +09:00
fakeshadow
160995b8d4
fix awc pool leak () 2020-08-09 21:49:43 +01:00
Rob Ede
cf1c8abe62
prepare release http & awc () 2020-07-22 01:13:10 +01:00
Yuki Okushi
92b5bcd13f
Check format and tweak CI config () 2020-07-22 00:28:33 +01:00
masnagam
701bdacfa2
Fix illegal chunked encoding ()
Co-authored-by: Rob Ede <robjtede@icloud.com>
2020-07-21 17:24:56 +01:00
Rob Ede
6dc47c4093
fix soundness concern in h1 decoder ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-07-21 16:25:33 +01:00
Rob Ede
0ec335a39c
bump MSRV to 1.42 () 2020-07-21 16:40:30 +09:00
Yuki Okushi
1382094c15
Avoid using deprecated / in license field 2020-07-14 11:19:56 +09:00
Rob Ede
327e472e44
prepare http-2.0.0-beta.1 release () 2020-07-13 15:35:30 +01:00
Patrick Tescher
e10eb648d9
Fix leaks with actix_http's client () 2020-07-10 22:35:22 +01:00
Yuki Okushi
deab634247
actix-http: Update sha-1 to 0.9 () 2020-07-03 01:08:24 +01:00
Rob Ede
eb0eda69c6
migrate cookie handling to cookie crate () 2020-06-19 14:34:14 +01:00
Andrew
e72ee28232
Enforce HW_BUFFER_SIZE inside h1::dispatcher () 2020-06-17 08:58:23 +01:00
Taiki Endo
6c5c4ea230 Remove uses of pin_project::project attribute
pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: https://github.com/taiki-e/pin-project/issues/225
2020-06-06 06:44:14 +09:00
Yuki Okushi
5286b8aed7
Remove AppVeyor config 2020-06-03 03:39:35 +09:00
Stephen Stack
621ebec01a
Fix typo in timeout error display () 2020-06-02 18:04:49 +01:00
Yuki Okushi
4a955c425d
Update actix-http-test dependency to 2.0.0-alpha.1 2020-05-23 12:14:17 +09:00
Nick Kolpinskiy
7d8fb631a0 Use itoa in the content-length helper 2020-05-21 22:25:34 +03:00
Yuki Okushi
48fa78e182
http: Bump up to 2.0.0-alpha.4 2020-05-21 15:22:07 +09:00
Yuki Okushi
8391427905
http: Update base64 to 0.12 2020-05-21 09:51:32 +09:00
Yuki Okushi
292af145cb
http: Minimize futures dependencies 2020-05-19 08:29:11 +09:00
Omid Rad
32a37b7282
Remove content_length from ResponseBuilder ()
* Remove content_length since it'll be overwritten by the response body. FIXES 

* Add setting of Content-Length to the no_chunking function

* Add changes and migration documentations

* Update MIGRATION.md

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>

Co-authored-by: Rob Ede <robjtede@icloud.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-05-19 07:46:31 +09:00
Rob Ede
7e8ea44d5c
remove needless BodySize::Sized64 variant 2020-05-18 00:42:51 +01:00
Rob Ede
f3b0233477
use mem::take where possible () 2020-05-17 10:54:42 +09:00
Rob Ede
996f1d7eae
bump msrv in ci and readme 2020-05-13 01:57:37 +01:00
Takeru Sato
63864ecf9e
support parsing of SameSite=None () 2020-05-12 17:48:35 +01:00
Yuki Okushi
0bc4a5e703
http: Bump up to 2.0.0-alpha.3 2020-05-08 02:35:45 +09:00
Rob Ede
9d94fb91b2
correct spelling of ConnectError::Unresolved ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-05-08 02:26:48 +09:00
Rob Ede
b521e9b221
conditional test compilation [range, charset] ()
* conditionally compile range and charset tests

* remove deprecated try macros

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-05-03 22:33:29 +09:00
Rob Ede
f37cb6dd0b
refactor h1 status line helper to remove unsafe usage ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-05-03 17:37:40 +09:00
Mikail Bagishov
d5ceae2074
Replace deprecated now with now_utc ()
* Replace deprecated now with now_utc

* Update doctest
2020-05-02 10:14:50 +01:00
Rob Ede
c27d3fad8e
clarify resource/scope app data overriding ()
* relocate FnDataFactory

* clarify app data overriding in Scope and Resource

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-04-30 02:20:47 +09:00
Huston Bokinsky
b047413b39
Small ws codec fix ()
* Small ws codec fix

* Update actix-http/Changes.md

Co-authored-by: Huston Bokinsky <huston@deepgram.com>
2020-04-29 11:13:09 +09:00
Rob Ede
5b0f7fff69
fix spelling errors in doc comments 2020-04-21 04:09:35 +01:00
Yuki Okushi
54619cb680
actix-http: Remove failure support () 2020-04-16 06:54:34 +09:00
Otavio Salvador
146ae4da18 Implement std::error::Error for our custom errors
For allowing a more ergonomic use and better integration on the
ecosystem, this adds the `std::error::Error` `impl` for our custom
errors.

We intent to drop this hand made code once `derive_more` finishes the
addition of the Error derive support[1]. Until that is available, we
need to live with that.

1. https://github.com/JelteF/derive_more/issues/92

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
2020-03-18 00:22:18 -03:00
Yuki Okushi
e718f65121
Update tests 2020-03-08 16:42:45 +09:00
Yuki Okushi
b93e1555ec
Update actix-connect to 2.0.0-alpha.2 2020-03-08 15:27:40 +09:00
Yuki Okushi
0d5646a8b6
Run rustfmt 2020-03-08 00:52:39 +09:00
Yuki Okushi
6f63acaf01
Bump up to 2.0.0-alpha.2 2020-03-08 00:48:45 +09:00
Yuki Okushi
7172885beb
Update changelog 2020-03-08 00:43:17 +09:00
Yuki Okushi
cf721c5fff
Update README example 2020-03-08 00:43:01 +09:00
Maxim Vorobjov
10e3e72595
Http2 client configuration to improve performance ()
* add defaults for http2 client configuration

* fix spaces

* Add changes text for extended H2 defaults buffers

* client: configurable H2 window sizes and max_http_version

* add H2 window size configuration and max_http_version to awc::ClientBuilder

* add awc::ClientBuilder H2 window sizes and max_http_version

* add test for H2 window size settings

* cleanup comment

* Apply code review fixes

* Code review fix for awc ClientBuilder

* Remove unnecessary comments on code review

* pin quote version to resolve build issue

* max_http_version to accept http::Version

* revert fix for quote broken build
2020-03-07 11:09:31 +09:00
Aaron Hill
e90950fee1
Re-apply commit 2cf7b3ad20
This ended up getting reverted by , which re-introduced an unsound
use of `Pin::new_unchecked`

See my original PR  for the reasoning behind this change.
2020-03-04 11:27:58 -05:00
Yuki Okushi
9d661dc4f3 Update changelog 2020-03-04 15:20:14 +09:00
Yuki Okushi
687dc609dd Update rustls to 0.17 2020-03-04 15:11:31 +09:00
Yuki Okushi
b9b52079e0 Update actix-tls to 2.0.0-alpha.1 2020-03-04 15:10:23 +09:00
Yuki Okushi
117d28f7ba Update actix-connect to 2.0.0-alpha.1 2020-03-04 15:09:31 +09:00
Yuki Okushi
b4d63667df Demote lint level to warn 2020-02-27 22:39:11 +09:00
Yuki Okushi
6cc83dbb67 Allow clippy lint for compatibility 2020-02-27 12:45:11 +09:00
Yuki Okushi
15a2587887 Bump up to 2.0.0-alpha.1 2020-02-27 12:39:04 +09:00
Yuki Okushi
0173f99726 Update changelog 2020-02-27 12:39:04 +09:00
Yuki Okushi
f27dd19093 Fix Clippy warnings 2020-02-27 12:39:04 +09:00
Yuki Okushi
7ba14fd113 Run rustfmt 2020-02-27 11:10:55 +09:00
Yuki Okushi
903ae47baa dev-deps: Update env_logger to 0.7 2020-02-27 11:08:45 +09:00
Yuki Okushi
cd1765035c Avoid re-definition 2020-02-27 09:42:32 +09:00
Maksym Vorobiov
ea28219d0f reenable actix-http test-ws 2020-02-27 09:42:32 +09:00
Maksym Vorobiov
0a86907dd2 use mem::replace instead of mem::take rust 1.40+ 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
78749a4b7e rollback actix-http version change 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
de815dd99c Fixed condition for finishing transfer of response 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
e6078bf792 Fix EncoderBody enum to align with Body::Message 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
a84b37199a Add Unpin to Body to get rid of unsafe in MessageBody 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
c05f9475c5 refactor dispatcher to avoid possible UB with DispatcherState Pin 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
69dab0063c Get rid of one more unsafe 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
ec5c779732 unlink MessageBody from Unpin 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
2e2ea7ab80 remove extra whitespaces and Unpins 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
eeebc653fd change actix-http version to alpha 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
09a391a3ca rollback changes to actix-web, awc and test-server for now 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
62aba424e2 Rollback actix-http-test dependency to show the issue 2020-02-27 09:37:05 +09:00
Maksym Vorobiov
9d04b250f9 This is a squashed commit:
- Convert MessageBody to accept Pin in poll_next

- add CHANGES and increase versions aligned to semver

- update crates to accomodate MessageBody Pin change

- fix tests and dependencies
2020-02-27 09:37:05 +09:00
Maksym Vorobiov
a4148de226 add test crashing with segfault according to 2020-02-27 09:36:30 +09:00
Maxim Vorobjov
48ef4d7a26
Add actix-http support for actix error messages ()
* Moved actix-http for actix from actix crate

* remove resolver feature

* renamed actix feature to actor

* fixed doc attr for actors, add documentation
2020-02-27 09:34:49 +09:00
Aaron Hill
71c4bd1b30
Remove uses of Pin::new_unchecked in h1 Dispatcher ()
This removes the last uses of unsafe `Pin` functions in actix-web.

This PR adds a `Pin<Box<_>>` wrapper to `DispatcherState::Upgrade`,
`State::ExpectCall`, and `State::ServiceCall`.

The previous uses of the futures `State::ExpectCall` and `State::ServiceCall`
were Undefined Behavior - a future was obtained from `self.expect.call`
or `self.service.call`, pinned on the stack, and then immediately
returned from `handle_request`. The only alternative to using `Box::pin`
would be to refactor `handle_request` to write the futures directly into
their final location, or avoid polling them before they are returned.

The previous use of `DispatcherState::Upgrade` doesn't seem to be
unsound. However, having data pinned inside an enum that we
`std::mem::replace` would require some careful `unsafe` code to ensure
that we never call `std::mem::replace` when the active variant contains
pinned data. By using `Box::pin`, we any possibility of future
refactoring accidentally introducing undefined behavior.

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-02-26 08:21:05 +09:00
Yuki Okushi
2a72e8d119
Merge branch 'master' into replace-unsafe-content-length-helper 2020-02-25 14:30:04 +09:00
Yuki Okushi
845ce3cf34 Fix doc comment 2020-02-25 07:46:03 +09:00
Rob Ede
94da08f506
increase content-length fast path to responses up to 1MB 2020-02-24 20:58:41 +00:00
Yuki Okushi
c8ccc69b93 actix-http: update time to 0.2.7 2020-02-23 07:09:00 +09:00
Daniel YU
245f96868a
impl downcast_ref for MessageBody ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-02-21 13:31:51 +09:00
Aaron Hill
e6811e8818
Use #[pin_project] with ConnectorPoolSupport
This removes a use of `Pin::get_unchecked_mut`
2020-02-19 21:42:53 -05:00
Rob Ede
f266b44cb0
replace unsafe blocks in write_usize helper 2020-02-16 15:20:25 +00:00
Rob Ede
31a3515e90
add safe vs unsafe benchmarks 2020-02-16 14:31:06 +00:00
Rob Ede
82b2786d6b
replace unsafe content length implementation 2020-02-16 14:31:05 +00:00
zero-systems
728b944360
Extensions module improvement and tests. ()
* replace get.is_some to contains_key

* Add tests

* remove unnecessary box cast

* fix missing uints

* asserts fix

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-02-07 16:08:25 +09:00
Aaron Hill
fe13789345
Use Pin<Box<S>> in BodyStream and SizedStream ()
Fixes 

A better fix would be to change `MessageBody` to take a `Pin<&mut
Self>`, rather than a `Pin<&mut Self>`. This will avoid requiring the
use of `Box` for all consumers by allowing the caller to determine how
to pin the `MessageBody` implementation (e.g. via stack pinning).

However, doing so is a breaking change that will affect every user of
`MessageBody`. By pinning the inner stream ourselves, we can fix the
undefined behavior without breaking the API.

I've included @sebzim4500's reproduction case as a new test case.
However, due to the nature of undefined behavior, this could pass (and
not segfault) even if underlying issue were to regress.

Unfortunately, until  is resolved,
it's not even possible to write a Miri test that will pass when the bug
is fixed.

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-31 09:39:34 +09:00
Aaron Hill
3033f187d2
Enforce safety of downcast_ref at compile time. ()
* Enforce safety of `downcast_ref` at compile time.

The safety of `downcast_ref` requires that `__private_get_type_id__` not
be overriden by callers, since the returned `TypeId` is used to check if
the cast is safe. However, all trait methods in Rust are public, so
users can override `__private_get_type_id__` despite it being
`#[doc(hidden)]`.

This commit makes `__private_get_type_id__` return a type with a private
constructor, ensuring that the only possible implementation is the
default implementation. A more detailed explanation is provided in the
comments added to the file.

Note that the standard library was affected by this type of issue with
the `Error::type_id` function: see https://blog.rust-lang.org/2019/05/14/Rust-1.34.2.html#whats-in-1.34.2-stable

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-30 23:43:35 +09:00
Aaron Hill
276a5a3ee4
Replace UnsafeCell with Cell in DateServiceInner ()
* Replace `UnsafeCell` with `Cell` in `DateServiceInner`

This ensures that it's impossible to cause undefined behavior by
accidentally violating Rust's aliasing rules (e.g. passing a closure to
`set_date` which ends up invoking `reset` or `update` on the inner
`DateServiceInner`).

There might be a tiny amount of overhead from copying the `Option<(Date,
Instant)>` rather than taking a reference, but it shouldn't be
measurable.

Since the wrapped type is `Copy`, a `Cell` can be used, avoiding the
runtime overhead of a `RefCell`.

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-29 21:05:08 +09:00
kevinpoitra
e634e64847 Upgrade time to 0.2.5 ()
* Use `OffsetDateTime` instead of `PrimitiveDateTime`

* Parse time strings with `PrimitiveDateTime::parse` instead of `OffsetDateTime::parse`

* Remove unused `time` dependency from actix-multipart

* Fix a few errors with time related tests from the `time` upgrade

* Implement logic to convert a RFC 850 two-digit year into a full length year, and organize time parsing related functions

* Upgrade `time` to 0.2.2

* Correctly parse C's asctime time format using time 0.2's new format patterns

* Update CHANGES.md

* Use `time` without any of its deprecated functions

* Enforce a UTC time offset when converting an `OffsetDateTime` into a Header value

* Use the more readable version of `Duration::seconds(0)`, `Duration::zero()`

* Remove unneeded conversion of time::Duration to std::time::Duration

* Use `OffsetDateTime::as_seconds_f64` instead of manually calculating the amount of seconds from nanoseconds

* Replace a few additional instances of `Duration::seconds(0)` with `Duration::zero()`

* Truncate any nanoseconds from a supplied `Duration` within `Cookie::set_max_age` to ensure two Cookies with the same amount whole seconds equate to one another

* Fix the actix-http:🍪:do_not_panic_on_large_max_ages test

* Convert `Cookie::max_age` and `Cookie::expires` examples to `time` 0.2

Mainly minor  changes. Type inference can be used alongside the new
`time::parse` method, such that the type doesn't need to be specified.
This will be useful if a refactoring takes place that changes the type.
There are also new macros, which are used where possible.

One change that is not immediately obvious, in `HttpDate`, there was an
unnecessary conditional. As the time crate allows for negative durations
(and can perform arithmetic with such), the if/else can be removed
entirely.

Time v0.2.3 also has some bug fixes, which is why I am not using a more
general v0.2 in Cargo.toml.

v0.2.3 has been yanked, as it was backwards imcompatible. This version
reverts the breaking change, while still supporting rustc back to
1.34.0.

* Add missing `time::offset` macro import

* Fix type confusion when using `time::parse` followed by `using_offset`

* Update `time` to 0.2.5

* Update CHANGES.md

Co-authored-by: Jacob Pratt <the.z.cuber@gmail.com>
2020-01-28 20:44:22 +09:00
Kai Ren
cdba30d45f Skip empty chucks for BodyStream and SizedStream ()
* Skip empty chucks for BodyStream and SizedStream when streaming response ()

* Fix tests to fail on previous implementation

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-28 18:28:09 +09:00
Aaron Hill
74dcc7366d Remove several uses of Pin::new_unchecked ()
Most of the relevant struct already had a `#[pin_project]` attribute,
but it wasn't being used.

The remaining uses of `Pin::new_unchecked` all involve going from a
`&mut T` to a `Pin<&mut T>`, without directly observing a `Pin<&mut T>`
first. As such, they cannot be replaced by `pin_project`

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-28 12:35:51 +09:00
Maxim Vorobjov
8888520d83 Add benchmark for full stack request lifecycle ()
* add benchmark for full stack request lifecycle

* add direct service benchmarks

* fix newline

* add cloneable service benchmarks

* remove cloneable bench experiments + cargo fmt

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-25 08:05:25 +09:00
Maxim Vorobjov
58844874a0 Fixing convert UnsafeCell to RefCell in CloneableService ()
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2020-01-24 14:51:38 +09:00
Rob Ede
a3287948d1 allow explicit SameSite=None cookies ()
fixes 
2020-01-23 10:08:23 +09:00