mirrors/actix-web
1
0
Fork 0
mirror of https://github.com/actix/actix-web.git synced 2025-01-02 05:18:44 +00:00
Code Issues Projects Releases Wiki Activity

clippy warnings

Browse source
This commit is contained in:
Nikolay Kim 2018-07-05 13:16:16 +06:00
parent 05a43a855e
commit 8058d15624
4 changed files with 19 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/client/connector.rs
View file

@ -1007,22 +1007,22 @@ impl Protocol {
}
}
fn is_http(&self) -> bool {
match *self {
fn is_http(self) -> bool {
match self {
Protocol::Https | Protocol::Http => true,
_ => false,
}
}
fn is_secure(&self) -> bool {
match *self {
fn is_secure(self) -> bool {
match self {
Protocol::Https | Protocol::Wss => true,
_ => false,
}
}
fn port(&self) -> u16 {
match *self {
fn port(self) -> u16 {
match self {
Protocol::Http | Protocol::Ws => 80,
Protocol::Https | Protocol::Wss => 443,
}

12
src/header/mod.rs
View file

@ -129,8 +129,8 @@ pub enum ContentEncoding {
impl ContentEncoding {
#[inline]
/// Is the content compressed?
pub fn is_compression(&self) -> bool {
match *self {
pub fn is_compression(self) -> bool {
match self {
ContentEncoding::Identity | ContentEncoding::Auto => false,
_ => true,
}
@ -138,8 +138,8 @@ impl ContentEncoding {
#[inline]
/// Convert content encoding to string
pub fn as_str(&self) -> &'static str {
match *self {
pub fn as_str(self) -> &'static str {
match self {
#[cfg(feature = "brotli")]
ContentEncoding::Br => "br",
#[cfg(feature = "flate2")]
@ -152,8 +152,8 @@ impl ContentEncoding {
#[inline]
/// default quality value
pub fn quality(&self) -> f64 {
match *self {
pub fn quality(self) -> f64 {
match self {
#[cfg(feature = "brotli")]
ContentEncoding::Br => 1.1,
#[cfg(feature = "flate2")]

4
src/server/h1decoder.rs
View file

@ -130,7 +130,6 @@ impl H1Decoder {
if let Ok(name) =
HeaderName::from_bytes(&slice[idx.name.0..idx.name.1])
{
has_upgrade = has_upgrade || name == header::UPGRADE;
// Unsafe: httparse check header value for valid utf-8
let value = unsafe {
HeaderValue::from_shared_unchecked(
@ -176,6 +175,9 @@ impl H1Decoder {
};
inner.flags.get_mut().set(MessageFlags::KEEPALIVE, ka);
}
header::UPGRADE => {
has_upgrade = true;
}
_ => (),
}

5
src/server/h1writer.rs
View file

@ -204,9 +204,12 @@ impl<T: AsyncWrite, H: 'static> Writer for H1Writer<T, H> {
ResponseLength::None => (),
_ => continue,
},
DATE => {
has_date = true;
}
_ => (),
}
has_date = has_date || key == DATE;
let v = value.as_ref();
let k = key.as_str().as_bytes();
let len = k.len() + v.len() + 4;