update actix; update examples

examples/multipart/src/main.rs

@@ -18,8 +18,13 @@ impl Route for MyRoute {
     fn request(req: HttpRequest, payload: Payload, ctx: &mut HttpContext<Self>) -> Reply<Self> {
         println!("{:?}", req);
 
+        let multipart = match req.multipart(payload) {
+            Ok(mp) => mp,
+            Err(e) => return Reply::reply(e),
+        };
+
         // get Multipart stream
-        WrapStream::<MyRoute>::actstream(req.multipart(payload)?)
+        WrapStream::<MyRoute>::actstream(multipart)
             .and_then(|item, act, ctx| {
                 // Multipart stream is a stream of Fields and nested Multiparts
                 match item {

examples/websocket-chat/src/client.rs

@@ -58,6 +58,11 @@ struct ChatClient;
 
 struct ClientCommand(String);
 
+impl ResponseType for ClientCommand {
+    type Item = ();
+    type Error = ();
+}
+
 impl Actor for ChatClient {
     type Context = FramedContext<Self>;
 
@@ -112,11 +117,6 @@ impl Handler<ClientCommand> for ChatClient
     }
 }
 
-impl ResponseType<ClientCommand> for ChatClient {
-    type Item = ();
-    type Error = ();
-}
-
 /// Server communication
 
 impl FramedActor for ChatClient {
@@ -134,11 +134,6 @@ impl StreamHandler<codec::ChatResponse, io::Error> for ChatClient {
     }
 }
 
-impl ResponseType<codec::ChatResponse> for ChatClient {
-    type Item = ();
-    type Error = ();
-}
-
 impl Handler<codec::ChatResponse, io::Error> for ChatClient {
 
     fn handle(&mut self, msg: codec::ChatResponse, _: &mut FramedContext<Self>)

examples/websocket-chat/src/codec.rs

@@ -4,7 +4,7 @@ use serde_json as json;
 use byteorder::{BigEndian , ByteOrder};
 use bytes::{BytesMut, BufMut};
 use tokio_io::codec::{Encoder, Decoder};
-
+use actix::ResponseType;
 
 /// Client request
 #[derive(Serialize, Deserialize, Debug)]
@@ -20,6 +20,11 @@ pub enum ChatRequest {
     Ping
 }
 
+impl ResponseType for ChatRequest {
+    type Item = ();
+    type Error = ();
+}
+
 /// Server response
 #[derive(Serialize, Deserialize, Debug)]
 #[serde(tag="cmd", content="data")]
@@ -36,6 +41,10 @@ pub enum ChatResponse {
     Message(String),
 }
 
+impl ResponseType for ChatResponse {
+    type Item = ();
+    type Error = ();
+}
 
 /// Codec for Client -> Server transport
 pub struct ChatCodec;

examples/websocket-chat/src/main.rs

@@ -2,6 +2,7 @@
 extern crate rand;
 extern crate bytes;
 extern crate byteorder;
+extern crate futures;
 extern crate tokio_io;
 extern crate tokio_core;
 extern crate env_logger;
@@ -78,11 +79,6 @@ impl Handler<session::Message> for WsChatSession {
     }
 }
 
-impl ResponseType<session::Message> for WsChatSession {
-    type Item = ();
-    type Error = ();
-}
-
 /// WebSocket message handler
 impl Handler<ws::Message> for WsChatSession {
     fn handle(&mut self, msg: ws::Message, ctx: &mut HttpContext<Self>)
@@ -194,11 +190,6 @@ impl StreamHandler<ws::Message> for WsChatSession
     }
 }
 
-impl ResponseType<ws::Message> for WsChatSession {
-    type Item = ();
-    type Error = ();
-}
-
 
 fn main() {
     let _ = env_logger::init();

examples/websocket-chat/src/server.rs

@@ -16,11 +16,24 @@ pub struct Connect {
     pub addr: Box<Subscriber<session::Message> + Send>,
 }
 
+/// Response type for Connect message
+///
+/// Chat server returns unique session id
+impl ResponseType for Connect  {
+    type Item = usize;
+    type Error = ();
+}
+
 /// Session is disconnected
 pub struct Disconnect {
     pub id: usize,
 }
 
+impl ResponseType for Disconnect {
+    type Item = ();
+    type Error = ();
+}
+
 /// Send message to specific room
 pub struct Message {
     /// Id of the client session
@@ -31,9 +44,19 @@ pub struct Message {
     pub room: String,
 }
 
+impl ResponseType for Message {
+    type Item = ();
+    type Error = ();
+}
+
 /// List of available rooms
 pub struct ListRooms;
 
+impl ResponseType for ListRooms {
+    type Item = Vec<String>;
+    type Error = ();
+}
+
 /// Join room, if room does not exists create new one.
 pub struct Join {
     /// Client id
@@ -42,6 +65,11 @@ pub struct Join {
     pub name: String,
 }
 
+impl ResponseType for Join {
+    type Item = ();
+    type Error = ();
+}
+
 /// `ChatServer` manages chat rooms and responsible for coordinating chat session.
 /// implementation is super primitive
 pub struct ChatServer {
@@ -109,15 +137,6 @@ impl Handler<Connect> for ChatServer {
     }
 }
 
-impl ResponseType<Connect> for ChatServer {
-    /// Response type for Connect message
-    ///
-    /// Chat server returns unique session id
-    type Item = usize;
-    type Error = ();
-}
-
-
 /// Handler for Disconnect message.
 impl Handler<Disconnect> for ChatServer {
 
@@ -144,11 +163,6 @@ impl Handler<Disconnect> for ChatServer {
     }
 }
 
-impl ResponseType<Disconnect> for ChatServer {
-    type Item = ();
-    type Error = ();
-}
-
 /// Handler for Message message.
 impl Handler<Message> for ChatServer {
 
@@ -159,11 +173,6 @@ impl Handler<Message> for ChatServer {
     }
 }
 
-impl ResponseType<Message> for ChatServer {
-    type Item = ();
-    type Error = ();
-}
-
 /// Handler for `ListRooms` message.
 impl Handler<ListRooms> for ChatServer {
 
@@ -178,11 +187,6 @@ impl Handler<ListRooms> for ChatServer {
     }
 }
 
-impl ResponseType<ListRooms> for ChatServer {
-    type Item = Vec<String>;
-    type Error = ();
-}
-
 /// Join room, send disconnect message to old room
 /// send join message to new room
 impl Handler<Join> for ChatServer {
@@ -211,8 +215,3 @@ impl Handler<Join> for ChatServer {
         Self::empty()
     }
 }
-
-impl ResponseType<Join> for ChatServer {
-    type Item = ();
-    type Error = ();
-}

examples/websocket-chat/src/session.rs

@@ -3,6 +3,7 @@
 use std::{io, net};
 use std::str::FromStr;
 use std::time::{Instant, Duration};
+use futures::Stream;
 use tokio_core::net::{TcpStream, TcpListener};
 
 use actix::*;
@@ -14,6 +15,10 @@ use codec::{ChatRequest, ChatResponse, ChatCodec};
 /// Chat server sends this messages to session
 pub struct Message(pub String);
 
+impl ResponseType for Message {
+    type Item = ();
+    type Error = ();
+}
 
 /// `ChatSession` actor is responsible for tcp peer communitions.
 pub struct ChatSession {
@@ -68,11 +73,6 @@ impl StreamHandler<ChatRequest, io::Error> for ChatSession {
     }
 }
 
-impl ResponseType<ChatRequest> for ChatSession {
-    type Item = ();
-    type Error = ();
-}
-
 impl Handler<ChatRequest, io::Error> for ChatSession {
 
     /// We'll stop chat session actor on any error, high likely it is just
@@ -137,12 +137,6 @@ impl Handler<Message> for ChatSession {
     }
 }
 
-impl ResponseType<Message> for ChatSession {
-    type Item = ();
-    type Error = ();
-}
-
-
 /// Helper methods
 impl ChatSession {
 
@@ -194,7 +188,7 @@ impl TcpServer {
         // So to be able to handle this events `Server` actor has to implement
         // stream handler `StreamHandler<(TcpStream, net::SocketAddr), io::Error>`
         let _: () = TcpServer::create(|ctx| {
-            ctx.add_stream(listener.incoming());
+            ctx.add_stream(listener.incoming().map(|(t, a)| TcpConnect(t, a)));
             TcpServer{chat: chat}
         });
     }
@@ -206,18 +200,19 @@ impl Actor for TcpServer {
     type Context = Context<Self>;
 }
 
-/// Handle stream of TcpStream's
-impl StreamHandler<(TcpStream, net::SocketAddr), io::Error> for TcpServer {}
+struct TcpConnect(TcpStream, net::SocketAddr);
 
-impl ResponseType<(TcpStream, net::SocketAddr)> for TcpServer {
+impl ResponseType for TcpConnect {
     type Item = ();
     type Error = ();
 }
 
-impl Handler<(TcpStream, net::SocketAddr), io::Error> for TcpServer {
+/// Handle stream of TcpStream's
+impl StreamHandler<TcpConnect, io::Error> for TcpServer {}
 
-    fn handle(&mut self, msg: (TcpStream, net::SocketAddr), _: &mut Context<Self>)
-              -> Response<Self, (TcpStream, net::SocketAddr)>
+impl Handler<TcpConnect, io::Error> for TcpServer {
+
+    fn handle(&mut self, msg: TcpConnect, _: &mut Context<Self>) -> Response<Self, TcpConnect>
     {
         // For each incoming connection we create `ChatSession` actor
         // with out chat server address.

examples/websocket/src/main.rs

@@ -30,12 +30,15 @@ impl Route for MyWebSocket {
     }
 }
 
-impl ResponseType<ws::Message> for MyWebSocket {
-    type Item = ();
-    type Error = ();
-}
+impl StreamHandler<ws::Message> for MyWebSocket {
+    fn started(&mut self, ctx: &mut Self::Context) {
+        println!("WebSocket session openned");
+    }
 
-impl StreamHandler<ws::Message> for MyWebSocket {}
+    fn finished(&mut self, ctx: &mut Self::Context) {
+        println!("WebSocket session closed");
+    }
+}
 
 impl Handler<ws::Message> for MyWebSocket {
     fn handle(&mut self, msg: ws::Message, ctx: &mut HttpContext<Self>)

src/context.rs

@@ -20,6 +20,7 @@ pub struct HttpContext<A> where A: Actor<Context=HttpContext<A>> + Route,
 {
     act: Option<A>,
     state: ActorState,
+    modified: bool,
     items: ActorItemsCell<A>,
     address: ActorAddressCell<A>,
     stream: VecDeque<Frame>,
@@ -57,16 +58,19 @@ impl<A> AsyncContext<A> for HttpContext<A> where A: Actor<Context=Self> + Route
     fn spawn<F>(&mut self, fut: F) -> SpawnHandle
         where F: ActorFuture<Item=(), Error=(), Actor=A> + 'static
     {
+        self.modified = true;
         self.items.spawn(fut)
     }
 
     fn wait<F>(&mut self, fut: F)
         where F: ActorFuture<Item=(), Error=(), Actor=A> + 'static
     {
+        self.modified = true;
         self.wait.add(fut);
     }
 
     fn cancel_future(&mut self, handle: SpawnHandle) -> bool {
+        self.modified = true;
         self.items.cancel_future(handle)
     }
 }
@@ -85,6 +89,7 @@ impl<A> HttpContext<A> where A: Actor<Context=Self> + Route {
         HttpContext {
             act: None,
             state: ActorState::Started,
+            modified: false,
             items: ActorItemsCell::default(),
             address: ActorAddressCell::default(),
             wait: ActorWaitCell::default(),
@@ -124,17 +129,19 @@ impl<A> HttpContext<A> where A: Actor<Context=Self> + Route {
 impl<A> HttpContext<A> where A: Actor<Context=Self> + Route {
 
     #[doc(hidden)]
-    pub fn subscriber<M: 'static>(&mut self) -> Box<Subscriber<M>>
-        where A: Handler<M>
+    pub fn subscriber<M>(&mut self) -> Box<Subscriber<M>>
+        where A: Handler<M>,
+              M: ResponseType + 'static,
     {
         Box::new(self.address.unsync_address())
     }
 
     #[doc(hidden)]
-    pub fn sync_subscriber<M: 'static + Send>(&mut self) -> Box<Subscriber<M> + Send>
+    pub fn sync_subscriber<M>(&mut self) -> Box<Subscriber<M> + Send>
         where A: Handler<M>,
-              A::Item: Send,
-              A::Error: Send,
+              M: ResponseType + Send + 'static,
+              M::Item: Send,
+              M::Error: Send,
     {
         Box::new(self.address.sync_address())
     }
@@ -170,28 +177,23 @@ impl<A> Stream for HttpContext<A> where A: Actor<Context=Self> + Route
             _ => ()
         }
 
-        // check wait futures
-        if self.wait.poll(act, ctx) {
-            return Ok(Async::NotReady)
-        }
-
         let mut prep_stop = false;
         loop {
-            let mut not_ready = true;
-
-            if self.address.poll(act, ctx) {
-                not_ready = false
-            }
-
-            self.items.poll(act, ctx);
+            self.modified = false;
 
             // check wait futures
             if self.wait.poll(act, ctx) {
                 return Ok(Async::NotReady)
             }
 
+            // incoming messages
+            self.address.poll(act, ctx);
+
+            // spawned futures and streams
+            self.items.poll(act, ctx);
+
             // are we done
-            if !not_ready {
+            if self.modified {
                 continue
             }
 
@@ -239,15 +241,13 @@ impl<A> Stream for HttpContext<A> where A: Actor<Context=Self> + Route
     }
 }
 
-type ToEnvelopeSender<A, M> =
-    Sender<Result<<A as ResponseType<M>>::Item, <A as ResponseType<M>>::Error>>;
-
 impl<A, M> ToEnvelope<A, M> for HttpContext<A>
-    where M: Send + 'static,
-          A: Actor<Context=HttpContext<A>> + Route + Handler<M>,
-          <A as ResponseType<M>>::Item: Send, <A as ResponseType<M>>::Item: Send
+    where A: Actor<Context=HttpContext<A>> + Route + Handler<M>,
+          M: ResponseType + Send + 'static,
+          M::Item: Send,
+          M::Error: Send,
 {
-    fn pack(msg: M, tx: Option<ToEnvelopeSender<A, M>>) -> Envelope<A>
+    fn pack(msg: M, tx: Option<Sender<Result<M::Item, M::Error>>>) -> Envelope<A>
     {
         RemoteEnvelope::new(msg, tx).into()
     }

src/server.rs

@@ -46,7 +46,7 @@ impl<T, A> HttpServer<T, A>
               S: Stream<Item=(T, A), Error=io::Error> + 'static
     {
         Ok(HttpServer::create(move |ctx| {
-            ctx.add_stream(stream);
+            ctx.add_stream(stream.map(|(t, a)| IoStream(t, a)));
             self
         }))
     }
@@ -81,7 +81,7 @@ impl HttpServer<TcpStream, net::SocketAddr> {
         } else {
             Ok(HttpServer::create(move |ctx| {
                 for tcp in addrs {
-                    ctx.add_stream(tcp.incoming());
+                    ctx.add_stream(tcp.incoming().map(|(t, a)| IoStream(t, a)));
                 }
                 self
             }))
@@ -89,7 +89,9 @@ impl HttpServer<TcpStream, net::SocketAddr> {
     }
 }
 
-impl<T, A> ResponseType<(T, A)> for HttpServer<T, A>
+struct IoStream<T, A>(T, A);
+
+impl<T, A> ResponseType for IoStream<T, A>
     where T: AsyncRead + AsyncWrite + 'static,
           A: 'static
 {
@@ -97,16 +99,15 @@ impl<T, A> ResponseType<(T, A)> for HttpServer<T, A>
     type Error = ();
 }
 
-impl<T, A> StreamHandler<(T, A), io::Error> for HttpServer<T, A>
-    where T: AsyncRead + AsyncWrite + 'static,
-          A: 'static {
-}
+impl<T, A> StreamHandler<IoStream<T, A>, io::Error> for HttpServer<T, A>
+    where T: AsyncRead + AsyncWrite + 'static, A: 'static {}
 
-impl<T, A> Handler<(T, A), io::Error> for HttpServer<T, A>
+impl<T, A> Handler<IoStream<T, A>, io::Error> for HttpServer<T, A>
     where T: AsyncRead + AsyncWrite + 'static,
           A: 'static
 {
-    fn handle(&mut self, msg: (T, A), _: &mut Context<Self>) -> Response<Self, (T, A)>
+    fn handle(&mut self, msg: IoStream<T, A>, _: &mut Context<Self>)
+              -> Response<Self, IoStream<T, A>>
     {
         Arbiter::handle().spawn(
             HttpChannel{router: Rc::clone(&self.router),

src/ws.rs

@@ -69,7 +69,7 @@ use http::{Method, StatusCode, header};
 use bytes::{Bytes, BytesMut};
 use futures::{Async, Poll, Stream};
 
-use actix::Actor;
+use actix::{Actor, ResponseType};
 
 use context::HttpContext;
 use route::Route;
@@ -103,6 +103,11 @@ pub enum Message {
     Error
 }
 
+impl ResponseType for Message {
+    type Item = ();
+    type Error = ();
+}
+
 /// Prepare `WebSocket` handshake response.
 ///
 /// This function returns handshake `HttpResponse`, ready to send to peer.