1
0
Fork 0
mirror of https://github.com/actix/actix-web.git synced 2024-06-02 21:39:26 +00:00
actix-web/actix-http/src/h1/dispatcher.rs

715 lines
24 KiB
Rust
Raw Normal View History

2018-10-04 23:22:00 +00:00
use std::collections::VecDeque;
2018-11-17 05:09:33 +00:00
use std::mem;
2018-10-05 06:39:11 +00:00
use std::time::Instant;
2018-10-04 23:22:00 +00:00
2018-12-11 02:08:33 +00:00
use actix_codec::{AsyncRead, AsyncWrite, Framed};
use actix_service::Service;
use actix_utils::cloneable::CloneableService;
2018-12-06 22:32:52 +00:00
use bitflags::bitflags;
use futures::{Async, Future, Poll, Sink, Stream};
2018-12-06 22:32:52 +00:00
use log::{debug, error, trace};
2018-10-05 06:39:11 +00:00
use tokio_timer::Delay;
2018-10-04 23:22:00 +00:00
2019-03-27 16:24:55 +00:00
use crate::body::{Body, BodySize, MessageBody, ResponseBody};
2018-12-06 22:32:52 +00:00
use crate::config::ServiceConfig;
2019-04-05 23:46:44 +00:00
use crate::error::{DispatchError, Error};
2018-12-06 22:32:52 +00:00
use crate::error::{ParseError, PayloadError};
2019-04-05 23:46:44 +00:00
use crate::http::StatusCode;
2018-12-06 22:32:52 +00:00
use crate::request::Request;
use crate::response::Response;
2018-10-05 03:02:10 +00:00
use super::codec::Codec;
use super::payload::{Payload, PayloadSender, PayloadStatus, PayloadWriter};
2019-03-07 06:56:34 +00:00
use super::{Message, MessageType};
2018-10-04 23:22:00 +00:00
const MAX_PIPELINED_MESSAGES: usize = 16;
bitflags! {
pub struct Flags: u8 {
const STARTED = 0b0000_0001;
const KEEPALIVE_ENABLED = 0b0000_0010;
const KEEPALIVE = 0b0000_0100;
2018-10-07 16:48:53 +00:00
const POLLED = 0b0000_1000;
const SHUTDOWN = 0b0010_0000;
const DISCONNECTED = 0b0100_0000;
const DROPPING = 0b1000_0000;
2018-10-04 23:22:00 +00:00
}
}
/// Dispatcher for HTTP/1.1 protocol
2019-04-05 23:46:44 +00:00
pub struct Dispatcher<T, S, B, X>
2018-11-17 05:09:33 +00:00
where
2019-04-05 23:46:44 +00:00
S: Service<Request = Request>,
S::Error: Into<Error>,
B: MessageBody,
X: Service<Request = Request, Response = Request>,
X::Error: Into<Error>,
2018-11-17 05:09:33 +00:00
{
2019-04-05 23:46:44 +00:00
inner: Option<InnerDispatcher<T, S, B, X>>,
2018-11-17 05:09:33 +00:00
}
2019-04-05 23:46:44 +00:00
struct InnerDispatcher<T, S, B, X>
2018-10-04 23:22:00 +00:00
where
2019-04-05 23:46:44 +00:00
S: Service<Request = Request>,
S::Error: Into<Error>,
B: MessageBody,
X: Service<Request = Request, Response = Request>,
X::Error: Into<Error>,
2018-10-04 23:22:00 +00:00
{
service: CloneableService<S>,
2019-04-05 23:46:44 +00:00
expect: CloneableService<X>,
2018-10-04 23:22:00 +00:00
flags: Flags,
2018-11-17 05:09:33 +00:00
framed: Framed<T, Codec>,
2019-03-07 06:56:34 +00:00
error: Option<DispatchError>,
2018-10-05 06:39:11 +00:00
config: ServiceConfig,
2018-10-04 23:22:00 +00:00
2019-04-05 23:46:44 +00:00
state: State<S, B, X>,
2018-10-05 14:02:09 +00:00
payload: Option<PayloadSender>,
messages: VecDeque<DispatcherMessage>,
2018-10-05 04:14:18 +00:00
2018-10-05 06:39:11 +00:00
ka_expire: Instant,
ka_timer: Option<Delay>,
2018-10-04 23:22:00 +00:00
}
enum DispatcherMessage {
2018-10-07 04:07:32 +00:00
Item(Request),
Error(Response<()>),
2018-10-07 04:07:32 +00:00
}
2019-04-05 23:46:44 +00:00
enum State<S, B, X>
where
S: Service<Request = Request>,
X: Service<Request = Request, Response = Request>,
B: MessageBody,
{
2018-10-04 23:22:00 +00:00
None,
2019-04-05 23:46:44 +00:00
ExpectCall(X::Future),
2018-10-07 07:04:38 +00:00
ServiceCall(S::Future),
2018-11-21 15:49:24 +00:00
SendPayload(ResponseBody<B>),
2018-10-04 23:22:00 +00:00
}
2019-04-05 23:46:44 +00:00
impl<S, B, X> State<S, B, X>
where
S: Service<Request = Request>,
X: Service<Request = Request, Response = Request>,
B: MessageBody,
{
2018-10-04 23:22:00 +00:00
fn is_empty(&self) -> bool {
if let State::None = self {
true
} else {
false
}
}
}
2019-04-05 23:46:44 +00:00
impl<T, S, B, X> Dispatcher<T, S, B, X>
2018-10-04 23:22:00 +00:00
where
2018-10-05 03:02:10 +00:00
T: AsyncRead + AsyncWrite,
2019-04-04 17:59:34 +00:00
S: Service<Request = Request>,
2019-04-05 23:46:44 +00:00
S::Error: Into<Error>,
S::Response: Into<Response<B>>,
2018-11-18 04:21:28 +00:00
B: MessageBody,
2019-04-05 23:46:44 +00:00
X: Service<Request = Request, Response = Request>,
X::Error: Into<Error>,
2018-10-04 23:22:00 +00:00
{
2018-10-05 03:02:10 +00:00
/// Create http/1 dispatcher.
2019-04-05 23:46:44 +00:00
pub fn new(
stream: T,
config: ServiceConfig,
service: CloneableService<S>,
expect: CloneableService<X>,
) -> Self {
2019-03-07 06:56:34 +00:00
Dispatcher::with_timeout(
Framed::new(stream, Codec::new(config.clone())),
config,
None,
service,
2019-04-05 23:46:44 +00:00
expect,
2019-03-07 06:56:34 +00:00
)
2018-10-05 06:39:11 +00:00
}
/// Create http/1 dispatcher with slow request timeout.
pub fn with_timeout(
2019-03-07 06:56:34 +00:00
framed: Framed<T, Codec>,
2018-10-29 23:39:46 +00:00
config: ServiceConfig,
timeout: Option<Delay>,
service: CloneableService<S>,
2019-04-05 23:46:44 +00:00
expect: CloneableService<X>,
2018-10-05 06:39:11 +00:00
) -> Self {
2018-10-05 17:03:10 +00:00
let keepalive = config.keep_alive_enabled();
let flags = if keepalive {
2018-11-19 01:52:56 +00:00
Flags::KEEPALIVE | Flags::KEEPALIVE_ENABLED
2018-10-05 06:39:11 +00:00
} else {
2018-11-19 01:52:56 +00:00
Flags::empty()
2018-10-05 06:39:11 +00:00
};
2018-10-04 23:22:00 +00:00
2018-10-08 22:24:51 +00:00
// keep-alive timer
2018-10-05 06:39:11 +00:00
let (ka_expire, ka_timer) = if let Some(delay) = timeout {
(delay.deadline(), Some(delay))
} else if let Some(delay) = config.keep_alive_timer() {
(delay.deadline(), Some(delay))
} else {
(config.now(), None)
};
2018-10-05 03:02:10 +00:00
Dispatcher {
2018-11-17 05:09:33 +00:00
inner: Some(InnerDispatcher {
framed,
payload: None,
state: State::None,
error: None,
messages: VecDeque::new(),
service,
2019-04-05 23:46:44 +00:00
expect,
2018-11-17 05:09:33 +00:00
flags,
config,
ka_expire,
ka_timer,
}),
2018-10-04 23:22:00 +00:00
}
}
2018-11-17 05:09:33 +00:00
}
2018-10-04 23:22:00 +00:00
2019-04-05 23:46:44 +00:00
impl<T, S, B, X> InnerDispatcher<T, S, B, X>
2018-11-17 05:09:33 +00:00
where
T: AsyncRead + AsyncWrite,
2019-04-04 17:59:34 +00:00
S: Service<Request = Request>,
2019-04-05 23:46:44 +00:00
S::Error: Into<Error>,
S::Response: Into<Response<B>>,
2018-11-18 04:21:28 +00:00
B: MessageBody,
2019-04-05 23:46:44 +00:00
X: Service<Request = Request, Response = Request>,
X::Error: Into<Error>,
2018-11-17 05:09:33 +00:00
{
2018-10-04 23:22:00 +00:00
fn can_read(&self) -> bool {
2018-10-07 16:48:53 +00:00
if self.flags.contains(Flags::DISCONNECTED) {
2018-10-04 23:22:00 +00:00
return false;
}
if let Some(ref info) = self.payload {
info.need_read() == PayloadStatus::Read
} else {
true
}
}
// if checked is set to true, delay disconnect until all tasks have finished.
2018-10-07 04:07:32 +00:00
fn client_disconnected(&mut self) {
2018-10-07 16:48:53 +00:00
self.flags.insert(Flags::DISCONNECTED);
2018-10-04 23:22:00 +00:00
if let Some(mut payload) = self.payload.take() {
payload.set_error(PayloadError::Incomplete(None));
2018-10-04 23:22:00 +00:00
}
}
/// Flush stream
2019-03-07 06:56:34 +00:00
fn poll_flush(&mut self) -> Poll<bool, DispatchError> {
2018-11-19 01:52:56 +00:00
if !self.framed.is_write_buf_empty() {
2018-11-17 05:09:33 +00:00
match self.framed.poll_complete() {
2018-10-04 23:22:00 +00:00
Ok(Async::NotReady) => Ok(Async::NotReady),
Err(err) => {
debug!("Error sending data: {}", err);
Err(err.into())
}
Ok(Async::Ready(_)) => {
// if payload is not consumed we can not use connection
if self.payload.is_some() && self.state.is_empty() {
2018-10-05 03:02:10 +00:00
return Err(DispatchError::PayloadIsNotConsumed);
2018-10-04 23:22:00 +00:00
}
Ok(Async::Ready(true))
2018-10-04 23:22:00 +00:00
}
}
} else {
Ok(Async::Ready(false))
2018-10-04 23:22:00 +00:00
}
}
2018-11-21 15:49:24 +00:00
fn send_response(
2018-11-17 05:09:33 +00:00
&mut self,
message: Response<()>,
2018-11-21 15:49:24 +00:00
body: ResponseBody<B>,
2019-04-05 23:46:44 +00:00
) -> Result<State<S, B, X>, DispatchError> {
2018-11-17 05:09:33 +00:00
self.framed
2018-11-19 01:52:56 +00:00
.force_send(Message::Item((message, body.length())))
2018-11-17 05:09:33 +00:00
.map_err(|err| {
if let Some(mut payload) = self.payload.take() {
payload.set_error(PayloadError::Incomplete(None));
}
DispatchError::Io(err)
})?;
self.flags
.set(Flags::KEEPALIVE, self.framed.get_codec().keepalive());
2018-11-18 04:21:28 +00:00
match body.length() {
2019-03-27 16:24:55 +00:00
BodySize::None | BodySize::Empty => Ok(State::None),
2018-11-18 04:21:28 +00:00
_ => Ok(State::SendPayload(body)),
2018-11-17 05:09:33 +00:00
}
}
2019-04-05 23:46:44 +00:00
fn send_continue(&mut self) -> Result<(), DispatchError> {
self.framed
.force_send(Message::Item((
Response::empty(StatusCode::CONTINUE),
BodySize::Empty,
)))
.map_err(|err| DispatchError::Io(err))
}
2019-03-07 06:56:34 +00:00
fn poll_response(&mut self) -> Result<(), DispatchError> {
2018-10-04 23:22:00 +00:00
let mut retry = self.can_read();
loop {
2018-11-17 05:09:33 +00:00
let state = match mem::replace(&mut self.state, State::None) {
State::None => match self.messages.pop_front() {
Some(DispatcherMessage::Item(req)) => {
Some(self.handle_request(req)?)
2018-10-29 23:39:46 +00:00
}
2018-11-17 05:09:33 +00:00
Some(DispatcherMessage::Error(res)) => {
2018-11-21 15:49:24 +00:00
self.send_response(res, ResponseBody::Other(Body::Empty))?;
2018-11-18 04:21:28 +00:00
None
2018-11-17 05:09:33 +00:00
}
None => None,
2018-10-04 23:22:00 +00:00
},
2019-04-05 23:46:44 +00:00
State::ExpectCall(mut fut) => match fut.poll() {
Ok(Async::Ready(req)) => {
self.send_continue()?;
Some(State::ServiceCall(self.service.call(req)))
}
Ok(Async::NotReady) => {
self.state = State::ExpectCall(fut);
None
}
Err(e) => {
let e = e.into();
let res: Response = e.into();
let (res, body) = res.replace_body(());
Some(self.send_response(res, body.into_body())?)
}
},
2019-03-11 23:42:33 +00:00
State::ServiceCall(mut fut) => match fut.poll() {
Ok(Async::Ready(res)) => {
let (res, body) = res.into().replace_body(());
Some(self.send_response(res, body)?)
2018-10-04 23:22:00 +00:00
}
2019-03-11 23:42:33 +00:00
Ok(Async::NotReady) => {
self.state = State::ServiceCall(fut);
None
}
Err(_e) => {
let res: Response = Response::InternalServerError().finish();
let (res, body) = res.replace_body(());
Some(self.send_response(res, body.into_body())?)
}
},
2018-11-17 05:09:33 +00:00
State::SendPayload(mut stream) => {
2018-11-14 18:52:40 +00:00
loop {
2018-11-17 05:09:33 +00:00
if !self.framed.is_write_buf_full() {
2018-11-18 04:21:28 +00:00
match stream
.poll_next()
.map_err(|_| DispatchError::Unknown)?
{
2018-11-14 18:52:40 +00:00
Async::Ready(Some(item)) => {
2018-11-17 05:09:33 +00:00
self.framed
.force_send(Message::Chunk(Some(item)))?;
2018-10-08 22:24:51 +00:00
continue;
}
2018-11-14 18:52:40 +00:00
Async::Ready(None) => {
2018-11-17 05:09:33 +00:00
self.framed.force_send(Message::Chunk(None))?;
}
Async::NotReady => {
self.state = State::SendPayload(stream);
return Ok(());
2018-10-08 22:24:51 +00:00
}
2018-11-14 18:52:40 +00:00
}
} else {
2018-11-17 05:09:33 +00:00
self.state = State::SendPayload(stream);
2018-11-14 18:52:40 +00:00
return Ok(());
2018-10-08 22:24:51 +00:00
}
2018-11-14 18:52:40 +00:00
break;
2018-10-08 22:24:51 +00:00
}
2018-11-14 18:52:40 +00:00
None
2018-10-04 23:22:00 +00:00
}
};
match state {
2018-10-07 05:36:57 +00:00
Some(state) => self.state = state,
2018-10-04 23:22:00 +00:00
None => {
// if read-backpressure is enabled and we consumed some data.
2018-11-17 05:09:33 +00:00
// we may read more data and retry
2018-10-07 16:48:53 +00:00
if !retry && self.can_read() && self.poll_request()? {
2018-10-04 23:22:00 +00:00
retry = self.can_read();
continue;
}
break;
}
}
}
Ok(())
}
2019-04-05 23:46:44 +00:00
fn handle_request(&mut self, req: Request) -> Result<State<S, B, X>, DispatchError> {
// Handle `EXPECT: 100-Continue` header
let req = if req.head().expect() {
let mut task = self.expect.call(req);
match task.poll() {
Ok(Async::Ready(req)) => {
self.send_continue()?;
req
}
Ok(Async::NotReady) => return Ok(State::ExpectCall(task)),
Err(e) => {
let e = e.into();
let res: Response = e.into();
let (res, body) = res.replace_body(());
return self.send_response(res, body.into_body());
}
}
} else {
req
};
// Call service
2018-10-07 05:36:57 +00:00
let mut task = self.service.call(req);
2019-03-11 23:42:33 +00:00
match task.poll() {
Ok(Async::Ready(res)) => {
let (res, body) = res.into().replace_body(());
2018-11-17 05:09:33 +00:00
self.send_response(res, body)
2018-10-07 05:36:57 +00:00
}
2019-03-11 23:42:33 +00:00
Ok(Async::NotReady) => Ok(State::ServiceCall(task)),
Err(_e) => {
let res: Response = Response::InternalServerError().finish();
let (res, body) = res.replace_body(());
self.send_response(res, body.into_body())
}
2018-10-07 05:36:57 +00:00
}
}
2018-10-09 17:36:40 +00:00
/// Process one incoming requests
2019-03-07 06:56:34 +00:00
pub(self) fn poll_request(&mut self) -> Result<bool, DispatchError> {
2018-10-09 17:36:40 +00:00
// limit a mount of non processed requests
if self.messages.len() >= MAX_PIPELINED_MESSAGES {
return Ok(false);
2018-10-04 23:22:00 +00:00
}
let mut updated = false;
2018-10-29 23:39:46 +00:00
loop {
2018-11-17 05:09:33 +00:00
match self.framed.poll() {
2018-10-09 17:36:40 +00:00
Ok(Async::Ready(Some(msg))) => {
updated = true;
self.flags.insert(Flags::STARTED);
match msg {
2019-02-06 19:44:15 +00:00
Message::Item(mut req) => {
2018-11-17 05:09:33 +00:00
match self.framed.get_codec().message_type() {
2019-03-18 04:57:53 +00:00
MessageType::Payload | MessageType::Stream => {
2019-01-29 18:14:00 +00:00
let (ps, pl) = Payload::create(false);
2019-02-13 21:52:11 +00:00
let (req1, _) =
req.replace_payload(crate::Payload::H1(pl));
req = req1;
self.payload = Some(ps);
}
_ => (),
2018-10-09 17:36:40 +00:00
}
2018-10-04 23:22:00 +00:00
2018-10-09 17:36:40 +00:00
// handle request early
if self.state.is_empty() {
self.state = self.handle_request(req)?;
} else {
self.messages.push_back(DispatcherMessage::Item(req));
2018-10-09 17:36:40 +00:00
}
}
Message::Chunk(Some(chunk)) => {
2018-10-09 17:36:40 +00:00
if let Some(ref mut payload) = self.payload {
payload.feed_data(chunk);
} else {
error!(
"Internal server error: unexpected payload chunk"
);
self.flags.insert(Flags::DISCONNECTED);
self.messages.push_back(DispatcherMessage::Error(
Response::InternalServerError().finish().drop_body(),
2018-10-09 17:36:40 +00:00
));
self.error = Some(DispatchError::InternalError);
2018-11-06 03:32:03 +00:00
break;
2018-10-09 17:36:40 +00:00
}
}
Message::Chunk(None) => {
2018-10-09 17:36:40 +00:00
if let Some(mut payload) = self.payload.take() {
payload.feed_eof();
} else {
error!("Internal server error: unexpected eof");
self.flags.insert(Flags::DISCONNECTED);
self.messages.push_back(DispatcherMessage::Error(
Response::InternalServerError().finish().drop_body(),
2018-10-09 17:36:40 +00:00
));
self.error = Some(DispatchError::InternalError);
2018-11-06 03:32:03 +00:00
break;
2018-10-09 17:36:40 +00:00
}
}
2018-10-04 23:22:00 +00:00
}
2018-10-09 17:36:40 +00:00
}
Ok(Async::Ready(None)) => {
self.client_disconnected();
break;
}
Ok(Async::NotReady) => break,
Err(ParseError::Io(e)) => {
self.client_disconnected();
self.error = Some(DispatchError::Io(e));
break;
}
Err(e) => {
if let Some(mut payload) = self.payload.take() {
payload.set_error(PayloadError::EncodingCorrupted);
2018-10-07 16:48:53 +00:00
}
2018-10-04 23:22:00 +00:00
2018-10-09 17:36:40 +00:00
// Malformed requests should be responded with 400
self.messages.push_back(DispatcherMessage::Error(
Response::BadRequest().finish().drop_body(),
));
2018-10-09 17:36:40 +00:00
self.flags.insert(Flags::DISCONNECTED);
self.error = Some(e.into());
break;
2018-10-04 23:22:00 +00:00
}
}
}
2018-10-05 06:39:11 +00:00
if self.ka_timer.is_some() && updated {
if let Some(expire) = self.config.keep_alive_expire() {
self.ka_expire = expire;
}
}
2018-10-04 23:22:00 +00:00
Ok(updated)
}
2018-10-05 06:39:11 +00:00
/// keep-alive timer
2019-03-07 06:56:34 +00:00
fn poll_keepalive(&mut self) -> Result<(), DispatchError> {
2018-11-19 01:52:56 +00:00
if self.ka_timer.is_none() {
// shutdown timeout
if self.flags.contains(Flags::SHUTDOWN) {
if let Some(interval) = self.config.client_disconnect_timer() {
self.ka_timer = Some(Delay::new(interval));
} else {
self.flags.insert(Flags::DISCONNECTED);
return Ok(());
}
} else {
return Ok(());
}
2018-11-17 05:09:33 +00:00
}
2018-11-17 05:09:33 +00:00
match self.ka_timer.as_mut().unwrap().poll().map_err(|e| {
error!("Timer error {:?}", e);
DispatchError::Unknown
})? {
Async::Ready(_) => {
// if we get timeout during shutdown, drop connection
if self.flags.contains(Flags::SHUTDOWN) {
return Err(DispatchError::DisconnectTimeout);
} else if self.ka_timer.as_mut().unwrap().deadline() >= self.ka_expire {
2018-11-20 18:55:50 +00:00
// check for any outstanding tasks
2018-11-19 01:52:56 +00:00
if self.state.is_empty() && self.framed.is_write_buf_empty() {
2018-11-17 05:09:33 +00:00
if self.flags.contains(Flags::STARTED) {
trace!("Keep-alive timeout, close connection");
self.flags.insert(Flags::SHUTDOWN);
// start shutdown timer
if let Some(deadline) = self.config.client_disconnect_timer()
{
2019-01-29 18:14:00 +00:00
if let Some(timer) = self.ka_timer.as_mut() {
2018-11-08 17:30:53 +00:00
timer.reset(deadline);
let _ = timer.poll();
2019-01-29 18:14:00 +00:00
}
2018-10-07 17:09:48 +00:00
} else {
// no shutdown timeout, drop socket
self.flags.insert(Flags::DISCONNECTED);
2018-11-17 05:09:33 +00:00
return Ok(());
2018-10-05 06:39:11 +00:00
}
2018-11-17 05:09:33 +00:00
} else {
// timeout on first request (slow request) return 408
2018-11-20 18:55:50 +00:00
if !self.flags.contains(Flags::STARTED) {
trace!("Slow request timeout");
let _ = self.send_response(
Response::RequestTimeout().finish().drop_body(),
2018-11-21 15:49:24 +00:00
ResponseBody::Other(Body::Empty),
2018-11-20 18:55:50 +00:00
);
} else {
trace!("Keep-alive connection timeout");
}
self.flags.insert(Flags::STARTED | Flags::SHUTDOWN);
2018-11-18 04:21:28 +00:00
self.state = State::None;
2018-11-17 05:09:33 +00:00
}
} else if let Some(deadline) = self.config.keep_alive_expire() {
2019-01-29 18:14:00 +00:00
if let Some(timer) = self.ka_timer.as_mut() {
2018-11-08 17:30:53 +00:00
timer.reset(deadline);
let _ = timer.poll();
2019-01-29 18:14:00 +00:00
}
2018-10-05 06:39:11 +00:00
}
2019-01-29 18:14:00 +00:00
} else if let Some(timer) = self.ka_timer.as_mut() {
timer.reset(self.ka_expire);
let _ = timer.poll();
2018-10-05 06:39:11 +00:00
}
}
2018-11-17 05:09:33 +00:00
Async::NotReady => (),
2018-10-05 06:39:11 +00:00
}
Ok(())
}
2018-10-04 23:22:00 +00:00
}
2019-04-05 23:46:44 +00:00
impl<T, S, B, X> Future for Dispatcher<T, S, B, X>
2018-10-04 23:22:00 +00:00
where
2018-10-05 03:02:10 +00:00
T: AsyncRead + AsyncWrite,
S: Service<Request = Request>,
2019-04-05 23:46:44 +00:00
S::Error: Into<Error>,
S::Response: Into<Response<B>>,
2018-11-18 04:21:28 +00:00
B: MessageBody,
2019-04-05 23:46:44 +00:00
X: Service<Request = Request, Response = Request>,
X::Error: Into<Error>,
2018-10-04 23:22:00 +00:00
{
2019-03-07 06:56:34 +00:00
type Item = ();
type Error = DispatchError;
2018-10-04 23:22:00 +00:00
#[inline]
fn poll(&mut self) -> Poll<Self::Item, Self::Error> {
let inner = self.inner.as_mut().unwrap();
if inner.flags.contains(Flags::SHUTDOWN) {
inner.poll_keepalive()?;
if inner.flags.contains(Flags::DISCONNECTED) {
Ok(Async::Ready(()))
2018-11-17 05:09:33 +00:00
} else {
// try_ready!(inner.poll_flush());
match inner.framed.get_mut().shutdown()? {
Async::Ready(_) => Ok(Async::Ready(())),
Async::NotReady => Ok(Async::NotReady),
}
}
} else {
inner.poll_keepalive()?;
inner.poll_request()?;
loop {
inner.poll_response()?;
if let Async::Ready(false) = inner.poll_flush()? {
break;
2018-11-19 01:52:56 +00:00
}
}
2018-11-19 01:52:56 +00:00
if inner.flags.contains(Flags::DISCONNECTED) {
return Ok(Async::Ready(()));
}
// keep-alive and stream errors
if inner.state.is_empty() && inner.framed.is_write_buf_empty() {
if let Some(err) = inner.error.take() {
2019-03-30 04:13:39 +00:00
Err(err)
}
// disconnect if keep-alive is not enabled
else if inner.flags.contains(Flags::STARTED)
&& !inner.flags.intersects(Flags::KEEPALIVE)
{
inner.flags.insert(Flags::SHUTDOWN);
self.poll()
}
// disconnect if shutdown
else if inner.flags.contains(Flags::SHUTDOWN) {
self.poll()
2018-10-07 16:48:53 +00:00
} else {
2019-03-30 04:13:39 +00:00
Ok(Async::NotReady)
2018-10-04 23:22:00 +00:00
}
} else {
2019-03-30 04:13:39 +00:00
Ok(Async::NotReady)
2018-10-04 23:22:00 +00:00
}
}
2018-10-04 23:22:00 +00:00
}
}
2019-01-29 18:14:00 +00:00
#[cfg(test)]
mod tests {
use std::{cmp, io};
use actix_codec::{AsyncRead, AsyncWrite};
use actix_service::IntoService;
use bytes::{Buf, Bytes};
2019-01-29 18:14:00 +00:00
use futures::future::{lazy, ok};
use super::*;
use crate::error::Error;
2019-04-05 23:46:44 +00:00
use crate::h1::ExpectHandler;
2019-01-29 18:14:00 +00:00
struct Buffer {
buf: Bytes,
err: Option<io::Error>,
}
impl Buffer {
fn new(data: &'static str) -> Buffer {
Buffer {
buf: Bytes::from(data),
err: None,
}
}
}
impl AsyncRead for Buffer {}
impl io::Read for Buffer {
fn read(&mut self, dst: &mut [u8]) -> Result<usize, io::Error> {
if self.buf.is_empty() {
if self.err.is_some() {
Err(self.err.take().unwrap())
} else {
Err(io::Error::new(io::ErrorKind::WouldBlock, ""))
}
} else {
let size = cmp::min(self.buf.len(), dst.len());
let b = self.buf.split_to(size);
dst[..size].copy_from_slice(&b);
Ok(size)
}
}
}
impl io::Write for Buffer {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
Ok(buf.len())
}
fn flush(&mut self) -> io::Result<()> {
Ok(())
}
}
impl AsyncWrite for Buffer {
fn shutdown(&mut self) -> Poll<(), io::Error> {
Ok(Async::Ready(()))
}
fn write_buf<B: Buf>(&mut self, _: &mut B) -> Poll<usize, io::Error> {
Ok(Async::NotReady)
}
}
#[test]
fn test_req_parse_err() {
let mut sys = actix_rt::System::new("test");
let _ = sys.block_on(lazy(|| {
let buf = Buffer::new("GET /test HTTP/1\r\n\r\n");
let mut h1 = Dispatcher::new(
buf,
ServiceConfig::default(),
2019-02-10 05:32:44 +00:00
CloneableService::new(
2019-03-23 16:40:20 +00:00
(|_| ok::<_, Error>(Response::Ok().finish())).into_service(),
2019-02-10 05:32:44 +00:00
),
2019-04-05 23:46:44 +00:00
CloneableService::new(ExpectHandler),
2019-01-29 18:14:00 +00:00
);
assert!(h1.poll().is_ok());
assert!(h1.poll().is_ok());
assert!(h1
.inner
.as_ref()
.unwrap()
.flags
.contains(Flags::DISCONNECTED));
// assert_eq!(h1.tasks.len(), 1);
ok::<_, ()>(())
}));
}
}