mirrors/PeerTube
1
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2024-05-15 11:22:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return 400 if filter query is still there

Browse source
This commit is contained in:
Chocobozzz 2023-11-28 07:01:12 +01:00
parent d3849e9b22
commit a0606360a7
No known key found for this signature in database
GPG key ID: 583A612D890159BE
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/tests/src/api/check-params/videos-common-filters.ts
View file

@ -59,6 +59,7 @@ describe('Test video filters validators', function () {
expectedStatus: HttpStatusCodeType
excludeAlreadyWatched?: boolean
unauthenticatedUser?: boolean
filter?: string
}) {
const paths = [
'/api/v1/video-channels/root_channel/videos',
@ -80,13 +81,18 @@ describe('Test video filters validators', function () {
isLocal: options.isLocal,
privacyOneOf: options.privacyOneOf,
include: options.include,
excludeAlreadyWatched: options.excludeAlreadyWatched
excludeAlreadyWatched: options.excludeAlreadyWatched,
filter: options.filter
},
expectedStatus: options.expectedStatus
})
}
}
it('Should fail with the old filter query param', async function () {
await testEndpoints({ filter: 'all-local', expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
})
it('Should fail with a bad privacyOneOf', async function () {
await testEndpoints({ privacyOneOf: [ 'toto' ] as any, expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
})

9
server/core/middlewares/validators/videos/videos.ts
View file

@ -515,6 +515,15 @@ const commonVideosFiltersValidator = [
})
return false
}
if (req.query.filter) {
res.fail({
status: HttpStatusCode.BAD_REQUEST_400,
message: '"filter" query parameter is not supported anymore by PeerTube. Please use "isLocal" and "include" instead'
})
return false
}
return next()
}
]