Show confirmation dialog when deleting post (#713) close #712

* Show confirmation dialog when deleting post

* Localization

* Fixes

---------

Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>

IceCubesApp/Resources/Localization/ca.lproj/Localizable.strings

@@ -325,6 +325,8 @@
 "status.action.boost" = "Impulsa";
 "status.action.copy-text" = "Copia el text";
 "status.action.delete" = "Elimina";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Edita";
 "status.action.favorite" = "Marca com a preferit";
 "status.action.mention" = "Menciona";

IceCubesApp/Resources/Localization/de.lproj/Localizable.strings

@@ -326,6 +326,8 @@
 "status.action.boost" = "Boosten";
 "status.action.copy-text" = "Text kopieren";
 "status.action.delete" = "Löschen";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Bearbeiten";
 "status.action.favorite" = "Favorisieren";
 "status.action.mention" = "Erwähnen";

IceCubesApp/Resources/Localization/en-GB.lproj/Localizable.strings

@@ -328,6 +328,8 @@
 "status.action.boost" = "Boost";
 "status.action.copy-text" = "Copy Text";
 "status.action.delete" = "Delete";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Edit";
 "status.action.favorite" = "Favourite";
 "status.action.mention" = "Mention";

IceCubesApp/Resources/Localization/en.lproj/Localizable.strings

@@ -327,6 +327,8 @@
 "status.action.boost" = "Boost";
 "status.action.copy-text" = "Copy Text";
 "status.action.delete" = "Delete";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Edit";
 "status.action.favorite" = "Favorite";
 "status.action.mention" = "Mention";

IceCubesApp/Resources/Localization/es.lproj/Localizable.strings

@@ -327,6 +327,8 @@
 "status.action.boost" = "Retootear";
 "status.action.copy-text" = "Copiar texto";
 "status.action.delete" = "Borrar";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Editar";
 "status.action.favorite" = "Marcar como favorito";
 "status.action.mention" = "Mencionar";

IceCubesApp/Resources/Localization/fr.lproj/Localizable.strings

@@ -322,6 +322,8 @@
 "status.action.boost" = "Promouvoir";
 "status.action.copy-text" = "Copier le texte";
 "status.action.delete" = "Supprimer";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Modifier";
 "status.action.favorite" = "Favori";
 "status.action.mention" = "Mentionner";

IceCubesApp/Resources/Localization/it.lproj/Localizable.strings

@@ -327,6 +327,8 @@
 "status.action.boost" = "Condividi";
 "status.action.copy-text" = "Copia il testo";
 "status.action.delete" = "Elimina";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Modifica";
 "status.action.favorite" = "Apprezza";
 "status.action.mention" = "Menziona";

IceCubesApp/Resources/Localization/ja.lproj/Localizable.strings

@@ -326,6 +326,8 @@
 "status.action.boost" = "ブースト";
 "status.action.copy-text" = "テキストをコピー";
 "status.action.delete" = "削除";
+"status.action.delete.confirm.title" = "確認";
+"status.action.delete.confirm.message" = "本当に投稿を削除しますか？";
 "status.action.edit" = "編集";
 "status.action.favorite" = "お気に入り";
 "status.action.mention" = "返信";

IceCubesApp/Resources/Localization/ko.lproj/Localizable.strings

@@ -328,6 +328,8 @@
 "status.action.boost" = "부스트";
 "status.action.copy-text" = "복사";
 "status.action.delete" = "삭제";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "수정";
 "status.action.favorite" = "좋아요";
 "status.action.mention" = "언급";

IceCubesApp/Resources/Localization/nb.lproj/Localizable.strings

@@ -326,6 +326,8 @@
 "status.action.boost" = "Forsterk";
 "status.action.copy-text" = "Kopier tekst";
 "status.action.delete" = "Slett";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Rediger";
 "status.action.favorite" = "Favoritt";
 "status.action.mention" = "Omtal";

IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings

@@ -320,6 +320,8 @@
 "status.action.boost" = "Boosten";
 "status.action.copy-text" = "Kopieer tekst";
 "status.action.delete" = "Verwijder";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Bewerk";
 "status.action.favorite" = "Maak favoriet";
 "status.action.mention" = "Vermelden";

IceCubesApp/Resources/Localization/pl.lproj/Localizable.strings

@@ -322,6 +322,8 @@
 "status.action.boost" = "Podbij";
 "status.action.copy-text" = "Kopiuj tekst";
 "status.action.delete" = "Usuń";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Edytuj";
 "status.action.favorite" = "Dodaj do polubionych";
 "status.action.mention" = "Wymień osobę";

IceCubesApp/Resources/Localization/pt-BR.lproj/Localizable.strings

@@ -326,6 +326,8 @@
 "status.action.boost" = "Boost";
 "status.action.copy-text" = "Copiar Texto";
 "status.action.delete" = "Deletar";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Editar";
 "status.action.favorite" = "Favoritar";
 "status.action.mention" = "Menção";

IceCubesApp/Resources/Localization/tr.lproj/Localizable.strings

@@ -322,6 +322,8 @@
 "status.action.boost" = "Yükselt";
 "status.action.copy-text" = "Yazıyı Kopyala";
 "status.action.delete" = "Sil";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "Düzenle";
 "status.action.favorite" = "Favori";
 "status.action.mention" = "Bahset";

IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings

@@ -327,6 +327,8 @@
 "status.action.boost" = "转发";
 "status.action.copy-text" = "拷贝文本";
 "status.action.delete" = "删除";
+"status.action.delete.confirm.title" = "Confirm";
+"status.action.delete.confirm.message" = "are you sure you want to delete this post?";
 "status.action.edit" = "编辑";
 "status.action.favorite" = "收藏";
 "status.action.mention" = "提及";

Packages/Status/Sources/Status/Row/StatusRowContextMenu.swift

@@ -112,9 +112,10 @@ struct StatusRowContextMenu: View {
             Label("status.action.edit", systemImage: "pencil")
           }
         }
-        Button(role: .destructive) { Task { await viewModel.delete() } } label: {
+        Button(role: .destructive,
-          Label("status.action.delete", systemImage: "trash")
+               action: { viewModel.showDeleteAlert = true },
-        }
+               label: { Label("status.action.delete", systemImage: "trash") }
+        )
       }
     } else if !viewModel.isRemote {
       Section(viewModel.status.account.acct) {

Packages/Status/Sources/Status/Row/StatusRowView.swift

@@ -127,6 +127,18 @@ public struct StatusRowView: View {
           remoteContentLoadingView
         }
       }
+      .alert(isPresented: $viewModel.showDeleteAlert, content: {
+        Alert(
+          title: Text("status.action.delete.confirm.title"),
+          message: Text("status.action.delete.confirm.message"),
+          primaryButton: .destructive(
+            Text("status.action.delete")) {
+              Task {
+                await viewModel.delete()
+              }
+            },
+          secondaryButton: .cancel())
+      })
       .alignmentGuide(.listRowSeparatorLeading) { _ in
         -100
       }

Packages/Status/Sources/Status/Row/StatusRowViewModel.swift

@@ -26,6 +26,7 @@ public class StatusRowViewModel: ObservableObject {
 
   @Published var translation: String?
   @Published var isLoadingTranslation: Bool = false
+  @Published var showDeleteAlert: Bool = false
 
   @Published var favoriters: [Account] = []
   @Published var rebloggers: [Account] = []