Add back posts streaming behind a setting, default to off

This commit is contained in:
Thomas Ricouard 2024-09-19 09:55:56 +02:00
parent 7eeaf4d902
commit db7155423a
4 changed files with 50 additions and 3 deletions

View file

@ -39,6 +39,7 @@ struct SettingsTabs: View {
accountsSection
generalSection
otherSections
postStreamingSection
AISection
cacheSection
}
@ -248,6 +249,23 @@ struct SettingsTabs: View {
#endif
}
@ViewBuilder
private var postStreamingSection: some View {
@Bindable var preferences = preferences
Section {
Toggle(isOn: $preferences.isPostsStreamingEnabled) {
Label("Posts streaming", systemImage: "clock.badge")
}
} header: {
Text("Streaming")
} footer: {
Text("Enabling post streaming will automatically add new posts at the top of your home timeline. Disable if you get performance issues.")
}
#if !os(visionOS)
.listRowBackground(theme.primaryBackgroundColor)
#endif
}
@ViewBuilder
private var AISection: some View {
@Bindable var preferences = preferences

View file

@ -23845,6 +23845,9 @@
},
"Disable to hide AI assisted tools options such as copywritting and alt image description generated from AI. Use OpenAI API. See our Privacy Policy for more information." : {
},
"Enabling post streaming will automatically add new posts at the top of your home timeline. Disable if you get performance issues." : {
},
"enum.avatar-position.leading" : {
"comment" : "MARK: Enums",
@ -42055,6 +42058,9 @@
}
}
}
},
"Posts streaming" : {
},
"Privacy Policy" : {
"localizations" : {
@ -77147,6 +77153,9 @@
}
}
}
},
"Streaming" : {
},
"Tab" : {
"localizations" : {

View file

@ -63,6 +63,8 @@ import SwiftUI
@AppStorage("sidebar_expanded") public var isSidebarExpanded: Bool = false
@AppStorage("stream_new_posts") public var isPostsStreamingEnabled: Bool = false
init() {
prepareTranslationType()
}
@ -358,6 +360,12 @@ import SwiftUI
}
}
public var isPostsStreamingEnabled: Bool {
didSet {
storage.isPostsStreamingEnabled = isPostsStreamingEnabled
}
}
public func getRealMaxIndent() -> UInt {
showReplyIndentation ? maxReplyIndentation : 0
}
@ -533,6 +541,7 @@ import SwiftUI
showAccountPopover = storage.showAccountPopover
muteVideo = storage.muteVideo
isSidebarExpanded = storage.isSidebarExpanded
isPostsStreamingEnabled = storage.isPostsStreamingEnabled
}
}

View file

@ -391,9 +391,8 @@ extension TimelineViewModel {
guard let client = client, canStreamEvents, isTimelineVisible else { return }
switch event {
case _ as StreamEventUpdate:
// Removed automatic stream for events.
break
case let updateEvent as StreamEventUpdate:
await handleUpdateEvent(updateEvent, client: client)
case let deleteEvent as StreamEventDelete:
await handleDeleteEvent(deleteEvent)
case let statusUpdateEvent as StreamEventStatusUpdate:
@ -403,6 +402,18 @@ extension TimelineViewModel {
}
}
private func handleUpdateEvent(_ event: StreamEventUpdate, client: Client) async {
guard timeline == .home,
UserPreferences.shared.isPostsStreamingEnabled,
await !datasource.contains(statusId: event.status.id) else { return }
pendingStatusesObserver.pendingStatuses.insert(event.status.id, at: 0)
await datasource.insert(event.status, at: 0)
await cache()
StatusDataControllerProvider.shared.updateDataControllers(for: [event.status], client: client)
await updateStatusesState()
}
private func handleDeleteEvent(_ event: StreamEventDelete) async {
if let _ = await datasource.remove(event.status) {
await cache()