Fix scaling of custom emoji (#1020)

This commit is contained in:
David Walter 2023-02-22 22:13:46 +01:00 committed by GitHub
parent 76556f4e83
commit a0e37273a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 45 additions and 1 deletions

View file

@ -134,6 +134,7 @@ struct AccountDetailHeaderView: View {
VStack(alignment: .leading, spacing: 0) { VStack(alignment: .leading, spacing: 0) {
EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis) EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis)
.font(.scaledHeadline) .font(.scaledHeadline)
.emojiSize(Font.scaledHeadlinePointSize)
Text("@\(account.acct)") Text("@\(account.acct)")
.font(.scaledCallout) .font(.scaledCallout)
.foregroundColor(.gray) .foregroundColor(.gray)
@ -160,6 +161,7 @@ struct AccountDetailHeaderView: View {
EmojiTextApp(account.note, emojis: account.emojis) EmojiTextApp(account.note, emojis: account.emojis)
.font(.scaledBody) .font(.scaledBody)
.emojiSize(Font.scaledBodyPointSize)
.padding(.top, 8) .padding(.top, 8)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
routerPath.handle(url: url) routerPath.handle(url: url)
@ -242,6 +244,7 @@ struct AccountDetailHeaderView: View {
.foregroundColor(Color.green.opacity(0.80)) .foregroundColor(Color.green.opacity(0.80))
} }
EmojiTextApp(field.value, emojis: viewModel.account?.emojis ?? []) EmojiTextApp(field.value, emojis: viewModel.account?.emojis ?? [])
.emojiSize(Font.scaledBodyPointSize)
.foregroundColor(theme.tintColor) .foregroundColor(theme.tintColor)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
routerPath.handle(url: url) routerPath.handle(url: url)

View file

@ -39,12 +39,14 @@ public struct AccountsListRow: View {
VStack(alignment: .leading, spacing: 2) { VStack(alignment: .leading, spacing: 2) {
EmojiTextApp(.init(stringValue: viewModel.account.safeDisplayName), emojis: viewModel.account.emojis) EmojiTextApp(.init(stringValue: viewModel.account.safeDisplayName), emojis: viewModel.account.emojis)
.font(.scaledSubheadline) .font(.scaledSubheadline)
.emojiSize(Font.scaledSubheadlinePointSize)
.fontWeight(.semibold) .fontWeight(.semibold)
Text("@\(viewModel.account.acct)") Text("@\(viewModel.account.acct)")
.font(.scaledFootnote) .font(.scaledFootnote)
.foregroundColor(.gray) .foregroundColor(.gray)
EmojiTextApp(viewModel.account.note, emojis: viewModel.account.emojis) EmojiTextApp(viewModel.account.note, emojis: viewModel.account.emojis)
.font(.scaledFootnote) .font(.scaledFootnote)
.emojiSize(Font.scaledFootnotePointSize)
.lineLimit(3) .lineLimit(3)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
routerPath.handle(url: url) routerPath.handle(url: url)

View file

@ -61,6 +61,7 @@ public struct AppAccountView: View {
EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis) EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis)
Text("\(account.username)@\(viewModel.appAccount.server)") Text("\(account.username)@\(viewModel.appAccount.server)")
.font(.scaledSubheadline) .font(.scaledSubheadline)
.emojiSize(Font.scaledSubheadlinePointSize)
.foregroundColor(.gray) .foregroundColor(.gray)
} }
} }

View file

@ -76,6 +76,7 @@ public struct ConversationDetailView: View {
{ {
EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis) EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis)
.font(.scaledHeadline) .font(.scaledHeadline)
.emojiSize(Font.scaledHeadlinePointSize)
} else { } else {
Text("Direct message with \(viewModel.conversation.accounts.count) people") Text("Direct message with \(viewModel.conversation.accounts.count) people")
.font(.scaledHeadline) .font(.scaledHeadline)

View file

@ -32,6 +32,7 @@ struct ConversationMessageView: View {
VStack(alignment: .leading) { VStack(alignment: .leading) {
EmojiTextApp(message.content, emojis: message.emojis) EmojiTextApp(message.content, emojis: message.emojis)
.font(.scaledBody) .font(.scaledBody)
.emojiSize(Font.scaledBodyPointSize)
.padding(6) .padding(6)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
routerPath.handleStatus(status: message, url: url) routerPath.handleStatus(status: message, url: url)

View file

@ -22,6 +22,7 @@ struct ConversationsListRow: View {
EmojiTextApp(.init(stringValue: conversation.accounts.map { $0.safeDisplayName }.joined(separator: ", ")), EmojiTextApp(.init(stringValue: conversation.accounts.map { $0.safeDisplayName }.joined(separator: ", ")),
emojis: conversation.accounts.flatMap { $0.emojis }) emojis: conversation.accounts.flatMap { $0.emojis })
.font(.scaledSubheadline) .font(.scaledSubheadline)
.emojiSize(Font.scaledSubheadlinePointSize)
.fontWeight(.semibold) .fontWeight(.semibold)
.foregroundColor(theme.labelColor) .foregroundColor(theme.labelColor)
.multilineTextAlignment(.leading) .multilineTextAlignment(.leading)
@ -39,6 +40,7 @@ struct ConversationsListRow: View {
EmojiTextApp(conversation.lastStatus?.content ?? HTMLString(stringValue: ""), emojis: conversation.lastStatus?.emojis ?? []) EmojiTextApp(conversation.lastStatus?.content ?? HTMLString(stringValue: ""), emojis: conversation.lastStatus?.emojis ?? [])
.multilineTextAlignment(.leading) .multilineTextAlignment(.leading)
.font(.scaledBody) .font(.scaledBody)
.emojiSize(Font.scaledBodyPointSize)
} }
Spacer() Spacer()
} }

View file

@ -44,10 +44,18 @@ public extension Font {
static var scaledHeadline: Font { static var scaledHeadline: Font {
customFont(size: userScaledFontSize(baseSize: headline), relativeTo: .headline).weight(.semibold) customFont(size: userScaledFontSize(baseSize: headline), relativeTo: .headline).weight(.semibold)
} }
static var scaledHeadlinePointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: headline)).pointSize
}
static var scaledBody: Font { static var scaledBody: Font {
customFont(size: userScaledFontSize(baseSize: body), relativeTo: .body) customFont(size: userScaledFontSize(baseSize: body), relativeTo: .body)
} }
static var scaledBodyPointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: body)).pointSize
}
static var scaledBodyUIFont: UIFont { static var scaledBodyUIFont: UIFont {
customUIFont(size: userScaledFontSize(baseSize: body)) customUIFont(size: userScaledFontSize(baseSize: body))
@ -56,18 +64,34 @@ public extension Font {
static var scaledCallout: Font { static var scaledCallout: Font {
customFont(size: userScaledFontSize(baseSize: callout), relativeTo: .callout) customFont(size: userScaledFontSize(baseSize: callout), relativeTo: .callout)
} }
static var scaledCalloutPointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: body)).pointSize
}
static var scaledSubheadline: Font { static var scaledSubheadline: Font {
customFont(size: userScaledFontSize(baseSize: subheadline), relativeTo: .subheadline) customFont(size: userScaledFontSize(baseSize: subheadline), relativeTo: .subheadline)
} }
static var scaledSubheadlinePointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: subheadline)).pointSize
}
static var scaledFootnote: Font { static var scaledFootnote: Font {
customFont(size: userScaledFontSize(baseSize: footnote), relativeTo: .footnote) customFont(size: userScaledFontSize(baseSize: footnote), relativeTo: .footnote)
} }
static var scaledFootnotePointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: footnote)).pointSize
}
static var scaledCaption: Font { static var scaledCaption: Font {
customFont(size: userScaledFontSize(baseSize: caption), relativeTo: .caption) customFont(size: userScaledFontSize(baseSize: caption), relativeTo: .caption)
} }
static var scaledCaptionPointSize: CGFloat {
customUIFont(size: userScaledFontSize(baseSize: caption)).pointSize
}
} }
public extension UIFont { public extension UIFont {

View file

@ -33,6 +33,7 @@ public struct ListEditView: View {
VStack(alignment: .leading) { VStack(alignment: .leading) {
EmojiTextApp(.init(stringValue: account.safeDisplayName), EmojiTextApp(.init(stringValue: account.safeDisplayName),
emojis: account.emojis) emojis: account.emojis)
.emojiSize(Font.scaledBodyPointSize)
Text("@\(account.acct)") Text("@\(account.acct)")
.foregroundColor(.gray) .foregroundColor(.gray)
.font(.scaledFootnote) .font(.scaledFootnote)

View file

@ -104,6 +104,7 @@ struct NotificationRowView: View {
.foregroundColor(.gray) .foregroundColor(.gray)
}) })
.font(.scaledSubheadline) .font(.scaledSubheadline)
.emojiSize(Font.scaledSubheadlinePointSize)
.fontWeight(.semibold) .fontWeight(.semibold)
.lineLimit(3) .lineLimit(3)
.fixedSize(horizontal: false, vertical: true) .fixedSize(horizontal: false, vertical: true)
@ -160,6 +161,7 @@ struct NotificationRowView: View {
emojis: notification.accounts[0].emojis) emojis: notification.accounts[0].emojis)
.lineLimit(3) .lineLimit(3)
.font(.scaledCallout) .font(.scaledCallout)
.emojiSize(Font.scaledCalloutPointSize)
.foregroundColor(.gray) .foregroundColor(.gray)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
routerPath.handle(url: url) routerPath.handle(url: url)

View file

@ -34,6 +34,7 @@ struct StatusEditorAutoCompleteView: View {
VStack(alignment: .leading) { VStack(alignment: .leading) {
EmojiTextApp(.init(stringValue: account.safeDisplayName), EmojiTextApp(.init(stringValue: account.safeDisplayName),
emojis: account.emojis) emojis: account.emojis)
.emojiSize(Font.scaledFootnotePointSize)
.font(.scaledFootnote) .font(.scaledFootnote)
.foregroundColor(theme.labelColor) .foregroundColor(theme.labelColor)
Text("@\(account.acct)") Text("@\(account.acct)")

View file

@ -47,6 +47,7 @@ public struct StatusEmbeddedView: View {
VStack(alignment: .leading, spacing: 0) { VStack(alignment: .leading, spacing: 0) {
EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis) EmojiTextApp(.init(stringValue: account.safeDisplayName), emojis: account.emojis)
.font(.scaledFootnote) .font(.scaledFootnote)
.emojiSize(Font.scaledFootnotePointSize)
.fontWeight(.semibold) .fontWeight(.semibold)
Group { Group {
Text("@\(account.acct)") + Text("@\(account.acct)") +

View file

@ -26,6 +26,7 @@ public struct StatusEditHistoryView: View {
VStack(alignment: .leading, spacing: 8) { VStack(alignment: .leading, spacing: 8) {
EmojiTextApp(edit.content, emojis: edit.emojis) EmojiTextApp(edit.content, emojis: edit.emojis)
.font(.scaledBody) .font(.scaledBody)
.emojiSize(Font.scaledBodyPointSize)
Group { Group {
Text(edit.createdAt.asDate, style: .date) + Text(edit.createdAt.asDate, style: .date) +
Text("status.summary.at-time") + Text("status.summary.at-time") +

View file

@ -38,6 +38,7 @@ struct StatusRowHeaderView: View {
HStack(alignment: .center, spacing: 4) { HStack(alignment: .center, spacing: 4) {
EmojiTextApp(.init(stringValue: status.account.safeDisplayName), emojis: status.account.emojis) EmojiTextApp(.init(stringValue: status.account.safeDisplayName), emojis: status.account.emojis)
.font(.scaledSubheadline) .font(.scaledSubheadline)
.emojiSize(Font.scaledSubheadlinePointSize)
.fontWeight(.semibold) .fontWeight(.semibold)
.lineLimit(1) .lineLimit(1)
.layoutPriority(1) .layoutPriority(1)

View file

@ -19,6 +19,7 @@ struct StatusRowReblogView: View {
+ Text("status.row.was-boosted") + Text("status.row.was-boosted")
) )
.font(.scaledFootnote) .font(.scaledFootnote)
.emojiSize(Font.scaledFootnotePointSize)
.foregroundColor(.gray) .foregroundColor(.gray)
.fontWeight(.semibold) .fontWeight(.semibold)
.onTapGesture { .onTapGesture {

View file

@ -13,6 +13,7 @@ struct StatusRowSpoilerView: View {
.foregroundColor(.secondary) .foregroundColor(.secondary)
EmojiTextApp(status.spoilerText, emojis: status.emojis, language: status.language) EmojiTextApp(status.spoilerText, emojis: status.emojis, language: status.language)
.font(.system(.subheadline, weight: .bold)) .font(.system(.subheadline, weight: .bold))
.emojiSize(Font.scaledSubheadlinePointSize)
.foregroundColor(.secondary) .foregroundColor(.secondary)
.multilineTextAlignment(.leading) .multilineTextAlignment(.leading)
Spacer() Spacer()

View file

@ -12,6 +12,7 @@ struct StatusRowTextView: View {
HStack { HStack {
EmojiTextApp(status.content, emojis: status.emojis, language: status.language) EmojiTextApp(status.content, emojis: status.emojis, language: status.language)
.font(.scaledBody) .font(.scaledBody)
.emojiSize(Font.scaledBodyPointSize)
.environment(\.openURL, OpenURLAction { url in .environment(\.openURL, OpenURLAction { url in
viewModel.routerPath.handleStatus(status: status, url: url) viewModel.routerPath.handleStatus(status: status, url: url)
}) })