Remove tab string from iOS app (#669)

* Remove tab string from iOS app

* Added tab string display setting

* Fixes

---------

Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>

IceCubesApp/App/IceCubesApp.swift

@@ -146,7 +146,13 @@ struct IceCubesApp: App {
       ForEach(availableTabs) { tab in
         tab.makeContentView(popToRootTab: $popToRootTab)
           .tabItem {
-            tab.label
+            if userPreferences.showiPhoneTabLabel {
+              tab.label
+                .labelStyle(TitleAndIconLabelStyle())
+            } else {
+              tab.label
+                .labelStyle(IconOnlyLabelStyle())
+            }
           }
           .tag(tab)
           .badge(badgeFor(tab: tab))

IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift

@@ -98,7 +98,14 @@ struct DisplaySettingsView: View {
         Toggle("settings.display.translate-button", isOn: $userPreferences.showTranslateButton)
       }
       .listRowBackground(theme.primaryBackgroundColor)
-      
+
+      if UIDevice.current.userInterfaceIdiom == .phone {
+        Section("settings.display.section.phone") {
+          Toggle("settings.display.show-tab-label", isOn: $userPreferences.showiPhoneTabLabel)
+        }
+        .listRowBackground(theme.primaryBackgroundColor)
+      }
+
       if UIDevice.current.userInterfaceIdiom == .pad {
         Section("settings.display.section.ipad") {
           Toggle("settings.display.show-ipad-column", isOn: $userPreferences.showiPadSecondaryColumn)

IceCubesApp/Resources/Localization/ca.lproj/Localizable.strings

@@ -156,6 +156,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/de.lproj/Localizable.strings

@@ -154,6 +154,9 @@
 "settings.haptic.tab-selection" = "Tabauswahl";
 "settings.haptic.buttons" = "Knopfdruck";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Zweite Spalte aktivieren";
 

IceCubesApp/Resources/Localization/en-GB.lproj/Localizable.strings

@@ -160,6 +160,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/en.lproj/Localizable.strings

@@ -158,6 +158,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/es.lproj/Localizable.strings

@@ -154,6 +154,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/fr.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Sélection d'onglet";
 "settings.haptic.buttons" = "Appui bouton";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Activer la colonne secondaire";
 

IceCubesApp/Resources/Localization/it.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Selezione Tab";
 "settings.haptic.buttons" = "Pressione dei bottoni";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Attiva la seconda colonna";
 

IceCubesApp/Resources/Localization/ja.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "タブセレクト";
 "settings.haptic.buttons" = "ボタン操作時";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "タブ名を表示";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "セカンドカラムを有効にする";
 

IceCubesApp/Resources/Localization/ko.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "하단 탭 바를 누를 때";
 "settings.haptic.buttons" = "버튼을 누를 때";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/nb.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings

@@ -154,6 +154,9 @@
 "settings.haptic.tab-selection" = "Tabselectie";
 "settings.haptic.buttons" = "Knoppen";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Toon tweede kolom";
 

IceCubesApp/Resources/Localization/pl.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Wybór zakładki";
 "settings.haptic.buttons" = "Naciśnięcie przycisku";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Włącz dodatkową kolumnę";
 

IceCubesApp/Resources/Localization/pt-BR.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/tr.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.haptic.tab-selection" = "Tab Selection";
 "settings.haptic.buttons" = "Button Press";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab name";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "Enable secondary column";
 

IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings

@@ -157,6 +157,9 @@
 "settings.display.font.custom" = "自定义";
 "settings.display.font.scaling-%@" = "字体缩放：%@";
 
+"settings.display.section.phone" = "iPhone";
+"settings.display.show-tab-label" = "Show tab label";
+
 "settings.display.section.ipad" = "iPad";
 "settings.display.show-ipad-column" = "启用边栏";
 

Packages/Env/Sources/Env/UserPreferences.swift

@@ -36,6 +36,8 @@ public class UserPreferences: ObservableObject {
   @AppStorage("haptic_timeline") public var hapticTimelineEnabled = true
   @AppStorage("haptic_button_press") public var hapticButtonPressEnabled = true
   
+  @AppStorage("show_tab_label_iphone") public var showiPhoneTabLabel = true
+  
   @AppStorage("show_second_column_ipad") public var showiPadSecondaryColumn = true
 
   public var postVisibility: Models.Visibility {