FediMovies/fedimovies
1
1
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Activity

Skip signature verification when processing Delete(Person) activities

Browse source
This commit is contained in:
silverpill 2021-12-29 20:52:30 +00:00
parent 580ba6dfba
commit b2f341445b
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/activitypub/views.rs
View file

@ -100,17 +100,19 @@ async fn inbox(
request: HttpRequest, request: HttpRequest,
activity: web::Json<serde_json::Value>, activity: web::Json<serde_json::Value>,
) -> Result<HttpResponse, HttpError> { ) -> Result<HttpResponse, HttpError> {
let activity_type = activity["type"].as_str().unwrap_or("Unknown");
log::info!("received in {}: {}", request.uri().path(), activity_type);
log::debug!("received activity: {}", activity); log::debug!("received activity: {}", activity);
let signature_verified = verify_http_signature(&config, &db_pool, &request).await; let activity_type = activity["type"].as_str().unwrap_or("Unknown");
if activity_type == DELETE && signature_verified.is_err() { if activity_type == DELETE && activity["actor"] == activity["object"] {
// Ignore Delete() activities if HTTP signature is not valid // Ignore Delete(Person) activities and skip signature verification
log::info!("received in {}: Delete", request.uri().path()); log::info!("received in {}: Delete(Person)", request.uri().path());
return Ok(HttpResponse::Ok().finish()); return Ok(HttpResponse::Ok().finish());
} else {
log::info!("received in {}: {}", request.uri().path(), activity_type);
}; };
let signature_verified = verify_http_signature(&config, &db_pool, &request).await;
match signature_verified { match signature_verified {
Ok(signer_id) => log::debug!("activity signed by {}", signer_id), Ok(signer_id) => log::debug!("activity signed by {}", signer_id),
// TODO: return error 401
Err(err) => log::warn!("invalid signature: {}", err), Err(err) => log::warn!("invalid signature: {}", err),
}; };
receive_activity(&config, &db_pool, &activity).await receive_activity(&config, &db_pool, &activity).await