Verify that Monero transaction exists after sending

https://codeberg.org/silverpill/mitra/issues/21

src/monero/subscriptions.rs

@@ -26,6 +26,7 @@ use crate::models::{
     users::queries::get_user_by_id,
 };
 use super::wallet::{
+    get_single_item,
     get_subaddress_balance,
     send_monero,
     DEFAULT_ACCOUNT,
@@ -85,11 +86,8 @@ pub async fn check_monero_subscriptions(
                 DEFAULT_ACCOUNT,
                 Some(vec![transfer.subaddr_index.minor]),
             ).await?;
-            let subaddress = if let [subaddress_data] = &address_data.addresses[..] {
-                subaddress_data.address
-            } else {
-                return Err(MoneroError::OtherError("invalid response from wallet"));
-            };
+            let subaddress_data = get_single_item(address_data.addresses)?;
+            let subaddress = subaddress_data.address;
             let invoice = get_invoice_by_address(
                 db_client,
                 &config.chain_id,

src/monero/wallet.rs

@@ -1,4 +1,5 @@
 use monero_rpc::{
+    HashString,
     RpcClient,
     SubaddressBalanceData,
     SweepAllArgs,
@@ -22,6 +23,9 @@ pub enum MoneroError {
     #[error(transparent)]
     WalletError(#[from] anyhow::Error),
 
+    #[error("{0}")]
+    WalletRpcError(&'static str),
+
     #[error(transparent)]
     AddressError(#[from] AddressError),
 
@@ -58,11 +62,11 @@ pub async fn create_monero_address(
     Ok(address)
 }
 
-fn get_single_item<T: Clone>(items: Vec<T>) -> Result<T, MoneroError> {
+pub fn get_single_item<T: Clone>(items: Vec<T>) -> Result<T, MoneroError> {
     if let [item] = &items[..] {
         Ok(item.clone())
     } else {
-        Err(MoneroError::OtherError("invalid response from wallet"))
+        Err(MoneroError::WalletRpcError("expected single item"))
     }
 }
 
@@ -99,12 +103,35 @@ pub async fn send_monero(
         get_tx_metadata: None,
     };
     let sweep_data = wallet_client.sweep_all(sweep_args).await?;
-    let tx_hash = get_single_item(sweep_data.tx_hash_list)?;
+    let HashString(tx_hash) = get_single_item(sweep_data.tx_hash_list)?;
     let amount = get_single_item(sweep_data.amount_list)?;
     let fee = get_single_item(sweep_data.fee_list)?;
+
+    // TODO: transaction can fail
+    // https://github.com/monero-project/monero/issues/8372
+    let maybe_transfer = wallet_client.get_transfer(
+        tx_hash.clone(),
+        Some(DEFAULT_ACCOUNT),
+    ).await?;
+    let transfer_status = maybe_transfer
+        .map(|data| data.transfer_type.into())
+        .unwrap_or("dropped");
+    if transfer_status == "dropped" || transfer_status == "failed" {
+        log::error!(
+            "sent transaction {:x} from {}/{}, {}",
+            tx_hash,
+            DEFAULT_ACCOUNT,
+            from_address,
+            transfer_status,
+        );
+        return Err(MoneroError::WalletRpcError("transaction failed"));
+    };
+
     log::info!(
-        "sent transaction {}, amount {}, fee {}",
+        "sent transaction {:x} from {}/{}, amount {}, fee {}",
         tx_hash,
+        DEFAULT_ACCOUNT,
+        from_address,
         amount,
         fee,
     );