FediMovies/fedimovies
1
1
Fork 0
Code Issues 3 Pull requests Packages Projects Releases Activity

Don't log incoming Delete() activities if HTTP signature is not valid

Browse source
This commit is contained in:
silverpill 2021-11-22 22:38:47 +00:00
parent 1d1618d6a2
commit 20026bd819
2 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/activitypub/receiver.rs
View file

@ -263,7 +263,6 @@ pub async fn process_note(
pub async fn receive_activity(
config: &Config,
db_pool: &Pool,
_username: String,
activity_raw: Value,
) -> Result<(), HttpError> {
let activity: Activity = serde_json::from_value(activity_raw)

21
src/activitypub/views.rs
View file

@ -16,6 +16,7 @@ use super::activity::{create_note, OrderedCollection};
use super::actor::{get_local_actor, get_instance_actor};
use super::constants::ACTIVITY_CONTENT_TYPE;
use super::receiver::receive_activity;
use super::vocabulary::DELETE;
pub fn get_actor_url(instance_url: &str, username: &str) -> String {
format!("{}/users/{}", instance_url, username)
@ -89,14 +90,19 @@ async fn inbox(
config: web::Data<Config>,
db_pool: web::Data<Pool>,
request: HttpRequest,
web::Path(username): web::Path<String>,
activity: web::Json<serde_json::Value>,
) -> Result<HttpResponse, HttpError> {
log::info!("received in '{}' inbox: {}", username, activity);
if let Err(err) = verify_http_signature(&config, &db_pool, &request).await {
let signature_verified = verify_http_signature(&config, &db_pool, &request).await;
if activity["type"].as_str() == Some(DELETE) && signature_verified.is_err() {
// Don't log Delete() activities if HTTP signature is not valid
log::info!("received in {}: Delete", request.uri().path());
} else {
log::info!("received in {}: {}", request.uri().path(), activity);
};
if let Err(err) = signature_verified {
log::warn!("invalid signature: {}", err);
}
receive_activity(&config, &db_pool, username, activity.into_inner()).await?;
};
receive_activity(&config, &db_pool, activity.into_inner()).await?;
Ok(HttpResponse::Ok().finish())
}
@ -165,7 +171,10 @@ async fn instance_actor_view(
async fn instance_actor_inbox(
activity: web::Json<serde_json::Value>,
) -> Result<HttpResponse, HttpError> {
log::info!("received in instance inbox: {}", activity);
log::info!(
"received in instance inbox: {}",
activity["type"].as_str().unwrap_or("Unknown"),
);
Ok(HttpResponse::Ok().finish())
}