Commit graph

163 commits

Author SHA1 Message Date
Fabien Basmaison
e37cbcd88d cover: Comment CSS rules a bit more and add rules for consistency. 2021-04-28 15:02:47 +02:00
Fabien Basmaison
bba60c99e9 cover: Rearrange some CSS rules. 2021-04-28 14:48:25 +02:00
Fabien Basmaison
baaaeef4c0 cover: Fix little details. 2021-04-28 10:47:14 +02:00
Fabien Basmaison
8a1c8cb061 cover: Update goal:
- Remove `.content` from template when not dealing with markdown-generated markup.
- Fix some duplicated CSS selectors.
2021-04-27 21:07:54 +02:00
Fabien Basmaison
a5359d1f80 cover: Update author. 2021-04-27 20:30:10 +02:00
Fabien Basmaison
d8b6676976 cover: Udpate logged out home and discover. 2021-04-27 16:27:39 +02:00
Fabien Basmaison
8ddc292ee6 cover: Change the logic again:
- Work on feeds.
- Add `.is-cover` to modify the behaviours of columns.
- Only apply logic for dimensions on the cover container; too many contextual side effects otherwise.
- Add classes to dimension and align, including auto margins for flex.
- Rename classes in templates accordingly.
2021-04-27 16:24:20 +02:00
Fabien Basmaison
b089f6c86a Update Bulma from v0.9.1 to v0.9.2. 2021-04-26 15:20:48 +02:00
Fabien Basmaison
26cacf502c Rationalise behaviours of context, container and cover:
- Set minimum dimensions to avoid having to pass classes all over the place.
- Outline the container to show white on white covers properly.
- Remove extraneous code.
- Better size caption when no cover is available.
- Create Alignments, Positions and Spacings sections and move some existing dimensions.
- Update previous templates.
2021-04-26 13:39:17 +02:00
Fabien Basmaison
30bed6c963 Merge branch 'main' into frontend-book-cover 2021-04-26 11:35:10 +02:00
Joachim
e92166c7f7 Directory: Homogenize cards heights
When the content of a profile card stretches it in height, the grid is not homogenous. This PR adds a CSS class that'll display cards as stretchable columns. The card content will be able to grow, which should always place the card footer at the bottom of the card.
2021-04-25 20:05:31 +02:00
Mouse Reeve
2fd8e12b96
Merge pull request #974 from joachimesque/list-table
Add mobile styles for book preview table
2021-04-25 10:42:27 -07:00
Fabien Basmaison
a268f339c0 Fix linting issues. 2021-04-25 15:45:49 +02:00
Fabien Basmaison
953dff90bb cover: tweak styles:
- `optimizeQuality` > `smooth` (CSS language evolution)
- Use `auto` instead of a fixed width.
- Add exceptions for heights and apply them to some previously modified templates.
- Remove `is-large` exception.
- Widen the content column on list curation.
2021-04-25 15:37:46 +02:00
Fabien Basmaison
23985e4357 Merge branch 'main' into frontend-book-cover 2021-04-25 11:24:21 +02:00
Fabien Basmaison
cf5a4ebe90 Fix typo:
Addresses https://github.com/bookwyrm-social/bookwyrm/pull/994#discussion_r619688900.
2021-04-24 21:27:05 +02:00
Fabien Basmaison
eea8b4e750 cover: Handle covers with specific heights:
- Have an explicit contextual class on `cover-container`.
- Use more flexible, consistent and searchable variable name for passing classes to covers.
- Consistently use `'…'` with django variables.
- Give the option to not hide covers to screen readers.
- consitently give a title to the cover container if `alt_text` exists.
- [lists] Remove `.content` which is applying too extensive default styles.
2021-04-24 21:27:05 +02:00
Joachim
e06154c457
Merge branch 'main' into smaller-statuses-dense-cards 2021-04-24 20:07:13 +02:00
Fabien Basmaison
32fb06c9e6 Prevent stars from wrapping on multiple lines. 2021-04-24 13:23:03 +02:00
Fabien Basmaison
7f0b3184a1 cover: Use book-cover as component:
- Avoid specifying context-dependent values in CSS for components. Those values can be defined by the context calling the component.
- Use `<figure>` with optional caption.
- Reduce redundant markup.
- Allow more variables to be passed to the book-cover (image path and class for the container).
- Hide the book cover to screen readers.
2021-04-24 12:48:55 +02:00
Mouse Reeve
c6e8161a9f Removes scroll padding 2021-04-22 13:08:22 -07:00
Joachim
15c7a1dc82 Update bookwyrm.css 2021-04-22 20:57:24 +02:00
Joachim
2749e6ad95 Fix CSS for linter 2021-04-21 22:36:07 +02:00
Joachim
0b0a283e64 Fix buttons styles 2021-04-21 22:32:14 +02:00
Joachim
e4836bd9b3 Fix for lint 2021-04-21 21:29:28 +02:00
Joachim
2ae9085e55 Vertically align cells in desktop view 2021-04-21 21:26:20 +02:00
Joachim
482774f1e1 Add mobile styles for book preview table 2021-04-21 21:25:37 +02:00
Joachim
71390f1735 Set body height 2021-04-15 21:51:14 +02:00
Fabien Basmaison
e016006ade [css] Rename all classes consistently: :shamed:
This commit addresses https://github.com/mouse-reeve/bookwyrm/pull/883#pullrequestreview-632930445.
2021-04-10 19:51:18 +02:00
Fabien Basmaison
b92ff9752d [assets] Remove UI and behaviours for interactions:
This commit addresses https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609739553.
2021-04-08 17:37:29 +02:00
Fabien Basmaison
2f90b4ce66 [assets] Fix broken actions for focus and checkbox:
This commit should address the following two comments:

- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609172258
- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609174513
2021-04-08 11:37:14 +02:00
Fabien Basmaison
83bd417878 [assets] Update interactions code:
This commit should address https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609381969.

- Disable the button being used to submit the form.
- Rename variables based on @mouse-reeve’s explanations. Thanks! 
2021-04-08 11:08:13 +02:00
Fabien Basmaison
be0cabc415 [css] Improve quotes. 2021-04-07 18:07:32 +02:00
Fabien Basmaison
2a0924027b [css] Use more visible comments to split blocks. 2021-04-07 17:33:28 +02:00
Fabien Basmaison
f77088b964 [assets] Remove redundant class already provided by bulma:
Replace all classes `hidden` with `is-hidden` in templates, CSS and JS.
2021-04-07 17:31:00 +02:00
Fabien Basmaison
f2a2b410a1 [assets] Add comment to mention replacing font icons with SVG. 2021-04-07 10:49:52 +02:00
Fabien Basmaison
54805afb51 [assets] Tweak JSDoc. 2021-04-07 10:37:11 +02:00
Fabien Basmaison
5d569e8926 [assets] Only update status if the promise is successful:
- Use promises in `ajaxPost` and `interact`.
- Add some animations in CSS.
2021-04-07 09:24:34 +02:00
Fabien Basmaison
1c05107f2b [assets] Tweak comments. 2021-04-07 07:53:30 +02:00
Fabien Basmaison
44040201f9 [assets] Move interact function. 2021-04-06 17:57:39 +02:00
Fabien Basmaison
9d95f54aa2 [assets] Refactor toggleAction and toggleMenu a bit. 2021-04-06 17:48:56 +02:00
Fabien Basmaison
52d2f0e331 [assets] Document functions and variables:
- Use expressive names for variables.
- Add docblocks for each function.
- Add ESLint rules for comments.
2021-04-06 16:17:20 +02:00
Fabien Basmaison
5d3d00f694 [assets] Use dataset + use expressive names for some variables. 2021-04-06 15:36:34 +02:00
Fabien Basmaison
62fe2ef600 [assets] Replace inline events with addEventListener; this breaks sliding menu. 2021-04-06 11:37:23 +02:00
Fabien Basmaison
7e49b3cb26 [assets] Simplify addRemoveClass function. 2021-04-06 11:19:44 +02:00
Fabien Basmaison
70c652d565 [assets] Add rules to ESLint:
- Fix long line.
- Enforce a few stylistic habits:

    - Avoid some potential dangerous constructs.
    - `arrow-spacing`: Use at least one space around arrows.
    - `keyword-spacing`: Use at least one space around keywords (if, else, for…).
    - `no-multiple-empty-lines`: Only use one empty line between code.
	- `no-var`: Use `let` or `const` instead of `var`:
    - `padded-blocks`: Do not pad blocks.
    - `padding-line-between-statements`: Use empty lines between some statements.
    - `space-before-blocks`: Use at least one space before the opening brace of a block.
2021-04-06 10:42:52 +02:00
Fabien Basmaison
991d897ac7 [assets] Listen to events as soon as possible. 2021-04-06 09:57:52 +02:00
Fabien Basmaison
2f2f7db086 [assets] Use classes for JS files:
- Classes strictly parse code implicitly.
- Fix previously updated code.
2021-04-06 09:44:59 +02:00
Fabien Basmaison
f430363be0 [assets] Simplify a function expression. 2021-04-06 09:11:56 +02:00
Fabien Basmaison
f6c3e581b9 [assets] Replace Array.from(document.getElementsByClassName(…)) by querySelectorAll(…). 2021-04-06 09:11:27 +02:00