From 45ac13a7fffe00337127b5b82d6a569cc2703ed3 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Sat, 30 Jan 2021 18:30:07 -0800
Subject: [PATCH 1/8] Clear unused editions with poor metadata

---
 .../management/commands/remove_editions.py    | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 bookwyrm/management/commands/remove_editions.py

diff --git a/bookwyrm/management/commands/remove_editions.py b/bookwyrm/management/commands/remove_editions.py
new file mode 100644
index 00000000..c5153f44
--- /dev/null
+++ b/bookwyrm/management/commands/remove_editions.py
@@ -0,0 +1,34 @@
+''' PROCEED WITH CAUTION: this permanently deletes book data '''
+from django.core.management.base import BaseCommand
+from django.db.models import Count, Q
+from bookwyrm import models
+
+
+def remove_editions():
+    ''' combine duplicate editions and update related models '''
+    # not in use
+    filters = {'%s__isnull' % r.name: True \
+        for r in models.Edition._meta.related_objects}
+    # no cover, no identifying fields
+    filters['cover'] = ''
+    null_fields = {'%s__isnull' % f: True for f in \
+        ['isbn_10', 'isbn_13', 'oclc_number']}
+
+    editions = models.Edition.objects.filter(
+        Q(languages=[]) | Q(languages__contains=['English']),
+        **filters, **null_fields
+    ).annotate(Count('parent_work__editions')).filter(
+        # mustn't be the only edition for the work
+        parent_work__editions__count__gt=1
+    )
+    print(editions.count())
+    editions.delete()
+
+
+class Command(BaseCommand):
+    ''' dedplucate allllll the book data models '''
+    help = 'merges duplicate book data'
+    # pylint: disable=no-self-use,unused-argument
+    def handle(self, *args, **options):
+        ''' run deudplications '''
+        remove_editions()

From 6ce4be74067f1d842d0588a19e561ad47884a282 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 12:25:33 -0800
Subject: [PATCH 2/8] Adds inline form component

---
 .../templates/components/inline_form.html     | 13 ++++++++
 bookwyrm/templates/lists/create_form.html     | 11 +++++++
 bookwyrm/templates/lists/edit_form.html       | 11 +++++++
 bookwyrm/templates/lists/list_layout.html     | 12 ++------
 bookwyrm/templates/lists/lists.html           | 30 ++++++++-----------
 5 files changed, 50 insertions(+), 27 deletions(-)
 create mode 100644 bookwyrm/templates/components/inline_form.html
 create mode 100644 bookwyrm/templates/lists/create_form.html
 create mode 100644 bookwyrm/templates/lists/edit_form.html

diff --git a/bookwyrm/templates/components/inline_form.html b/bookwyrm/templates/components/inline_form.html
new file mode 100644
index 00000000..6a244ffd
--- /dev/null
+++ b/bookwyrm/templates/components/inline_form.html
@@ -0,0 +1,13 @@
+<section class="card hidden {{ class }}" id="{{ controls_text }}{% if controls_uid %}-{{ controls_uid }}{% endif %}">
+    <header class="card-header has-background-white-ter">
+        <h2 class="card-header-title" tabindex="0" id="{{ controls_text }}{% if controls_uid %}-{{ controls_uid }}{% endif %}-header">
+            {% block header %}{% endblock %}
+        </h2>
+        <span class="card-header-icon">
+        {% include 'snippets/toggle/toggle_button.html' with label="Close" class="delete" nonbutton=True controls_text=controls_text %}
+        </span>
+    </header>
+    <section class="card-content content">
+        {% block form %}{% endblock %}
+    </section>
+</section>
diff --git a/bookwyrm/templates/lists/create_form.html b/bookwyrm/templates/lists/create_form.html
new file mode 100644
index 00000000..706dff08
--- /dev/null
+++ b/bookwyrm/templates/lists/create_form.html
@@ -0,0 +1,11 @@
+{% extends 'components/inline_form.html' %}
+
+{% block header %}
+Create List
+{% endblock %}
+
+{% block form %}
+    <form name="create-list" method="post" action="{% url 'lists' %}">
+    {% include 'lists/form.html' %}
+</form>
+{% endblock %}
diff --git a/bookwyrm/templates/lists/edit_form.html b/bookwyrm/templates/lists/edit_form.html
new file mode 100644
index 00000000..55723b72
--- /dev/null
+++ b/bookwyrm/templates/lists/edit_form.html
@@ -0,0 +1,11 @@
+{% extends 'components/inline_form.html' %}
+
+{% block header %}
+Edit List
+{% endblock %}
+
+{% block form %}
+<form name="edit-list" method="post" action="{% url 'list' list.id %}">
+    {% include 'lists/form.html' %}
+</form>
+{% endblock %}
diff --git a/bookwyrm/templates/lists/list_layout.html b/bookwyrm/templates/lists/list_layout.html
index 1887cd82..d3ff2c48 100644
--- a/bookwyrm/templates/lists/list_layout.html
+++ b/bookwyrm/templates/lists/list_layout.html
@@ -15,15 +15,9 @@
     {% endif %}
 </header>
 
-<form name="edit-list" method="post" action="{% url 'list' list.id %}" class="box hidden" id="edit-list">
-    <header class="columns">
-        <h3 class="title column" tabindex="0" id="edit-list-header">Edit list</h3>
-        <div class="column is-narrow">
-            {% include 'snippets/toggle/toggle_button.html' with controls_text="edit-list" label="close" class="delete" nonbutton=True %}
-        </div>
-    </header>
-    {% include 'lists/form.html' %}
-</form>
+<div class="block">
+    {% include 'lists/edit_form.html' with controls_text="edit-list" %}
+</div>
 
 {% block panel %}{% endblock %}
 
diff --git a/bookwyrm/templates/lists/lists.html b/bookwyrm/templates/lists/lists.html
index a0e18933..ad2dfbaf 100644
--- a/bookwyrm/templates/lists/lists.html
+++ b/bookwyrm/templates/lists/lists.html
@@ -5,26 +5,20 @@
     <h1 class="title">Lists</h1>
 </header>
 {% if request.user.is_authenticated and not lists.has_previous %}
-<section class="block content">
-    <header class="columns">
-        <div class="column">
-            <h2 class="title">Your lists</h2>
-        </div>
-        <div class="column is-narrow">
-            {% include 'snippets/toggle/open_button.html' with controls_text="create-list" icon="plus" text="Create new list" focus="create-list-header" %}
-        </div>
-    </header>
+<header class="block columns">
+    <div class="column">
+        <h2 class="title">Your lists</h2>
+    </div>
+    <div class="column is-narrow">
+        {% include 'snippets/toggle/open_button.html' with controls_text="create-list" icon="plus" text="Create new list" focus="create-list-header" %}
+    </div>
+</header>
 
-    <form name="create-list" method="post" action="{% url 'lists' %}" class="box hidden" id="create-list">
-        <header class="columns">
-            <h3 class="title column" tabindex="0" id="create-list-header">Create list</h3>
-            <div class="column is-narrow">
-                {% include 'snippets/toggle/toggle_button.html' with controls_text="create-list" label="Close" class="delete" nonbutton=True %}
-            </div>
-        </header>
-        {% include 'lists/form.html' %}
-    </form>
+<div class="block">
+    {% include 'lists/create_form.html' with controls_text="create-list" %}
+</div>
 
+<div class="block content">
     {% if request.user.list_set.exists %}
     {% include 'lists/list_items.html' with lists=request.user.list_set.all|slice:4 %}
     {% endif %}

From bcbcdd5b3b070c35537b7aa4089c79cc724a8956 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 12:36:20 -0800
Subject: [PATCH 3/8] Uses component for create shelf form

---
 .../templates/user/create_shelf_form.html     | 26 +++++++++++++++++++
 bookwyrm/templates/user/shelf.html            | 23 +++-------------
 bookwyrm/urls.py                              |  2 +-
 3 files changed, 30 insertions(+), 21 deletions(-)
 create mode 100644 bookwyrm/templates/user/create_shelf_form.html

diff --git a/bookwyrm/templates/user/create_shelf_form.html b/bookwyrm/templates/user/create_shelf_form.html
new file mode 100644
index 00000000..89f41fd8
--- /dev/null
+++ b/bookwyrm/templates/user/create_shelf_form.html
@@ -0,0 +1,26 @@
+{% extends 'components/inline_form.html' %}
+
+{% block header %}
+Create New Shelf
+{% endblock %}
+
+{% block form %}
+<form name="create-shelf" action="{% url 'shelf-create' %}" method="post">
+    {% csrf_token %}
+    <input type="hidden" name="user" value="{{ request.user.id }}">
+    <div class="field">
+        <label class="label" for="id_name_create">Name:</label>
+        <input type="text" name="name" maxlength="100" class="input" required="true" id="id_name_create">
+    </div>
+
+    <div class="field has-addons">
+        <div class="control">
+            {% include 'snippets/privacy_select.html' %}
+        </div>
+        <div class="control">
+            <button class="button is-primary" type="submit">Create shelf</button>
+        </div>
+    </div>
+</form>
+{% endblock %}
+
diff --git a/bookwyrm/templates/user/shelf.html b/bookwyrm/templates/user/shelf.html
index add5e5db..07b4f30b 100644
--- a/bookwyrm/templates/user/shelf.html
+++ b/bookwyrm/templates/user/shelf.html
@@ -29,30 +29,13 @@
 
     {% if is_self %}
     <div class="column is-narrow">
-        {% include 'snippets/toggle/open_button.html' with text="Create shelf" icon="plus" class="is-clickable" controls_text="create-shelf-form" %}
+        {% include 'snippets/toggle/open_button.html' with text="Create shelf" icon="plus" controls_text="create-shelf-form" focus="create-shelf-form-header" %}
     </div>
     {% endif %}
 </div>
 
-<div class="hidden box mb-5" id="create-shelf-form">
-    <h2 class="title is-4">Create new shelf</h2>
-    <form name="create-shelf" action="/create-shelf/" method="post">
-        {% csrf_token %}
-        <input type="hidden" name="user" value="{{ request.user.id }}">
-        <div class="field">
-            <label class="label" for="id_name_create">Name:</label>
-            <input type="text" name="name" maxlength="100" class="input" required="true" id="id_name_create">
-        </div>
-
-        <label class="label">
-            <p>Shelf privacy:</p>
-            {% include 'snippets/privacy_select.html' with no_label=True %}
-        </label>
-        <div class="field is-grouped">
-            <button class="button is-primary" type="submit">Create shelf</button>
-            {% include 'snippets/toggle/close_button.html' with text="Cancel" controls_text="create-shelf-form" %}
-        </div>
-    </form>
+<div class="block">
+    {% include 'user/create_shelf_form.html' with controls_text='create-shelf-form' %}
 </div>
 
 <div class="block columns">
diff --git a/bookwyrm/urls.py b/bookwyrm/urls.py
index 68aaedd7..3830adb9 100644
--- a/bookwyrm/urls.py
+++ b/bookwyrm/urls.py
@@ -150,7 +150,7 @@ urlpatterns = [
             user_path, views.Shelf.as_view(), name='shelf'),
     re_path(r'^%s/shelf/(?P<shelf_identifier>[\w-]+)(.json)?/?$' % \
             local_user_path, views.Shelf.as_view()),
-    re_path(r'^create-shelf/?$', views.create_shelf),
+    re_path(r'^create-shelf/?$', views.create_shelf, name='shelf-create'),
     re_path(r'^delete-shelf/(?P<shelf_id>\d+)?$', views.delete_shelf),
     re_path(r'^shelve/?$', views.shelve),
     re_path(r'^unshelve/?$', views.unshelve),

From 502e235e590b4d1dfb5a3f224ce554c5dce0db6a Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 12:44:51 -0800
Subject: [PATCH 4/8] Edit shelf form using component

---
 bookwyrm/templates/user/edit_shelf_form.html | 31 ++++++++++++++++++++
 bookwyrm/templates/user/shelf.html           | 27 ++---------------
 2 files changed, 34 insertions(+), 24 deletions(-)
 create mode 100644 bookwyrm/templates/user/edit_shelf_form.html

diff --git a/bookwyrm/templates/user/edit_shelf_form.html b/bookwyrm/templates/user/edit_shelf_form.html
new file mode 100644
index 00000000..b179be9f
--- /dev/null
+++ b/bookwyrm/templates/user/edit_shelf_form.html
@@ -0,0 +1,31 @@
+{% extends 'components/inline_form.html' %}
+
+{% block header %}
+Edit Shelf
+{% endblock %}
+
+{% block form %}
+<form name="edit-shelf" action="{{ shelf.local_path }}" method="post">
+    {% csrf_token %}
+    <input type="hidden" name="user" value="{{ request.user.id }}">
+    {% if shelf.editable %}
+    <div class="field">
+        <label class="label" for="id_name">Name:</label>
+        <input type="text" name="name" maxlength="100" class="input" required="true" value="{{ shelf.name }}" id="id_name">
+    </div>
+    {% else %}
+    <input type="hidden" name="name" required="true" value="{{ shelf.name }}">
+    {% endif %}
+
+    <div class="field has-addons">
+        <div class="control">
+            {% include 'snippets/privacy_select.html' with current=shelf.privacy %}
+        </div>
+        <div class="control">
+            <button class="button is-primary" type="submit">Update shelf</button>
+        </div>
+    </div>
+</form>
+{% endblock %}
+
+
diff --git a/bookwyrm/templates/user/shelf.html b/bookwyrm/templates/user/shelf.html
index 07b4f30b..5e2f532f 100644
--- a/bookwyrm/templates/user/shelf.html
+++ b/bookwyrm/templates/user/shelf.html
@@ -49,34 +49,13 @@
     </div>
     {% if is_self %}
     <div class="column is-narrow">
-        {% include 'snippets/toggle/open_button.html' with text="Edit shelf" icon="pencil" class="is-clickable" controls_text="edit-shelf-form" %}
+        {% include 'snippets/toggle/open_button.html' with text="Edit shelf" icon="pencil" controls_text="edit-shelf-form" focus="edit-shelf-form-header" %}
     </div>
     {% endif %}
 </div>
 
-<div class="hidden box mb-5" id="edit-shelf-form">
-    <h2 class="title is-4">Edit shelf</h2>
-    <form name="create-shelf" action="{{ shelf.local_path }}" method="post">
-        {% csrf_token %}
-        <input type="hidden" name="user" value="{{ request.user.id }}">
-        {% if shelf.editable %}
-        <div class="field">
-            <label class="label" for="id_name">Name:</label>
-            <input type="text" name="name" maxlength="100" class="input" required="true" value="{{ shelf.name }}" id="id_name">
-        </div>
-        {% else %}
-        <input type="hidden" name="name" required="true" value="{{ shelf.name }}">
-        {% endif %}
-
-        <label class="label">
-            <p>Shelf privacy:</p>
-            {% include 'snippets/privacy_select.html' with no_label=True current=shelf.privacy %}
-        </label>
-        <div class="field is-grouped">
-            <button class="button is-primary" type="submit">Update shelf</button>
-            {% include 'snippets/toggle/close_button.html' with text="Cancel" controls_text="edit-shelf-form" %}
-        </div>
-    </form>
+<div class="block">
+    {% include 'user/edit_shelf_form.html' with controls_text="edit-shelf-form" %}
 </div>
 
 <div class="block">

From 7faf639758127ccbc48a990fe81714eb0dc59c08 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 12:52:13 -0800
Subject: [PATCH 5/8] Fixes openlibrary connector test

---
 bookwyrm/tests/connectors/test_openlibrary_connector.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/bookwyrm/tests/connectors/test_openlibrary_connector.py b/bookwyrm/tests/connectors/test_openlibrary_connector.py
index c277ba04..8132a203 100644
--- a/bookwyrm/tests/connectors/test_openlibrary_connector.py
+++ b/bookwyrm/tests/connectors/test_openlibrary_connector.py
@@ -192,9 +192,15 @@ class Openlibrary(TestCase):
         self.assertEqual(edition['key'], '/books/OL9788823M')
 
 
+    @responses.activate
     def test_create_edition_from_data(self):
         ''' okay but can it actually create an edition with proper metadata '''
         work = models.Work.objects.create(title='Hello')
+        responses.add(
+            responses.GET,
+            'https://openlibrary.org/authors/OL382982A',
+            json={'hi': 'there'},
+            status=200)
         result = self.connector.create_edition_from_data(
             work, self.edition_data)
         self.assertEqual(result.parent_work, work)

From 476d65552ef16843352c478b5d924bbfceb91b1e Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 16:01:49 -0800
Subject: [PATCH 6/8] Hide other people's empty lists from lists page

---
 bookwyrm/views/list.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bookwyrm/views/list.py b/bookwyrm/views/list.py
index ce0cedb4..88938a67 100644
--- a/bookwyrm/views/list.py
+++ b/bookwyrm/views/list.py
@@ -29,6 +29,7 @@ class Lists(View):
         user = request.user if request.user.is_authenticated else None
         lists = models.List.objects.filter(
             ~Q(user=user),
+            books__isnull=False,
         ).all()
         lists = privacy_filter(request.user, lists, ['public', 'followers'])
 

From 39d31060e10e343b187b1b568ecabefc261d294c Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 16:11:42 -0800
Subject: [PATCH 7/8] Sort list preview by most recently added

---
 bookwyrm/templates/lists/list_items.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookwyrm/templates/lists/list_items.html b/bookwyrm/templates/lists/list_items.html
index 4560147f..942579ca 100644
--- a/bookwyrm/templates/lists/list_items.html
+++ b/bookwyrm/templates/lists/list_items.html
@@ -9,8 +9,8 @@
                 </h4>
             </header>
             <div class="card-image is-flex">
-                {% for book in list.books.all|slice:5 %}
-                {% include 'snippets/book_cover.html' with book=book size="small" %}
+                {% for book in list.listitem_set.all|slice:5 %}
+                {% include 'snippets/book_cover.html' with book=book.book size="small" %}
                 {% endfor %}
             </div>
             <div class="card-content is-flex-grow-0">

From 3f2f27bcaca32ec592cc8ab972bb73d93938a55f Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Wed, 3 Feb 2021 16:40:29 -0800
Subject: [PATCH 8/8] Fixes logged out list view

---
 bookwyrm/templates/lists/lists.html | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bookwyrm/templates/lists/lists.html b/bookwyrm/templates/lists/lists.html
index ad2dfbaf..96ad8153 100644
--- a/bookwyrm/templates/lists/lists.html
+++ b/bookwyrm/templates/lists/lists.html
@@ -33,9 +33,7 @@
 {% if lists %}
 <section class="block content">
     <h2 class="title">Recent Lists</h2>
-    {% if request.user.list_set.exists %}
     {% include 'lists/list_items.html' with lists=lists %}
-    {% endif %}
 </section>
 <div>
     {% include 'snippets/pagination.html' with page=lists path=path %}