From 7abe39b7d5325848106b4bdfb528ec9dd3a3b310 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Thu, 14 Jan 2021 15:29:37 -0800
Subject: [PATCH] Tab change javascript out of html

---
 bookwyrm/static/js/shared.js                  | 35 +++++++++----------
 bookwyrm/templates/feed.html                  |  2 +-
 .../templates/snippets/create_status.html     |  6 ++--
 3 files changed, 21 insertions(+), 22 deletions(-)

diff --git a/bookwyrm/static/js/shared.js b/bookwyrm/static/js/shared.js
index 54d2a1b7..3cb85d11 100644
--- a/bookwyrm/static/js/shared.js
+++ b/bookwyrm/static/js/shared.js
@@ -11,6 +11,12 @@ window.onload = function() {
     // select all
     Array.from(document.getElementsByClassName('select-all'))
         .forEach(t => t.onclick = selectAll);
+
+    // toggle between tabs
+    Array.from(document.getElementsByClassName('tab-change-nested'))
+        .forEach(t => t.onclick = tabChangeNested);
+    Array.from(document.getElementsByClassName('tab-change'))
+        .forEach(t => t.onclick = tabChange);
 };
 
 function toggleAction(e) {
@@ -42,32 +48,25 @@ function selectAll(e) {
         .forEach(t => t.checked=true);
 }
 
-function rate_stars(e) {
-    e.preventDefault();
-    ajaxPost(e.target);
-    rating = e.target.rating.value;
-    var stars = e.target.parentElement.getElementsByClassName('icon');
-    for (var i = 0; i < stars.length ; i++) {
-        stars[i].className = rating > i ? 'icon icon-star-full' : 'icon icon-star-empty';
-    }
-    return true;
+function tabChangeNested(e) {
+    var target = e.target.closest('li')
+    var parentElement = target.parentElement.closest('li').parentElement;
+    handleTabChange(target, parentElement)
 }
 
-function tabChange(e, nested) {
+function tabChange(e) {
     var target = e.target.closest('li')
-    var identifier = target.getAttribute('data-id');
+    var parentElement = target.parentElement;
+    handleTabChange(target, parentElement)
+}
 
-    if (nested) {
-        var parent_element = target.parentElement.closest('li').parentElement;
-    } else {
-        var parent_element = target.parentElement;
-    }
 
-    parent_element.querySelectorAll('[aria-selected="true"]')
+function handleTabChange(target, parentElement) {
+    parentElement.querySelectorAll('[aria-selected="true"]')
         .forEach(t => t.setAttribute("aria-selected", false));
     target.querySelector('[role="tab"]').setAttribute("aria-selected", true);
 
-    parent_element.querySelectorAll('li')
+    parentElement.querySelectorAll('li')
         .forEach(t => t.className='');
     target.className = 'is-active';
 }
diff --git a/bookwyrm/templates/feed.html b/bookwyrm/templates/feed.html
index e1580fa5..07f4c60a 100644
--- a/bookwyrm/templates/feed.html
+++ b/bookwyrm/templates/feed.html
@@ -21,7 +21,7 @@
                         <ul>
                             {% for book in shelf.books %}
                             <li class="{% if shelf_counter == 1 and forloop.first %}is-active{% endif %}" data-id="tab-book-{{ book.id }}">
-                                <label for="book-{{ book.id }}" onclick="tabChange(event, nested=true)">
+                                <label for="book-{{ book.id }}" class="tab-change-nested">
                                     <div role="tab" tabindex="0" aria-selected="{% if shelf_counter == 1 and forloop.first %}true{% else %}false{% endif %}" aria-controls="book-{{ book.id }}-panel">
                                         <a>
                                             {% include 'snippets/book_cover.html' with book=book size="medium" %}
diff --git a/bookwyrm/templates/snippets/create_status.html b/bookwyrm/templates/snippets/create_status.html
index ac8c0b75..c1fc5979 100644
--- a/bookwyrm/templates/snippets/create_status.html
+++ b/bookwyrm/templates/snippets/create_status.html
@@ -5,21 +5,21 @@
     <ul role="tablist">
         <li class="is-active" data-id="tab-review-{{ book.id }}" data-category="tab-option-{{ book.id }}">
             <label for="review-{{ book.id }}">
-                <div onclick="tabChange(event)" role="tab" aria-selected="true" tabindex="0">
+                <div class="tab-change" role="tab" aria-selected="true" tabindex="0">
                     <a>Review</a>
                 </div>
             </label>
         </li>
         <li data-id="tab-comment-{{ book.id }}" data-category="tab-option-{{ book.id }}">
             <label for="comment-{{ book.id}}">
-                <div onclick="tabChange(event)" role="tab" tabindex="0">
+                <div class="tab-change" role="tab" tabindex="0">
                     <a>Comment</a>
                 </div>
             </label>
         </li>
         <li data-id="tab-quotation-{{ book.id }}" data-category="tab-option-{{ book.id }}">
             <label for="quote-{{ book.id }}">
-                <div onclick="tabChange(event)" role="tab" tabindex="0">
+                <div class="tab-change" role="tab" tabindex="0">
                     <a>Quote</a>
                 </div>
             </label>