From 6022e7b232459d689a6cdc8df20307f8df7528c7 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Fri, 17 Sep 2021 12:59:16 -0700
Subject: [PATCH] Adds IP blocklist views

---
 bookwyrm/forms.py                             |  6 +++
 bookwyrm/middleware/ip_middleware.py          |  2 +-
 bookwyrm/static/css/bookwyrm.css              |  7 +++
 bookwyrm/templates/components/tooltip.html    |  2 +-
 bookwyrm/templates/settings/domain_form.html  |  2 +-
 .../templates/settings/ip_address_form.html   | 36 ++++++++++++++
 bookwyrm/templates/settings/ip_blocklist.html | 47 ++++++++++++++++++
 bookwyrm/templates/settings/ip_tooltip.html   |  8 +++
 bookwyrm/templates/settings/layout.html       |  4 ++
 bookwyrm/urls.py                              | 10 ++++
 bookwyrm/views/__init__.py                    |  1 +
 bookwyrm/views/admin/email_blocklist.py       |  4 +-
 bookwyrm/views/admin/ip_blocklist.py          | 49 +++++++++++++++++++
 13 files changed, 173 insertions(+), 5 deletions(-)
 create mode 100644 bookwyrm/templates/settings/ip_address_form.html
 create mode 100644 bookwyrm/templates/settings/ip_blocklist.html
 create mode 100644 bookwyrm/templates/settings/ip_tooltip.html
 create mode 100644 bookwyrm/views/admin/ip_blocklist.py

diff --git a/bookwyrm/forms.py b/bookwyrm/forms.py
index b53d0b6a..0be53ba0 100644
--- a/bookwyrm/forms.py
+++ b/bookwyrm/forms.py
@@ -311,6 +311,12 @@ class EmailBlocklistForm(CustomForm):
         fields = ["domain"]
 
 
+class IPBlocklistForm(CustomForm):
+    class Meta:
+        model = models.IPBlocklist
+        fields = ["address"]
+
+
 class ServerForm(CustomForm):
     class Meta:
         model = models.FederatedServer
diff --git a/bookwyrm/middleware/ip_middleware.py b/bookwyrm/middleware/ip_middleware.py
index 7fcec1df..8063dd1f 100644
--- a/bookwyrm/middleware/ip_middleware.py
+++ b/bookwyrm/middleware/ip_middleware.py
@@ -11,6 +11,6 @@ class IPBlocklistMiddleware:
 
     def __call__(self, request):
         address = request.META.get("REMOTE_ADDR")
-        if models.IPBlockList.objects.filter(address=address).exists():
+        if models.IPBlocklist.objects.filter(address=address).exists():
             raise Http404()
         return self.get_response(request)
diff --git a/bookwyrm/static/css/bookwyrm.css b/bookwyrm/static/css/bookwyrm.css
index 9065d7fb..e1012c2f 100644
--- a/bookwyrm/static/css/bookwyrm.css
+++ b/bookwyrm/static/css/bookwyrm.css
@@ -378,6 +378,13 @@ input[type=file]::file-selector-button:hover {
     right: 1em;
 }
 
+/** Tooltips
+ ******************************************************************************/
+
+.tooltip {
+    width: 100%;
+}
+
 /** States
  ******************************************************************************/
 
diff --git a/bookwyrm/templates/components/tooltip.html b/bookwyrm/templates/components/tooltip.html
index 06b13f34..b1a8f56c 100644
--- a/bookwyrm/templates/components/tooltip.html
+++ b/bookwyrm/templates/components/tooltip.html
@@ -3,7 +3,7 @@
 {% trans "Help" as button_text %}
 {% include 'snippets/toggle/open_button.html' with text=button_text class="ml-3 is-rounded is-small is-white p-0 pb-1" icon="question-circle is-size-6" controls_text=controls_text controls_uid=controls_uid %}
 
-<aside class="notification is-hidden transition-y is-pulled-left mb-2" id="{{ controls_text }}{% if controls_uid %}-{{ controls_uid }}{% endif %}">
+<aside class="tooltip notification is-hidden transition-y is-pulled-left mb-2" id="{{ controls_text }}{% if controls_uid %}-{{ controls_uid }}{% endif %}">
     {% trans "Close" as button_text %}
     {% include 'snippets/toggle/close_button.html' with label=button_text class="delete" nonbutton=True controls_text=controls_text controls_uid=controls_uid %}
 
diff --git a/bookwyrm/templates/settings/domain_form.html b/bookwyrm/templates/settings/domain_form.html
index 0919791e..e9333749 100644
--- a/bookwyrm/templates/settings/domain_form.html
+++ b/bookwyrm/templates/settings/domain_form.html
@@ -8,7 +8,7 @@
 {% block form %}
 <form name="add-domain" method="post" action="{% url 'settings-email-blocks' %}">
     {% csrf_token %}
-    <label class="label" for="id_event_date">{% trans "Domain:" %}</label>
+    <label class="label" for="id_domain">{% trans "Domain:" %}</label>
     <div class="field has-addons">
         <div class="control">
             <div class="button is-disabled">@</div>
diff --git a/bookwyrm/templates/settings/ip_address_form.html b/bookwyrm/templates/settings/ip_address_form.html
new file mode 100644
index 00000000..c8a4c3e7
--- /dev/null
+++ b/bookwyrm/templates/settings/ip_address_form.html
@@ -0,0 +1,36 @@
+{% extends 'components/inline_form.html' %}
+{% load i18n %}
+
+{% block header %}
+{% trans "Add IP address" %}
+{% endblock %}
+
+{% block form %}
+<form name="add-address" method="post" action="{% url 'settings-ip-blocks' %}">
+    <div class="block">
+        {% trans "Use IP address blocks with caution, and consider using blocks only temporarily, as IP addresses are often shared or change hands. If you block your own IP, you will not be able to access this page." %}
+    </div>
+
+    {% csrf_token %}
+
+    <div class="field">
+        <label class="label" for="id_address">
+            {% trans "IP Address:" %}
+        </label>
+    </div>
+
+    <div class="field">
+        <input type="text" name="address" maxlength="255" class="input" required="" id="id_address" placeholder="190.0.2.0/24">
+    </div>
+
+    {% for error in form.address.errors %}
+    <p class="help is-danger">{{ error | escape }}</p>
+    {% endfor %}
+
+    <div class="field">
+        <div class="control">
+            <button type="submit" class="button is-primary">{% trans "Add" %}</button>
+        </div>
+    </div>
+</form>
+{% endblock %}
diff --git a/bookwyrm/templates/settings/ip_blocklist.html b/bookwyrm/templates/settings/ip_blocklist.html
new file mode 100644
index 00000000..c978c126
--- /dev/null
+++ b/bookwyrm/templates/settings/ip_blocklist.html
@@ -0,0 +1,47 @@
+{% extends 'settings/layout.html' %}
+{% load i18n %}
+{% load humanize %}
+
+{% block title %}{% trans "IP Address Blocklist" %}{% endblock %}
+
+{% block header %}{% trans "IP Address Blocklist" %}{% endblock %}
+
+{% block edit-button %}
+{% trans "Add IP address" as button_text %}
+{% include 'snippets/toggle/open_button.html' with controls_text="add_address" icon_with_text="plus" text=button_text focus="add_address_header" %}
+{% endblock %}
+
+{% block panel %}
+{% include 'settings/ip_address_form.html' with controls_text="add_address" class="block" %}
+
+<p class="notification block">
+    {% trans "Any traffic from this IP address will get a 404 response when trying to access any part of the application." %}
+</p>
+
+<table class="table is-striped is-fullwidth">
+    <tr>
+        <th>
+            {% trans "Address" %}
+        </th>
+        <th>
+            {% trans "Options" %}
+        </th>
+    </tr>
+    {% for address in addresses %}
+    <tr>
+        <td>{{ address.address }}</td>
+        <td>
+            <form name="remove-{{ address.id }}" action="{% url 'settings-ip-blocks-delete' address.id %}" method="post">
+                {% csrf_token %}
+                {% trans "Delete" as button_text %}
+                <button class="button" type="submit">
+                    <span class="icon icon-x" title="{{ button_text }}" aria-hidden="true"></span>
+                    <span class="is-hidden-mobile">{{ button_text }}</span>
+                </button>
+            </form>
+        </td>
+    </tr>
+    {% endfor %}
+</table>
+
+{% endblock %}
diff --git a/bookwyrm/templates/settings/ip_tooltip.html b/bookwyrm/templates/settings/ip_tooltip.html
new file mode 100644
index 00000000..3a2bf543
--- /dev/null
+++ b/bookwyrm/templates/settings/ip_tooltip.html
@@ -0,0 +1,8 @@
+{% extends 'components/tooltip.html' %}
+{% load i18n %}
+
+{% block tooltip_content %}
+
+{% trans "You can block IP ranges using CIDR syntax." %}
+
+{% endblock %}
diff --git a/bookwyrm/templates/settings/layout.html b/bookwyrm/templates/settings/layout.html
index 72a9fb4e..dd315347 100644
--- a/bookwyrm/templates/settings/layout.html
+++ b/bookwyrm/templates/settings/layout.html
@@ -58,6 +58,10 @@
                 {% url 'settings-email-blocks' as url %}
                 <a href="{{ url }}"{% if url in request.path %} class="is-active" aria-selected="true"{% endif %}>{% trans "Email Blocklist" %}</a>
             </li>
+            <li>
+                {% url 'settings-ip-blocks' as url %}
+                <a href="{{ url }}"{% if url in request.path %} class="is-active" aria-selected="true"{% endif %}>{% trans "IP Address Blocklist" %}</a>
+            </li>
         </ul>
         {% endif %}
         {% if perms.bookwyrm.edit_instance_settings %}
diff --git a/bookwyrm/urls.py b/bookwyrm/urls.py
index 6acf75cb..af5714d7 100644
--- a/bookwyrm/urls.py
+++ b/bookwyrm/urls.py
@@ -154,6 +154,16 @@ urlpatterns = [
         views.EmailBlocklist.as_view(),
         name="settings-email-blocks-delete",
     ),
+    re_path(
+        r"^settings/ip-blocklist/?$",
+        views.IPBlocklist.as_view(),
+        name="settings-ip-blocks",
+    ),
+    re_path(
+        r"^settings/ip-blocks/(?P<block_id>\d+)/delete/?$",
+        views.IPBlocklist.as_view(),
+        name="settings-ip-blocks-delete",
+    ),
     # moderation
     re_path(r"^settings/reports/?$", views.Reports.as_view(), name="settings-reports"),
     re_path(
diff --git a/bookwyrm/views/__init__.py b/bookwyrm/views/__init__.py
index 95f3fc7f..16ebb2ba 100644
--- a/bookwyrm/views/__init__.py
+++ b/bookwyrm/views/__init__.py
@@ -5,6 +5,7 @@ from .admin.federation import Federation, FederatedServer
 from .admin.federation import AddFederatedServer, ImportServerBlocklist
 from .admin.federation import block_server, unblock_server
 from .admin.email_blocklist import EmailBlocklist
+from .admin.ip_blocklist import IPBlocklist
 from .admin.invite import ManageInvites, Invite, InviteRequest
 from .admin.invite import ManageInviteRequests, ignore_invite_request
 from .admin.reports import (
diff --git a/bookwyrm/views/admin/email_blocklist.py b/bookwyrm/views/admin/email_blocklist.py
index 2ed8c152..cd3d83fd 100644
--- a/bookwyrm/views/admin/email_blocklist.py
+++ b/bookwyrm/views/admin/email_blocklist.py
@@ -1,4 +1,4 @@
-""" moderation via flagged posts and users """
+""" Manage email blocklist"""
 from django.contrib.auth.decorators import login_required, permission_required
 from django.shortcuts import get_object_or_404, redirect
 from django.template.response import TemplateResponse
@@ -14,7 +14,7 @@ from bookwyrm import forms, models
     name="dispatch",
 )
 class EmailBlocklist(View):
-    """Block users by email address"""
+    """Block registration by email address"""
 
     def get(self, request):
         """view and compose blocks"""
diff --git a/bookwyrm/views/admin/ip_blocklist.py b/bookwyrm/views/admin/ip_blocklist.py
new file mode 100644
index 00000000..643dae22
--- /dev/null
+++ b/bookwyrm/views/admin/ip_blocklist.py
@@ -0,0 +1,49 @@
+""" Manage IP blocklist """
+from django.contrib.auth.decorators import login_required, permission_required
+from django.shortcuts import get_object_or_404, redirect
+from django.template.response import TemplateResponse
+from django.utils.decorators import method_decorator
+from django.views import View
+
+from bookwyrm import forms, models
+
+# pylint: disable=no-self-use
+@method_decorator(login_required, name="dispatch")
+@method_decorator(
+    permission_required("bookwyrm.moderate_user", raise_exception=True),
+    name="dispatch",
+)
+class IPBlocklist(View):
+    """Block registration by ip address"""
+
+    def get(self, request):
+        """view and compose blocks"""
+        data = {
+            "addresses": models.IPBlocklist.objects.all(),
+            "form": forms.IPBlocklistForm(),
+        }
+        return TemplateResponse(request, "settings/ip_blocklist.html", data)
+
+    def post(self, request, block_id=None):
+        """create a new ip address block"""
+        if block_id:
+            return self.delete(request, block_id)
+
+        form = forms.IPBlocklistForm(request.POST)
+        data = {
+            "addresses": models.IPBlocklist.objects.all(),
+            "form": form,
+        }
+        if not form.is_valid():
+            return TemplateResponse(request, "settings/ip_blocklist.html", data)
+        form.save()
+
+        data["form"] = forms.IPBlocklistForm()
+        return TemplateResponse(request, "settings/ip_blocklist.html", data)
+
+    # pylint: disable=unused-argument
+    def delete(self, request, domain_id):
+        """remove a domain block"""
+        domain = get_object_or_404(models.IPBlocklist, id=domain_id)
+        domain.delete()
+        return redirect("settings-ip-blocks")