From 4555d7713a717b873cb413fe200e195307dbee42 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Sun, 10 May 2020 14:56:53 -0700 Subject: [PATCH] remove unneeded connector code --- fedireads/connectors/abstract_connector.py | 12 +++--------- fedireads/tests/test_connector_fedireads.py | 1 - 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/fedireads/connectors/abstract_connector.py b/fedireads/connectors/abstract_connector.py index 1e5c2665..64427117 100644 --- a/fedireads/connectors/abstract_connector.py +++ b/fedireads/connectors/abstract_connector.py @@ -267,19 +267,13 @@ def update_from_mappings(obj, data, mappings): if key == 'id': continue - if has_attr(obj, key): + try: + hasattr(obj, key) + except ValueError: obj.__setattr__(key, formatter(value)) return obj -def has_attr(obj, key): - ''' helper function to check if a model object has a key ''' - try: - return hasattr(obj, key) - except ValueError: - return False - - def get_date(date_string): ''' helper function to try to interpret dates ''' if not date_string: diff --git a/fedireads/tests/test_connector_fedireads.py b/fedireads/tests/test_connector_fedireads.py index b1da6f4c..2e0bfaf0 100644 --- a/fedireads/tests/test_connector_fedireads.py +++ b/fedireads/tests/test_connector_fedireads.py @@ -3,7 +3,6 @@ from dateutil import parser from django.test import TestCase import json import pathlib -import pytz from fedireads import models from fedireads.connectors.fedireads_connector import Connector