rafaelcaricio/gstreamer-rs
1
0
Fork 0
forked from mirrors/gstreamer-rs
Code Pull requests Activity
1235 commits 17 branches 82 tags 38 MiB
Commit graph

45 commits

Author SHA1 Message Date
Valmir Pretto
7663589d94 gstreamer: BusStream cleanup 
A few small readability changes
 2020-02-04 10:33:25 -03:00
Sebastian Dröge
fe4f074e90 bus: Don't use the bus sync handler in the bus Stream to notify about messages being available 
This is racy and can cause the consumer of the messages to never be
woken up anymore:

1. Waker is stored because no message on the bus
2. Sync handler is called, waker is woken up
3. Bus is polled again and no message is on it (yet),
   new waker is registered
4. Bus stores the message from 2. in its queue (after
   the sync handler has returned BusSyncReply::Pass)
5. No new message ever appears on the bus because all
   this happened for the very last message

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/235
 2020-01-28 23:39:36 +02:00
Sebastian Dröge
b17f04e866 bus: Make bus Stream private and add functions on the bus directly for it 
Also add a helper function that allows filtering the stream directly.
 2020-01-22 10:05:36 +02:00
Sebastian Dröge
217bbc3e94 bus: Take the mutex before popping messages for the bus stream 
Otherwise a message might arrive between popping, getting None and
locking the mutex for storing the waker. In that case we would never
be woken up.
 2020-01-22 09:21:10 +02:00
Sebastian Dröge
be3c378f28 Use Results instead of Options where they signal an error instead of just a missing value 
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/216
 2019-12-17 22:21:28 +02:00
Sebastian Dröge
77c6741ae0 Update to futures 0.3 and require Rust 1.39 
Also use async/await in the futures examples.
 2019-11-11 12:18:49 +01:00
Sebastian Dröge
86e969d964 Remove various Into<Option<_>> trait bounds from functions 
In autogenerated code these were already replaced but some manual code
still kept them.
 2019-05-24 10:04:16 +00:00
Sebastian Dröge
c282f34c74 bus: Fix naming for filtered pop functions 2019-05-11 13:45:09 +00:00
Vivia Nikolaidou
05d936fcee gstreamer: Add binding for GstMessageType and gst_bus_timed_pop_filtered 
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/168
 2019-05-10 19:35:13 +03:00
Sebastian Dröge
5f1a50026d Update futures code to futures 0.3 
Also clean it up a bit.
 2019-05-02 21:35:12 +03:00
Sebastian Dröge
e7898c1b24 Update manual code 2019-04-15 19:19:19 +03:00
Sebastian Dröge
8c39da4e5b Update to Rust 1.31 linter-specific attributes 2019-03-04 15:16:01 +02:00
Sebastian Dröge
95f6844702 Fix various minor clippy warnings 2019-02-21 19:56:23 +02:00
Sebastian Dröge
a5a016557f bus: add_watch() can fail as there can only be one watch at a time 
Return an Option<SourceId> because of that.
 2019-02-15 13:30:05 +02:00
Sebastian Dröge
09ad177315 Add Bus::add_watch_local() without Send bound on the closure 
This panics if not called from the thread that owns the main context.
 2019-02-10 11:43:55 +02:00
Sebastian Dröge
42a8b9e505 Get rid of double-boxing for some other closures 2019-01-30 13:02:41 +00:00
Sebastian Dröge
49c5fa33ba Add tests for Element::foreach_pad() and Bus::set_sync_handler() 2019-01-29 16:45:35 +02:00
Sebastian Dröge
bd0cbe99b3 Add more Debug impls to everything possible 2019-01-22 17:46:08 +02:00
Sebastian Dröge
69af6a5975 bus: Add iter() and iter_timed() that return Iterators around the corresponding pop() functions 
And make use of them in the examples where it makes sense.
 2018-12-28 00:06:03 +02:00
Sebastian Dröge
af5470a8b0 Unref the message in sync bus handlers if Drop is returned 2018-07-24 15:35:26 +03:00
Sebastian Dröge
e0972ae1e5 Get rid of manual usage of callback_guard! 2018-06-24 14:52:50 +03:00
Sebastian Dröge
da6b04abfd Bus::create_watch() can't return None, change it to return no Option 2018-05-19 10:36:15 +03:00
Sebastian Dröge
a276c226fd Port BusStream to futures 0.2 2018-04-23 20:27:17 +03:00
Sebastian Dröge
492c3d656c Run everything through rustfmt again 2018-04-01 11:57:58 +03:00
François Laignel
cd56d60352 Bus::get_pollfd generate doc for both unix & windows 
There are different implementations and signatures for `get_pollfd` depending
on whether the target platform is unix or windows. When generating the doc,
we need both implementations to appear regardless of the target platform. This
commit is inspired by the way Rust `std` library deals with `process::Command`
OS dependent variants
(https://doc.rust-lang.org/std/process/struct.Command.html#impl-CommandExt).

Documentation can't be accurate though as we can't use the`std::os::windows`
on `unix` and vice versa. As a workaround a fake fd class matching the other
platform is declared.

This could be further enhanced once `#[doc(cfg(...))]` is stabilized
(https://github.com/rust-lang/rust/issues/43781) by declaring `#[doc(cfg(unix))]`
or `#[doc(cfg(windows))]` instead of the hard coded comments `This is supported
on **Windows/Unix** only`. Unfortunately, these comments disappear when
generating will `--all-features` because they are not part of the documentation
in the gir file.
 2018-03-19 13:48:59 +02:00
Sebastian Dröge
4864a1e089 Fix build 2018-03-19 10:32:07 +02:00
Sebastian Dröge
1abe9cbeb9 Update gstreamer 2018-03-19 10:32:07 +02:00
Sebastian Dröge
a3b294f0f2 Add back callback guards 2018-03-02 21:34:29 +02:00
Sebastian Dröge
4117c01ff2 Run everything through latest rustfmt-nightly 2018-02-22 11:18:37 +01:00
Sebastian Dröge
f1426c82ba Remove callback guards 
Since Rust 1.24 it is safe to let panics go to the FFI boundary
 2018-02-17 19:58:41 +02:00
Sebastian Dröge
e0dc84c10a Run everything through rustfmt again 2017-12-20 19:30:14 +02:00
Sebastian Dröge
9a7ede1dcc Bus::add_signal_watch_full() should take a Priority, not u32 for the priority 2017-12-18 09:39:14 +02:00
Sebastian Dröge
8c697b3a27 Use Arc::clone(&val) instead of val.clone() to make it more explicit that only the Arc cloned here 2017-11-27 14:03:33 +02:00
Sebastian Dröge
d4bd1c2d76 Add dox feature to everything as needed 2017-11-12 13:33:02 +01:00
Sebastian Dröge
85b335fd89 Fix/hide various clippy warnings in gstreamer 2017-09-10 15:21:26 +03:00
Sebastian Dröge
3b0e6843e2 Regenerate everything with latest GIR 2017-09-09 16:35:01 +03:00
Sebastian Dröge
f0935d7e1e Add remaining gst_init() assertions 2017-08-30 14:39:09 +03:00
Sebastian Dröge
165d85646f Move futures based BusStream from examples to the bindings 
And hide behind the "futures" feature.

Fixes https://github.com/sdroege/gstreamer-rs/issues/26
 2017-08-17 13:07:59 +03:00
Sebastian Dröge
77cb4da32a Add ClockId and related waiting API, and SystemClock 
Fixes https://github.com/sdroege/gstreamer-rs/issues/23
 2017-08-14 01:41:37 +03:00
Sebastian Dröge
32c5218e7d Fix indentation 2017-08-02 19:41:33 +03:00
Sebastian Dröge
09db28bbf5 Fix various clippy warnings 2017-08-02 19:40:31 +03:00
Sebastian Dröge
23ef3c1f08 Add a function to unset the Bus' current sync handler 
And use it in the Tokio example to unset the handler once the BusStream
is dropped.
 2017-08-01 20:52:29 +03:00
Sebastian Dröge
7c600bfce3 Fix unsafety of pad probes and sync bus handler 
These can't be FnMut but must be Fn as they can be called from many
threads at the same time.
 2017-08-01 15:28:36 +01:00
Sebastian Dröge
03285a6311 Run everything through latest rustfmt-nightly 2017-07-31 12:16:42 +01:00
Sebastian Dröge
64f8b8c015 Add missing manual Bus bindings 2017-07-12 10:28:42 +03:00