From 6b4f6ca45cf99c54bbccb204d5e918592c86c379 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Mon, 13 Sep 2021 11:34:00 +0300
Subject: [PATCH] gstreamer/device_provider: Add constructor for device
 provider metadata

---
 gstreamer/src/subclass/device_provider.rs | 62 ++++++++++++++++++++---
 1 file changed, 56 insertions(+), 6 deletions(-)

diff --git a/gstreamer/src/subclass/device_provider.rs b/gstreamer/src/subclass/device_provider.rs
index f9c507340..a3fd5744a 100644
--- a/gstreamer/src/subclass/device_provider.rs
+++ b/gstreamer/src/subclass/device_provider.rs
@@ -4,17 +4,67 @@ use glib::prelude::*;
 use glib::subclass::prelude::*;
 use glib::translate::*;
 
+use std::borrow::Cow;
+
 use crate::Device;
 use crate::DeviceProvider;
 use crate::LoggableError;
 
 #[derive(Debug, Clone)]
 pub struct DeviceProviderMetadata {
-    long_name: String,
-    classification: String,
-    description: String,
-    author: String,
-    additional: Vec<(String, String)>,
+    long_name: Cow<'static, str>,
+    classification: Cow<'static, str>,
+    description: Cow<'static, str>,
+    author: Cow<'static, str>,
+    additional: Cow<'static, [(Cow<'static, str>, Cow<'static, str>)]>,
+}
+
+impl DeviceProviderMetadata {
+    pub fn new(long_name: &str, classification: &str, description: &str, author: &str) -> Self {
+        Self {
+            long_name: Cow::Owned(long_name.into()),
+            classification: Cow::Owned(classification.into()),
+            description: Cow::Owned(description.into()),
+            author: Cow::Owned(author.into()),
+            additional: Cow::Borrowed(&[]),
+        }
+    }
+
+    pub fn with_additional(
+        long_name: &str,
+        classification: &str,
+        description: &str,
+        author: &str,
+        additional: &[(&str, &str)],
+    ) -> Self {
+        Self {
+            long_name: Cow::Owned(long_name.into()),
+            classification: Cow::Owned(classification.into()),
+            description: Cow::Owned(description.into()),
+            author: Cow::Owned(author.into()),
+            additional: additional
+                .iter()
+                .copied()
+                .map(|(key, value)| (Cow::Owned(key.into()), Cow::Owned(value.into())))
+                .collect(),
+        }
+    }
+
+    pub const fn with_cow(
+        long_name: Cow<'static, str>,
+        classification: Cow<'static, str>,
+        description: Cow<'static, str>,
+        author: Cow<'static, str>,
+        additional: Cow<'static, [(Cow<'static, str>, Cow<'static, str>)]>,
+    ) -> Self {
+        Self {
+            long_name,
+            classification,
+            description,
+            author,
+            additional,
+        }
+    }
 }
 
 pub trait DeviceProviderImpl: DeviceProviderImplExt + ObjectImpl + Send + Sync {
@@ -109,7 +159,7 @@ unsafe impl<T: DeviceProviderImpl> IsSubclassable<T> for DeviceProvider {
                     metadata.author.to_glib_none().0,
                 );
 
-                for (key, value) in &metadata.additional {
+                for (key, value) in metadata.additional.iter() {
                     ffi::gst_device_provider_class_add_metadata(
                         klass,
                         key.to_glib_none().0,