mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-12-13 20:16:30 +00:00
52d3652f2e
Use IDs of the forge to fetch repositories instead of their names and owner names. This improves handling of renamed and transferred repos. TODO - [ ] try to support as many forges as possible - [x] Gogs (no API) - [ ] Bitbucket Server - [x] Coding (no API?) - [x] update repo every time it is fetched or received from the forge - [x] if repo remote IDs are not available, use owner / name to get it - [x] handle redirections (redirect a renamed repo to its new path) - [x] ~~pull all repos once during migration to update ID (?)~~ issue fixed by on-demand loading of remote IDs - [x] handle redirections in web UI - [ ] improve handling of hooks after a repo was renamed (currently it checks for a redirection to the repo) - [x] tests - [x] `UNIQUE` constraint for remote IDs after migration shouldn't work (all repos have an empty string as remote ID) close #854 close #648 partial close https://codeberg.org/Codeberg-CI/feedback/issues/46 Possible follow-up PRs - apply the same scheme on everything fetched from the remote (currently only users) Co-authored-by: 6543 <6543@obermui.de>
194 lines
4.1 KiB
Go
194 lines
4.1 KiB
Go
// Copyright 2018 Drone.IO Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datastore
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/woodpecker-ci/woodpecker/server/model"
|
|
)
|
|
|
|
func TestPermFind(t *testing.T) {
|
|
store, closer := newTestStore(t, new(model.Repo), new(model.Perm), new(model.User))
|
|
defer closer()
|
|
|
|
user := &model.User{ID: 1}
|
|
repo := &model.Repo{
|
|
UserID: 1,
|
|
FullName: "bradrydzewski/test",
|
|
Owner: "bradrydzewski",
|
|
Name: "test",
|
|
RemoteID: "1",
|
|
}
|
|
assert.NoError(t, store.CreateRepo(repo))
|
|
|
|
err := store.PermUpsert(
|
|
&model.Perm{
|
|
UserID: user.ID,
|
|
RepoID: repo.ID,
|
|
Repo: repo,
|
|
Pull: true,
|
|
Push: false,
|
|
Admin: false,
|
|
},
|
|
)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
perm, err := store.PermFind(user, repo)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
if got, want := perm.Pull, true; got != want {
|
|
t.Errorf("Wanted pull %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Push, false; got != want {
|
|
t.Errorf("Wanted push %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Admin, false; got != want {
|
|
t.Errorf("Wanted admin %v, got %v", want, got)
|
|
}
|
|
}
|
|
|
|
func TestPermUpsert(t *testing.T) {
|
|
store, closer := newTestStore(t, new(model.Repo), new(model.Perm), new(model.User))
|
|
defer closer()
|
|
|
|
user := &model.User{ID: 1}
|
|
repo := &model.Repo{
|
|
UserID: 1,
|
|
FullName: "bradrydzewski/test",
|
|
Owner: "bradrydzewski",
|
|
Name: "test",
|
|
RemoteID: "1",
|
|
}
|
|
assert.NoError(t, store.CreateRepo(repo))
|
|
|
|
err := store.PermUpsert(
|
|
&model.Perm{
|
|
UserID: user.ID,
|
|
RepoID: repo.ID,
|
|
Repo: repo,
|
|
Pull: true,
|
|
Push: false,
|
|
Admin: false,
|
|
},
|
|
)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
perm, err := store.PermFind(user, repo)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
if got, want := perm.Pull, true; got != want {
|
|
t.Errorf("Wanted pull %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Push, false; got != want {
|
|
t.Errorf("Wanted push %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Admin, false; got != want {
|
|
t.Errorf("Wanted admin %v, got %v", want, got)
|
|
}
|
|
|
|
//
|
|
// this will attempt to replace the existing permissions
|
|
// using the insert or replace logic.
|
|
//
|
|
|
|
err = store.PermUpsert(
|
|
&model.Perm{
|
|
UserID: user.ID,
|
|
RepoID: repo.ID,
|
|
Repo: repo,
|
|
Pull: true,
|
|
Push: true,
|
|
Admin: true,
|
|
},
|
|
)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
perm, err = store.PermFind(user, repo)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
if got, want := perm.Pull, true; got != want {
|
|
t.Errorf("Wanted pull %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Push, true; got != want {
|
|
t.Errorf("Wanted push %v, got %v", want, got)
|
|
}
|
|
if got, want := perm.Admin, true; got != want {
|
|
t.Errorf("Wanted admin %v, got %v", want, got)
|
|
}
|
|
}
|
|
|
|
func TestPermDelete(t *testing.T) {
|
|
store, closer := newTestStore(t, new(model.Repo), new(model.Perm), new(model.User))
|
|
defer closer()
|
|
|
|
user := &model.User{ID: 1}
|
|
repo := &model.Repo{
|
|
UserID: 1,
|
|
FullName: "bradrydzewski/test",
|
|
Owner: "bradrydzewski",
|
|
Name: "test",
|
|
RemoteID: "1",
|
|
}
|
|
assert.NoError(t, store.CreateRepo(repo))
|
|
|
|
err := store.PermUpsert(
|
|
&model.Perm{
|
|
UserID: user.ID,
|
|
RepoID: repo.ID,
|
|
Repo: repo,
|
|
Pull: true,
|
|
Push: false,
|
|
Admin: false,
|
|
},
|
|
)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: insert perm: %s", err)
|
|
return
|
|
}
|
|
|
|
perm, err := store.PermFind(user, repo)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: select perm: %s", err)
|
|
return
|
|
}
|
|
err = store.PermDelete(perm)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: delete perm: %s", err)
|
|
return
|
|
}
|
|
_, err = store.PermFind(user, repo)
|
|
if err == nil {
|
|
t.Errorf("Expect error: sql.ErrNoRows")
|
|
return
|
|
}
|
|
}
|