mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-12-13 20:16:30 +00:00
52d3652f2e
Use IDs of the forge to fetch repositories instead of their names and owner names. This improves handling of renamed and transferred repos.
TODO
- [ ] try to support as many forges as possible
- [x] Gogs (no API)
- [ ] Bitbucket Server
- [x] Coding (no API?)
- [x] update repo every time it is fetched or received from the forge
- [x] if repo remote IDs are not available, use owner / name to get it
- [x] handle redirections (redirect a renamed repo to its new path)
- [x] ~~pull all repos once during migration to update ID (?)~~ issue fixed by on-demand loading of remote IDs
- [x] handle redirections in web UI
- [ ] improve handling of hooks after a repo was renamed (currently it checks for a redirection to the repo)
- [x] tests
- [x] `UNIQUE` constraint for remote IDs after migration shouldn't work (all repos have an empty string as remote ID)
close #854
close #648 partial
close https://codeberg.org/Codeberg-CI/feedback/issues/46
Possible follow-up PRs
- apply the same scheme on everything fetched from the remote (currently only users)
Co-authored-by: 6543 <6543@obermui.de>
109 lines
3 KiB
Go
109 lines
3 KiB
Go
// Copyright 2021 Woodpecker Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datastore
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/woodpecker-ci/woodpecker/server/model"
|
|
)
|
|
|
|
func TestRepoListLatest(t *testing.T) {
|
|
store, closer := newTestStore(t, new(model.Repo), new(model.User), new(model.Perm), new(model.Build))
|
|
defer closer()
|
|
|
|
user := &model.User{
|
|
Login: "joe",
|
|
Email: "foo@bar.com",
|
|
Token: "e42080dddf012c718e476da161d21ad5",
|
|
}
|
|
assert.NoError(t, store.CreateUser(user))
|
|
|
|
repo1 := &model.Repo{
|
|
Owner: "bradrydzewski",
|
|
Name: "test",
|
|
FullName: "bradrydzewski/test",
|
|
RemoteID: "1",
|
|
IsActive: true,
|
|
}
|
|
repo2 := &model.Repo{
|
|
Owner: "test",
|
|
Name: "test",
|
|
FullName: "test/test",
|
|
RemoteID: "2",
|
|
IsActive: true,
|
|
}
|
|
repo3 := &model.Repo{
|
|
Owner: "octocat",
|
|
Name: "hello-world",
|
|
FullName: "octocat/hello-world",
|
|
RemoteID: "3",
|
|
IsActive: true,
|
|
}
|
|
assert.NoError(t, store.CreateRepo(repo1))
|
|
assert.NoError(t, store.CreateRepo(repo2))
|
|
assert.NoError(t, store.CreateRepo(repo3))
|
|
|
|
for _, perm := range []*model.Perm{
|
|
{UserID: user.ID, Repo: repo1, Push: true, Admin: false},
|
|
{UserID: user.ID, Repo: repo2, Push: true, Admin: true},
|
|
} {
|
|
assert.NoError(t, store.PermUpsert(perm))
|
|
}
|
|
|
|
build1 := &model.Build{
|
|
RepoID: repo1.ID,
|
|
Status: model.StatusFailure,
|
|
}
|
|
build2 := &model.Build{
|
|
RepoID: repo1.ID,
|
|
Status: model.StatusRunning,
|
|
}
|
|
build3 := &model.Build{
|
|
RepoID: repo2.ID,
|
|
Status: model.StatusKilled,
|
|
}
|
|
build4 := &model.Build{
|
|
RepoID: repo3.ID,
|
|
Status: model.StatusError,
|
|
}
|
|
assert.NoError(t, store.CreateBuild(build1))
|
|
assert.NoError(t, store.CreateBuild(build2))
|
|
assert.NoError(t, store.CreateBuild(build3))
|
|
assert.NoError(t, store.CreateBuild(build4))
|
|
|
|
builds, err := store.RepoListLatest(user)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: repository list with latest build: %s", err)
|
|
return
|
|
}
|
|
if got, want := len(builds), 2; got != want {
|
|
t.Errorf("Want %d repositories, got %d", want, got)
|
|
}
|
|
if got, want := builds[0].Status, string(model.StatusRunning); want != got {
|
|
t.Errorf("Want repository status %s, got %s", want, got)
|
|
}
|
|
if got, want := builds[0].FullName, repo1.FullName; want != got {
|
|
t.Errorf("Want repository name %s, got %s", want, got)
|
|
}
|
|
if got, want := builds[1].Status, string(model.StatusKilled); want != got {
|
|
t.Errorf("Want repository status %s, got %s", want, got)
|
|
}
|
|
if got, want := builds[1].FullName, repo2.FullName; want != got {
|
|
t.Errorf("Want repository name %s, got %s", want, got)
|
|
}
|
|
}
|