From 7189cd61bf1a1ce27259a45b3e94bfe5b2b911c4 Mon Sep 17 00:00:00 2001
From: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Date: Sun, 1 Dec 2024 21:39:00 +0200
Subject: [PATCH 1/2] Some UI improvements (#4497)

Co-authored-by: Robert Kaussow <xoxys@rknet.org>
---
 web/src/components/atomic/Badge.vue               | 7 +++++--
 web/src/views/org/settings/OrgSettingsWrapper.vue | 8 ++++----
 web/src/views/user/UserCLIAndAPI.vue              | 2 +-
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/web/src/components/atomic/Badge.vue b/web/src/components/atomic/Badge.vue
index c8bd5d5be..64e31ddf0 100644
--- a/web/src/components/atomic/Badge.vue
+++ b/web/src/components/atomic/Badge.vue
@@ -1,14 +1,17 @@
 <template>
   <span class="text-xs font-medium inline-flex">
     <span
-      class="pl-2 pr-1 py-0.5 bg-wp-state-neutral-100 text-gray-300 border-2 border-wp-state-neutral-100 rounded-l-full"
+      class="pl-2 pr-1 py-0.5 bg-wp-state-neutral-100 text-gray-300 border-2 border-wp-state-neutral-100 rounded-l-full flex items-center"
       :class="{
         'rounded-r-full pr-2': value === undefined,
       }"
     >
       {{ label }}
     </span>
-    <span v-if="value !== undefined" class="pl-1 pr-2 py-0.5 border-2 border-wp-state-neutral-100 rounded-r-full">
+    <span
+      v-if="value !== undefined"
+      class="pl-1 pr-2 py-0.5 border-2 border-wp-state-neutral-100 rounded-r-full flex items-center"
+    >
       {{ value }}
     </span>
   </span>
diff --git a/web/src/views/org/settings/OrgSettingsWrapper.vue b/web/src/views/org/settings/OrgSettingsWrapper.vue
index e1cf581d8..1aafffb93 100644
--- a/web/src/views/org/settings/OrgSettingsWrapper.vue
+++ b/web/src/views/org/settings/OrgSettingsWrapper.vue
@@ -2,10 +2,10 @@
   <Scaffold v-if="org" enable-tabs :go-back="goBack">
     <template #title>
       <span>
-        <router-link :to="{ name: 'org' }" class="hover:underline">
-          {{ org.name }}
-          <!-- eslint-disable-next-line @intlify/vue-i18n/no-raw-text -->
-        </router-link>
+        <router-link :to="{ name: 'org' }" class="hover:underline">{{
+          org.name
+          /* eslint-disable-next-line @intlify/vue-i18n/no-raw-text */
+        }}</router-link>
         /
         {{ $t('settings') }}
       </span>
diff --git a/web/src/views/user/UserCLIAndAPI.vue b/web/src/views/user/UserCLIAndAPI.vue
index 55feba35b..dbf550a4b 100644
--- a/web/src/views/user/UserCLIAndAPI.vue
+++ b/web/src/views/user/UserCLIAndAPI.vue
@@ -10,7 +10,7 @@
     </InputField>
 
     <InputField :label="$t('user.settings.cli_and_api.token')">
-      <template #headerActions>
+      <template #titleActions>
         <Button class="ml-auto" :text="$t('user.settings.cli_and_api.reset_token')" @click="resetToken" />
       </template>
       <pre class="code-box">{{ token }}</pre>

From 3c31284e7bfb75c049d6b52af0687daaf2b29b4c Mon Sep 17 00:00:00 2001
From: Robert Kaussow <mail@thegeeklab.de>
Date: Sun, 1 Dec 2024 20:39:47 +0100
Subject: [PATCH 2/2] Use pagination helper to list pipelines in cli (#4478)

Co-authored-by: 6543 <6543@obermui.de>
---
 cli/pipeline/create.go           |  2 +-
 cli/pipeline/last.go             |  2 +-
 cli/pipeline/list.go             | 56 ++++++++++++++-----------------
 cli/pipeline/list_test.go        | 57 +++++++-------------------------
 cli/pipeline/pipeline.go         |  6 ++--
 cli/pipeline/pipeline_test.go    |  2 +-
 cli/pipeline/show.go             |  2 +-
 woodpecker-go/woodpecker/repo.go | 21 ++++++++++--
 8 files changed, 62 insertions(+), 86 deletions(-)

diff --git a/cli/pipeline/create.go b/cli/pipeline/create.go
index e343c24a0..7f079f818 100644
--- a/cli/pipeline/create.go
+++ b/cli/pipeline/create.go
@@ -74,5 +74,5 @@ func pipelineCreate(ctx context.Context, c *cli.Command) error {
 		return err
 	}
 
-	return pipelineOutput(c, []woodpecker.Pipeline{*pipeline})
+	return pipelineOutput(c, []*woodpecker.Pipeline{pipeline})
 }
diff --git a/cli/pipeline/last.go b/cli/pipeline/last.go
index 49f161142..68e6cbb2f 100644
--- a/cli/pipeline/last.go
+++ b/cli/pipeline/last.go
@@ -58,5 +58,5 @@ func pipelineLast(ctx context.Context, c *cli.Command) error {
 		return err
 	}
 
-	return pipelineOutput(c, []woodpecker.Pipeline{*pipeline})
+	return pipelineOutput(c, []*woodpecker.Pipeline{pipeline})
 }
diff --git a/cli/pipeline/list.go b/cli/pipeline/list.go
index afe1f3803..930e0e84f 100644
--- a/cli/pipeline/list.go
+++ b/cli/pipeline/list.go
@@ -22,6 +22,7 @@ import (
 
 	"go.woodpecker-ci.org/woodpecker/v2/cli/common"
 	"go.woodpecker-ci.org/woodpecker/v2/cli/internal"
+	shared_utils "go.woodpecker-ci.org/woodpecker/v2/shared/utils"
 	"go.woodpecker-ci.org/woodpecker/v2/woodpecker-go/woodpecker"
 )
 
@@ -77,60 +78,51 @@ func List(ctx context.Context, c *cli.Command) error {
 	if err != nil {
 		return err
 	}
-	resources, err := pipelineList(c, client)
+	pipelines, err := pipelineList(c, client)
 	if err != nil {
 		return err
 	}
-	return pipelineOutput(c, resources)
+	return pipelineOutput(c, pipelines)
 }
 
-func pipelineList(c *cli.Command, client woodpecker.Client) ([]woodpecker.Pipeline, error) {
-	resources := make([]woodpecker.Pipeline, 0)
-
+func pipelineList(c *cli.Command, client woodpecker.Client) ([]*woodpecker.Pipeline, error) {
 	repoIDOrFullName := c.Args().First()
 	repoID, err := internal.ParseRepo(client, repoIDOrFullName)
 	if err != nil {
-		return resources, err
+		return nil, err
 	}
 
 	opt := woodpecker.PipelineListOptions{}
-	before := c.Timestamp("before")
-	after := c.Timestamp("after")
 
-	if !before.IsZero() {
+	if before := c.Timestamp("before"); !before.IsZero() {
 		opt.Before = before
 	}
-	if !after.IsZero() {
+	if after := c.Timestamp("after"); !after.IsZero() {
 		opt.After = after
 	}
 
-	pipelines, err := client.PipelineList(repoID, opt)
-	if err != nil {
-		return resources, err
-	}
-
 	branch := c.String("branch")
 	event := c.String("event")
 	status := c.String("status")
 	limit := int(c.Int("limit"))
 
-	var count int
-	for _, pipeline := range pipelines {
-		if count >= limit {
-			break
-		}
-		if branch != "" && pipeline.Branch != branch {
-			continue
-		}
-		if event != "" && pipeline.Event != event {
-			continue
-		}
-		if status != "" && pipeline.Status != status {
-			continue
-		}
-		resources = append(resources, *pipeline)
-		count++
+	pipelines, err := shared_utils.Paginate(func(page int) ([]*woodpecker.Pipeline, error) {
+		return client.PipelineList(repoID,
+			woodpecker.PipelineListOptions{
+				ListOptions: woodpecker.ListOptions{
+					Page: page,
+				},
+				Before: opt.Before,
+				After:  opt.After,
+				Branch: branch,
+				Events: []string{event},
+				Status: status,
+			},
+		)
+	}, limit)
+	if err != nil {
+		return nil, err
 	}
 
-	return resources, nil
+	return pipelines, nil
 }
diff --git a/cli/pipeline/list_test.go b/cli/pipeline/list_test.go
index e73bffe57..4668b2fb3 100644
--- a/cli/pipeline/list_test.go
+++ b/cli/pipeline/list_test.go
@@ -22,7 +22,7 @@ func TestPipelineList(t *testing.T) {
 		pipelines   []*woodpecker.Pipeline
 		pipelineErr error
 		args        []string
-		expected    []woodpecker.Pipeline
+		expected    []*woodpecker.Pipeline
 		wantErr     error
 	}{
 		{
@@ -34,53 +34,12 @@ func TestPipelineList(t *testing.T) {
 				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
 			},
 			args: []string{"ls", "repo/name"},
-			expected: []woodpecker.Pipeline{
+			expected: []*woodpecker.Pipeline{
 				{ID: 1, Branch: "main", Event: "push", Status: "success"},
 				{ID: 2, Branch: "develop", Event: "pull_request", Status: "running"},
 				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
 			},
 		},
-		{
-			name:   "filter by branch",
-			repoID: 1,
-			pipelines: []*woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-				{ID: 2, Branch: "develop", Event: "pull_request", Status: "running"},
-				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
-			},
-			args: []string{"ls", "--branch", "main", "repo/name"},
-			expected: []woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
-			},
-		},
-		{
-			name:   "filter by event",
-			repoID: 1,
-			pipelines: []*woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-				{ID: 2, Branch: "develop", Event: "pull_request", Status: "running"},
-				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
-			},
-			args: []string{"ls", "--event", "push", "repo/name"},
-			expected: []woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
-			},
-		},
-		{
-			name:   "filter by status",
-			repoID: 1,
-			pipelines: []*woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-				{ID: 2, Branch: "develop", Event: "pull_request", Status: "running"},
-				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
-			},
-			args: []string{"ls", "--status", "success", "repo/name"},
-			expected: []woodpecker.Pipeline{
-				{ID: 1, Branch: "main", Event: "push", Status: "success"},
-			},
-		},
 		{
 			name:   "limit results",
 			repoID: 1,
@@ -90,7 +49,7 @@ func TestPipelineList(t *testing.T) {
 				{ID: 3, Branch: "main", Event: "push", Status: "failure"},
 			},
 			args: []string{"ls", "--limit", "2", "repo/name"},
-			expected: []woodpecker.Pipeline{
+			expected: []*woodpecker.Pipeline{
 				{ID: 1, Branch: "main", Event: "push", Status: "success"},
 				{ID: 2, Branch: "develop", Event: "pull_request", Status: "running"},
 			},
@@ -107,7 +66,15 @@ func TestPipelineList(t *testing.T) {
 	for _, tt := range testtases {
 		t.Run(tt.name, func(t *testing.T) {
 			mockClient := mocks.NewClient(t)
-			mockClient.On("PipelineList", mock.Anything, mock.Anything).Return(tt.pipelines, tt.pipelineErr)
+			mockClient.On("PipelineList", mock.Anything, mock.Anything).Return(func(_ int64, opt woodpecker.PipelineListOptions) ([]*woodpecker.Pipeline, error) {
+				if tt.pipelineErr != nil {
+					return nil, tt.pipelineErr
+				}
+				if opt.Page == 1 {
+					return tt.pipelines, nil
+				}
+				return []*woodpecker.Pipeline{}, nil
+			}).Maybe()
 			mockClient.On("RepoLookup", mock.Anything).Return(&woodpecker.Repo{ID: tt.repoID}, nil)
 
 			command := buildPipelineListCmd()
diff --git a/cli/pipeline/pipeline.go b/cli/pipeline/pipeline.go
index cc86ddf07..04bd256df 100644
--- a/cli/pipeline/pipeline.go
+++ b/cli/pipeline/pipeline.go
@@ -50,7 +50,7 @@ var Command = &cli.Command{
 	},
 }
 
-func pipelineOutput(c *cli.Command, resources []woodpecker.Pipeline, fd ...io.Writer) error {
+func pipelineOutput(c *cli.Command, pipelines []*woodpecker.Pipeline, fd ...io.Writer) error {
 	outFmt, outOpt := output.ParseOutputOptions(c.String("output"))
 	noHeader := c.Bool("output-no-headers")
 
@@ -74,7 +74,7 @@ func pipelineOutput(c *cli.Command, resources []woodpecker.Pipeline, fd ...io.Wr
 		if err != nil {
 			return err
 		}
-		if err := tmpl.Execute(out, resources); err != nil {
+		if err := tmpl.Execute(out, pipelines); err != nil {
 			return err
 		}
 	case "table":
@@ -89,7 +89,7 @@ func pipelineOutput(c *cli.Command, resources []woodpecker.Pipeline, fd ...io.Wr
 		if !noHeader {
 			table.WriteHeader(cols)
 		}
-		for _, resource := range resources {
+		for _, resource := range pipelines {
 			if err := table.Write(cols, resource); err != nil {
 				return err
 			}
diff --git a/cli/pipeline/pipeline_test.go b/cli/pipeline/pipeline_test.go
index ce69e5946..4bbe52b31 100644
--- a/cli/pipeline/pipeline_test.go
+++ b/cli/pipeline/pipeline_test.go
@@ -47,7 +47,7 @@ func TestPipelineOutput(t *testing.T) {
 		},
 	}
 
-	pipelines := []woodpecker.Pipeline{
+	pipelines := []*woodpecker.Pipeline{
 		{
 			Number:  1,
 			Status:  "success",
diff --git a/cli/pipeline/show.go b/cli/pipeline/show.go
index 165c6a70a..2f14224af 100644
--- a/cli/pipeline/show.go
+++ b/cli/pipeline/show.go
@@ -65,5 +65,5 @@ func pipelineShow(ctx context.Context, c *cli.Command) error {
 		return err
 	}
 
-	return pipelineOutput(c, []woodpecker.Pipeline{*pipeline})
+	return pipelineOutput(c, []*woodpecker.Pipeline{pipeline})
 }
diff --git a/woodpecker-go/woodpecker/repo.go b/woodpecker-go/woodpecker/repo.go
index 5c24b228d..876a4e413 100644
--- a/woodpecker-go/woodpecker/repo.go
+++ b/woodpecker-go/woodpecker/repo.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"net/url"
 	"strconv"
+	"strings"
 	"time"
 )
 
@@ -31,8 +32,12 @@ const (
 
 type PipelineListOptions struct {
 	ListOptions
-	Before time.Time
-	After  time.Time
+	Before      time.Time
+	After       time.Time
+	Branch      string
+	Events      []string
+	RefContains string
+	Status      string
 }
 
 type CronListOptions struct {
@@ -77,6 +82,18 @@ func (opt *PipelineListOptions) QueryEncode() string {
 	if !opt.After.IsZero() {
 		query.Add("after", opt.After.Format(time.RFC3339))
 	}
+	if opt.Branch != "" {
+		query.Add("branch", opt.Branch)
+	}
+	if len(opt.Events) > 0 {
+		query.Add("event", strings.Join(opt.Events, ","))
+	}
+	if opt.RefContains != "" {
+		query.Add("ref", opt.RefContains)
+	}
+	if opt.Status != "" {
+		query.Add("status", opt.Status)
+	}
 	return query.Encode()
 }