From eaf05dbae84b751ee972daae97f626f7de61487d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=83=B3=E5=87=BA=E7=BD=91=E5=90=8D=E5=95=A6?= Date: Thu, 8 Sep 2022 00:34:08 +0800 Subject: [PATCH] On Repo update, keep old "Clone" if update would empty it (#1170) fixed #1169 after debugging, I found that: if `Clone` in database is empty, before https://github.com/woodpecker-ci/woodpecker/blob/master/server/api/hook.go#L128, the `repo.Clone` be always unset, so clone is failed. This PR makes the empty `Clone` can't overwrite the value in database. --- server/model/repo.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/model/repo.go b/server/model/repo.go index 0c60b08a0..afb018319 100644 --- a/server/model/repo.go +++ b/server/model/repo.go @@ -82,7 +82,9 @@ func (r *Repo) Update(from *Repo) { r.Avatar = from.Avatar r.Link = from.Link r.SCMKind = from.SCMKind - r.Clone = from.Clone + if len(from.Clone) > 0 { + r.Clone = from.Clone + } r.Branch = from.Branch if from.IsSCMPrivate != r.IsSCMPrivate { if from.IsSCMPrivate {