From c60c59bd651d3635677d60ea178d3644a5bd598f Mon Sep 17 00:00:00 2001
From: Hayden <64056131+hay-kot@users.noreply.github.com>
Date: Mon, 13 Mar 2023 18:42:11 -0800
Subject: [PATCH] fix: apply permissions when flatPermissions enabled (#1603)

Closes #1582

When `WOODPECKER_FLAT_PERMISSIONS=true` workaround is applied all
permissions are set to false (default) and query never returns any
matches.

This fixes it by always assigning Pull/Push/Admin to true when flatPermissions is enabled.
---
 server/forge/userSyncer.go | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/server/forge/userSyncer.go b/server/forge/userSyncer.go
index ad464590e..83b99fce1 100644
--- a/server/forge/userSyncer.go
+++ b/server/forge/userSyncer.go
@@ -78,11 +78,9 @@ func (s *Syncer) Sync(ctx context.Context, user *model.User, flatPermissions boo
 
 			// TODO(485) temporary workaround to not hit api rate limits
 			if flatPermissions {
-				if repo.Perm == nil {
-					repo.Perm.Pull = true
-					repo.Perm.Push = true
-					repo.Perm.Admin = true
-				}
+				repo.Perm.Pull = true
+				repo.Perm.Push = true
+				repo.Perm.Admin = true
 			} else {
 				forgePerm, err := s.Forge.Perm(ctx, user, repo)
 				if err != nil {