From 3539988604c2c80c484272d99e459113aaa8b172 Mon Sep 17 00:00:00 2001 From: Vaidas Jablonskis Date: Fri, 19 Aug 2016 18:27:08 +0100 Subject: [PATCH] Fix URI encoding fmt.Sprintf was interpreting URL encoding chars previously. Ouch. --- client/client_impl.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/client/client_impl.go b/client/client_impl.go index 89f78f7c0..ca661a88e 100644 --- a/client/client_impl.go +++ b/client/client_impl.go @@ -222,8 +222,8 @@ func (c *client) BuildQueue() ([]*model.Feed, error) { func (c *client) BuildStart(owner, name string, num int, params map[string]string) (*model.Build, error) { out := new(model.Build) val := parseToQueryParams(params) - uri := fmt.Sprintf(pathBuild+"?"+val.Encode(), c.base, owner, name, num) - err := c.post(uri, nil, out) + uri := fmt.Sprintf(pathBuild, c.base, owner, name, num) + err := c.post(uri+"?"+val.Encode(), nil, out) return out, err } @@ -240,8 +240,8 @@ func (c *client) BuildFork(owner, name string, num int, params map[string]string out := new(model.Build) val := parseToQueryParams(params) val.Set("fork", "true") - uri := fmt.Sprintf(pathBuild+"?"+val.Encode(), c.base, owner, name, num) - err := c.post(uri, nil, out) + uri := fmt.Sprintf(pathBuild, c.base, owner, name, num) + err := c.post(uri+"?"+val.Encode(), nil, out) return out, err } @@ -259,8 +259,8 @@ func (c *client) Deploy(owner, name string, num int, env string, params map[stri val.Set("fork", "true") val.Set("event", "deployment") val.Set("deploy_to", env) - uri := fmt.Sprintf(pathBuild+"?"+val.Encode(), c.base, owner, name, num) - err := c.post(uri, nil, out) + uri := fmt.Sprintf(pathBuild, c.base, owner, name, num) + err := c.post(uri+"?"+val.Encode(), nil, out) return out, err }