From 7d64138855a1994a59ac0cb193f1c676a99be535 Mon Sep 17 00:00:00 2001
From: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Date: Sun, 5 Jan 2025 13:46:08 +0200
Subject: [PATCH] Do not start metrics collector if metrics are disabled
 (#4667)

---
 cmd/server/server.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd/server/server.go b/cmd/server/server.go
index 420f0c500..b6ab3c3b7 100644
--- a/cmd/server/server.go
+++ b/cmd/server/server.go
@@ -111,8 +111,6 @@ func run(ctx context.Context, c *cli.Command) error {
 
 	log.Info().Msgf("starting Woodpecker server with version '%s'", version.String())
 
-	startMetricsCollector(ctx, _store)
-
 	serviceWaitingGroup.Go(func() error {
 		log.Info().Msg("starting cron service ...")
 		if err := cron.Run(ctx, _store); err != nil {
@@ -260,6 +258,8 @@ func run(ctx context.Context, c *cli.Command) error {
 	}
 
 	if metricsServerAddr := c.String("metrics-server-addr"); metricsServerAddr != "" {
+		startMetricsCollector(ctx, _store)
+
 		serviceWaitingGroup.Go(func() error {
 			metricsRouter := gin.New()
 			metricsRouter.GET("/metrics", gin.WrapH(prometheus_http.Handler()))