From 47b9dab016fde8faeb8446775aee76a2a1077357 Mon Sep 17 00:00:00 2001 From: Sebastian P <5564491+s3lph@users.noreply.github.com> Date: Sun, 10 Sep 2023 13:33:48 +0200 Subject: [PATCH] Fix: change tasks.task_data column type to longblob in mysql (#2418) Fix #2206 Changes are copied and adapted from #1050 --- server/model/task.go | 2 +- .../datastore/migration/023_task_data_type.go | 37 +++++++++++++++++++ server/store/datastore/migration/migration.go | 1 + 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 server/store/datastore/migration/023_task_data_type.go diff --git a/server/model/task.go b/server/model/task.go index 030701cb7..b9af56069 100644 --- a/server/model/task.go +++ b/server/model/task.go @@ -29,7 +29,7 @@ type TaskStore interface { // Task defines scheduled pipeline Task. type Task struct { ID string `json:"id" xorm:"PK UNIQUE 'task_id'"` - Data []byte `json:"data" xorm:"'task_data'"` + Data []byte `json:"data" xorm:"LONGBLOB 'task_data'"` Labels map[string]string `json:"labels" xorm:"json 'task_labels'"` Dependencies []string `json:"dependencies" xorm:"json 'task_dependencies'"` RunOn []string `json:"run_on" xorm:"json 'task_run_on'"` diff --git a/server/store/datastore/migration/023_task_data_type.go b/server/store/datastore/migration/023_task_data_type.go new file mode 100644 index 000000000..9b788c7e4 --- /dev/null +++ b/server/store/datastore/migration/023_task_data_type.go @@ -0,0 +1,37 @@ +// Copyright 2023 Woodpecker Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package migration + +import ( + "xorm.io/xorm" + "xorm.io/xorm/schemas" +) + +var alterTableTasksUpdateColumnTaskDataType = task{ + name: "alter-table-tasks-update-type-of-task-data", + fn: func(sess *xorm.Session) (err error) { + dialect := sess.Engine().Dialect().URI().DBType + + switch dialect { + case schemas.MYSQL: + _, err = sess.Exec("ALTER TABLE tasks MODIFY COLUMN task_data LONGBLOB") + default: + // xorm uses the same type for all blob sizes in sqlite and postgres + return nil + } + + return err + }, +} diff --git a/server/store/datastore/migration/migration.go b/server/store/datastore/migration/migration.go index a4a663cbf..55a058d58 100644 --- a/server/store/datastore/migration/migration.go +++ b/server/store/datastore/migration/migration.go @@ -55,6 +55,7 @@ var migrationTasks = []*task{ &parentStepsToWorkflows, &addOrgs, &addOrgID, + &alterTableTasksUpdateColumnTaskDataType, } var allBeans = []interface{}{