diff --git a/pipeline/backend/kubernetes/kubernetes.go b/pipeline/backend/kubernetes/kubernetes.go index b1f1a0447..443c3d669 100644 --- a/pipeline/backend/kubernetes/kubernetes.go +++ b/pipeline/backend/kubernetes/kubernetes.go @@ -252,10 +252,10 @@ func (e *kube) WaitStep(ctx context.Context, step *types.Step, taskUUID string) finished := make(chan bool) - podUpdated := func(_, new any) { - pod, ok := new.(*v1.Pod) + podUpdated := func(_, newPod any) { + pod, ok := newPod.(*v1.Pod) if !ok { - log.Error().Msgf("could not parse pod: %v", new) + log.Error().Msgf("could not parse pod: %v", newPod) return } @@ -328,10 +328,10 @@ func (e *kube) TailStep(ctx context.Context, step *types.Step, taskUUID string) up := make(chan bool) - podUpdated := func(_, new any) { - pod, ok := new.(*v1.Pod) + podUpdated := func(_, newPod any) { + pod, ok := newPod.(*v1.Pod) if !ok { - log.Error().Msgf("could not parse pod: %v", new) + log.Error().Msgf("could not parse pod: %v", newPod) return } diff --git a/server/store/datastore/migration/common.go b/server/store/datastore/migration/common.go index 5fd10c534..ddc2502a0 100644 --- a/server/store/datastore/migration/common.go +++ b/server/store/datastore/migration/common.go @@ -23,14 +23,14 @@ import ( "xorm.io/xorm/schemas" ) -func renameTable(sess *xorm.Session, old, new string) error { +func renameTable(sess *xorm.Session, oldTable, newTable string) error { dialect := sess.Engine().Dialect().URI().DBType switch dialect { case schemas.MYSQL: - _, err := sess.Exec(fmt.Sprintf("RENAME TABLE `%s` TO `%s`;", old, new)) + _, err := sess.Exec(fmt.Sprintf("RENAME TABLE `%s` TO `%s`;", oldTable, newTable)) return err case schemas.POSTGRES, schemas.SQLITE: - _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` RENAME TO `%s`;", old, new)) + _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` RENAME TO `%s`;", oldTable, newTable)) return err default: return fmt.Errorf("dialect '%s' not supported", dialect) diff --git a/server/store/datastore/migration/migration_test.go b/server/store/datastore/migration/migration_test.go index 661bd01ac..41461217a 100644 --- a/server/store/datastore/migration/migration_test.go +++ b/server/store/datastore/migration/migration_test.go @@ -57,14 +57,14 @@ func createSQLiteDB(t *testing.T) string { return tmpF.Name() } -func testDB(t *testing.T, new bool) (engine *xorm.Engine, closeDB func()) { +func testDB(t *testing.T, initNewDB bool) (engine *xorm.Engine, closeDB func()) { driver := testDriver() var err error closeDB = func() {} switch driver { case "sqlite3": config := ":memory:" - if !new { + if !initNewDB { config = createSQLiteDB(t) closeDB = func() { _ = os.Remove(config) @@ -77,7 +77,7 @@ func testDB(t *testing.T, new bool) (engine *xorm.Engine, closeDB func()) { return case "mysql", "postgres": config := os.Getenv("WOODPECKER_DATABASE_DATASOURCE") - if !new { + if !initNewDB { t.Logf("do not have dump to test against") t.SkipNow() }