From cc709f242cbe8aa9dc323d324a2fb267d2b2ad37 Mon Sep 17 00:00:00 2001 From: Matthias Rampke Date: Fri, 26 Jun 2020 15:17:23 +0000 Subject: [PATCH] Update changelog and readme for #315: SignalFX extension Declare the behavior with mixed tagging as undefined, we don't want to promise anything in that case, not even negatively. Signed-off-by: Matthias Rampke --- CHANGELOG.md | 1 + README.md | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e35c6c..e2c7c01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ * [CHANGE] Support non-timer distributions without unit conversion ([#314](https://github.com/prometheus/statsd_exporter/pull/314)) * [ENHANCEMENT] Offline configuration check ([#312](https://github.com/prometheus/statsd_exporter/pull/312)) +* [ENHANCEMENT] Support the SignalFX tagging extension ([#315](https://github.com/prometheus/statsd_exporter/pull/315)) * [BUGFIX] Allow matching single-letter metric name components ([#309](https://github.com/prometheus/statsd_exporter/pull/309)) Distribution and histogram events (type `d`, `h`) are now treated as distinct from timer events (type `ms`). diff --git a/README.md b/README.md index 3deb637..cbe0369 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ in the long term. ### Tagging Extensions -The exporter supports Librato, InfluxDB, and DogStatsD-style tags, +The exporter supports Librato, InfluxDB, DogStatsD, and SignalFX-style tags, which will be converted into Prometheus labels. For Librato-style tags, they must be appended to the metric name with a @@ -68,9 +68,14 @@ in the DogStatsD documentation for the concept description and If you encounter problems, note that this tagging style is incompatible with the original `statsd` implementation. -Be aware: If you mix tag styles (e.g., Librato/InfluxDB with DogStatsD), the -exporter will consider this an error and the sample will be discarded. Also, -tags without values (`#some_tag`) are not supported and will be ignored. +For [SignalFX dimension](https://docs.signalfx.com/en/latest/integrations/agent/monitors/collectd-statsd.html#adding-dimensions-to-statsd-metrics), add the tags to the metric name in square brackets, as so: + +``` +metric.name[tagName=val,tag2Name=val2]:0|c +``` + +Be aware: If you mix tag styles (e.g., Librato/InfluxDB with DogStatsD), the exporter will consider this an error and the behavior is undefined. +Also, tags without values (`#some_tag`) are not supported and will be ignored. ## Building and Running