mirror of
https://github.com/searxng/searxng.git
synced 2024-12-12 20:36:27 +00:00
bb04699b17
Depending on the order the unit tests are executed, the searx.search module is
initalized or not, issue reported in [1]::
Traceback (most recent call last):
File "searxng/tests/unit/test_results.py", line 72, in test_result_merge_by_title
self.container.extend('stract', [fake_result(engine='stract', title='short title')])
File "searxng/searx/results.py", line 243, in extend
histogram_observe(standard_result_count, 'engine', engine_name, 'result', 'count')
File "searxng/searx/metrics/__init__.py", line 49, in histogram_observe
histogram_storage.get(*args).observe(duration)
^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get'
To ensure that the searx.search module is initialized, the
- searx.engines.load_engines is replace by
- searx.search.initialize
[1] https://github.com/searxng/searxng/pull/3932#discussion_r1822406569
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
75 lines
2.5 KiB
Python
75 lines
2.5 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
# pylint: disable=missing-module-docstring
|
|
|
|
from searx.results import ResultContainer
|
|
import searx.search
|
|
from tests import SearxTestCase
|
|
|
|
|
|
def make_test_engine_dict(**kwargs) -> dict:
|
|
test_engine = {
|
|
# fmt: off
|
|
'name': None,
|
|
'engine': None,
|
|
'categories': 'general',
|
|
'shortcut': 'dummy',
|
|
'timeout': 3.0,
|
|
'tokens': [],
|
|
# fmt: on
|
|
}
|
|
|
|
test_engine.update(**kwargs)
|
|
return test_engine
|
|
|
|
|
|
def fake_result(url='https://aa.bb/cc?dd=ee#ff', title='aaa', content='bbb', engine='wikipedia', **kwargs):
|
|
result = {
|
|
# fmt: off
|
|
'url': url,
|
|
'title': title,
|
|
'content': content,
|
|
'engine': engine,
|
|
# fmt: on
|
|
}
|
|
result.update(kwargs)
|
|
return result
|
|
|
|
|
|
class ResultContainerTestCase(SearxTestCase): # pylint: disable=missing-class-docstring
|
|
|
|
def setUp(self) -> None:
|
|
stract_engine = make_test_engine_dict(name="stract", engine="stract", shortcut="stra")
|
|
duckduckgo_engine = make_test_engine_dict(name="duckduckgo", engine="duckduckgo", shortcut="ddg")
|
|
mojeek_engine = make_test_engine_dict(name="mojeek", engine="mojeek", shortcut="mjk")
|
|
searx.search.initialize([stract_engine, duckduckgo_engine, mojeek_engine])
|
|
self.container = ResultContainer()
|
|
|
|
def tearDown(self):
|
|
searx.search.load_engines([])
|
|
|
|
def test_empty(self):
|
|
self.assertEqual(self.container.get_ordered_results(), [])
|
|
|
|
def test_one_result(self):
|
|
self.container.extend('wikipedia', [fake_result()])
|
|
|
|
self.assertEqual(self.container.results_length(), 1)
|
|
|
|
def test_one_suggestion(self):
|
|
self.container.extend('wikipedia', [fake_result(suggestion=True)])
|
|
|
|
self.assertEqual(len(self.container.suggestions), 1)
|
|
self.assertEqual(self.container.results_length(), 0)
|
|
|
|
def test_result_merge(self):
|
|
self.container.extend('wikipedia', [fake_result()])
|
|
self.container.extend('wikidata', [fake_result(), fake_result(url='https://example.com/')])
|
|
|
|
self.assertEqual(self.container.results_length(), 2)
|
|
|
|
def test_result_merge_by_title(self):
|
|
self.container.extend('stract', [fake_result(engine='stract', title='short title')])
|
|
self.container.extend('duckduckgo', [fake_result(engine='duckduckgo', title='normal title')])
|
|
self.container.extend('mojeek', [fake_result(engine='mojeek', title='this long long title')])
|
|
|
|
self.assertEqual(self.container.get_ordered_results()[0].get('title', ''), 'this long long title')
|