From e509519db4fe6c9c0c3942ebd9ccb540439fba18 Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Sat, 20 Jul 2024 21:21:21 -0400
Subject: [PATCH] Publisher jobs will not retry if the error received is a 400

---
 changelog.d/oban-cancel-badreq.change     | 1 +
 lib/pleroma/web/activity_pub/publisher.ex | 1 +
 2 files changed, 2 insertions(+)
 create mode 100644 changelog.d/oban-cancel-badreq.change

diff --git a/changelog.d/oban-cancel-badreq.change b/changelog.d/oban-cancel-badreq.change
new file mode 100644
index 000000000..c7951735c
--- /dev/null
+++ b/changelog.d/oban-cancel-badreq.change
@@ -0,0 +1 @@
+Publisher jobs will not retry if the error received is a 400
diff --git a/lib/pleroma/web/activity_pub/publisher.ex b/lib/pleroma/web/activity_pub/publisher.ex
index 90c4274f2..c8bdf2250 100644
--- a/lib/pleroma/web/activity_pub/publisher.ex
+++ b/lib/pleroma/web/activity_pub/publisher.ex
@@ -123,6 +123,7 @@ defmodule Pleroma.Web.ActivityPub.Publisher do
         Logger.error("Publisher failed to inbox #{inbox} with status #{code}")
 
         case response do
+          %{status: 400} -> {:cancel, :bad_request}
           %{status: 403} -> {:cancel, :forbidden}
           %{status: 404} -> {:cancel, :not_found}
           %{status: 410} -> {:cancel, :not_found}