From b5fcb82bffd3f31cf1318c1504fcb97e56b892cd Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Thu, 30 May 2024 10:47:51 -0400
Subject: [PATCH 1/3] Test for missing FK indexes

---
 test/fixtures/unindexed_fk.sql | 27 +++++++++++++++++++++++++++
 test/pleroma/schema_test.exs   | 17 +++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 test/fixtures/unindexed_fk.sql
 create mode 100644 test/pleroma/schema_test.exs

diff --git a/test/fixtures/unindexed_fk.sql b/test/fixtures/unindexed_fk.sql
new file mode 100644
index 000000000..3b71679cf
--- /dev/null
+++ b/test/fixtures/unindexed_fk.sql
@@ -0,0 +1,27 @@
+-- Unindexed FK -- Missing indexes - For CI
+
+WITH y AS (
+SELECT
+pg_catalog.format('%I', c1.relname)  AS referencing_tbl,
+pg_catalog.quote_ident(a1.attname) AS referencing_column,
+(SELECT pg_get_expr(indpred, indrelid) FROM pg_catalog.pg_index WHERE indrelid = t.conrelid AND indkey[0] = t.conkey[1] AND indpred IS NOT NULL LIMIT 1) partial_statement
+FROM pg_catalog.pg_constraint t
+JOIN pg_catalog.pg_attribute  a1 ON a1.attrelid = t.conrelid AND a1.attnum = t.conkey[1]
+JOIN pg_catalog.pg_class  c1 ON c1.oid = t.conrelid
+JOIN pg_catalog.pg_namespace  n1 ON n1.oid = c1.relnamespace
+JOIN pg_catalog.pg_class  c2 ON c2.oid = t.confrelid
+JOIN pg_catalog.pg_namespace  n2 ON n2.oid = c2.relnamespace
+JOIN pg_catalog.pg_attribute  a2 ON a2.attrelid = t.confrelid AND a2.attnum = t.confkey[1]
+WHERE t.contype = 'f'
+AND NOT EXISTS (
+SELECT 1
+FROM pg_catalog.pg_index i
+WHERE i.indrelid = t.conrelid
+AND i.indkey[0] = t.conkey[1]
+AND indpred IS NULL
+)
+)
+SELECT  referencing_tbl || '.' || referencing_column as "column"
+FROM y
+WHERE (partial_statement IS NULL OR partial_statement <> ('(' || referencing_column || ' IS NOT NULL)'))
+ORDER BY 1;
\ No newline at end of file
diff --git a/test/pleroma/schema_test.exs b/test/pleroma/schema_test.exs
new file mode 100644
index 000000000..9bddd2031
--- /dev/null
+++ b/test/pleroma/schema_test.exs
@@ -0,0 +1,17 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.SchemaTest do
+  use Pleroma.DataCase, async: true
+
+  alias Pleroma.Repo
+
+  test "No unindexed foreign keys" do
+    query = File.read!("test/fixtures/unindexed_fk.sql")
+
+    {:ok, result} = Repo.query(query)
+
+    assert Enum.empty?(result.rows)
+  end
+end

From c20ac6d1adc224232422640d8bc11a80f5eff350 Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Wed, 29 May 2024 21:27:35 -0400
Subject: [PATCH 2/3] Add missing foreign key indexes

---
 ...0240530011739_add_missing_foreign_keys.exs | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 priv/repo/migrations/20240530011739_add_missing_foreign_keys.exs

diff --git a/priv/repo/migrations/20240530011739_add_missing_foreign_keys.exs b/priv/repo/migrations/20240530011739_add_missing_foreign_keys.exs
new file mode 100644
index 000000000..158f9701b
--- /dev/null
+++ b/priv/repo/migrations/20240530011739_add_missing_foreign_keys.exs
@@ -0,0 +1,20 @@
+defmodule Pleroma.Repo.Migrations.AddMissingForeignKeys do
+  use Ecto.Migration
+
+  def change do
+    create_if_not_exists(index(:announcement_read_relationships, :announcement_id))
+    create_if_not_exists(index(:bookmarks, :activity_id))
+    create_if_not_exists(index(:bookmarks, :folder_id))
+    create_if_not_exists(index(:chats, :recipient))
+    create_if_not_exists(index(:mfa_tokens, :authorization_id))
+    create_if_not_exists(index(:mfa_tokens, :user_id))
+    create_if_not_exists(index(:notifications, :activity_id))
+    create_if_not_exists(index(:oauth_authorizations, :app_id))
+    create_if_not_exists(index(:oauth_authorizations, :user_id))
+    create_if_not_exists(index(:password_reset_tokens, :user_id))
+    create_if_not_exists(index(:push_subscriptions, :token_id))
+    create_if_not_exists(index(:report_notes, :activity_id))
+    create_if_not_exists(index(:report_notes, :user_id))
+    create_if_not_exists(index(:user_notes, :target_id))
+  end
+end

From 5f6e477ecaa941a79b22599aca169164b7241bcf Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Thu, 30 May 2024 10:51:50 -0400
Subject: [PATCH 3/3] Missing FKs changelog

---
 changelog.d/missing-fks.add | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 changelog.d/missing-fks.add

diff --git a/changelog.d/missing-fks.add b/changelog.d/missing-fks.add
new file mode 100644
index 000000000..cf74de03b
--- /dev/null
+++ b/changelog.d/missing-fks.add
@@ -0,0 +1 @@
+Add missing indexes on foreign key relationships