From 03c3c58d74217edd0822b68772eb76a59451fe50 Mon Sep 17 00:00:00 2001 From: Taylan Kammer Date: Wed, 10 Jul 2024 07:21:37 +0200 Subject: [PATCH] LDAP Authenticator: Improve error reporting. --- changelog.d/ldap-error-logging.change | 1 + lib/pleroma/web/auth/ldap_authenticator.ex | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changelog.d/ldap-error-logging.change diff --git a/changelog.d/ldap-error-logging.change b/changelog.d/ldap-error-logging.change new file mode 100644 index 000000000..56f0e7fc3 --- /dev/null +++ b/changelog.d/ldap-error-logging.change @@ -0,0 +1 @@ +Improve error logging when LDAP authentication fails. diff --git a/lib/pleroma/web/auth/ldap_authenticator.ex b/lib/pleroma/web/auth/ldap_authenticator.ex index c2c5eb1e5..ea5620cf6 100644 --- a/lib/pleroma/web/auth/ldap_authenticator.ex +++ b/lib/pleroma/web/auth/ldap_authenticator.ex @@ -91,7 +91,8 @@ defmodule Pleroma.Web.Auth.LDAPAuthenticator do end error -> - error + Logger.error("Could not bind LDAP user #{name}: #{inspect(error)}") + {:error, {:ldap_bind_error, error}} end end @@ -111,7 +112,8 @@ defmodule Pleroma.Web.Auth.LDAPAuthenticator do try_register(name, attributes) error -> - error + Logger.error("Couldn't register user because LDAP search failed: #{inspect(error)}") + {:error, {:ldap_search_error, error}} end end