diff --git a/crates/api/src/local_user/save_settings.rs b/crates/api/src/local_user/save_settings.rs index 2aed3b17b..972760a00 100644 --- a/crates/api/src/local_user/save_settings.rs +++ b/crates/api/src/local_user/save_settings.rs @@ -1,8 +1,9 @@ -use actix_web::web::{Data, Json}; +use activitypub_federation::config::Data; +use actix_web::web::Json; use lemmy_api_common::{ context::LemmyContext, person::SaveUserSettings, - request::delete_image_from_pictrs, + request::replace_image, utils::{ get_url_blocklist, local_site_to_slur_regex, @@ -15,7 +16,6 @@ use lemmy_api_common::{ use lemmy_db_schema::{ source::{ actor_language::LocalUserLanguage, - images::LocalImage, local_user::{LocalUser, LocalUserUpdateForm}, local_user_vote_display_mode::{LocalUserVoteDisplayMode, LocalUserVoteDisplayModeUpdateForm}, person::{Person, PersonUpdateForm}, @@ -42,17 +42,8 @@ pub async fn save_user_settings( let bio = diesel_option_overwrite( process_markdown_opt(&data.bio, &slur_regex, &url_blocklist, &context).await?, ); - if data.avatar.is_some() { - // Ignore errors because image may be stored externally. - if let Some(avatar) = &local_user_view.person.avatar { - let image = LocalImage::delete_by_url(&mut context.pool(), &avatar) - .await - .ok(); - if let Some(image) = image { - delete_image_from_pictrs(&image.pictrs_alias, &image.pictrs_delete_token, &context).await?; - } - } - } + replace_image(&data.avatar, &local_user_view.person.avatar, &context).await?; + replace_image(&data.banner, &local_user_view.person.banner, &context).await?; let avatar = proxy_image_link_opt_api(&data.avatar, &context).await?; let banner = proxy_image_link_opt_api(&data.banner, &context).await?; diff --git a/crates/api_common/src/request.rs b/crates/api_common/src/request.rs index c17d96a61..370a9427b 100644 --- a/crates/api_common/src/request.rs +++ b/crates/api_common/src/request.rs @@ -3,6 +3,7 @@ use crate::{ post::{LinkMetadata, OpenGraphData}, utils::proxy_image_link, }; +use activitypub_federation::config::Data; use encoding::{all::encodings, DecoderTrap}; use lemmy_db_schema::{ newtypes::DbUrl, @@ -312,6 +313,26 @@ async fn is_image_content_type(client: &ClientWithMiddleware, url: &Url) -> Resu } } +/// When adding a new avatar or similar image, delete the old one. +pub async fn replace_image( + new_image: &Option, + old_image: &Option, + context: &Data, +) -> Result<(), LemmyError> { + if new_image.is_some() { + // Ignore errors because image may be stored externally. + if let Some(avatar) = &old_image { + let image = LocalImage::delete_by_url(&mut context.pool(), &avatar) + .await + .ok(); + if let Some(image) = image { + delete_image_from_pictrs(&image.pictrs_alias, &image.pictrs_delete_token, &context).await?; + } + } + } + Ok(()) +} + #[cfg(test)] mod tests { #![allow(clippy::unwrap_used)] diff --git a/crates/api_crud/src/community/update.rs b/crates/api_crud/src/community/update.rs index 83ffded13..51c57e1c8 100644 --- a/crates/api_crud/src/community/update.rs +++ b/crates/api_crud/src/community/update.rs @@ -4,6 +4,7 @@ use lemmy_api_common::{ build_response::build_community_response, community::{CommunityResponse, EditCommunity}, context::LemmyContext, + request::replace_image, send_activity::{ActivityChannel, SendActivityData}, utils::{ check_community_mod_action, @@ -42,6 +43,9 @@ pub async fn update_community( let description = process_markdown_opt(&data.description, &slur_regex, &url_blocklist, &context).await?; is_valid_body_field(&data.description, false)?; + let old_community = Community::read(&mut context.pool(), data.community_id).await?; + replace_image(&data.icon, &old_community.icon, &context).await?; + replace_image(&data.banner, &old_community.banner, &context).await?; let description = diesel_option_overwrite(description); let icon = proxy_image_link_opt_api(&data.icon, &context).await?; diff --git a/crates/api_crud/src/site/update.rs b/crates/api_crud/src/site/update.rs index 809dbe498..be67152aa 100644 --- a/crates/api_crud/src/site/update.rs +++ b/crates/api_crud/src/site/update.rs @@ -1,7 +1,9 @@ use crate::site::{application_question_check, site_default_post_listing_type_check}; -use actix_web::web::{Data, Json}; +use activitypub_federation::config::Data; +use actix_web::web::Json; use lemmy_api_common::{ context::LemmyContext, + request::replace_image, site::{EditSite, SiteResponse}, utils::{ get_url_blocklist, @@ -63,6 +65,9 @@ pub async fn update_site( SiteLanguage::update(&mut context.pool(), discussion_languages.clone(), &site).await?; } + replace_image(&data.icon, &site.icon, &context).await?; + replace_image(&data.banner, &site.banner, &context).await?; + let slur_regex = local_site_to_slur_regex(&local_site); let url_blocklist = get_url_blocklist(&context).await?; let sidebar = process_markdown_opt(&data.sidebar, &slur_regex, &url_blocklist, &context).await?; diff --git a/crates/db_schema/src/impls/images.rs b/crates/db_schema/src/impls/images.rs index 221aa1a68..a9aeb1f16 100644 --- a/crates/db_schema/src/impls/images.rs +++ b/crates/db_schema/src/impls/images.rs @@ -74,19 +74,16 @@ impl LocalImage { query.load::(conn).await } - pub async fn delete_by_alias(pool: &mut DbPool<'_>, alias: &str) -> Result { + pub async fn delete_by_alias(pool: &mut DbPool<'_>, alias: &str) -> Result { let conn = &mut get_conn(pool).await?; diesel::delete(local_image::table.filter(local_image::pictrs_alias.eq(alias))) - .execute(conn) + .get_result(conn) .await } pub async fn delete_by_url(pool: &mut DbPool<'_>, url: &DbUrl) -> Result { - let conn = &mut get_conn(pool).await?; let alias = url.as_str().split('/').last().ok_or(NotFound)?; - diesel::delete(local_image::table.filter(local_image::pictrs_alias.eq(alias))) - .get_result(conn) - .await + Self::delete_by_alias(pool, alias).await } }