=== release 1.20.3 === 2022-06-15 23:36:18 +0100 Tim-Philipp Müller * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.20.3 2022-06-15 23:36:10 +0100 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.20.3 2022-06-09 20:00:35 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapifilter.c: vaapi: Do not disable the whole vpp when some va operations not available. Part-of: 2022-05-20 09:59:58 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipostproc.c: vaapidecode,vaapipostproc: Disable DMAbuf from caps negotiation. Given the amount of complains about artifacts when negotiating dmabuf given incompatible drm-formats, and that there's no enough bandwidth for a proper and quick fix in gstreamer-vaapi, this patch disables, from decoders and postprocessor, the DMABuf caps feature. For those who needs DMABuf can use the va elements in -bad, increasing their ranking for autoplugging by using the environment variable GST_PLUGIN_FEATURE_RANK=vah264dec:MAX, for example. This can be considered a first step to the deprecation of gstreamer-vaapi in favor of the va plugin in -bad. Fixes: #1137 Part-of: 2022-05-03 00:39:09 +0100 Tim-Philipp Müller * meson.build: Back to development Part-of: === release 1.20.2 === 2022-05-02 23:29:25 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.20.2 2022-05-02 23:29:19 +0100 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.20.2 2022-04-21 10:54:50 +0100 Tim-Philipp Müller * docs/gst_plugins_cache.json: * meson_options.txt: vaapi: fix up package-origin in meson_options.txt Follow-up to !2243 Part-of: 2022-04-12 15:23:08 +0300 Sebastian Dröge * gst-libs/gst/vaapi/gstvaapivalue.c: Fix `transfer` gobject-introspection annotation typos Part-of: 2022-03-14 14:48:01 +0000 Tim-Philipp Müller * meson.build: Back to development === release 1.20.1 === 2022-03-14 11:33:33 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.20.1 2022-03-14 11:33:25 +0000 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.20.1 2022-02-07 16:17:28 +0000 Tim-Philipp Müller * meson.build: Back to development === release 1.20.0 === 2022-02-03 19:53:25 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.20.0 2022-02-03 19:53:18 +0000 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.20.0 2022-01-30 09:38:48 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * meson.build: vaapi: Disable Wayland if no libdrm Platform wise, is not possible, as far as I known, to have Wayland without kernel's DRM. Though, it's possible to configure gstreamer-vaapi without DRM but Wayland support, with the enhanced handling of dmabuf in vaapisink for Wayland, vaapisink will always fail. Given both issues, configuration with no DRM but Wayland, makes things more complex, and a simpler approach is to refuse that configuration. This patch disables Wayland support if there isn't DRM support. Also, it disables the display test for Wayland, relying only on DRM and X11. Part-of: 2022-01-30 07:10:09 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/video-format.c: vaapi: libs: video-format: Check if formats map is not NULL. Formats map is instantiated at the end of the display instantiation. The problem is the Wayland display which looks for a format in a callback, before the map is populated. If user compiles gstreamer-vaapi with DRM support, the map is populated with a DRM display at GStreamer plugin registration. But if not, or a VA driver is not available, the plugin will try with a Wayland driver, which cause the NULL de-reference. Nevertheless, in the case of no DRM support, and if the Wayland display doesn't get a reply from the format conversion is not a problem. So the solution is the trivial one, check if the format map is already populated before de-reference it. Fixes: #977 Part-of: === release 1.19.90 === 2022-01-28 14:28:35 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.19.90 2022-01-28 14:28:28 +0000 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.19.90 2022-01-05 02:07:59 +0530 Nirbheek Chauhan * docs/meson.build: * meson.build: meson: Add explicit check: kwarg to all run_command() calls This is required since Meson 0.61.0, and causes a warning to be emitted otherwise: https://github.com/mesonbuild/meson/commit/2c079d855ed87488bdcc6c5c06f59abdb9b85b6c https://github.com/mesonbuild/meson/issues/9300 This exposed a bunch of places where we had broken run_command() calls, unnecessary run_command() calls, and places where check: true should be used. Part-of: 2022-01-04 16:19:44 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiprofile.c: vaapi: av1dec: Use named profiles to replace the numeric ones. Use named AV1 profiles (i.e., main, high) to replace the old "0" and "1" profiles. Part-of: 2021-12-01 15:36:44 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: Misc enhancements. - Use GST_WARNING rather than g_critical - Replace gst_ghost_pad_new_from_template() with gst_ghost_pad_new() to avoid using the template. - Declare extern variable Part-of: 2021-12-01 12:26:11 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: Autogenerate caps template. vaapidecode is used in vaapidecodebin and it exposes all the theoretically supported caps, but that slows down autoplug. With this autplug is negotiated faster, giving more option to decodebin to select other decoder. Part-of: 2021-11-16 17:18:28 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: vaapi: libs: Use unsized arrays as parameters. Instead of defining a sized array for function signature, use it unsized (a pointer alias, basically). In this way clang warning is silenced: warning: ‘fill_profiles’ accessing 64 bytes in a region of size 12 [-Wstringop-overflow=] Part-of: 2021-11-16 17:21:52 +0100 Víctor Manuel Jáquez Leal * meson.build: vaapi: meson: Fail if static build. And initialize the plugin array. Part-of: 2021-11-15 16:38:34 +0800 Ung, Teng En * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix mising metadata when using system Part-of: 2021-11-03 18:44:03 +0000 Tim-Philipp Müller * meson.build: Back to development === release 1.19.3 === 2021-11-03 15:43:36 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.19.3 2021-11-03 15:43:32 +0000 Tim-Philipp Müller * ChangeLog: Update ChangeLogs for 1.19.3 2021-10-18 15:47:00 +0100 Tim-Philipp Müller * tests/check/meson.build: meson: update for meson.build_root() and .build_source() deprecation -> use meson.project_build_root() or .global_build_root() instead. Part-of: 2021-10-18 00:40:14 +0100 Tim-Philipp Müller * docs/meson.build: * gst-libs/gst/vaapi/meson.build: * meson.build: * tests/check/meson.build: meson: update for dep.get_pkgconfig_variable() deprecation ... in favour of dep.get_variable('foo', ..) which in some cases allows for further cleanups in future since we can extract variables from pkg-config dependencies as well as internal dependencies using this mechanism. Part-of: 2021-10-14 18:38:26 +0100 Tim-Philipp Müller * meson.build: meson: bump meson requirement to >= 0.59 For monorepo build and ugly/bad, for advanced feature option API like get_option('xyz').required(..) which we use in combination with the 'gpl' option. For rest of modules for consistency (people will likely use newer features based on the top-level requirement). Part-of: 2021-10-15 00:33:39 +0800 He Junyan * docs/index.md: Docs: Fix a typo for Intel's vaapi driver name. Part-of: 2021-09-28 10:11:15 +1000 Brad Hards * RELEASE: doc: update IRC links to OFTC Part-of: 2021-09-26 01:07:02 +0100 Tim-Philipp Müller * meson.build: Back to development Part-of: === release 1.19.2 === 2021-09-23 01:35:54 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.19.2 2021-08-26 15:06:53 +0800 Zhang Yuankun * gst/vaapi/gstvaapidecode.c: vaapi: decoder: modify the condition to judge whether dma buffer is supported It seems "GST_VAAPI_PLUGIN_BASE_SRC_PAD_CAN_DMABUF (decode)" will return false even if this platform support the mem_type dma buffer. And media-driver will return GST_VAAPI_BUFFER_MEMORY_TYPE_DMA_BUF2 on Gen12(such as TGL). Without this patch, The command such as: gst-launch-1.0 videotestsrc num-buffers=100 ! video/x-raw, format=I420 ! \ x264enc ! h264parse ! vaapih264dec ! video/x-raw\(memory:DMABuf\) ! fakesink will return not-negotiated. Signed-off-by: Zhang Yuankun Part-of: 2021-05-14 12:04:04 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst/vaapi/gstvaapivideocontext.c: Display: Add a property to export the VA display handle. Just like what we do in VA plugins. The display can be seen as a generic gst object and we can add a property to get the internal VA handle. Part-of: 2021-05-14 11:49:01 +0800 He Junyan * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: video memory: Add a GST_MAP_VAAPI flag to peek the surface. Just like what we do in VA plugins, the GST_MAP_VAAPI can directly peek the surface of the VA buffers. The old flag 0 just peek the surface proxy, which may not be convenient for the users who do not want to include our headers. Part-of: 2021-07-09 11:01:14 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: Revert "vaapi: Demote vaapidecodebin to rank NONE." This reverts commit 7a25c5d4ec95aefeca6515ac023b23c5dd330194. Part-of: 2021-06-23 16:23:00 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: plugins: encode: fix a deadlock because of _drain() We call gst_vaapiencode_drain() in gst_vaapiencode_change_state(), whose context does not hold the stream lock of the encoder. The current gst_vaapiencode_drain inside unlock/lock pair adds a extra lock count to the stream lock of encoder and causes hang later. We just remove the gst_vaapiencode_drain() and expand its logic correctly according to the lock/unlock context. Part-of: 2021-06-29 15:09:13 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_av1.c: libs: decoder: av1: Clean the film_grain_info field. We need to clean all film_grain_info fields when the film grain feature is not enabled. It may have random data because the picture parameter buffer is not cleaned. Part-of: 2021-06-03 22:12:04 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: libs: encoder: mpeg2: Add highP level for 1080@50p/60p. The MPEG2 spec has amendment 3 to introduce a new level highP, which is used for 1080@50p/60p streams. We need to add this level to avoid encoding failure because of the level check. Fix: #306 Part-of: 2021-05-11 16:59:07 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: Decoder: H264: Add the support for frame packing arrangement SEI message. Frame packing arrangement SEI message is an alternative simple stereo 3D manner for AVC. We need to recognize that SEI message and report the correct 3D caps. Part-of: 2021-05-22 18:54:49 +0100 Tim-Philipp Müller * gst-libs/gst/vaapi/gstvaapifilter.c: * meson.build: Use g_memdup2() where available and add fallback for older GLib versions Alloc size is based on existing allocations and struct sizes. g_memdup() is deprecated since GLib 2.68 and we want to avoid deprecation warnings with recent versions of GLib. Part-of: 2021-06-01 15:29:16 +0100 Tim-Philipp Müller * meson.build: Back to development === release 1.19.1 === 2021-06-01 00:16:31 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.19.1 2021-04-23 19:01:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: vaapi: Demote vaapidecodebin to rank NONE. One of the main reasons of vaapidecodebin was because it mitigated the possible surface exhaustion. But that problem is currently solved. Nowadays, vaapidecodebin brings more problems than it solves. Thus this patch demotes vaapidecodebin to NONE rank while bumping PRIMARY + 1 the most common decoders. Part-of: 2021-05-20 10:28:05 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapioverlay.c: plugins: Demote rank of vaapipostproc and vaapioverlay. Since almost all video filters have rank NONE, these both elements should be NONE too. This is useful for autovideoconvert and other bins, and users might force to use these by setting the environment variable GST_PLUGIN_FEATURE_RANK. Part-of: 2021-04-21 10:55:45 +0200 François Laignel * tests/check/elements/vaapioverlay.c: Use gst_element_request_pad_simple... Instead of the deprecated gst_element_get_request_pad. Part-of: 2021-04-23 11:02:05 +0800 Zhang yuankun * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: VP9: fix > 4k encode fail issue The VP9 spec defines the MAX_TILE_WIDTH_B64(64), which is the maximum width of a tile in units of superblocks. So the max width of one tile should not be larger than 64x64=4096. When the width exceeds 4k, we need to split it into multiple tiles in columns. The current vp9 encoder does not handle this correctly. The command such as: gst-launch-1.0 videotestsrc ! video/x-raw,width=7680,height=4320 ! \ vaapivp9enc ! fakesink will crash. Part-of: 2021-04-02 15:43:45 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: libs: display: drm: don't fallback to default device if explicitly specified device can't load/init Otherwise user will be misled that the specified device is using This fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/issues/305 Part-of: 2021-03-22 13:41:13 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: decoder: H265: Enable cu_qp_delta_enabled_flag when ROI If ROI is enabled, the CUs within the ROI region may have different QP from the other part of the picture. This needs us to enable the cu_qp_delta_enabled_flag even in the CQP mode. Part-of: 2021-03-19 17:42:36 +1100 Matthew Waters * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideomemory.c: * tests/internal/simple-decoder.c: gst: don't use volatile to mean atomic volatile is not sufficient to provide atomic guarantees and real atomics should be used instead. GCC 11 has started warning about using volatile with atomic operations. https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719 Discovered in https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/868 Part-of: 2021-02-24 17:41:02 +0100 Paul Goulpié * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: gstvaapiencoder_h264: add ENCODER_EXPOSURE on aud propertie forgot during the following mainline commit: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/commit/bc2f8fd19e924aa0e193708307326acd037691ce# Signed-off-by: Paul Goulpié 2021-02-04 15:05:55 +0800 He Junyan * gst/vaapi/gstvaapipostproc.c: plugins: postproc: Fix a problem of propose_allocation when passthrough. We should query the downstream element to answer a precise allocation query when the passthrough mode is enabled. The current way still decides the allocation by the postproc itself. The pipeline such as: gst-launch-1.0 -v filesrc location=xxx.264 ! h264parse ! vaapih264dec ! \ vaapipostproc ! fakevideosink silent=false sync=true will lose some info such as the GST_VIDEO_META_API_TYPE. Part-of: 2021-01-27 12:05:44 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst/vaapi/gstvaapivideocontext.c: libs: display: drm: support gst.vaapi.app.Display context for drm backend Attributes for drm backend: - va-display : ponter of VADisplay - drm-device-fd : the DRM device file descriptor Part-of: 2021-01-13 14:43:20 +0800 Haihao Xiang * docs/index.md: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: libs: display: drm: allow user specify a drm device via an env variable Currently the default drm device is always used on a system with multiple drm devices. This patch allows user to specify the required drm device via GST_VAAPI_DRM_DEVICE env variable Example: GST_VAAPI_DRM_DEVICE=/dev/dri/renderD129 gst-launch-1.0 videotestsrc ! vaapih264enc ! fakesink Part-of: 2021-01-25 14:45:47 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: libs: display: drm: fix set_device_path_from_fd drmGetBusid() (GET_UNIQUE ioctl) won't return a valid bus id when drmSetInterfaceVersion() (SET_VERSION ioctl) hasn't been called(see[1]), so we can't get the right device path. Running test-display will get the error below: ** (test-display:18630): ERROR **: 10:26:00.434: could not create Gst/VA display Calling drmSetInterfaceVersion() before drmGetBusid() can't fix this issue because a special permission is required for SET_VERSION ioctl. This patch retrieves the device path from file descriptor via g_file_read_link() [1] https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/drm_ioctl.c#L48-L104 Part-of: 2021-01-20 10:42:09 +0100 Rafał Dzięgiel * gst-libs/gst/vaapi/gstvaapiutils_glx.c: glx: Iterate over FBConfig and select 8 bit color size Texture upload mechanism used by gstreamer-vaapi relies on 8 bpc. In latest mesa versions the first fbconfig might not be 8 bit, so iterate over it to find the correct config with supported values. This also adds 8 bit alpha size to the framebuffer configuration which is required to get it working properly. Part-of: 2021-01-11 09:57:03 +0800 Ung, Teng En * gst-libs/gst/vaapi/gstvaapiutils.c: vaapipostproc: fix code style. Part-of: 2020-12-21 05:42:00 +0000 Ung, Teng En * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapifilter.c: vaapipostproc: Remove YUV to/from RGB color primary quirk since iHD driver has fixed in https://github.com/intel/media-driver/commit/a39fe9bc051a8c3efa8f35122a1585981ec7f816. Part-of: 2020-12-21 05:36:29 +0000 Ung, Teng En * gst-libs/gst/vaapi/gstvaapiutils.c: vaapipostproc: Added gstreamer BT2020 color standard support. Part-of: 2021-01-09 16:05:48 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_av1.c: decoder: AV1: Fix a static analysis problem of update_state(). No need to check the picture pointer after we have already dereferenced it. Fix: #298 Part-of: 2020-12-22 23:43:52 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_av1.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: libs: decoder: Add decode_with_surface_id for AV1 film_grain. The AV1 film_graim feature needs two surfaces the same time for decoding. One is for recon surface which will be used as reference later, and the other one is for display. The GstVaapiPicture should contain the surface for display, while the vaBeginPicture() need the recon surface as the target. We add a gst_vaapi_picture_decode_with_surface_id API to handle this kind of requirement. Part-of: 2020-08-27 21:46:41 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_av1.c: * gst-libs/gst/vaapi/gstvaapidecoder_av1.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/meson.build: * gst/vaapi/gstvaapidecode.c: * meson.build: libs: decoder: AV1: Add the av1 decoder support. Part-of: 2020-08-27 21:39:35 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: libs: codecobject: Add number of elements when create codec object. One slice data may need several slice parameter buffers at one time. Part-of: 2020-12-12 10:30:41 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideobufferpool.c: vaapi: use gst_clear_object instead of g_clear_object Part-of: 2020-12-08 13:34:35 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: plugins: encode: unlock the stream lock before _flush() The current encoder will hang when EOS comes. When we call the gst_vaapi_encoder_encode_and_queue(), we should release the stream lock, just like what we do in gst_vaapiencode_handle_frame(). The deadlock happens when: The input thread holding the stream lock is using gst_vaapi_encoder_create_coded_buffer() to acquire a coded buffer, while the output thread which holding the coded buffer resource is acquiring the stream lock in _push_frame() to push the data to down stream element. Part-of: 2020-12-09 00:04:33 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: H264: Fix one assert in get_pending_reordered(). gst_vaapi_encoder_h264_get_pending_reordered() does not consider the case for HIERARCHICAL_B mode. The pipeline: gst-launch-1.0 videotestsrc num-buffers=48 ! vaapih264enc prediction-type=2 \ keyframe-period=32 ! fakesink get a assert: ERROR:../gst-libs/gst/vaapi/gstvaapiencoder_h264.c:1996:reflist1_init_hierarchical_b: assertion failed: (count != 0) The last few B frames are not fetched in correct order when HIERARCHICAL_B is enabled. We also fix a latent bug for normal mode. The g_queue_pop_tail() of B frames make the last several frames encoded in reverse order. The NAL of last few frames come in reverse order in the bit stream, though it can still output the correct image. Part-of: 2020-06-25 16:25:21 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: encoder: H265: Add screen content coding extensions support. In scc mode, the I frame can ref to itself and it needs the L0 reference list enabled. So we should set the I frame to P_SLICE type. We do not need to change the ref_pic_list0/1 passed to VA driver, just need to enable the VAEncPictureParameterBufferHEVC->pps_curr_pic_ref_enabled_flag to notify the driver consider the current frame as reference. For bits conformance, the NumRpsCurrTempList0 should be incremented by one to include the current picture as the reference frame. We manually do it when packing the slice header. Command line like: gst-launch-1.0 videotestsrc num-buffers=10 ! \ capsfilter caps=video/x-raw,format=NV12, framerate=30/1,width=640,height=360 ! \ vaapih265enc ! capsfilter caps=video/x-h265,profile="{ (string)screen-extended-main }" ! \ filesink location=out.265 Can be used to specify that the encoder should use SCC profiles. Part-of: 2020-07-11 23:37:29 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: vp9: Implement the set_config(). We store the allowed profiles list to encoder in set_config(). Part-of: 2020-07-11 23:39:40 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: vp9: Add the profile into output caps. Part-of: 2020-07-11 23:27:21 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: no need to ensure_hw_profile. Once we decide the profile and can get the valid entrypoint for that profile, hw must already support this profile/entrypoint pair. No need to check it again in set_context_info(). Part-of: 2020-07-11 23:22:55 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: Improve the manner to decide the profile. We should decide the VP9 encoder's profile based on the chroma and depth of the input format, then make sure it is included in the allowed list. Part-of: 2020-07-11 23:17:02 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_vpx.c: * gst-libs/gst/vaapi/gstvaapiutils_vpx.h: libs: util: vpx: add get_chroma_format_idc for VP9 Part-of: 2020-07-11 23:09:59 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: libs: encoder: vp9: Add allowed_profiles. We need the allowed_profiles to store the allowed profiles in down stream's caps. Command line like: vaapivp9enc ! capsfilter caps=video/x-vp9,profile="{ (string)1, \ (string)3 }" We need to store GST_VAAPI_PROFILE_VP9_1 and GST_VAAPI_PROFILE_VP9_3 in this list. Part-of: 2020-11-30 18:00:30 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: H265: Fix a typo in scc reference setting. Part-of: 2020-07-17 18:00:30 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: libs: decoder: H265: Add MAIN_422_12 profile supporting. Part-of: 2020-07-31 14:38:42 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: video-format: Add Y212_LE format. It can be used as HEVC YUV_4:2:2 12bits stream's decoder output, and also can be used as the input format for encoding HEVC YUV_4:2:2 12bits stream. Part-of: 2020-07-30 23:21:06 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: libs: decoder: H265: Add MAIN_444_12 profile supporting. Part-of: 2020-07-30 23:13:10 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: video-format: Add Y412_LE format. It can be used as HEVC YUV_4:4:4 12bits stream's decoder output, and also can be used as the input format for encoding HEVC YUV_4:4:4 12bits stream. Part-of: 2020-09-17 16:47:43 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: fill missing predictor_palette_size field. The predictor_palette_size of VAPictureParameterBufferHEVCScc is forgotten and need to be filled when streams have palettes. Part-of: 2020-09-17 15:35:11 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: utils: h265: Use get_profile_from_sps to get profile. We now use gst_h265_get_profile_from_sps() to replace the old way of gst_h265_profile_tier_level_get_profile() to get more precise profile. The new function consider the unstandard cases and give a more suitable profile decision. Part-of: 2020-10-19 13:46:44 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: decoder: vp9: 0xff segment pred probs if no temporal update According to the spec (6.2.11 Segmentation params syntax) segmentation_pred_prob[i] ast to be 0xff if not temporal_update. Part-of: 2020-10-19 13:42:53 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: decoder: vp9: avoid reference rewriting The removed code set all the reference frames to the current frame it is a key one, but later, all the reference frames were rewritten with the decoded picture buffers or VA_INVALID_SURFACE if they were not available. Basically, all this time the first reference frame assignment has been ignored, and it's not described by the spec, and this patch removes that code. Part-of: 2020-09-20 09:56:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: decoder: don't reply src caps query with allowed if pad is fixed If the pad is already fixed the caps query have to be reply with the current fixed caps. Otherwise the query has to be replied with the autogeneratd src caps. This path fix this by falling back to the normal caps query processing if the pad is already fixed. Otherwise it will fetch the allowed src pad caps. Part-of: 2020-09-15 00:11:30 +0800 He Junyan * gst/vaapi/gstvaapidecode.c: plugins: decode: fix a DMA caps typo in ensure_allowed_srcpad_caps. Part-of: 2020-09-01 09:31:33 +0200 Marc Leeman * gst/vaapi/gstvaapisink.c: vaapisink: when updating the caps, reset rotation When an element upstream changes settings (e.g. crop), new caps are sent to vaapisink. When vaapisink was rotating the image, it needs to re-evaluate if the sink needs to rotate the image. Part-of: 2020-09-08 17:31:02 +0100 Tim-Philipp Müller * .gitlab-ci.yml: ci: include template from gst-ci master branch again 2020-09-08 16:59:07 +0100 Tim-Philipp Müller * meson.build: Back to development === release 1.18.0 === 2020-09-08 00:09:51 +0100 Tim-Philipp Müller * .gitlab-ci.yml: * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.18.0 2020-09-07 12:15:43 +0300 Sebastian Dröge * gst-libs/gst/vaapi/gstvaapifilter.c: Update for gst_video_transfer_function_*() function renaming Part-of: 2020-08-22 12:53:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: Revert "libs: decoder: h264, h265: in context at least 16 reference surfaces" This reverts commit b387081a4d77d3da202da72686ab40fb9c83ee1e as discussed in https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/commit/b387081a4d77d3da202da72686ab40fb9c83ee1e === release 1.17.90 === 2020-08-20 16:16:25 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.17.90 2020-08-17 11:43:53 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_egl.c: libs: surface: egl: guard memory type Part-of: 2020-08-17 19:26:43 +0800 He Junyan * gst/vaapi/gstvaapidecode.c: plugin: decode: Fix two mem leaks because of caps. Part-of: 2020-08-16 01:57:15 +0800 He Junyan * gst/vaapi/gstvaapivideomemory.c: plugin: allocator: No need to ref allocator when create mem. We do not need to ref the allocator when creating GstVaapiVideoMemory kind memory, and then release it in _free(). The framework already does it for us. Part-of: 2020-08-14 10:42:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: ignore level without breaking negotiation Since commit 9f627ef2 if the user sets level in the encoder src caps the caps negotiation is rejected. But since the same commit the same encoder set the autoconfigured level in caps. Some change in the base class might fixed the operation order so now the caps are set and later negotiated. This patch removes the level check. Fixes: #273 Part-of: 2019-07-09 19:17:48 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/egl_vtable.h: * gst-libs/gst/vaapi/gstvaapisurface_egl.c: * gst-libs/gst/vaapi/gstvaapisurface_egl.h: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: libs: egl: surface: export EGLImage as DMABuf if GEM not supported This code path is used when frames are rendered as textures through GstVideoGLTextureUploadMeta with EGL, mainly under Wayland. Originally the EGLImage was exported as GEM, which was handled by Intel drivers, but Gallium ones cannot create VA surfaces from GEM buffers, only DMABuf. This patch checks the memory types supported by VA driver to choose the render the EGLImages from GEM or DMABuf, because GEM is still better where supported. DMABuf is well handled either by intel-vaapi-driver and gallium. Fixes: #137 Part-of: 2020-05-26 16:18:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: libs: filter: gst_vaapi_filter_get_memory_types() Part-of: 2020-08-12 18:48:59 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: remove gst_vaapi_plugin_base_get_allowed_srcpad_raw_caps() Since nobody uses it, just remove it. Thus extract_allowed_surface_formats() is refactored to attend only gst_vaapi_plugin_base_get_allowed_sinkpad_raw_caps(). Now a surface is created when the image chorma is different from the previous one. And if the driver has the quirk, it outputs all the supported image formats without trying them. Part-of: 2020-08-12 17:50:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: expose raw src caps with same chroma The try-and-error approach for getting the possible image formats from a surface has brought several problems in different drivers, from crashes to drop in performance. Instead of that we change the algorithm to determine the possible image formats based in the surface chroma: only those available image formats with same chroma are exposed as possible raw caps. Do this is important to avoid performance degrading in raw sinks which doesn't handle NV12 but it does YV12 or I420. Part-of: 2020-07-10 17:05:38 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: util: h265: use common parser API to get vaapi profiles. We can reuse H265 parser's API to recognize the correct profile and then just need to convert them to VAAPI profiles. Part-of: 2020-08-07 16:41:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/meson.build: * gst/vaapi/meson.build: * meson.build: build: update for gl pkg-config file split Part-of: 2020-08-06 12:51:27 +0800 Xu Guangxin * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264dec: mark remaining frames as unreference before exec_picture_refs_modification 8.2.4.2 required this. Some clips will crash if we do not fill the reference list like this. Part-of: 2020-07-31 18:22:46 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: encoder: H265: Enable Main 12 profile support. Part-of: 2020-07-31 19:17:39 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: video format: Fix P012_LE's chrome type typo. Part-of: 2020-08-04 21:15:01 +0300 Jordan Petridis * gst-libs/gst/vaapi/gstvaapiminiobject.c: gstvaapiminiobject.c: fix clang 10 warnings the typesystem checks in g_atomic_pointer_compare_and_exchange seem to trigger some false positives with clang 10 similar to gstreamer!584 Part-of: 2020-07-31 11:07:23 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: destroy all wayland buffers during finalize Some buffers and the associated FrameState state may still be pending at that point. If the wayland connection is shared, then messages for the buffer may still arrive. However, the associated event queue is already deleted. So the result is a crash. With a private connection the associated memory is leaked instead. Part-of: 2020-06-18 20:25:18 +0200 Michael Olbrich * tests/examples/test-vaapicontext.c: test: vaapicontext: fix draw callback with multiple videos The callback is called for both windows. So make sure that gst_video_overlay_set_render_rectangle() is called for the correct one. Otherwise, the left video will be randomly moved behind the right video. Part-of: 2020-06-19 09:23:52 +0200 Michael Olbrich * tests/examples/meson.build: * tests/examples/test-vaapicontext.c: test: vaapicontext: support wayland display On Wayland, The whole gtk window is one Wayland surface. So gtk_widget_get_window() must be called on the top-level widget. For any other widget the following gdk_window_ensure_native() may create a new top-level Wayland surface that is never visible. As a result, the coordinates passed to gst_video_overlay_set_render_rectangle() must be relativ to the top-level window. Otherwise the video is placed incorrectly. Original-Patch-By: Víctor Manuel Jáquez Leal Part-of: 2017-12-01 20:18:28 +0100 Víctor Manuel Jáquez Leal * tests/examples/test-vaapicontext.c: test: vaapicontext: use playbin to test files Part-of: 2017-11-29 11:11:39 +0100 Víctor Manuel Jáquez Leal * tests/examples/test-vaapicontext.c: test: vaapicontext: add PLAY and NULL buttons They only appear when only one sink is instanciated and their purpose is to test the NULL-PLAY use case in context sharing. Part-of: 2020-06-19 21:26:52 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: wayland: update the opaque region in set_render_rect gst_vaapi_window_wayland_set_render_rect() may be called from an arbitrary thread. That thread may be responsible for making the window visible. At that point another thread will block in gst_vaapi_window_wayland_sync() because the frame callback will not be called until the window is visible. If that happens, then acquiring the display lock in gst_vaapi_window_wayland_set_render_rect() would result in a deadlock. Cache the size of the opaque rectangle separately and create the opaque region right before applying it to the surface. Part-of: 2020-06-19 09:21:16 +0200 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst/vaapi/gstvaapisink.c: libs: window: implements gst_vaapi_window_set_render_rectangle Implements new vmethod gst_vaapi_window_set_render_rectangle, which is doing set the information of the rendered rectangle set by user. This is necessary on wayland at least to get exact information of external surface. And vaapisink calls this when gst_video_overlay_set_render_rectangle is called. Part-of: 2017-11-08 13:23:39 +0900 Hyunjun Ko * gst/vaapi/gstvaapisink.c: vaapisink: implements gst_vaapisink_wayland_create_window_from_handle() Implements gst_vaapisink_wayland_create_window_from_handle() to support using external wl_surface. Part-of: 2020-06-19 09:11:20 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: libs: wayland: implement video overlay API The Wayland sub-surfaces API is used to embed the video into an application window. See Appendix A. Wayland Protocol Specification as the following. """ The aim of sub-surfaces is to offload some of the compositing work within a window from clients to the compositor. A prime example is a video player with decorations and video in separate wl_surface objects. This should allow the compositor to pass YUV video buffer processing to dedicated overlay hardware when possible. """ Added new method gst_vaapi_window_wayland_new_with_surface() Original-Patch-By: Víctor Manuel Jáquez Leal Zhao Halley changzhix.wei@intel.com Hyunjun Ko Part-of: 2020-06-19 21:54:52 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: doc: libs: wayland: add 'transfer full' to the returnvalye of gst_vaapi_window_wayland_new Part-of: 2020-06-11 08:25:57 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: always call close_display() All close_display() have their own checks for use_foreign_display and only destroy locally created objects in that case. Without this objects other than the actuall foreign display itself are leaked. Part-of: 2020-07-30 23:37:10 +0800 He Junyan * gst-libs/gst/vaapi/video-format.h: video-format: Add the missing P012_LE into GST_VAAPI_FORMATS_ALL. Part-of: 2020-05-25 17:02:26 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: add gst_vaapi_caps_set_width_and_height_range() This utility function is called internally by gst_vaapi_build_caps_from_formats() and can be used outside. This function sets frame size and framerates ranges. Also gst_vaapi_build_caps_from_formats() is simplified. Part-of: 2020-07-31 15:27:38 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder.c: libs: decoder: fix a crash issue when get_surface_formats. Some context does not report any valid format that we can support. For example, the HEVC 444 12 bits decoder context, all the formats it reports is not supported now, which make the formats list a NULL array. We should check that pointer before we use it. Part-of: 2020-07-03 19:28:28 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: choose the profile based on allowed list. We can decide the profile in ensure_profile(), based on allowed list passed by the encode. We also need to check whether the entrypoint is available. Once it is decided, no need to check the hw entrypoint them again. Part-of: 2020-07-29 22:05:41 +0800 He Junyan * gst/vaapi/gstvaapiencode_h265.c: plugins: encode: h265: set all allowed profiles to encoder. We should collect all allowed profiles and pass them to the inside encoder, rather than just calculate the max profile idc. The allowed profiles should also be supported by the HW. Part-of: 2020-07-29 22:32:55 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: Add a helper function to get profiles by codec. Part-of: 2020-07-03 01:28:28 +0800 He Junyan * gst/vaapi/gstvaapiencode_h265.c: plugins: encode: h265: collect all allowed profiles to encoder. We should collect all allowed profiles and pass them to the inside encoder, rather than just calculate the max profile idc. Part-of: 2020-07-03 00:53:31 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: * gst/vaapi/gstvaapiencode_h265.c: libs: encoder: h265: modify set_max_profile to set_allowed_profiles. In h265, bigger profile idc may not be compatible with the small profile idc. And more important, there are multi profiles with the same profile idc. Such as main-422-10, main-444 and main-444-10, they all have profile idc 4. So recording the max profile idc is not enough, the encoder needs to know all allowed profiles when deciding the real profile. Part-of: 2020-07-02 23:33:31 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: No need to check hw_max_profile. In h265, higher profile idc number does not mean better compression performance and may be not compatible with the lower profile idc. So, it is not suitable to find the heighest idc for hw to ensure the compatibility. On the other side, when the entrypoint of the selected profile is valid, it means the hw really support this profile, no need to check it again. Part-of: 2020-04-08 19:41:09 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: early return if fixate srcpad caps fails Part-of: 2020-07-29 13:39:44 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: vaapipluginutil: simplify gst_vaapi_find_preferred_caps_feature() Generalize the way how the preferred color format is chosen. Also use new GStreamre API as syntatic sugar. Part-of: 2020-07-29 14:22:18 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: libs: profile: Use get_codec_from_caps to get codec type. There is no need to get a profile from the caps and then convert that profile into codec type. We can get the codec type by caps's name easily. Part-of: 2020-07-12 19:42:40 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiprofile.c: libs: profile: h265: Fix return value of from_codec_data_h265. profile_from_codec_data_h265() returns wrong GstVaapiProfile for h265. The codec data of caps contain the profile IDC, but the mapping between profile IDC and GstVaapiProfile is wrong. Part-of: 2020-07-07 00:46:23 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp9.c: plugins: encode: vp9: Implement vp9's allowed_profiles() func. Part-of: 2020-07-08 16:30:17 +0800 He Junyan * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugin: util: rename h26x_encoder_get_profiles_from_caps(). Change its name to encoder_get_profiles_from_caps(). Other codecs such as VP9 also needs to use this function. Part-of: 2020-07-06 23:35:12 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_vpx.c: * gst-libs/gst/vaapi/gstvaapiutils_vpx.h: * gst-libs/gst/vaapi/meson.build: libs: utils: vpx: Add utils vpx to handle VP8/9 misc things. Part-of: 2020-07-29 10:17:31 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display, context: handle broken jpeg decoder for i965 driver JPEG decoding in i965 driver is pretty much broken, and the driver is deprecated which mean authors only accept trivial fixes. Surfaces for JPEG decoder context in i965 only handle IMC3[1] color format which is not a common format in GStreamer. It can export it to I420 at mapping raw bytes, but DMABuf exporting is problematic. This patch artificially adds NV12 to the context format list when it's JPEG decoder for i965 and force the usage of old VA-API for surface creation without specifying color format. Also it artificially disables the DMABuf announcement. 1. https://docs.microsoft.com/en-us/windows/win32/medfound/recommended-8-bit-yuv-formats-for-video-rendering#420-formats-16-bits-per-pixel Part-of: 2020-07-29 12:02:50 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: change function to internal code style Instead of a getter the function `get_preferred_format()` to `ensure_preferred_format()` which aligns to the code style. Part-of: 2020-07-28 20:00:09 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: always merge profile caps in sink caps This commit fixes a regression of e962069d, where if the profile's caps doesn't have a caps profile, it's ignored. This patch add a conditional jump if the caps doesn't have a profile field to merge it. Fixes: #271 Part-of: 2020-07-28 12:22:40 +0200 Víctor Manuel Jáquez Leal * meson.build: build: request libdrm >= 2.4.98 and fallback Fixes: #270 Part-of: 2020-05-18 17:32:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: dma caps only use reported color format This fix pipelines without vaapipostproc after vaapi decoder, such as gst-launch-1.0 filesrc location=~/file.mp4 ! parsebin ! vaapih264dec ! glimagesink On EGL platforms, so DMABuf is used. Part-of: 2020-02-07 17:10:45 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: use allowed srcpad caps for caps query Instead of using just the template caps use the current allowed srcpad caps, which is created considering the current decoder context. Part-of: 2020-01-22 17:41:28 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst/vaapi/gstvaapidecode.c: vaapidecode: build allowed srcpad caps from va context Instead of generating allowed srcpad caps with generic information, now it takes the size an formats limits from the decoder's context. This is possible since srcpad caps are generated after the internal decoder is created. The patch replaces gst_vaapi_decoder_get_surface_formats() with gst_vaapi_decoder_get_suface_attributes(). From these attributes, formats are only used for VASurface memory caps feature. For system memory caps feature, the old gst_vaapi_plugin_get_allowed_srcpad_caps() is still used, since i965 jpeg decoder cannot deliver mappable format for gstreamer. And for the other caps features (dmabuf and texture upload) the same static list are used. This patch also adds DMABuf caps feature only if the context supports that memory type. Nonetheless, we keep the pre-defined formats since they are the subset of common derive formats formats supported either by amd/gallium and both intel drivers, since, when exporting the fd through vaAcquireBufferHandle()/ vaReleaseBufferHandle(), the formats of the derivable image cannot be retriebable from the driver. Later we'll use the attribute formats for the DMABuf feature too, when the code be ported to vaExportSurfaceHandle(). Finally, the allowed srcpad caps are removed if the internal decoder is destroyed, since context attribues will change. Part-of: 2020-02-07 16:50:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: reorder src caps template Since negotiation depends on caps order, first is VA, then DMABuf, later GLUploadTexture (deprecated) and finally raw. Also, for decoders, the possible available color formats for DMABuf is extended to all the possible VA color formats. Part-of: 2020-07-22 10:01:41 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: use dmabuf protocol if available Currently vaGetSurfaceBufferWl() is used to create wayland buffers. Unfortunately this is not implemented by the 'media-driver' and Mesa VA-API drivers. And the implementation provided by 'intel-vaapi-driver' is not compatible with a Wayland server that uses the iris Mesa driver. So create the Wayland buffers manually with the zwp_linux_dmabuf_v1 wayland protocol. Formats and modifiers supported by the Wayland server are taken into account. If necessary, VPP is enabled to convert the buffer into a supported format. Fall back to vaGetSurfaceBufferWl() if creating buffers via dambuf protocol fails. Part-of: 2020-07-21 10:03:19 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: libs: window: allow choosing the format for the vpp pool Signed-off-by: Michael Olbrich Part-of: 2020-06-28 17:42:29 +0200 Michael Olbrich * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: video-format: add DRM formats to the mapping table This will be needed for the DMABuf protocol support to map DRM formats to vaapi and gstreamer formats. Part-of: 2020-07-22 09:36:18 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/meson.build: libs: display: wayland: add basic dmabuf protocol support This is just the basic infrastructure. Hook up the interface and collect all supported formats. Part-of: 2020-07-06 09:59:40 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: wait for configure before committing the first buffer Committing the first buffer for a surface must not be done before ack_configure() has been sent for the xdg_surface. With weston, the commit will fail with "error 3: xdg_surface has never been configured". Wait in gst_vaapi_window_wayland_show() until configure is done to avoid this. Part-of: 2020-07-01 14:50:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: set no P frame automatically. The double reference lists may be required by drivers and there should be no P frames in the of stream. The old way of converting P frames to B frames is by setting `low-delay-b` property, which is unconvenient and has bad user experience, since most of the users do not know when to set this property, and if it is not set correctly, the encoding pipeline fails or even hangs on some platforms. VA driver now provides a attribute to query whether both reference lists must be un-NULL for a profile/entrypoint pair. Part-of: 2020-04-15 16:26:55 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Deprecate the low-delay-b property. In HEVC, P and B definitions are different from AVC: P frames have just one reference list and so 1 MV, while B frames have two reference lists and so 2 MVs. No matter B or P, ist reference lists can contain forward/backward reference. So P and B can both have bi-directions dependency, the difference is just their reference list number (i.e. MV number). This is different from the AVC. The *low delay b mode* refers to a special HEVC mode, in which the stream just contain I and B frames, without P frames, and all B frames only have forward direction dependencies (i.e. all inter frames have 2 reference lists but no backward reference in both lists). This is similar to AVC I/P mode, but changing the P to the forward dependent B. The `low-delay-b` property is now just used to simply convert all P frames to B frames when driver does not support P frames (so both reference lists have the same references frames). This is a little different from the meaning of low delay b mode (the two ref lists may have the different reference frames). And the driver now can report whether it supports P frames correctly, so there is no need to use this property and deprecate it. Part-of: 2020-07-24 12:54:31 +0200 Marc Leeman * gst/vaapi/gstvaapipostproc.c: postproc: reconfigure after changing cropping values Part-of: 2020-07-09 13:49:29 +0800 He Junyan * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: Add static caps for template documentation. Part-of: 2020-07-08 19:03:14 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: vp9: Use the dynamically built src template caps. Part-of: 2020-07-08 19:02:45 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp8.c: plugin: encode: vp8: Use the dynamically built src template caps. Part-of: 2020-07-08 19:02:23 +0800 He Junyan * gst/vaapi/gstvaapiencode_jpeg.c: plugin: encode: jpeg: Use the dynamically built src template caps. Part-of: 2020-07-08 19:00:39 +0800 He Junyan * gst/vaapi/gstvaapiencode_mpeg2.c: plugin: encode: mpeg2: Use the dynamically built src template caps. Part-of: 2020-07-08 18:59:18 +0800 He Junyan * gst/vaapi/gstvaapiencode_h265.c: plugin: encode: h265: Use the dynamically built src template caps. Part-of: 2020-07-08 18:57:26 +0800 He Junyan * gst/vaapi/gstvaapiencode_h264.c: plugin: encode: h264: Use the dynamically built src template caps. Part-of: 2020-07-08 18:46:58 +0800 He Junyan * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: Store the coded caps in type's init data. Part-of: 2020-07-08 18:30:00 +0800 He Junyan * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugin: util: add helper function build_template_coded_caps_by_codec() Like build_template_raw_caps_by_codec(), this function can detect and build the caps for specified codec based on the query of the profiles. The result is coded caps such as video/x-h265, video/x-h264. The result can be used as the template of encode's src or decode's sink. Part-of: 2020-07-07 17:16:41 +0800 He Junyan * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: utils: rename build_template_caps_by_codec. Rename the function build_template_caps_by_codec() to the name of build_template_raw_caps_by_codec(). It can be used to collect all raw video formats for encode's sink and decode's src. Part-of: 2020-07-21 20:14:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapidecode: merge common profiles before setting size range The synthetic profiles, such as H264 baseline, H265 intra, etc. are added at the end of processing all available VA profiles. This generated an non-optimal caps for negotiation, since the synthetic profiles don't have frame size ranges. This patch adds those possible synthetic profiles when the associated profile is processed, with its frame size ranges. Now allowed sink caps are simpler. Part-of: 2020-07-21 22:05:08 +0800 He Junyan * gst/vaapi/gstvaapipluginutil.c: plugin: util: Add the missing DMA buffer input in template caps. We pass the wrong parameter to gst_vaapi_build_caps_from_formats() and lose the DMA feature in caps. Part-of: 2020-07-14 18:13:56 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: libs: decoder: H265: Add MAIN_12 profile supporting. Part-of: 2020-07-09 23:07:38 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: video-format: Add P012_LE format. It can be used as HEVC YUV_4:2:0 12bits stream's decoder output, and also can be used as the input format for encoding HEVC YUV_4:2:0 12bits stream. Part-of: 2020-07-17 00:45:53 +0800 He Junyan * gst/vaapi/gstvaapidecode.c: plugin: decode: correct ensure_allowed_sinkpad_caps's caps. The decode allowed caps returned by ensure_allowed_sinkpad_caps() contains all profiles of the whole VAAPI, like: image/jpeg, width=(int)[ 0, 1638 4 ], height=(int)[ 0, 16384 ]; video/mpeg, mpegversion=(int)2, profile=(string){ simple, main }, width=(int)[ 0, 2048 ], height=(int)[ 0, 2048 ]; video/x-h264, profile=(string){ main, high, constrained-baseline }, width=(int)[ 0, 4096 ], height=(int)[ 0, 4096 ]; video/x-h264, profile=(string){ constrained-high, progressive-high, baseline }; video/x-h265, profile=(string){ main, main-intra }, width=(int)[ 0, 8192 ], height=(int)[ 0, 8192 ]; video/x-vp8, width=(int)[ 0, 4096 ], height=(int)[ 0, 4096 ]; video/x-wmv, wmvversion=(int)3, format=(string)WVC1, profile=(string)advanced, width=(int)[ 0, 3840 ], height=(int)[ 0, 3840 ]; video/x-wmv, wmvversion=(int)3, profile=(string){ simple, main }, width=(int)[ 0, 3840 ], height=(int)[ 0, 3840 ] Which is verbose and may have latent problems. It should only contains the profiles belong to its codec type. For example, h265 should only return: video/x-h265, profile=(string){ main, main-intra }, width=(int)[ 0, 8192 ], height=(int)[ 0, 8192 ] Part-of: 2020-07-13 11:06:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: don't force NV12 since P010_10LE is now possible Part-of: 2020-07-12 20:34:31 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiprofile.c: libs: profile: The VP9 profiles' name should be just "0,1,2,3" Part-of: 2020-07-08 17:33:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * tests/internal/simple-decoder.c: vaapidecode: Remove NO_SURFACE error handling Since surfaces are not bounded to decoding context it makes no sense to keep the surface semaphore. This patch removes the handling of this error. Part-of: 2020-07-08 17:48:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: Revert "vaapidecode: drop non-keyframe in reverse playback" Since the number of surfaces are not bounded to decoder context, this hack is no longer needed. This reverts commit 19c0c8a97385ce119440c4aad2d689fc79297435. Part-of: 2019-12-06 14:21:33 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapicontext.c: libs: decoder: context: remove surfaces binding from context. The vaCreateContext do not need to specify the surfaces for the context creation now. So we do not need to bind any surface to the context anymore. Surfaces should be the resource belong to display and just be used in encoder/decoder context. The previous manner has big limitation for decoder. The context's surface number is decided by dpb size. All the surfaces in dpb will be attached to a gstbuffer and be pushed to down stream, and the decoder need to wait down stream free the surface and go on if not enough surface available. For more and more use cases, this causes deadlock. For example, gst-launch-1.0 filesrc location=a.h264 ! h264parse ! vaapih264dec ! x264enc ! filesink location=./output.h264 will cause deadlock and make the whole pipeline hang. the x264enc encoder need to cache more than dpb size surfaces. The best solution is seperating the surfaces number and the dpb size. dpb and dpb size shoule be virtual concepts maintained by the decoder. And let the surfaces_pool in context maintain the re-use of all surfaces. For encoder, the situation is better, all the surfaces are just used as reference frame and no need to be pushed to down stream. We can just reserve and set the capacity of the surfaces_pool to meet the request. Fix: #147 Fix: #88 Co-Author: Víctor Manuel Jáquez Leal Part-of: 2020-07-08 17:50:51 +0100 Tim-Philipp Müller * meson.build: * scripts/extract-release-date-from-doap-file.py: meson: set release date from .doap file for releases Part-of: 2020-07-08 11:57:52 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: use VA allocator by default on raw caps Instead of using dmabuf allocator in source pad, when raw video caps are negotiated, it uses VA allocator as before, since it is stable in more use cases, for example transcoding, and more backend drivers. Dmabuf allocator is only used when dmabuf caps feature is negotiated. Part-of: 2020-06-06 18:47:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapisink: rank it as secondary iHD doesn't provide a full implemention for rendering surfaces and i965 has problems in wayland. And I suspect this path is followed by other driver implementations. This patch demotes the rank of vaapisink to secondary, so it will not be autoplugged avoiding bad experience of users. Part-of: 2020-06-19 10:44:50 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h264, h265: in context at least 16 reference surfaces Registering only stream's DBP size number of surfaces for decoding VA surfaces brings issues for certain streams. This change register all possible number of reference surfaces in a stream, which is 16. Fixes: #94 2020-07-04 21:21:57 +0800 He Junyan * gst/vaapi/gstvaapiencode_h265.c: plugins: encode: h265: Add profile,level,tier to output caps. Part-of: 2020-07-04 21:08:20 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: init tier to GST_VAAPI_TIER_H265_UNKNOWN. Part-of: 2020-07-04 21:05:49 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: fix a bug to get get_profile_tier_level. 0 is a valid value for h265 tier. Part-of: 2020-07-02 19:19:35 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: no need to check the high compression tune. The h265 encoder just support tune mode: (0): none - None (3): low-power - Low power mode So, no need to check and set the high compression parameters. And by the way, the current ensure_tuning_high_compression manner of choosing the hightest profile idc as the best compression profile is not correct. Unlike h264, in h265 the higher profile idc number does not mean it has more compression tools, and so it has better compression performance. It may even be un-compatible with the lower profile idc. For example, the SCREEN_CONTENT_CODING profile with idc 9 is not compatible with 3D_MAIN profile with idc 8. Part-of: 2020-07-03 02:04:14 +0100 Tim-Philipp Müller * meson.build: Back to development === release 1.17.2 === 2020-07-03 00:36:40 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.17.2 2020-06-23 10:20:46 -0400 Thibault Saunier * docs/gst_plugins_cache.json: * gst/vaapi/gstvaapiencode.c: docs: Mark parent classes as plugin API 2020-06-23 00:07:57 +0200 Mathieu Duponchelle * docs/meson.build: meson: mark plugins cache target as always stale 2020-06-19 23:34:11 -0400 Thibault Saunier * docs/gst_plugins_cache.json: doc: Stop documenting properties from parents 2020-06-20 00:28:35 +0100 Tim-Philipp Müller * meson.build: Back to development === release 1.17.1 === 2020-06-19 19:27:11 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * gstreamer-vaapi.doap: * meson.build: Release 1.17.1 2020-06-19 15:21:56 +0100 Tim-Philipp Müller * docs/gst_plugins_cache.json: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: Update plugin docs and add more plugins Part-of: 2020-06-11 08:32:05 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: libs: wayland: display: only handle the first output Right now, all outputs are handled. The means that the registry object for all but the last are leaked. As a result the sizes are not used correctly. With two outputs, at first the mode and physical size of the second output are used. If the first output changes the mode, then the physical size of the second output is used in combination with the resolution of the first output. The resulting pixel aspect ratio is incorrect. There seems to be no way to determine on which output the window is shown, so just use the first one to get consistent results. Part-of: 2020-06-11 18:15:17 +0800 He Junyan * gst/vaapi/gstvaapipluginbase.c: plugins: pluginbase: Do not destroy display when _close() When the element's state changes to NULL, it can still receive queries, such as the image formats. The display is needed in such queries but not well protected for MT safe. For example, ensure_allowed_raw_caps() may still use the display while it is disposed by gst_vaapi_plugin_base_close() because of the state change. We can keep the display until the element is destroyed. When the state changes to NULL, and then changes to PAUSED again, the display can be correctly set(if type changes), or leave untouched. Fix: #260 Part-of: 2020-06-09 21:19:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: use correct printing modifier GstVaapiID is an alias of gsize, thus its modifier is platform dependant. Part-of: 2020-06-06 00:42:46 +0200 Mathieu Duponchelle * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapivalue.c: plugins: uddate gst_type_mark_as_plugin_api() calls 2020-03-05 18:12:27 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Enable tile in VA command. Part-of: 2020-03-05 17:56:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Add ensure_tile to calculate tiles. We need consider tiles and slices together, separate tiles uniformly and then assign slices uniformly to each tiles. Part-of: 2020-04-30 14:19:29 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: add a quirk for iHD driver tile encoding. The iHD driver has a requirement that one slice can not span tiles when tile is enabled, which is not required by hevc spec. Part-of: 2020-03-05 17:40:43 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Add tile info to bitstream. Part-of: 2020-03-05 17:29:41 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: promote level if tile is enabled. Part-of: 2020-03-05 17:07:28 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.h: libs: encoder: h265: Add num-tile-cols/rows properties. These properties are used for support of tile encoding. We just support uniform mode of tile encoding, that is, separating picture equally by (num-tile-cols X num-tile-rows). According to HEVC spec A1, the max number of tiles in column is 20 and in rows is 22, so add two constant definitions. Part-of: 2020-03-05 16:21:24 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: extract slice creation from add_slice_headers extract slice creation details from add_slice_headers, and let the add_slice_headers just focuses on calculating slice start address and CTU number. Part-of: 2020-03-05 12:44:45 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: Add a helper function to check the tile support. Encoding by tiles separation now is a very common feature for all relative new codecs, such as HEVC, AV1, and VP9. Just make this check as a common helper function of the encoder base class. Part-of: 2020-05-13 18:02:07 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: decoder: H265: Add SCC_MAIN_444_10 profile support. Part-of: 2020-05-13 16:05:59 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: update reference list for SCC. Part-of: 2020-05-13 15:46:29 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: H265: Fill picture and slice SCC parameters. Part-of: 2020-05-13 15:00:53 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: util: H265: recognize the SCC profiles. Part-of: 2020-05-13 14:53:46 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils.c: libs: profile: Add screen extended main/main10/main444 define. Part-of: 2020-04-03 14:53:40 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst/vaapi/gstvaapiencode_h265.c: libs: encoder: h265: Add support for MAIN 4:2:2 10 profile. Using YUY2 as the input of the encoder can generate main 4:2:2 bit streams and using Y210 as the input of the encoder can generate main 4:2:2 10 bit streams. Part-of: 2020-05-29 16:40:20 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Use correct index for SubWidthC and SubHeightC. We need to use the chroma_format_idc as the index for getting the SubWidthC and SubHeightC values as the spec 6.1(table 6-1) defines. The wrong SubWidthC or SubHeightC make us calculate a wrong right or bottom offset for crop size and generate garbage in output. Part-of: 2020-05-29 15:37:24 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: encoder: h265: Fix chrome idc for 444 10 bits GST_VAAPI_CHROMA_TYPE_YUV444_10BPP should also set chroma_format_idc to 3 as GST_VAAPI_CHROMA_TYPE_YUV444 does. Part-of: 2020-06-03 18:37:22 -0400 Thibault Saunier * docs/meson.build: doc: Require hotdoc >= 0.11.0 2020-06-03 18:49:53 -0400 Thibault Saunier * gst/vaapi/gstvaapipostproc.c: doc: Fix wrong link to GstVideoDirectionMethod 2020-06-03 17:38:10 -0400 Thibault Saunier * docs/gst_plugins_cache.json: * meson_options.txt: docs: Update plugin cache with the new format And fix the default URL which should not be inside quotes. 2020-06-03 17:37:48 -0400 Thibault Saunier * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst/vaapi/gstvaapipostproc.c: Use gst_type_mark_as_plugin_api() for all non-element plugin types 2020-05-23 22:09:17 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/meson.build: libs: delete all gstvaapiobject related files. Part-of: 2020-05-23 20:48:54 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: return fail immediately if can not create subpicture Part-of: 2020-05-23 14:00:58 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * tests/internal/image.c: libs: subpicture: Make subpicture a standard GstMiniObject. Part-of: 2020-05-26 02:19:15 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: Add ref flags for splited field. When split one frame into fields, the second field should also copy the reference flags. Part-of: 2020-05-25 15:46:58 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: disallow multiple slice group As far as we know there are no VAAPI drivers supporting FMO, which migth be used in baseline streams. This commit is a continuation of https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/328 Part-of: 2020-05-20 10:50:05 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode_props.c: * gst/vaapi/gstvaapidecode_props.h: vaapidecoder: h264: remove baseline as constrained property From now on always the baseline is going to be treated as constrained without need of setting a property. Since the property was added along the development cycle (1.17 / commit 866a9f06) and never released, we assume that it is safe to remove it. Fixes: #252 Part-of: 2020-05-21 11:37:36 +0200 Víctor Manuel Jáquez Leal * README: README: update VP9 decoder and encoder Part-of: 2020-05-21 13:42:47 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: vaapiencoder_h264: set direct_spatial_mv_pred_flag to true by default This flag is set to true by default in both MediaSDK and FFmpeg-vaapi, so let's align this plugin with other libraries / softwares. Part-of: 2020-05-18 18:29:05 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: fix meta overwrite commit 7ac2a207 added a regression by erroneously assumed that GstVaapiVideoMeta is actually a GstMeta, which is not. Part-of: 2020-05-17 09:55:42 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: vaapivideopool: Set pooled flag to added metas. So this could hint filters how to use these metas. Had to change the return value for texutre upload meta in order to flag it. Part-of: 2020-05-16 20:49:31 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiparser_frame.c: * gst-libs/gst/vaapi/gstvaapisurface.c: libs: use array_unref() rather than array_free() It is more convinience and thread-safe. Part-of: 2020-04-10 22:20:35 +0800 He Junyan * gst/vaapi/gstvaapi.c: plugin: use register_type to replace get_type for encode init. xxx_register_type will detect the template sink caps and is needed to be called at init time. Part-of: 2020-04-10 22:05:50 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp9.c: * gst/vaapi/gstvaapiencode_vp9.h: plugins: encode: Modify sink template of vp9 encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_vp9_register_type, which should be called at plugin register time. Part-of: 2020-04-10 22:05:18 +0800 He Junyan * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp8.h: plugins: encode: Modify sink template of vp8 encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_vp8_register_type, which should be called at plugin register time. Part-of: 2020-04-10 22:04:34 +0800 He Junyan * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: plugins: encode: Modify sink template of mpeg2 encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_mpeg2_register_type, which should be called at plugin register time. Part-of: 2020-04-10 22:03:49 +0800 He Junyan * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_h265.h: plugins: encode: Modify sink template of h265 encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_h265_register_type, which should be called at plugin register time. Part-of: 2020-04-10 22:00:38 +0800 He Junyan * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: plugins: encode: Modify sink template of h264 encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_h264_register_type, which should be called at plugin register time. Part-of: 2020-04-10 22:11:34 +0800 He Junyan * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_jpeg.h: plugins: encode: Modify sink template of jpeg encode. Use gst_vaapi_detect_codec_caps to get more precise template caps. Also implement gst_vaapiencode_jpeg_register_type, which should be called at plugin register time. Part-of: 2020-04-23 00:02:02 +0800 He Junyan * gst/vaapi/gstvaapiencode.h: plugin: encode: add a helper macro to register encode type. Part-of: 2020-04-10 21:44:05 +0800 He Junyan * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: util: Add a helper function to detect supported caps. This helper function iterate all profiles and entrypoints belong to the specified codec, query the VAConfigAttribRTFormat and list all possible video formats. This function is used by each codec to get the template sink caps (for encode) or src caps(for decode) at register time, when just all possible formats are listed and no need to be very accurate. So there is no context created for the performance reason. Most codecs just use YUV kinds of formats as the input/output, so we do not include RGB kinds of formats. User can specified more formats in extra_fmts(For example, jpeg may need BGRA) if needed. Part-of: 2020-04-10 21:27:32 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugin: encode: extract the allowed caps maker as a helper function. Extract all logic about making caps for encode's sink as a standalone helper function. It can be reused. Part-of: 2020-04-10 21:21:43 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: libs: video-format: add a helper function of get_formats_by_chroma. The function iterates all supported video formats and returns the formats belong to the specified chroma type. Part-of: 2020-05-16 21:03:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: libs: texture: remove unused headers include This is continuation of https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/317 Part-of: 2020-05-16 19:58:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodedbuffer.h: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisurface.h: libs: removed duplicated function declarations Some headers had duplicated inlined function declaration. This was for gtkdoc, but now GStreamer uses hotdoc and the internal library documentation is not generated. So let's remove these extra lines. Part-of: 2020-04-18 19:32:24 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: * gst-libs/gst/vaapi/gstvaapitexturemap.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: * gst/vaapi/gstvaapivideometa_texture.c: * tests/internal/test-textures.c: libs: texture: Make texture a standard GstMiniObject. We store GstVaapiTextureGLX and GstVaapiTextureEGL's private data in the qdata of miniobject and avoid extending the base texture class. Part-of: 2020-04-26 12:33:29 +0200 Víctor Manuel Jáquez Leal * README: Update README Part-of: 2020-04-21 18:00:26 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: libs: display: drm: use g_strcmp0 to be null safe Part-of: 2020-04-26 13:30:16 +0800 Haihao Xiang * gst/vaapi/gstvaapipluginutil.c: vaapipluginutil: Use GST_VAAPI_DISPLAY_TYPE_DRM for Mesa3D GBM We may build this plugin with window system support but run it without window system. Without this patch, the following pipeline will trigger a segfault when running it without window system. gst-launch-1.0 filesrc location=input.264 ! h264parse ! vaapih264dec ! fakesink Part-of: 2020-04-21 11:16:37 +0200 Víctor Manuel Jáquez Leal * meson.build: build: use join_paths() for driverdir 2020-04-21 09:04:51 +0000 Veerabadhran G * README: README: Update supported hardware Added the AMD hardware list to the "Hardware Requirements" section. 2020-04-04 13:58:00 +0200 He Junyan * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: libs: bufferproxy: remove GstMemory reference Since bufferproxy and surface are not referenced circularly, there's no need to keep, in the buffer proxy, a reference to the GstMemory where it is held. This patch removes that handling. 2020-03-15 23:29:05 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: * gst/vaapi/gstvaapivideomemory.c: libs,plugin: break surface-bufferproxy circular reference The bufferproxy may reference the surface and the surface may also reference the bufferproxy, producing a circular reference, which might lead to serious resource leak problems. Now make the relationship clearer, the bufferproxy's references is transfered to surface, while bufferproxy just keeps the surface's address without increasing its reference count. The surface can be created through a bufferproxy like in gst_vaapi_surface_new_with_dma_buf_handle(), and the surface might get its bufferproxy via gst_vaapi_surface_get_dma_buf_handle(). In both cases the surface holds a bufferproxy's reference. 2020-04-03 18:43:52 +0200 He Junyan * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: libs: bufferproxy: rename parent memeber as surface 2020-03-15 22:07:31 +0800 He Junyan * gst/vaapi/gstvaapivideobufferpool.c: plugin: bufferpool: use hashmap to cache dmabuf mem-surface The old way of refer memory by bufferproxy is not a good one, since it make the logic error prone. Now it is established a map between surface-bufferproxy and its GstMemory, caching the memory bound by a surface looked for the specified surface. 2020-03-15 21:50:24 +0800 He Junyan * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: plugin: bufferpool: Delete ACQUIRE_FLAG_NO_ALLOC flag. Delete the GST_VAAPI_VIDEO_BUFFER_POOL_ACQUIRE_FLAG_NO_ALLOC flag. In fact, no one is using that flag, and all vaapi buffers should have GstVaapiVideoMeta. 2020-02-13 09:43:38 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: enable HDR10 tone mapping 2020-02-13 09:00:18 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: libs: filter: HDR10 tone mapping support Add support for HDR10 tone mapping (since VA-API 1.4.0). 2020-04-02 15:14:15 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst/vaapi/gstvaapiencode_h265.c: libs: encoder: h265: Support MAIN 4:4:4 10 profile. Using Y410 as the input of the encoder can generate main_444_10 bit streams. 2020-04-02 15:19:41 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: fix an inexact trace info in chroma type check. 2020-03-31 12:22:31 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: make sure format array is not NULL when returning TRUE This fixed segfault when running the pipeline below with iHD driver (commit efe5e9a) on ICL gst-launch-1.0 videotestsrc ! vaapivp9enc tune=low-power ! vaapivp9dec ! \ fakesink 2020-03-18 13:28:00 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_h265.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.h: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapitexturemap.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_egl.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: libs: extend g_autoptr support 2020-03-26 22:40:40 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideometa.c: vaapivideometa: remove compiler warning 2020-03-22 20:59:20 +0100 Víctor Manuel Jáquez Leal * meson.build: * meson_options.txt: build: Add meson's option package-origin. This options is added to synchronize with other gstreamer packages build configuration. Though, to avoid breaking distro configuration it is set, as default, the issues gitlab's url, instead of the used string "Unkown package origin". Also, set_quoted is used for string based cdata. 2020-02-25 13:45:05 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: deprecate format, width and size parameters Since they should only be controlled by caps negotiation. 2020-03-18 16:41:01 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst/vaapi/gstvaapidecode.c: libs,plugins: decoder: Add -intra profile support for hevc. In hevc, we can consider the -intra profile a subset of the none -intra profile. The -intra profiles just contain I frames and we definitely can use the none -intra profiles's context to decode them. Signed-off-by: Víctor Manuel Jáquez Leal 2020-03-04 12:35:42 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: support ICQ/QVBR BRC Enable support for ICQ and QVBR bitrate control. The code is essentially the same for h264 ICQ/QVBR support which was added in commit 9e0c133a2403. 2020-03-19 11:19:18 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: set VA HRD param before RC param This is a workaround for intel-media-driver bug https://github.com/intel/media-driver/issues/865 The driver will force the RC method to CBR for HEVCe when it parses the HRD param. Thus, any RC method param submitted "prior" to the HRD param will be lost. Therefore, VBR, ICQ and QVBR for HEVCe can't be effectively enabled if the RC method param "precedes" the HRD param. To work around this issue, set the HRD param before the RC method param so the driver will parse the RC method param "after" the HRD param. Afaict, other codecs in the driver (and other drivers) do not appear to be dependent on the order of HRD and RC param submission. 2019-11-25 14:16:30 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: vaapijpegenc: Add a quantization quirk for iHD driver iHD driver shifts the value by 50 when calculating quantization for JPEG encoding, so we should add 50 in this plugin for iHD driver too. 2020-03-13 21:49:15 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapipixmap.h: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: * gst-libs/gst/vaapi/meson.build: * meson.build: * tests/internal/output.c: * tests/internal/output.h: * tests/internal/simple-decoder.c: * tests/internal/test-decode.c: libs: remove GstVaapiPixmap GstVaapiPixmap is an abstract base class which only implementation were GstVaapiPixmapX11. This class were used for a special type of rendering in the tests apps, utterly unrelated in GStreamer. Since gstreamer-vaapi is no longer a general-user wrapper for VA-API we should remove this unused API. This removal drops libxrender dependency. 2020-03-17 18:51:19 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: Add HEVC Main444 sting in string_of_VAProfile HEVCMain444_10 is already a supported profile and misses the strings. 2020-03-17 12:47:33 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: plugin: don't error if cannot create display This might generated errors on automatic tools such as CI. Let's rather just raise a warning and let continue. 2020-03-09 01:52:57 +0800 He Junyan * tests/check/meson.build: test: fix a ninja test failure for vaapioverlay. That test case only works with drm display, so the build such as meson -Dwith_x11=yes -Dwith_wayland=no -Dwith_drm=no -Dwith_egl=no -Dwith_glx=no gets a failure when run ninja test. Just enable this test when drm is enabled. 2020-02-07 23:56:13 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: videopool: fix a condition race for pool allocate. 2020-03-05 13:22:23 -0800 U. Artie Eoff * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: force video meta if sizes are different The strides and offsets could be the same, but the allocation size might be different (e.g. alignment). Thus, ensure we also set the flag to copy from VA memory to system memory when alloc size differs. Fixes #243 2020-03-05 14:18:32 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't set base sink caps twice Base class's sink pad caps are already set when calling set_format(). There's no need to call it again in gst_vaapidecode_negotiate(). 2020-03-05 13:26:38 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: unlock stream if caps update fails If caps update fail a dead lock occurs since the stream mutex is not unlocked. 2020-03-03 15:24:32 +0800 Xu Guangxin * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: parser state after update dependent slice If the dependent_slice_segment_flag is true, most slice info derived from last slice. So we need check the slice type after we call populate_dependent_slice_hdr 2020-02-16 12:21:28 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: force RGBA image format for i965 driver Since commit 32bf6f1e GLTextureUpload is broken because i965 doesn't report properly RGBA support. It could be possible to use RGBx but GLTextureUpload only regotiates RGBA. The simplest fix to this regression is adding synthetically the RGBA format in the internal format map. 2020-02-14 19:30:54 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: iterate all quirks table Instead of break at the fist foud quirk in the table, iterate all over so it would be feasible to add several quirks for one driver per element in array. 2020-02-25 12:05:28 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: handle RGB to/from YUV color primary driver quirk The intel-media-driver (iHD) can't convert output color primaries when doing YUV to/from RGB CSC. Thus, we must keep the output color primaries the same as the input color primaries for this case. fixes #238 2020-02-25 12:00:36 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: add YUV to/from RGB color primary quirk The intel-media-driver (iHD) can't convert output color primaries when doing YUV to/from RGB CSC. 2020-02-28 11:33:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: Revert "vaapivideomemory: Store surface allocation flags." This reverts commit dd428cc4a12c2d5c694fcd3303811cf486002c9d because it rewrites the buffer size whilst surface allocation flags are stored when allocator_params_init() is called since fab890ce. Fix: #239 2020-01-27 18:19:57 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: Try surface with allocation flags. When a vaapi allocator is instantiated, it first try to generate a surface with the specified configuration. This patch adds, in this tried buffer, the requested allocation flags. 2020-01-27 18:10:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: Store surface allocation flags. Store surface allocation flags passed to the vaapi allocator in GObject's qdata, because it might be used by the vaapivideobufferpool when recreating the allocator given any resolution change. 2020-01-24 19:32:52 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: libs: surface: Add hints to allocation flags. When creating surfaces it is possible to pass to VA hints of its usage, so the driver may do some optimizations. This commit adds the handling of encoding/decoding hints. 2020-01-24 22:08:50 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_egl.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * tests/internal/test-filter.c: * tests/internal/test-surfaces.c: libs: surface: surfacepool: Add allocation flags in constructors. 2020-02-22 16:06:13 +0800 He Junyan * meson.build: build: let the build fail if none if X11, wayland or drm. In fact, gst_vaapi_create_test_display only test x11, wayland and drm, no glx and egl entries. So if none of them is enabled, no vaapi element can be detected. 2020-02-21 00:58:47 +0800 He Junyan * tests/internal/test-display.c: test: avoid unused warning for test-display meson -Dwith_x11=yes -Dwith_wayland=no -Dwith_drm=no -Dwith_egl=no -Dwith_glx=no buildir generate unused warnings. 2020-02-21 00:50:47 +0800 He Junyan * meson.build: build: fix meson build error when without x11. meson -Dwith_x11=no build_dir can not success build the project because the glx is still enabled. We need to disable GLX when X11 is disabled. 2020-02-14 19:53:09 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: h265enc: Set max_transform_hierarchy_depth_{inter, intra} to 2 Intel HW has limitation on max_transform_hierarchy_depth_inter and max_transform_hierarchy_depth_intra (see [1]). We can provide a quirk for other HWs if other HWs may support other values [1] https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-kbl-vol10-hevc.pdf 2020-02-21 07:37:50 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: do not compensate for crop/direction if no VPP If we do not have functional VPP, then cropping and video direction is non-functional and we should avoid calling any of the gst_vaapi_filter* APIs. 2020-02-21 06:54:47 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: only set VPP colorimetry when VPP is available If we don't have functional vpp then we should not call gst_vaapi_filter_set_colorimetry. 2020-02-16 01:25:37 +0800 He Junyan * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: videobufferpool: don't reset surface when created internally The bug fixing, in commit 89f202ea, just considers the case when surface's DMABuf is set through gst_buffer_pool_acquire_buffer(), which is typically a decoder's behavior. But vaapipostproc doesn't provide any surface when calling gst_buffer_pool_acquire_buffer(), thus a surface is created when GstMemory is allocated. If the surface proxy in buffer's meta is reset at buffer_pool_reset_buffer(), that surface will be destroyed and it won't be available anymore. But GstBuffers are cached in the buffer pool and they are reused again, hence only those images are rendered repeatedly. Fixes: #232 2020-02-16 17:19:04 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiblend.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapi.c: libs: blend: filter: handle finalize() if display isn't assigned I've just discovered iHD driver in Skylake doesn't have VideoProc entry point, hence, in this platform, when vaapioverlay is tried to be registered, critical warnings are raised because blend doesn't have a display assigned. As it is possible to have drivers without EntryPointVideoProc it is required to handle it gracefully. This patch does that: only tries to register vaapioverlay if the testing display has VPP and finalize() vmethods, in filter and blend, bail out if display is NULL. 2020-02-15 11:02:49 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils.c: libs: filter: guard all color properties to VA-API 1.2.0 Older VA-API (0.39.0) doesn't have VAProcColorProperties. Thus, guard all colorimetry -> VA-API support to version 1.2.0. Fixes #234 2020-02-17 08:55:36 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: set parser info state at decoding codec data Commit 1168d6d5 showed up a regression: decode_sps() stores the unit's parser info in sps array. If that parser info comes from decoding codec data, that parser info will have an undefined state which might break ensure_sps(). This patch sets the parser info state, at decoding codec data, with the internal parser state. This is similar with h264 decoder apprach. Original-patch-by: Xu Guangxin 2020-02-07 15:24:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: demote log message to trace level 2020-02-14 14:45:56 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/video-format.c: libs: video-format: set general vaapi log category Instead of logging in an unspecified category, set the default vaapi. 2020-02-15 11:44:48 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: guard EncSliceLP for VA-API < 0.39.1 Relates to #234 2020-02-14 16:17:04 +0800 Haihao Xiang * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: h265enc: Set VA_PICTURE_HEVC_INVALID flag for invalid picture 2020-02-11 11:31:31 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: remove crumbs of libva < 0.39 All these guarded code seem like leftovers of commit 920b1ec7a. This patch completes that missing clean up. 2020-02-11 00:38:40 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils.c: libs: VA explicit color standard not supported until 1.2.0 VAProcColorStandardExplicit and associated VAProcColorProperties (primaries, transfer and matrix) are not supported until VA-API 1.2.0. Use VAProcColorStandardNone instead of VAProcColorStandardExplicit if VA-API < 1.2.0. Fixes #231 2020-02-10 09:31:15 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: WA: use explicit for sRGB colorimetry Addresses #228 on iHD side. It seems iHD can't handle VAProcColorStandardSRGB in all situations for vpp. But it has no problem when we specify the sRGB parameters via VAProcColorStandardExplicit parameters. 2020-02-07 11:25:31 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: set vpp input/output color range We've always sent VA_SOURCE_RANGE_UNKNOWN to the driver. And, the [iHD] driver essentially computes the same color range as gstreamer when we send VA_SOURCE_RANGE_UNKNOWN for cases were gstreamer computes it automatically. But, if the user wants to make it explicit, we should try to honor it. 2020-02-07 11:20:11 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: utils: map GstVideoColorRange to VAAPI VPP 2020-02-07 15:28:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't remove chroma-site nor colorimetry Since now they can be handled by vaapipostproc. 2020-02-04 14:17:43 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: use sink resolution to calculate src colorimetry The default output colorimetry is persuaded by the output resolution, which is too naive when doing VPP cropping and/or scaling. For example, scaling 4K(sink)->1080P(src) resolution (i.e. both YUV) results in bt2020(sink)->bt709(src) colorimetry selection and some drivers don't support that mode in vpp. Thus, if output (i.e. downstream) does not specify a colorimetry then we use the input resolution instead of the output resolution to create the default colorimetry. Also, note that we still use the output format since it may be a different color space than the input. As in the example above, this will result in bt2020(sink)->bt2020(src) colorimetry selection and all drivers (afaik) should support that in vpp. 2020-02-04 09:57:42 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: set srcpad colorimetry unconditionally We always need a srcpad colorimetry for VAAPI VPP operations. Also, check the return value of _set_colorimetry. 2020-01-30 12:34:07 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: do not override explicit srcpad colorimetry If colorimetry has been set by a capsfilter (e.g. vaapipostproc ! video/x-raw,colorimetry=bt709) then don't try to override it. Previously, the aforementioned capsfilter will fail to negotiate if default colorimetry is not the same as the capsfilter (e.g. 4K resolutions). 2020-01-30 09:37:18 -0800 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: set vpp filter colorimetry Set the input and output colorimetry for vpp filter. 2020-01-30 09:34:10 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: libs: filter: support vpp input/output color standard Add API function to allow setting the input and output vpp color standard from GstVideoColorimetry. 2020-02-04 11:32:54 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: utils: map GstVideoColorimetry to VAAPI VPP Fallback to VAProcColorStandardExplicit if there is no 1:1 mapping. 2020-02-04 10:27:23 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: add vpp color standard quirk for i965 driver The i965 does not properly report supported vpp color standards. 2020-02-02 18:04:35 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: dmabuf implies allocator Some code can be optimized since only if the dmabuf allocator is set, the internal flag of dmabuf is TRUE, thus there's no need to evaluate the allocator address. 2020-01-29 11:55:39 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: reject configuration if allocator isn't vaapi If the requested allocator in set_config() is not a VAAPI valid one, reject the configuration, instead of lying and using a private one. This patch superseeds !254 and !24 2020-01-29 11:55:28 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: add explanation for allocator reconfig 2020-01-29 11:54:38 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: check for vaapi meta first If the configured meta doesn't request vaapi meta then it is not a vaapi buffer pool. Bail out as soon as possible. 2020-01-29 11:52:38 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: turn errors into warnings set_config() vmethod should fail gracefully, thus upstream could negotiate another pool if possible. Instead of sending error messages to the bus, let demote the level to warning. 2020-01-29 11:51:47 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: log out vendor string when available This is useful while asking for logs to know the used driver. 2020-01-27 11:49:26 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: initialize VASurfaceAttribExternalBuffers Initialize VASurfaceAttribExternalBuffers using compiler's syntax rather than using memset(). 2020-01-27 11:44:49 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: merge two loops into one Merge two loops into one for setting offsets and strides in the external buffer descriptor. 2020-01-22 10:42:35 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: libs: surface: surfacepool: rename variable for clearity In order to be readable, the meaningless 'flags' is renamed to surface_allocation_flags, which is clearer. 2020-01-27 18:40:46 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: Reuse internal allocator is possible. Instead of creating a new allocator when upstream requests a different allocator, this patch tries to reuse the internal allocator if it was already initializated. If the stream changes, then either one will be unref and a new allocator is created. 2020-01-27 18:05:14 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: Log messages in proper category. The log messages where logged in the GstBufferPool category because the instance was not properly casted. This fix that situation. 2020-01-16 11:49:21 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst/vaapi/gstvaapipluginbase.c: libs: display: driver quirks mechanism This mechanism comes from ffmpeg vaapi implementation, where they have their own quirks. A specific driver is identified by a substring present in the vendor string. If that substring is found, a set of bitwise flags are store. These flags can be accessed through the function gst_vaapi_display_has_driver_quirks(). The purpose for this first quirks is to disable the put image try for AMD Gallium driver (see [1]). 1. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/merge_requests/72 2020-01-15 23:07:29 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: renable Mesa Gallium driver 2020-01-24 11:55:22 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: validate returned meta Validate if the meta returned by gst_buffer_get_vaapi_video_meta() in the acquired buffer is not null. This situation should be very "pathological", but still it is better be safe since that meta might be used later to create a new dma buffer. 2020-01-22 18:50:36 +0100 Philipp Zabel * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: always update/release the underlying surface proxy gst_vaapi_video_buffer_pool_reset_buffer() is called when the sink releases the last reference on an exported DMA buffer. This should release the underlying surface proxy. To avoid releasing the wrong surface due to a stale surface proxy reference in the buffer's GstVaapiVideoMeta, always update the reference to the correct surface in gst_vaapi_video_buffer_pool_acquire_buffer(). 2020-01-23 16:56:44 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: libs: context: select vaCreateSurfaces version according attributes This commit tries to centralize the selection of vaCreateSurfaces version, instead of having fallbacks everywhere. These fallbacks are hacks, added because new drivers use the latest version of vaCreateSurfaces (with surface attributes) [1], meanwhile old drivers (or profiles as JPEG decoder in i965) might rather use the old version. In order to select which method, there's detected hack: each config context has a list of valid formats, in the case of JPEG decoder the list only contains "rare" 4:2:2 formats (ICM3, GRAY8) which aren't handled correctly by the current gstreamer-vaapi code [2]. The hack consist in identify if the format list contains an arbitrary preferred format (which is suposedly well supported by gstreamer-vaapi, mostly NV12). If no prefered colour format is found, the the old version of vaCreateSurfaces is used, and the surfaces wil be mapped into a image with their own color format. 1. https://bugzilla.gnome.org/show_bug.cgi?id=797143 2. https://bugzilla.gnome.org/show_bug.cgi?id=797222 2020-01-21 19:35:02 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: add debug category for context 2020-01-22 20:20:30 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiblend.c: libs: blend: guard VA_BLEND_GLOBAL_ALPHA 2020-01-21 14:09:33 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: promote info to warning Let's notify user about using constrained-baseline instead on requested basline profile. 2019-06-28 15:41:16 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode_props.c: * gst/vaapi/gstvaapidecode_props.h: vaapih264dec: Add a property to assume constrained-baseline When baseline-as-constrained is set, the decoder will expose support for baseline decoding and assume that the baseline content is constrained-baseline. This can be handy to decode streams in hardware that would otherwise not be possible to decode. A lot of baseline content is in fact constrained. 2020-01-17 16:19:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapipluginutil.c: vaapih264enc: accept baseline as constrained baseline compatible 2020-01-17 14:24:37 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: update level in src caps And, if downstream requests a specific level, the caps are not negotiated, because there is no mechanism right now to specify a custom level in the internal encoder. 2020-01-17 17:12:53 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: document gst_vaapi_encoder_h264_supports_avc() 2020-01-17 13:38:29 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: force byte-stream if avc isn't supported Removing the validation in gst_vaapiencode_h264_get_caps() since that ought be handled in gst_vaapiencode_h264_set_config() 2020-01-08 17:37:22 +0100 Philipp Zabel * gst/vaapi/gstvaapiencode_h264.c: vaaph264enc: suppress avc if the driver does not support packed headers Do not negotiate AVC output if the driver does not support it. 2020-01-08 17:16:35 +0100 Philipp Zabel * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: Add gst_vaapi_encoder_h264_supports_avc() AVC output requires packed header support in the driver. 2020-01-17 13:07:04 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: intersect the new proposed caps Instead of just leave to keep the proposed caps, with the best profile in the allowed caps, is its intersected again. 2020-01-17 12:58:58 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: propose new profile caps and fixate it When the available caps doesn't intersect with the allowed caps in the pipeline, a new caps is proposed rather than just expecting to iterate. Later, the intersected caps (profile_caps) is fixated in order to extract the configuration. 2020-01-17 13:18:28 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: common fail for gst_vaapiencode_h264_set_config() Add a common fail code path for gst_vaapiencode_h264_set_config(). 2020-01-17 12:54:21 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: unref formats array if none The formats array is always created, in order to keep the logic and to avoid broken caps, if this formats array doesn't contain any elements, it has to be unref and the function should return NULL. 2020-01-17 14:22:48 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapih264enc: fix log message Before the log wasn't processed because wrong instance pointer. 2019-06-22 00:44:25 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst/vaapi/gstvaapiencode_h265.c: plugin: encode: Add H265 main-444 profile. Expose the main-444 profile to h265enc caps, when the upstream chooses to use VUYA as input, we choose main 4:4:4 profile to encode the frames. 2020-01-15 19:36:00 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Consider main-444 profile when encoding. Add support of main-444 profile for parameter setting and packed header generation. 2020-01-15 23:04:08 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: * gst-libs/gst/vaapi/gstvaapiprofilecaps.h: * gst/vaapi/gstvaapiencode.c: vaapiencode: DMABuf only if PRIME is available Add DMABuf capsfeature in encoders' allowed sinkcaps only if PRIME memory type is available in the VA surface attributes of codec context. 2020-01-16 09:14:30 +0800 Haihao Xiang * hooks/pre-commit.hook: Add hooks/pre-commit.hook meson.build in gstreamer-vaapi requires hooks/pre-commit.hook Copied and pasted pre-commit.hook from other gstreamer modules to make sure gstreamer-vaapi follows the same code style 2019-12-26 16:45:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Set encoder paramters base on entrypoint. When the tune is NONE, we now can choose entrypoint freely. So the GST_VAAPI_ENCODER_TUNE macro may not return the correct current entrypoint. We also delay CTU size calculation after entrypoint has been decided. 2019-12-28 19:18:12 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.h: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapifei_objects.c: * gst-libs/gst/vaapi/gstvaapifei_objects.h: * gst-libs/gst/vaapi/gstvaapifei_objects_priv.h: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.h: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.h: * gst-libs/gst/vaapi/gstvaapifeiutils_h264.c: * gst-libs/gst/vaapi/gstvaapifeiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/meson.build: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h264_fei.h: * gst/vaapi/gstvaapifeivideometa.c: * gst/vaapi/gstvaapifeivideometa.h: * gst/vaapi/meson.build: * meson.build: * tests/internal/meson.build: * tests/internal/test-fei-enc-in.c: * tests/internal/test-fei-enc-out.c: Remove all FEI related FEI encoders are not actively mantained neither tested, and it is using infrastructure that is changing and FEI is stopping this effort. Also it is required to rethink how FEI can be used in GStreamer. 2020-01-14 11:17:49 -0800 U. Artie Eoff * gst/vaapi/gstvaapioverlay.c: vaapioverlay: ensure sinkpad has current buffer Use the gst_video_aggregator_pad_has_current_buffer API to check if the current sinkpad has a queued buffer before attempting to obtain a input buffer from the base plugin. If the sinkpad does not have a current buffer, then it is either not producing them yet (e.g. current time < sinkpad start time) or it has reached EOS. Previously, we only handled EOS case. Example: gst-launch-1.0 videotestsrc num-buffers=100 \ ! vaapipostproc ! vaapioverlay name=overlay \ ! vaapisink videotestsrc timestamp-offset=1000000000 \ num-buffers=100 ! video/x-raw,width=160,height=120 \ ! overlay. 2020-01-14 18:57:31 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapioverlay.c: vaapioverlay: unroll the recursive call Recursive functions are elegant but dangerous since they might overflow the stack. It is better to turn them into a list tranversal if possible, as this case. 2020-01-14 18:46:49 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiblend.c: * gst/vaapi/gstvaapioverlay.c: vaapioverlay: add minimal documentation 2020-01-14 18:25:11 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiblend.c: * gst-libs/gst/vaapi/gstvaapiblend.h: * gst/vaapi/gstvaapioverlay.c: libs: blend: simplify generator API Instead of using a parent structure that has to be derived by API consumers, this change propse a simplification by using the common pattern of GTK of passing a function pointer and user data which will be passed as its parameter. That user data contains the state and the function will be called to update that state. 2020-01-10 10:14:38 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiblend.c: * gst-libs/gst/vaapi/gstvaapiblend.h: libs: blend: remove begin/render/end API This API was risky and is superseded by the surface generator (process) API. Resolves #219 2020-01-10 10:12:36 -0800 U. Artie Eoff * gst/vaapi/gstvaapioverlay.c: vaapioverlay: use blend surface generator API See #219 2020-01-10 09:54:30 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiblend.c: * gst-libs/gst/vaapi/gstvaapiblend.h: libs: blend: add surface generator API This new API allows the user to call a single method (process) which handles the [display] lock/unlock logic internally for them. This API supersedes the risky begin, render, end API. It eliminates the need for the user to call a lock method (process_begin) before processing the input buffers (process_render) and calling an unlock method (process_end) afterwards. See #219 2019-12-23 14:29:08 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: plugin: encode: List all possible profiles to detect input formats. The current get_profile just return one possible profile for the encode, which is not enough. For example, if we want to support HEVC 4:4:4 profile, the input of encode should be VYUA rather than NV12 in HEVC main profile. So the command line: gst-launch-1.0 videotestsrc num-buffers=200 ! capsfilter \ caps=video/x-raw,format=VUYA,width=800,height=600 ! vaapih265enc \ tune=low-power init-qp=30 ! fakesink can not work because vaapih265enc just report NV12 in sink caps, we need to specify the profile obviously like: gst-launch-1.0 videotestsrc num-buffers=200 ! capsfilter \ caps=video/x-raw,format=VUYA,width=800,height=600 ! vaapih265enc \ tune=low-power init-qp=30 ! capsfilter caps=video/x-h265, \ profile=main-444 ! fakesink The encode should have the ability to choose the profile based on input format automatically. If the input video format is VUYA, the main-444 profile should be auto choosed. We modify to let get_allowed_profiles of each encode sub class to return an array of all supported profiles based on downstream's allowed caps, or return NULL if no valid profiles specified by downstream. If no allowed profiles found, all profiles which belong to the current encoder's codec will be the candidates. The function gst_vaapi_encoder_get_surface_attributes collects the surface's attributes for that profile list we just get. So for this case, both NV12 and VUYA should be returned. TODO: some codec like VP9, need to implement the get_profile() function. 2020-01-08 15:07:36 +0800 He Junyan * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugin: util: add helper function to detect profiles in caps. 2020-01-08 15:04:18 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: libs: encoder: add a helper function to get all supported profiles 2020-01-13 15:34:54 +0900 Seungha Yang * gst-libs/gst/vaapi/gstvaapidecoder.c: libs: decoder: Don't unref null object ** (gst-launch-1.0:9789): CRITICAL **: 15:29:09.330: gst_vaapi_context_unref: assertion 'context != NULL' failed 2020-01-10 09:26:44 -0800 U. Artie Eoff * gst/vaapi/gstvaapioverlay.c: plugins: overlay: use proper NULL check on double pointer Check the address of the variable is not NULL, not the address of the pointer. 2020-01-08 23:42:21 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapicodedbuffer_priv.h: libs: codedbuf: delete a useless field. The context field in GstVaapiCodedBuffer is not inited correctly and is never used, just delete it. 2019-12-29 17:57:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: add iHD driver in whitelist 2020-01-02 21:02:40 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: modify 265 SPS header's profile compatibility flag. Make the SPS profile compatibility flags more precisely conform to the HEVC Spec. 2020-01-06 19:39:06 +0100 Víctor Manuel Jáquez Leal * tests/check/elements/vaapioverlay.c: test: vaapioverlay: bail test if not available vaapioverlay is only registered if the VA driver support the blend operation. This patch only executes the test if vaapioverlay is available, otherwise the test is bail out without raising an error. 2020-01-06 14:53:28 +0100 Víctor Manuel Jáquez Leal * tests/check/elements/vaapioverlay.c: tests: vaapioverlay: force drm backend 2019-12-22 17:32:19 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiblend.c: libs: blend: update to new mini-object API 2019-11-19 13:48:22 -0800 U. Artie Eoff * tests/check/elements/vaapioverlay.c: * tests/check/meson.build: tests: check: add basic vaapioverlay test Add test_overlay_position test to verify sink_1 input is overlayed onto sink_0 input at the appropriate position. 2019-11-14 12:03:57 -0800 U. Artie Eoff * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapioverlay.c: * gst/vaapi/gstvaapioverlay.h: * gst/vaapi/meson.build: plugins: add vaapioverlay plugin A plugin similar to the base compositor element but uses VA-API VPP blend functions to accelerate the overlay/compositing. Simple example: gst-launch-1.0 -vf videotestsrc ! vaapipostproc \ ! tee name=testsrc ! queue \ ! vaapioverlay sink_1::xpos=300 sink_1::alpha=0.75 \ name=overlay ! vaapisink testsrc. ! queue ! overlay. 2019-11-14 12:02:19 -0800 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiblend.c: * gst-libs/gst/vaapi/gstvaapiblend.h: * gst-libs/gst/vaapi/meson.build: libs: add a vaapi blend class Support for the VA-API VPP blend functions. 2019-11-14 11:54:59 -0800 U. Artie Eoff * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: base: add GstVideoAggregator subclass support 2020-01-05 19:32:16 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: libs: image: init all image fields correctly. 2020-01-06 17:41:53 +0100 Stéphane Cerveau * gst/vaapi/gstvaapipostproc.c: doc: fix pipeline typo in vaapipostproc 2020-01-02 21:11:44 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: modify 265 VPS header fields. vps_base_layer_internal_flag and vps_base_layer_available_flag have been clearly defined now. 2020-01-01 19:54:13 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: libs: display: fix a resource leak in X11 pixmap format. 2020-01-02 18:00:21 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: * gst-libs/gst/vaapi/gstvaapiprofilecaps.h: libs: utils: delete useless gst_vaapi_profile_caps_append_encoder. 2019-12-30 14:09:17 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst/vaapi/gstvaapiencode.c: libs: encoder: get surfaces resolution the same time with formats. We can get all the information about the video format at one shot when we create the test context for getting the supported formats. The current way to get the width and height ranges are inefficient, since it calls the function gst_vaapi_profile_caps_append_encoder() and it creates another temporal context to detect the resolution information. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-28 17:42:55 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: fix code style 2019-12-16 23:19:46 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: set entrypoint based on tune automatically Some profile, such as H265_MAIN_444 on new Intel platform, may only support ENTRYPOINT_SLICE_ENCODE_LP entrypoint. This leads two problems: 1. We need to specify the tune mode like `vaapih265enc tune=low-power` every time when we need to use this kind of profile. Or we can not create the encoder context successfully. 2. More seriously, we set the entrypoint to a fixed value in init_context_info() and so the create_test_context_config() can not create the test context for these profile and can not get the supported video formats, either. We now change the entrypoint setting based on the tune option of the encoder. If no tune property provided, we just choose the first available entrypoint. 2019-12-16 23:19:46 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: set context info profile by encoder Instead of init_context_info() setting the passed profile, it is assumed that it has to be set by each encoder. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-27 18:49:02 +0100 He Junyan * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: libs: context: add invalid entrypoint symbol The symbol GST_VAAPI_ENTRYPOINT_INVALID is just a representation of zero, which was already used as an invalid value tacitly. This patch only makes it explicit. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-29 01:13:29 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: libs: pixmap: Fix a pixmap creation crash. We use GST_VAAPI_OBJECT_NATIVE_DISPLAY with wrong parameter for x11 pixmap creation, which causes crash if we run the internal test case of: test-decode --pixmap 2019-12-22 14:35:18 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: plugin: encode: set allowed_sinkpad_caps to empty. We now set encode->allowed_sinkpad_caps to NULL if we fail to get surfaces formats. This causes two problem: 1. gst_video_encoder_proxy_getcaps use NULL as its caps parameter, which changes its behavior. It will use encode's sinkpad template rather than empty caps to do the clip job. So even if we fail to set allowed_sinkpad_caps, gst_video_encoder_proxy_getcaps can still return valid caps. 2. We should just set the allowed_sinkpad_caps once. The NULL point make the ensure_allowed_sinkpad_caps function works again and again. 2019-12-22 15:22:57 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: Add NULL pointer check for context when finalize. Context may be NULL if pipeline fail in early stage, and the ensure_context will not be called. Need to add a pointer protection for it. 2019-12-20 06:38:42 -0800 U. Artie Eoff * gst/vaapi/gstvaapipluginbase.c: plugins: base: do not reset can_dmabuf Don't reset the can_dmabuf field. This restores the close/reset logic that existed prior to commit ca2942176b5632e07eebac23336954f9aaf1cb26 in regards to dmabuf support. Plugins only call gst_vaapi_plugin_base_set_srcpad_can_dmabuf once during startup, but may need to reset the other private fields multiple times during negotiation. Thus, can_dmabuf should be exempt from the resets. Fixes #208 2019-12-06 00:21:12 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: plugin: encode: Refine encode's sink caps. The old manner to get the encode's sink caps is not correct. Such as 264 encode, it gets: video/x-raw(memory:VASurface), format=(string){ ENCODED, NV12, I420, YV12, YUY2, UYVY, Y210, P010_10LE, AYUV, Y410, Y444 }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]; video/x-raw(memory:DMABuf), format=(string){ I420, YV12, RGBA }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]; video/x-raw, format=(string){ NV12 }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ] where the formats for memory:VASurface and memory:DMABuf are superfluous. All the "I420, YV12, YUY2, UYVY, Y210, RGBA" can not be really used as input format for encoder. We should get: video/x-raw, format=(string){ NV12 }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]; video/x-raw(memory:VASurface), format=(string){ NV12 }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]; video/x-raw(memory:DMABuf), format=(string){ NV12 }, width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ] as the correct result. 2019-12-20 08:37:11 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: libs: display: code clean up 2019-12-12 21:34:21 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapiprofile.h: libs: display: refine the profile/entrypoint map. The old way make the one config for each profile/entrypoint pair, which is not very convenient for description the relationship between them. One profile may contain more than one entrypoints to within it, so a set like data structure should be more suitable. 2019-12-19 14:19:10 +0100 He Junyan * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_egl.c: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa_texture.c: * tests/internal/image.c: * tests/internal/test-filter.c: * tests/internal/test-surfaces.c: * tests/internal/test-windows.c: libs: surface: port to GstMiniObject GstVaapiMiniObject and GstVaapiObject are deprecated. This is the first step to remove them by porting GstVaapiSurface as a GstMiniBuffer descendant. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-19 18:26:10 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: rename create function names to init There are several internal functions with 'create' name, but they don't create any new structure, but rather it initializes that structure. Renaming those function to reflect better their purpose. 2019-12-19 14:17:34 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: use macro accessors 2019-12-19 13:46:09 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_priv.h: libs: surface: fix internal documentation 2019-12-18 18:00:49 +0100 He Junyan * gst-libs/gst/vaapi/gstvaapicodedbuffer.c: * gst-libs/gst/vaapi/gstvaapicodedbuffer.h: * gst-libs/gst/vaapi/gstvaapicodedbuffer_priv.h: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: codedbuffer: port to GstMiniObject GstVaapiMiniObject and GstVaapiObject are deprecated. This is the first step to remove them by porting GstVaapiCodedBuffer as a GstMiniBuffer descendant. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-18 12:57:01 +0100 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimage_priv.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: * tests/internal/image.c: * tests/internal/simple-encoder.c: * tests/internal/test-fei-enc-in.c: * tests/internal/test-filter.c: * tests/internal/test-windows.c: libs: image: port to GstMiniObject base class GstVaapiMiniObject and GstVaapiObject are deprecrated. This is the first step to remove them, by porting GstVaapiImage as a GstMiniObject. Signed-off-by: Víctor Manuel Jáquez Leal 2019-09-24 01:01:22 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapicodedbuffer.c: * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: libs: context: port to a plain C structure The GstVaapiMiniObject is obsolete and we need to replace it. This patch turns GstVaapiContext into a plain C structure with its own reference counting mechanism. Also this patch removes unused overlays attributes. Signed-off-by: Víctor Manuel Jáquez Leal 2019-12-18 00:40:58 +0800 He Junyan * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: change the dmabuf caps to all supported formats. The encode's dmabuf caps definition is obsolete, it can support more formats now. Re-define it to include all supported formats in video format map. 2019-12-17 17:09:37 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264fei: remove unnecessary check Issue detected by Coverity `info_to_pack.h264_slice_header` is always allocated by gst_vaapi_feipak_h264_encode(), thus checking it to free it afterwards in doesn't make much sense. But it requires to be free on the error path. There may be a null pointer dereference, or else the comparison against null is unnecessary. In gst_vaapi_encoder_h264_fei_encode: All paths that lead to this null pointer comparison already dereference the pointer earlier 2019-12-17 17:05:22 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: h264fei: remove unnecessary assert Issue detected by Coverity An unsigned value can never be negative, so this test will always evaluate the same way. In add_slice_headers: An unsigned value can never be less than 0 2019-12-17 16:57:41 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264fei: remove unnecessary check Issue detected by Coverity There may be a null pointer dereference, or else the comparison against null is unnecessary. In gst_vaapi_encoder_h264_fei_encode: All paths that lead to this null pointer comparison already dereference the pointer earlier 2019-12-17 16:49:47 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: h264fei: don't free memory on stack Issue detected by Coverity `info_to_pak` variable in gst_vaapi_encoder_h264_fei_encode() is declared in the stack, but it is free in gst_vaapi_feienc_h264_encode() as if declared on the heap. This patch initializes the structure and removes the free. A non-heap pointer is placed on the free list, likely causing a crash later. In gst_vaapi_encoder_h264_fei_encode: Free of an address-of expression, which can never be heap allocated. 2019-12-17 13:22:12 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264fei: fix surface leak Issue detected by Coverity If the FEI mode is not handled the created resources should be released and return and error code. The system resource will not be reclaimed and reused, reducing the future availability of the resource. In gst_vaapi_encoder_h264_fei_encode: Leak of memory or pointers to system resources 2019-12-17 13:09:58 +0100 Víctor Manuel Jáquez Leal * tests/check/elements/vaapipostproc.c: tests: check return calling of gst_navigation_event_parse.* This issue was detected by Coverity. If the function returns an error value, the error value may be mistaken for a normal value. In cb_mouse_event: Value returned from a function is not checked for errors before being used 2019-12-16 16:25:02 +0800 He Junyan * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: plugin: encode: set sink's raw caps to GST_VAAPI_FORMATS_ALL. Then encode plugin just supports raw formats declared in vaapi video format map. This modification makes the template caps more precise. 2019-11-14 11:13:51 -0800 U. Artie Eoff * gst/vaapi/gstvaapipluginbase.c: plugins: base: add GstPad param to internal helper functions The base plugin public API function implementations determine which pad should be passed to the internal helper functions. Currently, only the base plugin static sinkpad and static srcpad are supported/used. However, this change enables future API functions to be added that can accept a pad (i.e. request pad) from an element subclass (e.g. a GstVideoAggregator subclass). 2019-11-12 12:21:52 -0800 U. Artie Eoff * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: base: manage pad-specific data in a single struct Define a struct (GstVaapiPadPrivate) to encapsulate the pad-specific data (i.e. buffer pool, allocator, info, caps, etc.). Add an interface to retrieve the data struct for a given pad. Finally, update the base plugin to use the data struct throughout the implementation. This will enable us to easily extend the base plugin in the future to allow for N-to-1 pad subclasses (e.g. overlay/ composite). 2019-10-29 15:13:44 -0700 U. Artie Eoff * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: plugins: use plugin base macros to access pad specific data Don't access base struct fields directly since the underlying definition can change. Instead, use the accessor macros. 2019-12-03 00:52:45 +0800 He Junyan * gst/vaapi/gstvaapidecode.c: libs: decoder: Modify decode src's template raw formats We do not need to maintain a standalone list of decoder's output template for raw formats and that is easy to make mistake(for example, the AYVU is wrong in that list, should be VUYA). Just use GST_VAAPI_FORMATS_ALL to replace the raw formats list for src template. 2019-12-11 14:11:13 +0800 He Junyan * gst/vaapi/gstvaapipostproc.c: libs: postproc: Modify src/sink template raw formats We need to provide more precise template caps for postproc's src and sink pads. The GST_VIDEO_FORMATS_ALL make all video formats available which are really superfluous. 2019-12-10 18:40:42 -0300 Thibault Saunier * tests/check/elements/vaapipostproc.c: Do not mix declaration and code 2019-11-03 17:59:01 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: skip all pictures prior the first I-frame Don't try to decode until the first I-frame is received within the currently active sequence. i965 H265 decoder don't show any artifact but it crashes. Fixes: #98 2019-11-27 01:44:05 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/video-format.c: libs: video-format: remove dead code 2019-10-31 00:59:34 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapipluginutil.h: libs: video-format: add GST_VAAPI_FORMATS_ALL GST_VAAPI_FORMATS_ALL collects all declared formats in video-format as a caps template string, and make them available in caps with memory:VASurface feature. Fixes: #199 2019-11-06 22:37:12 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: * tests/internal/test-windows.c: libs: video-format: change GST_VIDEO_FORMAT_AYUV to VUYA. We only support VUYA format in gst vaapi now, need to correct the mapping. 2019-10-09 15:13:09 -0700 U. Artie Eoff * tests/check/elements/vaapipostproc.c: tests: check: vaapipostproc test_orientation_mouse_events Test that vaapipostproc properly translates mouse events when using video-direction (orientation). 2019-10-09 10:11:54 -0700 U. Artie Eoff * tests/check/elements/vaapipostproc.c: * tests/check/meson.build: tests: check: vaapipostproc test_crop_mouse_events Test that vaapipostproc properly translates mouse events when cropping. 2019-10-08 12:20:26 -0700 U. Artie Eoff * meson.build: * meson_options.txt: * tests/check/elements/vaapipostproc.c: * tests/check/meson.build: * tests/meson.build: tests: check: initial unit test support Add minimal unit test toolchain files and a simple vaapipostproc unit test. 2019-10-08 12:19:06 -0700 U. Artie Eoff * meson.build: * tests/examples/meson.build: * tests/examples/test-roi.c: * tests/examples/test-vaapicontext.c: * tests/examples/test-vaapipostproc.c: * tests/examples/test-vaapisink.c: * tests/internal/codec.c: * tests/internal/codec.h: * tests/internal/decoder.c: * tests/internal/decoder.h: * tests/internal/image.c: * tests/internal/image.h: * tests/internal/meson.build: * tests/internal/output.c: * tests/internal/output.h: * tests/internal/simple-decoder.c: * tests/internal/simple-encoder.c: * tests/internal/test-decode.c: * tests/internal/test-decode.h: * tests/internal/test-display.c: * tests/internal/test-fei-enc-in.c: * tests/internal/test-fei-enc-out.c: * tests/internal/test-filter.c: * tests/internal/test-h264.c: * tests/internal/test-h264.h: * tests/internal/test-jpeg.c: * tests/internal/test-jpeg.h: * tests/internal/test-mpeg2.c: * tests/internal/test-mpeg2.h: * tests/internal/test-mpeg4.c: * tests/internal/test-mpeg4.h: * tests/internal/test-subpicture-data.c: * tests/internal/test-subpicture-data.h: * tests/internal/test-subpicture.c: * tests/internal/test-surfaces.c: * tests/internal/test-textures.c: * tests/internal/test-vc1.c: * tests/internal/test-vc1.h: * tests/internal/test-windows.c: * tests/internal/y4mreader.c: * tests/internal/y4mreader.h: * tests/meson.build: tests: move examples and tests to subfolders This makes way for adding unit (check) tests. 2019-10-14 01:01:27 +0100 Tim-Philipp Müller * .gitmodules: * Makefile.am: * autogen.sh: * common: * configure.ac: * git.mk: * gst-libs/Makefile.am: * gst-libs/gst/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst/Makefile.am: * gst/vaapi/Makefile.am: * m4/Makefile.am: * tests/Makefile.am: * tests/elements/Makefile.am: Remove autotools build 2019-10-10 15:26:36 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix off-by-one coord translations When translating navigation x,y coordinates for video-direction, it is necessary to subtract 1 when using the video dimensions to compute the new x,y coordinates. That is, a 100x200 image should map coordinates in x=[0-99],y=[0-199]. This issue was found with unit tests provided in !182. 2019-10-11 17:34:06 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: libs: window: x11: Avoid usage of deprecated API 2019-10-11 17:13:34 +0200 Víctor Manuel Jáquez Leal * meson.build: build: halt meson configuration if no renderer API We should halt meson configuration if there is no render API installed (either DRM, Wayland or X11). That behavior was already in autotools but missed in meson. This patch brings it back. Fixes: #196 2019-10-09 12:12:18 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: fix default orientation regression Fix regression introduced in f232f87f7082 2019-10-07 11:53:23 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: use OP_DATA_DEFAULT_VALUE macro 2019-10-07 11:39:19 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: use macro for returning op default value The code is essentially the same for getting all op default values. Thus, use a macro to help minimize code duplication and [hopefully] encourage using the same mechanism for all default getters. 2019-10-07 09:56:37 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: query param spec for default scale method Related: #159 2019-10-07 09:44:06 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: query param spec for default skin-tone values Related: #159 2019-10-02 12:54:52 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: query param spec for default video-direction Related: #159 2019-10-07 10:23:09 -0700 U. Artie Eoff * .gitignore: add .gitignore 2019-09-05 16:40:52 +0800 Yan Wang * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: Use level value for skin-tone-enhancement filter. Currently the parameter of skin-tone-enhancement filter is forced to zero. In fact it could be set different value by the user. So create a new property named as "skin-tone-enhancement-level" for accepting the used defined parameter value. At the same time, skin-tone-enhancement is marked as deprecated. When skin-tone-enhancement-level is set, skin-tone-enhancement will be ignored. 2019-09-21 13:39:42 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h264, h266: fix g_return_val_if_fail() missuse g_return_val_fail() documentations says: If expr evaluates to FALSE, the current function should be considered to have undefined behaviour (a programmer error). The only correct solution to such an error is to change the module that is calling the current function, so that it avoids this incorrect call. So it was missused in a couple parts of the H264 and H265 internal decoders. This patch changes that to plain conditionals. Also, it was included a couple code-style fixes. 2019-09-23 19:52:20 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * tests/simple-encoder.c: * tests/test-fei-enc-in.c: libs: encoder: remove gst_vaapi_encoder_{ref,unref}() Since GstVaapiEncoder is a descendant of of GstObject, there is no need to keep a custom ref()/unref() methods. This patch deletes them. 2019-09-24 01:03:02 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: correct encoder's ref/unref function. GstVaapiEncoder now is a standard gstobject and need to use gst_object_ref/unref functions. 2019-09-19 12:09:20 -0700 U. Artie Eoff * gst/vaapi/gstvaapiencode_h264_fei.c: gst: encode: h264_fei: remove useless comparison The expression "len >= 0" is always true since "len" is an unsigned type. And it is clear that the writers intention was not to write "len > 0" since we handle len == 0 in the ensuing "if (len < 3)" conditional block. 2019-09-19 11:17:24 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264_fei: fix potential overflow before widen Found by static analysis. encoder->mb_width * encoder->mb_height is evaluated using 32-bit arithmetic before widen. Thus, cast at least one of these to guint64 to avoid overflow. 2019-09-19 10:56:13 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264_fei: remove dead error condition Found by static analysis. The feipak is always null when we reach the error target. 2019-09-19 10:49:11 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: add missing break in switch 2019-09-11 11:56:35 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: libs: video-format: Make all YUV format available The YUV formats have no ambiguity for drivers, so we can add them all. Some old driver(i965) does not implement full get/put image functions but can use derive image funtions for the YUV format. It does not report that kind of formats correctly in image query, but will derive that YUV format image from surface. The dynamic mapping of YUV format will block that manner. Adding more YUV format mapping has no side effect. So considering the legacy driver conformance, we add all YUV formats mapping statically and dynamic mapping RBG formats Fix: #189 Fix: #190 2019-09-18 15:30:03 +1000 Matthew Waters * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: egl: Fix racyness in display thread creation Multiple different scenarios could break the display thread creation and end up blocking waiting for thread o be created. Fix them all by correctly waiting for a new boolean to become valid. 2019-09-18 15:29:03 +1000 Matthew Waters * gst-libs/gst/vaapi/gstvaapiutils_egl.c: egl: don't advertise a wrapped EGLContext as actually wrapped It's not actually wrapped as we create a new EGLContext from the passed in EGLContext. As a result, the created EGLContext was never destroyed. 2019-09-16 23:28:31 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: h264decoder: do not return error for unhandled NAL unit. Some streams have error data introducing unknown NAL type. There are also kinds of NAL types we do not want to handle. The old manner will set a decoder error when encounter this, which cause a latent crash bug. The decoder may successfully decode the picture and insert it into DPB. But there are error NAL units after the AU which cause the post unit error and make that frame dropped. The later output of the picture still want to ref that frame and crash. No need to set decoder error when can not recognize or handle the NAL unit, just skip it and continue. Fix: #191 2019-09-11 14:32:22 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst/vaapi/gstvaapiencode.c: libs: encoders: use GST_PARAM_USER_SHIFT to define internal params This patch makes use of GST_PARAM_USER_SHIFT to define the internal param in encoders to decide which parameters to expose. Thus gstreamer-vaapi will not interfere with any change in GStreamer in the future. Also, the internal symbol was change to GST_VAAPI_PARAM_ENCODER_EXPOSURE to keep the namespacing. 2019-09-09 18:06:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: libs: Add BGR10A2_LE support for color space conversion. Fix: #179 2019-08-23 14:41:06 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: add pointer check for surface_new_from_formats. The command line: gst-launch-1.0 filesrc location=some_name.mjpeg ! jpegparse ! vaapijpegdec ! videoconvert ! video/x-raw,format=I420 ! vaapisink will crash on i965 driver because of no pointer check. We now generate the video format map between GST format and VA format dynamically based on the image format returned by vaQueryImageFormats. i965 driver does to report image format of 444P and Y800 forcc, while the jpeg decoder context VASurfaceAttribPixelFormat use them. We can not recognize these format and pass a NULL pointer to gst_vaapi_surface_new_from_formats. We need to add a pointer check here and let the fallback logic handle this case correctly. Other drivers work well. 2019-09-07 13:23:01 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: guard the VAEntrypointFEI symbol VAEntrypointFEI appeared in libva 2.0.0 (API version 1.0.0) 2019-09-05 14:48:22 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: libs: video-format: Refine the video format mapping. Improve the mapping between va format and gst format. The new map will be generated dynamically, based on the query result of image format in VA driver. Also consider the ambiguity of RGB color format in LSB mode. 2019-04-15 16:51:26 +0100 Philippe Normand * gst/vaapi/gstvaapipluginutil.c: pluginutil: Remove Mesa from drivers white list The Mesa Gallium driver is poorly tested currently, leading to bad user experience for AMD users. The driver can be added back to the white list at runtime using the GST_VAAPI_ALL_DRIVERS environment variable. 2019-07-08 14:18:00 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: allow cropping via properties Add crop-left, crop-right, crop-top and crop-bottom properties to vaapipostproc. 2019-08-30 17:31:45 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: rotate outbuf and crop meta if forwarding When forwarding crop meta to downstream, the output buffer and crop meta need to be rotated, too. Test: for i in 90r 180 90l vert horiz ul-lr ur-ll do gst-launch-1.0 -vf videotestsrc num-buffers=500 \ ! videocrop top=100 bottom=30 left=40 right=20 \ ! vaapipostproc video-direction=$i \ ! vaapisink & \ gst-launch-1.0 -vf videotestsrc num-buffers=500 \ ! videocrop top=100 bottom=30 left=40 right=20 \ ! vaapipostproc video-direction=$i \ ! identity drop-allocation=true \ ! vaapisink done 2019-08-30 14:14:30 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix output buffer WxH for crop meta forwarding Adding crop meta x,y to w,h only compensates for left,top cropping. But we also need to compensate for right,bottom cropping. The video meta contains the appropriate w,h (uncropped) values, so use it instead. Test: gst-launch-1.0 -vf videotestsrc num-buffers=500 \ ! videocrop top=50 bottom=30 left=40 right=20 \ ! vaapipostproc ! vaapisink & \ gst-launch-1.0 -vf videotestsrc num-buffers=500 \ ! videocrop top=50 bottom=30 left=40 right=20 \ ! vaapipostproc ! identity drop-allocation=1 \ ! vaapisink 2019-09-04 10:52:51 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: vaapipostproc: handle size and direction together in src events Mapping a pointer event needs to consider both size and video-direction operations together, not just one or the other. This fixes an issue where x,y were not being mapped correctly for 90r, 90l, ur-ll and ul-lr video-direction. In these directions, the WxH are swapped and GST_VAAPI_POSTPROC_FLAG_SIZE is set. Thus, the first condition in the pointer event handling was entered and x,y scale factor were incorrectly computed due to srcpad WxH swap. This also fixes all cases where both video-direction and scaling are enabled at the same time. Test that all pointer events map appropriately: for i in `seq 0 7` do GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \ ! vaapipostproc video-direction=${i} width=300 \ ! vaapisink GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \ ! vaapipostproc video-direction=${i} width=300 height=200 \ ! vaapisink GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \ ! vaapipostproc video-direction=${i} height=200 \ ! vaapisink GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \ ! vaapipostproc video-direction=${i} \ ! vaapisink done 2019-08-20 14:22:57 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: advertise crop meta is handled Advertise to upstream that vaapipostproc can handle crop meta. When used in conjunction with videocrop plugin, the videocrop plugin will only do in-place transform on the crop meta when vaapipostproc advertises the ability to handle it. This allows vaapipostproc to apply the crop meta on the output buffer using vaapi acceleration. Without this advertisement, the videocrop plugin will crop the output buffer directly via software methods, which is not what we desire. vaapipostproc will not apply the crop meta if downstream advertises crop meta handling; vaapipostproc will just forward the crop meta to downstream. If crop meta is not advertised by downstream, then vaapipostproc will apply the crop meta. Examples: 1. vaapipostproc will forward crop meta to vaapisink gst-launch-1.0 videotestsrc \ ! videocrop left=10 \ ! vaapipostproc \ ! vaapisink 2. vaapipostproc will do the cropping gst-launch-1.0 videotestsrc \ ! videocrop left=10 \ ! vaapipostproc \ ! identity drop-allocation=1 \ ! vaapisink 2019-08-29 18:44:36 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: clean two virtual func in encoder class set_property and get_default_properties functions are no longer needed for encoder class. 2019-08-29 18:43:30 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.h: libs: encoder: delete old set_property and property enum feienc264 2019-08-29 18:39:27 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: libs: encoder: delete old set_property and property enum in h264 fei 2019-08-29 18:37:58 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: libs: encoder: delete old set_property and property enum in vp9 2019-08-29 18:36:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: libs: encoder: delete old set_property and property enum in vp8 2019-08-29 18:35:59 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: libs: encoder: delete old set_property and property enum in mpeg2 2019-08-29 18:34:57 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: libs: encoder: delete old set_property and property enum in jpeg 2019-08-29 18:31:56 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: delete old set_property and property enum in h265 2019-08-29 18:30:07 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: delete old set_property and property enum in h264 2019-08-29 18:17:42 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: delete EncoderPropInfo related functions 2019-08-29 16:13:19 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: libs: encoder: delete encoder_set_property We no longer need this obsolete set_property function now after switch to standard gobject's property manner. Also delete the old encoder's property enum in the header file. 2019-08-29 15:59:43 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: delete properties_get_default for base class 2019-08-29 15:52:04 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: plugin: encode: delete useless init_properties. Also delete the get_properties function in encode class. We now use g_object_class_list_properties to get all properties for internal encoder class. 2019-08-29 15:43:45 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: plugin: encode: delete set/get_property func in encode class Use standard gobject's property functions to replace the old way. 2019-08-29 15:31:16 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: plugin: encode: delete gst_vaapiencode_init_properties No need to init the properties got by get_default_properties func now. The properties are inited correctly in internal encoder class. 2019-08-29 15:19:10 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: delete 3 useless init macro 2019-08-29 15:16:26 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.h: libs: encoder: delete get_default_properties of feienc 2019-08-29 15:14:14 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: libs: encoder: delete get_default_properties of H264 Fei 2019-08-29 15:07:17 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: libs: encoder: delete get_default_properties of VP9 2019-08-29 15:06:25 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: libs: encoder: delete get_default_properties of VP8 2019-08-29 15:03:52 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: libs: encoder: delete get_default_properties of MPEG2 2019-08-29 15:03:19 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: libs: encoder: delete get_default_properties of JPEG 2019-08-30 19:15:38 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: delete get_default_properties of H265 2019-08-29 14:59:12 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: delete get_default_properties of H264 2019-08-29 14:53:59 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: delete the useless constructed func for encoder. 2019-08-26 23:16:33 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: implement get_view_ids for h264 encoder. 2019-08-20 23:56:33 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: gst: encode: enable new type of property mechanism. 2019-08-20 22:16:35 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: gst: encode: add property help functions for encoder properties. The encoder is a true gstobject now and all the properties are using gobject's properties mechanism. Add help functions to handle the properties between encode and encoder class. The basic idea is mapping the same property between encoder and encode. All the encoder's properties will have the same name, the same type in encode. The set/get property function just forward the property setting/getting to the encoder using the same property name and value. Because the encoder is created on needed, we need to cache the property setting in encode. 2019-08-30 18:39:32 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: add flags to all encoder properties. G_PARAM_CONSTRUCT make all properties init correctly, we do not need to init the properties manually. G_PARAM_FLAG_VAAPI_ENCODER_EXPOSURE is a vaapi encoder specific flag, means need to expose the property to according encode class. 2019-08-20 17:00:39 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: Add properties for h264 encoder fei. Install properties for h264 encoder fei class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 15:58:30 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: Add properties for h264 fei encoder. Install properties for h264 fei encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 15:29:27 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: Add properties for vp9 encoder. Install properties for vp9 encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 15:01:02 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: Add properties for vp8 encoder. Install properties for vp8 encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 14:31:58 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: libs: encoder: Add properties for mpeg2 encoder. Install properties for mpeg2 encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 14:53:06 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: libs: encoder: Add properties for jpeg encoder. Install properties for jpeg encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 14:12:36 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: Add properties for h265 encoder. Install properties for h265 encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-20 01:33:40 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: Add properties for h264 encoder. Install properties for h264 encoder class. Also set the new get/set property functions for gobject class. Still use the old properties way now and this new feature will be enabled later. 2019-08-19 15:38:09 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: add properties and prop help functions Add all common properties to encoder base class. rate-control and tune are moved to sub class. 2019-08-29 14:38:49 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: delete useless gst_vaapi_encoder_new func. GstVaapiEncoder is a abstract gobject and never be created directly. 2019-07-27 00:55:53 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.h: lib: encoder: gstobjectfy all vaapi encoders. Replace all gstvaapiobject in vaapi encoders with standard gstobject. Let the gstobject common logic to handle all the init and finalize works. But the property install/set/get still use the old way, need to be improved later. 2019-08-29 12:11:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: check for filter before appending caps While ensuring the allowed sink pad caps, the filter attributes set the frame size restriction, but it is not ensured, at that moment, that the filter is already instantiaded. In order to silence the glib logs, this patch add only calls gst_vaapi_filter_append_caps() if the filter is instantiated. 2019-08-28 12:49:03 -0400 Thibault Saunier * gst/vaapi/gstvaapidecodebin.c: Classify vaapidecodebin as a hardware decoder 2019-08-27 18:12:45 +0800 He Junyan * gst/vaapi/gstvaapipostproc.c: libs: postproc: fix a memory leak point. filter_ops and filter_formats should already have valid value when the function gst_vaapipostproc_ensure_filter_caps re-enter 2019-08-27 01:30:36 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_core.c: libs: util: Fix a memory leak in config_surface_attributes_get 2019-08-22 14:33:54 +0800 Wangfei * gst/vaapi/gstvaapidecode.c: vaapidecode: support transform ROI meta This will benefit the use case like: src ---> encode ---> decode ---> circle ROI ---> sink | | --> analyse to --> get ROI 2019-08-23 19:10:15 +0200 Mathieu Duponchelle * gst/vaapi/gstvaapidecodedoc.c: docstrings: port ulinks to markdown links 2019-08-20 17:05:14 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext_overlay.c: * gst-libs/gst/vaapi/gstvaapicontext_overlay.h: * gst-libs/gst/vaapi/meson.build: libs: remove context's overlay The context overlay was an optimization to apply a video composition to all the surfaces bound to a context. But since commit 18031dc6 this optimization was disabled, so it is better just get rid of it. 2019-08-20 16:50:46 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst/vaapi/gstvaapipluginutil.c: * tests/test-subpicture.c: libs: remove surface's parent context In commit 18031dc6 surface's parent context is not assigned because of circular references. Since then (2013), there's has no issue with subpictures attached to a context, the current only users of this API. This patch cleans up all of related code with the unused surface's parent context. 2019-08-18 13:53:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: guard if no structure is available in caps 2019-08-18 13:53:19 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: append frame size restrictions in caps 2019-08-18 13:09:58 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: libs: profilecaps: refactor common code 2019-08-16 19:35:58 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: set frame size restrictions in caps Fixes: #12 2019-08-16 19:28:27 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst/vaapi/gstvaapiencode.c: vaapiencode: enhance how the profile is defined This code doesn't define the profile used by the internal encoder, but it used to "predict" which is going to be used and to get the caps restrictions. Before the profile was predicted by checking the donwstream caps, but sometimes they are not defined, setting an unknown profile. In order to enhances this situation, the encoder asks to internal encoder if it has one. If so, it is used. To ask the internal encoder's profile a new accessor function was added: gst_vaapi_encoder_get_profile() 2019-08-16 19:26:36 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: * gst-libs/gst/vaapi/gstvaapiprofilecaps.h: libs: profilecaps: defines gst_vaapi_profile_caps_append_encoder() Previously it was just a boilerplate. Now it is real implementation. 2019-08-16 19:17:48 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: treat va_rt_format as bitwise flag The return value of vaGetConfigAttributes() of VAConfigAttribRTFormat is a bitwise flag with *all* the supported chroma types. Previously it was assumed that the return value was a single value, thus when returning the GST_VAAPI_CHROMA_TYPE_XXX the code was a simple case. But it is wrong. This patch changes the case block with a sequence of ifs testing the bitwise. For now we assume a "priority" list in the testing sequence. 2019-08-16 18:07:43 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * tests/test-display.c: libs: profile: add gst_vaapi_profile_get_va_name() gst_vaapi_profile_get_name() returns a proper name for GstCaps. Nonetheless, there are many profiles which don't have a name representation for that realm. gst_vaapi_profile_get_va_name() returns the name of the profile according to its VAProfile name. This new funtion is used in the encoder error message. 2019-08-05 19:47:30 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiprofilecaps.c: * gst-libs/gst/vaapi/gstvaapiprofilecaps.h: * gst-libs/gst/vaapi/meson.build: * gst/vaapi/gstvaapidecode.c: libs: profilecaps: move caps config into a new file Implement all the appending of frame size restrictions in caps, for encoders and decoders, in a new source file. 2019-08-05 19:45:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: libs: decoder: ref the caps as property 2019-08-02 16:56:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: libs: context: add gst_vaapi_context_get_surface_attributes() This function copies the surface attributes from the context's object to the caller. 2019-08-02 12:46:55 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: move memory types conversions to gstvaapiutils And add more supported memory types by current VA. 2019-08-01 19:48:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_core.c: * gst-libs/gst/vaapi/gstvaapiutils_core.h: libs: utils: remove unused function gst_vaapi_get_surface_formats() 2019-08-01 19:46:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapifilter.c: libs: context, filter: use new surface attributes API 2019-08-01 19:13:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_core.c: * gst-libs/gst/vaapi/gstvaapiutils_core.h: libs: utils: add gst_vaapi_config_surface_attributes_get() To extract the surface restrictions per config using a new structure: GstVaapiConfigSurfaceAttributes 2019-07-31 13:08:43 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_core.c: Split the surface attribute retrieval 2019-07-15 21:51:46 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: handle navigation downstream event When navigation events contains coordiantes those have to be mapped to the new size and/or orientation. 2019-07-15 21:23:21 +0200 Víctor Manuel Jáquez Leal * tests/elements/test-vaapisink.c: test-vaapisink: also use vaapipostproc to change orientation 2019-07-15 21:27:20 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: handle image-orientation upstream event Now that vaapipostproc can possible handle video-direction, it should also handle the image-orientation event from upstream if video-direction property is set to auto. 2019-07-26 22:09:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add missing locks when adding flags 2019-07-26 22:05:29 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: update filter before fixate caps It is requiered to know if postproc is capable to change the video direction before fixating the source caps. In order to do it, it'ss required to know if there's a functional VPP, but that's checked at create() vmethod, which occurs after caps fixating. This patch checks for a functional VPP at fixate caps and, if so, checks for the enabled filtes and later do the caps fixations. 2019-07-26 19:46:09 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: element warning if video direction is unsupported If the video direction is unsupported by the driver, an element warning is posted in the bus to notify the application. gst_vaapi_enum_type_get_nick() was added in the library thus it can be used elsewhere. It retrives the nick from an enum gtype. 2019-07-26 19:09:54 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: check mirror and rotation caps only once This patch locks the display before querying the pipeline caps and stores the mirror and rotation capabilities, thus they are not queried every time the video direction is set. 2019-08-16 19:51:29 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: set VP9_0 profile as default Commit 0afc8131 introduced a regression and only NV12 format were admitted, failing in any other valid color format. This patch sets the profile to GST_VAAPI_PROFILE_VP9_0 by default. 2019-08-16 13:25:06 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: fail if first color balance value is invalid 2019-08-06 19:24:08 +0800 Yan Wang * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: filter: set all color balance values When set multiple settings of color balance like hue, saturation, brightness and contrast for vaapipostproc, they should be set as parameters of color balance filter, at the same color balance filter calling. Otherwise, multiple color balance filter calling will cause previous setting get reset by the last calling with default value. Fixes #182. Signed-off-by: Yan Wang 2019-08-16 11:02:08 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: h265dec: remove limitation of get iq matrix According hevc spec, scaling_list_data is not related to chroma_format_idc. 2019-05-30 23:52:51 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: videopool: fix undocumented behavior and counting gst_vaapi_video_pool_reserve_unlocked() hit an undocumented behavoir because it locks twice the same mutex. Also, n had different meanings in the current code: as an increase value and as a new total of allocated surfaces. This patche removes the undocumented behavoir (usually a deadlock) and fixes the meaning of n as the new total of allocated surfaces. Signed-off-by: Víctor Manuel Jáquez Leal 2019-07-17 11:56:45 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: Add missing entries for string_of_VAEntrypoint. 2019-07-18 22:01:01 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: Consider vp9 profiles based on input format. Only support GST_VAAPI_PROFILE_VP9_0 and GST_VAAPI_PROFILE_VP9_2 now. Fix: #184 2019-08-12 18:41:52 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: demote error message to info The main reason to demote the message's level is because it is not an error, it's a possible output of the trial and there's a code path that handles it. Secondly, it's very annoying when using gallium driver for radeon. 2019-07-18 13:32:46 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapivalue.c: libs: encoder: h264: support ICQ/QVBR bitrate control mode ICQ is Intelligent Constant Quality. It will use the initial QP vaule of icq-quality-factor to adjust QP at MB level intelligently to improve subjective quality. QVBR is Quality defined VBR. It will use qvbr-quality-factor to adjust QP for each MB to get enough quality picture without waste of bits. 2019-08-05 10:51:24 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapitypes.h: libs: Let GST_VAAPI_RATECONTROL_MASK return unsigned int The value return from GST_VAAPI_RATECONTROL_MASK will be used by GST_VAAPI_POPCOUNT32 as its inpput. GST_VAAPI_POPCOUNT32 can only deal with unsigned int. Otherwise there may be an error of out of range of integer if we define few more rate-control mode. 2019-06-07 09:54:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: set queue's max size buffers to 1 Otherwise the queue will swallow all the available decoder's surfaces reaching a dead-lock. This setting might impact the bin's peformance, but it's a trade-off. 2019-06-07 09:53:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: set properties default values 2019-05-31 13:12:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't error if can't push buffers downtream When the code path goes to push buffers downstream when no surface available in decoder context, and it fails the code bails out with a fatal error. That behavior is wrong, since it shouldn't be fatal. The use case is when the video stream is disabled. This patch just ignores the errors in this situation and demotes the level of a log message. 2019-05-18 13:24:35 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h264,h265: add new property "max-qp" Add new property "max-qp" to allow set the maximum quantisation parameter values. 2019-05-23 10:18:52 -0400 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: add low power mode encode By now, this feature only support by media-driver on Ice Lake platform, more information you can reference: https://github.com/intel/media-driver 2019-07-15 15:33:07 -0700 U. Artie Eoff * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: update PAR when rotating When rotating, swap pixel-aspect-ratio during negotiation. Fixes #181 2019-07-01 15:26:18 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: add rotation support Adds vpp rotation support to vaapipostproc. Uses property video-direction. Default is identity (no rotation). Closes #104 2019-05-22 10:47:30 -0400 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: pass diff_cu_qp_delta_depth flag to driver Intel media-driver requires enablement of diff_cu_qp_delta_depth when cu_qp_delta_enabled_flag enabled. Fixes: #177 2019-07-01 17:02:33 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiutils.c: libs: encoder: Add MB ratecontrol mode to get its string 2019-07-01 16:52:00 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiutils.c: libs: encoder: refine guard of bitrate control mode Remove useless guard of all bitrate control mode's guard except MB which is define in VA-API version 0.39.1. 2019-06-29 00:08:40 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: Update for parse_vui_params parameter removal. Update calls to the h264 parser lib for removal of the parse_vui_params parameter. 2019-06-24 16:26:56 -0400 Wang Zhanjun * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: dec: vp9: do not use display size as decoded size If display size is smaller than current frame size, then the crop size will be set as display size, which either crashes the pipeline or the output MD5 does not match. Rather it should use the actual decoded size. This patch removes the cropping set. For rendering we can use aspect ratio to set display size. Fixes #175 Signed-off-by: Wang Zhanjun Signed-off-by: Xu Guangxin 2019-06-28 16:32:51 +0200 Víctor Manuel Jáquez Leal * README: Update README 2019-06-25 19:11:12 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: libs: dec: h265: Consider chroma_bit_depth to choose chrome type For some main-10 stream, sometime the luma is 8 bits while chrome is more than 8 bits, which cause using the wrong NV12 surface as the render target and decoding error. Fix #176 2019-06-25 10:31:20 +0800 Wangfei * gst/vaapi/gstvaapidecode.c: vaapidecode: set initial decode format according surface chroma type For surfaces with different chroma type, it is prefer to initialize a format which chroma type should be same with surface chroma type instead of using fixed NV12. 2019-05-30 09:48:51 -0400 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: libs: decoder: jpeg: add support 400/411/422/444 chroma type When create vaapi surface, it is better to use the chroma type get from jpeg file instead of using fixed 420 format. And the correct chroma type can be determined by horizontal_factor/vertical_factor flags that get from jpegparse. 2019-06-22 00:05:24 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: dec: h265: Fix profile_idc mapping. The old mapping values return by gst_vaapi_utils_h265_get_profile_idc is wrong, though GST_H265_PROFILE_IDC_MAIN and GST_H265_PROFILE_IDC_MAIN_10 happened to be the correct value. We only support Annex A profile_idc (1-4). 2019-06-10 20:46:30 -0700 U. Artie Eoff * gst/vaapi/gstvaapipluginbase.c: plugins: remove last negotiated video info if caps are same If the allocation caps and negotiated caps are the same, then ensure any previously negotiated video info is also removed. This can occur when multi-resolution video decoding returns to it's original resolution. Fixes #170 2019-06-10 20:39:28 -0700 U. Artie Eoff * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: allow negotiated info to be removed Allow NULL negotiated_vinfo to be passed into gst_allocator_set_vaapi_negotiated_video_info to allow any previously set info to be removed. 2019-06-06 17:24:30 +0300 Freyr * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp8,vp9: reset frame_counter when input frame's format changes When input frame's formate changes, vp{8,9} encoders don't reset their frame counter, hence the newly created frame could become a P-frame, leading to some major troubles (sigabrt in libdrm in case of vp9). This patch adds some frame prediction-related reset logic to the `flush' methods of GstVaapiEncoderVP8 and GstVaapiEncoderVP9 implementations. 2019-05-31 12:30:03 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: increase bitrate prop max value There are many profile levels that can support more than 102400 kbps. Thus, increase the max allowed bitrate property value from 102400 kbps to 2048000 kbps (same as msdk encoder plugins). 2019-06-04 13:27:50 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: libs: mpeg2 encoder: No packed header for SPS and PPS Dislable passing down packed PPS and PPS to driver if driver does not want it. Fix: #168 2019-05-31 23:10:33 +0200 Niels De Graef * configure.ac: * meson.build: * tests/output.c: meson: Bump minimal GLib version to 2.44 This means we can use some newer features and get rid of some boilerplate code using the G_DECLARE_* macros. As discussed on IRC, 2.44 is old enough by now to start depending on it. 2019-05-31 13:08:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: dec: vp9: clear parser pointer after release Fix an use-after-release of the parser pointer in VP9 decoder. 2019-05-28 12:09:36 +0300 Freyr666 * gst/vaapi/gstvaapiencode.c: vaapiencode: Fixes deadlock in gst_vaapiencode_change_state function This fixes a deadlock in gst_vaapiencode_change_state, which was due to srcpad's chain function was locked waiting for available buffers. Since the coded buffers in codedbuf_queue become available after sinkpad consume the encoded frames, Paused -> Ready state change leads to deadlock. Coded buffers are never consumed and marked free, hence gst_vaapiencode_handle_frame waits for available buffers and holds the stream_lock of the srcpad. 2019-05-29 23:08:22 +0200 Mathieu Duponchelle * gst-libs/gst/vaapi/gstvaapitypes.h: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodedoc.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: doc: remove xml from comments 2019-05-13 16:39:33 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add mirror support Adds vpp mirroring support to vaapipostproc. Use property video-direction. Valid values are identity, horiz or vert. Default is identity (no mirror). Closes #89 v2: Use GstVideoOrientationMethod enum v3: Don't warn for VA_MIRROR_NONE. Use GST_TYPE_VIDEO_ORIENTATION_METHOD type. v4: Query VAAPI caps when setting mirror value instead of during per-frame processing. v5: Return TRUE in warning cases when setting mirror value. 2019-05-29 01:35:17 +0200 Mathieu Duponchelle * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapisink.c: doc: fix some incorrect gtk-doc links 2019-05-16 09:22:42 -0400 Thibault Saunier * docs/gst_plugins_cache.json: docs: Update plugin cache Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/issues/36 2019-05-16 16:46:43 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.h: libs: surface: fix documentation format 2019-05-16 10:05:17 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: enc: h265: reset num_ref_idx_l1_active_minus1 when low delay B. When enable low delay B, the reference list 1 will be same with reference list 0, so need reset the num_ref_idx_l1_active_minus1 to num_ref_idx_l0_active_minus1. Fixes: #160 2019-05-13 19:05:43 -0400 Thibault Saunier * docs/meson.build: meson: Fix call to wrong function 2018-10-22 11:48:29 +0200 Thibault Saunier * Makefile.am: * configure.ac: * docs/Makefile.am: * docs/gst_plugins_cache.json: * docs/index.md: * docs/meson.build: * docs/plugins/Makefile.am: * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins-sections.txt: * docs/plugins/gstreamer-vaapi-plugins.types: * docs/plugins/inspect/plugin-vaapi.xml: * docs/plugins/running.xml: * docs/sitemap.txt: * docs/version.entities.in: * gst/vaapi/meson.build: * meson.build: * meson_options.txt: docs: Port to hotdoc 2019-05-10 18:29:10 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: not call ensure_num_slices inside g_assert g_assert will take no effect when glib's G_DISABLE_ASSERT macro is defined. The function inside the g_assert will take no effect and we will fail to set the correct slice number. 2019-04-29 09:52:39 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: h265: dec: Add extension flags setting. Use VAPictureParameterBufferHEVCExtension& VASliceParameterBufferHEVCExtension to pass extension setting from some extension profile clips which may include these information. The hevc extension setting only supported after libva release 2.2.0 (API 1.2.0). 2019-05-01 12:56:55 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: add target-percentage property Allow users to set the target-percentage for variable rate controls. The default value is 70 (as hard-coded prior). v2: minimum allowed value changed from 0 to 1 v3: target-percentage unchanged if CBR used Resolves #129 2019-05-09 00:09:21 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.h: libs: encoder: Add a missing comment for DEFAULT_ROI_VALUE property. 2019-05-08 23:39:20 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: Enable trellis quantization method. The advanced trellis algorithm is supported in VA driver. We add its support as a property named "trellis" of encoder. It only works for H264 now, should be more in future. 2019-05-07 11:03:51 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: decoder: vp9: support 422/444 8bit/10bit chroma type. According to the vp9 sepc, profile 1/3 support 422/440/444 chroma type, so we need to add subsampling_x&subsampling_y to fix it. Here is the relationship between chroma type and profile and subsampling_x&subsampling_y according to vp9 spec: ------------------------------------------ Profile | Bit depth | Chroma subsampling | ------------------------------------------ 0 | 8 | 420 | ------------------------------------------ 1 | 8 | 422,440,444 | ------------------------------------------ 2 | 10, 12 | 420 | ------------------------------------------ 3 | 10, 12 | 422,440,444 | ------------------------------------------ ----------------------------------------------- Subsampling_x | Subsampling_y | Chroma format | ----------------------------------------------- 0 | 0 | 444 | ----------------------------------------------- 0 | 1 | 440 | ----------------------------------------------- 1 | 0 | 422 | ----------------------------------------------- 1 | 1 | 420 | ----------------------------------------------- 2019-04-16 18:33:54 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: libs: Add packed 24 RGB format support. Can not find a suitable chrome_type for this GST_VIDEO_FORMAT_RGB packed 24 format. Just use GST_VAAPI_CHROMA_TYPE_RGB32 as its chrome type. This kind of surface will just be created by new API with fourcc and no old style chrome based creation is available. fixes: #151 2019-03-15 14:29:41 +0800 Wangfei * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: vaapiencode: handle DMABuf caps feature in sink pad Add DMABuff caps features in all encoders' sink pad. 2019-05-03 10:31:52 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: continue if roi meta is NULL Coverity scan bug: If the function actually returns a null value, a null pointer dereference will occur. In gst_vaapi_encoder_ensure_param_roi_regions(): Return value of function which returns null is dereferenced without checking 2019-04-15 19:58:14 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: lib: decoder: vp9: Set chroma_type by VP9 bit_depth The decoder's surface chroma type should depend on the bit depth of VP9's parser. For 10bits VP9 stream, we need to use P10LE kind 10 bits surface as the decoder result. Fixes #155 2019-05-02 16:00:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: don't do any color conversion when GL_TEXTURE_UPLOAD https://bugzilla.gnome.org/show_bug.cgi?id=748184 has resurrected with commit 3e992d8a Since gst_vaapi_find_preferred_caps_feature() returns a color format from caps negotiation, different from the default one (NV12), the postproc enables the color transformation. But when GL_TEXTURE_UPLOAD feature is negotiated, no color transformation shall be done. Nonetheless, with commit 3e992d8a the requested format changes firstly, because there's no video sink yet, so ANY caps are negotiated; but later, when there's a video sink and a caps renegotiation, the GL_TEXTURE_UPLOAD is negotiated though the color format conversion still ongoing. It is required to reset that conversion. This patch force default color format when GL_TEXTURE_UPLOAD is selected as preferred, thus avoiding the color conversion. Fixes: #157 2019-04-19 15:49:37 -0700 Julien Isorce * gst-libs/gst/vaapi/gstvaapisurface_drm.c: libs: surface: fix double free when dmabuf export fails Happens if vaAcquireBufferHandle fails. 2019-04-29 20:10:39 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: h264encoder: fix a typo of GstVaapiEncoderH264PredictionType 2019-04-19 10:43:35 +0100 Tim-Philipp Müller * RELEASE: * configure.ac: * docs/plugins/inspect/plugin-vaapi.xml: * meson.build: Back to development === release 1.16.0 === 2019-04-19 00:38:12 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.16.0 2019-04-19 00:38:12 +0100 Tim-Philipp Müller * docs/plugins/inspect/plugin-vaapi.xml: Update docs 2019-04-15 19:34:05 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264,h265: guard VA version for max_qp property This patch fixes a regression from commit 5b1fe9c6. max_qp, in rate control configuration, appeared in libva release 2.1 (API 1.1), thus it is required to guard the VA API version. Fixes: #150 2019-04-08 18:29:35 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: libs: Add RGB565 image format support. 2019-04-10 13:59:05 +0200 Víctor Manuel Jáquez Leal * configure.ac: build: configure: delay USE_GTK conditional until check libva-x11 libva-x11 is used for X11 applications, so it is required to build any GTK application. Later, when Wayland test is added, we should change this. 2019-04-10 13:25:10 +0200 Víctor Manuel Jáquez Leal * configure.ac: build: configure: disable GLX if libva-x11 is not found 2019-04-15 13:55:26 +0200 He Junyan * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: avoid macro evaluation when stringify string_of_va_chroma_format() gets a wrong string format description. For example, the YUV420_10BPP get a string of 0x00000100 as output. It's because VA_RT_FORMAT_xxx values are macro definitions. And STRINGIFY(VA_RT_FORMAT_xxx) will expand to its real value 0x00000XXX. To avoid the macro evaluation, it is changed to show only the color format without VA_RT_FORMAT_ prefix. 2019-04-15 13:54:15 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: use glib's macros Don't reinvent the wheel. 2019-04-11 15:05:02 +0800 Wangfei * gst/vaapi/gstvaapipluginutil.c: plugins: find the preferred format from right caps. When the downstream has any caps, then raw video feature will be used. At this situation, the preferred format should be chose from caps which contains "vide/x-raw" feature instead of from the fist allowed caps. Fixes #142 2019-04-10 11:43:33 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: fill tier in va seq param buf Now that tier is calculated in commit 58e74f9440fe (!68), ensure we fill in the general_tier_flag in the VAEncSequenceParameterBufferHEVC. === release 1.15.90 === 2019-04-11 00:40:03 +0100 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.15.90 2019-04-11 00:40:03 +0100 Tim-Philipp Müller * docs/plugins/inspect/plugin-vaapi.xml: Update docs 2019-04-09 20:42:04 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Recognize the correct level and tier. The current manner can not recognize the correct level and always set the tier to main. Need to add frame rate check to recognize levels such as 4.1, 6.2, etc. We also add a logic to check main and high tier based on bitrate. Fixes: #145 2019-04-03 14:12:23 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264,h265: Set max_qp if min_qp is non-zero. media-driver currently fails to set a correct value of max_qp when min_qp is different to zero, in CBR and VBR mode, generating full quality frames, thus unexpected huge output. This patch sets max_qp to an arbitrary value to avoid this output temporary. Fixes: #144 2019-04-09 12:42:56 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264,h265: initial and minimal QP can be zero Currently the minimal value for either min_qp and init_qp are 1, but VA documentation specifiy that zero is also valid and means to ignore the quantiser. The default value is not changed though to avoid behaivor changes to users. 2019-04-09 09:20:23 +0800 Haihao Xiang * tests/elements/meson.build: meson: build test-vaapicontext when using X11 x11_dep and libva_x11_dep are optional and meson ignores these dependencies even if they are added into the dependency list. This fixes the error below when libva-x11 is not avaiblabe: cc -Itests/elements/tests@elements@@test-vaapicontext@exe -Itests/elements -I../../gstreamer-vaapi/tests/elements -I. -I../../gstreamer-vaapi/ -Igst-libs -I../../gstreamer-vaapi/gst-libs -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/orc-0.4 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -g -fvisibility=hidden -fno-strict-aliasing -pthread -DHAVE_CONFIG_H -MD -MQ 'tests/elements/tests@elements@@test-vaapicontext@exe/test-vaapicontext.c.o' -MF 'tests/elements/tests@elements@@test-vaapicontext@exe/test-vaapicontext.c.o.d' -o 'tests/elements/tests@elements@@test-vaapicontext@exe/test-vaapicontext.c.o' -c ../../gstreamer-vaapi/tests/elements/test-vaapicontext.c ../../gstreamer-vaapi/tests/elements/test-vaapicontext.c:29:10: fatal error: va/va_x11.h: No such file or directory #include 2019-04-01 12:56:28 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: libs: encoder: h264_fei: Use gst_param_spec_array for view-ids GValueArray is deprecated. Use GstValueArray instead. 2019-03-30 18:29:31 +0100 Danilo Spinella * gst/vaapi/gstvaapipluginutil.c: vaapipluginutil: Fix #endif for USE_X11 2019-03-29 18:29:51 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: simplify the view-ids setting 2019-03-26 14:54:47 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: Use gst_param_spec_array for view-ids GValueArray is deprecated. Use GstValueArray instead. gst_param_spec_array can be deserialized from command line using: vaapih264enc view-ids="<(uint)40,(uint)100>" num-views=2 While the g_param_spec_value_array() can not, and always get error: "gst_value_deserialize_g_value_array: unimplemented" Also fixed an out-of-range bug. 2019-03-29 13:33:41 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: libs: Change the parameter setting order when encode picture. The order in gst_vaapi_enc_picture_encode when encoding one picture is not very correct. The misc parameters are set before the picture parameters. Some of the misc parameters such as ROI may change the current picture parameters. But the later setting of picture parameter will re-init all picture related parameters and clear the previous setting. The right order should be picture parameter first and then misc parameters. Signed-off-by: He Junyan 2019-03-26 14:20:34 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: libs: decoder: jpeg: support dynamic resolution change decode. Add size_changed flag to watch out resolution. if change, reset jpeg decoder's context. 2019-03-23 15:34:03 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: add low power mode encode. By now, this feature only support by media-driver on Ice Lake platform, more information you can reference: https://github.com/intel/media-driver 2019-03-15 18:40:21 +0800 He Junyan * gst/vaapi/gstvaapiencode.c: vaapiencode: gobject's prop_id differ from vaapi encoder The vaapi internal encoder's property id are negative, thus they are different from GObject's property ids. gst_vaapi_encoder_set_property() should map to the internal encoder property id, assigned in gst_vaapiencode_default_set_property(). 2019-03-21 16:56:34 +0000 Tim-Philipp Müller * meson.build: meson: disable compiler warnings for unused vars and args if gst debug system is disabled 2019-03-21 13:31:57 +0000 Tim-Philipp Müller * meson.build: meson: use new 'python' module instead of deprecated 'python3' one 2019-03-11 18:38:36 -0300 Thibault Saunier * common: Update common submodule back to 59cb678164719ff59dcf6c8b93df4617a1075d11 It was wrongly changed in 3d9555a86d45565870c684fe00ec8bbb0fed7205 2019-03-04 09:16:17 +0000 Tim-Philipp Müller * NEWS: * RELEASE: * configure.ac: * docs/plugins/inspect/plugin-vaapi.xml: * meson.build: Back to development 2019-03-01 12:33:26 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapisurfacepool.c: libs: Fix a typo in comments. Fix a typo in function description of gst_vaapi_surface_pool_new_with_chroma_type. Signed-off-by: He Junyan 2019-02-27 13:02:10 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugin: if any caps in downstream, negotiate raw video When downstream has any caps, vaapi should not shovel vaapi featured buffers, but rather plain raw video, assuming always the worst case scenario (downstream cannot handle featured video memory but raw system memory buffers). This patch query the peer caps without any filter, to know if donwstream just ask for any caps, if so jump to the color space checking, otherwise do the caps intersection and continue with the feature selection algorithm. Fixes: #139 === release 1.15.2 === 2019-02-26 12:01:53 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.15.2 2019-02-26 12:01:53 +0000 Tim-Philipp Müller * docs/plugins/inspect/plugin-vaapi.xml: Update docs 2019-02-05 16:59:40 +0800 He Junyan * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: Prefer same format for surface and image We prefer to use the same format between image and surface for gst vaapi allocator. The old way may choose different formats between image and surface. For example, the RGBA image may have a NV12 surface. So we need to do format conversion when we put/get image to surface. Some drivers such as iHD can not support such conversion and always cause a data flow error. There may also have some performance cost for format conversion when put/get images. So we prefer to use the same format for image and surface in the allocator. If the surface can not support that format, we then fallback to find a best one as the surface format. Co-authored-by: Víctor Jáquez 2019-02-15 15:19:51 +0800 He Junyan * gst-libs/gst/vaapi/video-format.c: libs: Delete the duplicated ARGB video format. Two ARGB formats with the same format information. Should be verbose and delete one. Signed-off-by: He Junyan 2019-02-13 10:39:59 -0500 Adam Jackson * common: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: glx: Stop specifying GLX_DEPTH_SIZE This code is just confused. It's asking for at least as many bits of (z-axis) depth as the root window has bits of (color) depth. For rgb565 or rgb888 this is harmless, but at 10 bits per channel this demands a 30-bit or deeper Z buffer. While some hardware could in principle do a 32-bit Z buffer, Mesa does not expose such fbconfigs (at least on Intel and AMD). We're not actually using the Z buffer, so just stop asking for one. 2019-01-14 11:30:48 +0100 Niels De Graef * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/meson.build: * gst/vaapi/gstvaapisink.c: * meson.build: libs: wayland: add support for XDG-shell protocol [wl_shell] is officially [deprecated], so provide support for the XDG-shell protocol should be provided by all desktop-like compositors. (In case they don't, we can of course fall back to wl_shell). Note that the XML file is directly provided by the `wayland-protocols` dependency and generates the protocol marshalling code. [wl_shell]: https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Client/group__iface__wl__shell.html [deprecated]: https://github.com/wayland-project/wayland/commit/698dde195837f3d0844b2725ba4ea8ce9ee7518c 2019-02-16 19:09:50 +0100 Niels De Graef * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: Prefix wl_shell_surface field with `wl_` It will help us to distinguish from other Wayland shell surface (such as XDG-shell) later on. 2019-01-14 09:58:19 +0100 Niels De Graef * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: wayland: Prefix wl_shell field with `wl_` It will help us to distinguish from other Wayland shells (such as XDG-shell) later on. 2019-02-08 09:21:28 +0300 Denis Nagorny * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: lock ensure_profile() Thread safety patch for ensure_profile() function Fixes #133 2019-02-08 16:35:39 +0100 Víctor Manuel Jáquez Leal * meson.build: meson: bump the minimum wayland version requirement to 1.11.0 This was missed on commit 77bb3424 2019-01-24 21:08:07 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst/vaapi/gstvaapisink.c: vaapisink: x11: trap WM_DELETE_WINDOW message Register the WM_DELETE_WINDOW message from window manager and trap it to stop the pipeline cleanly. Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/130 2019-01-21 19:22:58 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: libs: window: remove native-id property native-id property is problematic since the variable that stores it is gsize, which is platform specific, and in some is bigger than unsigned long, and there are not way to handle gsize properties. Also, GST_VAAPI_ID_INVALID is defined in gsize terms, and we would like to keep using it for this scope. This patch removes the native-id property and set it manually in gst_vaapi_window_new_internal(). 2019-01-18 10:33:37 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: libs: window: use G_GSIZE_MODIFIER for window id gsize type is not equal in all platforms, then the 'l' print modifier shall not be used always. This issue was found in Debian builds. 2019-01-17 10:27:13 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: h264/h265: set SPS cbr_flag with correct value. The flag only set as 1 when the rate-control mode is CBR. === release 1.15.1 === 2019-01-17 02:36:52 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * RELEASE: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.15.1 2019-01-17 02:36:52 +0000 Tim-Philipp Müller * docs/plugins/inspect/plugin-vaapi.xml: Update docs 2019-01-14 19:35:34 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: refactor to avoid code duplication gst_vaapi_encoder_put_frame() and gst_vaapi_encoder_flush() duplicates the same code segment where the coded buffer is created, the picture encoded on it and pushed to the async queue. The function gst_vaapi_encoder_encode_and_queue() refactor this. 2019-01-14 18:21:30 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: h264/h265: flush pending ordered pictures In order to flush the pending pictures, a new internal encoder vmethod is used: get_pending_reordered() This method follows an iterator pattern which will return the next picture to encode and push. The base encoder will call this function in a loop when flush() is called. For now, only H.264 and H.265 encoders implement this flushing mechanism. 2018-12-06 10:18:53 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264/h265: fix encode lose frame issue. Instead of dropping all remain frames in reorder_frame_list during flush, keep encoding. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/97 2019-01-15 14:33:11 +0800 Wangfei * gst/vaapi/gstvaapipostproc.c: vaapipostproc: before set surface proxy, check if it already been created and exist. Fix the deinterlace black frame when playing with glimagesink: gst-launch-1.0 filesrc location=test.264 ! h264parse ! vaapih264dec \ ! vaapipostproc deinterlace-mode=1 deinterlace-method=1 ! glimagesink 2019-01-11 13:48:29 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiutils.c: vaapipostproc: clean up USE_VA_VPP macro since it already removed from configure file. 2018-12-26 14:36:23 +0800 Haihao Xiang * gst-libs/gst/vaapi/meson.build: * gst/vaapi/meson.build: * meson.build: * tests/meson.build: meson: build h264 fei encoder if possible 2018-12-26 14:04:08 +0800 Haihao Xiang * configure.ac: configure: bump the minimum wayland version requirement to 1.11.0 2018-12-24 12:58:53 +0800 Haihao Xiang * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_core.c: * gst-libs/gst/vaapi/meson.build: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/meson.build: * meson.build: * tests/decoder.c: * tests/simple-decoder.c: vaapi: bump the minimum vaapi version requirement to 0.39.0 And reduce unnecessary API version and structures check as well. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/108 2018-12-22 18:07:35 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * tests/test-decode.c: * tests/test-filter.c: * tests/test-subpicture.c: * tests/test-textures.c: * tests/test-windows.c: libs: window: remove custom ref() and unref() Use gst_object_ref() and gst_object_unref() instead. 2018-12-22 13:25:09 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: libs: window: use its own debug category 2018-12-22 18:02:38 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: libs: window: refactor as gobject This is another step in the gobjectification of the internal library of gstreamer-vaapi. Now it is the turn of GstVaapiWindow and its derivates. The idea is to minimize the changeset keeping the same design as much as possible. GstVaapiWindow is defined as an abstract class with two properties: the GstVaapiDisplay and the native ID. Thus, many of the GstVaapiObject macros were copied as GstVaapiWindow macros. The function gst_vaapi_window_new_internal() is kept as a decorator of for calling gst_vaapi_window_create() and the possibility of failure. The descendant classes, such as glx, still use the private structures, but through the gobject mechanism. 2018-12-03 22:05:29 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: libs: filter: use its own debug category 2018-12-24 14:08:42 +0800 He Junyan * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: Add more check for allowed raw caps. The gst_vaapi_plugin_base_get_allowed_raw_caps is used for both sink pad and src pad, which cause some bugs. For sink pad, we need to verify vaPutImage() while for the src pad we need to verify vaGetImage(). For vaapidecoderXXX kind of plugins, the case is more complex. We need to verify whether the decoded result(in some surface, NV12 format most of the time) can be vaGetImage to some raw image format. Add more check to fix all these problems. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/123 Signed-off-by: He Junyan 2018-12-18 10:44:21 +0800 Wangfei * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix csc fail when only change width or height. 2018-12-15 09:47:15 +0900 Wonchul Lee * tests/elements/meson.build: meson: Add gtk guard 2018-12-15 14:48:03 +0800 Wangfei * gst/vaapi/gstvaapiencode_h264.c: libs: enc: h264: set max profile idc with correct profile. Use the highest rank of available profile as the max profile to set max idc value. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/124 2018-12-03 13:56:52 +0100 Niels De Graef * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: Use G_DEFINE_TYPE_WITH_PRIVATE if applicable This gets rid of the strange `do_init` macro and makes the intent a bit more clear. 2018-12-05 17:24:53 -0300 Thibault Saunier * common: Automatic update of common submodule From ed78bee to 59cb678 2018-11-27 09:47:44 -0500 Wangfei * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: libs: dec: h265: support decode for main-444 10bit streams. Add 444 10bit yuv format Y410, which can be used to decode main-444 10bit streams. Currently, this feature is only supported by media-driver in Icelake. 2018-11-28 05:56:44 +0200 Jordan Petridis * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: Run gst-indent through the files This is required before we enabled an indent test in the CI. https://gitlab.freedesktop.org/gstreamer/gstreamer-project/issues/33 2018-11-14 13:11:56 +0800 He Junyan * gst/vaapi/gstvaapipluginbase.c: plugins: modify image check of extract_allowed_surface_formats. The extract_allowed_surface_formats function just check whether we can support some kind of surface/image format pair. We just need to create a surface, create an image with the same video-format and putImage from image to surface. All these operations success, that kind of video-format is supported. The old manner do not work for some kind of video-format. For example, the RGBA kind of format will create a NV12 surface and RGBA image, and the putImage will fail because the format is not same. And so the RGBA format is not supported but actually it is supported. 2018-11-14 11:34:20 +0100 Michael Olbrich * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add some missing locking gst_vaapi_plugin_base_close() removed the raw caps that are used indirectly in gst_vaapipostproc_transform_caps(). The usage is already protected by the mutex. This is needed when the pipeline is stopped during startup. 2018-11-20 16:07:44 +0800 Xiang, Haihao * gst/vaapi/gstvaapivideomemory.c: Close dmabuf_fd Otherwise it will result in resource leak when failed to create dmabuf memory 2018-11-12 13:39:51 +0100 Michael Olbrich * gst/vaapi/gstvaapiencode.c: vaapiencode: don't start src pad task in set_format Otherwise the task may be restarted during shutdown. Start the task in gst_vaapiencode_handle_frame() instead. 2018-11-14 13:52:48 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: libs: dec: h265: support decode for main-444 8bit streams. Add 444 8bit yuv format AYUV, which can be used to decode main-444 8bit streams. Currently, this feature is only supported by media-driver in Icelake. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/119 2018-11-12 17:43:54 +0100 Víctor Manuel Jáquez Leal * .gitlab-ci.yml: Add Gitlab CI configuration This commit adds a .gitlab-ci.yml file, which uses a feature to fetch the config from a centralized repository. The intent is to have all the gstreamer modules use the same configuration. The configuration is currently hosted at the gst-ci repository under the gitlab/ci_template.yml path. Part of https://gitlab.freedesktop.org/gstreamer/gstreamer-project/issues/29 2018-11-09 22:03:43 +0800 He Junyan * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: libs: Sync the GstVaapiChromaType to VA header file. Add more kinds of chrometype which will be used to describe new video formats. Sync it with 1.4.0 version header file. Alse delete useless GST_VAAPI_CHROMA_TYPE_YUV410 chrome type. Signed-off-by: He Junyan 2018-11-09 23:55:05 +0000 Tim-Philipp Müller * gst-libs/gst/vaapi/meson.build: meson: link with -lm Fixes #117 hopefully. 2018-11-09 23:46:53 +0000 Tim-Philipp Müller * meson.build: meson: bump meson required to 0.47 for feature options 2018-11-06 14:38:08 +0800 Junyan He * gst-libs/gst/vaapi/video-format.c: libs: Modify the video format of endianness. We lack some video format because endianness declare. The video format should not directly relate to endianness. For example, ARGB on big endian should not be simplely seen as BGRA on little endian machine. We should provide endianess convert or format convert help functions if endianness does not match. https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/112 Signed-off-by: Junyan He 2018-10-17 18:36:52 +0800 Junyan He * gst/vaapi/gstvaapipluginutil.c: plugins: Fix build error when GL is enabled while EGL is disabled. gl_platform_type in gst_vaapi_get_display_type_from_gl_env generate unused-variable warning and may block build when Werror enabled. Several functions like gst_vaapi_display_egl_new_with_native_display have no prototype warning and link error when GL is enabled but EGL is disabled. Fix all these warning and link error. https://bugzilla.gnome.org/show_bug.cgi?id=797358 Signed-off-by: Junyan He 2018-11-03 15:06:09 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: libs: encoder: h264/h264fei: remove unuseless code. The variable are set twice, remove previous one. https://bugzilla.gnome.org/show_bug.cgi?id=797365 2018-11-03 15:28:35 +0800 Wangfei * tests/simple-encoder.c: * tests/test-fei-enc-in.c: tests: check return value when using gst_buffer_map. https://bugzilla.gnome.org/show_bug.cgi?id=797366 2018-11-02 16:50:47 +0100 Víctor Manuel Jáquez Leal * meson.build: * meson_options.txt: * tests/elements/meson.build: * tests/meson.build: build: meson: build examples 2018-11-02 16:50:00 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/meson.build: build: meson: declare headers for libgstvaapi Thus handling its recompilation if needed. 2018-11-05 05:41:13 +0000 Matthew Waters * .gitmodules: Update common submodule location Remove the git directory 2018-11-05 13:00:28 +0800 Haihao Xiang * .gitmodules: * gstreamer-vaapi.doap: Clone the code from gitlab This fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/116 2018-10-24 14:18:37 -0400 Wangfei * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: libs: dec: h265: support decode for main-10-422 10bit streams. Add 422 10bit yuv format Y210, which can be used to decode main-10-422 10bit streams. Currently, this feature is only supported by media-driver in Icelake. https://bugzilla.gnome.org/show_bug.cgi?id=797264 2018-10-13 15:00:32 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: roi_rc_qp_delta_support should not be checked when CQP. VA_ROI_RC_QP_DELTA_SUPPORT return value will be ignored when the rate control mode is set as CQP. In CQP mode, it shouldn't check roi_rc_qp_delta_support return value from driver backend. https://bugzilla.gnome.org/show_bug.cgi?id=797087 2018-10-15 17:55:24 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix classification string The classification string is splitted by '/' and then looks for the components. This patch removes the ';' by unifying all the components. 2018-10-15 16:05:02 +0100 Philippe Normand * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Add Hardware classifier to metadata 2018-10-12 16:37:34 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: create context first before using it to create surface. In gst_vaapi_context_reset(), if the context has to be destroyed, make sure to create it first before allocating its associated surfaces. This patch fixes a regression introduced in commit 82872f4 because the formats available in the current context now are ensured before creating the context's surfaces. https://bugzilla.gnome.org/show_bug.cgi?id=797277 2018-10-12 15:39:53 +0100 Philippe Normand * docs/plugins/inspect/plugin-vaapi.xml: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp9.c: gst: Advertise elements interacting with hardware devices 2018-10-01 09:26:05 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: libs: context: query surface format before context to create surface. Before using context to create surface, the supported surface format should be checked first. https://bugzilla.gnome.org/show_bug.cgi?id=797222 2018-10-09 17:23:55 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapivalue.c: libs: replace g_error with GST_ERROR And handle those errors rather than halting. 2018-10-09 17:23:30 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: libs: replace g_warning with GST_WARNING 2018-09-26 14:55:32 -0500 Matteo Valdina * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.c: libs: Move from g_debug to GST_DEBUG. https://bugzilla.gnome.org/show_bug.cgi?id=797202 2018-10-04 02:20:10 +0800 Soon, Thean Siew * gst/vaapi/gstvaapipostproc.c: vaapipostproc: change the way of handling deinterlace The current vaapipostproc calls driver's video processing pipeline for deinterlacing only if it is Advance deinterlacing. Modify in the way that it always tries with driver's video processing pipeline for deinterlacing, and falls back to software method of appending picture structure meta data only if it fails with driver's method. https://bugzilla.gnome.org/show_bug.cgi?id=797095 2018-09-24 16:54:29 -0500 Matteo Valdina * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: libs: h264: Update level table to "Recommendation H.264 (04/17)". Added level 6, 6.1 and 6.2. Reference Table A-1 – Level limits from T-REC-H.264-201704. https://bugzilla.gnome.org/show_bug.cgi?id=797202 2018-09-20 09:57:33 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.h: libs: dec: h265: add 422 chroma format support. Add main-422-10 profile which support 422 chroma format stream. Currently, this feature is only supported by media-driver in Icelake. https://bugzilla.gnome.org/show_bug.cgi?id=797143 2018-09-26 19:34:06 +0200 U. Artie Eoff * tests/y4mreader.c: tests: include sysdeps.h in compilation unit Fixes https://bugzilla.gnome.org/show_bug.cgi?id=797204 Signed-off-by: U. Artie Eoff 2018-09-26 18:04:53 +0200 Víctor Manuel Jáquez Leal * tests/y4mreader.c: * tests/y4mreader.h: tests: fix compilation https://bugzilla.gnome.org/show_bug.cgi?id=797204 2018-09-25 20:28:02 +0200 Víctor Manuel Jáquez Leal * tests/y4mreader.h: tests: don's use sysdeps.h in header 2018-09-14 19:30:56 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.h: libs: utils: no need of include config.h 2018-09-13 18:12:02 +0200 Víctor Manuel Jáquez Leal * tests/decoder.c: * tests/output.c: * tests/test-decode.c: * tests/test-subpicture.c: tests: remove already include string.h Since sysdeps.h includes string.h there's no need to include it again. 2018-09-13 18:11:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: libs: remove already include string.h Since sysdeps.h includes string.h there's no need to include it again. 2018-09-13 18:26:27 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst/vaapi/gstvaapivideometa_texture.c: libs: object: separation of internal API and plugins Removed exposed macros GST_VAAPI_OBJECT_DISPLAY() and GST_VAAPI_OBJECT_ID() to plugins, keeping them only for internal library usage. The purpose is readability. https://bugzilla.gnome.org/show_bug.cgi?id=797139 2018-09-13 16:34:54 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiparser_frame.h: libs: parser_frame: change macros for inlined functions https://bugzilla.gnome.org/show_bug.cgi?id=797139 2018-09-13 16:10:13 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: libs: videopool: remove unneeded code The removed code comes frome the bad practice of copy&paste. Better move it as internal function. https://bugzilla.gnome.org/show_bug.cgi?id=797139 2018-09-13 12:22:42 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/meson.build: libs: remove dependency on IN_LIBGSTVAAPI_CORE This conditional code was when libgstvaapi was intended to be library used outside GStreamer. This not the case anymore, thus removing it. https://bugzilla.gnome.org/show_bug.cgi?id=797139 2018-09-19 10:16:36 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiutils_h265.c: libs: dec: h265: fix the macros used for IDC profile profile_idc flag in SPS only indicate the IDC profile, which may need some other flags together to get the real profile. https://bugzilla.gnome.org/show_bug.cgi?id=797160 2018-09-12 19:06:22 +0900 Jimmy Ohn * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: use g_clear_pointer() when possible https://bugzilla.gnome.org/show_bug.cgi?id=797131 2018-09-03 13:56:52 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.h: libs: filter: add gobject's cleanup function 2018-05-22 14:28:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapisurface_egl.c: * tests/test-filter.c: libs: filter: remove custom ref() and unref() Replacing them by gst_object_ref() and gst_object_unref() https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-22 14:26:48 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: libs: filter: refactor filter as gobject https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:38:00 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: libs: decoder: remove destoy() and create() callbacks They were all replaced by reset() https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:26:01 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: decoder: vp9: implement reset() callback remove destroy() and create() callback https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:25:37 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: libs: decoder: vp8: implement reset() callback remove create() and destroy() callbacks https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:24:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: libs: decoder: vc1: implement reset() callback remove destroy() and create() callbacks use g_clear_pointer for rbdu_buffer no cast for enum https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:24:13 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: libs: decoder: mpeg4: implement reset() callback remove destroy() and create() callback https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:22:45 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: libs: decoder: mpeg2: implement reset() callback remove create() and destroy() callbacks https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:22:07 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: libs: decoder: jpeg: implement reset() callback and remove create() and destroy() callbacks. https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:13:31 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: implement reset() callback and remove create() and destroy() and use g_clear_pointer for dpb structure https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 13:11:41 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: remove create() and destroy() callbacks https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 11:56:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * tests/test-decode.c: * tests/test-subpicture.c: libs: decoder: remove gst_vaapi_decoder_unref() Replaced by gst_object_unref() in tests https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 11:51:14 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: libs: decoder: remove gst_vaapi_decoder_ref() https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-21 11:50:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: libs: decoder: remove gst_vaapi_decoder_new() https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-05-18 16:09:31 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.h: libs: decoder: refactor decoders as gobject https://bugzilla.gnome.org/show_bug.cgi?id=796308 2018-08-31 20:56:13 -0500 Matteo Valdina * gst/vaapi/gstvaapidecode.c: vaapidecode: Requests upstream a key unit at parse or decode error. This is done to resume decoding after a parse error or decode error. Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=797006 2018-08-31 20:48:13 -0500 Matteo Valdina * gst/vaapi/gstvaapidecode.c: vaapidecode: sets return value in failure case. In gst_vaapidecode_handle_frame, when there is a decode error there is a code path the returns an uninitialized value. Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=797006 2018-08-30 18:56:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: lock at extracting available image formates When running several vaapi elements at the concurrently, at initialization, there is a race condition when extractin the avaible formats for images and subpictures. This patch add a lock when the those arrays are filled. https://bugzilla.gnome.org/show_bug.cgi?id=797039 2018-08-31 14:47:55 +0530 Nirbheek Chauhan * meson.build: meson: Sync libversion and osxversion code from other repos gstreamer-vaapi does not build any libraries, only plugins, so this is not used, but sync it just in case someone does add it in the future. 2018-08-29 13:44:44 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h265: trivial documentation fix 2018-08-30 11:08:07 +0800 Wangfei * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h265: add low delay B frame support. Low delay B frame provide the function of transforming P frame into low delay B frame which frame type is B, but only reference predictive frames. This can be used when P frame unsupported. Especially for P and B both unsupported, in this case, I and low delay B frame can be encoded in a stream. https://bugzilla.gnome.org/show_bug.cgi?id=796984 2018-08-27 20:42:15 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: Avoid using picture after it has been free In some cases, the found_picture ended up being evicted and freed, which would lead to a use after free when accessing picture->base.poc. In this fix, we take a ref on the picture before calling dpb_evict. https://bugzilla.gnome.org/show_bug.cgi?id=787124 2018-07-25 17:03:19 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264decoder: Fail decoding slice with missing inter-view reference Similarly to previous patch, we have no error concealment. As a side effect, it's better to skip slices with missing references then passing NULL pointers to the accelerator. Passing NULL pointer would lead to major visual artifact, a behaviour that is likely undefined. https://bugzilla.gnome.org/show_bug.cgi?id=787124 2017-09-14 14:25:41 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: reset context when the number of view is increased Usually in case of MVC decoding, dpb size is increasedi if subset sps. That's why it resets context without this patch. But for some media it doesn't increase dpb size. Even in this case we should reset context to deal with MVC decoding. Otherwise, it leads to assert. https://bugzilla.gnome.org/show_bug.cgi?id=787124 2018-07-25 13:50:23 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst/vaapi/gstvaapidecode.c: vaapidecode: Skip unparsable units from adapter If the unit could not be parsed, just skip this nal and keep parsing what is left in the adapter. We need to flush the broken unit in the decoder specific parser because the generic code does not know about units boundary. This increases error resilliance. Before this, the broken unit would stay in the adapter and EOS would be returned. Which stopped the streaming. Just removing the EOS would have lead to the adapter size growing indefinitely. https://bugzilla.gnome.org/show_bug.cgi?id=796863 2018-07-24 12:40:00 -0400 Nicolas Dufresne * gst/vaapi/gstvaapidecode.c: vaapidecoder: Don't error out on decode errors This is problematic on live pipeline where loosing network can cause an important amount of errors. https://bugzilla.gnome.org/show_bug.cgi?id=796832 2018-07-25 15:47:49 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: h265decoder: Don't scan empty buffer Same as what we did for H264 decoder, this is to avoid an assertion in the adapter. https://bugzilla.gnome.org/show_bug.cgi?id=796832 2018-07-25 20:21:51 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: h264: renable the vaapi category for logging h264 log messages were logged in default category because a regression in code. This patch renable the usage of vaapi logging category. This regression was introduced in commit 7c365bdd. 2018-07-18 13:09:42 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264decoder: Fail decoding slice if modification process failed This patch chains up failure to executing the modification process. The end result is that we now fail decoding the slice if this process fails. This avoid sending a corrupted state to the accelerator. In some special cases, this could lead to unrecoverable errors. https://bugzilla.gnome.org/show_bug.cgi?id=796832 2018-07-18 13:07:51 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264decoder: Don't scan empty buffer gst_adapter_masked_scan_uint32_peek() asserts if size is 0. Don't try and scan in that case. This fixes assertion that would some times happen when the stream is corrupted. https://bugzilla.gnome.org/show_bug.cgi?id=796832 2018-07-04 12:51:10 +0800 Tianhao Liu * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: libs: encoder: jpeg: set component id and Tqi This change is due a problem encoding JPEGs with Intel's media-driver: green/black image when playback jpeg This patch sets component identifier and quantization table destination selector in frame header to support packing headers by Intel's media-driver that does not accept packed header in AP level. https://bugzilla.gnome.org/show_bug.cgi?id=796705 2018-06-25 14:20:32 +0200 Mathieu Duponchelle * gst/vaapi/gstvaapipluginutil.c: pluginutil: downgrade unsupported driver logging On systems with an Nvidia card, this error is output each time the registry is rebuilt, which happens pretty often when using gst-build as a development environment. https://bugzilla.gnome.org/show_bug.cgi?id=796663 2018-06-24 13:07:20 +0200 Tim-Philipp Müller * gst/vaapi/gstvaapivideobufferpool.c: Update for g_type_class_add_private() deprecation in recent GLib 2018-05-30 16:01:36 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264dec: Remove false assumption about parity order The decoder was trying to detect earlier that a field was lost base on guessing the parity order. This breaks in streams were the parity order changes. This patch reverts the field order prediction code added by commit 8dd93e9c8. https://bugzilla.gnome.org/show_bug.cgi?id=796169 2018-05-18 17:03:57 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264dec: Properly set sentinel in ref frame list This ensure that we always have sentinels set in the reference pictures arrays. The code wasn't unsafe, this simply improve the tracing, so instead of printing 32 lines of zeros, va tracer prints proper empty lists. https://bugzilla.gnome.org/show_bug.cgi?id=796169 2018-06-13 18:00:18 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideometa.c: * tests/test-decode.c: libs: display: remove gst_vaapi_display_ref() Replace it with gst_object_ref() https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-13 17:54:23 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * tests/output.c: * tests/simple-encoder.c: * tests/test-decode.c: * tests/test-display.c: * tests/test-fei-enc-in.c: * tests/test-filter.c: * tests/test-subpicture.c: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-windows.c: libs: display: remove gst_vaapi_display_unref() Use gst_object_unref() instead. https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-13 18:10:28 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapibufferpool: declare parameter display as object We have neglected to update this code since GstVaapiDisplay turned into a GstObject descendant. https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-01 12:36:51 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: libs: display: replace gst_vaapi_display_new() with gst_vaapi_display_config() Gobjectification for GstVaapiDisplay was almost done by the commit 185da3d1. But still something breaking GObject code convention remains, which is calling gst_vaapi_display_new() in each decendants. This patch replaces it with gst_vaapi_display_config(), defined in private header. https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-13 17:05:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: redefine gst_vaapi_display_create() The function name was gst_vaapi_display_create_unlocked(), nonetheless it wasn't called unlocked. In order to keep the semantics this patch renames the gst_vaapi_display_create_unlocked() as gst_vaapi_display_create(), removing the previous function gst_vaapi_display_create(). https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-12 15:53:04 +0200 Víctor Manuel Jáquez Leal * meson.build: Revert "build: meson: libva gst-uninstall friendly" This reverts commit fc3eef9c432c1628cb92ab56e74924cf1182da30. 2018-06-12 15:13:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: fix compilation gstvaapipluginutil.c:171:1: error: old-style function definition [-Werror=old-style-definition] 2018-04-20 18:05:30 +0200 Víctor Manuel Jáquez Leal * meson.build: build: meson: libva gst-uninstall friendly Make gstreamer-vaapi to use libva uninstalled. 2018-06-10 10:44:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: refactor gst_vaapi_create_display_from_gl_context() gst_vaapi_create_display_from_gl_context() was a spaghetti mess. This path refactors it, in order to make the code readable and easy to follow. https://bugzilla.gnome.org/show_bug.cgi?id=796564 2018-05-25 12:17:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: libs: display: resurrect parent private member This is, practically, a revert of commit dcf135e2. The parent logic is useful for the EGL display, which is a decorator of the real windowing subsystem (X11 or Wayland). Thus it is avoided calling vaInitialize() and vaTerminate() twice. https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-27 18:35:30 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: display: egl: initialize params structure Statically initialise the internal params structure. https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-27 18:34:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: handle EGL when creating VAAPI display from gl If GstGL reports a EGL platform force to create a EGL display using the native EGL display. https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-24 18:17:24 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst/vaapi/gstvaapipluginutil.c: display: egl: create VaapiDisplayEGL with native EGL display gst_vaapi_display_egl_new_with_native_display() has been broken since it wasn't used. Currently it's needed to call this API to create a display providing the EGL display, so it could avoid duplicated calls to the native display (eg. eglTerminate). Signed-off-by: Victor Jaquez https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-06-07 09:34:11 +0800 Tianhao Liu * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: libs: decoder: release VA buffers after vaEndPicture This change is due a problem decoding JPEGs with Intel's media-driver: no image was generated. This patch relases the VA buffers after vaEndPicture() is called, and not before (after vaRenderPicture()). https://bugzilla.gnome.org/show_bug.cgi?id=796505 2018-06-07 19:49:02 +0100 Tim-Philipp Müller * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: meson: fix build when xrender or xrandr are not available HAVE_XRENDER are defined to 1 or 0, not defined or undefined. 2018-05-25 16:47:00 +0200 Michael Olbrich * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't copy the GstParentBufferMeta if use_vpp Otherwise a reference to a DMABuf input buffer is kept until the output buffer is deleted. https://bugzilla.gnome.org/show_bug.cgi?id=796399 2018-05-22 21:13:08 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: libs: display: remove unnecessary legacy code since gobjectification https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-05-22 21:05:54 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: libs: display: remove unused code https://bugzilla.gnome.org/show_bug.cgi?id=796470 2018-06-05 15:16:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: log output caps 2018-06-05 22:38:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: find profile in available and allowed caps The commit 67e33d3de225d0e006d7bf606e7abb20d4544eab ("vaapiencode: h264: find best profile in those available") changed the code to pick a profile that is actually supported by the hardware. Unfortunately it dropped the downstream constraints. This can cause negotiation failures under certain circumstances. The fix is split in two cases: 1\ the available VA-API caps doesn't intersect with pipeline's allowed caps: * The best allowed profile (pipeline's caps) is set as the encoding target profile (it will be adjusted later by the available profiles and properties) 2\ the available VA-API caps does intersect with pipeline's allowed caps: * The intersected caps are fixed, and its profile is set as the encoding target profile. In this case the is not the best profile, but the minimal one (if VA-API reports the profiles in order). Setting the minimal profile of the intersected caps is better for compatibility. This patch fixes other tests related with caps negotiation, for example, it handles baseline profile, even when VA only supports constrained-baseline. Original-patch-by: Michael Olbrich https://bugzilla.gnome.org/show_bug.cgi?id=794306 2018-06-01 15:27:25 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: increase log2_max_pic_order_cnt range according to spec The specification says, "log2_max_pic_order_cnt_lsb_minus4 shall be in the range of 0 to 12, inclusive." This patch changes the upper limit from 6 to 12. https://bugzilla.gnome.org/show_bug.cgi?id=796179 2018-05-21 13:27:14 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: guard GstGL code 2018-05-18 18:23:18 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: use g_clear_pointer() 2018-05-18 17:27:46 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: libs: decoder: mpeg4, vc1: remove unused header 2018-05-18 11:09:58 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: libs: decoder: remove unused forward declaration 2018-05-07 07:59:25 -0700 U. Artie Eoff * configure.ac: fix configure.ac regression Fixes regression introduced by 77527d67abe https://bugzilla.gnome.org/show_bug.cgi?id=795885 2018-05-05 17:57:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/Makefile.am: * gst-libs/gst/base/Makefile.am: * gst-libs/gst/base/gstbitwriter.c: * gst-libs/gst/base/gstbitwriter.h: * gst-libs/gst/base/meson.build: * gst-libs/gst/meson.build: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: * gst-libs/gst/vaapi/meson.build: libs: remove gstbitwriter Since it is deployed in gstreamer-core, there is no need to use our custom version. https://bugzilla.gnome.org/show_bug.cgi?id=795848 2018-04-28 16:10:46 +0800 Wang,Fei * gst/vaapi/gstvaapidecode.c: vaapih264dec: add constrained and progressive profiles Those profiles have been added in the version 2012-01 and 2011-06 of the AVC spec (A.2.4.1 and A.2.4.2). Both are supported by VAProfileH264High https://bugzilla.gnome.org/show_bug.cgi?id=795624 2018-04-26 18:15:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: plugin: remove custom GstGL context handling Instead of using our own context handling for looking for GstGL parameters (display, context and other context), this patch changes the logic to use the utility function offered by GstGL. https://bugzilla.gnome.org/show_bug.cgi?id=793643 2018-04-26 15:03:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: GstGL API must use the member variables This commit basically is a revert of commits 8092537 and fc1c415 https://bugzilla.gnome.org/show_bug.cgi?id=793643 2018-04-25 16:24:32 +0900 Hyunjun Ko * gst/vaapi/gstvaapipluginbase.c: plugins: pass members as parameters of gst_gl_ensure_element_data() The parameters of gst_gl_ensure_element_data() have to be not local variable since they are going to be used to see if they're set in gst_element_set_context() inside the API. This is basically a revert of commit 3d56306c https://bugzilla.gnome.org/show_bug.cgi?id=793643 2018-04-25 17:50:14 +0200 Víctor Manuel Jáquez Leal * meson.build: meson: fix USE_GLES_VERSION_MASK 1. The macro in the code is USE_GLES_VERSION_MASK 2. glesv3 is provided by glesv2 pkg-config, then it's required to check headers https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-24 18:12:44 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiutils_egl.c: libs: egl: utils: mark context as wrapped when it is The returning egl context may be null, so we should check the return value. https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-24 10:02:33 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_egl.c: libs: egl: utils: fix usage of GstGL macros Include gl.h for the required GstGL symbols. https://bugzilla.gnome.org/show_bug.cgi?id=795391 2018-04-25 11:01:45 +0100 Tim-Philipp Müller * meson.build: meson: use -Wl,-Bsymbolic-functions where supported Just like the autotools build. 2018-04-20 16:01:29 +0200 Víctor Manuel Jáquez Leal * meson.build: meson: use get_pkgconfig_variable() Use get_pkgconfig_variable() method, of dependency class, rather than using run_command(). 2018-04-20 11:50:55 +0100 Tim-Philipp Müller * gst-libs/gst/base/meson.build: * gst-libs/gst/vaapi/meson.build: * meson.build: meson: fix miscellaneous meson warnings WARNING: Passed invalid keyword argument "rqeuired". gst-libs/gst/base/meson.build:11: WARNING: Passed invalid keyword argument "version". gst-libs/gst/base/meson.build:11: WARNING: Passed invalid keyword argument "soversion". gst-libs/gst/vaapi/meson.build:223: WARNING: Passed invalid keyword argument "version". gst-libs/gst/vaapi/meson.build:223: WARNING: Passed invalid keyword argument "soversion". 2018-03-30 13:41:39 +0200 Paul Kocialkowski * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: display: drm: Allow finding DRM paths out of the PCI subsystem This removes hard-coded checks on the parent subsystem of potential DRM devices. These checks were set to exlude devices that do not originate from the PCI bus, which is only a valid approach on x86 devices. Other devices may have a DRM device originating from the platform subsystem, so the checks that were previously restricted to PCI are extended to cover platform devices as well. https://bugzilla.gnome.org/show_bug.cgi?id=794840 Signed-off-by: Paul Kocialkowski 2017-11-08 13:27:06 +0900 Hyunjun Ko * gst/vaapi/gstvaapivideocontext.c: videocontext: support wl-display in "gst.vaapi.app.Display" Through "gst.vaapi.app.Display" context, users can set their own VADisplay and native display of their backend. So far we support only X11 display, from now we also support Wayland display. Attributes: - wl-display : pointer of struct wl_display . https://bugzilla.gnome.org/show_bug.cgi?id=705821 2017-11-08 13:26:38 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: libs: display: wayland: add gst_vaapi_display_wayland_new_with_va_display() Implements new API function so that users could create GstVaapiDisplay with their own VADisplay within a native display as backend. https://bugzilla.gnome.org/show_bug.cgi?id=705821 2018-04-13 09:28:53 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: don't poll if there are no pending frames Otherwise the following poll may not return for an arbitrary amount of time. This can happen if another wayland event queue has flushed and read our events. https://bugzilla.gnome.org/show_bug.cgi?id=795224 2017-10-16 12:09:08 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: 16 bit rounding of picture width and height pic_width_in_luma_samples/pic_height_in_luma_samples can be 16-bit rounded instead of 32-bit. In addition, codedbuf_size must be calculated according to this change. https://bugzilla.gnome.org/show_bug.cgi?id=753229 2018-04-16 10:53:47 +0100 Tim-Philipp Müller * common: Automatic update of common submodule From 3fa2c9e to ed78bee 2018-03-30 20:39:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: find best profile in those available Instead to look for the best profile in the allowed profiles by downstream, the encoder should look for the base profile in the available profile in VA-API. https://bugzilla.gnome.org/show_bug.cgi?id=794306 2018-03-20 10:49:10 +0000 Tim-Philipp Müller * NEWS: * RELEASE: * configure.ac: * docs/plugins/inspect/plugin-vaapi.xml: * meson.build: Back to development === release 1.14.0 === 2018-03-19 20:30:28 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.14.0 2018-03-12 16:59:01 +0000 Julien Isorce * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: ensure num_ref_frames is greater than 0 Even if it is the h264parse fault or bad video file, vaapih264dec should set a proper value for VAPictureParameterBufferH264.num_ref_frames as the driver might use it. Also see "info.ref_frames = dpb_size;" in gstvaapidecoder_h264.c::ensure_context https://bugzilla.gnome.org/show_bug.cgi?id=793836 === release 1.13.91 === 2018-03-13 19:32:05 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.13.91 === release 1.13.90 === 2018-03-03 22:59:30 +0000 Tim-Philipp Müller * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.13.90 2018-03-01 07:33:27 -0600 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: change how the metadata is copied Instead of copying the metada in prepare_output_buffer() vmethod, it is done in append_output_buffer_metadata() thus deinterlaced buffers could also have the proper metas. GstVideoCropMeta now it is copied internally and it is decided via transform_meta() vmethod. A new internal method, copy_metadata() was added to handle VPP transformation where non-GstVideoVaapiMeta metas were lost. 2018-02-27 16:20:15 -0500 Nicolas Dufresne * gst/vaapi/gstvaapipostproc.c: postproc: Copy meta data from input to output This will ensure that meta data without memory tags will be copied. This was noticed when testing ROI. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-23 10:48:36 -0600 Víctor Manuel Jáquez Leal * tests/elements/test-roi.c: tests: element: rewrite ROI test Rewrote the ROI test to use GstVideoRegionOfInterest meta rather than injecting GstEvents. These meta are added as a pad probe in the queue src pad. Also * Use of navigation messages to control de test * Use signal watch for processing messages * Change to H265 rather than H264 since current intel-vaapi-driver only supports ROI on kabylake. TODO: add a parameter to change the encoder/decoder to test. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-22 14:20:42 -0600 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: reimplement ROI using meta Check input buffers for ROI metas and pass them to VA. Also added a new "default-roi-delta-qp" property in order to tell the encoder what delta QP should be applied to ROI by default. Enabled it for H264 and H265 encoders. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-22 08:22:35 -0600 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: Revert "libs: encoder: add api gst_vaapi_encoder_add/del_roi" This reverts commit 7a6f690340dcb3b82c59efa777d4453227851de8. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-22 14:29:19 -0600 Víctor Manuel Jáquez Leal * tests/simple-encoder.c: Revert "tests: simple-encoder: add an option to set ROI" This reverts commit c21345c4787bb6342adddea1190f53fe62abff04. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-21 10:56:47 -0600 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: Revert "vaapiencode: handle custom event GstVaapiEncoderRegionOfInterest" This reverts commit 8f1b88dac0e64a211325cdcb2cda693b80229bd1. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-23 09:25:51 -0600 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: copy input buffer metas When importing buffers to a VA-base buffer, it is required to copy the metas in the original buffer, otherwise information will be lost, such as GstVideoRegionOfInterestMeta. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2018-02-27 06:10:09 -0600 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: cast to uintptr_t pointer According to Debian package auto-building, uintptr_t is not an unsigned long in i386 arch, raising an "incompatible pointer type" error. This patch adds a casting for compiler's satisfaction in i386. 2018-02-25 20:46:56 -0600 Matteo Valdina * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: add zero as valid value for periodic keyframe. Enabled zero as valid value for keyframe-period property. https://bugzilla.gnome.org/show_bug.cgi?id=793829 2018-02-22 08:24:12 -0600 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: code-style fix 2018-02-17 18:32:11 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: generate system allocated buffers Generate system allocated output buffers when downstream doesn't support GstVideoMeta. The VA buffer content is copied to the new output buffer, and it replaces the VA buffer. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-15 19:32:37 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: handle system allocated buffers when required When downstream can't handle GstVideoMeta it is required to send system allocated buffers. The system allocated buffers are produced in prepare_output_buffer() vmethod if downstream can't handl GstVideoMeta. At transform() vmethod if the buffer is a system allocated buffer, a VA buffer is instanciated and replaces the out buffer. Later the VA buffer is copied to the system allocate buffer and it replaces the output buffer. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-15 19:32:19 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: add gst_vaapi_copy_va_buffer() This helper function aims to copy buffers with VA memory to dumb buffers, when GstVideoMeta is not available dowstream. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-15 19:29:51 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: add COPY_OUTPUT_FRAME flag This patch add the member copy_output_frame and set it TRUE when when downstream didn't request GstVideoMeta API, the caps are raw and the internal allocator is the VA-API one. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-15 19:28:33 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: store the first downstream allocator if available The allocator will be required if we need to allocate a buffer to store the frame with the expected strides. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-20 02:25:13 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: vaapibufferpool: add gst_vaapi_video_buffer_pool_copy_buffer() This function will inform the element if it shall copy the generated buffer by the pool to a system allocated buffer before pushing it to downstream. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-15 19:22:08 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapibufferpool: don't change config when forcing video meta VA-API based buffer might need a video meta because of different strides. But when donwstream doesn't support video meta we need to force the usage of video meta. Before we changed the buffer pool configuration, but actually this is a hack and we cannot rely on that for downstream. This patch add a check fo raw video caps and allocator is VA-API, then the option is enabled without changing the pool configuration. In this case the element is responsible to copy the frame to a simple buffer with the expected strides. https://bugzilla.gnome.org/show_bug.cgi?id=785054 2018-02-20 09:15:05 -0600 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: set discont flag at vpp deinterlacing When deinterlacing with VPP the discont flag was not forwarded to the new created buffer. This patch sets the discont flag if input buffer has it. 2018-02-20 02:14:37 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.h: vaapibufferpool: remove wrong gcc annotation 2018-02-15 14:55:42 -0600 Matteo Valdina * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h26x_priv.h: libs: encoder: h264,h265: extend max periodic keyframe. Increased max values of periodic key frame for h26x codecs. This allow more fine tunning of encoder that in certian scenario want higher periodic key frame. For example: it doesn't want a key frame each 10 seconds but each 120 seconds. https://bugzilla.gnome.org/show_bug.cgi?id=786320 2018-02-15 19:44:35 +0000 Tim-Philipp Müller * configure.ac: * meson.build: Back to development === release 1.13.1 === 2018-02-15 17:39:16 +0000 Tim-Philipp Müller * Makefile.am: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.13.1 2018-02-15 18:15:33 +0000 Tim-Philipp Müller * gst/vaapi/Makefile.am: vaapi: dist new header 2018-02-12 17:53:58 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: register vaapisink as marginal on wayland vaapsink, when used with the Intel VA-API driver, tries to display surfaces with format NV12, which are handled correctly by Weston. Nonetheless, COGL cannot display YUV surfaces, making fail pipelines on mutter. This shall be solved either by COGL or by making the driver to paint RGB surfaces. In the meanwhile, let's just demote vaapisink as marginal when the Wayland environment is detected, no matter if it is Weston. https://bugzilla.gnome.org/show_bug.cgi?id=775698 2018-02-12 19:00:36 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: update mesa's vendor string in whitelist Mesa has updated its VA-API Gallium driver vendor string: https://cgit.freedesktop.org/mesa/mesa/commit/?id=5db29d62ce1fefa3f2ee6e4a4688576fde4bde4a This patch tries to cover both, the old and the new one. https://bugzilla.gnome.org/show_bug.cgi?id=793386 2018-02-08 19:22:17 +0000 Tim-Philipp Müller * meson.build: meson: make version numbers ints and fix int/string comparison WARNING: Trying to compare values of different types (str, int). The result of this is undefined and will become a hard error in a future Meson release. 2018-02-07 09:13:26 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: handle vaapi allocator in allocation query In propose_allocation() if the numer of allocation params is zero, the system's allocator is added first, and lastly the native VA-API allocator. In decide_allocation(), the allocations params in query are travered, looking for a native VA-API allocator. If it is found, it is reused as src pad allocator. Otherwise, a new allocator is instantiated and appended in the query. https://bugzilla.gnome.org/show_bug.cgi?id=789476 2018-02-07 09:06:46 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: remove unused macro GST_VAAPI_VIDEO_ALLOCATOR_NAME was added in commit 5b11b8332 but it was never used, since the native VA-API allocator name has been GST_VAAPI_VIDEO_MEMORY_NAME. This patch removes GST_VAAPI_VIDEO_ALLOCATOR_NAME macro. https://bugzilla.gnome.org/show_bug.cgi?id=789476 2018-02-02 08:54:00 +0000 VaL Doroshchuk * gst/vaapi/gstvaapisink.c: vaapisink: don't mask button events for foreign windows Don't subscribe to button press events when using a foreing window, because the user created window would trap those events, preveting the show of frames. https://bugzilla.gnome.org/show_bug.cgi?id=791615 2018-02-05 08:51:56 +0100 Tim-Philipp Müller * configure.ac: autotools: use -fno-strict-aliasing where supported https://bugzilla.gnome.org/show_bug.cgi?id=769183 2018-01-30 20:38:37 +0000 Tim-Philipp Müller * meson.build: meson: use -fno-strict-aliasing where supported https://bugzilla.gnome.org/show_bug.cgi?id=769183 2018-01-30 12:56:49 +0000 Philippe Normand * gst/vaapi/gstvaapi.c: vaapi: add NULL-sentinel to kernel_names The array needs to be NULL-terminated according to the gst_plugin_add_dependency() documentation. 2018-01-18 18:53:29 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: remove spurious code This assignation is dead code, since gst_video_info_from_caps() set to 1 by default. https://bugzilla.gnome.org/show_bug.cgi?id=790149 2018-01-18 18:51:57 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: if no p-a-r in out caps define a range Instead of copying the pixel-aspect-ratio from the sink caps, define an open range for the src caps pixel-aspect-ratio. Later it will be defined. https://bugzilla.gnome.org/show_bug.cgi?id=790149 2018-01-18 13:10:59 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: check for display's color-balance properties Check for display's color-balance properties, available by the VA-API driver, before setting them. Also logs an info message of those unavailable properties. https://bugzilla.gnome.org/show_bug.cgi?id=792638 2018-01-17 17:30:50 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: re-using buffer pool breaks renegotiation at propose_allocation() we should not reuse the proposed buffer, because it could break renegotiation. https://bugzilla.gnome.org/show_bug.cgi?id=792620 2018-01-17 17:26:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: use g_clear_object() to unref sinkpad_buffer_pool https://bugzilla.gnome.org/show_bug.cgi?id=792620 2018-01-17 12:42:12 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/meson.build: build: meson: add missing GstGL dependency 2018-01-17 12:41:54 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_egl.c: libs: utils: egl: add missing guards for GstGL 2018-01-11 11:48:02 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove dmabuf-import hack Remove the hack to check if an upstream element has enabled the property io-mode enabled as dmabuf-import. https://bugzilla.gnome.org/show_bug.cgi?id=792034 2017-12-01 15:04:35 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: libs: egl: utils: use eglGetPlatformDisplay() eglGetDisplay() is currently broken in Mesa for Wayland. Also using eglGetDisplay() is rather fragile, and it is recommended to use eglGetPlatformDisplay() when possible. In order to do that, this patch uses the helper in GstGL. If gstreamer-vaapi is not compiled with GstGL support, eglGetDisplay() will be used. https://bugzilla.gnome.org/show_bug.cgi?id=790493 2017-12-08 14:46:02 +0100 Michael Tretter * gst/vaapi/gstvaapipostproc.c: vaapipostproc: lock ensure_filter with postproc_lock gst_vaapipostproc_ensure_filter might free the allowed_srcpad_caps and allowed_sinkpad_caps. This can race with copying these caps in gst_vaapipostproc_transform_caps and lead to segfaults. The gst_vaapipostproc_transform_caps function already locks postproc_lock before copying the caps. Make sure that calls to gst_vaapipostproc_ensure_filter also acquire this lock. https://bugzilla.gnome.org/show_bug.cgi?id=791404 2018-01-10 17:10:28 +0100 Víctor Manuel Jáquez Leal * tests/test-filter.c: tests: test-filter: fix dereference before null check Null-checking op_info suggests that it may be null, but it has already been dereferenced on all paths leading to the check. There may be a null pointer dereference, or else the comparison against null is unnecessary. 2018-01-10 17:06:53 +0100 Víctor Manuel Jáquez Leal * tests/y4mreader.c: tests: y4mreader: fix string state checkup str cannot be null in that moment, but it may be the end of string. 2018-01-10 16:59:56 +0100 Víctor Manuel Jáquez Leal * tests/y4mreader.c: tests: y4mreader: use int for fgetc Assigning the return value of fgetc to char truncates its value. It will not be possible to distinguish between EOF and a valid character. 2018-01-10 16:48:07 +0100 Víctor Manuel Jáquez Leal * tests/y4mreader.c: tests: y4mreader: fix incompatible cast Passed pointer in parse_int() are unsigned int (32 bits, unsigned) but they are dereferenced as a wider long (64 bits, signed). This may lead to memory corruption. 2017-12-19 16:01:10 +0000 Tim-Philipp Müller * meson.build: meson: fix fallback for gstreamer-gl-1.0, it's now in -base 2017-12-14 14:53:27 +1100 Matthew Waters * common: Automatic update of common submodule From e8c7a71 to 3fa2c9e 2017-12-06 16:11:46 -0500 Nicolas Dufresne * gst/vaapi/gstvaapivideocontext.c: videoconvert: gst_element_post_message() is transfer full on msg For this reson we need not to unref the message, even if it failed. 2017-12-06 16:11:25 -0500 Nicolas Dufresne * gst/vaapi/gstvaapivideocontext.c: Revert "vaapivideocontext: possible memleak when no bus attached" This reverts commit 0438a3e62660e64ed390b6bb83bfb560b91664aa. 2017-12-01 23:03:32 +0100 Víctor Manuel Jáquez Leal * tests/elements/test-vaapicontext.c: test: vaapicontext: process have-context bus message 2017-11-29 18:29:45 +0100 Víctor Manuel Jáquez Leal * tests/elements/test-vaapicontext.c: test: vaapicontext: app context is not persistent 2017-11-29 11:02:03 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: vaapivideocontext: only vaapisink process app context gst.vaapi.app.Display context is made for applications that will provide the VA display and the native display to used by the pipeline, when are using vaapisink as overlay. There are no use case for encoders, decoders, neither for the postprocessor. In the case of the vaapisink, it shall query for gst.vaapi.Display upstream first, and then, if there is no reply, gst.vaapi.app.Display context will be posted in the bus for the application. If the application replies, a GstVaapiDisplay object is instantiated given the context info, otherwise a GstVaapiDisplay is created with the normal algorithm to guess the graphics platform. Either way, the instantiated GstVaapiDisplay is propagated among the pipeline and the have-message bus message. Also only vaapisink will process the gst.vaapi.app.Display, if and only if, it doesn't have a display already set. This is caused because if vaapisink is in a bin (playsink, for example) the need-context is posted twice, leading to an error state. https://bugzilla.gnome.org/show_bug.cgi?id=790999 2017-12-01 20:21:54 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: log the name of GstVaapiDisplay https://bugzilla.gnome.org/show_bug.cgi?id=790999 2017-11-30 14:24:43 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: possible memleak when no bus attached https://bugzilla.gnome.org/show_bug.cgi?id=790999 2017-11-27 13:04:24 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: libs: window: wayland: remove unused header include Remove wayland-client.h include since there is no exposed symbols from it. 2017-11-27 12:18:56 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264,h265: guard rate control's macroblock macroblock parameter appear on VA-API 1.0.0. It should be guarded. 2017-11-27 20:17:55 +1100 Matthew Waters * common: Automatic update of common submodule From 3f4aa96 to e8c7a71 2016-07-29 14:58:49 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: Add Hierarchical-B encode Frames are encoded as different layers. Frame in a particular layer will use pictures in lower or same layer as references. Which means decoder can drop the frames in upper layer but still decode lower layer frames. B-frames, except the one in top most layer, are reference frames. All the base layer frames are I or P. eg: with 3 temporal layers T3: B1 B3 B5 B7 T2: B2 B6 T1: I0 P4 P8 T1, T2, T3: Temporal Layers P1...Pn: P-Frames: B1...Bn: B-frames: T1: I0->P4 , P4->P8 etc.. T2: I0--> B2 <-- P4 T3: I0--> B1 <-- B2, B2 --> B3 <-- P4 Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-28 18:33:23 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: Add Hierarchical-P encode Frames are encoded as different layers. A frame in a particular layer will use pictures in lower or same layer as references. Which means decoder can drop the frames in upper layer but still decode lower layer frames. eg: with 3 temporal layers T3: P1 P3 P5 P7 T2: P2 P6 T1: P0 P4 P8 T1, T2, T3: Temporal Layers P1...pn: P-Frames: P0->P1 , P0->P2, P2->P3, P0->P4......repeat Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-28 16:51:28 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: Fix frame_num generation The frame_num generation was not correctly implemented. According to h264 spec, frame_num should get incremented for each frame if previous frame is a referece frame. For eg: IPBPB sequece should have the frame numbers 0,1,2,2,3 Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-28 15:53:48 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: Add new property "prediction-type" Adds new property "prediction-type" to select different reference picture selection modes like hierarchical-p, hierarchical-b etc. Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-28 15:12:05 +0300 XuGuangxin * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: libs: encoder: h264: Add machinery for implementing hierarchical-prediction Adds some basic building blocks to ease the implementation of hierarchical prediction modes. -- add an utility method to find temporal level of each frame -- define max_ref_frame count based on temporal level count -- add temporal_level_div[] for finding temporal level each frame to be encoded. -- find ip_period based on temporal level count Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-28 14:17:53 +0300 XuGuangxin * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: Add property "temporal-levels" Adds new property "temporal-levels" to select the number of temporal levels to be included in the encoded stream. Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2016-07-27 16:41:01 +0300 XuGuangxin * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: libs: encoder: objects: Add a reference flag We can have p-frame as non-ref and also b-frame as ref which are not supported yet. Reference flag is the first machinery needed for more advanced reference picture selection modes. Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=788918 2017-11-02 13:21:34 +0100 Daniel van Vugt * gst-libs/gst/vaapi/gstvaapisurface_egl.c: libs: surface: egl: add comment Add a warning comment when using old intel-vaapi-drivers (>1.8.4), where the creation of surfaces from GEM fd may fail. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 13:38:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.h: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: libs: display: egl: add gst_vaapi_display_egl_set_current_display() Adds a new function that changes the internal EGL display to the current one (eglGetCurrentDisplay()) and sets the current context too (eglGetCurrentContext()). This new function is called by gst_vaapi_texture_egl_create() updating the GstVaapiDisplayEGL with the current EGL display. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-09 16:02:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexture_egl.c: libs: texture: egl: update EGL display and context It is required to use the context of the calling thread when wrapping a foreign texture. According the documentation of GstVideoGLTextureUploadMeta: "The caller of gst_video_gl_texture_upload_meta_upload() must have OpenGL set up and call this from a thread where it is valid to upload something to an OpenGL texture." This patch updates the EGL display and context in GstVaapiDisplay instance to the one used by te renderer that uploads the texture. Original-patch-by: Daniel van Vugt https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 19:53:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: centralize assignation of GL objects Add plugin_set_gst_gl() where the GstGL objects are assigned. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 19:13:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: set GL objects if ensured Only set the GL display and GL other context if they are ensured. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 17:14:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: set GL objects if context is handled Only set the GL display and GL other context if they are extracted correctly from the gstreamer's context. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 19:57:45 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: fix memory leak when GL context is created When the GL display and context are created inside an VAAPI element the created GL context is leaked. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-10 14:01:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: display: egl: free leaked memory The EGL VAAPI display forgot to release the egl display, context and proxied VAAPI display. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-05 19:25:08 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexture_egl.c: libs: texture: egl: code style https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-04 13:51:23 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_egl.c: libs: surface: egl: error message if no extension Instead of silently fail to export the image if there is not available the EGL_MESA_drm_image, log an error message. Also a code refactoring was done. https://bugzilla.gnome.org/show_bug.cgi?id=773453 2017-10-31 13:10:50 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: direct rendering on memory:VASurface As buffers negotiated with memory:VASurface caps feature can also be mapped, they can also be configured to use VA derived images, in other words "direct rendering". Also, because of the changes in dmabuf allocator as default allocator, the code for configuring the direct rendering was not clear. This patch cleans up the code and enables direct rendering when the environment variable GST_VAAPI_ENABLE_DIRECT_RENDERING is defined, even then the memory:VASurface cap feature is negotiated. https://bugzilla.gnome.org/show_bug.cgi?id=786054 2017-10-04 11:54:31 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: plugins: only dmabuf on srcpad if downstream Set if source pad can handle dmabuf only if the GstGL context comes from downstream. It is possible to know that at two moments: 1\ In the case of GstGLTextureUpload caps feature is negotiated and downstream pool reports back gst.gl.GstGLContext. 2\ When GstGLContext is found as GstContext from dowstream. https://bugzilla.gnome.org/show_bug.cgi?id=788503 2017-10-04 11:52:32 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: add inline documentation Document function gst_vaapi_find_gl_local_context(). https://bugzilla.gnome.org/show_bug.cgi?id=788503 2017-10-04 11:50:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: vaapivideocontext: return the direction of gl context In function gst_vaapi_find_gl_context() add a direction parameter to return back the direction where the GstGL context was found. This is going to be useful when checking if downstream can import dmabuf-based buffers. https://bugzilla.gnome.org/show_bug.cgi?id=788503 2017-10-04 08:30:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: add gst_vaapi_plugin_base_set_srcpad_can_dmabuf() This patch refactors the code by adding the function vaapi_plugin_base_set_srcpad_can_dmabuf(), it determines if the passed GstGLContext can handle dmabuf-based buffers. The function is exposed publicly since it is intended to be used later at GstVaapiDisplay instantiation. https://bugzilla.gnome.org/show_bug.cgi?id=788503 2017-10-20 12:37:15 +0200 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: vaapiencode: allow to set property on runtime Tis patch, allows some properties that we want to be set on runtime. (eg. bitrate) Note that all properties are under control by num_codedbuf_queued. https://bugzilla.gnome.org/show_bug.cgi?id=786321 2017-09-15 15:38:18 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: allow to set bitrate on runtime In case of streaming, controlling bitrate dynamically for encoder might be important to manage quality of the streaming. This patch is to support such a scenario. https://bugzilla.gnome.org/show_bug.cgi?id=786321 2017-10-10 11:35:24 +0300 Sebastian Dröge * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapi.h: * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: Register element if no VPP support is available too VPP support is only needed for advanced deinterlacing, which is not enabled by default either. Error out if it is selected but VPP is not supported, and otherwise just work without VPP support. https://bugzilla.gnome.org/show_bug.cgi?id=788758 2017-10-16 11:57:16 +0200 Thibault Saunier * gst/vaapi/gstvaapipluginutil.c: Avoid infinite loop when vaapi_create_display fails Which might be the case when using, for example, xvfb. 2017-10-02 18:53:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: log warn if display fail gstreamer-vaapi initializes the display by trial-and-error, thus logging an error message if the display initialisation fails the user may be weary of the error message in the screen, if using VA-API 1.0 This commit set the VA error log handler to GStreamer warning level while calling vaInitialize() and set it to error after that. https://bugzilla.gnome.org/show_bug.cgi?id=783169 2017-09-29 20:05:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: try to create test display in order When creating the test display for querying capabilites, it try in certain order: DRM, Wayland and finally X11. GLX nor EGL are tried since they are either composited with X11 or Wayland. The reason for this is to reduce the posibility of failure that could blacklist the plugin. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-09-29 15:07:47 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: libs: display: delay getting screen resolution Instead of extracting the screen resolution at GstVaapiDisplay creation, this patch delay it until the screen size is requested for first time. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-09-28 18:58:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: display: egl: avoid two vaDisplay instantiates GstVaapiDisplayEGL is a wrapper of another GstVaapiDisplay, either X11 or Wayland. Nonetheless it created another vaDisplay for it, instead of using the wrapped one. This patch enables the reuse of the wrapped vaDisplay avoiding instantiating two. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-09-28 17:45:00 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: libs: display: remove display_type from display info Since it's no required to pass the display type in the display info, the structure member is removed. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-09-28 17:35:01 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: libs: display: remove display_type member It is not used any more since GstVaapiDisplay was ported as a GstObject-based. This information is part of the class information. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-09-28 16:12:23 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: libs: display: remove parent member Parent was a crumb left from display cache. https://bugzilla.gnome.org/show_bug.cgi?id=782212 2017-10-03 13:06:33 +0200 Sebastian Dröge * gst/vaapi/gstvaapi.c: vaapi: Also register vaapipostproc without VPP support It can still do simple deinterlacing then. 2017-10-03 10:51:06 +0200 Sebastian Dröge * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Allow running without VPP support We returned FALSE from ::start() if VPP support is not available, but it is only really needed for complex filters and during transform we check for that. For simple deinterlacing it is not needed. 2017-09-27 18:35:20 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: use scoped variable for return value Instead of reusing a parameter variable for the return value of gst_vaapipostproc_transform_caps(), this patch uses the function scoped pointer. Thus, the code is cleaner. https://bugzilla.gnome.org/show_bug.cgi?id=785706 2017-09-27 18:32:03 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: removed unused parameter Removed caps parameter from gst_vaapipostproc_transform_caps_impl() helper function since the it is not used. https://bugzilla.gnome.org/show_bug.cgi?id=785706 2017-09-27 13:32:34 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: use scoped variable for return value Instead of reusing a parameter variable for the return value of gst_vaapipostproc_fixate_caps(), this patch uses the function scoped pointer. Thus, the code is cleaner. https://bugzilla.gnome.org/show_bug.cgi?id=785706 2017-09-27 11:27:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.h: plugins: memory:DMABuf only handles planar formats When glimagesink negotiates the caps feature memory:DMABuf the exported dmabufs buffers with NV12 format are not well rendered, thus setting only planar. https://bugzilla.gnome.org/show_bug.cgi?id=788229 2017-09-25 17:04:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: flush pending frames before set format Flush pending frames, if any, in the internal encorder, before setting the new negotiated format. https://bugzilla.gnome.org/show_bug.cgi?id=786173 2017-09-25 15:50:19 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: drain pending frames before set format Drain pending frames, if any, in the internal decoder before setting the new negotiated format. https://bugzilla.gnome.org/show_bug.cgi?id=786173 2017-09-22 19:35:04 +0200 Víctor Manuel Jáquez Leal * tests/test-display.c: tests: display: use GObject getter Instead of using the gst_vaapi_display_get_property(), this patch replaces it with g_object_get_property() to dump the available VA display properties. https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 19:25:20 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: use GObject setter and getter Instead of using gst_vaapi_display_set_property() or gst_vaapi_display_get_property(), this patch set replace it usage with g_object_set() or g_object_get(). Also the internal helper cb_set_value() is removed since it is not used anymore. https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 18:59:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: initialize value if they are not yet This is a difference between the GObject API and the GstVaapi one: the GValue passed to get a property value, in GObject has to be initialized with g_value_init(), but in GstVaapi is has not. In order to overcome this mismatch, this patch call g_value_init() internally only in the passed one is not already initialized. https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 17:04:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: optimize properties setters and getters Shuffled some code to avoid to find the properties descriptor in the array twice, adding the internal functions _set_property() and _get_property(). https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 16:29:02 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: install properties in class Install the properties in the class as a normal GObject. Implement set_property() and get_property() vmethods. https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 15:16:34 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: remove gst_vaapi_display_properties_init() Remove gst_vaapi_display_properties_init() since it can be unrolled in gst_vaapi_display_class_init() https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 15:12:05 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: remove libgstvaapi_init_once() It is not required since it can be unrolled in gst_vaapi_display_class_init() https://bugzilla.gnome.org/show_bug.cgi?id=788058 2017-09-22 17:50:15 +0200 Víctor Manuel Jáquez Leal * tests/test-display.c: tests: test-display: remove display cache tests Since commit ec3e10f6, display cache was removed. This patch removes this leftovers in the display test. 2017-09-18 14:29:55 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h264/h265: decode codec data only if opened Fixes regression introduced by commit 2eb2b26a. There is a use case when the decoder set the src caps and immediatly tries to process the media codec_data, this happens before decoder is even opened, thus priv->parser is not instantiated yet. https://bugzilla.gnome.org/show_bug.cgi?id=787818 2017-09-18 19:11:45 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: change mbbrc from uint to enum Instead of handling the macroblock bitrate control as a integer, this patch changes it as a enum, which is more self documented in the GStreamer elements. https://bugzilla.gnome.org/show_bug.cgi?id=787855 2017-09-18 13:55:49 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: Fix a typo in the prop string for compliance-mode 2017-09-15 18:31:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: don't unref properties This patch fixes a regression introduced in commit 148f867c, since the props variable is set to object's member variable encoder->properties. And it is set in the instance initialization, thus it will not be leaked. https://bugzilla.gnome.org/show_bug.cgi?id=787733 2017-09-15 15:14:47 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst/vaapi/gstvaapiencode.c: vaapiencode/libs: encoder: fix leaks of properties https://bugzilla.gnome.org/show_bug.cgi?id=786321 2017-08-24 21:51:22 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: libs: decoder: at update_caps() decode codec_data When updating the caps in decoder, if the caps has codec_data (avC format), it has to be parsed to update the state of the decoder. https://bugzilla.gnome.org/show_bug.cgi?id=786173 2017-09-13 15:44:32 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: fix wrong counter of the array of attributes The counter value passed to vaCreateConfig is always +1. This is a regression caused by commit e42ec3ad. The present patch fixes wrong counting of the array of attributes. https://bugzilla.gnome.org/show_bug.cgi?id=787613 2017-09-13 12:23:42 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h265: support I/P/B QP setting seperatedly Creates 2 properties, qp-ip and qp-ib for setting different QP for P/B frames and set slice_qp_delta for each frame according to the value provided. https://bugzilla.gnome.org/show_bug.cgi?id=785923 2017-09-13 12:22:07 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: support I/P/B QP setting seperatedly Creates 2 properties, qp-ip and qp-ib for setting different QP for P/B frames and set slice_qp_delta for each frame according to the value provided. In addition, remove the limitation of (<= 4) when setting slice_qp_delta. https://bugzilla.gnome.org/show_bug.cgi?id=785923 2017-09-13 12:15:57 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264/h265: keep min_qp as is unless it's over init_qp Creates new variable for QP for I frame and keep it at configuration and use this for pic_init_qp and slice_qp_delta setting. Since changing min qp doesn't make sense, keep min qp as is. https://bugzilla.gnome.org/show_bug.cgi?id=785923 2017-09-13 12:09:45 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h265: Add mbbrc property This property supports Macroblock level Bitrate Control as the following (same as h264 encoder): 0: auto 1: on 2: off https://bugzilla.gnome.org/show_bug.cgi?id=785917 2017-09-13 12:02:53 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: Add mbbrc property This property supports Macroblock level Bitrate Control as the following: 0: auto 1: on 2: off https://bugzilla.gnome.org/show_bug.cgi?id=785917 2017-09-13 11:39:09 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: add multi reference support This is doing the same as h264 encoder as the following: Using num_ref_frames provided and the result of the Query VAConfigAttribEncMaxRefFrames, it determines the size of reference list and perform encoding with multi reference frames as the following: 1\ The num_ref_frames is being considered as the number of reference picture list0 2\ Encoder adds 1 reference frame more to the reference picture list1 internally if b-frame encoding. 3\ If num_ref_frames is bigger than the number of refrence frames supported in the driver, it will be lowered. Also this patch includes: - Set num_negative_pics and num_positive_pics according to the number of refs. - Set delta_poc according to the number of refs. - Increase max_dec_pic_buffering according to the number of refs - Change max_num_reorder_pics according to num of bframes https://bugzilla.gnome.org/show_bug.cgi?id=783804 2017-09-13 11:37:33 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: libs: encoder: h265: add refs property Users can provide the number of reference frame by this property, which is exaclty same as h264. The value of the property will be considered as the number of reference picture list0 and will add 1 reference frame more to the reference picture list1 internally if b-frame encoding. If the value provided is bigger than the number of refrence frames supported in the driver, it will be lowered. The maximum value is aligned to the value of the driver supported now. https://bugzilla.gnome.org/show_bug.cgi?id=783804 2017-09-13 11:17:26 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264/5: determine num_ref_idx_active_override_flag according to reference list Follows the specification as below: 7.4.7.1 in Rec. ITU-T H.265 v4 (12/2016) num_ref_idx_active_override_flag equal to 1 specifies that the syntax element num_ref_idx_l0_active_minus1 is present for P and B slices and that the syntax element num_ref_idx_l1_active_minus1 is present for B slices. num_ref_idx_active_override_flag equal to 0 specifies that the syntax elements num_ref_idx_l0_active_minus1 and num_ref_idx_l1_active_minus1 are not present. https://bugzilla.gnome.org/show_bug.cgi?id=783804 2017-09-13 11:06:20 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: keep idr_period equal to keyframe period Remove FIXME code, which makes previous assignation spurious. This also means to make idr_period equal to keyframe period, which is same as h264 encoder. https://bugzilla.gnome.org/show_bug.cgi?id=783804 2017-09-06 14:03:25 -0400 Nicolas Dufresne * gst/vaapi/gstvaapipluginbase.c: Request minimum buffer even if need_pool is FALSE When tee is used, it will not request a pool, but still it wants to know how many buffers are required. https://bugzilla.gnome.org/show_bug.cgi?id=730758 2017-09-05 10:58:57 -0700 U. Artie Eoff * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: libs: encoder: h264_fei: VA-API 1.0 compat Use VA_ENC_PACKED_HEADER_H264_SEI compat macro for VA-API 1.0 compatibility. https://bugzilla.gnome.org/show_bug.cgi?id=787322 Signed-off-by: U. Artie Eoff 2017-09-01 13:48:01 -0700 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: Fix rendering in drm display Make sure vaapisink create a va surface backed buffer pool and all required attributes get assigned correctly for drm display type. This is needed to make the below pipeline working: gst-launch-1.0 filesrc location= raw_video.mov ! videoparse format=uyvy width=320 height=240 framerate=30/1 ! vaapisink display=drm https://bugzilla.gnome.org/show_bug.cgi?id=786954 2017-08-09 18:46:09 -0700 Sreerenj Balachandran * tests/Makefile.am: * tests/test-fei-enc-in.c: * tests/test-fei-enc-out.c: FEI: Add test applications to showcase fei use case test-fei-enc-out: A simple fei encoding application to output mv, mbcode and distortion eg: ./test-fei-enc-out -i sample_320x240.nv12 -w 320 -h 240 -o out.264 -v mv.out -d out.dist -m out.mbcode -e 1 test-fei-enc-in: A simple fei encoding application for testing input fei buffers eg: ./test-fei-enc-in -c h264 -o out.264 -e 4 -q 1 sample_i420.y4m Fixme: Running test-fei-enc-in in PAK mode with mv and mbcode input buffers from saved files is still not working People contributed: Wang, Yi Leilei Zhong, Xiaoxia xiaominc Li, Jing B https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 18:36:13 -0700 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_h264_fei.c: * gst/vaapi/gstvaapiencode_h264_fei.h: FEI: plugin: Add vaapih264feienc element A new FEI based encoder element for h264 is added: vaapih264feienc FEI is a an extension to VA-API which is providing low level advanced control over different stages of encoding. Extending vaapih264enc with fei support is possible, but it will make the code too much complicated and will be difficult to debug. So adding the new encoder element, but keeping the rank as 0 , vaapih264enc will stay as the primary encoder for normal use cases. The vaaih264feienc is mainly useful for customers who want to play with MotionVectors and Macroblock Predictions. Also user can do one stage of encoding(eg: only the Motion Vector Calculation) in software and offload trasformation/entroy-coding etc to Hardware (which is what PAK module is doing) using FEI element. vaapih264feienc can work in different modes using fei-mode properoty eg: gst-launch-1.0 videotestsrc ! vaapih264feienc fei-mode=ENC+PAK ! filesink location=sample.264 Important Note: ENC only mode won't produce any encoded data which is expected. But ENC alwys requires the output of PAK in order to do the inter-prediction over reconstructed frames. Similary PAK mode alway requires MV and MBCode as input, so unless there is an upstream element providing those buffers, PAK only won't work as expected. In a nutshell, ENC_PAK and the ENC+PAK modes are the only options we can verify with vaapih264feienc. But ideally, EN+PAK mode verification is enough to make sure that ENC and PAK are working as expected since ENC+PAK mode always invoke ENC and PAK separately in vaapih264feienc. People contributed: Wang, Yi Leilei Zhong, Xiaoxia xiaominc Li, Jing B https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 Signed-off-by: Sreerenj Balachandran 2017-08-09 18:32:13 -0700 Yi A Wang * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: FEI: plugin: Add virtual methods to base encode Two new virtual methods are added to gstvaapiencode. load_control_data(): load the FEI input buffers set by the upstream elements save_stats_to_meta(): save the FEI output buffers to Meta for downnstream elements https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 Signed-off-by: Sreerenj Balachandran 2017-08-09 18:26:57 -0700 Yi A Wang * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapifeivideometa.c: * gst/vaapi/gstvaapifeivideometa.h: FEI: plugin: Add fei specific video meta GstVaapiFeiVideoMeta holds the below fei codec objects: GstVaapiEncFeiMbCode GstVaapiEncFeiMv GstVaapiEncFeiMvPredictor GstVaapiEncFeiMbControl GstVaapiEncFeiQp GstVaapiEncFeiDistortion https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 Signed-off-by: Sreerenj Balachandran 2017-08-09 18:19:06 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_fei.h: * gst-libs/gst/vaapi/gstvaapifeienc_h264.c: * gst-libs/gst/vaapi/gstvaapifeienc_h264.h: * gst-libs/gst/vaapi/gstvaapifeipak_h264.c: * gst-libs/gst/vaapi/gstvaapifeipak_h264.h: FEI: libs: Add FEI encoder Adding FEI encoder to core lib. The code is splitted into three session: 1: gstvaapiencoder_h264_fei.{h,c} This is the replica of gstvaapiencoder_h264.{c,h} but with FEI. All the modes ENC, PAK and ENC_PAK are running based the code in these files. 2: gstvaapifeienc_h264.{h,c} Abstract implementation intended for ENC (only VME) operation. 3: gstvaapifeipak_h264.{h,c} Abstrct implementation intended for PAK (only the PAK module) Right now ENC_PAK, ENC and PAK are running based on code in gstvaapiencoder_h264_fei.{h,c}. The abstract implementations in gstvaapifeienc_h264.{h,c} and gstvaapifeipak_h264.{h,c} are needed if user request for ENC+PAK mode operation. ENC+PAK: Here we need to invoke two sequence of vaBeginPicture/vaRenderPicutre/vaEndPicture for each frame, first for the ENC only and the second for PAK only. Each mode associated with separate context ,but same pool of surfaces are shared between the modes. This is more useful once we have custom BRC algorithms. Other Contributors: Wang, Yi Leilei Zhong, Xiaoxia xiaominc Li, Jing B https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 17:54:27 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: FEI: libs: Add fei codec objects to GstVaapiEncPicture All the codec objects(vaapi buffers) supposed to be submited in vaRenderPicutre are associated with a GstVaapiEncPicture for each frame, follow the same design for FEI too. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 16:05:13 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.h: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy_priv.h: FEI: libs: Add fei codec objects in codedbufferproxy MbCode, MV and Distortion buffers (fei codec objects) can be treated as output of different fei modes based user request. For eg: MbCode and MV are the output of ENC only. MbCode, MV and Dist can be dumped as output in ENC_PAK mode for analysis purpose. So treating them as a part of CodedBufferProxy too. Here we avoided Qp, MbControl and MvPredictor codec objects since there is no practical use case of treating them as "output buffers". Other contributors: Zhong, Xiaoxia xiaominc Leilei Li, Jing B https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 15:49:21 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: FEI: libs: Add fei codec objects to surface proxy Add fei codec objects to surface proxy since handling the fei buffers(codec objects here) external to gstvaapisurfaceproxy will make the code complicated. Especially considering the behavior of encoder where the input frame order from upstream and output frame order to the downstream are not sequential. Other contributors: Zhong, Xiaoxia xiaominc Leilei Li, Jing B https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 15:35:10 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapifei_objects.c: * gst-libs/gst/vaapi/gstvaapifei_objects.h: * gst-libs/gst/vaapi/gstvaapifei_objects_priv.h: FEI: Add codec objects for fei usecase There are 6 new va buffer types, each defined as a specific codec object. Borrowed the code from gstvaapicodecobject , but made a clear separation to avoid any possible mess-up. Because unlike the other gstvaaicodecobjects, feicodecobjects can be shared between elements and also can be accessed from different thread. Unlike the other fei codecs object, VAEncMiscParameterTypeFEIFrameControl object is not shared between elements.So we utilize the already existing gst_vaapi_enc_misc_param_new(), but still keeping the code in gstvaapfei_objects_priv.h in order to have a better code readability. Fixme: -- Probably we need _locked_map() and _unlocked_map() -- Context can be associated with PreEnc(not just Enoder) once we have the proper support inplace, but for now we don't have PreEnc support, so should be safe enough to use GstVaapiEncoder. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 14:22:12 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapifeiutils_h264.c: * gst-libs/gst/vaapi/gstvaapifeiutils_h264.h: FEI: libs: add H264 fei specific utility functions Added enum/flag type definitions for a number of FEI input and output parameters. Original author of the patch: Wang, Yi https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 Signed-off-by: Wang, Yi Signed-off-by: Sreerenj Balachandran 2017-08-09 14:10:16 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: FEI: libs: Add virtual method for secondary context creation. Add a new vitrual method ensure_secondary_context to the base encoder which is only required for the FEI entrypoint, that too only when user configures the ENC+PAK mode. ENC+PAK mode is not something supported directly by libva or driver, but this can be enabled from the middleware. Original Author of this idea: Leilei Shang Signed-off-by: Leilei Shang Signed-off-by: xiaominc Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 14:05:03 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: FEI: libs: make sure the default context creation works as expected. Current code always guess the entrypoint during init phase in case if there is no entrypoint already configured in GstVaapiContextInfo. Make sure FEI Entrypoint is not messing up with this logic. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 13:45:40 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: FEI: libs: Add FEI functional mode configuration FEI Entrypoint can work in either one of the 3 different modes: VA_FEI_FUNCTION_ENC, VA_FEI_FUNCTION_PAK or VA_FEI_FUNCTION_ENC_PAK. Add infrastructure in gstvaapicontext and gstvaapiencoder for this functioal mode configuration. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 13:02:24 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: FEI: libs: Add FEI Entrypoint mapping Define the new mapping GST_VAAPI_ENTRYPOINT_SLICE_ENCODE_FEI for VAEntrypointFEI. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-09 12:58:29 -0700 Sreerenj Balachandran * configure.ac: FEI: Add support for FEI conditional build FEI(Flexible Encoding Infrastructure) is an extension to VA API. Define USE_H264_FEI_ENCODER based on fei header file and required structures availability. https://bugzilla.gnome.org/show_bug.cgi?id=785712 https://bugzilla.gnome.org/show_bug.cgi?id=784667 2017-08-28 17:34:50 -0700 Orestis Floros * gst/vaapi/gstvaapidecode.c: vaapidecode: force add h264 SVC profiles in caps When vaapih264dec's base-only profile is set to TRUE, fake SVC profile support in caps. https://bugzilla.gnome.org/show_bug.cgi?id=732266 Signed-off-by: Sreerenj Balachandran 2017-08-28 17:32:57 -0700 Orestis Floros * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: decode SVC base layer only Drops non-base NALs when the base-only property is set to TRUE. This modifies the behavior for MVC streams with base-only too: All the non-base units are dropped before they are decoded instead of dropping the non-base frames. The relevant part from the H264 spec is: > Decoders that conform to one or more of the profiles specified in Annex A rather than the profiles specified in Annexes G or H shall ignore (remove from the bitstream and discard) the contents of all NAL units with nal_unit_type equal to 14, 15, or 20. To eliminate side effects from the offending units: - PPS's with a broken seq_parameter_set_id (referring to dropped subset SPS's) are ignored. - The NAL parsing is skipped and their flags are set to GST_VAAPI_DECODER_UNIT_FLAG_SKIP. - Prefix units are not stored in prev_pi. Otherwise, parse_slice() would use them even if they are flagged to be skipped. Subset SPS's and slice extension units are not stored there either. https://bugzilla.gnome.org/show_bug.cgi?id=732266 Signed-off-by: Sreerenj Balachandran 2017-08-28 17:28:04 -0700 Orestis Floros * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: check nalu validity in parser info finalize https://bugzilla.gnome.org/show_bug.cgi?id=732266 Signed-off-by: Sreerenj Balachandran 2017-08-28 19:20:42 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: remove unused cast macro Remove internal macro to cast structure that are already declared in the header. 2017-08-28 19:09:07 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: Revert "libs: encoders: remove unused cast macros" This reverts commit fd7d38f7d26b11e592638092b4073b5c1764f255. 2017-08-28 18:32:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: libs: encoders: remove unused cast macros They are only used inside the code, where another macro is defined. Thus these exported macros have no use. 2017-08-24 20:26:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: improve code-style https://bugzilla.gnome.org/show_bug.cgi?id=786173 2017-08-25 16:22:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: handle deprecated enum In VA-API 1.0 the enum VAEncPackedHeaderH264_SEI is deprecated, and instead VAEncPackedHeaderRawData should be used. This patch creates a compatibility symbol, VA_ENC_PACKED_HEADER_H264_SEI, to expose the used enum according the VA-API version. https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-08-25 16:07:34 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiutils.c: libs: guard deprecated symbols In VA-API 1.0 the H.264 baseline profile is deprecated. This patch guards the H.264 baseline usage. Consider this commit as a continuation of commit e0e0a474 https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-08-17 12:54:47 +0200 Víctor Manuel Jáquez Leal * configure.ac: * meson.build: * meson_options.txt: Revert "build: check for libva-2.0" This reverts commit 8f2eb70803099d4b533ecc10fc259041d8714210. https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-08-17 12:44:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: macro to get a renamed value in VA-API 1.0 In VA-API 1.0 the union bits in VAEncMiscParameterBufferROI has renamed one member from roi_value_is_qp_delat to roi_value_is_qp_delta, which is the correct name. In order to keep back compatibility a macro has added to access this union member. https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-08-22 11:37:28 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: plugins: include main gstgl header Instead including particular gstgl header files in a header file that doesn't export a gstgl symbol, the main gstgl header file is included in gstvaapipluginutil.c where the symbols are used. https://bugzilla.gnome.org/show_bug.cgi?id=786597 2017-08-18 18:00:24 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: fix enum namespace 2017-08-17 12:26:12 +0100 Tim-Philipp Müller * common: Automatic update of common submodule From 48a5d85 to 3f4aa96 2017-08-17 11:03:35 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: remove spurious assignation Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. ip_period is assigned first to be rewritter inmediatly after. The first assignation is spurious. 2017-08-15 17:36:51 +0900 Hyunjun Ko * gst/vaapi/gstvaapidecode.c: vaapidecode: fix mismatch of the return type https://bugzilla.gnome.org/show_bug.cgi?id=786307 2017-08-10 13:34:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/libgstvaapi_priv_check.h: * gst-libs/gst/vaapi/meson.build: libs: remove unused header Since libgstvaapi is not distributed, there is no need to check for private header inclusion. Thus removing it. https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-10 13:27:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.h: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: libs: utils: move gstvaapisurface.h to private headers Since the utils don't expose API defined in gstvaapisource.h, it is moved to their private headers where they are used. https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-10 13:26:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: libs: utils: remove va.h include in header And include gstvaapicompat.h in the C files, since the VA-API is not exposed in the headers. https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-10 13:24:06 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: remove va.h include Since it is already managed by gstvaapicompat.h https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-10 13:11:04 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * meson.build: build: consolidate the VA sub API includes Include all VA sub APIs headers in a single point (gstvaapicompat.h), since they are all already included in va.h after VA-API 0.38. https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-10 13:09:27 +0200 Víctor Manuel Jáquez Leal * configure.ac: * meson.build: build: check for va_vpp.h Thus, in config.h the macro HAVE_VA_VA_VPP_H is defined. This will allow us to handle the inclusion of the header better. https://bugzilla.gnome.org/show_bug.cgi?id=786119 2017-08-11 20:22:41 +0100 Tim-Philipp Müller * meson.build: meson: don't export symbols by default Only plugin entry points should be exported. 2017-08-09 19:06:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: remove spurious code Coverity scan: Logically dead code: The indicated dead code may have performed some action; that action will never occur. By using pointer arithmetic is impossible to get NULL. 2017-08-08 18:52:37 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: use attribs index instead pointers Coverity scan bug: Out-of-bounds write. This could cause an immediate crash or incorrect computations. Coverity basically found that it is possible to assign more than 4 attribs in the array. In my opinion this was produced because code pattern used pointer arithmetic, which is not readable nor maintainable. This patch refactors config_create() to use an array index rather than pointer arithmetic. Also a run-time check for index size was added. 2017-08-08 17:38:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: remove spurious code Coverity scan bug: An unsigned value can never be negative, so this test will always evaluate the same way. As len is guint32, there is no need to check it if it is equal or bigger than zero. 2017-08-08 17:34:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: initialize variable Coverity scan bug: The variable will contain an arbitrary value left from earlier computations. Variable base_only is fetched from base-only property, and it may be not assigned. It needs to be initialized. 2017-08-08 17:29:54 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: windows: wayland: fail if cannot remove last frame Converity scan bug: If the function returns an error value, the error value may be mistaken for a normal value. If g_atomic_pointer_compare_and_exchange() fails because the frame is not the last one, the function fails. Thus, logging an info message. 2017-08-08 17:21:52 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_glx.c: libs: utils: glx: check return value Coverity scan bug: If the function returns an error value, the error value may be mistaken for a normal value. Function sscanf returns the number of assignations done. Validate this return value with the number of expected variables to match. 2017-08-08 17:12:06 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiobject.c: libs: vaapi: object: remove unrequired NULL check Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. Variable klass has been validated as non-NULL several time before in gst_vaapi_object_new() function, so there is no need to check it again. 2017-08-08 17:06:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: remove spurious assignation Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. ip_period is assigned first to be rewritter inmediatly after. The first assignation is spurious. 2017-08-08 16:50:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: fix copy & paste error Coverity scan bug: The copied code will not have its intended effect. This is a bug from commit cdaf15b2, where the intention is to initialize RefPicList1 while setting RefPicList0. 2017-08-08 16:33:44 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: fix possible integer overflow Coverity scan bug: Unintentional integer overflow. The expression's value may not be what the programmer intended, because the expression is evaluated using a narrow (i.e. few bits) integer type. Cast operator to guint64 before computation to avoid narrowing. merge with 3c5a6add 2017-08-08 16:12:13 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: libs: decoder: mpeg4: fail if return value is not OK Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. In the return value of decode_slice() or gst_mpeg4_parse_video_packet_header() are not success, thus fail decode_packet() function. 2017-08-08 15:49:27 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: check for null Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. While looking for hte lowest poc, according to rest of the code, the picture in the dbp (decoded picture buffer) might be NULL, thus we could check for a NULL picture before assigned as found. Also, split a comma operator because it is considered as a bad practice because it possible side effects. 2017-08-08 15:38:16 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h265: untaint loop control variable Coverity scan bug: Scalars (for example, integers) are not properly bounds-checked (sanitized) before being used as array or pointer indexes, loop boundaries, or function arguments are considered as tainted. In this case, num_nals were not checked before used as loop control. 2017-08-08 13:46:56 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: remove unrequired NULL check Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. In the original commit for fill_picture_gaps() (commit 5abd2b90) the prev_picture could be NULL, that's why the code did a null check. But, since commit 52adebe7, the previous reference frames are tracked, thus there is no need to check null anymore. 2017-08-03 23:17:44 +0300 orestisf * gst/vaapi/gstvaapidecode.c: vaapidecode: fix gst_caps_new_simple call https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-07-25 22:25:10 +0300 orestisf * gst/vaapi/gstvaapidecode.c: vaapidecode: force add h264 MVC profiles in caps When vaapih264dec's base-only profile is set to TRUE, fake MVC profile support in caps. https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-07-25 22:54:30 +0300 orestisf * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: decode MVC base view only If processed SPS has mvc profile and the configuration is set to base-only, the frame is drop. https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-07-25 22:06:56 +0300 orestisf * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode_props.c: vaapidecode: set h264 base-only to decoder Set the base-only value when property is set and the internal decoder is already instantiated or when the internal decoder is created. https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-07-25 22:03:34 +0300 orestisf * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: libs: decoder: h264: add setter for base-only mode https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-07-25 22:01:37 +0300 orestisf * gst/vaapi/gstvaapidecode_props.c: * gst/vaapi/gstvaapidecode_props.h: vaapidecode_props: h264: add base-only property https://bugzilla.gnome.org/show_bug.cgi?id=732265 2017-08-01 11:11:55 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: missing property enum documentation 2017-08-02 14:54:53 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: add multi reference support Using num_ref_frames provided and the result of the Query VAConfigAttribEncMaxRefFrames, it determines the size of reference list and perform encoding with multi reference frames as the following: 1\ The num_ref_frames is being considered as the number of reference picture list0 2\ Encoder adds 1 reference frame more to the reference picture list1 internally if b-frame encoding. 3\ If num_ref_frames is bigger than the number of refrence frames supported in the driver, it will be lowered. https://bugzilla.gnome.org/show_bug.cgi?id=783803 2017-08-02 14:53:34 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: add refs property Users can provide the number of reference frame by this property. The value of the property will be considered as the number of reference picture list0 and will add 1 reference frame more to the reference picture list1 internally if b-frame encoding. If the value provided is bigger than the number of refrence frames supported in the driver, it will be lowered. https://bugzilla.gnome.org/show_bug.cgi?id=783803 2017-07-28 15:27:20 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: implements gst_vaapi_encoder_ensure_max_num_ref_frames This function will query VAConfigAttribEncMaxRefFrames to get the maximum number of reference frames supported in the driver. This will be used for h264/h265 encoding. https://bugzilla.gnome.org/show_bug.cgi?id=783803 2017-08-01 18:38:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h265.c: vaapiencode: h265: compare an unsigned int if not zero An unsigned value can never be negative, so this test (greater than zero) will always evaluate the same way. Thus change it to just if it's not zero. 2017-08-01 18:10:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: check gst_gl_ensure_element_data() return value Refactor gst_vaapi_plugin_base_create_gl_context() in order to check the return value of gst_gl_ensure_element_data(). The result is a code bit cleaner. 2017-08-01 17:59:38 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: avoid dead code detection By using #elif macro, the static code analysis would stop to detect these lines as dead code. Also it is inforced the mutually exclusive environments. 2017-08-01 17:39:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: don't shift by negative since it's undefined The function g_bit_nth_lsf() may return -1 if the request bit position is not avaible. Thus, this patch check if the return value is not -1 in order to continue. 2017-08-01 17:29:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: fix memory leak 2017-08-01 17:23:48 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: fix memory leaks 2017-07-27 10:54:00 +0000 Tomas Rataj * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: when appending formats change pointers to indexes Thus, it fixes an invalid read when YV12 or I420 are not supported by the driver. https://bugzilla.gnome.org/show_bug.cgi?id=785085 2017-07-19 12:02:40 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: Add uncompliant mode reducing coded buffer size Added a new property "compliance-mode", which default is the normal strict compliant mode. The second mode, "restrict-buf-alloc", is to limit the coded buffer allocation size to improve performance in some specific Intel platforms (there is asignificant performance improvement in parallel encodings). Under this new mode, we use the MinCR field in A.3.1 for pre-calculating the coded-buffer size. https://bugzilla.gnome.org/show_bug.cgi?id=784590 2017-07-05 17:13:44 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: libs: utils_h264: Extend LevelLimit table with MinCR field Add MinCR(Minimum Compression Ratio) field to GstVaapiH264LevelLimits based on Annex A.3 https://bugzilla.gnome.org/show_bug.cgi?id=784590 2017-07-11 17:29:13 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: libva 1.0 changed the logging The logging mechanism in libva has changed it's functions signatures. This patch updates that for libva versions >= 1.0 https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-07-11 17:27:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: libva 1.0 deprecated baseline libva 1.0 deprecated H.264 baseline profile and FMO support (commit b4f332b3). https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-07-26 20:03:35 +0200 Víctor Manuel Jáquez Leal * configure.ac: * meson.build: * meson_options.txt: build: check for libva-2.0 Check for libva-2.0 since libva's developers decided to increase the library's version number. https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-07-11 16:55:26 +0200 Víctor Manuel Jáquez Leal * configure.ac: * meson.build: build: blacklist only libva 0.99.0 Intel's MSDK uses libva 0.99.0, meanwhile open source libva bumped its API version to 1.0.0. Thus we have to blacklist only the MSDK's libva (0.99.0) https://bugzilla.gnome.org/show_bug.cgi?id=784398 2017-07-26 20:30:37 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/meson.build: build: meson: remove gstvaapidisplaycache.c This is a missing bit of commit ec3e10f6 2017-07-26 09:53:10 -0700 U. Artie Eoff * configure.ac: configure: do not break configure if gtk+-3.0 devel missing Fix PKG_CHECK_MODULES rule for with_gtk=check condition to set USE_GTK=0 if gtk+-3.0 is not available. Since commit 85856c29a70d6de4aea5b708e04e9eb418190623 Author: Hyunjun Ko Date: Wed Jul 5 15:59:43 2017 +0900 tests: elements: add testsuite of vaapi context ...configure fails if gtk+-3.0 development files are missing. The "with_gtk" option defaults to "check" in configure.ac which implies that if it is not explicitly requested then configure will only enable it if it's available on the system. However, the PKG_CHECK_MODULES rule that get's activated on "check" condition did not provide default when gtk+-3.0 devel packages are not found on the system. Thus, it resulted in configure failure. Signed-off-by: U. Artie Eoff https://bugzilla.gnome.org/show_bug.cgi?id=785452 2017-07-05 15:59:43 +0900 Hyunjun Ko * configure.ac: * tests/elements/Makefile.am: * tests/elements/test-vaapicontext.c: tests: elements: add testsuite of vaapi context Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=766704 2017-07-05 15:32:43 +0900 Hyunjun Ko * gst/vaapi/gstvaapisink.c: vaapisink: fail if surface display is different Replacing GstVaapiDisplay during rendering might be hiding problems at some cases, even though it's safe currently since we use cache of GstVaapidisplay. Play safe by failing if this happens. https://bugzilla.gnome.org/show_bug.cgi?id=766704 2017-07-05 15:31:55 +0900 Hyunjun Ko * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: videocontext: support "gst.vaapi.app.Display" context Through "gst.vaapi.app.Display" context, users can set their own VADisplay and native display of their backend. Attributes: - display : pointer of VADisplay - x11-display : pointer of X11 display (Display *), if they're using. This patch creates GstVaapidisplayX11 if information provided through "gst.vaapi.app.Display" https://bugzilla.gnome.org/show_bug.cgi?id=766704 2017-07-05 14:33:38 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: libs: display: x11: add gst_vaapi_display_x11_new_with_va_display() Implements new API function so that users could create GstVaapiDisplay with their own VADisplay within a native display as backend. https://bugzilla.gnome.org/show_bug.cgi?id=766704 2017-07-05 14:32:35 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay.c: libs: display: pass display info when foreign display When creating a GstVaapiDisplay using a foreign VADisplay, and render with that display, it also requires native display of the backend. https://bugzilla.gnome.org/show_bug.cgi?id=766704 2017-06-26 21:18:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: libs: display: remove cache Remove a bunch of code that handles the VADisplay cache, since the context sharing should be doing this correctly. https://bugzilla.gnome.org/show_bug.cgi?id=747946 2017-07-13 10:56:18 +0900 Hyunjun Ko * tests/elements/Makefile.am: * tests/elements/test-vaapipostproc.c: tests: elements: add test for vaapipostproc https://bugzilla.gnome.org/show_bug.cgi?id=754885 2017-07-12 18:25:15 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostproc.c: postproc: reconfigure when width or height changes https://bugzilla.gnome.org/show_bug.cgi?id=754885 2017-07-17 18:53:57 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: array terminated in zeros There is a crash when setting ref-pic-mode since the #GEnumValue array is not terminated with a structured with all memvers being zero. https://bugzilla.gnome.org/show_bug.cgi?id=785032 2017-07-13 16:43:34 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: add plugin documentation Comment how the profile is set and other parameters. 2017-05-26 15:19:00 +0000 Matt Staples * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: push frames as soon as possible Push frames downstream as soon as possible instead of waiting until they are ejected from the DPB. This patch makes the decoder not comply with the H.264 specification, but it is required for some video cameras. https://bugzilla.gnome.org/show_bug.cgi?id=762509 Signed-off-by: Víctor Manuel Jáquez Leal 2017-07-10 19:27:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode_props.c: vaapidecode_props: h264: set low-latency in decoder Set the low-latency property if the H264 decoder is already instantiated, thus you could change the behavior in run-time. https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-07-06 20:00:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: set h264 low latency to decoder https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-06-14 18:30:53 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: libs: decoder: h264: add getter/setter for low latency mode https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-06-14 18:31:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode_props.c: * gst/vaapi/gstvaapidecode_props.h: vaapidecode_props: h264: add low latency property Adding support for private data. https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-06-14 18:23:34 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode_props.c: * gst/vaapi/gstvaapidecode_props.h: * gst/vaapi/meson.build: vaapidecode_props: add skeleton for h264 decoder properties https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-06-14 17:07:30 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: properties callback in decoders map https://bugzilla.gnome.org/show_bug.cgi?id=783588 2017-07-07 12:01:59 +0100 Tim-Philipp Müller * meson.build: meson: find python3 via python3 module https://bugzilla.gnome.org/show_bug.cgi?id=783198 2017-06-09 14:47:40 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: submit sps in case of IDR picture If the picture is IDR, also submit a SPS header. This means when frame number reaches to keyframe-period or an force key unit event arrives, we insert SPS/PPS again. https://bugzilla.gnome.org/show_bug.cgi?id=776712 2017-06-09 14:47:16 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: set the frame as IDR if forced key unit GST_VIDEO_CODEC_FRAME_IS_FORCE_KEYFRAME() is a flag usually used to manage the `frame-lost` event in the case of streaming, such as RTP. In case of this event, it is needed to start new GOP rather than just produce an I-frame. https://bugzilla.gnome.org/show_bug.cgi?id=776712 2017-04-05 14:48:46 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: libs: encoder: h264: insert AU delimiter Insert an AUD as the first NAL of each encoded frame. Some applications require Access Unit Delimiter for decoding the stream. The AU delimeter insertion is done only when the aud parameter is TRUE (by default is disabled). The reason of this it is because this header is only available from Intel Gen9 and the VA intel driver should be 1.8 or superior. Otherwise, the output will be corrupted. https://bugzilla.gnome.org/show_bug.cgi?id=776712 Signed-off-by: Victor Jaquez 2017-06-29 12:50:26 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: initialize all elements of view_ids Currently when num_views is changed by multiview-mode on sink caps, it produces wrong MVC encoded stream since the array view_ids is not set properly according to changed num_views. So this patch initializes all of the array sequentially to handle this case. Side effect is not going to happen by this patch since this array is being handled by num_views. https://bugzilla.gnome.org/show_bug.cgi?id=784321 2017-06-27 14:30:54 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: Revert "encoder: h264: Use high profile by default" This reverts commit 4aec5bdd7207fc0e45813ef14c9c0ad5174a8f75. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-27 16:03:37 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: set profile via capsfilter Until now, the encoder ignored the profile in src caps and chose one according with the given parameters. But the encoder must honor the profile specifed in src caps. This patch do that, and if the encoder needs to choose the profile, it will do it by following these rules: 1\ If given parameters are not compatible with given profile, the encoder will bail out with an error. 2\ The encoder will choose the higher profile indicated in the src caps. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-27 13:14:31 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: set profile to src caps So far vaapi encoder does not set profile to src caps. This patch makes it setting profile to src caps, which is determined by itself. In addition, if encoder chose different profile, which is not negotiated with downstream, we should set compatible profile to make negotiation working. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-22 09:56:49 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: vaapiencode: h264: verify if requested profile is supported Check if the requested profile in source caps, is supported by the VA driver. If it is not, an info log message is send saying that another (compatible?) profile will be used. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-21 21:49:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: improve set_config() vmethod First check if downstream requests ANY caps. If so, byte-stream is used and the profile will be choose by the encoder. If dowstream requests EMPTY caps, the negotiation will fail. Lately, byte-stream and profile are looked in the allowed caps. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-21 19:30:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: h264: check for avc in set_config() The check for avc stream format was done in the vaapi encoder's vmethod get_caps(), but that is wrong since it has to be check when encoder set_format(). https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-29 12:49:24 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: set multivew-mode flags to src caps vaapipostproc didn't negotiate the proper multiview caps losing downstream information. This patch enables the playing of MVC encoded stream by setting the proper multiview mode/flags and views to src caps, according to sink caps. https://bugzilla.gnome.org/show_bug.cgi?id=784320 2016-11-22 15:52:47 +0000 Julien Isorce * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add support for DMABuf caps feature https://bugzilla.gnome.org/show_bug.cgi?id=755072 Signed-off-by: Julien Isorce 2017-06-01 19:42:20 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: add support for DMABuf caps feature https://bugzilla.gnome.org/show_bug.cgi?id=755072 Original-patch-by: Julien Isorce 2017-06-23 12:12:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: force dmabuf allocator if DMABuf caps feature Instantiate all dmabuf allocator for src pad buffer pool if the src caps ask for memory:DMABuf feature. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-11-22 23:26:05 +0000 Julien Isorce * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapipluginutil: add support for DMABuf caps feature https://bugzilla.gnome.org/show_bug.cgi?id=755072 Signed-off-by: Julien Isorce Signed-off-by: Victor Jaquez vaapipluginutil: add support for DMABuf caps feature 2017-06-01 19:13:52 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: dmabuf memory map trial for raw caps Only push dmabuf-based buffers with raw caps if gst_memory_map() succeeds. Otherwise, use the the vaapi surfaces allocator. https://bugzilla.gnome.org/show_bug.cgi?id=755072 https://bugzilla.gnome.org/show_bug.cgi?id=774649 Original-patch-by: Julien Isorce 2016-06-08 19:11:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: add gst_vaapi_dmabuf_can_map() This new method checks the specified allocator can create GstMemory that can be mapped. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2017-06-23 17:33:03 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: fix regression with video metas There is another regression with 7a206923 when setting the video info for the video meta, it should be the one from the image's allocator rather from the allocation caps. Test pipeline: gst-launch-1.0 filesrc location=bug766184.flv ! decodebin \ ! tee ! videoconvert ! videoscale \ ! video/x-raw, width=1920, height=1080 ! xvimagesink 2017-06-23 14:38:10 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideobufferpool.c: plugins: update buffer size with the one reported by allocator There is a regression in 7a206923, since the buffer pool ditches all the buffers generated by them because the pool config size is different of the buffer's size. Test pipeline: gst-launch-1.0 filesrc location=big_buck_bunny_1080p_h264.mov \ ! qtdemux ! vaapih264dec ! vaapipostproc ! xvimagesink \ --gst-debug=GST_PERFORMANCE:5 The allocator may update the buffer size according to the VA surface properties. In order to do this, the video info is modified when the allocator is created, which reports through the allocation info the updated size, and set it to the pool config. 2017-06-14 21:40:33 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: initialize active_sps/pps in reset Since commits in https://bugzilla.gnome.org/show_bug.cgi?id=781142 landed, they introduced regression in seek. Formerly, once seek is done, decoder drops P-frames until I-frame arrives. But since the commits landed, it doesn't drop P-frame and does try to decode it continuously because active_sps is still alive. See ensure_sps function. But there are prev_frames and prev_ref_frames reset already, then it causes assertion. So it's necessary to reset active_sps/pps also in reset method. https://bugzilla.gnome.org/show_bug.cgi?id=783726 2017-06-15 13:24:56 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: fix compilation with old versions of libva There are some symbols that are not used when compiling with old version of libva and those generates a compilation error. Original-patch-by: Matt Staples 2017-06-09 14:02:20 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: Fix the quality level clamping Change the hard-coded range of quality-level from {1-8} to {1-7}, since it is the range Intel Open source driver supports. Also perform the range clamping only if the user provided quality-level is greater than the max-range suppored by the driver, because there could be non-intel drivers giving lower value than the hard-coded max value 7. https://bugzilla.gnome.org/show_bug.cgi?id=783567 2017-04-06 19:35:27 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: log out the name of the profile Instead of printing a number, it is more readable to log out, in case of error, the name of the failing profile. 2017-05-31 12:36:17 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: changes raw number of profile to macro name of its Changes raw number of profile to macro name of its to improve readability. https://bugzilla.gnome.org/show_bug.cgi?id=757941 2017-06-09 17:00:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: remove allocation_vinfo private attribute There is no need to keep this attribute internally since it is already managed by the allocator. https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-09 15:02:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: refactor set_config() Refactor the set_config() virtual method considering a cleaner approach to allocator instanciation, if it it not set or if it is not valid for the pool. https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-09 13:05:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: distinguish allocation and negotiation caps The vaapi video decoders might have different allocation caps from the negotiation caps, thus the GstVideoMeta shall use the negotiation caps, not the allocation caps. This was done before reusing gst_allocator_get_vaapi_video_info(), storing there the negotiation caps if they differ from the allocation ones, but this strategy felt short when the allocator had to be reset in the vaapi buffer pool, since we need both. This patch adds gst_allocator_set_vaapi_negotiated_video_info() and gst_allocator_get_vaapi_negotiated_video_info() to store the negotiated video info in the allocator, and distinguish it from the allocation video info. https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-08 19:32:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: rename qdata quarks and ids Also the parameter names were renamed to reflect their origin and purpose. https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-08 16:05:49 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: rename local variables Renamed local video info structure names in set_config() vitual method. The purpose of their renaming is to clarify the origin of those structures, whether come from passed caps parameter (new_allocation_vinfo) or from the configured allocator (allocator_vinfo). https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-08 15:49:05 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: rename video info structures Renamed private GstVideoInfo structure video_info to allocation_vinfo and alloc_info to negotiated_vinfo. The purpose of these renaming is to clarify the origin and purpose of these private variables: video_info (now allocation_vinfo) comes from the bufferpool configuration. It describes the physical video resolution to be allocated by the allocator, which may be different from the negotiated one. alloc_info (now vmeta_vinfo) comes from the negotiated caps in the pipeline. It represents how the frame is going to be mapped using the video meta. In Intel's VA-API backend, the allocation_vinfo resolution is bigger than the negotiated_info. https://bugzilla.gnome.org/show_bug.cgi?id=783599 2017-06-08 12:51:50 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: set framerate if bigger than 0/1 Just set the framerate parameter if the framerate numerator and denominator are bigger than zero. Otherwise, in Intel Gen6 driver, a warning is raised disabling the bitrate control. Original-patch-by: Hyunjun Ko https://bugzilla.gnome.org/show_bug.cgi?id=783532 2017-06-07 12:32:53 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: bitrate target percentage calculation If the rate control is set to Constant Bit Rate (CBR) the target percentage is 100%, otherwise is 70% 2017-06-07 12:25:24 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: h264,h265,mpeg2,vp8,vp9: refactor ratecontrol param Centralize the common configuration for the Rate Control parameter, thus can be overloaded per each specific encoder. 2017-06-07 11:10:49 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: h264,h265,mpeg2,vp8,vp9: refactor framerate param Since the framerate VA parameter is calculated equally among all the encoders, it is better to handle it in the base encoder class. 2016-08-09 15:53:47 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: libs: encoder: vp9: Adds CBR and VBR Encoding support https://bugzilla.gnome.org/show_bug.cgi?id=766832 Signed-off-by: Hyunjun Ko Signed-off-by: Víctor Manuel Jáquez Leal 2017-06-01 12:12:26 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: Adds VBR Encoding support https://bugzilla.gnome.org/show_bug.cgi?id=778732 2017-06-01 12:11:12 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: Adds VBR Encoding support Enables Variable BitRate mode, which does set FrameRate and RateControl parameters. https://bugzilla.gnome.org/show_bug.cgi?id=778732 2017-06-02 13:50:05 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: Describes more detail about the bitrate property https://bugzilla.gnome.org/show_bug.cgi?id=778732 2017-06-05 20:44:22 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: add rate control parameter https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-05 20:33:27 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: libs: encoder: h264,h265,mpeg2: add framerate parameter https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-05 20:30:07 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8,h264,h265,mpeg2: set misc param once Instead of recalculating the miscellaneous buffer parameters for every buffer, it is only done once, when the encoder is configured. And for every buffer, the same structures are just copied. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-05 17:31:10 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8,h264,h265,mpeg2: refactor misc parameters This is patch pretends to decouple the assignation of the values in the parameter structures and the VA buffer's parameters setting. It may lead to some issues since HRD, framerate or controlrate may not be handled by the specific encoder, but they are set in the VA buffer's parameters. I leave as it because this patch is just a transitional patch. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-05 16:34:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: fix frame rate calculation According to the VA documentation: The framerate is specified as a number of frames per second, as a fraction. The denominator of the fraction is given in the top half (the high two bytes) of the framerate field, and the numerator is given in the bottom half (the low two bytes). For example, if framerate is set to (100 << 16 | 750), this is 750 / 100, hence 7.5fps. If the denominator is zero (the high two bytes are both zero) then it takes the value one instead, so the framerate is just the integer in the low 2 bytes. This patch fixes the the framerate calculation in vp8 encoder according to this. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-02 19:46:52 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: refactor FrameRate parameter Move frame-rate parameter from ensure_misc_params() to ensure_contro_rate_param() since it only has meaning when the control rate is either VBR or CBR. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-02 19:33:36 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: h264,h265,mpeg2,vp8: refactor HDR Move the Hypothetical Reference Decoder (HRD) parameter, from ensure_misc_params() to ensure_control_rate_params(), since it only shall be defined when the control rate is either VBR or CBR. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-02 17:21:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: h264,vp8,mpeg2: refactor control rate Instead of filling the control rate param in ensure_misc_params(), this patch refactor it out, as a first step to merge the same code for all the encoders. https://bugzilla.gnome.org/show_bug.cgi?id=783449 2017-06-02 16:28:30 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: libs: encoder: h264, h265, mpeg2: remove assert Remove spurious asserts for misc parameters. If they cannot be allocated, FALSE is already returned. 2017-06-05 18:19:05 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: use VA quality level structure Instead of using a proxy to story the buffer quality level, the encoder now uses the native VA structure, which is copied to the dynamically allocated VAEncMiscParameterBuffer. This approach is computationally less expensive. 2017-05-26 11:10:34 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: standardize the FIXME comment This is a trivial patch that makes homogeneous the FIXME tag in comments. For more info about these comment style: http://wiki.c2.com/?FixmeComment 2017-05-22 17:20:45 +0200 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: set quality level regardless of rate control mode https://bugzilla.gnome.org/show_bug.cgi?id=782957 2017-05-15 18:38:29 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: check for maximum number of slices Right now, H264 and HEVC can set as a property the number of slices to process. But each driver can set a maximum number of slices, depending on the supported profile & entry point. This patch verifies the current num_slices to process against the maximum permitted by the driver and the media size. https://bugzilla.gnome.org/show_bug.cgi?id=780955 2017-05-15 18:36:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_h26x_priv.h: libs: utils: mark functions as internals The functions in this header are internal to the library. 2017-05-15 18:35:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.h: libs: context: add missing documentation Document the region-of-interest configuration variables. 2017-05-12 18:46:50 +0200 Víctor Manuel Jáquez Leal * tests/elements/test-vaapisink.c: tests: elements: vaapisink: handle nav events The test app can now handle navigation events to rotate the display. 2017-05-12 18:17:55 +0200 Víctor Manuel Jáquez Leal * tests/elements/test-vaapisink.c: tests: elements: clean up vaapisink test - Use gst_element_send_event() instead of gst_pad_push_event() - don't zero App structure - check for pipeline parsing error - only get vaapisink for property set 2017-05-12 13:08:30 +0900 Hyunjun Ko * gst/vaapi/gstvaapisink.c: vaapisink: keep handle_events flag except that if user want to set When state of vaapisink is changed from PLAYING to NULL, the handle_events flag is set to FALSE, and never recovered, and then event thread is never going to run. So we should allow to set the flag only when users try it. https://bugzilla.gnome.org/show_bug.cgi?id=782543 2017-05-12 13:06:24 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: libs: window: x11: fix src rect info when using vpp Since we started using VPP in VaapiWindowX11, we need to care about the case that src rect and window's size are different. So, once VPP has converted to other format, we should honor the size of the VPP's surface as source rect. Otherwise, it is cropped according the previous size of the source rect. https://bugzilla.gnome.org/show_bug.cgi?id=782542 2017-04-28 15:20:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: remove par from caps negotiation https://bugzilla.gnome.org/show_bug.cgi?id=781759 2017-03-30 17:57:42 +0900 Hyunjun Ko * tests/elements/Makefile.am: * tests/elements/test-roi.c: tests: elements: add an example for ROI This implements a pipleint to recognize difference between ROI and non-ROI. See comments in this code in detail. https://bugzilla.gnome.org/show_bug.cgi?id=768248 Signed-off-by: Víctor Manuel Jáquez Leal 2017-03-30 17:54:20 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: handle custom event GstVaapiEncoderRegionOfInterest Handles new custom event GstVaapiEncoderRegionOfInterest to enable/disable a ROI region. Writes a way to use new event to document. https://bugzilla.gnome.org/show_bug.cgi?id=768248 Signed-off-by: Víctor Manuel Jáquez Leal 2017-02-23 18:53:18 +0900 Hyunjun Ko * tests/simple-encoder.c: tests: simple-encoder: add an option to set ROI $ simple-encoder -r inputfile.y4m And you'll got an output file in H264 with two regions of interest. https://bugzilla.gnome.org/show_bug.cgi?id=768248 Signed-off-by: Víctor Manuel Jáquez Leal 2017-02-23 18:52:48 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: libs: encoder: h264: set ROI params during encoding Set ROI params during encoding each frame, which are set via gst_vaapi_encoder_add_roi () https://bugzilla.gnome.org/show_bug.cgi?id=768248 Signed-off-by: Víctor Manuel Jáquez Leal 2017-03-28 17:41:37 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: libs: encoder: add api gst_vaapi_encoder_add/del_roi Implements and exposes new api gst_vaapi_encoder_add/del_roi to set ROI regions. https://bugzilla.gnome.org/show_bug.cgi?id=768248 2017-02-23 17:57:07 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder/context: query region of interest support Queries if the driver supports "Region of Interest" (ROI) during the config creation. This attribute conveys whether the driver supports region-of-interest (ROI) encoding, based on user provided ROI rectangles. The attribute value is partitioned into fields as defined in the VAConfigAttribValEncROI union. If ROI encoding is supported, the ROI information is passed to the driver using VAEncMiscParameterTypeROI. https://bugzilla.gnome.org/show_bug.cgi?id=768248 Signed-off-by: Víctor Manuel Jáquez Leal 2017-05-12 11:11:48 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: libs: encoder: fix a comment 2017-05-11 12:23:28 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: guard quality level configuration The quality level appeared in VA-API 0.36. So let's guard its usage. 2017-04-19 13:04:44 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: encoders: add quality level tuning This patch adds the handling of VAEncMiscParameterTypeQualityLevel, in gstreamer-vaapi encoders: The encoding quality could be set through this structure, if the implementation supports multiple quality levels. The quality level set through this structure is persistent over the entire coded sequence, or until a new structure is being sent. The quality level range can be queried through the VAConfigAttribEncQualityRange attribute. A lower value means higher quality, and a value of 1 represents the highest quality. The quality level setting is used as a trade-off between quality and speed/power consumption, with higher quality corresponds to lower speed and higher power consumption. The quality level is set by the element's parameter "quality-level" with a hard-coded range of 1 to 8. Later, when the encoder is configured in run time, just before start processing, the quality level is scaled to the codec range. If VAConfigAttribEncQualityRange is not available in the used VA backend, then the quality level is set to zero, which means "disabled". All the available codecs now process this parameter if it is available. https://bugzilla.gnome.org/show_bug.cgi?id=778733 Signed-off-by: Víctor Manuel Jáquez Leal 2017-05-04 18:59:31 +0300 Sebastian Dröge * configure.ac: * meson.build: Back to development === release 1.12.0 === 2017-05-04 15:46:03 +0300 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.12.0 2017-05-04 11:49:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: Revert "vaapidecodebin: fix element's classification" This reverts commit 8cbe03599a4f27c2001380e2ec150c4f4267a9cf. 2017-04-27 22:55:27 -0700 Scott D Phillips * configure.ac: * meson.build: build: Require libva < 0.99.0 libva >= 0.99.0 is not currently supported by gstreamer-vaapi, so fail to configure instead of failing late in the build. This libva is bundled in msdk[1] and it is ahead in time with respect the official and open source libva[2]. GStreamer-VAAPI only supports the latter for now. 1. https://software.intel.com/en-us/media-sdk/download 2. https://github.com/01org/libva/ https://bugzilla.gnome.org/show_bug.cgi?id=781866 2017-05-02 14:08:54 +0200 Victor Toso * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: fix element's classification This bin should have similar classification as decodebin which is "Generic/Bin/Decoder" otherwise it will appear wrongly as video decoder. Signed-off-by: Victor Toso https://bugzilla.gnome.org/show_bug.cgi?id=782063 === release 1.11.91 === 2017-04-27 17:49:52 +0300 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.11.91 2017-04-27 13:08:56 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: Revert "plugins: reject pixel-aspect-ratio with value 0/1" This reverts commit c0be7b1890ea8da915a81ae82bc9f504aee7cc26. 2017-04-27 12:43:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: reject pixel-aspect-ratio with value 0/1 Do not negotiate a pixel-aspect-ratio of 0/1. https://bugzilla.gnome.org/show_bug.cgi?id=781759 2017-04-26 15:48:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: * gst/vaapi/gstvaapisink.c: plugins: handle pixel-aspect-ratio with value 0/1 When downstream negotiates a pixel-aspect-ratio of 0/1, the calculations for resizing and formatting in vaapipostproc and vaapisink, respectively, failed, and thus the pipeline. This patch handles this situation by converting p-a-r of 0/1 to 1/1. This is how other sinks, such as glimagesink, work. https://bugzilla.gnome.org/show_bug.cgi?id=781759 2017-04-27 14:42:55 +0900 Hyunjun Ko * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: fix leak of created allocator Since it's created by itself, it should be unref-counted after gst_buffer_pool_config_set_allocator call. Afterwards, this allocator will be ref-counted again when assigning to priv->allocator. https://bugzilla.gnome.org/show_bug.cgi?id=781577 2017-04-21 19:07:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: create or reconfig allocator Sometimes a video decoder could set different buffer pool configurations, because their frame size changes. In this case we did not reconfigure the allocator. This patch enables this use case, creating a new allocator inside the VAAPI buffer pool if the caps changed, if it is not dmabuf-based. If so, it is just reconfigured, since it doesn't have a surface pool. https://bugzilla.gnome.org/show_bug.cgi?id=781577 2017-04-25 12:58:44 +0200 Víctor Manuel Jáquez Leal * tests/elements/Makefile.am: test: elements: fix compilation flags This issue was spotten on bug #766704 Original-patch-by: Hyunjun Ko 2017-04-25 16:23:08 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: windows: wayland: fix leak if failure of sync Sometimes gst_vaapi_window_wayland_sync returns FALSE when poll returns EBUSY during destruction. In this case, if GstVaapiWindow is using vpp, leak of vpp surface happens. This surface is not attached to anything at this moment, so we should release it manually. https://bugzilla.gnome.org/show_bug.cgi?id=781695 2017-04-24 20:30:30 +0100 Tim-Philipp Müller * common: Automatic update of common submodule From 60aeef6 to 48a5d85 2017-04-21 15:30:09 +0200 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: mark frames as done When the frame listener callbacks 'done', the number of pending frames are decreased. Nonetheless, there might be occasions where the buffer listener callbacks 'release', without calling previously frame's 'done'. This leads to problem with gst_vaapi_window_wayland_sync() operation. This patch marks as done those frames which were callbacked, but if the buffer callbacks 'release' and associated frame is not marked as 'done' it is so, thus the number of pending frames keeps correct. https://bugzilla.gnome.org/show_bug.cgi?id=780442 Signed-off-by: Víctor Manuel Jáquez Leal 2017-04-21 14:07:44 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: don't sync at destroy() Don't call gst_vaapi_window_wayland_sync() when destroying the wayland window instance, since it might lead to a lock at gst_poll_wait() when more than one instances of vaapisink are rendering in the same pipeline, this is because they share the same window. Since now all the frames are freed we don't need to freed the private last_frame, since its address is invalid now. https://bugzilla.gnome.org/show_bug.cgi?id=780442 Signed-off-by: Hyunjun Ko 2017-04-19 10:37:19 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: null buffer at destroy() Fix leakage of the last wl buffer. VAAPI wayland sink needs to send a null buffer while destruction, it assures that all the wl buffers are released. Otherwise, the last buffer's callback might be not called, which leads to leak of GstVaapiDisplay. This was inspired by gstwaylandsink. https://bugzilla.gnome.org/show_bug.cgi?id=774029 Signed-off-by: Víctor Manuel Jáquez Leal 2016-10-30 10:43:49 +0900 Jagyum Koo * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: rt event queue at destroy() The proxy object of wl_buffer for the last frame remains in the wl_map. Even though we call wl_buffer_destroy() in frame_release_callback(), the proxy object remains without being removed, since proxy object is deleted when wayland server sees the delete request and sends 'delete_id' event. We need to call roundtrip before destroying event_queue so that the proxy object is removed. Otherwise, it would be mess up as receiving 'delete_id' event from previous play, when playing in the next va/wayland window with the same wl_display connection. https://bugzilla.gnome.org/show_bug.cgi?id=773689 Signed-off-by: Víctor Manuel Jáquez Leal 2017-04-20 20:30:52 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: cancel read at poll message Always call wl_display_cancel_read() when an errno is set, but different to EAGAIN or EINTR. https://bugzilla.gnome.org/show_bug.cgi?id=780442 2017-04-21 18:05:48 +0900 Hyunjun Ko * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: skips configuration once it's done Skips configuration of creation of vpp/capsfilter and link them once it's done. Otherwise, it always fails when it's trying to re-start playback. https://bugzilla.gnome.org/show_bug.cgi?id=781573 2017-04-20 18:44:41 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: fixes for memory leaks The use of gst_vaapi_value_set_format() and gst_structure_*_value() requires to clear the used GValue to avoid a memory leak. 2016-12-08 18:51:54 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: enable direct rendering with envvar Direct rendering (use vaDeriveImage rather than vaPutImage) has better performance in some Intel platforms (Haswell, for example) but in others (Skylake) is the opposite. In order to have some control, the patch enables the direct rendering through the environment variable GST_VAAPI_ENABLE_DIRECT_RENDERING. Also it seems to generating some problems with gallium/radeon backend. See bug #779642. https://bugzilla.gnome.org/show_bug.cgi?id=775848 2017-04-08 02:05:21 +1000 Jan Schmidt * gst/vaapi/gstvaapidecode.c: vaapidecode: Don't renegotiate on every flush If caps don't actually change, don't update the decoder and don't set the do_renego flag forcing downstream renegotiation https://bugzilla.gnome.org/show_bug.cgi?id=781142 2017-04-08 01:21:23 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264 decoder: Implement reset() for faster flush Implement a custom reset() function for faster flushes that just clear the reference pictures but don't reallocate the DPB or clear out SPS/PPS https://bugzilla.gnome.org/show_bug.cgi?id=781142 2017-04-05 17:24:20 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst/vaapi/gstvaapidecode.c: Implement decoder reset on flush, rather than recreating Clear decoders out on a flush but keep the same instance, rather than completely recreating them. That avoids unecessarily freeing and recreating surface pools and contexts, which can be quite expensive https://bugzilla.gnome.org/show_bug.cgi?id=781142 2017-04-11 18:50:35 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: libs: window: don't add an unused function The macro GST_VAAPI_OBJECT_DEFINE_CLASS_WITH_CODE only defines a function that is never used, thus when compiling we might see this warning (clang): gstvaapiwindow.c:147:1: warning: unused function 'gst_vaapi_window_class' [-Wunused-function] GST_VAAPI_OBJECT_DEFINE_CLASS_WITH_CODE (GstVaapiWindow, ^ https://bugzilla.gnome.org/show_bug.cgi?id=759533 2017-04-11 18:22:00 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: libs: window: remove surface_format member Since we always convert to NV12, there is no need to keep a variable for that. Let us hard code it. https://bugzilla.gnome.org/show_bug.cgi?id=759533 2017-04-10 17:23:26 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: libs: window: x11/wayland: use new api for conversion Since gst_vaapi_window_vpp_convert_internal is created, GstVaapiWindowX11/Wayland can use it for conversion. Note that once it chooses to use vpp, it's going to use vpp until the session is finished. https://bugzilla.gnome.org/show_bug.cgi?id=759533 2017-04-10 11:41:29 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: libs: window: add gst_vaapi_window_vpp_convert_internal() If a backend doesn't support specific format, we can use vpp for conversion and make it playing. This api is originated from GstVaapiWindowWayland and moved to GstVaapiWindow, so that GstVaapiWindowX11 could use it. https://bugzilla.gnome.org/show_bug.cgi?id=759533 2017-04-03 16:45:36 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: libs: window: x11/wayland: chaining up to GstVaapiWindow Currently, GstVaapiWindowX11/Wayland are not descendants of GstVaapiWindow. This patch chains them up to GstVaapiWindow to handle common members in GstVaapiWindow. https://bugzilla.gnome.org/show_bug.cgi?id=759533 2017-04-05 11:19:15 -0700 Scott D Phillips * gst/vaapi/gstvaapipluginutil.c: plugins: Fix usage of GST_GL_HAVE_WINDOW_* defines When these definitions are false, they are undef in the preprocessor, not a defined value of 0. When they are unset the compile fails with: 'GST_GL_HAVE_WINDOW_WAYLAND' undeclared (first use in this function) https://bugzilla.gnome.org/show_bug.cgi?id=780948 2017-04-10 23:51:06 +0100 Tim-Philipp Müller * common: Automatic update of common submodule From 39ac2f5 to 60aeef6 === release 1.11.90 === 2017-04-07 16:36:21 +0300 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: * meson.build: Release 1.11.90 2017-04-03 14:52:41 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h265.c: vaapiencode: h265: add main-10 in caps template This patch adds h265's main-10 profile in encoder src caps template. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-03 15:34:51 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: chroma and luma with format If the profile is main-10 the bit_depth_luma_minus8, in the sequence parameter buffer, shall be the color format bit depth minus 8, 10-8 which is 2. Also for bit_depth_chroma_minus8. This patch gets the negotiated sink caps format and queries its luma's depth and uses that value to fill the mentioned parameters. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-03-29 19:20:26 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: admit YUV420_10BPP as valid chroma Accepts as supported the GST_VAAPI_CHROMA_TYPE_YUV420_10BPP chroma type. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-03-29 19:16:50 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: ensures profile given format Set the VA profile as GST_VAAPI_PROFILE_H265_MAIN10 if the configured color format is P010_10LE. Otherwise, keep GST_VAAPI_PROFILE_H265_MAIN https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-06 17:21:21 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encode: merge all possible surface formats When the function gst_vaapi_encoder_get_surface_formats() was added it was under the assumption that any VA profile of the specific codec supported the same format colors. But it is not, for example the profiles that support 10bit formats. In other words, different VA profiles of a same codec may support different color formats in their upload surfaces. In order to expose all the possible color formats, if no profile is specified via source caps, or if the encoder doesn't have yet a context, all the possible VA profiles for the specific codec are iterated and their color formats are merged. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-06 16:28:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: vaapiencode: add get_profile() vmethod This new virtual method, get_profile(), if implemented by specific encoders, will return the VA profile potentially determined by the source caps. Also it is implemented by h264 and h265 encoders, which are the main users of this vmethod. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-06 12:49:24 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst/vaapi/gstvaapiencode.c: libs: encoder: pass profile to get_surface_formats() In order to get the supported surface formats within a specific profile this patch adds the GstVaapiProfile as property to gst_vaapi_encoder_get_surface_formats(). Currently the extracted formats are only those related with the default profile of the element's codec. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-06 12:28:51 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: dummy context for get_surface_formats() Instead of creating (if it doesn't exist, yet) the encoder's context the method gst_vaapi_encoder_get_surface_formats() now it creates dummy contexts, unless the encoder has it already created. The purpose of this is to avoid setting a encoder's context with a wrong profile. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-04 14:39:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: refactor init_context_info() In order to generate vaapi contexts iterative, the function init_context_info() is refactored to pass, as parameters the GstVaapiContextInfo and the GstVaapiProfile. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-04 14:21:43 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: encoder: initialize chroma_type Instead of initialize the chroma_type with a undefined value, which will be converted to GST_VAAPI_CHROMA_TYPE_YUV420 by GstVaapiContext, this patch queries the VA config, given the received GstVaapiContextInfo's parameters, and gets the first response. In order to get the GstVaapiChromaType value, also it was needed to add a new utility function: to_GstVaapiChromaType(), which, given a VA_RT_FORMAT_* will return the associated GstVaapiChromaType. https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-03-31 11:21:21 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: enhance logs of negotiated caps https://bugzilla.gnome.org/show_bug.cgi?id=771291 2017-04-05 11:15:41 -0700 Scott D Phillips * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: libs: encoder: vp9: Fix initialization of ref_list gcc 7.0.1 gives a memset-elt-size warning in gst_vaapi_encoder_vp9_init: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] https://bugzilla.gnome.org/show_bug.cgi?id=780947 2017-03-31 14:12:43 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Fix Backward ReferencePicture flag setting This is a regression introduced by e829b62 which override the reference flags and caused issues with latest intel-vaapi-driver. 2017-03-29 13:22:47 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: fix code style Trivial patch to remove a double ';' as end of instruction. 2017-03-28 10:53:20 -0700 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Fix B frame encoding artifacts The current implementation is updating the POC values only in Slice parameter Buffer.But we are not filling the picture order count and reference flags in VAPictureH264 while populating VA Picture/Slice structures.The latest intel-vaapi-driver is directly accessing the above fields from VAPicutreH264 provided as RefPicLists, which resulted some wrong maths and prediction errors in driver. https://bugzilla.gnome.org/show_bug.cgi?id=780620 2017-03-21 16:13:56 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: remove unused macro definition Since the h265 encoder doesn't use GValueArray, there is no need to disable the Glib deprecation warnings, thus removing the macro definition. 2017-03-20 16:45:01 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: when debug disabled, default category is NULL As in gstreamer-vaapi a common base class is used, the specific default category is passed to the base-plugin initializator, thus the log messages are categorized with the used plugin. Nonetheless, when the gst-debug is disabled in compilation time, it is needed to pass NULL to the base-plugin initializator. This patch does that. https://bugzilla.gnome.org/show_bug.cgi?id=780302 2017-03-17 17:14:01 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h26x.c: * gst-libs/gst/vaapi/gstvaapiutils_h26x_priv.h: libs: h26x: adds gst_vaapi_utils_h26x_write_nal_unit() Implements gst_vaapi_utils_h26x_write_nal_unit(), which writes NAL unit length and data to a bitwriter. Note that this helper function applies EPB (Emulation Prevention Bytes), since otherwise produced codec_data might be broken when decoder/parser considering EPB, starts parsing. See sections 7.3 and 7.4 of the H264 and H264 specifications, which describes the emulation_prevention_three_byte. https://bugzilla.gnome.org/show_bug.cgi?id=778750 Signed-off-by: Víctor Manuel Jáquez Leal 2017-03-17 16:49:41 +0900 Hyunjun Ko * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h26x.c: * gst-libs/gst/vaapi/gstvaapiutils_h26x_priv.h: * gst-libs/gst/vaapi/meson.build: libs: utils: h26x: create vaapiutils_h26x Since there is duplicated code in h264/265 encoder, we could refactor it to avoid duplicated code. https://bugzilla.gnome.org/show_bug.cgi?id=778750 Signed-off-by: Víctor Manuel Jáquez Leal 2017-03-17 16:32:36 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h264/5: fix wrong return value https://bugzilla.gnome.org/show_bug.cgi?id=778750 2017-03-13 17:29:59 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: docs: h264/h265: put parser to the example pipeline https://bugzilla.gnome.org/show_bug.cgi?id=778749 2017-03-13 16:20:59 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: fix reserved length of bits Fix reserved length of bits for bit_depth_luma_minus8 and bit_depth_chroma_minus8 https://bugzilla.gnome.org/show_bug.cgi?id=778749 2017-03-12 18:59:42 +0100 Thomas Petazzoni * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * tests/test-display.c: O_CLOEXEC needs _GNU_SOURCE defined From man open(2): The O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW flags are not specified in POSIX.1-2001, but are specified in POSIX.1-2008. Since glibc 2.12, one can obtain their definitions by defining either _POSIX_C_SOURCE with a value greater than or equal to 200809L or _XOPEN_SOURCE with a value greater than or equal to 700. In glibc 2.11 and earlier, one obtains the definitions by defining _GNU_SOURCE. And indeed, with the uClibc C library, O_CLOEXEC is not exposed if _GNU_SOURCE is not defined. Therefore, this commit fixes the build of gstreamer-vaapi with the uClibc C library. Signed-off-by: Thomas Petazzoni https://bugzilla.gnome.org/show_bug.cgi?id=779953 2017-03-14 16:07:08 +0100 Víctor Manuel Jáquez Leal * README: README: fix "Sources" section Update the URL where the release source tarballs can be downloaded. 2017-03-12 21:39:53 +0100 Thomas Petazzoni * README: README: fix "Reporting bugs" section The "Reporting bugs" section gives https://bugzilla.gnome.org/enter_bug.cgi?product=gstreamer-vaapi as the link to report a bug, but this link says "Sorry, entering a bug into the product gstreamer-vaapi has been disabled.". This commit fixes the URL to point to the proper location, and also removes the following paragraph that is no longer correct. Signed-off-by: Thomas Petazzoni https://bugzilla.gnome.org/show_bug.cgi?id=779954 2017-03-03 19:55:00 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: retry to create the VA display Particularly in GNOME Wayland, the negotiated or created GL context defines a GLX environment, but VAAPI fails to create a GLX VA display because there is no a DRI2 connection. This patch retries to create the VA display if VA cannot create one with the GL context parameters. Now using the old list of display types. This should also work in the case of systems with two GPU, when the non-VAAPI has the graphics environment, and the VAAPI-enabled one shall work headless. https://bugzilla.gnome.org/show_bug.cgi?id=772838 2016-10-19 15:33:41 +0100 Julien Isorce * gst/vaapi/gstvaapipostproc.c: vaapipostproc: texture upload if driver supports GL Removes GstVideoGLTextureUploadMeta caps feature if the driver doesn't support opengl. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=772838 2016-10-25 17:48:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: texture upload if driver supports GL When the allowed source pad caps are generated, the GLTextureUpload caps are only inserted if the driver support OpenGL. https://bugzilla.gnome.org/show_bug.cgi?id=772838 2017-02-22 15:02:01 -0800 Sreerenj Balachandran * configure.ac: configure: Add missing compiler flags The AC_CHECK_HEADERS macro was failing to locate some headers, in particular the va_enc_* headers due to missing compiler flags. https://bugzilla.gnome.org/show_bug.cgi?id=779101 Signed-off-by: Víctor Manuel Jáquez Leal 2017-03-01 14:48:46 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: window: wayland: handle more VAStatus to use vpp Since the commit landed https://github.com/01org/intel-vaapi-driver/pull/55, we should consider more returned VAStatus to use vpp. https://bugzilla.gnome.org/show_bug.cgi?id=779400 2017-02-23 15:16:06 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: ensure profile when context initialization We can't be sure that encoder's profile is assgined already or not at context initialization. https://bugzilla.gnome.org/show_bug.cgi?id=779120 2017-02-23 15:13:59 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: set rate control info only when query succeed Currently, it set rate control information even when query fails. In addition, it doesn't update any more since the flag got_rate_control_mask is set to TRUE. https://bugzilla.gnome.org/show_bug.cgi?id=779120 2017-02-24 16:00:23 +0200 Sebastian Dröge * meson.build: meson: Update version 2017-02-24 15:38:22 +0200 Sebastian Dröge * configure.ac: Back to development === release 1.11.2 === 2017-02-24 15:10:21 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.11.2 2017-02-16 18:37:59 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: merge tags for downstream's info Add encoder and codec name and the bitrate into the output for informational purposes. Some muxers or application use it as media metadata. https://bugzilla.gnome.org/show_bug.cgi?id=778781 2017-02-17 01:27:52 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: caps can change at any time The encoder should be able to change its caps even it is already processing a stream. This is suppose to happen after a flush so the codedbuf_queue should be empty. https://bugzilla.gnome.org/show_bug.cgi?id=775490 2017-02-17 01:19:00 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: encoder: h265: bail if nal unit type fails Bail out if the NAL unit type is not recognized. https://bugzilla.gnome.org/show_bug.cgi?id=778782 2017-02-16 18:11:50 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: libs: decoder: h264,h265 avoid uninitialized variable Configuring GCC to verify possible usage of uninitialized variables, shows that found_index might be used without previous assignation. This patch assigns a initial value to found_index, also avoid a branching when returning the result value. https://bugzilla.gnome.org/show_bug.cgi?id=778782 2017-02-13 16:39:41 -0800 Scott D Phillips * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: build: rename USE_HEVC_DECODER to USE_H265_DECODER Rename to be consistent with H.264 and also H.265 encoder. The meson build assumed this was already consistently named, and so previously was not able to actually build the H.265 decoder. https://bugzilla.gnome.org/show_bug.cgi?id=778576 2017-02-15 19:14:59 +0000 Tim-Philipp Müller * meson.build: meson: gstreamer-codecparsers is a required dep Just like in configure.ac. 2017-02-15 00:26:21 +0000 Tim-Philipp Müller * Makefile.am: meson: dist meson build files Ship meson build files in tarballs, so people who use tarballs in their builds can start playing with meson already. 2017-02-10 09:51:38 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: add CBR encoding mode This patch enables the Constant BitRate encoding mode in VP8 encoder. Basically it adds the configuration parameters required by libva to CBR enconding. Original-Patch-By: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749950 2017-02-09 12:39:19 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: encoder: vp8: fix bitrate calculation Base encoder's unit of bitrate is in Kbps. We should honor it so we use the value of bitrate in VA, in which is expressed in bps. https://bugzilla.gnome.org/show_bug.cgi?id=749950 2017-02-09 12:49:44 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: fix build when gcc In commit a8e482f9 we added a function without parameters, but gcc doesn't like that. 2017-02-06 15:46:20 -0800 Scott D Phillips * gst-libs/gst/base/meson.build: * gst-libs/gst/meson.build: * gst-libs/gst/vaapi/meson.build: * gst-libs/meson.build: * gst/meson.build: * gst/vaapi/meson.build: * meson.build: * meson_options.txt: vaapi: add meson build https://bugzilla.gnome.org/show_bug.cgi?id=778250 2017-02-08 10:17:40 -0800 Scott D Phillips * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiversion.h.in: make: remove gstvaapiversion.h generation https://bugzilla.gnome.org/show_bug.cgi?id=778250 2016-10-19 15:47:41 +0100 Julien Isorce * gst/vaapi/gstvaapipluginbase.c: plugins: use linear storage if not the same device When dmabuf is negotiated downstream and decoding and rendering are not done on the same device, the layout has to be linear in order for the memory to be shared accross devices, since each device has its own way to do tiling. Right now this code is rather just a to-do comment, since we are not fetching the device ids. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2017-02-08 14:17:05 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiutils.c: libs: utils: add HEVC profiles representation https://bugzilla.gnome.org/show_bug.cgi?id=778318 2017-02-07 16:17:39 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: reduce frame number of gaps Reduce frame num gaps so that we don't have to create unnecessary dummy pictures, just throw them away. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=777506 2016-10-16 01:04:09 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't GLTextureUpload if dmabuf Do not add the meta:GstVideoGLTextureUploadMeta feature if the render element can handle dmabuf-based buffers, avoiding its negotiation. 2016-10-19 16:21:21 +0100 Julien Isorce * gst/vaapi/gstvaapidecode.c: vaapidecode: make pool to export decoder's surface Use new -base API gst_video_decoder_allocate_output_frame_full() to pass the current proxy/surface to the pool. The pool will will export thins given surface instead of exporting a brand new surface that will never be filled in with meaningfull data. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2017-02-03 17:06:29 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: decoder can negotiate dmabuf downstream 2016-10-19 16:07:07 +0100 Julien Isorce * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: override acquire_buffer() Overriding the vmethod acquire_buffer() it is possible to attach the right GstMemory to the current acquired buffer. As a matter of fact, this acquired buffer may contain any instantiated GstFdmemory, since this buffer have been popped out from the buffer pool, which is a FIFO queue. So there is no garantee that this buffer matches with the current processed surface. Evenmore, the VA driver might not use a FIFO queue. Therefore, it is no way to guess on the ordering. In short, acquire_buffer on the VA driver and on the buffer pool return none matching data, we have to manually attach the right GstFdMemory to the acquired GstBuffer. The right GstMemory is the one associated with the current surface. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 16:05:04 +0100 Julien Isorce * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: export surface if it is provided gst_vaapi_dmabuf_memory_new() always exports a surface. Previously, it had to create that surface. Now it can also export an already provided surface. It is useful to export decoder's surfaces (from VA context). https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:55:27 +0100 Julien Isorce * gst/vaapi/gstvaapivideobufferpool.h: vaapivideobufferpool: add GstVaapiVideoBufferPoolAcquireParams Useful to let the pool know the current surface proxy when calling gst_buffer_pool_alloc_buffer() / gst_buffer_pool_acquire_buffer() https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:09:34 +0100 Julien Isorce * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: libs: surface: add gst_vaapi_surface_{set,peek}_buffer_proxy() These functions are useful when a dmabuf-based memory is instantiated in order to relate the generated buffer @proxy with the processed @surface. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:07:31 +0100 Julien Isorce * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: libs: bufferproxy: gst_vaapi_buffer_proxy_{set,peek}_mem() This patch adds a GstMemory as a variable member of the buffer proxy, because we will need to associate the buffer proxy with the memory which exposes it. Later, we will know which memory, in the video buffer pool, is attached to the processed surface. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:33:41 +0100 Julien Isorce * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't GLTextureUpload if dmabuf Do not add the meta:GstVideoGLTextureUploadMeta feature if the render element can handle dmabuf-based buffers, avoiding its negotiation. Similar as "vaapidecode: do not add meta:GstVideoGLTextureUploadMeta feature if can dmabuf" https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-12-16 14:12:30 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: enable DMAbuf allocator to downstream If the negotiated caps are raw caps and downstream supports the EGL_EXT_image_dma_buf_import extension, then the created allocator is the DMAbuf, configured to downstream. At this moment, the only element which can push dmabuf-based buffers to downstream, is vaapipostproc. 2016-06-02 22:13:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: check if negotiate dmabuf with downstream In order to enable, in the future, dmabuf-based buffers, the vaapi base plugin needs to check if downstream can import dmabuf buffers. This patch checks if downstream can handle dmabuf, by introspecting the shared GL context. If the GL context is EGL/GLES2 and have the extension EGL_EXT_image_dma_buf_import, then dmabuf can be negotiated. Original-patch-by: Julien Isorce 2016-10-19 15:37:04 +0100 Julien Isorce * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: release proxy's data if downstream The surface created for downstream is going to be filled by VAAPI elements. So, the driver needs write access on that surface. This patch releases the derived image held by the proxy, thus the surface is unmarked as busy. This is how it has to be done as discussed on libva mailing list. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:01:04 +0100 Julien Isorce * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: libs: bufferproxy: add gst_vaapi_buffer_proxy_release_data() Adds an API to request the user's data release in the buffer proxy. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-10-19 15:27:03 +0100 Julien Isorce * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: add direction to dmabuf allocator Add GstPadDirection param to gst_vaapi_dmabuf_allocator_new(), thus we later could do different thing when the allocated memory is for upstream or dowstream, as required by VA-API. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-12-15 15:59:30 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiutils_core.c: libs: utils: return NULL if failed to get surface formats Thus, when generating the allowed caps, the element will throw a warning and it will use its caps template. This behavior might be a bug in the VA driver. https://bugzilla.gnome.org/show_bug.cgi?id=775490 2015-11-26 18:21:08 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: Revert "vaapidisplay: mark X11 display as compatible with EGL" This reverts commit 200b1baabc066f8a4102f82f539655d588200ec9. 2017-02-01 14:32:45 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostproc.c: vaapipostproc: set GST_VAAPI_POSTPROC_FLAG_SIZE according to src caps A value of width/height property should be set to out caps, if negotiation had been going properly. So we can use srcpad_info when making decision of scaling. https://bugzilla.gnome.org/show_bug.cgi?id=778010 2017-01-27 12:10:54 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: handle GL params through context query If the element instantiated the GL display and context, they should handle them too through the context query. https://bugzilla.gnome.org/show_bug.cgi?id=777409 2017-01-26 12:02:56 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: plugins: create a GL context on certain conditions If a GstVaapiDisplay is not found in the GStreamer context sharing, then VAAPI elements look for a local GstGLContext in gst context sharing mechanism ('gst.gl.local.context'). If this GstGLContext not found either then, only the VAAPI decoders and the VAAPI post-processor, will try to instantiate a new GstGLContext. If a valid GstGLContext is received, then a new GstVaapiDisplay will be instantiated with the platform, API and windowing specified by the instantiated GstGLContext. Original-Patch-By: Matt Fischer https://bugzilla.gnome.org/show_bug.cgi?id=777409 2016-08-02 15:48:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: context type can be rejected Instead of calling g_return_val_if_fail() to check the context type, we should use a normal conditional, since it is possible that other context types can arrive and try to be assigned. Otherwise a critical log message is printed. This happens when we use playbin3 with vaapipostproc as video-filter. https://bugzilla.gnome.org/show_bug.cgi?id=777409 2017-01-20 19:57:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: use sink caps par if not requested Use the sink caps pixel-aspect-ratio to fixate the src caps, if it is not already set. https://bugzilla.gnome.org/show_bug.cgi?id=777395 2017-01-20 19:00:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: set interlace mode if the vaapipostproc is configured to not do deinterlacing, the interlace-mode in the src caps should be the same as the input caps. https://bugzilla.gnome.org/show_bug.cgi?id=777395 2017-01-20 16:10:32 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: fix gcc compiler warning warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 2017-01-12 19:54:41 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: don't use member variable outside lock Thus a race condition segfault is avoided. Original-patch-by: Matt Staples https://bugzilla.gnome.org/show_bug.cgi?id=777146 2017-01-18 17:20:21 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipostproc.c: plugins: avoid log flood when activating pool Every time a new buffer is allocated, the pool is activated. This doesn't impact in performance since gst_buffer_pool_set_active() checks the current state of the pool. Nonetheless it logs out a message if the state is the same, and it floods the logging subsystem if it is enabled. To avoid this log flooding first the pool state is checked before changing it. 2017-01-13 21:26:15 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: update internal decoder sink caps When a new sink caps arrive the internal decoder state is updated and, if it is, request a downstream renegotiation. Previously, when new caps arrived the whole decoder where destroyed and recreated. Now, if the caps are compatible or has the same codec, the internal decoder is kept, but a downstream renegotiation is requested. https://bugzilla.gnome.org/show_bug.cgi?id=776979 2017-01-12 16:33:13 +0200 Sebastian Dröge * configure.ac: Back to development === release 1.11.1 === 2017-01-12 16:27:12 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.11.1 2017-01-12 12:49:55 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: vaapi: bump ifdef to API 0.40.0 for log redirect vaSetInfoCallback() is not released yet. It is going to appear in VA-API 0.40.0 2017-01-12 13:45:29 +0200 Sebastian Dröge * gst-libs/gst/vaapi/gstvaapiutils.c: vaapiutils: Fix compilation with latest and previous libva releases vaSetInfoCallback() was defined after 0.39.4 / 1.7.3, so check for 0.39.5 instead. 2017-01-11 16:04:24 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: libs: display: redirect logging at initialize Redirect libva's logs to GStreamer logging mechanism. This is particularly useful when VA is initialized, because it always logs out the drivers details. In order to achieve this a new helper function was added as a wrapper for the vaInitialize() function. https://bugzilla.gnome.org/show_bug.cgi?id=777115 2017-01-10 15:15:31 +0900 Hyunjun Ko * gst/vaapi/gstvaapipluginbase.c: plugins: provide at least two buffers in sink pool Adds two buffers as the default value of minimum buffer. This would be used when creating and proposing vaapi bufferpool for sink pad, hence the upstream element will keep, at least, these two buffers. https://bugzilla.gnome.org/show_bug.cgi?id=775203 Signed-off-by: Víctor Manuel Jáquez Leal 2017-01-10 13:49:27 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: libs: decoder: h264: don't update cloned attributes If the frame is a cloned picture, its PTS comes from its parent picture. In addition, the base decoder doesn't set a valid PTS to the frame corresponding to the cloned picture. https://bugzilla.gnome.org/show_bug.cgi?id=774254 2017-01-09 19:25:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: check for display This patch fixes the check of display, rather than check for the meta, which it is known it exists. 2017-01-09 16:23:56 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: rename dmabuf allocator parameters Rename the parameters 'vip' and 'flags' to 'alloc_info' and 'surface_alloc_flags' respectively. The purpose of this change is to auto-document those parameters. Also, aligned to this patch, the local 'alloc_info' variable was renamed as 'surface_info', because it stores the possible surface's video info, not the allocate one. 2017-01-09 16:18:32 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: rename vip to alloc_info parameter In order to auto-document the code, this patch renames the 'vip' parameter in the functions related to gst_vaapi_video_allocator_new () to 'alloc_info', since it declares the allocation video info from the vaapi buffer pool. 2017-01-09 16:08:17 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: use GST_VIDEO_INFO_FORMAT_STRING() Use the existing local macro GST_VIDEO_INFO_FORMAT_STRING() to get the video format string. 2017-01-09 12:51:11 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: unroll gst_vaapi_surface_new_with_format() gst_vaapi_surface_new_with_format() is a wrapper for gst_vaapi_surface_new_full (). In this case, the former is simpler than the first. This patch changes that. 2017-01-04 19:23:06 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostproc.c: vaapipostproc: notify if src pad caps changed If src pad caps have changed, it needs to notify it downstream. In addition, do not set passthrough if they have changed. Otherwise, transform sometimes starts processing before caps change. The passthrough value will be set in fixate later in this case. https://bugzilla.gnome.org/show_bug.cgi?id=775204 2016-12-14 15:51:01 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: capsfilter to optimize negotiation Add a capsfilter forcing the caps "video/x-raw(memory:VASurface), format=(string)NV12" between the queue and the vaapipostproc so no renegotiation is required. https://bugzilla.gnome.org/show_bug.cgi?id=776175 2016-12-21 17:38:07 +0900 Hyunjun Ko * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: fail surface/image configuration To detect and handle errors during allocator_configure_surface_info() and allocator_conigure_image_info(). https://bugzilla.gnome.org/show_bug.cgi?id=776084 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-21 17:50:41 +0900 Hyunjun Ko * gst/vaapi/gstvaapisink.c: vaapisink: ensures raw caps at start() Calls gst_vaapi_plugin_base_get_allowed_raw_caps() at start() to avoid race conditions at get_caps(), especially with multiple src elements. https://bugzilla.gnome.org/show_bug.cgi?id=776303 2016-12-09 14:51:52 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: libs: surface: fix error handling code style 2016-12-09 16:14:14 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: add gst_video_info_update_from_surface() With this function is possible to refactor and remove duplicated code between dmabuf configuration and direct rendering/uploading configuration. 2016-12-09 15:51:32 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: no log object at initialization When an instance of GstVaapiVideoAllocator fails at initializing, the log message should not include the allocator's object, because it is going to be unrefed. 2016-12-09 17:56:02 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: lock stream when setting caps 2016-12-09 17:42:42 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: Revert "vaapidecode: implement negotiate() vmethod" This reverts commit 3285121181295c544480fc6ba756845b16285d30. videodecode's negotiate() vmethod is also called when events arrive, but this would mean that the proper configuration of sink pad might not be complete, thus we should not update the src pad. Let's keep the old non-vmethod negotitate(). 2016-12-07 16:52:35 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: Revert "encoders: demote to RANK_NONE since not fit for autoplugging yet" This reverts commit f182b8be2ba05965e6d31a4d380d6563b9b53a77. 2016-12-01 18:57:10 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: vaapiencode: get surface formats in get_caps() Query for the supported surface formats in config at get_caps() vmethod. https://bugzilla.gnome.org/show_bug.cgi?id=769266 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-07 11:26:37 +0100 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: libs: encoder: add gst_vaapi_encoder_get_surface_formats() This method will return the valid surface formats in the current config. If the are no VAConfig it is created with the information available. https://bugzilla.gnome.org/show_bug.cgi?id=769266 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-07 11:10:42 +0100 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiencoder.c: libs: encoder: split set_context_info() Split set_context_info() adding init_context_info() which only initialises the GstVaapiContextInfo structure inside GstVaapiEncoder required for VAConfig. https://bugzilla.gnome.org/show_bug.cgi?id=769266 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-02 09:30:52 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: skip VAContext if no frame size If GstVaapiContextInfo has just initial information, without frame's width and height, skip the creation of the VAContext, just keep the VAConfig. https://bugzilla.gnome.org/show_bug.cgi?id=769266 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-02 09:28:07 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapicontext.c: libs: context: split context_create() Split the funcion context_create() into context_create() and config_create(). Decoupling VAConfig and VAContext during context creation, we could query the VAConfig for the supported surface's formats without creating a VAContext. https://bugzilla.gnome.org/show_bug.cgi?id=769266 2016-12-06 17:33:42 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: libs: drm: find render node in hybrid system Originally the drm backend only tried to open the first render node found. But in hybrid system this first render node might not support VA-API (propietary Nvidia driver, for example). This patch tries all the available nodes until a finding one with a VA-API supported driver. https://bugzilla.gnome.org/show_bug.cgi?id=774811 Original-patch-by: Stirling Westrup and Reza Razavi 2016-11-14 17:45:55 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: refactor code for readability Added the inlined function allocator_configure_pools() moving out code from gst_vaapi_video_allocator_new() to make clear that it is a post-initalization of the object. 2016-11-14 17:40:37 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: log error if not VA image Log an error message if the test image for surface downloading cannot be allocated or mapped. 2016-11-14 17:33:41 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: remove unused macros These macros are not used. Let us remove them. 2016-11-11 19:45:45 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: rename video for allocation_info Since video_info stores the GstVideoInfo of the allocation caps, it is clear if we rename it as allocation_info, to distinguish it later from negotiation_info. 2016-10-19 15:27:03 +0100 Julien Isorce * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: add real GstVaapiDmaBufAllocator Instead of defining GstVaapiDmaBufAllocator as a hackish decorator of GstDmaBufAllocator, now, since the expose of the GstDmaBufAllocator's GType, GstVaapiDmaBufAllocator is a full feature GstAllocator inherited from GstDmaBufAllocator. https://bugzilla.gnome.org/show_bug.cgi?id=755072 Signed-off-by: Víctor Manuel Jáquez Leal 2016-10-19 15:30:09 +0100 Julien Isorce * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: errors in gst_vaapi_dmabuf_allocator_new() Add a helper function to initialize the gst_debug_vaapivideomemory, to use it either by the GstVaapiVideoAllocatorClass or GstVaapiDmabufAllocator (which is a decorator of GstDmaBufAllocator). Later, log possible errors when calling gst_vaapi_dmabuf_allocator_new () https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-11-29 15:14:32 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: vaapiencode: release internal encoder at stop() As the internal encoder is created at start(), let's release it at stop() vmethod, to be consistent. gst_vaapiencode_destroy() is called since it also resets the input and output states, which is something that the base class does internally after calling stop() vmethod. https://bugzilla.gnome.org/show_bug.cgi?id=769266 Signed-off-by: Víctor Manuel Jáquez Leal 2016-12-03 08:20:56 +0100 Edward Hervey * common: Automatic update of common submodule From f49c55e to 39ac2f5 2016-11-29 14:59:02 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: vaapiencode: call ensure_encoder() at start() Currently, specific encoder is created during set_format(). This might lead to race condition when creating profiles with multiple encoders. This patch moves ensure_encoder() call to start() vmethod to ensure avoiding the race condition. https://bugzilla.gnome.org/show_bug.cgi?id=773546 2016-11-21 19:29:22 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: bring back dynamic configuration In commit ca0c3fd6 we remove the dynamic configuration if the bin because we assumed that the bin will be always static as it is registered. Nonetheless we were wrong, because it is possible to request, with a property, to avoid the use of the post-processor. Since we want to add a way to disable the post-processor through environment variables, this remove feature is required again. If the environment variable GST_VAAPI_DISABLE_VPP is defined the postprocessor inside of the vaapidecodebin is disabled, then vaapidecodebin is an alias of the old vaapidecode. https://bugzilla.gnome.org/show_bug.cgi?id=775041 2016-11-21 18:25:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: implement negotiate() vmethod Instead of decorating the negotiate() method, let us override it, so the stream is locked while called. https://bugzilla.gnome.org/show_bug.cgi?id=775040 2016-11-26 11:27:26 +0000 Tim-Philipp Müller * .gitmodules: common: use https protocol for common submodule https://bugzilla.gnome.org/show_bug.cgi?id=775110 2016-11-24 21:17:54 +0100 Dominique Leuenberger * gst-libs/gst/vaapi/Makefile.am: build: add LIBVA_WAYLAND_CFLAGS to libgstvaapiegl In case libva-wayland has its headers not installed in default locations (like /usr/include), the build fails to include "wayland-client.h": CC libgstvaapi_egl_la-gstvaapiutils_egl.lo In file included from gstvaapidisplay_wayland.h:27:0, from gstvaapidisplay_egl.c:35: /usr/include/va/va_wayland.h:31:28: fatal error: wayland-client.h: No such file or directory #include As we already passed VA_CLAGS, /usr/include/va/va_wayland.h could be found, but it is our fault not to instruct the system that we ALSO care for va_wayland. We correctly query for libva-wayland.pc in configure and use this in other places as well. It is thus only correct and consequent, to do it also at this spot. https://bugzilla.gnome.org/show_bug.cgi?id=773946 2015-10-28 12:55:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: log a message if no bus Raise a warning if there is no bus when the element tries to post a message. 2015-10-28 12:57:14 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: create display at open() Instead of creating the VA display before setting the bus to the element, it is created when the element is opened. Basically, this commit is a revert of 5e5d62cac79754ba60057fc2516135aad8d7de35 That was done when the GStreamer's context sharing was not mature enough as now. There is no reason to keep this hack. 2016-11-04 18:04:36 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't add video crop meta Since the differentiation of negotiation caps and allocation caps, there is no need to add a video crop meta with the negotiation caps. Hence, removing it. https://bugzilla.gnome.org/show_bug.cgi?id=773948 2015-03-19 21:20:26 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: remove the video converter from vaapi buffer meta Since all the video converter were deprecated in gstreamer-1.2, we don't need to handle them anymore in the vaapi's buffer meta. This patch removes its usage and the buffer meta's API for that. https://bugzilla.gnome.org/show_bug.cgi?id=745728 2016-11-21 18:28:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: destroy source pad allocator and pool First, deactivate source pad pool when the out caps change, and if so, destroy texture map, the source pad allocator and pool only if the new caps are different from the ones already set. 2016-11-21 19:17:07 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: don't destroy sink pad allocator Don't destroy sink pad allocator at _set_caps() because it will be done at ensure_sinkpad_buffer_pool() if it is required. 2016-11-21 18:27:00 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: first validate the out caps When calling _set_caps() first validate the out caps before doing anything else. 2016-11-21 18:42:02 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: negotiate after destroying allocator This is related with bug 758907 when no vaapipostproc is used (no vaapidecodebin). In order to negotiate downstream we need to destroy the source pad allocator, otherwise the same allocated buffers are used, failing the mapping. 2016-11-21 16:35:34 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: remove GST_VAAPI_TYPE_VIDEO_INFO Remove redundant GST_VAAPI_TYPE_VIDEO_INFO, since it is a duplicate of GST_TYPE_VIDEO_INFO created before gstreamer 1.6, where the boxed type was created. https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-11-21 12:51:25 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: update the src pad allocator video info Update the size, stride and offset of the source pad allocator video info, so the pool could set the correct GstVideoMeta https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-11-21 12:36:27 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: add missing documentation https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-11-21 12:29:26 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: use early return without goto https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-11-21 11:25:21 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: add allocator to allocation query This patch adds the created allocator to the allocation query either in decide_allocation() and propose_allocation() vmehtods. With it, there's no need to set the modified allocator's size in the pool configuration. https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-10-19 15:15:01 +0100 Julien Isorce * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: set correct buffer size We should set the correct buffer size when we are configuring the pool, otherwise the buffer will be discarded when it returns to the pool. Indeed when the ref-count of a buffer reaches zero, its pool will queue it back (and ref it) if, and only if, the buffer size matches the configured buffer size on the pool. This issue can be debugged with GST_DEBUG=*PERF*:6, see gstbufferpool.c https://bugzilla.gnome.org/show_bug.cgi?id=774782 2016-11-10 13:26:31 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: check for memory allocator When calling gst_vaapi_video_memory_copy() the allocator of the memory to copy should be allocated by the vaapi allocator. This patch does this verification. 2016-11-10 13:25:30 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: code style fixes A cosmetic commit for enhance readability of the casts and method preconditions. 2016-11-09 19:49:22 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: unroll gst_vaapi_video_allocator_free() Instead of having a gst_vaapi_video_memory_free() that is only going to be called by gst_vaapi_video_allocator_free(), let's just remove the first and merged into the second. 2016-11-09 19:29:12 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: avoid virtual methods casting Use the expected virtual method signatures for readability. 2016-11-09 18:58:20 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: remove unimplemented methods Remove unimplemented method for allocator mem_share() and mem_is_span(). 2016-11-09 18:54:47 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: fail if frame map can't get plane If map() vmethod in GstVideMeta cannot get the plane data, return false, thus the caller will not try to read invalid memory. https://bugzilla.gnome.org/show_bug.cgi?id=774213 2016-11-09 18:39:06 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: lock map and unmap operations In order to avoid race condition when two threads call map/unmap the same VA surface, this patch mutex these operations. https://bugzilla.gnome.org/show_bug.cgi?id=774213 2016-11-09 17:37:06 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: refactor vaapi memory unmapping There were duplicated code in gst_video_meta_unmap_vaapi_memory() and gst_vaapi_video_memory_unmap() when unmapping. This patch refactors both methods adding the common function unmap_vaapi_memory(). This also ensures, if direct rendering is enabled, it is correctly reset. Additionally, only when mapping flag has the WRITE bit, it set the image as current, which was done in gst_video_meta_map_vaapi_memory() but no in gst_vaapi_video_memory_map(). In order to make this, the mapping flags were required, so instead of overloading mem_unmap() virtual function, mem_unmap_full() is overloaded. https://bugzilla.gnome.org/show_bug.cgi?id=774213 2016-11-09 13:54:23 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: refactor vaapi memory mapping There were duplicated code in gst_video_meta_map_vaapi_memory() and gst_vaapi_video_memory_map() when doing the READ and WRITE mapping. This patch refactors both methods adding the common function map_vaapi_memory(). Additionally, only when flag has the READ bit it calls ensure_images_is_current(), which was done in gst_video_meta_map_vaapi_memory() but no in gst_vaapi_video_memory_map(). https://bugzilla.gnome.org/show_bug.cgi?id=772151 2016-10-27 18:22:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: unref allowed_sinkpad_caps at close() The variable member allowed_sinkpad_caps is constructed querying the current VA display. Bearing that in mind, the variable shall be freed when the VA display changes or is removed. This patch moves the freeing of allowed_sinkpad_caps to close(), when the VA display is freed. 2016-11-11 11:40:09 +0900 Hyunjun Ko * gst/vaapi/gstvaapisink.c: vaapisink: finish event thread at stop() The thread that handles window's events should be finished during pipeline's shutdown, otherwise it will remain alive during pipeline re-activation, leading to unexpected problems. This patch fixes failures of intensive_state_change scenario of gst-validate https://bugzilla.gnome.org/show_bug.cgi?id=774241 2016-11-08 09:35:00 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: enhance debug message "gst_pad_push" is not a good description of the event. 2016-11-08 10:05:32 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostproc.c: postproc: honor gst_pad_push() return value Returning GST_FLOW_ERROR always when gst_pad_push fails might lead to deadlock during seek. This patch returns the same error of gst_pad_push() and log out the return value. https://bugzilla.gnome.org/show_bug.cgi?id=774030 2016-11-04 16:26:18 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: guard GST_VAAPI_MAKE_GLTEXUPLOAD_CAPS In commit 6d11a00 were introduced a regression when gstreamer-vaapi is compiled with out EGL/GLX support: it shall not support GST_VAAPI_MAKE_GLTEXUPLOAD_CAPS. This patch guards the inclusion of GST_VAAPI_MAKE_GLTEXUPLOAD_CAPS in the allowed src caps for vaapedecode if EGL/GLX. 2016-11-04 12:55:23 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: increment map counter only if succeeded Previously the frame map counter increased independently if the map succeeded or not. This leaded to critical messages and crashes if the frame was unable to be mapped, but the counter increased. This patch increases the map counter only if the map operation occurred. https://bugzilla.gnome.org/show_bug.cgi?id=773939 2016-11-03 17:30:46 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: set negotiation caps in src allocator When the allocator is created, it stores the allocation caps. But sometimes the "allocation caps" may be different from the "negotiation caps". In this case, the allocator should store the negotiation caps since they are the ones used for frame mapping with GstVideoMeta. When vaapispostproc is used, this is not a problem since the element is assume to resize. But when using a vaapi decoder only, with a software renderer, it fails in this case. https://bugzilla.gnome.org/show_bug.cgi?id=773323 2016-07-19 16:40:10 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: generate source pad caps Just as vaapipostproc, VA decoder's context can be queried to get the possible raw formats, so, the src caps can negotiate the exact caps that the context supports. 2016-02-25 18:57:30 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: libs: decoder: add _get_surface_formats() This function exposes the available formats of the surfaces in the the current context to the plugins. 2016-02-18 19:32:58 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: libs: context: ensure context formats This patch ensures to get the formats, as filter does, available in the decoder / encoder context. The context fills up the array as soon it is created, otherwise the pipeline could get stalled (perhaps this is a bug in my HSW backend). https://bugzilla.gnome.org/show_bug.cgi?id=752958 2016-02-18 19:20:10 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiutils_core.c: * gst-libs/gst/vaapi/gstvaapiutils_core.h: libs: move get_surface_formats to utils_core The query of all the supported formats for a VA config were only used by the postprocessor (vaapifilter). But, in order to enable the vaapidecoder to negotiate a suitable raw format with downstream, we need to query these formats against the decoder's config. This patch is the first step: moves the code in filter's ensure_image() to a generic gst_vaapi_get_surface_formats() in vaapiutils_core, so it can be shared later by the decoder. https://bugzilla.gnome.org/show_bug.cgi?id=752958 2016-07-19 18:56:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove set_sinkpad_dmabuf_allocator() Since when the sink pad allocator is created, it is decided if the required one is vaapi allocator or dmabuf allocator, there is no need to force its set again. 2016-10-27 11:25:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: ensure display when getting raw caps When running gst-discoverer-1.0, in certain media, vaapipostroc is stopped meanwhile it is transforming caps. The problem is that stop() calls gst_vaapi_plugin_base_close(), which nullifies the element's va display, but the va display is used in tranform_caps() when it is extracting the possible format conversions. This display disappearing generates warning messages. This patch holds a local reference of va display at ensure_allowed_raw_caps() hence it doesn't go away meanwhile it is used, even if the gst_vaapi_plugin_base_close() is called in other thread. https://bugzilla.gnome.org/show_bug.cgi?id=773593 2016-11-03 12:54:23 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: plugins: fix code style for errors 2016-10-19 19:04:20 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapicodedbuffer.c: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext_overlay.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiparser_frame.c: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: fix code style for errors 2016-11-03 09:31:17 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideocontext.c: plugins: update GstGL deprecated symbol GST_GL_TYPE_CONTEXT was deprecated. Now it is GST_TYPE_GL_CONTEXT. 2016-10-21 11:48:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: direct render when raw video Enable the direct rendering with linear surfaces if the negotiated src caps are video/x-raw without features. Pass also the caps, since they are needed to know the requested caps features. 2016-10-24 20:09:59 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: move src allocator error to instantiator Just as we did in ensure_sinkpad_allocator(), let's move the error message into the ensure_srcpad_allocator() from the caller, gst_vaapi_plugin_base_decide_allocation() 2016-10-20 19:37:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: enable direct upload if raw video Enable the direct upload with linear surfaces if the negotiated sink caps are video/x-raw without features. 2016-10-21 11:21:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: pluginutil: add gst_caps_is_video_raw() 2016-10-24 19:25:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: receive caps in ensure_sinkpad_allocator() Instead of receiving the GstVideoInfo structure as parameter, get the original GstCaps from ensure_sinkpad_buffer_pool(), in this way we could decide better which allocator instantiate. 2016-10-20 19:31:58 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: destroy derived image at unmap If the allocator was configured to use direct upload or rendering, the generated derived image created at mapping needs to be destroyed after unmapping, because, in order to process the surface, it should not be marked as "busy" by the driver. 2016-10-21 11:57:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: enhance logs for direct modes Print, conditionally, only the enabled direct mode. 2016-10-20 17:02:49 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: add direct upload flag Adds the direct-upload flag in the GstVaapiVideoAllocator and GstVaapiVideoMemory. It still doesn't apply any functional change. 2016-10-20 16:49:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: set direct rendering at run-time The way to experiment with the direct rendering is through and internal compiler pre-processor flag. The current change set enables a way to specified at run-time, as a flag passed to the allocator at instanciation time. 2016-10-20 18:09:59 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: log in perf category when copy Log in performance category when the derive image handling fails, falling back to memory copy. 2016-10-20 16:31:21 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: error log is derive image fails Instead of a silently failure of the derive image, this patch log an error message according to the failure. 2016-10-20 12:52:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: store surface alloc flags in qdata For sake of consistency, we should add the requested surface allocation flags to the object's qdata structure. 2016-10-20 12:22:06 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: category init when object define Move the Gstreamer debug category initialize to the GObject definition. 2016-11-03 08:31:16 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexturemap.c: libs: vaapitexturemap: trivial code-style fix 2016-11-02 20:01:09 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: display: egl: avoid recreate native display Instead of passing the native descriptor of the display, just pass the received GstVaapiDisplay and reuse it. 2016-11-02 15:38:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: log the GstVaapiDisplay name Now that GstVaapiDisplay is descendant of GstObject, it has a human-friendly name. Log it instead of the memory address. 2016-11-02 18:37:00 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: libs: window: egl: pass native va display When creating a GstVaapiWindowEGL, it also creates native window by its own native display. It should pass the native display, either X11 or Wayland. https://bugzilla.gnome.org/show_bug.cgi?id=768266 2016-10-13 12:53:17 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: * gst/vaapi/gstvaapivideocontext.c: libs: display: GstVaapiDisplay as GstObject descendant This patch is to change the inheritance of GstVaapiDisplay to GstObject, instead of GstVaapiMiniObject. In this way we can use all the available infrastructure for GObject/GstObject such as GstTracer, GIR, etc. In addition, a new debug category for GstVaapiDisplay is created to make it easier to trace debug messages. It is named "vaapidisplay" and it transverse all the VA display backends (DRM, GLX, EGL, Wayland, ...) This patch is a step forward to expose GstVaapiDisplay for users in a future library. https://bugzilla.gnome.org/show_bug.cgi?id=768266 Signed-off-by: Víctor Manuel Jáquez Leal === release 1.11.0 === 2016-11-01 18:54:54 +0200 Sebastian Dröge * configure.ac: Back to development === release 1.10.0 === 2016-11-01 18:19:32 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.10.0 2016-10-27 17:13:48 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: resurrect disable-vpp property https://bugzilla.gnome.org/show_bug.cgi?id=773589 2016-10-27 16:32:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: name the internal queue https://bugzilla.gnome.org/show_bug.cgi?id=773589 2016-10-27 16:27:45 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: remove unused variables Since vaapipostproc is only registered if the driver supports it, all the support for dynamic loading were removed. Though some leftovers remained. https://bugzilla.gnome.org/show_bug.cgi?id=773589 2016-10-27 12:53:54 +0200 Víctor Manuel Jáquez Leal * docs/plugins/Makefile.am: * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/running.xml: docs: document environment variables https://bugzilla.gnome.org/show_bug.cgi?id=773544 2016-10-27 12:31:49 +0200 Víctor Manuel Jáquez Leal * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins-sections.txt: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodedoc.c: docs: replace vaapidecode with each codec In the spirit of the codec split, this patch removes the documentation of vaapidecode and adds a page per each possible decoder. Nonetheless, only those available in the compilation system are going to be instrospected, because the rest are not registered. 2016-10-27 11:06:06 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideometa.c: docs: add missing long descriptions 2016-10-25 14:32:44 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: use GST_*_OBJECT when possible Since we can have several vaapipostproc operating in a pipeline, it is useful to know which one is generating the logging message. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-07-19 17:00:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: rename member to allowed_sinkpad_caps vaapidecode has a member named allowed_caps, but this name is not enough explicit. This patch renames allowed_caps to allowed_sinkpad_caps. No functional changes were included. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-10-20 18:12:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa_texture.c: plugins: fix code style for errors https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-10-20 17:01:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: comment style https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-10-20 11:19:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: rename input parameter In order to clarify the use of flag as input parameter, it is renamed to surface_alloc_flag, since it is used when creating a VA surface with certain properties. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-10-25 19:22:03 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: rename element description So encoders and decoders have similar descriptions. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-08-02 11:32:19 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: vaapiencode: h264, h265: rename codec name So encoder and decoders have the same codec name. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-07-29 15:17:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: simplify code Merge two lines of variable declarations. https://bugzilla.gnome.org/show_bug.cgi?id=773497 2016-10-07 18:46:22 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: libs: minor correction for logical consistency GstVaapiDecode is a descendant of GstVaapiMiniObject, so, thought we should use its methods, even though it doesn't change functionality. GstVaapiPixmap, GstVaapiTexture and GstVaapiWindow are descendant of GstVaapiObject, hence its methods shall be used. https://bugzilla.gnome.org/show_bug.cgi?id=772554 2016-10-19 15:39:54 +0100 Julien Isorce * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: add explanation about the call 'dup (dmabuf_fd)' In short GstFdMemory is configured to call close when using GstDmabufMemory. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-09-02 16:42:45 +0200 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/Makefile.am: build: clean up the dlopen usage 2016-10-08 14:33:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: h264,h265: fix regression in offset count In commit dc35dafa a bug was introduced because I assumed that GST_CLOCK_TIME_NONE is zero when is -1. This patch fixes that mistake. https://bugzilla.gnome.org/show_bug.cgi?id=772259 2016-10-18 17:02:59 +0200 Víctor Manuel Jáquez Leal * README: docs: update README 2016-09-27 17:29:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: display: egl: remove unused header include The header gmodule.h is not used since the library dynamic loading for EGL display was removed. https://bugzilla.gnome.org/show_bug.cgi?id=772599 === release 1.9.90 === 2016-09-30 13:05:20 +0300 Sebastian Dröge * ChangeLog: * NEWS: * common: * configure.ac: * gstreamer-vaapi.doap: Release 1.9.90 2016-03-04 16:35:11 +0900 Vineeth TM * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: vaapi: use new gst_element_class_add_static_pad_template() https://bugzilla.gnome.org/show_bug.cgi?id=763083 Signed-off-by: Víctor Manuel Jáquez Leal 2016-09-22 16:34:48 +0900 Hyunjun Ko * gst/vaapi/gstvaapipluginbase.c: plugins: reset textures at negotiation/shutdown When caps reconfiguration is called, the new downstream frame size might be different. Thus, if the downstream caps change,the display's texture map is reset. In addition, during pipeline shutdown, textures in texture map have to be released, since each one have a reference to the GstVaapiDisplay object, which is a dangerous circular reference. https://bugzilla.gnome.org/show_bug.cgi?id=769293 Signed-off-by: Víctor Manuel Jáquez Leal 2016-09-22 16:34:38 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst/vaapi/gstvaapivideometa_texture.c: libs: display{egl,glx}: cache GstVaapiTextures instances when created and reuse This patch improves performance when glimagesink uploads a GL texture. It caches the GStVaapiTexture instances in GstVaapiDisplay{GLX,EGL}, using an instance of GstVaapiTextureMap, so our internal texture structure can be found by matching the GL texture id for each frame upload process, avoiding the internal texture structure creation and its following destruction. https://bugzilla.gnome.org/show_bug.cgi?id=769293 Signed-off-by: Víctor Manuel Jáquez Leal 2016-09-22 16:33:06 +0900 Hyunjun Ko * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapitexturemap.c: * gst-libs/gst/vaapi/gstvaapitexturemap.h: libs: vaapitexturemap: implement GstVaapiTextureMap Implement GstVaapiTextureMap object, which caches VAAPI textures, so them can be reused. Internally it is a hash table. Note that it is GstObject based rather than GstVaapiObject, as part of the future converstion to GstObject of most of the code. https://bugzilla.gnome.org/show_bug.cgi?id=769293 Signed-off-by: Víctor Manuel Jáquez Leal 2016-09-21 09:55:53 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: encoder: vp8: Increase the allocation size for coded buffer We are not getting enough compression for some streams and encoded frame end up with more size than allocated. Assuming a compression ratio of 4, which should be good enough for holding the frames. https://bugzilla.gnome.org/show_bug.cgi?id=771528 2016-09-21 09:52:21 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: encoder: vp9: Fix refresh frame flag setting While doing the mode-1 referece picture selection, the circular buffer logic was not correctly setting the refresh frame flags as per VP9 spec. Make sure refresh_flag[0] get updated correclty after each cycle of GST_VP9_REF_FRAMES. https://bugzilla.gnome.org/show_bug.cgi?id=771507 2016-09-14 18:42:09 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: vaapidecode: codec_data minimal size is 7 When the format of a H.264 stream is AVC3, the SPS and PPS are inside the stream, not in the codec_data, so the size of codec_data might be 7. This patch reduces the minimal size of the codec_data buffer from 8 to 7. https://bugzilla.gnome.org/show_bug.cgi?id=771441 2016-09-14 16:29:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: reset decoder hard when set_format() set_format() is called by upstream when the stream capabilites has changed. Before, if the new stream is compatible with the old one the VA decoder was not destroyed. Nonetheless, with this behavoir, the VA decoder ignores when the upstreamer parsers gets more details of the stream, such as the framerate. Hence, when the src caps are negotiates, the further sink caps updates are ignored. This patch forces the VA decoder destroying and recreation when set_format() is called. https://bugzilla.gnome.org/show_bug.cgi?id=770921 2016-09-14 11:31:39 +0200 Sebastian Dröge * configure.ac: configure: Depend on gstreamer 1.9.2.1 2016-09-09 12:03:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: Revert "vaapivideomemory: load VA Image when mapping to write" This reverts commit c67edea4aba35f16d9e97c78a0b49ad1b590b112. 2016-09-10 20:52:21 +1000 Jan Schmidt * common: Automatic update of common submodule From b18d820 to f980fd9 2016-09-10 09:58:25 +1000 Jan Schmidt * common: Automatic update of common submodule From f49c55e to b18d820 2016-09-08 16:16:09 +0900 Hyunjun Ko * gst/vaapi/gstvaapipluginbase.c: plugins: set allocator's image size to sinkpad bufferpool Otherwise the buffer is always ditched by the bufferpool, losing performance. https://bugzilla.gnome.org/show_bug.cgi?id=771035 2016-09-07 17:34:08 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: libs: surface: ensure composite overlay is not bigger Ensure the composition overlay rectangle (subtitles) is not bigger than the surface where it is going to be composited and rendered. https://bugzilla.gnome.org/show_bug.cgi?id=766978 2016-09-07 17:51:23 +0900 Hyunjun Ko * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: load VA Image when mapping to write When calling gst_video_frame_map() with GST_MAP_WRITE flag, it doesn't call ensure_image_is_current(), which means it doesn't guarentee VAImage is valid in this case. https://bugzilla.gnome.org/show_bug.cgi?id=766978 2016-09-06 12:27:45 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: merge vc1 and wmv3 elements This patch merges vaapivc1dec and vaapiwmv3dec into a single vaapivc1dec. Also, removed the WMVA format, since it is not supported by libva. https://bugzilla.gnome.org/show_bug.cgi?id=734093 2016-09-06 11:19:05 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: vc1: fails only on advanced profile In commit 2eb4394 the frame coding mode was verified for progressive regardless the profile. But the FCM is only valid in the advanced profile. This patch checks for the advanced profile before verifying FCM for progressive. https://bugzilla.gnome.org/show_bug.cgi?id=769250 2016-09-01 12:39:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: DISPLAY envvar as dependency In a multiple video cards system, a X11 environment may have different VA capabilities. This patch tracks the DISPLAY environment variable to invalidates the GStreamer features cache. Also tracks WAYLAND_DISPLAY. https://bugzilla.gnome.org/show_bug.cgi?id=770357 2016-08-26 14:55:17 -0700 Scott D Phillips * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: vc1: Fail only on actual interlaced frames In the earlier patch: f31d9f3 decoder: vc1: Print error on interlaced content Decoding would error out if the interlace flag was set in the sequence bdu. This isn't quite right because a video can have this flag set and yet not have any interlaced pictures. Here instead we error out when either parsing a field bdu or decoding a frame bdu which has fcm set to anything other than progressive. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=769250 2016-09-01 12:34:48 +0300 Sebastian Dröge * configure.ac: Back to development === release 1.9.2 === 2016-09-01 12:34:38 +0300 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.9.2 2016-08-16 11:58:38 +0300 Scott D Phillips * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: vc1: Print error on interlaced content Interlaced video is as yet unsupported in the vc1 element. Print an error to make that more obvious. https://bugzilla.gnome.org/show_bug.cgi?id=769250 2016-08-10 13:29:45 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix C90 mixed declarations and code Commit 4259d1a introduced this compilation error. This patch fixes it. 2016-07-21 17:38:40 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: encoder: h264,h265,mpeg2,vp8: use gst_util_uint64_scale() for bitrate Use gst_util_uint64_scale() to calculate bitrate instead of normal arithmetic to avoid overflows, underflows and loss of precision. https://bugzilla.gnome.org/show_bug.cgi?id=768458 2016-07-05 20:07:15 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: vaapiencode: h264,h265: validate fps numerator Validate that fps numerator is non-zero so it can be used to calculate the duration of the B frame. Also it gst_util_uint64_scale() is used instead of normal arithmetic in order to aviod overflows, underflows and loss of precision. https://bugzilla.gnome.org/show_bug.cgi?id=768458 2016-08-06 12:54:17 +0100 Tim-Philipp Müller * gst/vaapi/gstvaapi.c: encoders: demote to RANK_NONE since not fit for autoplugging yet Encoders claim to support a whole bunch of input formats but then just error out if the format is not actually supported, even if there's a converter in front. This means they're not fit for autoplugging in encodebin or camerabin yet and therefore should not have a rank. People can still use them in custom pipelines. https://bugzilla.gnome.org/show_bug.cgi?id=769266 2016-07-19 19:24:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: check dmabuf-import for sink pad allocator Check earlier if upstream video source has activated the dmabuf-import io-mode (hack to disappear soon), thus we can avoid the re-assignation of a new allocator. 2016-07-19 20:02:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: reset allocators if video info changed If the frame size or format, change, the allocators are reset, so a new ones can be created with the new video info. 2016-07-19 19:27:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove sink pad allocator if caps change If the negotiated sinkpad caps change, destroy the assignated allocator, because it is not valid anymore. 2016-07-19 20:01:05 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: pluginutil: const params to gst_video_info_changed() Since they are not modified, we should mark them as const. 2016-07-29 15:13:29 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: gstvaapivideomemory: allocator's image size getter Add the method gst_allocator_get_vaapi_image_size() for the GstVaapiVideoAllocator, which gets the size of the allocated images with the current video info. This method replaces the direct call to the allocator's image info when the pool is configured. 2016-07-29 18:06:30 +0900 Hyunjun Ko * gst/vaapi/gstvaapipluginbase.c: plugins: update buffer pool size with new allocator's image size Depends on media, video size is sometimes updated with new allocator. It leads to dismatch between bufferpool's set size and real allocated buffer size. In this case, it causes every buffer is freed during release in bufferpool, which should be reused. This affects performance. https://bugzilla.gnome.org/show_bug.cgi?id=769248 2016-07-27 19:49:59 +0200 Víctor Manuel Jáquez Leal * configure.ac: configure: remove gmodule-2.0 EGL dependency Since commit 27429ce, EGL support doesn't depend on dynamic loading libraries, thus the dependency to gmodule-2.0 is not mandatory anymore. 2016-07-27 10:09:38 -0700 Scott D Phillips * configure.ac: configure: Fix non-fatal PKG_CHECK_MODULES invocations Some invocations of PKG_CHECK_MODULES were intended to be non-fatal if the package is missing, but action-if-not-found was given as an empty string which still causes the default action to run, which halts execution. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=769237 2016-07-13 18:34:57 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: libs: egl: remove dynamic library loading code Since the upstream of gstreamer-vaapi, the library is not a public shared object anymore. But the EGL support depended on this dynamic library, so the EGL support was broken. This patch removes the dynamic library loading code and instantiates the EGL display using either X11 or Wayland if available. https://bugzilla.gnome.org/show_bug.cgi?id=767203 2016-07-12 23:47:41 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: register only the available decoders In order to register only the available decoders, this patch queries the created test VA display, which uses the currently used back-end (X11, Wayland, DRM, …) on the used display device. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-06-28 11:43:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapi: register only the available encoders In order to register only the available encoders, this patch queries the created test VA display, which uses the currently used back-end (X11, Wayland, DRM, …) on the used display device. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-06-07 16:28:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: vaapidecode: split all the codecs Split the vaapidecode to all the supported codecs with the format vaapi{codec}dec. vaapidecode is stil registered as a GObject type, but not as a GStreamer feature, so it can be used internally by vaapidecodebin without changing its code too much. https://bugzilla.gnome.org/show_bug.cgi?id=734093 2016-07-12 22:19:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: simplify the code Since the elements dependant of the VA video processor are now only registered if it is available, vaapidecodebin code can be simplified a lot, removing all the code required to check if the VA video processor was available. https://bugzilla.gnome.org/show_bug.cgi?id=768899 2016-07-12 17:54:26 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: delay the GstVaapiDisplay instantiating Delay the GstVaapiDisplay instantiating until when changing the state from READY to PAUSE. In this way the element has more chances to find an already created GstVaapiDisplay, or a GL context, in the pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=766206 2016-07-12 17:49:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: pluginutil: set GLX display type The function gst_vaapi_create_display_from_gl_context() cretes a GstVaapiDisplay given a GstGLContext. But it didn't created a GLX VA display when the GL platform was GLX, but a plain X11 VA display. This patch fixes that, by querying the GL platform earlier. https://bugzilla.gnome.org/show_bug.cgi?id=766206 2016-06-02 19:57:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: plugins: add gst_vaapi_plugin_base_find_gl_context() Using the GstContext mechanism, it is possible to find if the pipeline shares a GstGLContext, even if we are not to negotiating GLTextureUpload meta. This is interesting because we could negotiate system memory caps feature, but enable DMABuf if the GstGLContext is EGL with some extensions. https://bugzilla.gnome.org/show_bug.cgi?id=766206 2016-06-28 17:14:06 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: remove gst_vaapi_plugin_base_driver_is_whitelisted() Since nobody is calling gst_vaapi_plugin_base_driver_is_whitelisted(), it is deleted. 2016-07-12 18:24:10 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.h: plugins: remove common change_state() vmethod Remove the common change_state() vmethod for all the plugins, since no one is using it. 2016-07-12 20:38:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove change_state() vmethod Since the driver checkup is done at registering, there is no need to do it when changing the element state from NULL to READY. This patch remove this vmethod from vaapidecode. 2016-07-12 20:29:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: register vaapipostproc only if supported Query the GstVaapiDisplay to know if the driver supports video postprocessing. If does, then register vaapipostproc and vaapidecodebin elements. This patch will simplify the design of vaapidecodebin. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-06-29 12:36:26 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: don't register if VA driver is unsupported Using the test VA display, the driver name is queried, and if it is not white-listed, the plugin rejects to register any element. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-06-28 17:14:06 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: add gst_vaapi_driver_is_whitelisted() Move some of the logic in gst_vaapi_plugin_base_driver_is_whitelisted() to a new function gst_vaapi_driver_is_whitelisted(), in this way, it can be used when registering the plugin's feature set with the test VA display. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-07-12 19:56:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: instantiate a VA display when registering This patch tries to instantiate a GstVaapiDisplay when registering the plugin features, if it fails, no gstreamer-vaapi element is registering. The purpose of this patch is to avoid a situation where the user has gstreamer-vaapi installed but their VA-API setup is not functional, which may lead to unexpected behavior. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-06-28 11:33:18 +0200 Víctor Manuel Jáquez Leal * configure.ac: * gst/vaapi/gstvaapi.c: vaapi: declare external dependencies There are two main external dependencies that define the feature set of this plugin: a) the kernel and b) the VA driver This patch tracks both dependencies, if any of them change, GStreamer will re-inspect the plugin. The kernel is tracked through the device files /dev/dri/card* The VA driver is tracked through the files VA_DRIVERS_PATH/*_drv_video.so, where VA_DRIVERS_PATH is the one defined in libva package configuration. Also, the environment variables LIBVA_DRIVERS_PATH and LIBVA_DRIVER_NAME are tracked since they modify the driver lookup. Additionally, the environment variable GST_VAAPI_ALL_DRIVERS is tracked too. https://bugzilla.gnome.org/show_bug.cgi?id=724352 2016-07-19 16:02:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove unneeded initializations GObject's memory is set to zero, so there is no need to initialize to zero or NULL it's class variables. 2016-07-19 18:28:28 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.h: plugins: remove undefined macros 2016-07-19 17:43:28 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: Revert "gstvaapisurface_drm: release image when done" This reverts commit 1dbcc8a0e199f2da6a0ab8e949f13341916128a3 and commit 372a03a9e38acbf435eb80bf31d9a9844069e504. While the dmabuf handle is exported, the derive image must exist, otherwise the image's VA buffer is invalid, thus the dmabuf handle is never released, leading into a file descriptors leak. 2016-07-21 17:38:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: h265: fix code-style 2016-07-22 16:55:59 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: update filters at color balance This is a fix for a regression of previous commit, which updates the filters only when the property is set, because it is also required to update the filter when the color balance interface change its values. 2016-07-22 12:10:23 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: make it enable/disable pass-through mode In case that sink caps and src caps are same, and no filtering parameter set, pass-through mode is enabled. If new filtering parameter is set during playback, it makes it reconfiguring, so that pass-through mode is changed In addition, updating filter is performed during reconfiguration, if needed. https://bugzilla.gnome.org/show_bug.cgi?id=751876 2016-07-22 11:51:26 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: checking and updating filter parameter only when it's set This patch is to avoid checking filter value at every frame. https://bugzilla.gnome.org/show_bug.cgi?id=751876 2016-07-21 11:24:31 +0300 Allen Zhang * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: h265: handle the SEI NAL units included in codec_data The prefix/suffix SEI nal units can appear in codec_data too which weren't handled before. Parse these SEI headers to fix the segfault. https://bugzilla.gnome.org/show_bug.cgi?id=768544 2016-07-15 16:32:26 +0200 Víctor Manuel Jáquez Leal * docs/plugins/Makefile.am: build: doc: do not redefine MAINTAINERCLEANFILES MAINTAINERCLEANFILES is defined in gtk-doc-plugins.mak, thus instead of overload it, the files should be added. 2016-07-15 14:41:27 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Fix MVC encode while enabling dct8x8 Pack the transform_8x8_mode_flag and other necessary rbsp data in packed_pps header for MVC encode. https://bugzilla.gnome.org/show_bug.cgi?id=768647 2016-07-12 23:58:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: demote a debug message to trace Reduces noise when debugging. 2016-07-13 17:21:01 +0900 Jagyum Koo * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: Error check before using cached wl_display A planar(or some other) buffer allocation may fail on the driver, then the wayland connection becomes invalid, not able to send request or receive any event. So we need to set up a new wayland connection if there's an error detected on the cached wl_display. https://bugzilla.gnome.org/show_bug.cgi?id=768761 Signed-off-by: Víctor Manuel Jáquez Leal 2016-07-11 21:15:57 +0200 Stefan Sauer * common: Automatic update of common submodule From ac2f647 to f49c55e 2016-07-05 18:23:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: demote a log to trace level Removes noise when debugging. 2016-07-06 11:17:23 +0900 Hyunjun Ko * gst/vaapi/gstvaapiencode.c: vaapiencode: implement flush() vmethod In order to handle correctly seek and other operations, vaapiencode should flush all the remaining data from the encoder without pushing it downstream. This patch implements the flush() vmethod, only after of pausing the source pad task, and restarting it again after the flush stop. https://bugzilla.gnome.org/show_bug.cgi?id=767176 Signed-off-by: Víctor Manuel Jáquez Leal 2016-07-11 08:43:04 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: vc1: flush dpb only if opened Flush the decode picture buffer, if and only if, the decoder is started. Otherwise the dpb structure might be NULL. https://bugzilla.gnome.org/show_bug.cgi?id=742922 2016-07-01 14:42:20 +0900 Hyunjun Ko * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: drop non-keyframe in reverse playback To avoid surface-exhausted situation during reverse playback, drop frames except for key frame. Also, to avoid the corruption of the parser state, flush() vmethod doesn't destroy the VA decoder when playing in reverse. https://bugzilla.gnome.org/show_bug.cgi?id=742922 Signed-off-by: Víctor Manuel Jáquez Leal 2016-07-10 19:33:14 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: unref output frame earlier The queue in GstVaapiDecode adds an extra reference to the frames. This patch unref that extra reference earlier making the code simpler to follow. https://bugzilla.gnome.org/show_bug.cgi?id=768652 2016-07-10 19:01:17 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove gst_vaapidecode_internal_flush() As gst_vaapidecode_finish() is the only callee of gst_vaapidecode_internal_flush(), it is better to inline it. https://bugzilla.gnome.org/show_bug.cgi?id=768652 2016-07-10 18:18:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: flush output adapter at drain() Calling drain() vmethod means "decode any data it can at this point, but that more data may arrive after". Hence, vaapidecode should check if there is data in the output adapter and process them, without destroying the decoded picture buffer (dpb). Since this operation is done by gst_vaapidecode_internal_flush(), the operation was refactored into a new function gst_vaapidecode_flush_output_adapter(). https://bugzilla.gnome.org/show_bug.cgi?id=768652 2016-07-10 13:46:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: call purge at flush() Calling flush() vmethod means "to flush all remaining data from the decoder without pushing it downstream". Nonetheless flush() is calling gst_vaapidecode_internal_flush(), which calls gst_video_decoder_have_frame() if there is still something in the input adapter, which may push buffers to downstream by calling handle_frame(). This patch changes this behavior by calling gst_vaapidecode_purge() rather than gst_vaapidecode_internal_flush(), which does what we want: flushes the VA decoder and releases all the rest of decoded frames. https://bugzilla.gnome.org/show_bug.cgi?id=768652 2016-07-06 18:38:37 +0200 Víctor Manuel Jáquez Leal * tests/elements/Makefile.am: * tests/elements/test-vaapisink.c: test: elements: remove spurious linkage Element tests only need to link against gstreamer libraries. 2016-07-06 14:41:21 +0300 Sebastian Dröge * configure.ac: configure: Require GLib >= 2.40 like everywhere else 2016-07-06 13:51:21 +0300 Sebastian Dröge * configure.ac: Back to development === release 1.9.1 === 2016-07-06 13:48:07 +0300 Sebastian Dröge * ChangeLog: * NEWS: * common: * configure.ac: * gstreamer-vaapi.doap: Release 1.9.1 2016-07-05 20:59:49 +0200 Víctor Manuel Jáquez Leal * tests/elements/test-vaapisink.c: tests: elements: rotate orientation event 2016-07-01 16:01:54 +0900 Hyunjun Ko * configure.ac: * tests/Makefile.am: * tests/elements/Makefile.am: * tests/elements/test-vaapisink.c: tests: elements: Add testsuite for vaapisink https://bugzilla.gnome.org/show_bug.cgi?id=765798 2016-07-01 16:00:46 +0900 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add support for GST_TAG_IMAGE_ORIENTATION https://bugzilla.gnome.org/show_bug.cgi?id=765798 2016-06-29 13:57:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: return caps template if no display This patch is a fix for my bad review of commit 6d73ca8d. The element should be able to return the available raw caps handled by the VA display, but that only should happen when there a VA display. If there's none, the element should use the caps template. https://bugzilla.gnome.org/show_bug.cgi?id=768161 2016-06-29 16:42:18 +1000 Matthew Waters * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't require a vaapi display for all caps queries This delays the requirement of having a GstVaapiDisplay until later https://bugzilla.gnome.org/show_bug.cgi?id=768161 2016-06-28 15:48:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils.c: utils: report VP9 profiles Add VP9Profile0-3 name mapping. 2016-06-28 14:05:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: nest includes under USE_ENCODER macro This is a missed changeset from commit 1c05c53, since also header includes should be nested. 2016-06-28 11:54:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: nest encoders under USE_ENCODER macro Though USE_{JPEG,VP8,VP9,H265}_ENCODER macros definition depend on USE_ENCODER macro, it is clearer to nest them, showing explicitly the dependency relation. 2016-06-24 12:05:24 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: check if query context is NULL Under certain conditions the element might receive a positive context query but without a context instance. This situation will lead to a segmentation fault when traversing the context list in the pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=767946 2016-06-20 13:22:36 -0700 Scott D Phillips * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/sysdeps.h: remove unused glibcompat.h glibcompat.h is no longer doing anything. Remove it. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=767886 2016-06-22 14:28:44 -0700 Scott D Phillips * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Use high profile by default Change defaults for max-bframes, cabac, and dct8x8 to be enabled by default. This will cause the default profile to be high instead of baseline. In most situations this is the right decision, and the profile can still be lowered in the case of caps restrictions. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=757941 2016-06-22 12:15:29 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: element warning if missing element Raise an element warning if a required element is not available, thus the pipeline will post a warning message and the application will be informed. 2016-06-22 15:11:56 +0300 Hyunjun Ko * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: h265: fix to release all dpb pictures Without this, all dpb pictures are not released during flush, because we used the global dpb_count variable for checking the dpb fullness which get decremented in dpb_remove_index() routine during each loop iteration. https://bugzilla.gnome.org/show_bug.cgi?id=767934 2016-06-21 11:48:54 -0400 Nicolas Dufresne * common: Automatic update of common submodule From ac2f647 to f363b32 2016-06-20 19:53:26 +0900 Hyunjun Ko * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipostproc.c: vaapi: fix minor leaks https://bugzilla.gnome.org/show_bug.cgi?id=767868 2016-06-17 17:00:03 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: vaapi: remove an already included header gst/gst.h is already included in gstcompat.h 2016-06-17 16:53:26 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: add vp9 in sink pad template 2016-06-15 20:19:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: return caps template if no display If vaapisink received a caps query before getting a VA display, it returned only the surfaces related caps. This behavior broke the autovideosink negotiation. This patch returns the pad's template caps if no VA display, otherwise the caps are crafted as before. https://bugzilla.gnome.org/show_bug.cgi?id=767699 2016-06-15 11:25:23 -0700 Scott D Phillips * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Update comment about context resets Clarify that vaapi context resets are never needed for vp9, but that ensure_context() needs called when the size increases so that new surfaces can be allocated. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=767474 2016-05-17 15:34:23 -0700 Scott D Phillips * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: gstvaapicontext: control reset_on_resize with option Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=767474 2016-06-14 09:45:22 -0700 Scott D Phillips * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: add video meta to config when needed In cases where we know the video meta must be present, add it to the pool configuration. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=766184 2016-06-13 10:48:41 -0700 Scott D Phillips * gst/vaapi/gstvaapipluginbase.c: plugins: retry pool config if gst_buffer_pool_set_config returns FALSE, check the modified config and retry set_config if the config is still acceptable. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=766184 2016-06-08 18:42:43 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: internal attributes to methods Mark as internal the functions used by VA-API dmabuf allocator. 2016-06-02 15:41:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove precondition for decide_allocation() There's no need to check for the display in the plugin object when decide_allocation() vmethod is called, because the display will created or re-created along the method execution. 2016-06-08 18:44:34 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: avoid possible memory leaks Get the pool config just before use it, to avoid a memory leak if the allocator cannot be instantiated. Similarly, return FALSE if the configuration cannot be set, avoid keep a not used allocator in the pool. 2016-05-31 11:52:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: use GstParentBufferMeta Instead of using the VASurface proxy's notify, which is internal gstvaapi API, use the GStreamer's GstParentBufferMeta. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-31 08:26:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: cache VASurfaces from dmabufs This patch avoids the creation of a VASurface each time a new input buffer is processed, caching them in the input buffer itself. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-30 23:55:43 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: * gst/vaapi/gstvaapipluginbase.c: libs: change gst_vaapi_surface_new_with_dma_buf_handle() Instead of passing the data already in GstVideoInfo, let's just pass the GstVideoInfo structure. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-25 12:31:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: use an unique allocator per pad Instead of instantiating an allocator per vaapivideobufferpool, only one allocator is instantiated per element's pad and shared among future pools. If the pad's caps changes, the allocator is reset. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-25 10:58:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: vaapivideobufferpool: share options flag with pluginbase Originally, vaapivideobufferpool has a set of boolean variables for the buffer configuration options. This pach changes these boolean variables for a single bitwise, just as it is used in pluginbase. Hence, the internal enum was moved to vaapivideobufferpool header. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-10 15:57:06 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: add gst_vaapi_plugin_base_create_pool() This patch refactors the code in pluginbase in order to centralize the buffer pool instantiation. As the buffer pool config may have different options, these are gathered using a bitwise flag. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-20 18:46:14 +0200 Víctor Manuel Jáquez Leal pluginbase negotiates allocator with bufferpool Originally vaapivideobufferpool instantiates its own allocator regardless the received configuration, and it relies in custom configuration options to choose which kind of allocator instantiate. This patch transfers the responsibility of the allocator instantiate to vaapipluginbase and pass it to the vaapivideobufferpool through its configuration. * gst/vaapi/gstvaapipluginbase.c + set_dmabuf_allocator(): inserts a dmabuf allocator in the bufferpool + ensure_sinkpad_buffer_pool(): set a normal vaapi video allocator in bufferpool configuration + gst_vaapi_plugin_base_propose_allocation(): call set_dmabuf_allocator() if needed. + gst_vaapi_plugin_base_decide_allocation(): set a normal vaapi video allocator in bufferpool configuration * gst/vaapi/gstvaapivideobufferpool.c + gst_vaapi_video_buffer_pool_set_config(): instead of instantiate the allocator, process the received one through its configuration. * gst/vaapi/gstvaapivideobufferpool.h: removed GST_BUFFER_POOL_OPTION_DMABUF_MEMORY since it is not used anymore. * gst/vaapi/gstvaapivideomemory.c + gst_vaapi_is_dmabuf_allocator(): new helper function to identify a dmabuf allocator with the vaapi qdata. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-20 14:39:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: keep only current video info Instead of keeping old and new GstVideoInfo video structure, we only keep one, the current one, the negotiated. The old one is not needed at all. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-23 15:38:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapivideomemory.c: pluginutil: add gst_video_info_force_nv12_if_encoded() This lines repeat a couple times in the code, so it would be better to put it a helper function. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-05-20 14:15:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapivideobufferpool.c: pluginutil: add gst_video_info_changed() helper This function is shared among different elements, so let factorized it. https://bugzilla.gnome.org/show_bug.cgi?id=765435 2016-06-08 10:14:16 +0900 Hyunjun Ko * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: Add colorimetry attributes to src caps https://bugzilla.gnome.org/show_bug.cgi?id=766596 2016-06-08 10:17:46 +0900 Hyunjun Ko * gst/vaapi/gstvaapidecode.c: vaapidecode: remove chroma-site and colorimetry from src caps https://bugzilla.gnome.org/show_bug.cgi?id=766596 2016-06-07 14:19:50 -0700 Scott D Phillips * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add postproc_lock to protect data members Add a mutex to postproc to protect concurrent access to data members. Previously set_caps() could release the allowed_srcpad_caps while transform_caps was in the middle of using it. Signed-off-by: Scott D Phillips https://bugzilla.gnome.org/show_bug.cgi?id=766940 2016-05-30 11:30:40 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: encoder: vp9: Add simple algorithms for reference picture selection Added two modes(as properties) for reference picture selection: ref-mode-0: AltRef and GoldRef pointing to the recent keyframe and LastRef is pointing to the previous frame. ref-mode-1: Previous frame (n) as LastRef , n-1 th frame as GoldRef and n-2 th frame as AltRef https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-30 11:25:52 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: encoder: vp9: Define Max frame width and height https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-30 11:25:03 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: encoder: vp9: Add more propertis for tuning encode quality Added three tuning properties: 1: filter_level 2: sharpness_level 3: luma ac quant-table index https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-30 11:24:14 +0300 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_vp9.c: * gst/vaapi/gstvaapiencode_vp9.h: Add vp9 encode element to "vaapi" plugin https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-30 11:23:12 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp9.h: Add vp9 encoder support in libgstvaapi https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-30 11:22:35 +0300 Sreerenj Balachandran * configure.ac: build: Add check for VP9 encode API support in libva https://bugzilla.gnome.org/show_bug.cgi?id=766048 2016-05-26 11:42:32 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: gstvaapisurface_drm: fix internal documentation 2016-05-26 11:41:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: gstvaapisurface_drm: fix code-style 2016-05-25 12:28:48 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove unused header Remove the include of gst/allocators/allocators.h since it is not used. 2016-05-25 10:36:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.h: vaapivideobufferpool: remove GL_TEXTURE_UPLOAD_META Since gstreamer-vaapi is coupled with gstreamer releases, there is no need to keep compatibility definition. This patch removes the definition of GST_BUFFER_POOL_OPTION_VIDEO_GL_TEXTURE_UPLOAD_META since it is in gst-plugins-base version 1.2.2 2016-05-23 22:49:11 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: add gst_vaapi_buffer_pool_caps_is_equal() This is a helper function to improve the readability of ensure_sinkpad_buffer_pool(). It makes clearer when the buffer pool needs to be re-instantiated. 2016-05-24 16:29:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: deactivate buffer pool before unref This buffer pool may still be processing buffers when a caps renegotiation is done. This one-liner patch deactivates the pool to drain it before it de-allocation. 2016-05-24 16:22:24 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: no sinkpad bufferpool when decoder Right now, the decoders create a buffer pool for their sink pad which is not used at all, because the decoders have never proposed it to upstream. This patch avoids the buffer pool instantiating when the element inherits from the GstVideoDecoder class. 2016-05-24 13:39:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: avoid to get/set pool config twice This patch is a bit of optimization, since the bufferpool configuration is get when the pool is created. Hence, we only need to request it when the pool from the allocation query is reused. 2016-05-13 13:14:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: destroy pool earlier if non-vaapi If the offered pool in decide_allocation() vmethod doesn't have the VAAPI_VIDEO_META option, it is destroyed immediatly and the pointer cleared, so it could be created later. 2016-05-23 22:30:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: split caps validation When validating the caps from bufferpool config, this patch distinguishes the error from no caps received (NULL) from the invalid caps (cannot be converted into GstVideoInfo structure). 2016-05-23 22:21:15 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: plugins: check for caps in query earlier Check for caps as soon gst_query_parse_allocation() returns. 2016-05-23 23:13:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: remove unused variables This variables stopped to be used since commit 001a5c63, which removed the gstvaapiuploader. 2016-05-23 18:47:46 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: fix potential memleak from commit 9159328 If gst_video_info_from_caps() fails it is required to unref the instantiated pool. 2016-05-23 18:04:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: handle if gst_video_info_from_caps() fails Return FALSE is the received caps cannot be transformed into a GstVideoInfo structure. 2016-05-23 17:55:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: handle if gst_video_info_from_caps() fails Let's play safe and return error if, somehow, the received caps are wrong. 2016-05-23 17:47:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: relate errors to instance Use GST_{ERROR,WARNING}_OBJECT instead of GST_{ERROR,WARNING}, thus the logs will show the name of the vaapipluginbase instance that failed. Also, the code-style is fixed, where some error labels need to be surrounded by braces. 2016-05-20 21:01:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: plugins: use GstVideoInfo accessors Instead of access to GstVideInfo members directly, use their accessors macros. This patch makes more resistance to future changes in GStreamer core. 2016-05-20 19:33:39 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipostproc.c: * tests/simple-encoder.c: remove spurious gst_video_info_init() gst_video_info_set_format() and gst_video_info_from_caps() call, internally, gst_video_info_init(), hence it is not required to call it before them. This patch removes these spurious calls. 2016-05-20 19:15:11 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: code-style: rename goto label The error labels have error_ prefix, but this one. 2016-05-19 16:34:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: use allocator custom alloc flag Instead of a dummy alloc() vmethod, the allocator instance set the flag GST_ALLOCATOR_FLAG_CUSTOM_ALLOC, which is used by the framework to avoid call gst_allocator_alloc() on the allocator. 2016-05-06 13:17:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideobufferpool.c: vaapivideobufferpool: relate errors to instance Use GST_ERROR_OBJECT instead of GST_ERROR, thus the logs will show the name of the vaapivideobufferpool instance that failed. 2016-05-10 16:14:48 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove gst_vaapi_plugin_base_set_pool_config() This function helper make sense for GStreamer 1.2, but it is not helpful for greater version since the validation is already done in the API implementation. Thus, it is removed. 2016-05-18 17:05:03 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapipluginbase.c: gstvaapipluginbase: Fix typo in doc 2016-05-13 11:45:20 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder : h264: Disable b-frame encode in low-power mode This is a workaround since vaapi-intel-driver doesn't have support for B-frame encode when utilizing low-power-enc hardware block. Fixme :We should query the VAConfigAttribEncMaxRefFrames instead of blindly disabling b-frame support and set b/p frame count, buffer pool size etc based on the query result. https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-13 11:44:57 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: encoder: h264 : Use "tune=low-power" for enabling lowpower encode Remove the duplicate property "low-power-enc" and use the tune property for enabling low power encoding mode. https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-11 12:06:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder:Use internal api to dervie configured VAEntrypoint https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-11 12:05:36 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: encoder: h264: Add support of low power/high performance encoding mode Added a new property "low-power-enc" for enabling low power encoding mode. Certain encoding tools may not be available with the VAEntrypointEncSliceLP. https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-11 12:04:46 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapivalue.c: Add mapping for Macroblock level rate control (VA_RC_MB) 2016-05-11 12:03:08 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidisplay.c: gstvaapidisplay: Add VAEntrypointEncSliceLP support https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-11 11:59:59 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: gstvaapiprofile : Add VAEntrypointEncSliceLP definitions This is for implementations that supports low_power/high_performance variant for slice level encode. https://bugzilla.gnome.org/show_bug.cgi?id=766050 2016-05-05 18:23:10 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: negotiate frame size fixation Refactor _fixate_frame_size(). Now, instead of fixating the frame size only using the sink caps, also it use the next capsfilter. This code is a shameless copy of gst_video_scale_fixate_caps() from https://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst/videoscale/gstvideoscale.c?id=1.8.1#n634 https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-06 10:50:10 +0200 Scott D Phillips * gst/vaapi/gstvaapipostprocutil.c: vaapipostproc: don't use GstVideoInfo for src caps Instead of using gst_video_info_to_caps () to generated the fixed src caps, this patch enables the first step for caps negotiation with a possible following caps filter. _get_preferred_caps() will traverse the possible src caps looking for the one wit the preferred feature and the preferred color format. Then the color format, the frame size and the frame rate are fixated. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-05 15:32:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostprocutil.c: * gst/vaapi/gstvaapipostprocutil.h: vaapipostproc: move gst_vaapipostproc_fixate_srccaps() Move gst_vaapipostproc_fixate_srccaps() to gstvaapiposptprocutil. No functional changes. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-05 15:19:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: simplify code Change a convoluted snippet to find the preferred color format in the peer caps. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-05 15:16:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: use othercaps for preferred caps Instead of the allowed_srcpad_caps variable, this patch uses the othercaps from fixate_caps() vmethod to find the preferred caps feature and color format. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-05 13:46:11 +0200 Scott D Phillips * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add fixate_caps() vmethod Instead of fixating the srcpad caps in transform_caps() vmethod, this patch implements the fixate_caps() vmethod and moves code around. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-05-05 12:07:59 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostprocutil.c: * gst/vaapi/gstvaapipostprocutil.h: vaapipostproc: set early properties restrictions When running transform_caps() vmethod, returning the srcpad caps, the caps are early restricted to the element properties set: width, height, format and force keep aspect. A new file was added gstvaapipostprocutil.{c,h} where the utilities functions are stored. https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-04-25 13:45:04 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: log the caps transformation https://bugzilla.gnome.org/show_bug.cgi?id=758548 2016-04-27 21:20:32 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: no GLTextureUpload in sinkpad As the vaapipostproc does not process frames with the VideoGLTextureUpload meta, the feature is removed from the sink pad template. https://bugzilla.gnome.org/show_bug.cgi?id=765931 2015-09-28 08:49:39 +0100 Julien Isorce * gst/vaapi/gstvaapivideobufferpool.c: vaapibufferpool: do not create texture upload meta if dmabuf https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-05-06 12:16:26 +0200 Víctor Manuel Jáquez Leal * git.mk: build: update git.mk 2016-04-29 13:11:48 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.h: plugin: fix macro processor check Instead of #ifdef it should be used #if becasuse USE_GST_GL_HELPERS is always defined in config.h, but it would be 0 or 1 depending on the configure output. https://bugzilla.gnome.org/show_bug.cgi?id=765702 2016-04-29 12:53:06 +0200 Víctor Manuel Jáquez Leal * tests/test-display.c: tests: display: guard possible unused variables https://bugzilla.gnome.org/show_bug.cgi?id=765702 2016-04-29 12:48:44 +0200 Víctor Manuel Jáquez Leal * tests/codec.c: * tests/decoder.c: * tests/image.c: * tests/output.c: * tests/simple-decoder.c: * tests/test-decode.c: * tests/test-display.c: * tests/test-filter.c: * tests/test-h264.c: * tests/test-jpeg.c: * tests/test-mpeg2.c: * tests/test-mpeg4.c: * tests/test-subpicture-data.c: * tests/test-subpicture.c: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-windows.c: tests: inforce gstreamer code-style 2016-04-27 17:10:26 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: h265: Enable cu_qp_delta_enabled_flag for CBR It seems driver requires enablement of cu_qp_delta_enabled_flag for modifying QP values to controll the CBR mode bitrate. https://bugzilla.gnome.org/show_bug.cgi?id=749852 2016-04-27 17:06:09 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: h265: Add CBR Encoding support https://bugzilla.gnome.org/show_bug.cgi?id=749852 2015-11-27 05:09:10 +0000 Julien Isorce * gst-libs/gst/vaapi/gstvaapisurface.c: gstvaapisurface: explicitely clear TILING flag if dmabuf https://bugzilla.gnome.org/show_bug.cgi?id=755072 2015-10-04 23:44:16 +0100 Julien Isorce * gst-libs/gst/vaapi/gstvaapisurface_drm.c: gstvaapisurface_drm: release image when done Otherwise intel-vaapi-driver will fail to process the exported surface because it will find it is currently derived, so considered as busy. https://bugzilla.gnome.org/show_bug.cgi?id=755072 2015-09-26 06:25:12 +0100 Julien Isorce * gst/vaapi/gstvaapipostproc.c: vaapipostproc: already have a surface proxy if dmabuf https://bugzilla.gnome.org/show_bug.cgi?id=755072 2016-03-11 08:58:51 +0000 Julien Isorce * gst/vaapi/gstvaapipostproc.c: various gst-indent 2016-04-21 15:14:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: vaapidecode: search driver in whitelist If the backend driver vendor string is not in a white-list, and the environment variable GST_VAAPI_ALL_DRIVERS is not set either, the decoder will change it state from NULL to READY, hence the auto-plug mechanism will look for another decoder. This patch assumes the GstContext has already being shared along the pipeline and the element has a valid GstVaapiDisplay instance. https://bugzilla.gnome.org/show_bug.cgi?id=764673 2016-04-21 12:57:30 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: rework set_context() vmethod definition In bug 757598 was added the set_context() vmethod chain up in GstVaapiPluginBase. But it is buggy, since the parent_class address is assigned to the last element which called gst_vaapi_plugin_base_class_init(). No error has shown up since none of the element's base classes redefined set_context() vmethod from GstElement, so always the correct function was called. Still this code is wrong and this patch make it right. Since set_context() is the same code, a macro is used to implement that code in all the gst-vaapi elements. https://bugzilla.gnome.org/show_bug.cgi?id=765368 2016-04-15 17:57:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: resize if negotiated and allocation caps are different Since commit 859a2b2, in vaapidecode, allocation query can be different from the negotiated caps. When connecting the vaapidecoder to the vaapipostprocessor, the last one will resize the frame to the negotiated, if and only if, some other parameter is activated to avoid the passthrough. If it is not, the surface won't be mapped into a image. If not, the image won't be resized and the output buffer would be mapped. This patch will break the passthrough if the allocation query is different from the negotiation caps, forcing the resizing. https://bugzilla.gnome.org/show_bug.cgi?id=765095 2016-04-05 13:09:37 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: improve code readability No functional changes. 2016-04-05 13:37:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: move GstCapsFeatures near to its use Move the handling of the GstCapsFeatures just after it is used, in order to avoid handling its memory. 2016-04-05 13:07:14 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: caps negotiation checks Check that GLUploadTexture is not negotatiated if gstreamer-vaapi is not compiled with GL support. 2016-03-10 16:43:16 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: plugins: remove param in gst_vaapi_plugin_base_decide_allocation() 2016-03-10 16:42:04 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: bail early if not caps in decide_allocation() 2016-03-29 14:17:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: plugin: use allowed caps filter from element Instead of using the srcpad template caps for filtering the peer caps, the function gst_vaapi_find_preferred_caps_feature(), now receives a new parameter for the element's allowed caps. With this modification, the vaapipostproc element simplifies a bit its code. https://bugzilla.gnome.org/show_bug.cgi?id=765223 2016-04-18 17:28:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: plugin: remove function parameter The native format parameter in gst_vaapi_find_preferred_caps_feature() can be saved if the out format is used for both: in and out. Thus the code is more readable. https://bugzilla.gnome.org/show_bug.cgi?id=765223 2016-04-18 17:17:58 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: warns if driver will do color conversions If the downstream feature is system memory, the surface has to be mapped, hence a warning message is logged saying that the driver has to do color conversions. This might be troublesome because not all the color conversion combinations are supported by the VA-API drivers, and there is not a reliable way to know them before hand. https://bugzilla.gnome.org/show_bug.cgi?id=765223 2016-03-29 13:28:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugin: honour negotiated format Instead of setting the requested format by the caller, the function gst_vaapi_find_preferred_caps_feature() now returns, in the output parameter, the negotiated format. A new helper function was added: gst_vaapi_find_preferred_format(), which, given the format list from the negotiated caps, will choose the best one, if possible, given the native format. https://bugzilla.gnome.org/show_bug.cgi?id=765223 2016-03-28 19:26:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugin: simplify caps feature selection This patch simplifies the function gst_vaapi_find_preferred_caps_feature(). Instead of intersecting custom caps to find the preferred feature, the peer caps are traversed in order to find the preferred feature, according to an ordered feature priority list. In the case of GLTextureUploadMeta, the colour format is computed using GstVideoInfo of the selected fixed caps. https://bugzilla.gnome.org/show_bug.cgi?id=765223 2016-03-31 16:39:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: use macros for GstVideoInfo Instead of accessing directly to the members of the structure, use the macros. 2016-04-14 17:02:23 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: refactor is_display_resolution_changed() Make the comparisons more readable and simple. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 16:43:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: keep only display_{width,height} Instead of keeping the structure GstVideoInfo when we are using its width and height, we only keep these two guints. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 16:31:34 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: decoded_info is valid at src caps update As decoded_info is assured to be valid when gst_vaapidecode_update_src_caps() is called, then we don't need to verify or replace it with the sinkpad info (reference state). https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 16:22:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: always a valid format in decoded_info Always set a valid format in decoded_info class variable. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-03-25 15:31:28 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: code style fixes No functional changes. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 16:10:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: init {decoded,display}_info at open() It is required to initialize {decoded,display}_info variables when the decoder is open, not only at instance initialization. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-03-28 15:30:28 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: remove spurious class variables active, do_pool_renego and do_outstate_renego class variables were used to indicate when negotiate downstream once, but now that each time a new surface resolution is pop out a renegotation verified, these variable are not required anymore. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 15:46:32 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: remove custom allocation query When resolving bug 753914, a custom allocation query was added, overlapping the responsibilities of GstVideoDecoder. But with the merge of the patches from bug 764421 this overlapping was not required anymore. This patch restores this situation setting the allocation_caps in the GstVideoCodecState when needed. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-04-14 10:04:47 +0100 Julien Isorce * common: Automatic update of common submodule From 6f2d209 to ac2f647 2016-04-13 15:44:20 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipostproc.c: plugins: disable GL_TEXTURE_UPLOAD if no EGL/GLX The plugins should not expose the feature meta:GstVideoGLTextureUploadMeta in their caps templates if they were not compiled either with GLX or EGL support. 2016-04-13 20:33:32 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: fix compilation when EGL/GLX is disabled The compiler might complain of gst_vaapi_create_display_from_handle() being unused if both EGL and GLX are disabled. This patch avoid that compilation error. 2016-04-13 14:09:00 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: libs: fix deleting a GstVaapiCodedBufferPool object Call gst_vaapi_video_pool_finalize() in coded_buffer_pool_finalize(). Otherwise it is not called when the pool is destroyed and all objects referenced by the GstVaapiVideoPool are never released. https://bugzilla.gnome.org/show_bug.cgi?id=764993 2016-04-07 18:03:42 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapisurface.c: surface: destroy derived image If gst_vaapi_image_new_with_image() fails, the created derived image should be destroyed, otherwise the surface cannot be processed because is being used. https://bugzilla.gnome.org/show_bug.cgi?id=764607 2016-03-18 20:00:52 -0300 Thiago Santos * gst/vaapi/gstvaapidecode.c: vaapidecode: add stop function Clear any status on the current stream: stored frames, caps and decoder configuration https://bugzilla.gnome.org/show_bug.cgi?id=763460 2016-04-01 14:00:28 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Align with the ABI changes in vp9 codecparser The subsampling_x, subsampling_y, bit_depth, color_space and color_range fileds are moved from GstVp9FrameHdr to the global GstVp9Parser structure. These fields are only present in keyframe or intra-only frame, no need to duplicate them for inter-frames. https://bugzilla.gnome.org/show_bug.cgi?id=764082 2016-04-01 13:59:59 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9 : Add 10bit decoding support (Profile2) https://bugzilla.gnome.org/show_bug.cgi?id=764082 2016-04-01 13:57:45 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: gstvaapiporfile: Add more VP9 profile definitions https://bugzilla.gnome.org/show_bug.cgi?id=764082 2016-02-03 20:34:49 +0100 Víctor Manuel Jáquez Leal * Makefile.am: * configure.ac: build: possibility to disable tests The configuration option --disable-examples will disable the compilation of the sample apps in tests/ directory. 2016-03-29 14:25:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: unify caps template for VAAPI encoders and decoders There is no difference in VAAPI surface caps between encoders and decoders. Thus, the patch makes a simplification by removing encoders specific caps and shares the same definition of VAAPI surfaces caps for all the elements. 2016-03-10 17:42:55 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: move gst_vaapidecode_negotiate() code With it we can remove a function declaration, making the code a bit more readable. https://bugzilla.gnome.org/show_bug.cgi?id=764316 2016-03-29 13:50:00 +0200 Víctor Manuel Jáquez Leal * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins-sections.txt: * gst/vaapi/gstvaapidecode.c: docs: generate vaapijpegdec documentation https://bugzilla.gnome.org/show_bug.cgi?id=764314 2016-03-30 14:37:21 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: h265: Fix offset calculation when there is more than one vps/sps/pps present in codec_data The array_completeness, reserved bit and num_nal_units fields in HEVCDecoderConfigurationRecord will be present for each VPS/SPS/PPS array list, but not for each occurance of similar headers. https://bugzilla.gnome.org/show_bug.cgi?id=764274 2016-03-29 15:34:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/video-format.c: video-format: Keep the HW order preference while mapping to GstVideoFormats 2016-03-29 15:02:46 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapivideomemory.c: gst/vaapi: keep precedence for NV12 over I420 Use NV12 as default "assumption" format all over. NV12 is the default high priority format used my most of the vaapi-drivers. 2016-03-29 14:34:37 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Use video format derived from decoded surface as default src pad format Use the surface format derived from first decoded surface to negotiate the downstream video format capabilities. https://bugzilla.gnome.org/show_bug.cgi?id=759181 2016-03-29 14:34:00 +0300 Scott D Phillips * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: Add P010 video format support The P010 video format is the native format used by the vaapi intel driver for HEVCMain10 decode . Add support for planes and images of this video format. https://bugzilla.gnome.org/show_bug.cgi?id=759181 2016-03-27 09:11:00 +0000 Stephen * gst-libs/gst/vaapi/gstvaapiutils_x11.c: libs: x11: allows 30-bit colour depth The colour depth is clamped to 24 when it is not equal {15,16,24,32}. But this fails with the NVIDIA binary driver as it doesn't advertise a TrueColor visual with a depth of 24 (only 30 and 32). Allowing the depth to be 30, lets everything work as expected. https://bugzilla.gnome.org/show_bug.cgi?id=764256 2016-03-28 13:13:56 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideometa_texture.c: gltextureupload: use an array for texture type Instead of using a single value for the texture type, use an array with 4 elements, just as the GstVideoGLTextureUploadMeta, avoiding a buffer overflow. https://bugzilla.gnome.org/show_bug.cgi?id=764231 2016-03-24 15:09:43 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: vaapidecode: Fix decide_allocation handling Set the already configured pool in decide_allocation query in cases where pool renegotiation is not required. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2016-03-24 15:09:15 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Derive and save the decoded surface format After the decoding of first frame, try to extract the exact decoded surface format using vaDeriveImage and keep this as the format in decoded_info. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2016-03-24 15:08:50 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: Make vaapidecode to advertise the cropped values in srcpad, but negotiate pool only if needed -- Maintaing decoded surface resoluton and actual display resoultion separately -- Before pushing every frames downstream, check for the requirement of pool negoation and output_state negotiation: This is needed to avoid multiple issuses with cropping, multi-resoluton video handling, more complex multi resolution decode scenarios for vp9decode, possible wrong behaviour from upstream element to report uncropped values etc. Due to these reasons, We can't just reliably use the resolution change notification from libgstvaapi for pool renegotiation too. This is slight overhead, but safe enough. Optimization could be possible though. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2016-03-24 15:08:27 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Delay the output format setting until we have a decoded surface This will help to consoidate the out caps negotiation to a single place, which will make the code simpler, allows to get the exact decoded format if needed and the selected chroma type too. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2016-03-24 13:36:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.h: vaapidecode: GST_VAAPIDECODE macro is a cast This patch is the continuation of commit 1e1d3b1d because the function gst_vaapidecode_get_type() got undefined since then. Now, the macro GST_VAAPIDECODE is a simple cast to the GstVaapiDecode structure. The rest of the GObject handling macros were deleted too. 2016-03-24 13:34:18 +0200 Sebastian Dröge * configure.ac: Back to development === release 1.8.0 === 2016-03-24 13:11:05 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.8.0 === release 1.7.91 === 2016-03-15 12:39:20 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.7.91 2016-03-11 17:44:07 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: h265: Fix offset calculation in codec_data parsing https://bugzilla.gnome.org/show_bug.cgi?id=762922 2016-03-09 20:26:31 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: don't handle jpeg decoding As JPEG decoder has been split and demoted, it cannot be handled by vaapidecodebin Added a fixme comment regarding the future removal of vaapidecode. https://bugzilla.gnome.org/show_bug.cgi?id=734093 2016-03-09 20:25:08 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: split out jpeg decoder Split, as a different element, the JPEG decoder. https://bugzilla.gnome.org/show_bug.cgi?id=734093 2016-03-09 18:41:49 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: register decoder with internal GType Don't expose the the vaapidecode GType, instead expose a function which will register element. This is the first step to split the decoder by codecs. https://bugzilla.gnome.org/show_bug.cgi?id=734093 2016-03-10 12:47:49 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove unused function declaration There is no need to pre-declare gst_vaapidecode_update_sink_caps(). And fixed code-style of the other pre-declared functions. 2016-03-09 18:58:13 +0100 Víctor Manuel Jáquez Leal * docs/plugins/Makefile.am: build: git ignore gtkdoc generated files 2016-03-09 18:55:39 +0100 Víctor Manuel Jáquez Leal * m4/Makefile.am: build: handle git ignore in m4 directory 2016-03-04 20:17:54 -0300 Thiago Santos * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: vaapidecoder_h265: plug leak of h265 parsing info If something goes wrong while parsing, the info object is being leaked https://bugzilla.gnome.org/show_bug.cgi?id=763121 2016-03-04 20:17:20 -0300 Thiago Santos * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: vaapidecoder_h264: plug leak of h264 parsing info If something goes wrong while parsing, the info object is being leaked https://bugzilla.gnome.org/show_bug.cgi?id=763121 2016-03-09 11:03:28 +0900 Vineeth TM * gst/vaapi/gstvaapipluginutil.c: plugins: fix gstgl and vaapi memory leaks 1\ Unref gl_display and gl_window as soon they are not needed. 2\ Remove an unneeded display type check, since is handled by gst_vaapi_created_display_from_handle() 3\ Unref vaapi's display if the display cannot be bind to a GL API. Modified-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=763354 2016-03-09 14:13:24 +0900 Vineeth TM * gst-libs/gst/vaapi/gstvaapidisplay.c: vaapidisplay: Fix uninitialized value error for VA attribute https://bugzilla.gnome.org/show_bug.cgi?id=763362 2016-03-08 10:47:56 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: plugins: proxy information from downstream caps Propagate to upstream the downstream information, such as fps, par, etc. This will fix several "getcaps" critical warnings in gst-validate. https://bugzilla.gnome.org/show_bug.cgi?id=763300 2016-03-04 10:51:42 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Assign values for profile and bit_depth from frame header bit_depth field has added only in VA-API 0.39.0, added version check. 2016-03-04 09:12:13 +0200 Sebastian Dröge * Makefile.am: build: Dist gstreamer-vaapi.doap and configure.ac/autogen.sh https://bugzilla.gnome.org/show_bug.cgi?id=763067 === release 1.7.90 === 2016-03-01 19:23:51 +0200 Sebastian Dröge * ChangeLog: * NEWS: * configure.ac: * gstreamer-vaapi.doap: Release 1.7.90 2016-03-01 16:14:47 +0200 Sebastian Dröge * configure.ac: configure: Use AG_GST_SET_PACKAGE_RELEASE_DATETIME_WITH_NANO to set release date 2016-03-01 11:35:49 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: intersect with filter in getcaps() In commit 6034734d I forgot to add the caps filter intersection in the getcaps() vmethod generating a regression when a capsfilter is set in the pipeline. This commit adds the caps filter intersection. 2016-02-29 11:55:27 +0200 Lim Siew Hoon * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: Add memset to initialize value for VAEncSliceParameterBufferJPEG https://bugzilla.gnome.org/show_bug.cgi?id=762850 2016-02-26 12:42:46 +0200 Sebastian Dröge * common: Automatic update of common submodule From b64f03f to 6f2d209 2016-02-24 12:36:33 +0100 Víctor Manuel Jáquez Leal * Makefile.am: * configure.ac: * m4/Makefile.am: build: add m4 directory Instead of rely on the automatic creation of m4 directory by aclocal, we already control it. Later we could create our own m4 scripts in order to unclutter configure.ac https://bugzilla.gnome.org/show_bug.cgi?id=762528 2016-02-23 10:55:02 +0200 Scott D Phillips * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fill dependent slice segment headers while parsing Copy the data into the dependent slice segment header from the corresponding independent slice segment header during parsing. Previously the reference to the "previous" independent header was held through the parsing phase and then dereferenced during the decoding phase. This caused all dependent headers to be populated with the data of the AU's last independent header instead of the proper corresponding header. https://bugzilla.gnome.org/show_bug.cgi?id=762352 Changes since v1: - Reworded commit message 2016-02-17 13:43:48 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: use video decoder getcaps() The usage of getcaps() vmethod is preferred than to handle manually the sink's caps query. In order to avoid function declarations, this patch moves the class_init() method to the end of the file. 2016-02-17 12:51:45 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: remove deprecated code Since we are only supporting current GStreamer version, since 1.3 gst_buffer_pool_config_add_option() checks if the option to add is already set. There is no need to do it ourselves. 2016-02-19 19:03:44 -0300 Thiago Santos * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: vaapidecoder_h265: fix parsing of NALU aligned data Don't assume the whole buffer is a single NAL, instead look for the next start code in case there are multiple NALs per buffer. https://bugzilla.gnome.org/show_bug.cgi?id=762328 2016-02-19 11:10:25 -0300 Thiago Santos * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: vaapidecoder_h264: fix parsing of NALU aligned data Don't assume the whole buffer is a single NAL, instead look for the next start code in case there are multiple NALs per buffer. https://bugzilla.gnome.org/show_bug.cgi?id=762328 2016-02-18 10:13:53 +0900 Vineeth TM * gst/vaapi/gstvaapisink.c: vaapisink: Fix event,pad,structure memory leaks https://bugzilla.gnome.org/show_bug.cgi?id=762229 2016-02-17 15:40:54 +0200 Lim Siew Hoon * gst/vaapi/gstvaapipluginbase.c: Add icamerasrc as dmabuf capable peer element icamerasrc is another gstreamer plugin using to capture RAW frames from camera device. It is based on libcamhal library. There are some properties available to control icamera behavior. Signed-off-by: Lim Siew Hoon Tested & Reviewed: Zhu Haiyang https://bugzilla.gnome.org/show_bug.cgi?id=759481 Fixme: This is the similar workaround we done for v4l2src. The workaround will be removed once we fix #755072 2016-02-17 17:15:28 +0900 Vineeth TM * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: Fix structure memory leak config structure is not being freed in all cases https://bugzilla.gnome.org/show_bug.cgi?id=762172 2016-02-17 17:20:08 +0900 Vineeth TM * gst/vaapi/gstvaapidecode.c: vaapidecode: Fix videocodec state memory leak When state is not NULL and either width/height of video info is 0, then state leaks https://bugzilla.gnome.org/show_bug.cgi?id=762173 2016-02-16 15:44:48 +0000 Tim-Philipp Müller * gst/vaapi/gstvaapisink.c: vaapisink: post message for application for unhandled keyboard/mouse events Makes (most) keyboard shortcuts work in gst-play-1.0 when the video window has focus. 2016-02-16 08:48:43 +0900 Vineeth TM * gst/vaapi/gstvaapidecode.c: vaapidecode: Fix capsfeature memory leak https://bugzilla.gnome.org/show_bug.cgi?id=762116 2016-02-16 08:15:40 +0900 Vineeth TM * gst/vaapi/gstvaapisink.c: vaapisink: Fix capsfeature memory leak caps feature allocated is not being freeing in some cases https://bugzilla.gnome.org/show_bug.cgi?id=762111 2016-02-16 15:09:01 +0200 Sebastian Dröge * configure.ac: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipluginutil.c: vaapi: Fix various compiler warnings and disable -Wredundant-decls for now 2016-02-16 14:36:39 +0200 Sebastian Dröge * configure.ac: configure: Fix setting of extra compiler warning flags 2016-02-15 18:00:49 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapibufferproxy.c: libs: fix build error gst_vaapi_buffer_proxy_{acquire_handle,release_handle,finalize,class} functions are used only when libva's API version is greater than 0.36.0 This patch guards those functions completely rather than just their content. The patch is a continuation of commit 38f8fea4 Original-patch-by: Vineeth TM https://bugzilla.gnome.org/show_bug.cgi?id=762055 2016-02-15 10:01:54 +0900 Vineeth TM * tests/simple-encoder.c: tests: simple-encoder: fix build error argument mismatch of gsize with 'long unsigned int' https://bugzilla.gnome.org/show_bug.cgi?id=762055 2016-02-04 10:16:00 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: Fix wrong caps advertising The get_caps() should only report the supported formats. https://bugzilla.gnome.org/show_bug.cgi?id=761147 2016-02-05 18:11:29 -0300 Thiago Santos * common: Automatic update of common submodule From e97c9bb to b64f03f 2016-02-03 19:07:40 +0100 Víctor Manuel Jáquez Leal * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins-sections.txt: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: rename encoders to vaapi{codec}enc Trying to comply with GStreamer's element names, this patch renames the encoders using the name format vaapi{codec}enc. In this way, the plugin documentation is linked correctly. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 18:42:36 +0100 Víctor Manuel Jáquez Leal * configure.ac: Use new AG_GST_ARG_ENABLE_EXTRA_CHECKS #define Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 18:02:21 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: remove vp9 parser check Since the VP9 parser was added in gst-plugins-bad 1.7.1 we can remove safely the check of the parser, as we did for the others. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 17:06:48 +0100 Víctor Manuel Jáquez Leal * common: * configure.ac: Back to development Signed-off-by: Víctor Manuel Jáquez Leal === release 1.6.0 === 2016-02-03 16:53:41 +0100 Víctor Manuel Jáquez Leal * configure.ac: Release 1.6.0 2016-02-03 16:45:18 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: libs: fix compiler warnings After setting the release flags, the compiler warns about a couple initialized variables. Also marked a couple of set variables as unused, because they are only used for assertion. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 20:41:27 +0100 Víctor Manuel Jáquez Leal * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins-sections.txt: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: docs: update plugin documentation Update all the documentation of elements of the vaapi plugin. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 15:39:09 +0100 Víctor Manuel Jáquez Leal * Makefile.am: * configure.ac: * docs/Makefile.am: * docs/plugins/Makefile.am: * docs/plugins/gstreamer-vaapi-plugins-docs.xml.in: * docs/plugins/gstreamer-vaapi-plugins.types: * docs/reference/Makefile.am: * docs/reference/plugins/Makefile.am: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: * docs/version.entities.in: resurrect gtk-doc machinery Our auto-generated documentation has been a bit neglected. This patch replaces the 'normal' gtk-doc with the one used in GStreamer, which is adapted for plugins, elements and libraries. This patch also re-enables documentation generation. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 19:35:24 +0100 Víctor Manuel Jáquez Leal * ChangeLog: * Makefile.am: * autogen.sh: * configure.ac: use gst-common submodule This is 'the' big change in gstreamer-vaapi autoconf. Now it uses the official GStreamer common submodule. The documentation generation has been disable temporarily since it needs a major rework, which will be done in the following commit. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-25 16:06:03 +0100 Víctor Manuel Jáquez Leal * .gitmodules: * common: add gst-common submodule Pointing to branch 1.6 Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 13:28:30 +0100 Víctor Manuel Jáquez Leal * gstreamer-vaapi.doap: add doap descriptor DOAP (Description of a Project) is an RDF Schema and XML vocabulary to describe software projects, in particular free and open source software. The description is used in GStreamer as in many other open source projects. This patch adds the doap description of this project. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 11:50:13 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiparser_frame.c: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: libs: humongous code style fix As part of the upstreaming process of gstreamer-vaapi into the GStreamer umbrella, we need to comply with the project's code style. This meant to change a lot of code. It was decided to use a single massive patch to update the code style. I would like to apologize with the original developers of this code because of the history breakage. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 11:04:15 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst/vaapi/gstvaapivideomemory.c: libs: small refactors to enhance the code style As gst-indent generated ugly code in these cases, this patch changes the used idiomatic into other one. No functional changes were introduced. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-02 17:59:57 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: * gst-libs/gst/vaapi/gstvaapicodedbufferproxy.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: libs: small code style fixes This a set of small code style fixes detected as-is by gst-indent. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-02 17:50:19 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: libs: trivial comment style fixes Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-02 17:31:02 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicodedbuffer.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: libs: avoid gst-indent mess up Guard pieces of code to avoid gst-ident to mess up the following code. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-03 12:17:59 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideomemory.c: plugins: fix code style Minor code style changes by executing gst-indent in gst/vaapi directory. Signed-off-by: Víctor Manuel Jáquez Leal 2016-02-01 13:22:10 +0000 Tim-Philipp Müller * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: Fix some more compiler warning Two (false) compiler warnings about variables potentially being used uninitialized, and one about a variable being set but not used. https://bugzilla.gnome.org/show_bug.cgi?id=759192 2016-02-01 13:02:13 +0000 Tim-Philipp Müller * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * tests/simple-encoder.c: * tests/test-filter.c: vaapi: fix 'ISO C90 forbids mixed declarations and code' compiler warnings Declare variables at the beginning of a code block, which is how it's done in GStreamer. https://bugzilla.gnome.org/show_bug.cgi?id=759192 2016-01-28 14:21:04 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fix crop rectangle setting Align with software vp9dec behaviour: Add crop rectangle only if display_width/display_height is less than the frame_hdr->width/frame_hdr->height 2016-01-27 08:56:45 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Fix renegotiation for resolution change Always renegotiate the pool if the immediate frame which going to be pushed has a different un-cropped resolution than the already configured one. 2016-01-29 15:51:49 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.h: plugins: use the same pre-processor macro In gstvaapipluginbase.c we are using the macro USE_GST_GL_HELPERS to guard the code related with GstGL. Nonetheless, in gstvaapipluginbase.h we are using HAVE_GST_GL_GL_H macro in order to include the GstGLContext's header. We should use only one to be homogeneous. This patch sets USE_GST_GL_HELPERS in the header file. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 18:06:29 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: update a deprecated function Somehow this didn't show up earlier, but gst_adapter_prev_timestamp() got deprecated since GStreamer 1.0. This patch replace it with gst_adapter_prev_pts() Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 13:13:56 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: honor configure's cache The user might enable --config-cache when calling configure script. If so, our configuration variables will not be correctly calculated. This patch extracts the value of our variables either from the cache or from the operation result. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 19:12:13 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: use common version variables Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 19:01:43 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: hard-code an unneeded macro That macro is required for EGL's dynamic module loading, but since gstreamer-vaapi doesn't creates dynamic modules, it is not required anymore. That code in gst-libs/gst/vaapi/gstvaapidisplay_egl.c should be removed. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 17:14:51 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: refactorization of dependency tracking This patch tries to avoid branching in configure.ac using a more functional approach in macros usage. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 12:34:30 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: check for OpenGL either GLX or EGL are requested Refactor some code in configure.ac to centralize $enable_opengl definition. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 16:55:44 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: indent and add square braces Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 16:50:39 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: upgrade autotools version dependency Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 11:14:34 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: enhance string comparisons Add a 'x' as a prefix in string comparisons to watch out for edge cases where the string is empty or undefined. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-28 14:29:16 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: remove unused variables Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 19:00:51 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: remove check for old version of gstreamer Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 17:55:02 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: remove GStreamer's parsers checks This patch removes almost all the parsers check since they are already in place, with the exception of the VP9 parser, since it was merged in Gstreamer 1.7. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-29 12:11:17 +0100 Víctor Manuel Jáquez Leal * configure.ac: * gst/vaapi/Makefile.am: build: add gstreamer-pbutils dependency This dependency was added in gstvaapidecodebin with the call gst_missing_element_message_new(). Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 17:53:59 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: fix variable declaration Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 17:47:32 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: build: fix when HEVC decoder is disabled This a very pathological situation: when we have a HEVC encoder but not a HEVC decoder. The encoder needs functions that are only available when the decoder is enabled. This patch moves the utils functions into the generic sources, such as the rest of the utils. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 17:20:31 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: build: remove unused EGL specific sources These Makefile variables are not used at all. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-27 17:19:32 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: build: remove check for GStreamer 1.2 Since we are working for current stable GStreamer 1.6 Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-26 11:49:40 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiparse.h: Remove more video parser crufts This header is not used anymore since it declares parsers that are already in GStreamer 1.6 Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-25 12:43:15 +0000 Tim-Philipp Müller * configure.ac: * docs/reference/Makefile.am: * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-overrides.txt: * docs/reference/libs/libs-sections.txt: docs: remove library documentation which is non-public now https://bugzilla.gnome.org/show_bug.cgi?id=759192 2016-01-25 12:40:49 +0000 Tim-Philipp Müller * Makefile.am: * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/changelog.in: * debian.upstream/compat: * debian.upstream/control.in: * debian.upstream/copyright: * debian.upstream/gstreamer-vaapi-doc.install.in: * debian.upstream/gstreamer-vaapi.install.in: * debian.upstream/rules: Remove debian.upstream packaging https://bugzilla.gnome.org/show_bug.cgi?id=759192 2016-01-22 19:27:13 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: Remove old gst version guards As gstreamer-vaapi now only supports from GStreamer 1.6, this patch removes all the old GStreamer version guards. Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-22 19:23:43 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiparse.c: Remove video parser crufts We forgot to remove gstvaapiparse.c when we removed all the videoparser machinery. Signed-off-by: Víctor Manuel Jáquez Leal 2015-12-09 19:52:33 +0100 Víctor Manuel Jáquez Leal * docs/reference/libs/Makefile.am: * docs/reference/plugins/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: * tests/Makefile.am: libs: remove versioning Since we don't install libraries anymore, it makes no sense to keep versioning them according to the gstreamer's version. Signed-off-by: Víctor Manuel Jáquez Leal 2015-12-09 16:59:16 +0100 Víctor Manuel Jáquez Leal * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: * debian.upstream/libgstvaapi-dev.install.in: * debian.upstream/libgstvaapi-drm.install.in: * debian.upstream/libgstvaapi-glx.install.in: * debian.upstream/libgstvaapi-wayland.install.in: * debian.upstream/libgstvaapi-x11.install.in: * debian.upstream/libgstvaapi.install.in: * gst-libs/gst/vaapi/Makefile.am: * tests/Makefile.am: libs: make libraries no installables Signed-off-by: Víctor Manuel Jáquez Leal 2015-12-09 15:37:39 +0100 Víctor Manuel Jáquez Leal * debian.upstream/libgstvaapi-dev.install.in: * gst-libs/gst/vaapi/Makefile.am: Do not install libgstvaapi headers Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-19 10:40:54 +0200 Sreerenj Balachandran * Makefile.am: * configure.ac: * patches/Makefile.am: * patches/videoparsers/0001-plugins-compile-the-built-in-video-parsers-as-vaapip.patch: * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: * patches/videoparsers/0003-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: * patches/videoparsers/0004-h264parse-Disable-3D-video-support-for-GStreamer-1.5.patch: * patches/videoparsers/0005-videoparsers-h264-Disable-passthorugh-mode-enabling.patch: * patches/videoparsers/0006-h265parse-include-gstvaapiparse.h.patch: * patches/videoparsers/0007-h265parse-fix-build-with-GStreamer-1.5.patch: * patches/videoparsers/Makefile.am: * patches/videoparsers/series.frag: Remove videoparser patches 2015-12-09 15:18:11 +0100 Víctor Manuel Jáquez Leal * Makefile.am: * configure.ac: * debian.upstream/libgstvaapi-dev.install.in: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-drm.pc.in: * pkgconfig/gstreamer-vaapi-glx.pc.in: * pkgconfig/gstreamer-vaapi-wayland.pc.in: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: Remove pkg-config files Signed-off-by: Víctor Manuel Jáquez Leal 2015-12-09 13:24:30 +0100 Víctor Manuel Jáquez Leal * .gitmodules: * Makefile.am: * configure.ac: * ext/Makefile.am: * ext/codecparsers: * gst-libs/gst/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: Remove codecparsers submodule Signed-off-by: Víctor Manuel Jáquez Leal 2015-12-08 00:36:36 +0200 Sreerenj Balachandran * .gitmodules: * autogen.sh: * configure.ac: * debian.upstream/libgstvaapi.install.in: * ext/Makefile.am: * ext/libvpx/Makefile.am: * ext/libvpx/gstlibvpx.c: * ext/libvpx/gstlibvpx.h: * ext/libvpx/libgstcodecparsers_vpx.vers: * ext/libvpx/sources.frag: * ext/libvpx/upstream: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/codecparsers/gstvaapilibvpx.c: Remove libvpx submodule We will be using upstream codecparsers always. No more internal libvpx ! 2015-12-09 14:12:22 +0100 Víctor Manuel Jáquez Leal * configure.ac: build: fix check for GstJpegParser Right now the local JPEG parser is always compiled because the check for the upstreamed version is broken: it looks for an non existent symbol: GstJpegImage. This patch changes that check for< GstJpegFrameHdr. Signed-off-by: Víctor Manuel Jáquez Leal 2015-10-28 09:56:46 +0100 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: free the frame in frame_release_callback() This basically reverts 62c3888b76afc69f714a020957e8c5dd9d98f561 (wayland: decouple wl_buffer from frame). Otherwise the frame may be overwritten while it is still used by the compositer: The frame done callback (frame_done_callback()) is called, when the compositor is done processing the frame and hands it to the hardware. The buffer release callback (frame_release_callback()) is called when the buffer memory is no longer used. This can be quite some time later: E.g. if weston (with the DRM backend) puts the buffer on a hardware plane, then then buffer release callback is called when the kernel is done with the buffer. This is usually when the next frame is shown, so most likely after the frame done callback for the next frame! Since 70eff01d36a2870cbf06ffb91c2a941e8cb6b804 "wayland: sync() when destroy()" the mentioned possible leak should no longer be a problem, so reverting this change should cause no leaking buffers. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=758848 Signed-off-by: Víctor Manuel Jáquez Leal 2016-01-14 17:36:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: check ANY caps at transform_caps() When transforming downstream caps we should check for ANY caps from peer pad, otherwise we get a segmentation fault. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=759893 2016-01-13 19:17:02 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: ignore frame if its upload failed When gst_vaapi_plugin_base_get_input_buffer() fail to copy the input buffer into a VAAPI buffer, the return value is GST_FLOW_NOT_SUPPORTED, and it was ignored by the vaapisink, leading to a segmentation fault. This patch ignores the frame that generated the GST_FLOW_NOT_SUPPORTED returned by gst_vaapi_plugin_base_get_input_buffer(), avoiding the segmentation fault, but doing and effort to continue rendering. This is the same behavior of ximagesink. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=759332 2015-12-09 18:24:50 +0200 Joel Holdsworth * configure.ac: build: Don't ignore GST_PLUGIN_PATH_1_0 even if the directory doesn't exist yet https://bugzilla.gnome.org/show_bug.cgi?id=759184 2015-12-08 16:14:11 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: Add 10 HEVC 10 bit decoding support Only supporting vaapidecode ! vaapisink combination for now. Missing dependencies: 1: No support for P010 video format in GStreamer 2: No support for P010 vaGetImage()/vaPutimage() in vaapi-intel-driver 3: As a result of 1&2 , we have no support for Vaapi Video memory mapping through GstVideoMeta. Right now we only set chroma format (YUV420 with more than 8 bits per channel) for surface pool and keeping GST_VIDEO_FORMAT as ENCODED. The underlying format of the surfaces is implementation (driver) defined, which is P010. 2001-01-01 04:59:28 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: gstvaapisurfacepool: Add new API to create surface pool based on chroma type This new API gst_vaapi_surface_pool_new_with_chroma_type() is for creating a new GstVaapiVideoPool of GstVaapiSurfaces with the specified chroam type and dimensions. The underlying format of the surfaces is implementation (driver) defined. 2015-12-07 19:06:28 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: Add definitions for YUV420 with more than 8 bits per channel 2015-12-07 17:26:24 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiprofile.c: gstvaapiporfile: Fix string representation of HEVCMain10 profile 2015-12-07 16:17:11 +0200 Sreerenj Balachandran * configure.ac: Bump version for development === release 0.7.0 === 2015-12-07 12:52:10 +0200 Sreerenj Balachandran * configure.ac: 0.7.0 2015-12-07 12:49:05 +0200 Sreerenj Balachandran * NEWS: NEWS: Updates 2015-12-07 12:47:04 +0200 Sreerenj Balachandran * AUTHORS: AUTHORS: Update 2015-12-07 12:39:23 +0200 Sreerenj Balachandran * README: README: Update 2015-11-26 10:34:12 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexture_glx.c: texture: detect GL version and use the proper API When receiving the texture from the application or the video sink, we must know it size and border. To query the texture the API has changed according to the OpenGL version used in the GL context of the application/vsink. This patch checks the current context API type and queries the texture according to this detected API. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=753099 2015-11-26 10:19:32 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapitexture_glx.c: texture: check for expected target and format gst_vaapi_texture_glx_new_wrapped() only handles a GL_TEXTURE_2D target and formats GL_RGBA or GL_BGRA. This patch adds a debugging verification of those values. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=753099 2015-11-26 10:26:10 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: libs: add gl3_bind_texture_2d() Since OpenGL3.1 removed the fixed pipelines[1] enabling 2D textures is not needed. In particular, the Intel's Mesa implementation complains if it is called. This patch add a new binding function for 2D textures, without enabling gl3_bind_texture_2d()[2]. 1. https://www.opengl.org/wiki/Fixed_Function_Pipeline 2. https://www.opengl.org/wiki/Common_Mistakes#OOP_and_hidden_binding Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=753099 2015-11-26 10:14:45 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: libs: add gl_get_current_api() In order to know which OpenGL API use, we must detect the API type of current context. This patch adds the function gl_get_current_api() which returns the OpenGL API type. This function is an adaptation of gst_gl_context_get_current_gl_api() from GstGL. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=753099 2015-11-27 12:29:11 +0200 Sreerenj Balachandran * configure.ac: * gst-libs/gst/vaapi/Makefile.am: build: Add gmodule dependency for libgstvaapi_egl https://bugzilla.gnome.org/show_bug.cgi?id=756259 2015-11-27 14:24:55 +0200 Sreerenj Balachandran * patches/videoparsers/0005-videoparsers-h264-Disable-passthorugh-mode-enabling.patch: * patches/videoparsers/0006-h265parse-include-gstvaapiparse.h.patch: * patches/videoparsers/0007-h265parse-fix-build-with-GStreamer-1.5.patch: * patches/videoparsers/series.frag: patches/videoparsers: h264: Disable passthorugh mode enabling This is a quick fix for regression introduced by the upstream commit e8908f5aeef952566f6bccde743c7735d3f8c6ef in h264 videoparser. The patch is disabling the passthrough mode, otherwise it will break multi-layer mvc stream parsing. https://bugzilla.gnome.org/show_bug.cgi?id=758656 2015-11-25 15:12:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * patches/videoparsers/Makefile.am: * patches/videoparsers/series.frag: build: add gsth265parse patches conditionally As gsth265parse was added in GStreamer 1.4, and gstreamer-vaapi still support GStreamer 1.2, the patching of gsth265parse must be conditional to the target GStreamer version. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=755525 2015-11-25 15:11:28 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: build: declare correctly parse lib built files This is a continuation of commit fc8a0d12 When declaring BUILT_SOURCES, those files should not be distributed. This patch avoids the distribution of the generated source code. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=755525 2015-11-24 17:14:20 +0200 Sreerenj Balachandran * ext/libvpx/sources.frag: build: libvpx: Add missing source file 2015-11-23 17:21:23 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Correctly detect the caps change This is a quick fix for regression introuduced by the commit 757833230bc73b8e3b4e31649e4618ba802bea51 With out this, the gst_vaapipostproc_create() will never get invoked. https://bugzilla.gnome.org/show_bug.cgi?id=758543 2015-11-18 20:48:30 +0100 Víctor Manuel Jáquez Leal * ext/libvpx/Makefile.am: * ext/libvpx/sources.frag: build: libvpx: update the sources lists `make dist` broke since commit f06798 (libvpx: Update the submodule to libvpx-1.4.0) because the sources.frag does not contain all the module sources. This patch updates thoroughly the sources. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=755525 2015-11-16 17:49:01 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't set caps change at first set When the source caps change, the filter is destroyed and recreated. Nonetheless, this happens every time the vaapipostproc starts, since the caps change detection algorithm does not take in consideration when the caps are set by first time. This patch intents to be an optimization, to avoid a useless filter destroy-creation cycle when the sources caps are set for first time. The new helper function video_info_update() is a refactorization to avoid duplicated code. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=758007 2015-11-12 16:13:25 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: params video_info_changed() callers The signature is video_info_changed(old_vip, new_vip). Nonetheless the callers swapped the the order. This didn't raise problems since the comparison of both structures were not affected by its semantics. But still it would be better to fix this to keep the coherence of the code. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=758007 2015-09-24 10:35:44 +0000 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: build: declare real built files When runnig the `make dist` target from a clean tree, it fails because if could not find the copied files from codecparsers submodule. They weren't copied because they weren't declared as built sources. This patch removes the stamp mechanism and use the actual file list to copy as the built sources. Also it fixes the duplication of the parser files. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=755525 2015-11-17 19:37:07 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fix last/golden/altref frame index setting Always fill VADecPictureParameterBufferVP9 last/golden/altref indices based on what ever reference frame indices encoded in frame header. 2015-08-25 16:01:51 +0000 Víctor Manuel Jáquez Leal * debian.upstream/rules: debian: remove custom parallel compilation In order to build a debian package with upstream source, the user should do ./autogen.sh cp -a debian.upstream debian debuild -eDEB_BUILD_OPTIONS="parallel=8" -us -uc -b The environment variable DEB_BUILD_OPTIONS="parallel=8" is the canonical way to make a parallel build (-j8 in this case). This commit removes the script in debian/rules that detects the number of cpus, requested by the environment variable DEBIAN_BUILD_NCPUS, which is not official in debian. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754087 2015-11-16 18:22:55 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fix PTS calculation of cloned frames 2015-11-16 18:22:33 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Avoid unnecessary show_frame flag checking while doing picture output We always set GST_VAAPI_PICTURE_FLAG_SKIPPED for DECODE_ONLY frames and the gstvaapidecoder base calss is reponsible for handling those frames later on. No need for explicit verification of frame header's show_frame in order to do picture outputing. 2015-11-16 18:22:14 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fix ref picture update while doing repeat frame Don't try to do frame decoding and reference picture update while receiving a vp9 frame having show_existing_frame flag set as TRUE. 2015-11-16 18:21:56 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Add repeat-frame display handling If vp9 frame header come up with show_existing_frame flag set, we should duplicate the existing decoded frame as current frame to be displayed. 2015-11-12 11:07:38 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: add me as element co-author Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757957 2015-11-12 12:47:01 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: try to get display from decoder Rather than create a dummy display, if none has propagated as a context, we should try to get the one from vaapidecode. As the bin is already in READY state, the vaapidecode should be also in that state. That means that the contexts have been negotiated, and it should have already a display. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757957 2015-11-11 19:04:25 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: add postprocessor dynamically The former approach to left the bin unfinished has some problems: the context cannot be shared because the vaapidecode is unlinked in many cases, leading to creating a VADisplay twice. Initially the bin is fully functional, constructed as (-----------------------------------) | vaapidecodebin | | (-------------) (-------) | |<--| vaapidecode |--->| queue |--->| | (-------------) (-------) | (-----------------------------------) When the context is shared and the VADisplay has VPP capabilities, before changing to READY state, the bin is reconfigured dynamically, adding the vaapipostproc element afeter the queue: (--------------------------------------------------------) | vaapidecodebin | | (-------------) (-------) (---------------) | |<--| vaapidecode |--->| queue |--->| vaapipostproc |--->| | (-------------) (-------) (---------------) | (--------------------------------------------------------) Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757957 2015-11-11 16:33:24 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: delay the bin configuration Delay the bin configuration until changing to READY state. This is because we should add the vaapipostproc element until the vaapidecode has emitted the HAVE_CONTEXT message, so de gst_bin_add() could set the context set to vaapipostproc. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757957 2015-11-13 19:39:56 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Add crop rectangle support. Set crop rectange if: There is display_width and display_height which is different from actual width/height or The changed resolution is less than the actual configured dimension of surfaces 2015-11-13 19:23:05 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fix the context and surface pool reset for multi resolution video Unlike other decoders, vp9 decoder doesn't need to reset the whole context and surfaces for each resolution change. Context reset only needed if resolution of any frame is greater than what actullay configured. There are streams where a bigger resolution set in ivf header or webm header but actual resolution of all frames are less. Also it is possible to have inter-prediction between these multi resolution frames. 2015-11-13 18:58:33 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Fill the VADecPictureParameterBufferVP9 width/height from frame header Always fill width/height of VADecPictureParameterBufferVP9 from frame header. Preliminary fix for supproting multi resolution video decode. 2015-11-13 18:51:27 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Add comments for corner case fixes and fix couple of indentations. 2015-11-13 18:41:53 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: decoder: vp9: Set lossless flag from frame header 2015-11-13 18:40:52 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch d9f25 d9f2527: codecparsers: vp9: Set lossless flag in frame header 2015-11-11 19:16:16 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: libs: vp9: remove unused symbols clang complains about a couple variables and one label which were not used. This patch removes them. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757958 2015-11-10 19:00:22 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch da251bb da251bb: codecparsers: vp9: Optimize the memory allocation f5759f4: codecparsers: vp9: Fix the wrong memcpy of probability arrays 2015-11-05 12:58:52 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugin: guard pointers to pad query functions Since gstreamer 1.4 is not required to have pad query functions if the query vmethods are used. This patch guards out the pad query functions for gstreamer < 1.4 Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757629 2015-11-05 12:39:55 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapiencode.c: vaapiencode: use pad query vmethods GstVideoEncoder, the base class of vaapiencode, added support for pad queries as virtual methods since gstreamer 1.4. This patch enables those vmethods, while keeps support for previous versions of gstreamer. This patch is relevant since GstVideoEncoder takes care of other queries that we are currently ignoring. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757629 2015-10-28 13:01:04 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: return pad's template caps if no display A caps query can occur before the element has a display. In that case, the element can return its pad's template. But when the element already has a display, and the caps probe fails, the element shall return an empty caps, so the auto-plug could try with another decoder. If the element has a display and the caps probe works, then the computed caps should be returned. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-10-28 12:59:02 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: plugins: don't create display at caps query Caps query can happen before the element has a bus. The display creation should be should occur on the context negotiation, when the bus is already configured. Then at caps query no display should be created. Instead of force the display creation, we graciously fail the allowed_caps() creation. This change only applies for vaapidecode and vaapisink. The vaapipostroc, as a basetransform descendant, seems to be not affected by this, nor the encoders. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-04 21:38:42 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: fix context query handling The current context query handling design is flawed: the function gst_vaapi_reply_to_query() returns FALSE either if the query is not a GST_CONTEXT_QUERY of if the query could not be handled correctly. But the pad query function should handle differently each case. This patch changes the gst_vaapi_reply_to_query() for gst_vaapi_handle_context_query() and changes it usage in all the vaapi plugins to match the correct context query handling. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-04 20:37:05 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugin: don't lose previous context at query When processing the GST_CONTEXT_QUERY we should not lose the previous context in the query, we should only add our display structure. This patch copies the old context, if it is there, and stamp our display on it. Otherwise, a new context is created. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-04 20:29:03 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: vaapivideocontext: add gst_vaapi_video_context_set_display() This function set the display to an already created context. This function is going to be used later. Also, gst_vaapi_video_context_new_with_display() now uses this function. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-10-30 12:27:16 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: plugins: check if display is set in sync Since the context messages are sync'ed, the display assignation happens in the same thread, hence we can know if the display was found or not as soon we call for it. In order to take advantage of it, gst_vaapi_video_context_prepare() receives, as a new parameter, the address of the plugin's display, and reports back if the display was found and set. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-10-30 12:33:48 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: plugins: set display through context Instead of setting the display to the plugin directly after its creation, do it through the gstreamer's context mechanism, avoiding double assignations. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-02 18:20:07 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: rename context structure The context structure is named "display" which is too generic. The contrary happens, for example, with GstGL, what uses the same name as the context, and its logs make more sense. This patch renames the context structure with the same name as the context, thus GST_PTR_FORMAT can pretty print it. https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-04 19:02:34 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: refactor gst_vaapi_video_context_prepare() First, refactorized run_context_query() into _gst_context_run_query(), adding a new parameter: the pad direction, in order to simplify the code. Second, added a new helper function: _gst_context_query(), which is a generic context query function. It isolates the operation of running the query and sets the context if found, also it enhances the logs. _gst_context_query() is similar to the one used in GstGL. Perhaps, in the future this helper function will be merged into the core libraries of GStreamer. Finally, gst_vaapi_video_context_prepare() was rewritten to use _gst_context_query(). Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-10-30 11:18:47 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: vaapivideocontext: refactor context category debug Refactor the extraction GST_CAT_CONTEXT logging using a only once initializator, so we could get the debug category from different code paths, safely. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-10-23 11:17:01 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: gstvaapivideocontext: fix indentation gst-indent does not handle correctly some expression like function declaration with attributes, breaking the following expressions. This patch makes gst-indent to ignore the attributed function declartion so the followed function definition is not mangled, such as happened in commit b4154a Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-02 16:48:27 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugin: chain up set_context() vmethod Since Gstreamer 1.7, set_context() vmethod needs to be chained up with the parent class in order to broadcast all its contexts when the element is added into a bin: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=d5ded1588920c4471eefe055d09095d9e5e989b5 There is no need to guard the call, because before GStreamer 1.7, the set_context() vmethod was NULL in the element class, hence the conditional call make it safe. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757598 2015-11-06 10:20:34 +0100 Víctor Manuel Jáquez Leal * tests/simple-encoder.c: tests: simple-encoder: remove dead code The caps creation for codec state configuration is not used. Let's remove it. Signed-off-by: Víctor Manuel Jáquez Leal 2015-11-02 19:05:07 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: fix a leaked display instance The display returned by gst_vaapi_video_context_get_display() increments the references. Thus, we have to unref the returned display. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757595 2015-11-04 16:50:44 +0100 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: libs: remove unneeded headers Since gstvaapidisplay_glx.h do not expose gl.h/glx.h structures, it is not required to include them in the header. It is not also required to include them in gstvaapidisplay_glx.c, since gstvaapiutils_glx.h includes them and exposes their structures (e.g. GLXPixmap). Nonetheless, glext.h neither glxext.h are required to include, they are already included conditionally by gl.h and glx.h, respectively. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757577 2015-11-06 19:18:54 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch 0ea6792 0ea6792: codecparsers: vp9: Add header comments 347ffc7: codecparsers: vp9: Use g_slice_free() for releasing memory allocated from the slice allocator 2015-11-06 15:19:38 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: VP9: plugins: Add VP9 decoder 2015-11-06 15:12:51 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp9.h: VP9: libgstvaapi: Add VP9 decoder 2015-11-06 14:57:00 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: VP9: gstvaapiprofile: Add profile definitions 2015-11-06 14:39:22 +0200 Sreerenj Balachandran * configure.ac: VP9: build: Check availability of vp9 decoder APIs 2015-11-06 14:24:08 +0200 Sreerenj Balachandran * configure.ac: * ext/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: VP9: Allow building vp9 codecparser internally 2015-11-06 12:38:46 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit ac5dc1a ac5dc1a: codecparsers: vp9: Add vp9 codec parser e7d9217: codecparser: h264: initialize parsing structures 403d400: codecparser: h265: initialize parsing structures 2015-11-04 15:37:34 +0100 Víctor Manuel Jáquez Leal * configure.ac: configure.ac: don't use an undefined variable If the environment lacks of gstreamer development packages, this error will be reported to the user: "gstreamer- was not found" This is because we are using an undefined variable in the printed message. The fix simple changes the variable for the hard-coded string "1.0". Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=757283 2015-10-16 15:55:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: relax guards for memory:VASurface capsfeature Though caps features are supported since GStreamer 1.2, there are some issues with the features caps negotiation in that version. Nonetheless, those issues are fixed in GStreamer 1.4. So, the memoy:VASurface caps feature negotiation is relaxed for GStreamer 1.4. The guard is the same as in vaapisink's caps template. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=756686 2015-10-15 18:18:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: decide allocation doesn't update srccaps The received caps query will bring the already negotiated caps, so they are not expected to change. This patch removes this verification which is dead code path. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=756686 2015-10-14 20:30:30 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapidecode: use caps to check the features Instead of calling gst_vaapi_find_preferred_caps_feature(), which is expensive, we check the caps from the allocation query, to check the negotiated feature. In order to do this verification a new utility function has been implemented: gst_vaapi_caps_feature_contains(). As this new function shared its logic with gst_caps_has_vaapi_surface(), both have been refactorized. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=756686 2015-10-14 20:22:43 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: set format before decide allocation There is a regression from commit 3d8e5e. It was expected the buffer pool allocation occur before the caps negotiation, but it is not. This patch fixes this regression: the caps negotiation is done regardless the allocation query from downstream. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=756686 2015-10-16 20:21:50 +0800 Lim Siew Hoon * configure.ac: build: check for patch and fix yasm check Add configure checking for GNU patch tools and fixed configure checking YASM to correct sequence. Signed-off-by: Lim Siew Hoon https://bugzilla.gnome.org/show_bug.cgi?id=756690 2015-10-15 19:20:21 +0300 Sreerenj Balachandran * ext/libvpx/Makefile.am: build: Remove disable-md5 option for libvpx build The configure option --disable-md5 was provided in libvpx-1.3.0 which has been removed in 1.4.0. 2015-10-15 19:00:26 +0300 Sreerenj Balachandran * ext/libvpx/upstream: libvpx: Update the submodule to libvpx-1.4.0 libvpx git commit: c74bf6d889992c3cabe017ec353ca85c323107cd 2015-10-15 10:59:08 +0300 Sreerenj Balachandran * configure.ac: configure: mark support for GStreamer 1.2 as obsolete. Support for GStreamer 1.2 is obsolete. i.e. it is no longer supported. Our goal is to support the last two stable versions of GStreamer which are 1.4 and 1.6 at the moment. We still keep the 1.2 specific codes until the next gstreamer-vaapi-0.7 release and will get rid of those in 0.8. 2015-10-12 14:13:03 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Fix buffer copy assertion Don't try to copy the NULL buffer-codec_data. 2015-09-28 14:57:33 +0200 Víctor Manuel Jáquez Leal * configure.ac: build: allow builds against GStreamer 1.7.x Signed-off-by: Víctor Manuel Jáquez Leal 2015-09-23 16:02:46 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstcompat.h: gstcompat: add gst_buffer_copy_deep() if gst < 1.5 gst_buffer_copy_deep() was added in GStreamer 1.5. If want to use it we should add an implementation if gstreamer-vaapi is linked to previous versions. Signed-off-by: Víctor Manuel Jáquez Leal 2015-09-23 12:13:41 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: simplify copy of GstVideoCodecState Signed-off-by: Víctor Manuel Jáquez Leal 2015-09-14 19:21:08 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0006-h265parse-fix-build-with-GStreamer-1.5.patch: * patches/videoparsers/series.frag: patches/videoparsers: h265parser: more API fences Add more API fences according with its version and refresh the patch. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-14 19:19:56 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0005-h265parse-include-gstvaapiparse.h.patch: * patches/videoparsers/series.frag: patches/videoparsers: h265parser: rename patch keeping number Refresh the patch and rename it in order to keep the patch number. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-14 19:18:33 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: patches/videoparsers: h264parser: more API fences and refresh Add more API fences according with its version and refresh the patch. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-14 19:16:51 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0004-h264parse-Disable-3D-video-support-for-GStreamer-1.5.patch: * patches/videoparsers/series.frag: patches/videoparsers: h264parser: fix description and refresh Fix a typo in the patch description and refresh it in order to avoid the creation of .orig files and break the distcheck target. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-14 19:15:18 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0001-plugins-compile-the-built-in-video-parsers-as-vaapip.patch: * patches/videoparsers/0003-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: patches/videoparsers: h264parser: refresh patches In order to avoid the creation of .orig files and break the distcheck target. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-15 16:53:31 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: build: link libgstvaapi_parse against codec parser GST_CODEC_PARSER_* variables are defined if builtin codec parsers are disabled when running configure. Right now, libgstcodecparsers links only to libgstvaapi, but libgstvaapi_parse need it if builtin codec parsers are disabled. This patch adds GST_CODEC_PARSER_* variables to libgstvaapi_parse compilation. If builtin codec parsers are enable, this variable is null, so it should work using libgstvaapi, as normal. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-11 16:35:30 +0200 Víctor Manuel Jáquez Leal * configure.ac: build: verify for H264 MVC and H265 SPS Currently the H264 and H265 parsers look for MVC and SPS respectively, and the required symbols for those were added in GStreamer 1.5 If we try to compile in GStreamer < 1.4, without enabling the builtin codec parsers, the compilation fails, because the lack of those symbols. This patch verifies if the installed H264 and H265 parsers have those symbols. If they do not, the specific built in codec parsers are enabled and used. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-11 16:49:16 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: initialize PPS's slice_group_id When the GstVaapiParserInfoH264 is allocated, the memory is not initialized, so it contains random data. When gst_h264_parser_parse_pps() fails, the PPS structure keeps slice_group_id pointer uninitialized, leading to a segmentation fault when the memory is freed. This patch prevents this by initializing the slice_group_id before the PPS parsing. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754845 2015-09-15 11:01:29 +0300 Mark Nauwelaerts * gst/vaapi/gstvaapidecode.c: vaapidecode: proper numerator and denominator for forced latency framerate https://bugzilla.gnome.org/show_bug.cgi?id=755040 2015-09-11 20:51:42 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit f9e284b dae1a84: h264parse/h265parse: Fix negotiation crash 45a9f8a: codecparsers: h265 : Fix default scaling list values 28eaaf5: codecparsers: h265: Fix the selection of Active Ref Pic Set Signed-off-by: Sreerenj Balachandran 2015-09-04 22:19:55 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Don't flush dpb for EOS/EOB nal Explicit flushing of dpb for EOS and EOB nal decoding is wrong, the dpb_add() itself will handle the flusing(if needed) of dpb for end of sequence and end of bitstream. https://bugzilla.gnome.org/show_bug.cgi?id=754010 2015-09-04 22:11:10 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix the dpb_add() based on C.5.2.3 Follow the spec as it is in C.5.2.3, add the decoded frame to dpb just after the PicLatencyCnt setting of existing dpb frames. https://bugzilla.gnome.org/show_bug.cgi?id=754010 2015-09-04 22:02:55 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix the picture addition in dpb() based on spec H265 v3 (04/2015) This fix is based on the V3 vesion of spec which was missing in older versions. When the current picture has PicOutputFlag equal to 1, for each picture in the DPB that is marked as "needed for output" and follows the current picture in output order, the associated variable PicLatencyCount is set equal to PicLatencyCount + 1 (C.5.2.3). https://bugzilla.gnome.org/show_bug.cgi?id=754010 2015-09-04 22:00:36 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: h265: Fix indentation 2015-06-13 01:39:31 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: multiview: initial attempt at stereo/multiview support Add support for marking caps and buffers for multiview or stereoscopic output. https://bugzilla.gnome.org/show_bug.cgi?id=750835 2015-08-28 17:12:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: remove unused functions Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=754250 2015-08-31 13:11:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove (another) unused variable Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-28 17:10:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove unused variable Thus silence the compilation warnings. 2015-08-28 16:06:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: compilation fix gst_vaapi_decoder_state_changed() returns void. This patch fixes the compilation where the toolchain uses restrictive flags as clang. Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-29 00:27:05 +0300 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: renegotiate if caps are not equal The use of gst_caps_is_always_compatible() for this optimization may lead to false positives. It is better to stick to gst_caps_is_strictly_equal() to know if it is required a re-negotiation. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=750835 2015-08-29 00:18:57 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: Rework the re-negotiation code to handle multi resoultion videos Delaying the pool re-negotiation untill we push all decoded (and queued) frames downstream. Otherwise for the multi-resolution videos, the GstVideoVideoMemory will be having wrong resolution and which leads to nasty behaviours, especially when using software renderers. sample media file: RAP_B_Bossen_1.bin case explained: The first SPS Nal will report resoultion of 448x256 and having crop rectangles to get the final resoultion 416x240. Starting from 25 th frame, the resolution will change to 416x240. But parser elements won't report this since the effective croped resolution is same in both cases. Here the core libgstvaapi will detect this through it's internal parsing and do all context/pool destory/reset stuffs. Also it will notify this change to plugins in advance. But if the plugin try to do re-negotiaion of pool immediately, this will not sync with the resolution of already decoded and queued frames and which will lead to failure in gst_video_frame_map() in downstream(if we use the software renderer). So we have to delay the pool renegotiation in vaapidecode, untill we push all decoded frames downstream. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2015-08-28 23:43:47 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Always keep a copy of input codec state Currently we are sharing the input GstVideoCodecState with GstVaapiDecoder(gst-libs/gst/vaapi) by just doing ref and unref for each caps change. This is troublesome in many cases, for eg: if resoultion changes with in a singe stream. Because, when ever there is a resolution change, GstVideoDecoder will first change the Codec_state->caps fields with new resolution, but since we are using the same codecstate (ref) in gstvaapidecode.c, the caps check for input caps change will always fail. https://bugzilla.gnome.org/show_bug.cgi?id=753914 2015-08-26 07:25:03 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix the scaling list scan order The default scan order of scaling lists are up-right-diagonal as per hevc specification. Use the newly implemented uprightdiagonal_to_raster conversion codecparser APIs to get the the scaling_list values in raster order, which is what the VA intel driver requires. 2015-08-26 07:20:09 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: sync with the codecparser changes The Tile Scanning Conversion process (spec 6-3 and 6-4) is implemented in codecparsers now. Remove the duplication from gstvaapidecoder_h265 2015-08-26 07:04:22 +0300 Sreerenj Balachandran * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: patches/Videoparsers: update patch to fix build with older GStreamer 1.2 stacks 2015-08-26 06:57:36 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 69550f1 c207c6d: codecparsers: h265: Fix tile row and column parsing 47074c5: codecparsers: h265: Add APIs for up-right-diagonal/raster scan conversion cd28b18: codecparsers: h265: Fix the range of delta_chroma_log2_weight_denom 1746bbe: videoparsers: Use gst_base_parse_merge_tags() 2f0932b: h264parse: Clear SPS info after processing f57d6b0: videoparsers: enable accept-template flag 2015-08-25 15:38:42 +0000 Víctor Manuel Jáquez Leal * debian.upstream/control.in: debian: add yasm as build dependency As the compilation of libvpx (for vp8 parser) is enabled by default, yasm is required by default too. Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-14 19:21:04 +0800 Lim Siew Hoon * debian.upstream/rules: debian: remove --with-gstreamer-api option It is no longer valid in gstreamer-vaapi. Signed-off-by: Lim Siew Hoon [removed unused GST_API_VERSION variable] Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=753618 2015-08-24 19:22:14 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: rename is_cancelled to sync_failed Since commit 065a18a3, the semantics of the variable is_cancelled did not make sense. This commit renames this variable to sync_failed. 2015-08-13 15:12:44 -0400 Olivier Crete * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: Don't return GST_FLOW_ERROR on flushing Setting the sink to flushing causes gst_vaapi_window_wayland_sync() to return FALSE which makes gst_vaapi_window_wayland_render() return FALSE which ends up posting an ERROR message in gst_vaapisink_show_frame_unlocked(). Solution is to just return TRUE in the EBUSY case. https://bugzilla.gnome.org/show_bug.cgi?id=753598 2015-08-06 12:28:51 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapi.c: Revert "Marking rank of vaapidecodebin as GST_RANK_MARGINAL for now." This reverts commit 3ccb198b513dc6ad287fe44117d03bec4d6a966a. 2015-07-06 20:22:57 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: check for postproc instance If the VPP's deinterlace-method is set, first we should check if the postproc is already instanced to set it. Otherwise we just store it until the VPP is added into the bin. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-08-06 18:48:13 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapidecodebin: ensure VPP before going to READY There are sometimes that the VA-API display context is not shared among the pipeline, but it is important to know it before going to READY state (when the pipeline is already linked). One instance of this case is this: gst-launch-1.0 filesrc location=media ! decodebin ! vaapipostproc ! vaapisink This patch adds a new function in gstvaapipluginutil called gst_vaapi_create_test_display(). Its purpose is to create a disposable VA-API display, which only will be used for verify if the VAEntrypointVideoProc is available by the hardware. Afterwards, it should be unrefed. If the vaapidecodebin is going to READY state, and the element still doesn't know if VPP is available, the last resort is to create a new instance of the VA-API display and test for it. https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-08-06 12:39:52 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: post an error message if fails If the construction of the bin fails, post an error message in the bus. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-08-06 12:36:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: has_vpp as a tri-state variable has_vpp can be UNKNOWN while the context message hasn't being received. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-08-03 16:33:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: gstvaapivideomemory: native format with no derived image If USE_NATIVE_FORMATS is defined we bail out before configuring the surface info based on the derived image configuration. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-07-23 20:07:59 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapivideomemory.c: surface pool config based on video info First added the function gst_vaapi_video_format_get_best_native(), which returns the best native format that matches a particular chroma type: YUV 4:2:0 -> NV12, YUV 4:2:2 -> YUY2, YUV 4:0:0 -> Y800 RGB32 chroma and encoded format map to NV12 too. That format is used to configure, initially, the surface's pool for the allocator. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-07-23 16:03:43 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: gstvaapivideomemory: refactor gst_vaapi_video_allocator_new() Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-06-19 15:51:07 +0200 Victor Jaquez * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder: validate chroma according to the VA's RT format Before, only YUV420 color space where supported. With this patch, the encoder is queried to know the supported formats and admits YUV422 color space if its available. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-08-13 05:07:52 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Add calculation of WpOffsetHalfRangeC This is necessary for finding ChromaOffsetL0/ChromaOffsetL1 prediction weight table values with out using any hard coding. Fixme: We don't have parser API for sps_range_extension, so assumed zero value for high_precision_offsets_enabled_flag. Signed-off-by: Sreerenj Balachandran 2015-08-13 04:09:44 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix ChromaOffsetL0/ChromaOffsetL1 calculation Based on ITU-T rec H265(4/2015): 7-56 This was a wrong equation in rec H265 (4/2013): 7-44... Signed-off-by: Sreerenj Balachandran 2015-08-13 04:08:03 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix default value assignment of pred_weight_table 2015-08-13 03:48:43 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix the value assigning for delta_chroma_log2_weight_denom Assign only if ChromaArrayType != 0.. Signed-off-by: Sreerenj Balachandran 2015-08-13 03:06:32 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 1c70432 8e98b41: codecparsers: h265: Fix the range of delta_chroma_log2_weight_denom 839c5bc: codecparsers: h265: Fix the parsing of ref_pic_lists_modification Signed-off-by: Sreerenj Balachandran 2015-08-11 08:09:10 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit c18b8ad 8a03e67: videoparsers: h265: Avoid skipping of EOS and EOB nals a033083: videoparsers: h265: Fix the frame start detection code Signed-off-by: Sreerenj Balachandran 2015-08-10 05:50:50 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Add SEI parsing Signed-off-by: Sreerenj Balachandran 2015-08-07 08:43:44 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Workaround to recognize wrongly encoded main profile streams HACK: This is a work-around to identify some main profile streams having wrong profile_idc. There are some wrongly encoded main profile streams(eg: ENTP_C_LG_3.bin) which doesn't have any of the profile_idc values mentioned in Annex-A, instead general_profile_idc has been set as zero and having general_profile_compatibility_flag[general_profile_idc] is TRUE. Assuming them as MAIN profile for now. https://bugzilla.gnome.org/show_bug.cgi?id=753226 Signed-off-by: Sreerenj Balachandran 2015-08-07 08:41:57 +0300 Sreerenj Balachandran * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: patches/videoparsers: Fix the wrong source file path This is something wrongly typed in commit 6d7b631 2015-08-07 08:34:55 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit b8d8be4 ee7e81b: h264parse: Don't discard first AU delimiter 3690fb9: h264parse: Add more NAL types for debugging output 108d368: h265parse: Avoid checking for Non Mandatory VPS NAL ace61048: h265parse: expose compatible profiles to downstream Signed-off-by: Sreerenj Balachandran 2015-08-06 13:07:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: gstvaapivideocontext: remove unused parameter gst_vaapi_video_context_prepare() received an unused parameter. This patch removes it and the structure passed by the caller. This a left over of "Removal of gstreamer-1.0 support" (commit 8b36e25f). Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-06 04:01:24 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix decoding of stream when it has temporal sublayers We are calculating the dpb size based on max_dec_pic_buffering. But if there are more than one temporal sublayers, we are supposed to use the max_dec_pic_buffering[max_sub_layers_minus] for dpb size calculation (Assuming HighestTid as max_sub_layers_minus). Sample streams: TSCL_A_VIDYO_5.bin, TSCL_B_VIDYO_4.bin https://bugzilla.gnome.org/show_bug.cgi?id=753226 Signed-off-by: Sreerenj Balachandran 2015-08-05 14:11:12 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: refactor vaapi caps strings for pad templates Refactor the main vaapi caps strings into three macros: GST_VAAPI_MAKE_SURFACE_CAPS, GST_VAAPI_MAKE_ENC_SURFACE_CAPS and GST_VAAPI_MAKE_GLTEXUPLOAD_CAPS. Those are in gstvaapipluginutil.h so all the elements could use them, instead of re-declaring them every time. No functional changes. Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-05 14:15:07 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: gstvaapipostproc: fix code style Signed-off-by: Víctor Manuel Jáquez Leal 2015-08-05 05:23:20 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix the decoding of dependent slice segment Decoding process for reference picture list construction needs to be invoked only for P and B slice and the value for slice_type of dependent slice segment should be taken from the previous independent slice segment header of the same pic. https://bugzilla.gnome.org/show_bug.cgi?id=753226 Signed-off-by: Sreerenj Balachandran 2015-06-22 17:38:41 +0200 Victor Jaquez * gst/vaapi/gstvaapipluginbase.c: plugins: reduce the noise of warnings Those messagse should be attached to the object, also the lack of caps is not an error, in particular in the case of JPEG encoding. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-06-23 17:49:51 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapicontext.c: gstvaapicontext: fix the JPEG encoder attribs value When we query for the VAConfigAttribEncJPEG, we get a value which packs the VAConfigAttribValEncJPEG structure, but we did not assign it. This patch assigns the returned value to the attribute. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-06-18 17:37:46 +0200 Victor Jaquez * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder: framerate 0/1 is valid too Framerate 0/1 is valid, and it is particularly useful for picture encoding, such as jpeg. This patch makes the encoder to admit that framerate. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=744042 2015-07-03 09:35:16 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostroc: GLTextureUploadMeta in sink template Advertise GLTextureUploadMeta in sink caps template. https://bugzilla.gnome.org/show_bug.cgi?id=752130 2015-07-23 13:11:40 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapiuploader.h: remove gstvaapiuploader Working on bug #744042 I realized that the gstvaapiuploader is practically not used. This patch removes the gstvaapiuploader and add the method gst_vaapi_plugin_base_get_allowed_raw_caps () that returns the raw caps that the system can handle, which is used by vaapisink and vaapipostproc. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=752777 2015-07-27 18:49:13 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: don't lost GLTextureUpload on seek When seeking, the decoder is reset, but the buffer pool is not re-negotiated, but in reset_full() the code forgets if the negotiated buffer pool has the GLTextureUpload meta. The decoder knows that GLTextureUpload meta was negotiated in decide_allocation(), but this method is not called when seeking. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=752929 2015-07-21 18:45:56 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: don't use gst_pad_get_allowed_caps() gst_pad_get_allowed_caps() query the pad and the peer pad. In the case decoders, that is OK, but in the case of the postproc might lead loops, since the gst_base_transform_query_caps() forwards the query upstream and forth. Instead of gst_pad_get_allowed_caps() we only query the peer with gst_pad_peer_query_caps() using the pad's template as filter. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=752558 2015-07-22 12:40:19 +0300 Sreerenj Balachandran * README: README: updates 2015-07-22 09:45:26 +0300 Sreerenj Balachandran * patches/videoparsers/0004-h264parse-Disable-3D-video-support-for-GStremaer-1.5.patch: * patches/videoparsers/series.frag: patches/videoparsers: h264parse: Disable 3D video support for GStremaer < 1.5 All API/ABI changes for S3D/MVC are added in 1.5, backporting them to older verison is not recommended. Signed-off-by: Sreerenj Balachandran 2015-07-22 09:41:34 +0300 Sreerenj Balachandran * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: patches/Videoparsers: update patch to fix build with older GStreamer 1.2 stacks 2015-07-22 09:38:42 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: decoder: jpeg: Align with new API/ABI changes in codecparser Signed-off-by: Sreerenj Balachandran 2015-07-22 09:31:02 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 800bdb2 ed13220: mpegvideometa: add meta transform function 18d5efd: codecparsers: jpeg: add some padding to ScanHdr struct 7a51722: codecparsers: jpeg: fix docs for table parsing functions 06b8ded: codecparsers: jpeg: fix validity checking of data parsed 387a39d: codecparsers: jpeg: fix up API db9d6a9: codecparsers: jpeg: tweak API a little bb6951e: codecparsers: jpeg: hide gst_jpeg_scan_for_marker_code() f33c30c: codecparsers: jpeg: fix and optimize scan for next marker code 4658c30: codecparsers: jpeg: fix calculation of segment size 759bcb9: codecparsers: jpeg: fix default Huffman tables generation b4811ee: codecparsers: jpeg: add JPEG bitstream parser 9422464: h264parse: fix typo in log message 9e793a0: h264parse: Move PAR calcs, and use them for stereoscopic half-aspect 77704ce: nalutils: trivial patch to check if 8bb9249: codecparsers: mpeg4: actually return full number of bits of resync marker 7862f95: Revert "codecparsers: remove ignored increment of return" 54017b1: h264parse: Add support for passing stereoscopic/multiview info 8667ee4: h264parse: Don't switch to passthrough on set_caps() Signed-off-by: Sreerenj Balachandran 2015-06-29 14:27:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: track previous reference frames. Improve closure of gaps in frame_num by strictly following and trying to fill them with previous reference frames. So, they are now tracked thus avoiding insertion of dummy ("greenish") frames. 2015-06-29 13:16:09 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix integration of second field into the DPB. If the new picture to be added to the DPB is not a first field, then it shall be the second field of the previous picture that was added before. This removes the need for dpb_find_picture() now that we track the immediately preceding decoded picture, in decode order. 2015-07-06 14:38:26 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix closure of "other-field" gap. When a dummy "other-field" is inserted, it is assumed to inherit the reference flags from the first field, and the sliding window decoded reference picture marking process is also executed so that corrupted frames are moved out as early as possible. While doing so, we also try to output frames that now contain a single valid field picture, prior to inserting any other picture into the DPB. Note: this may be superfluous currently based on the fact that dpb_add() combines the two most recent pairable fields, but this process would be further simplified later on. 2015-06-24 13:58:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: track corrupted frames. Mark the picture as "corrupted" if it is reconstructed from corrupted references or if those references are fake, e.g. resulting from lost frames. This is useful for notifying the upper layer, or downstream elements, that the decoded frame may contain artefacts. https://bugzilla.gnome.org/show_bug.cgi?id=703921 2015-06-24 13:48:46 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst/vaapi/gstvaapidecode.c: decoder: add initial infrastructure for marking corrupted output. Add initial infrastructure in core codec library and vaapidecode to mark corrupted frames as such. A corrupted frame is such a frame that was reconstructed from invalid references for instance. https://bugzilla.gnome.org/show_bug.cgi?id=751434 Signed-off-by: Gwenole Beauchesne 2015-07-15 18:18:49 +0300 Sreerenj Balachandran * configure.ac: Bump version for development === release 0.6.0 === 2015-07-15 15:49:38 +0300 Sreerenj Balachandran * configure.ac: 0.6.0 2015-07-15 15:49:19 +0300 Sreerenj Balachandran * NEWS: NEWS: updates 2015-07-14 19:39:20 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiprofile.c: vaapidecoder: no wmv profiles gstreamer 1.4/1.2 This patch fix the auto-plugging problem in gstreamer 1.2 and gstreamer 1.4 Right now there is not a primary ranked parser for vc1 and the demuxers delivers caps without specifying the profile. This situation is not an issue for avdec_vc1 but for vaapidecode it is, which refuses to negotiate without a explicit profile defined in the negotiated caps. Nonetheless, in gstreamer 1.5 it seems not to be a problem since the negotiation admits caps subsets try outs. This patch solves the issue ignoring the profile negotiation in the caps. For gstreamer < 1.5 the profile string is not handled, so the auto-plugging get done without the vc1 parser, such as happens in gstreamer 1.5. Signed-off-by: Víctor Manuel Jáquez Leal 2015-07-07 20:57:20 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapi.c: Marking rank of vaapidecodebin as GST_RANK_MARGINAL for now. Unfortunately vaapidecodebin element is not seems to be stable enough for autoplugging ahead of vaapidecode. Lowering the rank for now (cosidering the immediate 0.6 release). See this: https://bugzilla.gnome.org/show_bug.cgi?id=749554 Signed-off-by: Sreerenj Balachandran 2015-07-07 13:32:18 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: build: Add missing CFLAGS to Makefile.am 2015-07-03 15:07:02 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapifilter.c: gstvaapifilter: Only register STE property if it supported by corresponding VA library Fix the regression introduced in commit eb465fb. VAProcFilterSkinToneEnhancement is avaialbe from VA >= 0.36. Signed-off-by: Sreerenj Balachandran 2015-07-02 17:49:25 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: no format convert on GL tex upload meta When GL texture upload meta is negotiated, vaapipostproc shall not modify the color format of the buffer. https://bugzilla.gnome.org/show_bug.cgi?id=748184 2015-07-03 12:42:09 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapifilter.c: gstvaapifilter: Add guard for VAProcFilterSkinToneEnhancement VAProcFilterSkinToneEnhancement is avaialbe from VA >= 0.36. Signed-off-by: Sreerenj Balachandran 2015-07-02 21:57:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder:h265: Fix the check for packed-header support Use VA_ENC_PACKED_HEADER_* definition for checking. Signed-off-by: Sreerenj Balachandran 2015-07-02 21:37:56 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder:h264: Fix the check for packed-header support Use VA_ENC_PACKED_HEADER_* definition for checking. Signed-off-by: Sreerenj Balachandran 2015-07-02 21:00:14 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: submit SEI buffering_period() and picture_timing() messages for CBR mode One buffering_period() SEI message shall be present in every IDR access unit when NalHrdBpPresentFlag is inferred to be equal to 1. This is the case when we use a non-CQP mode, e.g. CBR. In other words, when nal_hrd_parameters_present_flag is set to 1. One picture_timing() SEI messages shall be present in every access unit if CpbDpbDelaysPresentFlag is equal to 1 or pic_struct_present_flag is equal to 1 https://bugzilla.gnome.org/show_bug.cgi?id=722734 https://bugzilla.gnome.org/show_bug.cgi?id=751831 Signed-off-by: Sreerenj Balachandran 2015-07-01 14:16:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: vaapidecodebin: notify if vpp is disabled When the system is aware that VPP is not available by the VA driver, it would be useful to notify to the user that the disable-vpp property has changed. https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-07-01 14:17:17 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: enable vpp if it is available Instead of creating and adding VPP into the bin at setup, we wait until we are sure the VA driver supports it. We know that when the VA video context is received by the bin. Afterwards, it is decided to instanciate and link the VPP or not. This is more efficient and safer than waiting the VPP to fail and then disable it. https://bugzilla.gnome.org/show_bug.cgi?id=749554 2015-07-02 12:29:32 +0300 Sreerenj Balachandran * tests/test-display.c: * tests/test-windows.c: tests: Fix compilation while enabling egl as the only renderer in build Include missing header files gstvaapidisplay_egl.h and gstvaapiwindow_egl.h. 2015-07-02 10:45:50 +0300 Sreerenj Balachandran * configure.ac: configure: fix the build while enabling egl as the only renderer 2015-07-02 10:25:25 +0300 Sreerenj Balachandran * configure.ac: libs: Bump library major version 2015-06-30 09:44:18 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: gst/vaapi: Switch to upstreram like indentation. gst-indent for all gst/vaapi/*.c source files 2015-06-30 09:35:37 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: Add property to disable VPP Adding a new propery "disable-vpp", enabling it will prevent the insertion of vaapipostproc child element. This is helpful in debugging, specifically to narrow-down the vaapidecodebin/vaapipostproc related negotiation issues. No support for run-time disabling for now. https://bugzilla.gnome.org/show_bug.cgi?id=745901 2015-06-29 13:35:59 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Fix wrong selection of passthrough mode. The Current code path is falling back to passthorugh mode if there is no vpp property set by the user explictily. But we should not use the passthrough mode if the negotiated src pad caps have a differnt color space format than sink pad caps (Even though the user didn't set the format property explicitly). https://bugzilla.gnome.org/show_bug.cgi?id=748184 Signed-off-by: Sreerenj Balachandran 2015-06-29 13:20:28 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: vaapipostproc: prevent advanced-deinterlacing of non-native video formats. This is a workaround to deal with the va-intel-driver for non-native formats while doing advanced deinterlacing. The format of reference surfaces must be same as the format used by the driver internally for motion adaptive deinterlacing and motion compensated deinterlacing. A permanent solution could be to do the color space conversion internally for reference surfaces. https://bugzilla.gnome.org/show_bug.cgi?id=730925 Signed-off-by: Sreerenj Balachandran 2015-06-29 13:06:30 +0300 Simon Farnsworth * gst/vaapi/gstvaapisink.c: Work around ABBA deadlock between vaapisink and vaapipostproc vaapisink takes the display lock, then does a gst_buffer_replace which can take the lock on the gst_vaapi_video_pool. vaapipostproc asks the gst_vaapi_video_pool for a new surface. This takes the lock on the gst_vaapi_video_pool; if you're unlucky, there are no free surfaces, which means that gst_vaapi_surface_create is called. gst_vaapi_surface_create takes the display lock. If vaapisink and vaapipostproc are in different threads, and this happens, you get a deadlock. vaapisink holds the display lock, and wants the gst_vaapi_video_pool lock. vaapipostproc holds the gst_vaapi_video_pool lock and wants the display lock. Work around this by releasing the display lock in vaapisink around the gst_buffer_replace. https://bugzilla.gnome.org/show_bug.cgi?id=738249 Signed-off-by: Simon Farnsworth Signed-off-by: Sreerenj Balachandran 2015-04-29 16:34:07 +0200 Jacobo Aragunde Pérez * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: expose deinterlace-method property from inner vaapipostproc https://bugzilla.gnome.org/show_bug.cgi?id=745901 2015-05-19 11:24:10 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: log negotiated caps 2015-05-18 14:30:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: remove useless debug message 2015-02-12 12:31:57 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: log negotiated src/sink caps 2015-05-07 15:57:26 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: error handling if rendering fails This patch enhance the code path when an error is found when rendering a buffer. If the video meta doesn't contain a surface proxy or a surface, a warning message is printed. If the rendering backend fails, a error message is posted in the bus. https://bugzilla.gnome.org/show_bug.cgi?id=749382 2015-06-18 14:55:12 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: Fix the conditional pad template creation. 2015-06-18 13:19:26 +0300 Sreerenj Balachandran * tests/Makefile.am: build: Don't build simple-encoder test program if there is no VA Encoding support This will fix the build error against older VA-APIs <= 0.32 2015-06-18 12:20:37 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapicompat.h: Fix build error for older VA-API versions Provide guards for VA_SURFACE_ATTRIB_MEM_TYPE_KERNEL_DRM and VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME which are only availble from VA >= 0.36. 2015-06-17 14:20:37 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: Fix the capsfeature advertisement in padtemplate This fixes the regression introduced in 64acc74. If a pad supports multiple set of capsfeatures, it needs to add multiple equal structures with different feature sets to the caps. Because caps structures with the same name but with a non-equal set of caps features are not compatible. Without this patch, playbin will autoplug xvimagesink instead of vaapisink. https://bugzilla.gnome.org/show_bug.cgi?id=750095 2015-06-17 12:41:28 +0300 Adrian Cox * gst/vaapi/gstvaapisink.c: vaapisink: Expose the overlay capability for compatibility with dvbsuboverlay. https://bugzilla.gnome.org/show_bug.cgi?id=750095 Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2015-06-17 09:53:29 +0300 Olivier Crete * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: Override downstream allocation reply if no pool If the downstream replied without a pool, then override it. https://bugzilla.gnome.org/show_bug.cgi?id=748559 2015-06-09 15:15:31 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add color balance interface https://bugzilla.gnome.org/show_bug.cgi?id=720376 2015-05-22 18:13:25 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add skin tone enhancement Added the 'skin-tone-enhancement' property to vaapostproc. https://bugzilla.gnome.org/show_bug.cgi?id=744088 2015-05-20 18:02:37 +0200 Víctor Manuel Jáquez Leal * docs/reference/libs/libs-docs.xml.in: doc: add VA-API reference in freedesktop 2015-06-04 19:03:44 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0001-plugins-compile-the-built-in-video-parsers-as-vaapip.patch: * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: * patches/videoparsers/0003-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: patches/videoparsers: rebase all the h264parse patches In order to avoid the creation of .orig files and break the distcheck target 2015-06-04 18:29:15 +0200 Víctor Manuel Jáquez Leal * ext/libvpx/Makefile.am: build: don't build in parallel libvpx This fixes the distcheck -j XX target. 2015-06-02 08:52:53 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: encoder: jpeg: Fix the packed header generation This is a work-around to satisfy the va-intel-driver. Normalize the quality factor and scale QM values (only for packed header generation) similar to what VA-Intel driver is doing . Otherwise the generated packed headers will be wrong, since the driver itself is scaling the QM values using the normalized quality factor. https://bugzilla.gnome.org/show_bug.cgi?id=748335 Signed-off-by: Sreerenj Balachandran 2015-06-02 11:46:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix uninitialized variables in avcC mode. Fix uninitialized variables when decoding SPS and PPS NAL units from "codec-data" buffers. This is particularly important when seeking ops are involved, and the new persistent states are used more often. https://bugzilla.gnome.org/show_bug.cgi?id=750094 2015-06-01 18:39:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove unneeded casting And a code-style fix 2015-05-21 19:38:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: calculate decoding latency This is a naïve approach to the calculation of the VA-API decoding latency. It takes into consideration when the frame-rate has some insane value. https://bugzilla.gnome.org/show_bug.cgi?id=740419 2015-05-21 23:16:14 +1000 Jan Schmidt * configure.ac: configure: Compiling against libgstgl requires libgstvideo Fix detection of the GstGL helper headers in uninstalled builds. 2015-05-28 10:52:48 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: hevc: Fix the size over-flow for encoded buffer. The approximation of 6 times compression ratio migh not work in all cases. Especially when enabling I frames. Provide large enough size for coded-buffer creation. 2015-05-28 10:43:20 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: encoder: vp8: Fix the size over-flow for encoded buffer. The approximation of 4 times compression ratio will not work in all cases. Especially when enabling I frames. Provide large enough size for coded-buffer creation. 2015-05-28 05:43:49 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: encoder: hevc: fix bug in multi slice encoding. This is a work-around for satisfying the VA-Intel driver. The driver only support slices begin from CTU row start address. Multi-Slice encoding also requires a fix in va-intel-driver: http://lists.freedesktop.org/archives/libva/2015-May/003351.html https://bugzilla.gnome.org/show_bug.cgi?id=749854 Signed-off-by: Sreerenj Balachandran 2015-03-12 22:57:22 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add initial support for loss of pictures. Implement decoding process for gaps in frame_num (8.5.2). This also somewhat supports unintentional loss of pictures. https://bugzilla.gnome.org/show_bug.cgi?id=745048 https://bugzilla.gnome.org/show_bug.cgi?id=703921 Original-patch-by: Wind Yuan [fixed derivation of POC, ensured clone is valid for reference, actually fixed detection of gaps in FrameNum by PrevRefFrameNum] Signed-off-by: Gwenole Beauchesne 2015-05-22 11:42:52 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add support for missing first field. Try to identify missing first fields too, thus disregarding any intermediate gaps in frames. We also assume that we keep the same field sequence, i.e. if previous frames were in top-field-first (TFF) order, then so are subsequent frames. Note that insertion of dummy first fields need to operate in two steps: (i) create the original first field that the current field will inherit from, and (ii) submit that field into the DPB prior to initializing the current (other) field POC values but after any reference flag was set. i.e. copy reference flags from the child (other field) to the parent (first field). https://bugzilla.gnome.org/show_bug.cgi?id=745048 2015-05-07 14:00:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add support for missing second field. Interlaced H.264 video frames always have two fields to decode and display. However, in some cases, e.g. packet loss, one of the field can be missing. This perturbs the reference picture marking process, whereby the number of references available in DPB no longer matches the expected value. This patch adds initial support for missing field within a decoded frame. The current strategy taken is to find out the nearest field, by POC value, and with the same parity. https://bugzilla.gnome.org/show_bug.cgi?id=745048 2015-05-22 17:06:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: improve tracking of "top-field-first" flag. Try to maintain a "top-field-first" (TFF) flag, even if the H.264 standard does not mandate it. This will be useful for tracking missing fields, and also for more correct _split_fields() implementation for frames in the DPB. 2015-05-05 11:56:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: skip all pictures prior the first I-frame. Don't try to decode pictures until the first I-frame is received within the currently active sequence. There is no point is decoding and then displaying frames with artifacts. 2015-05-12 15:36:10 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix processing of EOSEQ NAL. Fix decoding of end_of_seq() NAL unit so that to not submit the current picture for decoding again. This is pretty vintage code that dates back before the existing of the whole decoder units machinery. One issue that could be arising if that code was kept is that we could have submitted a picture, and subsequently a GstVideoCodec frame, twice. Once without the decode_only flag set, and once with that flag set. The end result is that the GstVideoDecoder would release the codec frame twice, thus releasing stale data. In short, the piece of code that is removed by this patch is for once completely obsolete for a while, and secondly error-prone in corner cases. 2013-02-28 15:26:36 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: add utility function to clone picture objects. https://bugzilla.gnome.org/show_bug.cgi?id=703921 Signed-off-by: Wind Yuan [added cosmetic changes, fixed propagation of "one-field" flag to children, fixed per-codec clone modes (h264)] Signed-off-by: Gwenole Beauchesne 2015-05-27 23:49:18 +0300 Alban Browaeys * gst/vaapi/Makefile.am: build: don't compile HEVC encoder if not supported Fix: (gst-plugin-scanner:16681): GStreamer-WARNING **: Failed to load plugin '/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstvaapi.so': /usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstvaapi.so: undefined symbol: gst_vaapi_encoder_h265_get_default_properties https://bugzilla.gnome.org/show_bug.cgi?id=749954 Signed-off-by: Alban Browaeys Signed-off-by: Sreerenj Balachandran 2015-05-27 23:43:16 +0300 Alban Browaeys * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: HEVC: decode: add missing va_dec_hevc header Signed-off-by: Alban Browaeys Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=749953 2015-05-26 13:28:32 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix PTS cache for GOP start. If the GOP temporal sequence number (TSN) is interpolated from a valid PTS, then we need to compensate that PTS corresponding to the start of GOP with the next picture to be decoded, which shall be an I-frame, based on its sequence number. https://bugzilla.gnome.org/show_bug.cgi?id=748676 2015-05-27 10:49:56 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: avoid crash when seeking with debug logs Move down the debug message when the state of the decoder is verified so the slice header is not NULL. 2014-12-17 00:41:10 +1100 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: Avoid crashes and warnings on re-opened decoder after a seek Reset state and add some checks for safe state to avoid a crash and a warning after the decoder is destroyed/recreated during a seek. 2015-05-26 10:21:59 +0300 Sreerenj Balachandran * patches/videoparsers/0003-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: * patches/videoparsers/series.frag: patches/videoparsers: Rebase the patch on top of gst-vaapi-branch commit 20ee952 Signed-off-by: Sreerenj Balachandran 2015-05-26 10:03:20 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 20ee952 b7dded3: h264parse: don't consider unknown stream-format as avc 5110ad9: h264parse: fix up handling of input caps corner cases e51db3e: h264parse: Remove dead code 3d739d0: codecparser: h265: Fix the number of tile rows/columns parsing 8482957: h265parse: Fix profile, tier and level setting in caps 4649acb: h265parse: Fix the memory freeing of stored VPS nals f2beeb7: h265parse: Fix source caps to report cropped dimensions 6886a31: h264parse: Fix profile and level setting in caps 5286c1a: h264parse: Consider SEI NALU as "HEADER" packets eb97854: videoparsers: h264: bit-exact sync with upstream, minor changes here and there 53074fc: build: Upgrade GStreamer dependency to 1.0 Signed-off-by: Sreerenj Balachandran 2015-05-26 06:01:10 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: HEVC: decode: Replace clip3 implementation with glib CLAMP macro Signed-off-by: Sreerenj Balachandran 2015-05-26 05:33:33 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: HEVC: decode: Update Cropping Rectangle Signed-off-by: Sreerenj Balachandran 2015-05-25 11:58:20 +0300 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_h265.c: * gst/vaapi/gstvaapiencode_h265.h: HEVC_Encode: Add HEVC(h265) Encoder plugin https://bugzilla.gnome.org/show_bug.cgi?id=748874 Signed-off-by: Sreerenj Balachandran 2015-05-25 11:38:34 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h265.c: * gst-libs/gst/vaapi/gstvaapiencoder_h265.h: HEVC_Encode: Add HEVC(h265) encoder to core libgstvaapi https://bugzilla.gnome.org/show_bug.cgi?id=748874 Signed-off-by: Sreerenj Balachandran 2015-05-25 11:26:14 +0300 Sreerenj Balachandran * configure.ac: HEVC_Encode: build: Check availability of VA APIs for H265 encoding. Signed-off-by: Sreerenj Balachandran https://bugzilla.gnome.org/show_bug.cgi?id=748874 2015-05-25 10:58:52 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.h: gstvaapiutils_h265: Add H265 Tier specific utility functions -- New API: gst_vaapi_utils_h265_get_tier_from_string() -- New API: gst_vaapi_utils_h265_get_tier_string() https://bugzilla.gnome.org/show_bug.cgi?id=748874 Signed-off-by: Sreerenj Balachandran 2015-05-19 10:57:42 +0200 Víctor Manuel Jáquez Leal * docs/reference/plugins/Makefile.am: doc: conditional linking for scanner Add x11 library only if it is enabled. https://bugzilla.gnome.org/show_bug.cgi?id=749018 2015-05-19 10:37:13 +0200 Víctor Manuel Jáquez Leal * docs/reference/plugins/plugins.types: doc: fix scanner compilation warning https://bugzilla.gnome.org/show_bug.cgi?id=749018 2015-05-06 16:19:23 +0200 Víctor Manuel Jáquez Leal * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: doc: update sections and symbols https://bugzilla.gnome.org/show_bug.cgi?id=749018 2015-05-13 10:38:24 +0200 Víctor Manuel Jáquez Leal * .gitignore: * Makefile.am: * debian.upstream/Makefile.am: * docs/Makefile.am: * docs/reference/Makefile.am: * docs/reference/libs/Makefile.am: * docs/reference/plugins/Makefile.am: * ext/Makefile.am: * ext/libvpx/Makefile.am: * git.mk: * gst-libs/Makefile.am: * gst-libs/gst/Makefile.am: * gst-libs/gst/base/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst/Makefile.am: * gst/vaapi/Makefile.am: * patches/Makefile.am: * patches/videoparsers/Makefile.am: * pkgconfig/Makefile.am: * tests/Makefile.am: build: use git.mk This patch handles dinamically the gitignore files with git.mk[1]. Removed the automake variable MAINTAINERCLANFILES in most of the Makefile.am files since now it is handled by the top one. 1. https://github.com/behdad/git.mk/blob/master/git.mk https://bugzilla.gnome.org/show_bug.cgi?id=749321 2015-05-07 11:28:15 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: sync() when destroy() Before pushing a the new frame, the render() method calls sync() to flush the pending frames. Nonetheless, the last pushed frame never gets rendered, leading to a memory leak too. This patch calls sync() in the destroy() to flush the pending frames before destroying the window. Also a is_cancelled flag is added. This flag tells to not flush the event queue again since the method failed previously or were cancelled by the user. https://bugzilla.gnome.org/show_bug.cgi?id=749078 2015-05-07 15:55:40 +0200 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst/vaapi/gstvaapisink.c: vaapisink: implement unlock/unlock_stop for wayland Otherwise wl_display_dispatch_queue() might prevent the pipeline from shutting down. This can happen e.g. if the wayland compositor exits while the pipeline is running. Changes: * renamed unlock()/unlock_stop() to unblock()/unblock_cancel() in gstvaapiwindow * splitted the patch removing wl_display_dispatch_queue() Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=747492 https://bugzilla.gnome.org/show_bug.cgi?id=749078 2015-05-07 12:33:34 +0200 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: wl_display_dispatch_queue() can block forever. wl_display_dispatch_queue() might prevent the pipeline from shutting down. This can happen e.g. if the wayland compositor exits while the pipeline is running. This patch replaces it with these steps: - With wl_display_prepare_read() all threads announce their intention to read. - wl_display_read_events() is thread save. On threads reads, the other wait for it to finish. - With wl_display_dispatch_queue_pending() each thread dispatches its own events. wl_display_dispatch_queue_pending() was defined since wayland 1.0.2 Original-patch-by: Michael Olbrich * stripped out the unlock() unlock_stop() logic * stripped out the poll handling Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749078 https://bugzilla.gnome.org/show_bug.cgi?id=747492 2015-05-07 18:30:33 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: rename frame for last_frame Since frame in the private data means the last frame sent, it would semantically better use last_frame. Also, this patch makes use of g_atomic_pointer_{compare_and_exchange, set}() functions. https://bugzilla.gnome.org/show_bug.cgi?id=749078 2015-05-07 11:18:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: use a counter as sync flag Wayland window has a pointer to the last pushed frame and use it to set the flag for stopping the queue dispatch loop. This may lead to memory leaks, since we are not keeping track of all the queued frames structures. This patch removes the last pushed frame pointer and change the binary flag for an atomic counter, keeping track of number of queued frames and use it for the queue dispatch loop. https://bugzilla.gnome.org/show_bug.cgi?id=749078 2015-05-07 10:36:17 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: decouple wl_buffer from frame This patch takes out the wayland's buffer from the the frame structure. The buffer is queued to wayland and destroyed in the "release" callback. The frame is freed in the surface's "done" callback. In this way a buffer may be leaked but not the whole frame structure. - surface 'done' callback is used to throttle the rendering operation and to unallocate the frame, but not the buffer. - buffer 'release' callback is used to destroy wl_buffer. Original-patch-by: Zhao Halley * code rebase * kept the the event_queue for buffer's proxy Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=749078 2015-05-14 16:22:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: fix indentation 2015-05-13 11:54:01 +0200 Víctor Manuel Jáquez Leal * debian.upstream/Makefile.am: * ext/libvpx/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: * tests/Makefile.am: build: fix make distcheck This patch fixes several issues found when running the `make distcheck` target: - In commit c561b8da, the update of gstcompat.h in Makefile.am was forgotten. - In commit c5756a91 add the simple_encoder_source_h in EXTRA_DIST was forgotten. - vpx.build.stamp is not generated at all, only vpx.configure.stamp. - The make target distcleancheck failed because some autogenerated files were not handled with the DISTCLEANFILES variable. Note: `make distcheck -jXX` is not currently supported. 2015-05-13 13:28:17 +0200 Víctor Manuel Jáquez Leal * patches/videoparsers/0001-plugins-compile-the-built-in-video-parsers-as-vaapip.patch: * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: * patches/videoparsers/0004-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: h264parse: update patches with upstream These patches didn't applied cleanly, breaking the `make distcleancheck` target. Re-sync'ed the patches against the current git's submodule. 2015-05-12 16:04:33 +0200 Gwenole Beauchesne * tests/simple-encoder.c: tests: simple-encoder: fix build warnings on 64-bit platforms. Add a cosmetic change to replace VAAPI buffer with VA buffer and most importantly fix warnings spitted out during build on 64-bit platforms. ../../tests/simple-encoder.c:211:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘gssize’ [-Wformat=] g_warning ("Invalid VAAPI buffer size (%d)", size); ^ ../../tests/simple-encoder.c:217:5: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘gssize’ [-Wformat=] g_warning ("Failed to create output buffer of size %d", size); ^ 2015-05-08 15:54:09 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapivideocontext.h: plugins: remove gstreamer-0.10 crumbs GstVideoContext was used in gstreamer-0.10, which is not supported anymore. Still, its definition was still in the code. This patch removes it. https://bugzilla.gnome.org/show_bug.cgi?id=749113 2015-05-05 13:08:25 +0200 Víctor Manuel Jáquez Leal * tests/Makefile.am: * tests/simple-encoder.c: * tests/y4mreader.c: * tests/y4mreader.h: tests: add simple-encoder program This patch adds a simple-encoder test program that uses libgstvaapi for video encoding to elementary (raw) streams. Input stream is raw YUV in the Y4M format. That can be from a regular file or standard input when the input filename is "-". Usage: simple-encoder [options]* Options: --output|-o output file name --codec|-c codec to use for video encoding --bitrate|-b desired bitrate (kbps) By default, and as an initial patch, the encoded stream shall conform to the minimally supported profile. That is "Constrained Baseline Profile" for H.264 and "Simple Profile" for MPEG-2. Though, those are the defaults to be generated by libgstvaapi. You can find Y4M sample files here http://samples.mplayerhq.hu/yuv4mpeg2/ Original-patch-by: Changzhi Wei * general code clean-up * removed the yuv reader thread * re-wrote the y4m file parser * updated used API fixed some wrong usage * fixed a lot of memory leaks * added the bitrate setting * keep fps' numerator and denominator * simplified the thread control * removed custom logging and use glib Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=719528 2015-05-05 13:02:19 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder.h: libs: trivial documentation fix GST_VAAPI_ENCODER_STATUS_NO_SURFACE and GST_VAAPI_ENCODER_STATUS_NO_BUFFER are not errors, so they do not have the ERROR namespace. This patch fixes this typo in documentation. 2015-02-15 15:01:03 +0000 Simon Farnsworth * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: window: Correct prototype to match implementation On s390x, guintptr and GstVaapiID are not compatible types. The implementation of gst_vaapi_window_new_internal() and all its callers seem to assume that its third argument is a GstVaapiID, while the header gives it guintptr type. https://bugzilla.gnome.org/show_bug.cgi?id=744559 2015-05-04 14:24:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: vaapidecode: add guards for disabled codecs. Fix link when building plugin elements without HEVC support. e.g. don't try to call into gst_vaapi_decoder_h265_set_alignment() if there is no support HEVC enabled in libgstvaapi. Also, drop disabled codecs from static template caps. Add the missing HEVC static template caps into vaapidecodebin too. 2015-04-30 13:29:48 +0200 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/glibcompat.h: build: upgrade glib dependency to 2.32 Since bug #745728 was fixed the oldest supported version of GStreamer is 1.2. That GStreamer release requires glib 2.32, so we can upgrade our requirement too. This patch changes the required version of glib in configure.ac and removes the hacks in glibcompat.h https://bugzilla.gnome.org/show_bug.cgi?id=748698 2015-04-30 13:21:08 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: check if the pool config is already set In commit 97b768, a regression for GStreamer 1.2 was introduced: GStreamer 1.2 doesn't check, in gst_buffer_pool_set_config() if the config option is already set. This patch adds an inline function to first verify if the option is not in the pool config berfore add it. 2015-04-29 12:39:50 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: vaapipostproc: tune up a couple of log messages In order to reduce the noise, the query type log was downgrade from INFO to DEBUG, and the shared display address log message is assigned to the object. 2015-04-29 12:27:43 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: check gst_buffer_pool_set_config() Check the return value of gst_buffer_pool_set_config(). If it fails an error message is posted in the bus. 2015-04-29 12:24:52 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: more specific log message Be more specific in the log message about the reason of creating a new pool. 2015-04-29 12:22:29 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: delete unused variable need_pool is a boolean variable extracted from the allocation query, but it is not used afterwards. 2015-04-27 19:21:12 -0400 Olivier Crete * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: Update the pool if there was no pool in the downstream reply Fix regression introduced by bd866479, the query after decide_allocation() always needs a pool in the first slot. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=748559 2015-04-27 20:50:19 -0400 Olivier Crete * gst/vaapi/gstvaapivideobufferpool.c: videopool: Free members before chaining up finalize The finalize function in GObject frees the object memory, so everything else needs to have been freed before. https://bugzilla.gnome.org/show_bug.cgi?id=748563 2015-04-27 20:31:50 -0400 Olivier Crete * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: don't leak the registry proxy Release the registry proxy when closing the display. https://bugzilla.gnome.org/show_bug.cgi?id=748564 2015-04-21 17:17:06 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: refactor _sync() method and rename callback This patch only intends to improve readability: in the method gst_vaapi_window_wayland_sync() the if/do instructions are squashed into a single while loop. Also renames the frame_redraw_callback() callback into frame_done_callback(), which is a bit more aligned to Wayland API. 2015-02-03 16:52:06 +0100 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: free frame in buffer release callback The Wayland compositor may still use the buffer when the frame done callback is called. This patch destroys the frame (which contains the buffer) until the release callback is called. The draw termination callback only controls the display queue dispatching. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=747492 2015-04-21 10:00:36 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: refactor gst_vaapidecode_internal_flush() This a cosmetic refactor: gst_vaapidecode_internal_flush() removes its only label; gst_vaapidecode_finish() is more readable and gst_vaapidecode_purge() shares the same error message of gst_vaapidecode_internal_flush() when flush fails. 2015-04-20 13:27:27 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: refactor gst_vaapidecode_destroy() Add the method gst_vaapidecode_purge(). This method releases the flushed frames from the decoder. This new method add more readablity to gst_vaapidecode_destroy() 2015-04-16 12:53:18 -0400 Olivier Crete * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst/vaapi/gstvaapidecode.c: vaapidecode: Tell the base class about released frames on close The base class needs to be informed about frames that were still queued in the decoder on release, otherwise they are leaked. https://bugzilla.gnome.org/show_bug.cgi?id=747999 2015-04-19 11:19:03 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: reduce logging noise When a frame is rejected by downstream, the message is logged twice. This patch removes one of those logging messages. Also, the reject of a frame doesn't mean an alarming error. This patch demotes the log message from error to info. 2015-04-16 20:18:13 -0400 Olivier Crete * gst/vaapi/gstvaapidecode.c: vaapidecode: Use the GstVideoDecoder error reporting function This way, the decoder won't stop on the first decoding error, in most cases it can recover after some glitchiness. https://bugzilla.gnome.org/show_bug.cgi?id=744620 2015-04-17 19:10:35 +0000 Olivier Crete * gst/vaapi/gstvaapipluginbase.c: vaapipluginbase: The allocation query can return without a pool It is possible to return the min/max/size without actually providing a pool. This way the source knows how many buffers downstream needs. https://bugzilla.gnome.org/show_bug.cgi?id=748076 2015-04-17 16:45:22 +0300 Sreerenj Balachandran * ext/Makefile.am: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapiparse.c: * gst/vaapi/gstvaapiparse.h: * patches/videoparsers/0001-h265parse-include-gstvaapiparse.h.patch: * patches/videoparsers/series.frag: plugins: Add h265 videoparser element "vaapiparse_h265" This is a mirror of h265parse element in upstream gst-plugins-bad. There could be additional patches but all should go to upstream. This is for making development faster. Note: vaapiparse_h265 will get build only for GStreamer version >= 1.4 2015-04-17 15:44:04 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 43a0368 45f1c28: codecparser: h265: Fix nal unit size checking f25987b: codecparser: h265: Calculate crop rectangle dimensions 639573a: codecparser: h265: Fix parsing multiple SEI messages in a single SEI Nal 4c8ec41: Add h265 videoparser plugin source files 2015-04-17 10:10:10 +0200 Gwenole Beauchesne * autogen.sh: autogen: drop videoutils submodule. 2015-04-17 10:36:25 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: cosmetics. Mostly coding style updates. Avoid integer signess inconsistencies. Optimize dpb_find_lowest_poc() to align with original h264's decoder. 2015-04-16 14:13:59 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Add Support for tiled video decoding Based up on the value of uniform_spacing_flag in Picture Parameter Set, the tile column width and tile row height should be calculated. Equations: 6-1, 6-2 Tiled video Descriptions: 7.3.2.3, 7.4.3.3 2015-04-16 14:13:21 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: decoder: hevc: Fix decoding when there are RASL pictures present. -- Set NoRaslOutputFlag based on EOS and EOB Nal units -- Fix PicOutputFlag setting for RASL picture -- Fix prev_poc_lsb/prev_poc_msb calculation -- Drop the RASL frames if NoRaslOutputFlag is TRUE for the associated IRAP picture -- Fixed couple of crashes and added cosmetics 2015-04-14 10:54:54 +0100 Martin Sherburn * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: display: drm: fix race condition setting device type There is a race condition where g_drm_device_type can be left set to DRM_DEVICE_RENDERNODES when it shouldn't. If thread 1 comes in and falls into the last else statement setting up both RENDERNODES and LEGACY types. And begins to process the first type (RENDERNODES), it sets g_drm_device_type = RENDERNODES. Now when thread 2 comes in and sees g_drm_device_type is RENDERNODES, it queues up that type to be tried but then encounters the lock and has to wait until the first thread finishes. Once the lock is acquired it will then proceed to ONLY try RENDERNODES and fail it. But it doesn't try LEGACY. And from then on, all future attempts will only try RENDERNODES. So to avoid this situation I have simply moved the acquisition of the lock higher up in the attached patch. https://bugzilla.gnome.org/show_bug.cgi?id=747914 2015-04-15 15:26:12 -0400 Olivier Crete * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Don't create filter on caps query The problem with this is that creating the filter causes the display to be selected, and the caps query happens while linking the element. So, if the downstream or upstream element is using a specific display object, it won't be propagated correctly to the postproc as it already has a display at this point. https://bugzilla.gnome.org/show_bug.cgi?id=747945 2015-04-15 15:20:17 -0400 Olivier Crete * gst-libs/gst/vaapi/gstvaapivideopool.c: videopool: Release lock while allocating new object The video pool can be accessed with the display lock held, for example, when releasing a buffer from inside vaapisink_render, but allocating a new object can may also take the display lock. Which means a possible deadlock. https://bugzilla.gnome.org/show_bug.cgi?id=747944 2015-04-15 17:26:43 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: vaapisink: use GstVideoSink vmethod show_frame() vaapisink inherits from GstVideoSink, in order to use its functionality (such as ::show-preroll-frame property), we should use its vmethod show_frame(), rather than call ourselves render() and preroll(). 2015-04-15 18:16:47 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add 'handoff' signal This patch adds the signal ::handoff and the property signal-handoffs. If the property is set TRUE, the signal ::handoff is emitted just after the buffer is rendered. Based on Zhao Halley https://bugzilla.gnome.org/show_bug.cgi?id=747905 2015-04-14 10:17:16 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: HEVC: silence the compiler Fixed a couple of clang complains. 2015-02-02 16:42:43 +0100 Michael Olbrich * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: destroy vpp buffer pool on resize Otherwise the old buffers with the old size are used. https://bugzilla.gnome.org/show_bug.cgi?id=747491 2015-04-14 10:08:47 +0200 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/Makefile.am: build: don't compile HEVC if not supported HEVC decoding was added recently libva-1.5. This patch avoids HEVC decoding support in libgstvaapi if it is not available in the installed libva. https://bugzilla.gnome.org/show_bug.cgi?id=747831 2015-04-13 16:04:59 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Update Author name in plugin metadata 2015-04-13 15:43:30 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: plugins: Add HEVC decoder Signed-off-by: Sreerenj Balachandran 2015-04-13 15:41:45 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_h265.c: * gst-libs/gst/vaapi/gstvaapidecoder_h265.h: HEVC: Add HEVC(h265) decoder to core libgstvaapi Signed-off-by: Sreerenj Balachandran 2015-04-13 14:53:46 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_h265.c: * gst-libs/gst/vaapi/gstvaapiutils_h265.h: * gst-libs/gst/vaapi/gstvaapiutils_h265_priv.h: HEVC: Add codec utility methods to core libgstvaapi Signed-off-by: Sreerenj Balachandran 2015-04-13 14:52:53 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: HEVC: gstvaapiprofile: Add profile definitions Signed-off-by: Sreerenj Balachandran 2015-04-13 14:52:14 +0300 Sreerenj Balachandran * configure.ac: HEVC: build: Check availability of h265 decoder APIs Signed-off-by: Sreerenj Balachandran 2015-04-13 14:51:51 +0300 Sreerenj Balachandran * configure.ac: * ext/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: HEVC: Allow to build h265 codecparser internally Signed-off-by: Sreerenj Balachandran 2015-04-08 18:05:20 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: * gst-libs/gst/vaapi/gstvaapisurface.c: guard buffer export API if not available The support for buffer exports in VA-API was added in version 0.36. These interfaces are for interop with EGL, OpenCL, etc. GStreamer-VAAPI uses it for a dmabuf memory allocator. Though, gstreamer-vaapi has to support VA-API versions ranging from 0.30.4, which doesn't support it. This patch guards all the buffer exports handling (and dmabuf allocator) if the detected VA-API version is below 0.36. https://bugzilla.gnome.org/show_bug.cgi?id=746405 2015-04-13 11:29:35 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: Update to gst-vaapi-branch commit 9bc72b0 767bf22: codecparsers: h265: add helpers to convert quantization matrices 71c8e93: codecparser: h265: skip byte alignment bits while parsing slice header 3bf0355: codecparsre: h265: Fix the NumDeltaPocs calculation 10e2087: codecparser: h265: Fix the NumPocTotalCurr calculatio 2d753b8: codecparser: h265: Fix nal size calculation for EOS and EOB 2014-12-11 12:02:38 +0100 Michael Olbrich * gst/vaapi/gstvaapidecode.c: vaapidecode: unref video codec frame twice We get one reference when the frame is passed to decode_handle_frame() and create another one in gst_vaapi_decoder_push_frame(). Usually the frame is handled in gst_vaapidecode_push_decoded_frame(). Here the frame is always released twice: gst_video_decoder_finish_frame() + gst_video_codec_frame_unref() or gst_video_decoder_drop_frame() + gst_video_codec_frame_unref(). In gst_vaapidecode_reset_full() both references to the frame must be released as well. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=743226 2015-04-08 18:20:34 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: libs: remove unused variables clang reports these unused variables. Let's get rid of them. This patch is a missing part of commit c82e5173 https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:38:07 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: decoder: mpeg4: remove an spurious comparison The member size in GstMpeg4Packet is gsize which is unsigned, which cannot be less than zero. Hence this pre-condition test is a no-op. This patch removes that code. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:33:44 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: casts slice_param->slice_type slice_type in slice_param is defined as (char *), but it is compared against a signed integer. clang complains about this comparison. This patch casts the variable. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:31:47 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: encoder: avoid GstVaapiCodedBuffer redefinition The symbol GstVaapiCodedBuffer is already defined in gst-libs/gst/vaapi/gstvaapicodedbuffer.h which is loaded, at the end, by gstvaapiencoder_objects.h. Clang complains about the symbol re-definition. This patch removes that redefinition. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:28:22 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: libs: remove unused variables clang reports these unused variables. Let's get rid of them. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:27:24 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: mpeg2: use fabsf() instead of abs() The member value in frame_rate_tab is float, the result of the abs() function should be float too. But abs() only manages integers. This patch replaces abs() with fabsf() to handle correctly the possible floats values. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-03 20:02:29 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: decoder: cast GST_VAAPI_DECODER_STATUS_DROP_FRAME Since GST_VAAPI_DECODER_STATUS_DROP_FRAME is not part of the enum GstVaapiDecoderStatus, we need to cast it to avoid compiler complains. https://bugzilla.gnome.org/show_bug.cgi?id=747312 2015-04-04 00:40:29 +0300 Sreerenj Balachandran * README: Update README 2015-04-04 00:06:56 +0300 Sreerenj Balachandran * .gitmodules: * README: Changing source code download links from https://gitorious to https://github -- gitmodules: Change gstreamer-codecparsers submodule source download link -- README: Change the gstreamer-vaapi webpage link 2015-04-03 23:30:24 +0300 Sreerenj Balachandran * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 1f792e4 87f4a7e: bytereader: add gst_byte_reader_peek_sub_reader() and _get_sub_reader() 7d8ba7a: bytereader: use unchecked inline variant for get_remaining in more places 2528ea6: bytereader: add gst_byte_reader_masked_scan_uint32_peek 2b92a67: h264parse: reset the parser information when caps changes 05eee86: codecparsers: Indent file e27a38b: codecparsers: Add READ_UE_MAX macro 2036471: Constify some static arrays everywhere 2015-04-03 17:45:08 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_x11.c: Remove the gstvaapivideoconverter_*.c source files missed in commit 51b1e4a 2015-04-03 17:09:08 +0300 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: * gst/vaapi/gstvaapivideoconverter_glx.h: * gst/vaapi/gstvaapivideoconverter_x11.h: * gst/vaapi/gstvaapivideomemory.h: * gst/vaapi/gstvaapivideometa_texture.c: Removal of gstreamer-1.0 support The support for GStreamer 1.0 has been obsoleted in 0.5.10 release. GStreamer 1.2 is the a minimal requirement for building the gstreamer-vaapi. This patch removes all the pre-processor conditional code compilation guarded for gstreamer-1.0. Thus, all the video converters were removed too. https://bugzilla.gnome.org/show_bug.cgi?id=745728 Signed-off-by: Gwenole Beauchesne Signed-off-by: Sreerenj Balachandran 2015-04-03 17:08:30 +0300 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/sysdeps.h: * gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiparse.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_x11.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa_texture.c: * tests/codec.c: update and move gstcompat.h The purpose of gstcompat.h is to couple the API differences among gstreamer-1.0 and gstreamer-0.10. Since gstreamer-0.10 is obsolete, the code in this compatibility layer shall be removed. Nevertheless, the gstcompat.h header should be kept, if new incompatibilites appear in the future, but it shall live in gst/vaapi, not in gst-libs. This patch removes the crumbs defined gstcompat.h and moves it to gst/vaapi. In order to avoid layer violations, gstcompat.h includes sysdeps.h and all the includes in gst/vaapi of sysdeps.h are replaced with gstcompat.h https://bugzilla.gnome.org/show_bug.cgi?id=745728 Signed-off-by: Gwenole Beauchesne Signed-off-by: Sreerenj Balachandran 2015-04-03 17:05:45 +0300 Víctor Manuel Jáquez Leal * configure.ac: * gst/vaapi/Makefile.am: autotools: remove gstreamer-1.0 support This patch only removes the support of gstreamer-1.0 in the autotools scripts. No other files are touched. In the automake file all the converters were deprecated. https://bugzilla.gnome.org/show_bug.cgi?id=745728 Signed-off-by: Gwenole Beauchesne Signed-off-by: Sreerenj Balachandran 2015-04-03 17:03:38 +0300 Sreerenj Balachandran * .gitmodules: * ext/Makefile.am: * ext/videoutils: Remove the gstreamer-videoutils submodule 2015-04-03 17:01:45 +0300 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/video/Makefile.am: * gst/vaapi/Makefile.am: * tests/Makefile.am: Remove libgstvaapi-videoutils.so This library was intended to add the base classes for video decoders which where not included in gstreamer-0.10. Since the support of gstreamer-0.10 is deprecated those classes are not required, thus the whole library is removed. https://bugzilla.gnome.org/show_bug.cgi?id=745728 https://bugzilla.gnome.org/show_bug.cgi?id=732666 Signed-off-by: Gwenole Beauchesne 2015-04-03 16:55:43 +0300 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/gstvaapicontext_overlay.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * tests/test-subpicture.c: Remove HAVE_GST_VIDEO_OVERLAY_HWCAPS macro This macro guarded the use of HAVE_GST_VIDEO_OVERLAY_HWCAPS, which was not defined before gstreamer 0.10.35. Since the support of gstreamer-0.10 is deprecated these guards are not required. https://bugzilla.gnome.org/show_bug.cgi?id=745728 https://bugzilla.gnome.org/show_bug.cgi?id=732666 Signed-off-by: Gwenole Beauchesne 2015-04-03 16:55:27 +0300 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapicontext_overlay.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiparse.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_x11.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: * tests/test-filter.c: * tests/test-subpicture.c: Removal of gstreamer-0.10 support This patch removes all the pre-processor conditional code compilation guarded for gstreamer-0.10. https://bugzilla.gnome.org/show_bug.cgi?id=745728 https://bugzilla.gnome.org/show_bug.cgi?id=732666 Signed-off-by: Gwenole Beauchesne 2015-04-03 16:54:54 +0300 Víctor Manuel Jáquez Leal * configure.ac: * debian.upstream/control.in: * gst-libs/gst/video/Makefile.am: * gst/vaapi/Makefile.am: autotools: remove gstreamer-0.10 support This patch only removes the support of gstreamer-0.10 in the autotools scripts. No other files are touched. The configuration parameter --gstreamer-api was deleted since now it is always auto-detected. The verification of vmethod query in GstBaseSinkClass was removed since it was added in gstreamer 0.10.35. The same case for GstVideoOverlayComposition and its format flags. The precious variable GST_PLUGIN_PATH was removed, while GST_PLUGIN_PATH_1_0 remained. The automake files were changed accordingly. Removed, in debian/control, the vaapiupload and vaapidownload descriptions. https://bugzilla.gnome.org/show_bug.cgi?id=732666 https://bugzilla.gnome.org/show_bug.cgi?id=745728 Signed-off-by: Gwenole Beauchesne 2015-03-16 23:38:18 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: add drain() vmethod In GStremer v1.6 a new vmethod drain() was added in GstVideoDecoder class. This patch implements this new method. https://bugzilla.gnome.org/show_bug.cgi?id=742922 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-03-16 23:37:29 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: remove vmethod reset() Since in bug #745728 the support for GStreamer 1.0 is going to be dropped, this patch removes the method reset() which was deprecated in GStreamer 1.2. https://bugzilla.gnome.org/show_bug.cgi?id=742922 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-03-16 23:36:33 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: handle flush() vmethod Since GStreamer 1.2 the vmethod reset() in GstVideoDecoderClass was deprecated and flush() was added. This patch set the vmethod flush() if the installed GStreamer version is 1.2 or superior. Otherwise, reset() is set. v2: 1) In order to avoid symbol collision, the old method gst_vaapidecode_flush() was renamed to gst_vaapidecode_internal_flush(). 2) The new vmethod flush() always do a hard full reset. v3: 1) Call gst_vaapidecode_internal_flush() first in flush() vmethod, in order to gather all collected data with gst_video_decoder_have_frame() https://bugzilla.gnome.org/show_bug.cgi?id=742922 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-03-16 23:10:53 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: call the correct query function In commit 2f8c115 (vaapidecode: use the query virtual methods in 1.4) a bug was introduced: when calling the parent's query function of the src pad, the one of the sink pad is called instead. This patch fixes this issue. https://bugzilla.gnome.org/show_bug.cgi?id=746248 2015-03-15 00:36:45 +0200 Sreerenj Balachandran * .gitmodules: gitmodules: Use https:// url instead of git:// for submodules. Gitorious is failing to clone repositories over git:// url. 2015-03-14 22:12:19 +0200 Julien Isorce * gst-libs/gst/vaapi/gstvaapidisplay.c: vaapidisplay: mark X11 display as compatible with EGL GST_GL_WINDOW=x11 GST_GL_API=gles2 GST_GL_PLATFORM=egl gst-launch-1.0 ... ! vaapidecode ! glimagesink https://bugzilla.gnome.org/show_bug.cgi?id=745902 Signed-off-by: Víctor Manuel Jáquez Leal 2015-03-06 15:20:01 +0200 Olivier Crete * gst/vaapi/gstvaapidecode.c: vaapidecode: Don't crash if a buffer outlives the decoder Sometimes, for example, when switching video streams but keeping the same sink, the surface will be released after the decoder is stopped and replaced. This caused a crash because the release callback was called on an invalid pointer. The patch adding an additional reference to the decoder object in the buffer. https://bugzilla.gnome.org/show_bug.cgi?id=745189 Signed-off-by: Olivier Crete Signed-off-by: Sreerenj Balachandran 2015-03-06 14:31:21 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: clean-ups (indentation, drop unused variables) 2015-03-06 14:09:22 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: use the query virtual methods in 1.4 GstVideoDecoder, the base class of vaapidecode, added support for pad queries as virtual methods. This patch enables the use of that support, while keeping support for lower versions of gstreamer. This patch is important because GstVideoDecoder takes care of other queries that might be important in the pipeline managing. v2: 1) rebase to current master 2) fix indentation with gst-indent 3) simplify the patch layout 4) fix the context query 5) initialise the filter to NULL 6) improve the query log message for gst-1.2 https://bugzilla.gnome.org/show_bug.cgi?id=744406 2015-03-06 12:16:17 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: always activate buffer pool The vaapipostproc has a proxy flag to know if the the buffer pool is already active. But this fails in some situations where it is needed to renegotiate the buffer pool. This patch removes that flag so the renegotiation is done whenever is required. https://bugzilla.gnome.org/show_bug.cgi?id=745535 2015-03-02 17:04:20 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix minor memory leak in debug mode. The gst_video_colorimetry_to_string() function returns a newly created string that represents the GstVideoColorimetry value. So, that needs to be released after usage, in e.g. GST_DEBUG(). 2015-03-03 12:37:41 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecodebin.h: vaapidecodebin: Avoid usage of "__" prefix in macro names Avoiding "__" prefix usage in Header File Guards as per C standard recommendation. 2015-03-03 12:31:11 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapi.c: plugins: Disable vaapidecodebin for GStreamer < 1.4 There are autoplugging issues in GStreamer-1.2. Lets disable vaapidecodebin untill we get some workarounds for this. 2015-03-02 15:19:40 +0200 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecodebin.c: * gst/vaapi/gstvaapidecodebin.h: plugins: Add a vaapidecodebin element Add a "vaapidecodebin" element to vaapi plugins. Child Elements: "vaapidecode ! queue ! vaapipostproc" The Reasons for implementing a new bin element: -- Help to Autoplug Hardware Accelerated Video Postprocessing element in playbin with out any dependency to upstream gstreamer. This is to overcome the *unacceptable* delay in upstream gstreamer to get new features in. Eg: https://bugzilla.gnome.org/show_bug.cgi?id=687182. Also customers using older gstreamer versions (1.2 and 1.4) will get the benefit of autoplugging, hardware accelerated deinterlacing support etc. -- Help to maintain a single thread implementation in vaapidecode. This will result a dead-lock free vaapidecode in most of the cases. More details here: https://bugzilla.gnome.org/show_bug.cgi?id=742605 https://bugzilla.gnome.org/show_bug.cgi?id=745216 2015-03-02 14:59:16 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: re-indent (gst-indent) gstvaapidecode.c 2015-03-02 14:46:38 +0200 Simon Farnsworth * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: Switch back to Single thread implementation Because the decoder uses the thread from handle_frame() to decode a frame, the src pad task creates an unsolveable AB-BA deadlock between handle_frame() waiting for a free surface and decode_loop() pushing decoded frames out. Instead, have handle_frame() take responsibility for pushing surfaces, and remove the deadlock completely. If you need a separate thread downstream, you can insert a queue between vaapidecode and its downstream to get one. Another justification for the single thread implementation is, there are two many point of locking in gstreamer-vaapi's current implementation which can lead to deadlocks. https://bugzilla.gnome.org/show_bug.cgi?id=742605 Signed-off-by: Simon Farnsworth Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-03-02 13:28:41 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: plugins: fix detection of upstream v4l2src element. Improve check for upstream element that requires DMABUF buffer pool, e.g. v4l2src element. In particular, make sure to traverse through any additional capsfilter for instance. Note: the traversal to the top-most upstream element could be made more generic, but we are insofar only interested in supporting pipes similar to v4l2src or v4l2src ! capsfilter, e.g. with an explicit specification for a desired video camera format, or resolution. 2015-03-02 11:12:53 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: fix allocation of DMABUF memory. The dmabuf allocator would close the DMABUF handle passed in the init function gst_dmabuf_allocator_alloc(). So, we need to dup() it so that to avoid a double close, ultimately in the underlying driver that owns the DMABUF handle. 2015-02-26 12:28:02 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: keep src caps and output state in sync vaapidecode keeps an output state that use the format GST_VIDEO_FORMAT_ENCODED, while it crafts a different src caps for a correct negotiation. I don't see the rational behind this decoupling, it looks like unnecessary complexity. This patch simplify this logic keeping in sync the output state and the src caps. This patch improves the readability of the function gst_vaapidecode_update_src_caps() and simplify its logic. Also, the patch validates if the buffer pool has the configuration for the GL texture upload meta, in order to set the caps feature meta:GLTextureUpload. Otherwise, the I420 format is set back. https://bugzilla.gnome.org/show_bug.cgi?id=744618 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-02-26 12:26:54 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: upload meta only if feature and allocation When vaapidecode finishes the decoding of a frame and pushes it, if, in the decide_allocation() method, it is determined if the next element supports the GL texture upload meta feature, the decoder adds the buffer's meta. Nonetheless, in the same spirit of the commit 71d3ce4d, the determination if the next element supports the GL texture upload meta needs to check both the preferred caps feature *and* if the allocation query request the API type. This patch, first removes the unused variable need_pool, and determines the attribute has_texture_upload_meta using the preferred caps feature *and* the allocation query. Also, the feature passed to GstVaapPluginBase is not longer determined by has_texture_upload_meta, but by the computed preferred one. https://bugzilla.gnome.org/show_bug.cgi?id=744618 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-02-26 12:24:55 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapidecode: delayed src caps negotiation Currently the src caps are set immediately after the sink caps are set, but in that moment the pipeline might not fully constructed and the video sink has not negotiated its supported caps and features. As a consequence, in many cases of playback, the least optimized caps feature is forced. This is partially the responsible of bug #744039. Also, vaapidecode doesn't attend the reconfigure events from downstream, which is a problem too, since the video sink can be changed with different caps features. This patch delays the src caps, setting them until the first frame arrives to the decoder, assuming until that very moment the whole pipeline is already negotiated. Particularly, it checks if the src pad needs to be reconfigured, as a consequence of a reconfiguration event from downstream. A key part of this patch is the new GstVaapiCapsFeature GST_VAAPI_CAPS_FEATURE_NOT_NEGOTIATED, which is returned when the src pad doesn't have a peer yet. Also, for a better report of the caps allowed through the src pad and its peer, this patch uses gst_pad_get_allowed_caps() instead of gst_pad_peer_query_caps() when looking for the preferred feature. v3: move the input_state unref to close(), since videodecoder resets at some events such as navigation. v4: a) the state_changed() callback replaces the input_state if the media changed, so this case is also handled. b) since the parameter ref_state in gst_vaapidecode_update_src_caps() is always the input_state, the parameter were removed. c) there were a lot of repeated code handling the input_state, so I refactored it with the function gst_vaapi_decode_input_state_replace(). https://bugzilla.gnome.org/show_bug.cgi?id=744618 Signed-off-by: Víctor Manuel Jáquez Leal Signed-off-by: Sreerenj Balachandran 2015-02-24 17:14:33 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: encoder: h264: add support for more than 2 views Add support for H.264 MVC Multiview High profile encoding with more than 2 views. All views within the same accesss unit are provided in increasing order of view order index (VOIdx). Upto 10 view are supported for now. A new property "view-ids" has been provided for the plugins to set the view ids (which is an array of guint values) to be used for mvc encoding. https://bugzilla.gnome.org/show_bug.cgi?id=732453 2015-02-23 16:55:36 +0100 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginbase.c: plugins: upload meta only if feature and allocation Working on bug #743687, I realized that vaapidecode always adds to its buffer pool the config option GST_BUFFER_POOL_OPTION_VIDEO_GL_TEXTURE_UPLOAD_META if the decide_allocation()'s query has GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE. Nevertheless, there are occasions where the query has the API type, but the last negotiated caps don't have the feature meta:GstVideoGLTextureUploadMeta. Under this contradiction, vaapidecode adds the GLTextureUploadMeta API to its buffer pool configuration, and adds its buffer's meta to each output buffer, even if the negotiated caps feature is memory:SystemMemory with I420 color format. This kind of output buffers chokes ClutterAutoVideosSink, since it uses a map that relates caps <-> GL upload method. If it receives a buffer with color format I420, it assumes that it doesn't have a texture upload meta, because only those with RGB color format has it. Our buffers, with I420 format, say that they have the upload meta too. In that case the mapped method is a dummy one which does nothing. I reported this issue in bug #744039 (the patch, obviously, was rejected). This patch workarounds the problem: the buffer pool's configuration option GST_BUFFER_POOL_OPTION_VIDEO_GL_TEXTURE_UPLOAD_META is set if and only if the query has the GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE *and* the negotiated caps feature is meta:GstVideoGLTextureUploadMeta. I have tested these patches with gst-master (1.5), gst-1.4 and gst-1.2 and in all they seem to work correctly. https://bugzilla.gnome.org/show_bug.cgi?id=744618 [adapted to fit current EGL changes] Signed-off-by: Gwenole Beauchesne 2015-02-20 15:13:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: * gst/vaapi/gstvaapivideometa_texture.c: plugins: add support for GstVideoGLTextureOrientation. Add support for GstVideoGLTextureOrientation modes. In particular, add orientation flags to the GstVaapiTexture wrapper and the GLX implementations. Default mode is that texture memory is laid out with top lines first, left row first. Flags indicate whether the X or Y axis need to be inverted. 2015-02-09 21:09:07 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapivideometa_texture.c: plugins: add support for BGRA textures. Some frameworks (EFL) expect BGRA textures for storage. However, adding support for that broadly into GStreamer framework implies two kinds of hacks: (i) libgstgl helpers currently do not support BGRA textures correctly, (ii) we need to better parse downstream suggested caps and intersect them with what the VA plugin elements can offer to them for GL texturing. 2015-01-23 09:31:57 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: plugins: fix support for Wayland/EGL running alongside X11. When multiple display servers are available, the glimagesink element (from GStreamer 1.4) may not be able to derive a global display in Wayland. Rather, a "window"-specific display is created. In this case, the GstGLDisplay handle available through GstGLContext is invalid. So, try to improve heuristics for display server characterisation in those particular situations. 2015-02-20 15:29:17 +0100 Gwenole Beauchesne * configure.ac: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideometa_texture.c: plugins: add initial support for EGL. Add initial support for EGL through GstVideoGLTextureUploadMeta. Fix gst_vaapi_ensure_display() to allocate a GstVaapiDisplay off the downstream supplied GstGLContext configuration, i.e. use its native display handle to create a GstVaapiDisplay of type X11 or Wayland ; and use the desired OpenGL API to allocate the GstVaapiDisplayEGL wrapper. https://bugzilla.gnome.org/show_bug.cgi?id=741079 2014-12-09 11:46:58 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa_texture.c: plugins: track video texture size changes. Sync video texture sizes to GstVideoGLTextureUploadMeta private date, i.e. GstVaapiVideoMetaTexture, on a regular basis. In particular, we now update the texture size from the GstVideoMeta, if any, or reset to some defaults otherwise. 2014-12-03 15:45:52 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: plugins: ensure VA display matches GL context expectations. If a GstGLContext is supplied by the downstream element, then make sure that the VA plugin element gets a compatible display to what is requested by the GL context. e.g. re-allocate a VA/GLX display when a GLX context is provided by the downstream element. 2014-12-03 14:14:30 +0100 Gwenole Beauchesne * configure.ac: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: record downstream GstGLContext. Record GL context supplied by downstream elements. This can be useful, and further needed, to enforce run-time check that the GL context is compatible for use by libgstvaapi. e.g. check that we don't create a VA/GLX display for EGL/X11 contexts. https://bugzilla.gnome.org/show_bug.cgi?id=725643 Original-path-by: Matthew Waters 2014-12-01 14:52:39 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/output.c: egl: update tests. Add initial support for EGL to tests. The new EGL backend can be selected through the --egl command line option. The OpenGL|ES version can further be selected with the --gles-version command line option, where the default of 0 means "desktop" OpenGL. 2015-01-27 16:21:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: * gst-libs/gst/vaapi/gstvaapiwindow_egl.c: * gst-libs/gst/vaapi/gstvaapiwindow_egl.h: egl: add windowing support. This provides for some basic EGL window abstraction. 2015-01-24 08:29:57 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapitexture_egl.c: * gst-libs/gst/vaapi/gstvaapitexture_egl.h: egl: add texture abstraction. Add GstVaapiTextureEGL abstraction that can create its own GL texture, or import a foreign allocated one, while still allowing updates from a VA surface. 2014-12-09 18:14:56 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapisurface_egl.c: * gst-libs/gst/vaapi/gstvaapisurface_egl.h: egl: allow for EGLImage imports into VA Surfaces. Add helpers to import EGLImage objects into VA surfaces. There are two operational modes: (i) gst_vaapi_surface_new_from_egl_image(), which allows for implicit conversion from EGLImage to a VA surface in native video format, and (ii) gst_vaapi_surface_new_with_egl_image(), which exactly wraps the source EGLImage, typically in RGBA format with linear storage. Note: in case of (i), the EGLImage can be disposed right after the VA surface creation call, unlike in (ii) where the user shall ensure that the EGLImage is live until the associated VA surface is no longer needed. https://bugzilla.gnome.org/show_bug.cgi?id=743847 2015-02-20 15:27:53 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/egl_compat.h: * gst-libs/gst/vaapi/egl_vtable.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl.c: * gst-libs/gst/vaapi/gstvaapidisplay_egl.h: * gst-libs/gst/vaapi/gstvaapidisplay_egl_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_egl.c: * gst-libs/gst/vaapi/gstvaapiutils_egl.h: * gst-libs/gst/vaapi/ogl_compat.h: Add initial support for EGL. Add initial support for EGL to libgstvaapi core library. The target display server and the desired OpenGL API can be programmatically selected at run-time. A comprehensive set of EGL utilities are provided to support those dynamic selection needs, but also most importantly to ensure that the GL command stream is executed from within a single thread. https://bugzilla.gnome.org/show_bug.cgi?id=743846 2015-01-30 21:38:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivalue.c: libs: initialize GValues in a thread-safe manner. 2015-01-30 21:35:10 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivalue.c: libs: re-indent all GValue related source code. 2015-01-22 22:45:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: partially revert 0777f35. Reset the VA decoder after updating the base plugin caps, and most importantly, after GstVideoDecoder negotiation. The reason behind this is that the negotiation could trigger a last decide_allocation() where we could actually derive a new GstVaapiDisplay to use from the downstream element. e.g. GLX backend. 2015-02-19 13:37:09 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Caps query should return the list of all supported caps. Query caps filtering should be always done on top of allowed caps instead of existing fixed caps on a particular pad. This fixes the mvc stream decoding when there is a base view(high profile) and non-base view(stereo-high profile). 2015-02-18 13:36:16 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: intersect filter from query caps According to documentation[1] when receiving a GST_QUERY_CAPS the return value should be all formats that this elements supports, taking into account limitations of peer elements further downstream or upstream, sorted by order of preference, highest preference first. This patch add those limitations intersecting with the received filter in the query. Also takes into account the already negotiated caps. Also adds the processing of the query on the SRC pad. 1. http://gstreamer.freedesktop.org/data/doc/gstreamer/head/pwg/html/section-nego-getcaps.html https://bugzilla.gnome.org/show_bug.cgi?id=744406 2015-02-18 11:46:11 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst/vaapi/gstvaapivideomemory.c: Fix compiler warnings This patch fixes some warnings that gcc 4.9 reports. https://bugzilla.gnome.org/show_bug.cgi?id=744411 2015-02-18 11:22:21 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: Use GST_DEBUG_FUNCPTR for gst_vaapidecode_query() Hence the function name is shown in the gst-inspect-1.0 information rather than the memory address. https://bugzilla.gnome.org/show_bug.cgi?id=744330 2015-02-18 11:21:35 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: vaapidecode: log flow error name https://bugzilla.gnome.org/show_bug.cgi?id=744387 2015-02-18 11:20:42 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: VC1: decoder: Ignore VC1 user BDU's Don't return error if the processed BDU is a user one, just ignore them. https://bugzilla.gnome.org/show_bug.cgi?id=741237 Signed-off-by: Sreerenj Balachandran 2015-02-18 11:19:26 +0200 Olivier Crete * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: vaapidecode: Emit error GstMessage when returning a GST_FLOW_ERROR This is required in GStreamer, elements should never return GST_FLOW_ERROR without posting an ERROR message on the bus. https://bugzilla.gnome.org/show_bug.cgi?id=744620 2015-02-13 13:45:32 +0200 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_vp8.c: * gst/vaapi/gstvaapiencode_vp8.h: plugins: Add VP8 Encoder 2015-02-13 13:42:04 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.c: * gst-libs/gst/vaapi/gstvaapiencoder_vp8.h: Add VP8 Encoder to core libgstvaapi. 2015-02-13 13:40:19 +0200 Sreerenj Balachandran * configure.ac: configure: Add Check for VP8 Encoding API 2015-02-10 11:40:16 +0200 Lim Siew Hoon * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: vc1: Rounding control handling for VC1 simple and Main profile Added rounding control handling for VC1 simple and Main profile based on VC1 standard spec: section 8.3.7 https://bugzilla.gnome.org/show_bug.cgi?id=743958 Signed-off-by: Lim Siew Hoon Signed-off-by: Sreerenj Balachandran 2015-02-06 12:10:51 +0200 Sreerenj Balachandran * gst/vaapi/Makefile.am: build: fix make dist when certain conditionals not met. Fix typo which was preventing the inclusion of jpeg encoder source files from make dist (when there is no jpeg encoder API support in libva). 2015-02-05 13:08:53 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: encoder: jpeg: Fix the sampling factor calculation for ENCODED format. If the incoming raw video format is GST_VIDEO_FORMAT_ENCODED, use native YUV420 format (which is i420) as default. 2015-02-05 12:13:38 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: encoder: Only support YUV420 native format as input for now Practically we should be able to support more formats, for eg: JPEG Encoder can support YUV422, RGBA and all. But this is causing more issues which need proper fix here and there. 2015-02-04 18:34:59 +0200 Olivier Crete * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst/vaapi/gstvaapidecode.c: vaapidecode: Check the condition after taking the lock Otherwise the condition could become true before the lock is taken and the g_cond_signal() could be called before the g_cond_wait(), so the g_cond_wait() is never awoken. https://bugzilla.gnome.org/show_bug.cgi?id=740645 2015-02-04 11:18:29 +0200 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_jpeg.c: * gst/vaapi/gstvaapiencode_jpeg.h: plugins: Add JPEG encoder element 2015-02-04 11:17:58 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapicontext.c: gstvaapicontext: Add VAConfigAttribValEncJPEG to the attribute list using for VAConfig creation. 2015-02-04 11:17:27 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapicontext.c: gstvaapicontext: Don't use the unsupported Ratecontrol attributes for vaCreateConfig Don't add the VAConfigAttribRateControl to the attribute list using for the vaCreateConfig if it is not supported by the driver. 2015-02-04 11:17:06 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder: Use hardcoded packed_raw_data flag for JPEG Encoding 2015-02-04 11:16:37 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder: Fix crash when handling rate control mask Having a ratecontrol_mask equal to zero is not a bug, but the driver might not be supporting any kind of rate control mechanisms. Eg: JPEG Encoding 2015-02-04 11:16:05 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapiencoder_jpeg.h: encoder: Add JPEG Encoder 2015-02-04 11:15:38 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: encoder_objects: Add QuantizationMatrix and JPEGHuffmanTable 2015-02-04 11:15:00 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: Encode: Add support for Picture level Entrypoint This is useful for JPEG encoding which is utilizing picture level entrypoint instead of slice level entrypoint like h264,mpeg2 etc. 2015-02-04 11:14:15 +0200 Sreerenj Balachandran * configure.ac: configure: Add Check for JPEG encoding API 2015-02-03 13:08:53 +0200 Sreerenj Balachandran * AUTHORS: AUTHORS: Updates 2015-02-03 13:08:01 +0200 Sreerenj Balachandran * configure.ac: Bump version for development. === release 0.5.10 === 2015-02-03 10:00:42 +0200 Sreerenj Balachandran * configure.ac: 0.5.10 2015-02-03 10:00:23 +0200 Sreerenj Balachandran * NEWS: NEWS: Updates 2015-02-02 11:43:58 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapivideometa_texture.c: Fix compilation error if there is no GL/gl.h header file installed 2015-01-28 18:09:40 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.h: plugins: drop leftover declaration. GstVaapiVideoMemory quark is not needed any more, and the actual implementation was already removed bfore the merge. i.e. this is an oversight for a hunk that was not meant to be pushed. 2015-01-26 18:30:47 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: add support for dma_buf exports (v4l2src). Allow v4l2src element to connected to vaapipostproc or vaapisink when "io-mode" is set to "dmabuf-import". In practice, this is a more likely operational mode with uvcvideo. Supporting v4lsrc with "io-mode" set to "dmabuf" could work, but with more demanding driver or kernel reqs. Note: with GStreamer 1.4, v4l2src (gst-plugins-good) needs to be built with --without-libv4l2. https://bugzilla.gnome.org/show_bug.cgi?id=743635 2014-01-23 05:00:09 -0500 Wind Yuan * configure.ac: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginbase.c: plugins: add support for dma_buf imports. Allow imports of v4l2 buffers into VA surfaces for further operation with vaapi plugins, e.g. vaapipostproc or vaapiencode_* elements. https://bugzilla.gnome.org/show_bug.cgi?id=735362 [fixed memory leaks, ported to new dma_buf infrastructure, cleanups] Signed-off-by: Gwenole Beauchesne 2014-09-15 15:27:50 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: surface: add support for GEM buffer imports. Add support for GEM buffer imports. This is useful for VA/EGL interop with legacy Mesa implementations, or when it is desired or required to support outbound textures for instance. https://bugzilla.gnome.org/show_bug.cgi?id=736718 2014-09-15 15:25:09 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: surface: add support for dma_buf imports. Add new gst_vaapi_surface_new_with_dma_buf_handle() helper function to allow for creating VA surfaces from a foreign DRM PRIME fd. The resulting VA surface owns the supplied buffer handle. https://bugzilla.gnome.org/show_bug.cgi?id=735362 2015-01-27 11:19:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: surface: add initial support for foreign buffer imports. Add gst_vaapi_surface_new_from_buffer_proxy() helper function to create a VA surface from an external buffer provided throug the new GstVaapiBufferProxy object. 2014-09-15 13:47:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: surface: add support for GEM buffer exports. Add support for GEM buffer exports. This will only work with VA drivers based off libdrm, e.g. the Intel HD Graphics VA driver. This is needed to support interop with EGL and the "Desktop" GL specification. Indeed, the EXT_image_dma_buf_import extension is not going to be supported in Desktop GL, due to the lack of support for GL_TEXTURE_EXTERNAL_OES targets there. This is useful for implementing VA/EGL interop with legacy Mesa stacks, in Desktop OpenGL context. https://bugzilla.gnome.org/show_bug.cgi?id=736717 2014-09-15 11:48:05 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapisurface_drm.c: * gst-libs/gst/vaapi/gstvaapisurface_drm.h: surface: add support for dma_buf exports. Use the new VA buffer export APIs to allow for a VA surface to be exposed as a plain PRIME fd. This is in view to simplifying interop with EGL or OpenCL for instance. https://bugzilla.gnome.org/show_bug.cgi?id=735364 2014-09-15 10:58:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapibufferproxy.c: * gst-libs/gst/vaapi/gstvaapibufferproxy.h: * gst-libs/gst/vaapi/gstvaapibufferproxy_priv.h: Add abstraction for exported VA buffers. The VA buffer export APIs work for a particular lifetime starting from vaAcquireBufferHandle() and ending with vaReleaseBufferHandle(). As such, it could be much more convenient to support implicit releases by simply having a refcount reaching zero. https://bugzilla.gnome.org/show_bug.cgi?id=736721 2015-01-28 18:25:09 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/Makefile.am: Add missing header file to Makefile Add gstvaapitexture_glx.h to Makefile.am 2015-01-27 11:44:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: * tests/test-surfaces.c: videopool: add optional flags for surface pool allocation. Reword surface pool allocation helpers so that to allow for a simple form, e.g. gst_vaapi_surface_pool_new(format, width, height); and a somewhat more elaborated/flexible form with optional allocation flags and precise GstVideoInfo specification. This is an API/ABI change, and SONAME version needs to be bumped. 2015-01-26 23:21:56 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: videopool: re-indent all GstVaapiVideoPool related source code. 2014-12-10 20:13:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: window: add toplevel display indirection for visualid and colormap. Add GstVaapiDisplay::get_{visual_id,colormap}() helpers to help determine the best suitable window visual id and colormap. This is an indirection in view to supporting EGL and custom/generic replacements. 2014-12-10 19:58:10 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: window: add toplevel API to determine the colormap. Add GstVaapiWindowClass::get_colormap() hook to help determine the currently active colormap bound to the supplied window, or actually create it if it does not already exist yet. 2014-12-10 19:36:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: window: add toplevel API to determine a visual id. Add GstVaapiWindowClass::get_visual_id() function hook to help find the best suitable visual id for the supplied window. While doing so, also simplify the process by which an X11 window is created with a desired Visual, i.e. now use a visual id instead of a Visual object. 2014-12-10 18:12:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: window: add generic helper to create windows. Add a new generic helper function gst_vaapi_window_new() to create a window without having the caller to check for the display type himself. i.e. internally, there is now a GstVaapiDisplayClass hook to create windows, and the actual backend implementation fills it in. Add new generic helper functions gst_vaapi_texture_new_wrapped() This is a simplification in view to supporting EGL. 2014-12-03 11:39:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst/vaapi/gstvaapivideometa_texture.c: display: add utility function to check for OpenGL rendering. Add gst_vaapi_display_has_opengl() helper function to help determining whether the display can support OpenGL context to be bound to it, i.e. if the class is of type GST_VAAPI_DISPLAY_TYPE_GLX. 2014-12-10 18:02:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideometa_texture.c: display: refine the meaning of display type. Make gst_vaapi_display_get_display_type() return the actual VA display type. Conversely, add a gst_vaapi_display_get_class_type() function to return the type of the GstVaapiDisplay instance. The former is used to identify the display server onto which the application is running, and the latter to identify the original object class. 2014-12-02 11:23:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: cosmetics (helper macros, new internal API names). Add more helper macros to the top-level GstVaapiDisplay interfaces. Rename a few others used internally for improved consistency. 2014-12-01 17:08:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: display: record native display object. Record the underlying native display instance into the toplevel GstVaapiDisplay object. This is useful for fast lookups to the underlying native display, e.g. for creating an EGL display. 2014-12-01 16:54:32 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: use a recursive mutex for the display cache. Use a recursive mutex for the display cache so that a 3rdparty display object could be initialized during the initialization of the parent display. 2014-12-04 14:36:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: texture: add generic helper to create textures. Add new generic helper functions gst_vaapi_texture_new_wrapped() and gst_vaapi_texture_new() to create a texture without having the caller to uselessly check for the display type himself. i.e. internally, there is now a GstVaapiDisplayClass hook to create textures, and the actual backend implementation fills it in. This is a simplification in view to supporting EGL. 2014-10-23 17:44:23 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitexture_glx.c: * gst-libs/gst/vaapi/gstvaapitexture_glx.h: * gst-libs/gst/vaapi/gstvaapitexture_priv.h: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideometa_texture.c: * tests/test-textures.c: texture: move to core libgstvaapi base library. GstVaapiTexture is a generic abstraction that could be moved to the core libgstvaapi library. While doing this, no extra dependency needs to be added. This means that a GstVaapitextureClass is now available for any specific code that needs to be added, e.g. creation of the underlying GL texture objects, or backend dependent ways to upload a surface to the texture object. Generic OpenGL data types (GLuint, GLenum) are also replaced with a plain guint. https://bugzilla.gnome.org/show_bug.cgi?id=736715 2014-10-23 13:11:54 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapitexture.c: texture: drop support for VA/GLX interfaces. The VA/GLX interfaces are obsolete. They used to exist for XvBA, and ease of use, but they had other caveats to deal with. It's now better to move on to legacy mode, whereby VA/GLX interop is two be provided through (i) X11 Pixmap, and (ii) other modern means of buffer sharing. https://bugzilla.gnome.org/show_bug.cgi?id=736711 2014-10-23 11:56:31 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideometa_texture.c: * tests/test-textures.c: texture: add support for cropping rectangle during transfer. The gst_vaapi_texture_put_surface() function is missing a crop_rect argument that would be used during transfer for cropping the source surface to the desired dimensions. Note: from a user point-of-view, he should create the GstVaapiTexture object with the cropped size. That's the default behaviour in software decoding pipelines that we need to cope with. This is an API/ABI change, and SONAME version needs to be bumped. https://bugzilla.gnome.org/show_bug.cgi?id=736712 2014-10-23 11:22:10 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: texture: re-indent all GstVaapiTexture related source code. 2015-01-27 11:16:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: surface: add more fine-grained allocation helper. Add new gst_vaapi_surface_new_full() helper function that allocates VA surface from a GstVideoInfo template in argument. Additional flags may include ways to - allocate linear storage (GST_VAAPI_SURFACE_ALLOC_FLAG_LINEAR_STORAGE) ; - allocate with fixed strides (GST_VAPI_SURFACE_ALLOC_FLAG_FIXED_STRIDES) ; - allocate with fixed offsets (GST_VAAPI_SURFACE_ALLOC_FLAG_FIXED_OFFSETS). 2014-09-15 14:57:57 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: surface: re-indent all GstVaapiSurface related source code. 2015-01-23 16:44:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: surfaceproxy: add helper to create a wrapped surface object. Add new gst_vaapi_surface_proxy_new() helper to wrap a surface into a proxy. The main use case for that is to convey additional information at the proxy level that would not be suitable to the plain surface. 2015-01-23 16:37:06 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: surfaceproxy: re-indent all GstVaapiSurfaceProxy related source code. 2015-01-27 18:02:56 +0100 Gwenole Beauchesne * configure.ac: libs: bump library major version. 2014-12-04 14:36:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapitypes.h: libs: re-introduce a GST_VAAPI_ID_INVALID value. Re-introduce a GST_VAAPI_ID_INVALID value that represents a non-zero and invalid id. This is useful to have a value that is still invalid for cases where zero could actually be a valid value. 2014-12-02 16:51:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: libs: expose GstVaapiMiniObject APIs to all backends. Make it possible to have all libgstvaapi backends (libs) access to a common GstVaapiMiniObject API and implementation. This is a minor step towards full exposure when needed, but restrict it to libgstvaapi at this time. 2014-12-02 14:15:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: libs: re-indent all GstVaapiObject related source code. Re-indent and provide additional minor cosmetical changes to the GstVaapiMiniObject and GstVaapiObject source files. 2015-01-27 16:25:21 +0200 Simon Farnsworth * gst/vaapi/gstvaapipluginutil.c: pluginutil: Fix clearing of subtitle overlay dvbsuboverlay signals no subtitles present by not setting GstVideoOverlayCompositionMeta on a buffer. Detect this, and remove subtitles whenever we have no overlay composition to hand. Signed-off-by: Simon Farnsworth 2015-01-27 16:06:02 +0200 Michael Olbrich * gst/vaapi/gstvaapipostproc.c: vaapipostproc: clear state on stop Otherwise restarting may fail because the state of vaapipluginbase and vaapipostproc don't match. e.g. gst_vaapipostproc_set_caps() will skip initailization and not call gst_vaapi_plugin_base_set_caps() 2015-01-27 14:50:12 +0200 Michael Olbrich * gst/vaapi/gstvaapidecode.c: vaapidecode: don't print an error message for GST_FLOW_FLUSHING 2015-01-27 12:38:45 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder.c: gstvaapiencoder: Fix the negotiation issue with _ENCODED format handling Don't error out for the video format GST_VIDEO_FORMAT_ENCODED with in gstvaapiencoder, since the vaaapi context creation (gstvaapicontext.c) can still use the default chroma type which is YUV420. https://bugzilla.gnome.org/show_bug.cgi?id=743567 https://bugzilla.gnome.org/show_bug.cgi?id=743035 2015-01-21 18:31:22 +0200 Sreerenj Balachandran * patches/videoparsers/0003-h264parse-add-initial-support-for-MVC-NAL-units.patch: * patches/videoparsers/series.frag: h264parse: drop patches merged upstream. 0003-h264parse-add-initial-support-for-MVC-NAL-units.patch 2015-01-21 18:26:12 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit d3b5c1b 8194cac: h264parse: parse SPS subset 64b7f52: h264parse: expose stereo-high profile 774360a: h264parse: add initial support for MVC NAL units 258478f: h264parser: fix stack smashing 2015-01-19 11:30:12 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapivideometa_texture.c: Fix compilation error if there is no GL/gl.h header file installed 2015-01-15 16:23:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: commit updated srcpad caps to base plugin. Make sure that the GstVaapiPluginBase instance receives the new src pad caps whenever they get updated from within the GstVaapiDecoder decode routines. This also ensures that downstream elements receive correctly sized SW decoded buffers if needed. https://bugs.tizen.org/jira/browse/TC-114 2015-01-15 16:19:59 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: always reset decoder on ::set_format(). Split GstVideoDecoder::set_format() handler to first update the sink pad caps and reset the active VA decoder instance based on those, and then update the src pad caps whenever possible, e.g. when the caps specify a valid video resolution. 2015-01-15 16:14:13 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: don't crash when trying to allocate 0x0 images. In some occasions, a buffer pool is created for pre-initialization purposes regardless of whether a valid image size is available or not. However, during actual decode stage, the vaapidecode element is expected to update the srcpad caps with the new dimensions, thus also triggering a reset of the underlying bufferpool. 2015-01-15 00:00:16 +0200 Sreerenj Balachandran * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 191cb2f 347605a: h264parse: expose compatible profiles to downstream d1ea97e: h264parse: Fix periodic SPS/PPS sending work after a seek 24a3126: Revert "h264parse: expose compatible profiles to downstream" 8661740: h264parse: expose compatible profiles to downstream 8b7ef3f: codecparsers: fix some compiler warnings 2014-11-27 12:11:03 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Fix the period between I/P frames If the key-frame period is set as one, then ip_period shuld be zero https://bugzilla.gnome.org/show_bug.cgi?id=734992 2014-11-27 11:21:03 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: Provide intra_idr_period value for VAEncSequenceParameterBufferH264 https://bugzilla.gnome.org/show_bug.cgi?id=734993 2014-11-27 11:14:50 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: Protect the X11 API invokations with proper locking https://bugzilla.gnome.org/show_bug.cgi?id=739808 2014-11-27 11:13:20 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix pixel-aspect-ratio in encoded stream. Really report sample aspect ratio (SAR) as present, and make it match what we have obtained from the user as pixel-aspect-ratio (PAR). i.e. really make sure VUI parameter aspect_ratio_info_present_flag is set to TRUE and that the indication from aspect_ratio_idc is Extended_SAR. This is a leftover from git commit a12662f. https://bugzilla.gnome.org/show_bug.cgi?id=740360 2014-11-25 11:46:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: decoder: mpeg4: fix uninitialized variables. Fix gst_vaapi_decoder_mpeg4_parse() to initialize the packet type to GST_MPEG4_USER_DATA so that a parse error would result in skipping that packet. Also fix gst_vaapi_decoder_mpeg4_decode_codec_data() to initialize status to GST_VAAPI_DECODER_STATUS_SUCCESS. 2014-11-25 11:41:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix profile limits. Fix ensure_profile_limits() to lower profile to the desired limits, only if the latter are actually known and the profile needed to be changed to fit. 2014-11-24 15:14:37 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix out caps for GLMemory. If the best downstream capsfeature turns out to be GLMemory, then make sure to propagate RGBA video format in caps to that element. This fixes the following pipeline: ... ! vaapipostproc ! glimagesink. 2014-11-24 14:25:33 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix check for compatible src pad capsfilters. When an explicit output video format is selected, from an src pad capsfilter, make sure that the downstream element actually supports that format. In particular, fix crash with the following pipelines: ... ! vaapipostproc ! video/x-raw,format=XXX ! xvimagesink ; where XXX is a format not supported by xvimagesink. While doing so, also reduce the set of src pad filter caps to the actual set of allowed src pad caps. 2014-11-24 14:10:11 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapiuploader.h: plugins: re-indent all video processing related source code. 2014-11-24 13:20:33 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: further fixes to the new "current" storage tracker. The ensure_surface() and ensure_image() functions shall only relate to the underlying backing store. The actual current flags are to be updated only through ensure_{surface,image}_is_current() or very other particular cases in GstMemory hooks. 2014-11-21 15:43:35 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: fix "current" video memory flags. If the surface proxy is updated into the GstVaapiVideoMemory, then it is assumed it is the most current representation of the current video frame. Likewise, make a few more arrangements to have the "current " flags set more consistently. 2014-11-21 15:23:13 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: * gst/vaapi/gstvaapivideometa.c: plugins: ensure VA surface is current prior to using it. When interacting with SW elements, the buffers and underlying video memory could be mapped as read/write. However, we need to use those buffers again as plain VA surfaces, we have to make sure the VA image is thus committed back to VA surface memory. This fixes pipelines involving avdec_* and vaapi{postproc,sink}. 2013-07-12 06:34:15 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideomemory.c: plugins: enable memory maps for read & write. Hence vaapisink can display buffers decoded by gst-libav, or HW decoded buffers can be further processed in-place, e.g. with a textoverlay. https://bugzilla.gnome.org/show_bug.cgi?id=704078 [ported to current git master branch, amended commit message] Signed-off-by: Gwenole Beauchesne 2014-11-18 14:57:02 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: plugins: preserve framerate when updating src caps video format. In the current implementation, gst_video_info_set_format() would reset the whole GstVideoInfo structure first, prior to setting video format and size. So, coleteral information like framerate or pixel-aspect- ratio are lost. Provide and use a unique gst_video_info_change_format() for overcome this issue, i.e. only have it change the format and video size, and copy over the rest of the fields. https://bugzilla.gnome.org/show_bug.cgi?id=734665 2014-11-18 14:07:57 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapi.c: vaapidecode: increase the rank to GST_RANK_PRIMARY + 1 This is for helping decodebin to autoplug the vaapidecode element. Decodebin is selecting decoder elements only based on rank and caps. Without overriding the autoplug-* signals there is no way to autoplug HW decoders inside decodebin. An easier soulution is to raise the rank of vaapidecode, so that it gets selected first. https://bugzilla.gnome.org/show_bug.cgi?id=739332 2014-11-12 07:46:53 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst/vaapi/gstvaapidecode.c: vaapidecode: only expose supported profiles when needed. JPEG and VP8 codecs do not really support the concept of "profile". So, don't try to expose any set that wouldn't be supported by jpegparse, or ivfparse for instance. https://bugzilla.gnome.org/show_bug.cgi?id=739713 https://bugzilla.gnome.org/show_bug.cgi?id=739714 2014-11-13 15:13:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: decoder: h264: add initial support for repeat-first-field (RFF) flag. Use the SEI pic_timing() message to track and propagate down the repeat first field (RFF) flag. This is only initial support as there is one other condition that could induce the RFF flag, which is not handled yet. 2014-11-13 15:05:19 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix picture ordering count type 0 with previous MMCO5. Fix the decoding process for picture order count type 0 when the previous picture had a memory_management_control_operation = 5. In particular, fix the actual variable type for prev_pic_structure to hold the full bits of the picture structure. In practice, this used to work though, due to the underlying type used to express a gboolean. 2014-11-13 15:00:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix detection of top-field-first (TFF) flag. Use the SEI pic_timing() message to track the pic_struct variable when present, or infer it from the regular slice header flags field_pic_flag and bottom_field_flag. This fixes temporal sequence ordering when the output pictures are to be displayed. https://bugzilla.gnome.org/show_bug.cgi?id=739291 2014-11-14 09:54:02 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 3d05d9f. 1241840 h264: fix derivation of MaxPicNum variable 3bd718e h264: fix GstH264ParserResult documentation typo b021609 h264parse: set the HEADER flag on buffers containing SPS or PPS b08e4be h264parse: don't unnecesarily set src_caps 2014-11-03 19:20:43 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Add string representation of VPP functions to ElementFactoy Klass Added the same Klass specifications used in other upstream video postprocessing elements like videoconvert, videoscale, videobalance and deinterlace. An example use case is for this is to help the playsink to autoplug the hardware accelerated deinterlacer. 2014-11-03 19:19:20 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: vaapipostproc: Tweak the output video format setting to enable the autoplugging This is a workaround until auto-plugging is fixed when format=ENCODED + memory:VASurface caps feature are provided. Use the downstream negotiated video format as the output video format if the user didn't ask for the colorspace conversion explicitly. Usecase: This will help to connect elements like videoscale, videorate etc to vaapipostproc. https://bugzilla.gnome.org/show_bug.cgi?id=739443 2014-10-29 17:30:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: allow user defined scaling mode. Add new "scale-method" property to expose the scaling mode to use during video processing. Note that this is only a hint, and the actual behaviour may differ from implementation (VA driver) to implementation. 2014-10-29 16:57:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: filter: add initial support for high quality scaling. Add support for video scaling options in VPP pipelines. Only the DEFAULT mode is bound to exist. Others might be folded into that mode. 2014-10-29 16:35:46 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: re-indent all GstVaapiFilter related source code. 2014-10-29 15:45:50 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit f9d3bde. 2218b02 h264parse: expose parsed profile and level to downstream 3dbfab4 h264parse: return flushing if we get chained while being set to READY d40fa8b h264: fix frame packing SEI parsing 32d40be h264: Use proper bit_reader api while parsing buffering_period SEI b3e022e h264: initialize some fields of pic_timing structure a70661d vc1: fix expected level in sequence-layer parsing unit test 6cee88d vc1: fix level values for simple/main profile 356c189 vc1: add unit test for sequence-layer parsing ab9f641 vc1: take care of endianness when parsing sequence-layer 8dc8e35 mpeg4: fix vlc table used for sprite trajectory 2014-10-29 15:46:47 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: Expose the supported profiles as caps to upstream This will allows the playbin to fallback to Software Decoder if the Hardware Decoder does not support a particular profile. https://bugzilla.gnome.org/show_bug.cgi?id=730997 2014-10-29 15:46:12 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: encode: Attach the codec-data to out caps only based on negotiated caps Attach the codec_data to out_caps only if downstream needed. For eg: h264 encoder doesn't need to stuff codec_data to the src caps if the negotiated caps has a stream format of byte-stream. https://bugzilla.gnome.org/show_bug.cgi?id=734902 2014-10-29 15:45:44 +0200 Sreerenj Balachandran * configure.ac: configure: echoing installation prefix path 2014-09-24 10:14:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: display: add support for DRM Render-Nodes. Add support for DRM Render-Nodes. This is a new feature that appeared in kernel 3.12 for experimentation purposes, but was later declared stable enough in kernel 3.15 for getting enabled by default. This allows headless usages without authentication at all, i.e. usages through plain ssh connections is possible. 2014-09-24 13:44:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: clean-ups (indentation, drop unused variables). 2014-09-24 13:39:55 +0200 Gwenole Beauchesne * configure.ac: * gst/vaapi/gstvaapisink.c: vaapisink: fix GstNavigation "key-press" / "key-release" events. Fix arguments to XkbKeycodeToKeysym() for converting an X11 keycode to a KeySym. In particular, there is no such Window argument. Also make sure to check for, and use, the correct header where that new function is defined. Otherwise, default to the older XKeycodeToKeysym() function. 2014-09-24 13:23:17 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix GstNavigation "mouse-move" event. Really use the motion event coordinates to propagate the "mouse-move" event to upper layer, instead of those from a button event. Those are technically the same though. 2014-09-16 14:25:40 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: implement the GstNavigation interface This is useful for things like DVD menus, where key/mouse events would need to be forwarded from the upstream sink element. https://bugzilla.gnome.org/show_bug.cgi?id=711479 2014-03-13 18:38:33 +0000 Simon Farnsworth * gst/vaapi/gstvaapipluginbase.c: vaapipostproc: fix deinterlacing from non VA memory buffers. When we copy a buffer because we're moving it into VA-API memory, we need to copy flags. Otherwise, interlaced YUV buffers from a capture source (e.g. V4L2) don't get flagged as interlaced. https://bugzilla.gnome.org/show_bug.cgi?id=726270 Signed-off-by: Simon Farnsworth [reversed order of gst_buffer_copy_into() flags to match <1.0 code] Signed-off-by: Gwenole Beauchesne 2014-08-22 15:22:32 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add support for GLTextureUploadMeta output. This allows for vaapipostproc to be chained to the glimagesink element for instance. https://bugzilla.gnome.org/show_bug.cgi?id=735231 2014-08-22 15:22:32 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add support for "download" capability. Allow implicit conversions to raw video formats, while still keeping VA surfaces underneath. This allows for chaining the vaapipostproc element to a software-only element that takes care of maps/unmaps. e.g. xvimagesink. https://bugzilla.gnome.org/show_bug.cgi?id=720174 2014-08-22 18:10:54 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: use pooled vaapi video meta. Use pooled GstVaapiVideoMeta information, i.e. always allocate that on video buffer allocation. Also optimize copy of additional metadata info into the resulting video buffer: only copy the video cropping info and the source surface proxy. https://bugzilla.gnome.org/show_bug.cgi?id=720311 Signed-off-by: Sreerenj Balachandran [fixed proxy leak, fixed double free on error, optimized meta copy] Signed-off-by: Gwenole Beauchesne 2014-08-22 15:17:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix passthrough mode. If no explicit output surface format is supplied try to keep the one supplied through the sink pad caps. This avoids a useless copy, even if things are kept in GPU memory. This is a performance regression from git commit dfa70b9. 2014-07-05 21:00:34 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: fix output buffer to have a GstVaapiVideoMemory. https://bugzilla.gnome.org/show_bug.cgi?id=720311 [used new infrastructure through base decide_allocation() impl] Signed-off-by: Gwenole Beauchesne 2014-08-22 11:13:36 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: enable advanced deinterlacing with same format. If only advanced deinterlacing is requested, i.e. deinterlacing is the only active algorithm to apply with source and output surface formats being the same, then make sure to enable VPP processing. Otherwise, allow fallback to bob-deinterlacing with simple rendering flags alteration. 2014-08-21 15:04:20 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: avoid NULL pointer unref if GstVaapiImage creation failed. https://bugzilla.gnome.org/show_bug.cgi?id=735156 2014-08-22 13:25:03 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: plugins: fix memory leaks. 2014-08-21 14:10:36 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: factor out decide_allocation() hook. Add a default decide_allocation() hook to GstVaapiPluginBase. The caps feature argument can be used to force a bufferpool with a specific kind of memory. 2014-08-21 11:12:39 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideomemory.c: plugins: allow bufferpool to not allocate vaapi video meta. Add GST_VAAPI_VIDEO_BUFFER_POOL_ACQUIRE_FLAG_NO_ALLOC params flag that can be used to disable early allocations of vaapi video metas on buffers, thus delagating that to the bufferpool user. 2014-08-21 10:45:31 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_glx.h: * gst/vaapi/gstvaapivideoconverter_x11.c: * gst/vaapi/gstvaapivideoconverter_x11.h: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: plugins: re-indent all GstVaapiVideo* related source code. 2014-08-22 15:12:46 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: surfaceproxy: fix copy to propagate view_id. Fix gst_vaapi_surface_proxy_copy() to copy the view-id element, thus fixing random frames skipped when vaapipostproc element is used in passthrough mode. In that mode, GstMemory is copied, thus including the underlying GstVaapiVideoMeta and associated GstVaapiSurfaceProxy. 2014-08-20 16:38:45 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix detection of output surface format changes. Default to I420 format for output surfaces so that to match the usual GStreamer pipelines. Though, internally, we could still opt for NV12 surface formats, i.e. default format=ENCODED is a hint for that, thus delegating the decision to the VA driver. 2014-08-20 10:59:53 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix construction of allowed sink pad caps. Fix construction of the set of caps allowed on the sink pad to filter out unsupported raw video caps with GStreamer >= 1.2. 2014-08-20 10:37:02 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: improve heuristics for detecting native VA surfaces. Use the new gst_caps_has_vaapi_surface() helper function to detect whether the sink pad caps contain native VA surfaces, or not, i.e. no raw video caps. Also rename is_raw_yuv to get_va_surfaces to make the variable more explicit as we just want a way to differentiate raw video caps from VA surfaces actually. 2014-08-12 18:33:25 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: disable discontinuity detection code. The "discontinuity" tracking code, whereby lost frames are tentatively detected, is inoperant if the sink pad buffer timestamps are not right to begin with. This is a temporary workaround until the following bug is fixed: https://bugzilla.gnome.org/show_bug.cgi?id=734386 2014-08-07 14:57:26 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix heuristic for detecting discontinuity. In order to make the discontinuity detection code useful, we need to detect the lost frames in the history as early as the previous frame. This is because some VA implementations only support one reference frame for advanced deinterlacing. In practice, turn the condition for detecting new frame that is beyond the previous frame from field_duration*2 to field_duration*3, i.e. nothing received for the past frame and a half because of possible rounding errors when calculating the field-duration either in this element (vaapipostproc), or from the upstream element (parser element). This is a regression introduced with commit faefd62. https://bugzilla.gnome.org/show_bug.cgi?id=734135 2014-08-20 11:43:08 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: plugins: fix detection of raw video caps. Use the new gst_caps_has_vaapi_surface() helper function to better detect raw video caps, and in particular those from RGB colorspace. https://bugzilla.gnome.org/show_bug.cgi?id=734665 2014-08-20 11:30:41 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: add helper for detecting VA surfaces in caps. Introduce new gst_caps_has_vaapi_surface() helper function to detect whether the supplied caps has VA surfaces. With GStreamer >= 1.2, this implies a check for memory:VASurface caps features, and format=ENCODED for earlier versions of GStreamer. 2014-08-12 13:01:57 +0300 Sebastian Dröge * gst/vaapi/gstvaapidecode.c: vaapidecode: start the decoder task again after finishing This allows the element to accept data again after draining without a hard reset or caps change happening in between. https://bugzilla.gnome.org/show_bug.cgi?id=734616 2014-08-12 13:00:03 +0300 Sebastian Dröge * gst/vaapi/gstvaapidecode.c: vaapidecode: unlock condition variables before shutting down the element Otherwise threads might wait for them, causing the shutdown of the element to deadlock on the streaming thread. https://bugzilla.gnome.org/show_bug.cgi?id=734616 2014-08-11 17:15:24 +0300 Sebastian Dröge * gst/vaapi/gstvaapidecode.c: vaapidecode: reset decoder_finish variable after stopping the decoder thread Otherwise the element is not usable again after draining/EOS. https://bugzilla.gnome.org/show_bug.cgi?id=734616 2014-08-11 17:14:53 +0300 Sebastian Dröge * gst/vaapi/gstvaapidecode.c: vaapidecode: don't try flushing the decoder instance if we didn't create one yet This otherwise results in unnecessary error messages. https://bugzilla.gnome.org/show_bug.cgi?id=734616 2014-08-01 06:32:32 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: build: fix with --no-undefined linker flags. https://bugzilla.gnome.org/show_bug.cgi?id=729352 2014-01-23 15:44:09 +0000 Changzhi Wei * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add support for GstColorBalance interface. https://bugzilla.gnome.org/show_bug.cgi?id=722390 [fixed channel names, simplified range factor, fixed memory leak] Signed-off-by: Gwenole Beauchesne 2014-01-23 15:23:00 +0000 Changzhi Wei * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add support for colorbalance adjustment. https://bugzilla.gnome.org/show_bug.cgi?id=722390 [fixed and simplified tracking of colorbalance value changes] Signed-off-by: Gwenole Beauchesne 2014-07-31 13:18:21 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: improve installation of properties. Simplify the creation and installation process of properties, by first accumulating them into a g_properties[] array, and next calling into g_object_class_install_properties(). Also add missing docs and flags to some properties. 2014-07-31 10:48:15 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: code clean-ups. Move code around in a more logical way. Introduce GST_VAAPISINK_CAST() helper macro and use it wherever we know the object is a GstBaseSink or any base class. Drop explicit initializers for values that have defaults set to zero. 2014-07-31 10:37:57 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: re-indent all GstVaapiSink related source code. 2014-07-30 17:27:50 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: introduce separate backends. Introduce new backends vtable so that to have clean separation between display dependent code and common base code. That's a "soft" separation, we don't really need dedicated objects. https://bugzilla.gnome.org/show_bug.cgi?id=722248 2014-07-30 16:47:20 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: drop unused "synchronous" mode. Support for X11 "synchronous" mode was never implemented, and was only to be useful for debugging. Drop that altogether, that's not going to be useful in practice. https://bugzilla.gnome.org/show_bug.cgi?id=733985 2014-07-30 17:32:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: drop unused variables. Drop obsolete, and now unused, video_buffer_pool and video_buffer_size variables. They got merged into the GstVaapiPluginBase object. 2014-07-30 16:35:32 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: drop GLX rendering and fancy effects. Rendering with GLX in vaapisink is kind of useless nowadays, including OpenGL related fancy effects. Plain VA/GLX interfaces are also getting deprecated in favor of EGL, or more direct buffer sharing with actual GL textures. Should testing of interop with GLX be needed, one could still be using the modern cluttersink or glimagesink elements. https://bugzilla.gnome.org/show_bug.cgi?id=733984 2013-11-05 14:01:11 +0100 Holger Kaelberer * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: listen to window size changes on X11. Allow dynamic changes to the window, e.g. performed by the user, and make sure to refresh its contents, while preserving aspect ratio. In practice, Expose and ConfigureNotify events are tracked in X11 display mode by default. This occurs in a separte event thread, and this is similar to what xvimagesink does. Any of those events will trigger a reconfiguration of the window "soft" size, subsequently the render-rect when necessary, and finally _expose() the result. The default of handle_events=true can be changed programatically via gst_x_overlay_handle_events(). Thanks to Fabrice Bellet for rebasing the patch. https://bugzilla.gnome.org/show_bug.cgi?id=711478 [dropped XInitThreads(), cleaned up the code a little] Signed-off-by: Gwenole Beauchesne 2014-07-29 15:47:46 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: decode and output all pending frames on normal EOS. The gst_vaapidecode_decode_loop() function is called within a separate task to fetch and output all frames that were decoded so far. So, if the decoder_loop_status is forcibly set to EOS when _finish() is called, then we are bound to exist the task without submitting the pending frames. If the downstream element error'ed out, then the gst_pad_push() would propagate up an error and so we will get it right for cutting off _finish() early in that case. This is a regression from 6003596. https://bugzilla.gnome.org/show_bug.cgi?id=733897 2014-07-29 13:24:52 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2014-07-29 10:31:58 +0200 Gwenole Beauchesne * AUTHORS: AUTHORS: updates. 2014-07-29 10:31:15 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2014-07-29 16:22:01 +1000 Matthew Waters * gst/vaapi/gstvaapidecode.c: vaapidecode: properly return from decode loop on downstream errors. Fixes a hang/race on shutdown where _decode_loop() had already completed its execution and _finish() was waiting on a GCond for decode_loop() to complete. Also fixes the possible race where _finish() is called but _decode_loop() endlessly returns before signalling completion iff the decoder instance returns GST_FLOW_OK. Found with: ... ! vaapidecode ! {glimagesink,cluttersink} https://bugzilla.gnome.org/show_bug.cgi?id=733897 [factored out GST_VIDEO_DECODER_STREAM_UNLOCK() call] Signed-off-by: Gwenole Beauchesne 2014-07-28 18:45:49 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.9. 2014-07-28 18:31:09 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix GstVideoOverlay::expose() implementation. Now that we always track the currently active video buffer, it is not necessary to automatically increase its reference since this is implicitly performed in ::show_frame() through the get_input_buffer() helper from GstVaapiPluginBase class. This is a regression from a26df80. 2014-07-28 18:00:19 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: vaapidecode: simplify bufferpool configuration. Rework the logics behind the configuration of an adequate bufferpool, especially when OpenGL meta or additional capsfeatures are needed. Besides, for GStreamer >= 1.4, the first capsfeatures that gets matched, and that is not system memory, is now selected by default. 2014-07-28 16:43:47 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix auto-plugging of vaapisink element. Make sure to propagate memory:VASurface capsfeature to srcpad caps only for GStreamer >= 1.5 as the plug-in elements in GStreamer 1.4 core currently miss additional patches available in 1.5-git (1.6). This is a temporary workaround. 2014-07-28 15:54:46 +0300 Sreerenj Balachandran * configure.ac: configure: allow builds against GStreamer git (1.5.x). https://bugzilla.gnome.org/show_bug.cgi?id=733688 2014-07-28 14:20:33 +0200 Gwenole Beauchesne * configure.ac: configure: fix build with GStreamer 1.4.0 release. 2014-03-04 19:40:59 +0100 Gwenole Beauchesne * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: debian: fix packaging for new naming scheme. 2014-07-28 11:52:06 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2014-07-28 11:39:11 +0200 Gwenole Beauchesne * configure.ac: configure: mark support for GStreamer < 1.2 as deprecated. Supporting anything thing below GStreamer 1.2 is asking for trouble for keeping up with the required facilities to make efficient pipelines. Users are invited to upgrade to the very latest GStreamer 1.2.x release, at the minimum. 2014-07-28 11:35:24 +0200 Gwenole Beauchesne * configure.ac: configure: mark support for GStreamer 0.10 as obsolete. Support for GStreamer 0.10 is obsolete. i.e. it is no longer supported and may actually be removed altogether for a future release. There is no real point to maintain a build for such an ancient GStreamer version that is not even supported upstream. 2014-07-28 10:25:26 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: allow a specific view component to be displayed. If a multiview stream is decoded, multiple view components are submitted as is downstream. It is the responsibility of the sink element to display the required view components. By default, always select the frame buffer that matches the view-id of the very first frame to be displayed. However, introduce a "view-id" property to allow the selection of a specific view component of interest to display. 2014-07-28 10:09:34 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: always keep the last displayed buffer around. Always record the VA surface that is currently being rendered, no matter the fact we are using texturedblit or overlay. That's because in some occasions, we need to refresh or resize the displayed contents based on new events. e.g. user-resized window. Besides, it's simpler to track the last video buffer in GstVaapiSink than through the base sink "last-sample". 2014-07-25 11:13:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: vaapisink: add support for "display-name" property. Add a "display-name" property to vaapisink so that the end user could select the desired output. Keep "display-name" in-line with the existing "display" (GstVaapiDisplayXXX type). So, for X11 or GLX, the "display-name" is the usual display name as we know for XOpenDisplay(); for Wayland, the "display-name" is the name used for wl_display_connect(); and for DRM, the "display-name" is actually the DRI device name. https://bugzilla.gnome.org/show_bug.cgi?id=722247 2014-07-25 17:29:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: window: make gst_vaapi_window_reconfigure() thread-safe. Ensure the X11 implementation for GstVaapiWindow::get_geometry() is thread-safe by default, so that upper layer users don't need to handle that explicitly. 2013-07-29 09:28:28 +0200 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: window: allow for updating size from current geometry. Add gst_vaapi_window_reconfigure() interface to force an update of the GstVaapiWindow "soft" size, based on the current geometry of the underlying native window. This can be useful for instance to synchronize the window size when the user changed it. Thanks to Fabrice Bellet for rebasing the patch. [changed interface to gst_vaapi_window_reconfigure()] Signed-off-by: Gwenole Beauchesne 2014-07-25 16:53:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: window: re-indent all GstVaapiWindow related source code. 2014-07-25 11:24:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: display: add interface to retrieve the display name. Add gst_vaapi_display_get_display_name() helper function to determine the name associated with the underlying native display. Note that for raw DRM backends, the display name is actually the device path. 2014-07-25 10:55:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: fix comparison of X11 display names. Make sure to not only compare display host names, but also the actual display number. The screen number does not need to be checked at this time. 2014-07-25 15:52:06 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapivideobufferpool.c: vaapidecode: add support for VideoAlignment bufferpool option. Always add VideoAlignment bufferpool option if the downstream element expects its own pool to be used but does not offer it through a proper propose_allocation() implementation for instance, and that the ALLOCATION query does not expose the availability of the Video Meta API. This fixes propagation of video buffer stride information to Firefox. 2014-07-25 15:44:58 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: always prefer native VA surface formats. Make sure to always prefer native internal formats for the VA surfaces that get allocated. Also disable "direct-rendering" mode in this case. This is needed so that to make sure that anything that gets out of the decoder, or anything that gets into the encoder, is in native format for the hardware, and thus the driver doesn't need to perform implicit conversions in there. Interop with SW elements is still available with fast implementations of VA imaging APIs. 2014-07-24 11:58:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: disallow memory shares across buffers, use a copy. Forbid shares of GstMemory instances, and rather make copy of it. This effectively copies the GstMemory structure and enclosed metadata, but this does not copy the VA surface contents itself. It should though. This fixes preroll and makes sure to not download garbage for the first frame when a SW rendering sink is used. 2014-07-24 06:46:22 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: use an image pool to cache objects. Use an image pool to hold VA images to be used for downloads/uploads of contents for the associated surface. This is an optmization for size. So, instead of creating as many VA images as there are buffers (then VA surfaces) allocated, we only maintain a minimal set of live VA images, thus preserving memory resources. 2014-07-24 00:14:04 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: forbid R/W mappings if non direct-rendering mode. Disable read-write mappings if "direct-rendering" is not supported. Since the ordering of read and write operations is not specified, this would require to always download the VA surface on _map(), then commit the temporary VA image back to the VA surface on _unmap(). Some SW decoding plug-in elements still use R/W mappings though. https://bugzilla.gnome.org/show_bug.cgi?id=733242 2014-07-23 23:49:53 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: minor code clean-ups. Fix error messages introduced in the previous commit for the _map() imaplementation. Also use the new get_image_data() helper function to determine the base pixels data buffer from a GstVaapiImage when updating the video info structure from it. 2014-07-23 18:54:13 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: vaapivideomemory: add support for raw pixels mappings. Allow raw pixels of the whole frame to be mapped read-only. i.e. in cases where the buffer pool is allocated without VideoMeta API, thus individual planes cannot be mapped. This is initial support for Firefox >= 30. https://bugzilla.gnome.org/show_bug.cgi?id=731886 2014-07-03 18:41:11 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: fix determination of the surface pool format. While creating the vaapi video allocator, make sure the associated surface pool has correct format instead of defaulting to NV12 video format even though there is no direct rendering support. https://bugzilla.gnome.org/show_bug.cgi?id=732691 2014-07-23 18:01:21 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: vaapivideomemory: fix association of surface to proxy. Make sure to always update the VA surface pointer whenever the proxy changes. This used to only work when the VA surface is written to, in interop with SW element ("upload" feature), and this now fixes cases when the VA surface is needed for reading, in interop with SW element ("download" feature). 2014-07-23 10:23:06 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideomemory.c: plugins: expose I420 format for interop with SW elements. Always expose I420 format by default when the VA surface could be mapped for interoperability with non harware accelerated elements. However, the default behaviour remains the auto-plugging of vaapi elements, down to the sink. Side effect: "direct-rendering" mode is also disabled most of the times as plain memcpy() from uncached speculative write combining memory is not going to be efficient enough. 2014-07-22 18:54:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapivideomemory.c: plugins: allow download capability to vaapidecode element. Fix support for VA surface download capability in vaapidecode element for GStreamer >= 1.2. This is a fix to supporting libva-vdpau-driver, but also the libva-intel-driver while performing hardware accelerated conversions from the native VA surface format (NV12) to the desired output VA image format. For instance, this fixes pipelines involving vaapidecode ! xvimagesink. https://bugzilla.gnome.org/show_bug.cgi?id=733243 2014-07-17 01:51:36 +0200 Fabrice Bellet * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: decoder: mpeg4: fix picture decoder return value for skipped frames. The picture decoder should return GST_VAAPI_DECODER_STATUS_DROP_FRAME when a frame should be skipped, so the stream processing is not stalled. https://bugzilla.gnome.org/show_bug.cgi?id=733324 2014-07-04 15:13:32 +1000 Jan Schmidt * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: decoder: mpeg2: respect any input PTS provided for a frame. The timestamp generator in gstvaapidecoder_mpeg2.c always interpolated frame timestamps within a GOP, even when it's been fed input PTS for every frame. That leads to incorrect output timestamps in some situations - for example live playback where input timestamps have been scaled based on arrival time from the network and don't exactly match the framerate. https://bugzilla.gnome.org/show_bug.cgi?id=732719 2014-01-22 08:20:59 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiobject.c: GstVaapiObject: make gst_vaapi_object_new() more robust. Forbid GstVaapiObject to be created without an associated klass spec. It is mandatory that the subclass implements an adequate .finalize() hook, so it shall provide a valid GstVaapiObjectClass. https://bugzilla.gnome.org/show_bug.cgi?id=722757 [made non-NULL klass argument to gst_vaapi_object_new() a requirement] Signed-off-by: Gwenole Beauchesne 2014-01-21 15:43:57 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiobject.c: GstVaapiObject: initialize the derived object data with init() hook. Call the subclass .init() function in gst_vaapi_object_new(), if needed. The default behaviour is to zero initialize the subclass object data, then the .init() function can be used to initialize fields to non-default values, e.g. VA object ids to VA_INVALID_ID. Also fix the gst_vaapi_object_new() description, which was merely copied from GstVaapiMiniObject. https://bugzilla.gnome.org/show_bug.cgi?id=722757 [changed to always zero initialize the subclass] Signed-off-by: Gwenole Beauchesne 2014-06-13 21:45:04 +0100 Lionel Landwerlin * gst/vaapi/gstvaapidecode.c: vaapidecode: make decoder work with playbin When playbin/decodebin builds the pipeline, it puts decoders and sinks into different bins and forwards the queries from bins to bins. So in the initials steps the pipeline is built iteratively by playbin and looks like this : [filesrc] [filesrc] -> [typefind] [filesrc] -> [typefind] -> [demuxer] [filesrc] -> [typefind] -> [demuxer] -> [decoder] At this point the decoder is asked for its SRC caps and it will make a choice based on what gst_pad_peer_query_caps() returns. The problem is that the caps returns at that point includes caps features like ANY, essentially because playbin can plug in additional elements like videoscale, videoconv or deinterlace. This patch adds a another call to gst_vaapi_find_preferred_caps_feature() when the decoder decides its allocation, to make sure we asks the downstream elements when the entire pipeline has been built. https://bugzilla.gnome.org/show_bug.cgi?id=731645 2014-06-27 11:57:11 +0100 Simon Farnsworth * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't let tmp_rect go out of scope. A compiler change showed me that tmp_rect went out of scope before it was used. Move it to the beginning of the function instead. https://bugzilla.gnome.org/show_bug.cgi?id=726363 Signed-off-by: Simon Farnsworth [added guards for GStreamer 0.10 builds] Signed-off-by: Gwenole Beauchesne 2014-07-03 22:44:40 +0200 Gwenole Beauchesne * AUTHORS: AUTHORS: updates. 2014-07-03 22:34:35 +0200 Gwenole Beauchesne * README: README: updates. Drop references to deprecated plugins (vaapiupload, vaapidownload), mention that support for GStreamer 0.10 is deprecated, make overview more descriptive in certain aspects. 2014-07-03 22:21:39 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2014-07-03 19:42:02 +0200 Gwenole Beauchesne * README: * configure.ac: build: mention that support for GStreamer 0.10 is deprecated. 2014-07-03 17:17:00 +0200 Gwenole Beauchesne * configure.ac: * gst/vaapi/gstvaapidecode.c: build: fix for GStreamer 0.10. 2014-07-03 18:01:09 +0200 Gwenole Beauchesne * patches/videoparsers/0002-h264parse-fix-build-with-GStreamer-1.2.patch: * patches/videoparsers/0002-h264parse-fix-build-with-older-GStreamer-1.x-stacks.patch: * patches/videoparsers/series.frag: build: fix for GStreamer 1.0.x. 2014-07-03 13:48:48 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: detect incorrectly paired fields in frames. When a DPB flush is required, e.g. at a natural and of stream or issued explicitly through an IDR, try to detect any frame left in the DPB that is interlaced but does not contain two decoded fields. In that case, mark the picture as having a single field only. This avoids a hang while decoding tv_cut.mkv. 2014-07-03 11:13:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: simplify the DPB output process. Simplify the dpb_output() function to exclusively rely on the frame store buffer to output, since this is now always provided. Besides, also fix cases where split fields would not be displayed. This is a regression from f48b1e0. 2014-07-01 17:20:44 +0200 Gwenole Beauchesne * patches/videoparsers/0003-h264parse-fix-and-optimize-NAL-collection-function.patch: * patches/videoparsers/0005-h264parse-introduce-new-state-tracking-variables.patch: * patches/videoparsers/0006-h264parse-improve-conditions-for-skipping-NAL-units.patch: * patches/videoparsers/0007-h264parse-fix-collection-of-access-units-to-preserve.patch: * patches/videoparsers/series.frag: h264parse: drop patches merged upstream. 0003-h264parse-fix-and-optimize-NAL-collection-function.patch 0005-h264parse-introduce-new-state-tracking-variables.patch 0006-h264parse-improve-conditions-for-skipping-NAL-units.patch 0007-h264parse-fix-collection-of-access-units-to-preserve.patch 2014-07-01 17:18:08 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix memory leak in PPS. Cope with latest changes from codecparsers/h264. It is now required to explicitly clear the GstH264PPS structure as it could contain additional allocations (slice_group_ids). 2014-07-01 17:13:56 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 2d53b69. c4ace00 h264parse: fix collection of access units to preserve config headers 0f9f7c9 h264parse: improve conditions for skipping NAL units 9ffb25c h264parse: introduce new state tracking variables 64955d3 h264parse: fix and optimize NAL collection function 13cd2a3 h264: clarifications and documentation fixes 53e7dd1 h264: fix identification of EOSEQ and EOS NALs 18f0de0 h264: fix memory leak in GstH264PPS fdcb54c h264: fix typo in GstH264VUIParams description fd4dae9 vp8: move up built-in range decoder private data 2014-06-30 19:01:35 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: decoder: propagate MVC metadata ("view-id", head of multiview set). Add new GstVaapiSurfaceProxy flag FFB, which means "first frame in bundle", and really expresses the first view component of a multi view coded frame. e.g. in H.264 MVC, the surface proxy has flag FFB set if VOIdx = 0. Likewise, new API is exposed to retrieve the associated "view-id". 2014-06-30 18:46:45 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: propagate "one-field" flags. Allow decoders to set the "one-field" attribute when the decoded frame genuinely has a single field, or if the second field was mis-decoded but we still want to display the first field. 2014-06-30 18:34:45 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: output decoded frames only once. Make sure to output the decoded picture, and push the associated GstVideoCodecFrame, only once. The frame fully represents what needs to be output, included for interlaced streams. Otherwise, the base GstVideoDecoder class would release the frame twice. Anyway, the general process is to output decoded frames only when they are complete. By complete, we mean a full frame was decoded or both fields of a frame were decoded. 2014-06-30 16:12:52 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: decode current picture earlier. Slightly optimize decoding process by submitting the current VA surface for decoding earlier to the hardware, and perform the reference picture marking process and DPB update process afterwards. This is a minor optimization to let the video decode engine kick in work earlier, thus improving parallel resources utilization. 2014-06-30 16:09:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix output of second field when first field is not in DPB. Fix decoding of interlaced streams where a first field (e.g. B-slice) was immediately output and the current decoded field is to be paired with that former frame, which is no longer in DPB. https://bugzilla.gnome.org/show_bug.cgi?id=701340 2014-06-30 11:06:29 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: slightly optimize the process to detect new pictures. Optimize the process to detect new pictures or start of new access units by checking if the previous NAL unit was the end of a picture, or the end of the previous access unit. 2014-06-13 15:42:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: handle access unit ("au") optimization. Optimize parsing when buffers are supplied with access unit alignment. This helps determining faster when the end of an access unit is reached. 2014-06-28 07:25:35 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix tracking of DPB size changes. Add support for MVC streams with multiple SPS and subset SPS headers emitted regularly, e.g. at around every I-frame. Track the maximum number of views in ensure_context() and really reset the DPB size to the expected value, always. i.e. even if it decreased. dpb_reset() only cares of ensuring the DPB allocation. 2014-06-27 20:44:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix the DPB compaction process. Fix the compaction process when the DPB is cleared for a specific view, i.e. fix the process of filling in the holes resulting from removing frame buffers matching the current picture. 2014-06-27 16:38:03 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: generate new SPS only when codec config changed. It is not necessary to periodically send SPS or subset SPS headers. This is up to the upper layer (e.g. transport layer) to decide on if/how to periodically submit those. For now, only generate new SPS or subset SPS headers when the codec config changed. Note: the upper layer could readily determine the config headers (SPS/PPS) through the gst_vaapi_encoder_h264_get_codec_data() function. https://bugzilla.gnome.org/show_bug.cgi?id=732083 Signed-off-by: Gwenole Beauchesne 2014-06-27 18:43:27 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: track encoder config changes. Track and report when encoder configuration changed. For now, this covers resolution, profile/level and bitrate changes. 2014-06-27 13:15:13 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: add pixel-aspect-ratio to VUI parameters. Report sample aspect ratio (SAR) as present, and make it match what we have obtained from the user as pixel-aspect-ratio (PAR). i.e. the VUI parameter aspect_ratio_info_present_flag now defaults to TRUE. 2014-06-27 00:49:34 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix number of anchor and non-anchor reference pictures. Set the value of num_anchor_refs_l0, num_anchor_refs_l1, num_non_anchor_refs_l0, and num_non_anchor_refs_l1 to zero since the inter-view prediction is not yet supported. 2014-06-27 10:37:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix timing_info_present_flag value in subset SPS. When the seq_parameter_set_data() syntax structure is present in a subset sequence parameter set and vui_parameters_present_flag is equal to 1, then timing_info_present_flag shall be equal to 0 (H.7.4.2.1.1). 2014-06-26 14:39:52 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: add cpbBrNalFactor values for MVC profiles. 2014-06-26 14:51:32 +0200 Gwenole Beauchesne * patches/videoparsers/0003-h264parse-add-initial-support-for-MVC-NAL-units.patch: h264parse: fix detection of access unit boundaries for MVC. The gst_h264_parse_collect_nal() function is a misnomer. In reality, this function is used to determine access unit boundaries, i.e. that is the key function for alignment=au output format generation. 2014-06-26 14:49:53 +0200 Gwenole Beauchesne * patches/videoparsers/0007-h264parse-fix-collection-of-access-units-to-preserve.patch: * patches/videoparsers/series.frag: h264parse: fix collection of access units to preserve config headers. Always use a GstAdapter when collecting access units (alignment="au") in either byte-stream or avcC format. This is required to properly preserve config headers like SPS and PPS when invalid or broken NAL units are subsequently parsed. More precisely, this fixes scenario like: where we used to reset the output frame buffer when an invalid or broken NAL is parsed, i.e. SPS and PPS NAL units were lost, thus preventing the next slice unit to be decoded, should this also represent any valid data. https://bugzilla.gnome.org/show_bug.cgi?id=732203 2014-06-26 14:48:08 +0200 Gwenole Beauchesne * patches/videoparsers/0003-h264parse-add-initial-support-for-MVC-NAL-units.patch: * patches/videoparsers/0006-h264parse-improve-conditions-for-skipping-NAL-units.patch: * patches/videoparsers/series.frag: h264parse: improve conditions for skipping NAL units. Carefully track cases when skipping broken or invalid NAL units is necessary. In particular, always allow NAL units to be processed and let that gst_h264_parse_process_nal() function decide on whether the current NAL needs to be dropped or not. This fixes parsing of streams with SEI NAL buffering_period() message inserted between SPS and PPS, or SPS-Ext NAL following a traditional SPS NAL unit, among other cases too. Practical examples from the H.264 AVC conformance suite include alphaconformanceG, CVSE2_Sony_B, CVSE3_Sony_H, CVSEFDFT3_Sony_E when parsing in stream-format=byte-stream,alignment=au mode. https://bugzilla.gnome.org/show_bug.cgi?id=732203 2014-06-26 14:45:34 +0200 Gwenole Beauchesne * patches/videoparsers/0003-h264parse-add-initial-support-for-MVC-NAL-units.patch: * patches/videoparsers/0005-h264parse-introduce-new-state-tracking-variables.patch: * patches/videoparsers/series.frag: h264parse: introduce new state tracking variables. Improve parser state tracking by introducing new flags reflecting it: "got-sps", "got-pps" and "got-slice". This is an addition for robustness purposes. Older have_sps and have_pps variables are kept because they have a different meaning. i.e. they are used for deciding on when to submit updated caps or not, and rather mean "have new SPS/PPS to be submitted?" 2014-06-26 14:39:30 +0200 Gwenole Beauchesne * patches/videoparsers/0004-h264parse-default-to-byte-stream-nalu-format-Annex-B.patch: * patches/videoparsers/series.frag: h264parse: default to byte-stream/nalu format (Annex B). Always default to stream-format=byte-stream,alignment=nalu if avcC format was not detected. This is the natural stream format specified in the standard (Annex.B): a series of NAL units prefixed with the usual start code. https://bugzilla.gnome.org/show_bug.cgi?id=732167 2014-06-26 14:37:58 +0200 Gwenole Beauchesne * patches/videoparsers/0003-h264parse-fix-and-optimize-NAL-collection-function.patch: * patches/videoparsers/series.frag: h264parse: fix and optimize NAL collection function. Use gst_h264_parser_identify_nalu_unchecked() to identify the next NAL unit. We don't want to parse the full NAL unit, but only the header bytes and possibly the first RBSP byte for identifying the first_mb_in_slice syntax element. Also fix check for failure when returning from that function. The only success condition for that is GST_H264_PARSER_OK, so use it. https://bugzilla.gnome.org/show_bug.cgi?id=732154 2014-06-26 11:39:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix NAL unit types in packed headers. Submit Prefix NAL headers (nal_unit_type = 14) before every packed slice header (nal_unit_type = 1 or 5) only for the base view. In non base views, a Coded Slice Extension NAL header (nal_unit_type = 20) is required, with an appropriate nal_unit_header_mvc_extension() in the NAL header bytes. https://bugzilla.gnome.org/show_bug.cgi?id=732083 2014-06-25 22:05:52 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: add missing field in packed Subset SPS header. Write the missing num_level_values_signalled_minus1 syntax element into the packed header for subset sequence parameter set. https://bugzilla.gnome.org/show_bug.cgi?id=732083 2014-06-25 22:26:32 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix marking of non-reference picture into DPB. Fix search for a picture in the DPB that has a lower POC value than the current picture. The dpb_find_lowest_poc() function will return a picture with the lowest POC in DPB and that is marked as "needed for output", but an additional check against the actual POC value of the current picture is needed. This is a regression from 1c46990. https://bugzilla.gnome.org/show_bug.cgi?id=732130 2014-06-19 17:08:47 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix DPB clear when no decoding actually started. Fix dpb_clear() to clear previous frame buffers only if they actually exist to begin with. If the decoder bailed out early, e.g. when it does not support a specific profile, that array of previous frames might not be allocated beforehand. 2014-02-06 08:30:10 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst/vaapi/gstvaapidecode.c: decoder: h264: add support for NALU "alignment" optimization. We can avoid scanning for start codes again if the bitstream is fed in NALU chunks. Currently, we always scan for start codes, and keep track of remaining bits in a GstAdapter, even if, in practice, we are likely receiving one GstBuffer per NAL unit. i.e. h264parse with "nal" alignment. https://bugzilla.gnome.org/show_bug.cgi?id=723284 [use gst_adapter_available_fast() to determine the top buffer size] Signed-off-by: Gwenole Beauchesne 2014-06-18 18:53:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix caps to report interlace-mode accordingly. The `vaapipostproc' element could never determine if the H.264 stream was interlaced, and thus always assumed it to be progressive. Fix the H.264 decoder to report interlace-mode accordingly, thus allowing the vaapipostproc element to automatically enable deinterlacing. 2014-06-19 13:35:23 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: don't crash with dynamic framerate (0/1). Avoid reaching an assert if dynamic framerates (0/1) are used. One way to solve this problem is to just stick field_duration to zero. However, this means that, in presence of interlaced streams, the very first field will never be displayed if precise presentation timestamps are honoured. https://bugzilla.gnome.org/show_bug.cgi?id=729604 2014-02-07 12:27:50 +0000 Simon Farnsworth * gst/vaapi/gstvaapipostproc.c: vaapipostproc: create filter surface pool if it does not exist yet. ensure_srcpad_buffer_pool() tries to avoid unnecessarily deleting and recreating filter_pool. Unfortunately, this also meant it didn't create it if it did not exist. Fix it to always create the buffer pool if it does not exist. https://bugzilla.gnome.org/show_bug.cgi?id=723834 Signed-off-by: Simon Farnsworth 2013-12-12 10:01:13 +0800 Zhao, Halley * gst/vaapi/gstvaapipostproc.c: vaapipostproc: reset deinterlacer state when there is a discontinuity. Reset deinterlacer state, i.e. past reference frames used for advanced deinterlacing, when there is some discontinuity detected in the course of processing source buffers. This fixes support for advanced deinterlacing when a seek occurred. https://bugzilla.gnome.org/show_bug.cgi?id=720375 [fixed type of pts_diff variable, fetch previous buffer PTS from the history buffer, reduce heuristic for detecting discontinuity] Signed-off-by: Gwenole Beauchesne 2014-06-18 16:16:34 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add support for crop regions in VPP mode. Apply video cropping regions stored in GstVideoCropMeta, or in older GstVaapiSurfaceProxy representation, to VPP pipelines. In non-VPP modes, the crop meta are already propagated to the output buffers. https://bugzilla.gnome.org/show_bug.cgi?id=720730 2014-03-14 17:49:40 +0000 Simon Farnsworth * gst/vaapi/gstvaapipostproc.c: vaapipostproc: make deinterlace-mode behave as expected. deinterlace-mode didn't behave in the way you'd expect if you have past experience of the deinterlace element. There were two bugs: 1. "auto" mode wouldn't deinterlace "interleaved" buffers, only "mixed". 2. "force" mode wouldn't deinterlace "mixed" buffers flagged as progressive. Fix these up, and add assertions and error messages to detect cases that aren't handled. https://bugzilla.gnome.org/show_bug.cgi?id=726361 Signed-off-by: Simon Farnsworth Signed-off-by: Gwenole Beauchesne 2014-01-15 16:36:29 +0000 Matthieu Bouron * gst/vaapi/gstvaapidecode.c: vaapidecode: do not discard video info props when the format changed. gst_video_info_set_format() does not preserve video info properties. In order to keep important information in the caps such as interlace mode, framerate, pixel aspect ratio, ... we need to manually copy back those properties after setting the new video format. https://bugzilla.gnome.org/show_bug.cgi?id=722276 2014-02-23 01:43:39 +1100 Matthew Waters * gst/vaapi/gstvaapidecode.c: vaapidecode: plug a memory leak. It can happen that there is a pool provided that does not advertise the vappivideometa. We should unref that pool before using our own. Discovered with vaapidecode ! {glimagesink,cluttersink} https://bugzilla.gnome.org/show_bug.cgi?id=724957 [fixed compilation by adding the missing semi-colon] Signed-off-by: Gwenole Beauchesne 2014-06-18 13:47:36 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: parse source data until a frame is obtained. Parse any pending data until a complete frame is obtained. This is a memory optimization to avoid expansion of video packets stuffed into the GstAdapter, and a fix to EOS condition to detect there is actually pending data that needs to be decoded, and subsequently output. https://bugzilla.gnome.org/show_bug.cgi?id=731831 2014-06-05 15:32:29 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix multiple slices support in packed headers mode. Handle packedi slice headers and packed raw data on a per-slice basis, which is necessary for multi slice encoding. 2014-06-05 15:30:38 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: encoder: add infrastructure for per-slice handling of packed headers. The packed slice header and packed raw data need to be paired with the submission of VAEncSliceHeaderParameterBuffer. So handle them on a per-slice basis insted of a per-picture basis. [removed useless initializer] Signed-off-by: Gwenole Beauchesne 2014-03-07 17:40:34 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix initialization with "drm" display type. Force early initializatin of the GstVaapiDisplay so that to make sure that the sink element display object is presented first to upstream elements, as it will be correctly featuring the requested display type by the user. Otherwise, we might end up in situations where a VA/X11 display is initialized in vaapidecode, then we try VA/DRM display in vaapisink (as requested by the "display" property), but this would cause a failure because we cannot acquire a DRM display that was previously acquired through another backend (e.g. VA/X11). 2014-03-07 17:38:14 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbase.c: plugins: fix initialization with foreign context. When a new display is settled through GstElement::set_context() (>= 1.2), or GstVideoContext::set_context() (<= 1.0), then we shall also update the associated display type. 2014-04-28 17:44:03 +0200 Gwenole Beauchesne * Makefile.am: * configure.ac: * ext/Makefile.am: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapiparse.c: * gst/vaapi/gstvaapiparse.h: * patches/Makefile.am: * patches/videoparsers/0001-plugins-compile-the-built-in-video-parsers-as-vaapip.patch: * patches/videoparsers/0002-h264parse-fix-build-with-GStreamer-1.2.patch: * patches/videoparsers/0003-h264parse-add-initial-support-for-MVC-NAL-units.patch: * patches/videoparsers/Makefile.am: * patches/videoparsers/series.frag: plugins: add built-in video parsers as "vaapiparse" element. The built-in video parsers elements are built into a single DSO named libgstvaapi_parse.so. The various video parsers could be accessed as vaapiparse_CODEC. For now, this only includes a modified version of h264parse so that to support H.264 MVC encoded streams. 2014-06-13 11:36:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: cope with new gst_h264_quant_matrix_*() interfaces. New gst_h264_quant_matrix_*_get_raster_from_zigzag() were renamed from gst_h264_video_quant_matrix_*_get_raster_from_zigzag(). 2014-06-13 11:34:07 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit d6325ac. 7d8d045 h264parse: use new gst_h264_video_calculate_framerate() d2f965a h264parse: set field_pic_flag when parsing a slice header 24c15b8 Import h264parse a9283e5 bytereader: Use concistant derefence method a8252c6 bytereader: Use pointer instead of index access b1bebfc Import GstBitReader and GstByteReader 2f58788 h264: recognize SVC NAL units 4335da5 h264: fix SPS copy code for MVC cf9b6dc h264: fix quantization matrix conversion routine names b11ce2a h264: add gst_h264_video_calculate_framerate() 126dc6f add C++ guards for MPEG-4 and VP8 parsers 2014-06-10 18:30:21 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: factor out DPB pruning for MVC. Factor out the removal process of unused inter-view only reference pictures from the DPB, prior to the possible insertion of the current picture. Ideally, the compiler could still opt for generating two loops. But at least, the code is now clearer for maintenance. 2014-06-10 17:42:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: clean-ups. Fix GST_VAAPI_PICTURE_IS_{INTER_VIEW,ANCHOR}() definitions to use the base GST_VAAPI_PICTURE_FLAG_IS_SET() macro. 2014-06-10 16:07:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: improve pruning of unused MVC inter-view frames. Improve process for the removal of pictures from DPB before possible insertion of the current picture (C.4.4) for H.264 MVC inter-view only reference components. In particular, handle cases where picture to be inserted is not the last one of the access unit and if it was already output and is no longer marked as used for reference, including for decoding next view components within the same access unit. 2014-06-03 17:36:38 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: improve DPB bumping process for MVC. While invoking the DPB bumping process in presence of many views, it could be necessary to output previous pictures that are ready, in a whole. i.e. emitting all view components from the very first view order index zero to the very last one in its original access unit; and not starting from the view order index of the picture that caused the DPB bumping process to be invoked. As a reminder, the maximum number of frames in DPB for MultiView High profile with more than 2 views is not necessarily a multiple of the number of views. This fixes decoding of MVCNV-4.264. 2014-06-06 17:56:06 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix inter-view references array growth. Let the utility layer handle dynamic growth of the inter-view pictures array. By definition, setting a new size to the array will effectively grow the array, but would also fill in the newly created elements with empty entries (NULL), thus also increasing the reported length, which is not correct. 2014-06-03 17:36:38 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: reduce ReferenceFrames entries to the essential set. When decoding Multiview High profile streams with a large number of views, it is not possible to make the VAPictureParameterBufferH264. ReferenceFrames[] array hold the complete DPB, with all possibly active pictures to be used for inter-view prediction in the current access unit. So reduce the scope of the ReferenceFrames[] array to only include the set of reference pictures that are going to be used for decoding the current picture. Basically, this is a union of all RefPicListX[] array, for all slices constituting the decoded picture. 2014-06-04 19:10:44 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix MVC inter-view prediction process. The inter-view reference components and inter-view only reference components that are included in the reference picture lists shall be considered as not being marked as "used for short-term reference" or "used for long-term reference". This means that reference flags should all be removed from VAPictureH264.flags. This fixes decoding of MVCNV-2.264. 2014-06-04 19:03:18 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix detection of profile changes for MVC. If the VA driver exposes ad-hoc H.264 MVC profiles, then we have to be careful to detect profiles changes and not reset the underlying VA context erroneously. In MVC situations, we could indeed get a profile_idc change for every SPS that gets activated, alternatively (base-view -> non-base view -> base-view, etc.). An improved fix would be to characterize the exact profile to use once and for all when SPS NAL units are parsed. This would also allow for fallbacks to a base-view decoding only mode. 2014-06-03 14:30:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: drop extraneous definitions. Re-use definitions from the codecparser headers instead of duplicating them here again. That covers NALU definitions and slice types. 2014-04-01 11:26:04 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: remove unnecessary calcualtion of max_pic_order_cnt. https://bugzilla.gnome.org/show_bug.cgi?id=727418 2014-04-01 14:23:56 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: don't allow CABAC with Extended profile. The H.264 specification does not support CABAC entropy coding for the Extended profile. https://bugzilla.gnome.org/show_bug.cgi?id=727418 2014-05-07 00:12:39 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: use packed headers mode for MVC encoding. Exclusively use VA drivers that support raw packed headers for encoding. i.e. simply submit packed headers Subset SPS and Prefix NAL units. This provides for better compatibility accross the various VA drivers and HW generations since no particular API is needed beyond what readily exists. 2014-05-07 00:09:45 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: add support for packed slice headers. https://bugzilla.gnome.org/show_bug.cgi?id=722905 2014-05-07 00:09:19 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: store subset sps to generate the codec-data Store the SubsetSPS nal unit which we need for MVC specific codec_data generation. 2014-05-07 00:08:33 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix MVC pipeline hang while encoding with B-frames. Since we are encoding each view independently from each other, we need a higher number of pre-allocated surfaces to be used as the reconstructed frames. For Stereo High profile encoding, this means to effectively double the number of frames to be stored in the DPB. 2014-02-17 15:51:43 +0800 Li Xiaowei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst/vaapi/gstvaapiencode_h264.c: encoder: h264: add initial support for H.264 Stereo High profile. Add initial support for Subset SPS, Prefix NAL and Slice Extension NAL for non-base-view streams encoding, and the usual SPS, PPS and Slice NALs for base-view encoding. The H.264 Stereo High profile encoding mode will be turned on when the "num-views" parameter is set to 2. The source (raw) YUV frames will be considered as Left/Right view, alternatively. Each of the two views has its own frames reordering pool and reference frames list management system. Inter-view references are not supported yet, so the views are encoded independently from each other. Signed-off-by: Li Xiaowei [limited to Stereo High profile per the definition of MAX_NUM_VIEWS] Signed-off-by: Gwenole Beauchesne 2014-02-17 11:10:26 +0800 Li Xiaowei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: wrap pools for refs and frames reordering. Create structures to maintain the reference frames list (RefPool) and frames reordering (ReorderPool) logic. This is a prerequisite for H.264 MVC support. Signed-off-by: Li Xiaowei 2014-02-14 15:33:15 +0800 Li Xiaowei * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: add provisional support for subset SPS headers. Add provisions to write subset SPS headers to the bitstream in view to supporting the H.264 MVC specification. This assumes the libva "staging" branch is in use. Signed-off-by: Li Xiaowei 2013-12-18 13:47:32 +0800 Li Xiaowei * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiutils.c: utils: add H.264 MVC profiles. Add "MultiView High" and "Stereo High" definitions. Signed-off-by: Li Xiaowei [require VA-API >= 0.35.2 for MVC profiles] Signed-off-by: Gwenole Beauchesne 2014-06-02 16:25:03 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiutils.c: utils: only enable VP8 profiles for newer VA-API versions. VP8 decoding API appeared in VA-API >= 0.35.0. So, disable mappings involving VP8 codec on earlier versions of the API. 2014-05-22 10:04:46 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: compute view ids only once per slice. Optimize lookups of view ids / view order indices by caching the result of the calculatiosn right into the GstVaapiParserInfoH264 struct. This terribly simplifies is_new_access_unit() and find_first_field() functions. 2014-05-21 17:57:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add support for MVC interlaced streams. Fix support for MVC Stereo High profile streams with interlaced frames. Also improve the detection logic of the first field. 2014-05-20 18:08:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add MVC profiles compatibility logic. Add safe fallbacks for MVC profiles: - all MultiView High profile streams with 2 views at most can be decoded with a Stereo High profile compliant decoder ; - all Stereo High profile streams with only progressive views can be decoded with a MultiView High profile compliant decoder ; - all drivers that support slice-level decoding could normally support MVC profiles when the DPB holds at most 16 frames. 2014-05-02 14:58:45 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: h264: add initial support for MVC. https://bugzilla.gnome.org/show_bug.cgi?id=721772 2014-05-01 19:16:09 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: dynamically allocate the DPB. Dynamically allocate the Decoded Picture Buffer (DPB) and add provisions for supporting the MVC allocation requirements. 2014-05-01 19:33:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix detection of access unit boundaries. In order to have a stricter conforming implementation, we need to carefully detect access unit boundaries. Additional operations could be necessary to perform at those boundaries. 2013-03-13 11:44:38 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: detect the first VCL NAL unit of a picture for MVC. Detect the first VCL NAL unit of a picture for MVC, based on the view_id as per H.7.4.1.2.4. Note that we only need to detect new view components. Signed-off-by: Gwenole Beauchesne 2013-10-31 19:32:55 +0800 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: properly handle Prefix NAL units. Always cache the previous NAL unit so that we could check whether there is a Prefix NAL unit immediately preceding the current slice or IDR NAL unit. In that case, the NAL unit metadata is copied into the current NAL unit. Otherwise, some default values are inferred, tentatively. e.g. view_id shall be set to 0 and inter_view_flag to 1. [infer default values for slice if previous NAL was not a Prefix] Signed-off-by: Gwenole Beauchesne 2013-02-28 15:59:55 +0800 Xiaowei Li * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add support for MVC base views. Allow decoding for base views of MVC encoded streams. For now, just skip the slice extension and prefix NAL units, and skip non-base view frames. Signed-off-by: Xiaowei Li [fixed memory leak, improved check for MVC NAL units] Signed-off-by: Gwenole Beauchesne 2014-05-04 14:49:28 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: simplify storage of decoded picture into DPB. Factor out process by which the decoded picture with the lowest POC is found, and possibly output. Likewise, the storage and marking of a reference decoded, or non-reference decoded picture, into the DPB could also be simplified as they mostly share the same operations. 2014-05-02 22:40:16 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: minor clean-ups. Make init_picture_ref_lists() more consistent with other functions related to the reference marking process by supplying the current picture as argument. 2014-05-20 11:36:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: display: add utility function to query VA driver name. Add gst_vaapi_display_get_vendor_string() helper function to query the underlying VA driver name. The display object owns the resulting string, so it shall not be deallocated. That function is thread-safe. It could be used for debugging purposes, for instance. 2014-03-07 14:50:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: make cache maintenance really MT-safe. Make sure to initialize one GstVaapiDisplay at a time, even in threaded environments. This makes sure the display cache is also consistent during the whole display creation process. In the former implementation, there were risks that display cache got updated in another thread. 2014-05-03 15:56:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: context: allow dynamic growth of VA surfaces pool. Add support for dynamic growth of the VA surfaces pool. For decoding, this implies the recreation of the underlying VA context, as per the requirement from VA-API. Besides, only increases are supported, not shrinks. 2014-05-03 15:47:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: context: reset VA context if VA surfaces set changed. It is a requirement from VA-API specification that the VA context got from vaCreateContext(), for decoding purposes, binds the supplied set of VA surfaces. This means that if the set of VA surfaces is to be changed for the current decode session, then the VA context needs to be recreated with the new set of VA surfaces. 2014-05-12 19:23:04 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix assignment of LongTermFrameIdx. Complement fix committed as e95a42e. The H.264 AVC standard has to say: if the field is part of a reference frame or a complementary reference field pair, and the other field of the same reference frame or complementary reference field pair is also marked as "used for long-term reference", the reference frame or complementary reference field pair is also marked as "used for long-term reference" and assigned LongTermFrameIdx equal to long_term_frame_idx. This fixes decoding of MR9_BT_B in strict mode. https://bugs.freedesktop.org/show_bug.cgi?id=64624 https://bugzilla.gnome.org/show_bug.cgi?id=724518 2014-05-10 06:23:29 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: decoder: h264: properly support grayscale formats. Request the correct chroma format for decoding grayscale streams. i.e. make lookups of the VA chroma format more generic, thus possibly supporting more formats in the future. This means that, if a VA driver doesn't support grayscale formats, it is now going to fail. We cannot safely assume that maybe grayscale was implemented on top of some YUV 4:2:0 with the chroma components all set to 0x80. 2014-02-06 11:14:09 +0000 Simon Farnsworth * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * tests/test-filter.c: build: fix source file modes. A few source files are marked executable in error - fix them https://bugzilla.gnome.org/show_bug.cgi?id=723748 Signed-off-by: Simon Farnsworth 2014-04-29 13:22:47 +0300 Sreerenj Balachandran * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst/vaapi/gstvaapidecode.c: build: fix conditional compilation of VP8 decoder. https://bugzilla.gnome.org/show_bug.cgi?id=729170 [added check for VASliceParameterBufferBase fields] Signed-off-by: Gwenole Beauchesne 2014-04-27 08:55:24 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: build: fix make dist for codecparsers. 2014-04-28 09:42:13 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit eaa3f7e. h264: fix parsing of slice groups for map type = 2 2014-04-26 22:35:49 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi branch commit f44edfc. h264: fix derivation of default scaling lists 2013-05-24 19:00:54 +0800 Cong Zhong * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix long-term reference picture marking process. Fix reference picture marking process with memory_management_control_op set to 3 and 6, i.e. assign LongTermFrameIdx to a short-term reference picture, or the current picture. This fixes decoding of FRExt_MMCO4_Sony_B. https://bugs.freedesktop.org/show_bug.cgi?id=64624 https://bugzilla.gnome.org/show_bug.cgi?id=724518 [squashed, edited to use GST_VAAPI_PICTURE_IS_COMPLETE() macro] Signed-off-by: Gwenole Beauchesne 2014-04-26 20:21:46 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix initialization of RefPicLists for multiple slices. The initialization of reference picture lists (8.2.4.2) applies to all slices. So, the RefPicList0/1 lists need to be constructed prior to each slice submission to the HW decoder. This fixes decoding of video sequences where frames are encoded with multiple slices of different types, e.g. 4 slices in this order I, P, I, and P. More precisely, CABAST3_Sony_E and CABASTBR3_Sony_B. https://bugzilla.gnome.org/show_bug.cgi?id=724518 2013-06-04 15:01:46 +0800 Zhong Cong * ext/codecparsers: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: skip SPS extension and auxiliary slice NALs. When NAL units of type 13 (SPS extension) or type 19 (auxiliary slice) are present in a video, decoders shall perform the (optional) decoding process specified for these NAL units or shall ignore them (7.4.1). Implement option 2 (skip) for now, as alpha composition is not supported yet during the decoding process. This fixes decoding of the primary coded video in alphaconformanceG. https://bugzilla.gnome.org/show_bug.cgi?id=703928 https://bugzilla.gnome.org/show_bug.cgi?id=728869 https://bugzilla.gnome.org/show_bug.cgi?id=724518 [skip NAL units earlier, i.e. at parsing time] Signed-off-by: Gwenole Beauchesne 2013-03-07 11:32:20 +0800 Li Xiaowei * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix slice data bit offset with MVC NAL units. When MVC slice NAL units (coded slice extension and prefix NAL) are present, the number of NAL header bytes is 3, not 1 as usual. Signed-off-by: Li Xiaowei Signed-off-by: Gwenole Beauchesne 2014-04-25 19:11:03 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix activation of picture and sequence parameters. At the time the first VCL NAL unit of a primary coded picture is found, and if that NAL unit was parsed to be an SPS or PPS, then the entries in the parser may have been overriden. This means that, when the picture is to be decoded, slice_hdr->pps could point to an invalid (the next) PPS entry. So, one way to solve this problem is to not use the parser PPS and SPS info but rather maintain our own activation chain in the decoder. https://bugzilla.gnome.org/show_bug.cgi?id=724519 https://bugzilla.gnome.org/show_bug.cgi?id=724518 2014-04-25 16:24:01 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: retain SEI messages until the end of frame. Retain the SEI messages that were parsed from the access unit until we have completely decoded the current frame. This is done so that we can peek at that data whenever necessary during decoding. e.g. for exposing 3D stereoscopic information at a later stage. 2014-04-25 14:23:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: add support for grayscale encoded clips. Fix support for grayscale encoded video clips, and possibly others if the underlying driver supports the non-YUV 4:2:0 formats. i.e. defer the decision that a surface with the desired chroma format is not supported to the actual VA driver implementation. https://bugzilla.gnome.org/show_bug.cgi?id=728144 2014-04-25 14:16:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: decoder: default to YUV 4:2:0 VA surfaces. Cope with context changes to support non-YUV 4:2:0 VA surfaces. Still, make sure all codecs use YUV 4:2:0 output format for now, by default. 2014-04-25 13:57:02 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: re-indent GstVaapiDecoder base object. 2014-04-25 13:47:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: encoder: derive chroma type from video format. Cope with previous VA context change to derive the correct surface chroma type from the input video format. 2014-04-25 13:45:31 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: context: add support for non-YUV 4:2:0 formats. Don't force allocation of VA surfaces in YUV 4:2:0 format. Rather, allow for the upper layer to specify the desired chroma type. If the chroma type field is not set (or yields zero), then YUV 4:2:0 format is used by default. 2014-04-22 19:53:50 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: vp8: fix per-segment deblocking filter level in relative mode. Fix possible bug when a per-segment deblocking filter level value needs to be set in non-absolute mode, i.e. when the loop filter update value is negative in delta mode. Also clamp the resulting filter level value to 0..63 range. 2014-04-22 17:25:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: vp8: fix check for disabling the loop filter (again). Improve condition to disable the loop filter. The previous heuristic used to check all filter levels, for all segments. It turns out that only the base filter_level value defined in the frame header needs to be checked. This fixes 00-comprehensive-013. 2014-04-21 18:02:21 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: * gst/vaapi/Makefile.am: build: fix make dist with certain conditionals not met. Fix generation of source tarballs when certain conditionals are not met. e.g. always include all buildable codecparsers sources in the distribution tarball, fix plug-in element sources set to include X11 and encoder bits. 2014-04-21 17:34:59 +0200 Gwenole Beauchesne * ext/Makefile.am: build: add missing files for GStreamer 0.10. Add missing GstVideoEncoder implementation files to fix build with ancient GStreamer 0.10 stack. https://bugzilla.gnome.org/show_bug.cgi?id=723964 2014-04-19 10:17:20 +0200 Gwenole Beauchesne * ext/Makefile.am: build: add missing files for VP8 bitstream parser. Fix make dist for building the VP8 bitstream parser. 2014-04-21 17:49:38 +0200 Gwenole Beauchesne * configure.ac: * ext/libvpx/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: vp8: allow compilation without the built-in libvpx. The built-in libvpx serves multiple purposes, among which the most important ones could be: track the most up-to-date, and optimized, range decoder; allow for future hybrid implementations (non-VLD); and have a completely independent range decoder implementation. 2014-04-21 17:28:27 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: vp8: propagate PTS from demux frame. gst_adapter_prev_pts() is forbidden within libgstvaapi. Besides, the demuxer or parser would already have determined the PTS from a previous stage. 2014-04-19 07:49:30 +0200 Gwenole Beauchesne * Makefile.am: * debian.upstream/libgstvaapi.install.in: * ext/libvpx/Makefile.am: * ext/libvpx/sources.frag: * gst-libs/gst/codecparsers/Makefile.am: vp8: fix compilation with built-in libvpx. Apply correct patch from fd.o #722760 to fix several issues: update the license terms to LGPLv2.1+, fix dependencies to built-in libvpx and fix make dist. 2014-02-13 21:17:23 +0100 Gwenole Beauchesne * .gitmodules: * autogen.sh: * configure.ac: * ext/Makefile.am: * ext/libvpx/Makefile.am: * ext/libvpx/gstlibvpx.c: * ext/libvpx/gstlibvpx.h: * ext/libvpx/libgstcodecparsers_vpx.vers: * ext/libvpx/sources.frag: * ext/libvpx/upstream: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/codecparsers/gstvaapilibvpx.c: vp8: use range decoder from libvpx. Add libvpx submodule that tracks the upstream version 1.3.0. This is needed to build a libgstcodecparsers_vpx.so library with all symbols placed into the GSTREAMER namespace. 2014-04-04 19:17:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: vp8: fix check for disabling the loop filter. 2013-12-27 07:18:24 +0800 Zhao, Halley * configure.ac: * ext/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.c: * gst-libs/gst/vaapi/gstvaapidecoder_vp8.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst/vaapi/gstvaapidecode.c: Add initial VP8 decoder. https://bugzilla.gnome.org/show_bug.cgi?id=722761 [complete overhaul, fixed support for resolution changes] Signed-off-by: Gwenole Beauchesne 2014-03-21 15:15:37 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: cope with new gst_h264_parser_parse_sei() interface. The gst_h264_parse_parse_sei() function now returns an array of SEI messages, instead of a single SEI message. Reason: it is allowed to have several SEI messages packed into a single SEI NAL unit, instead of multiple NAL units. 2014-04-18 19:36:16 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit a454f86. b2eb5f6 vp8: rename dboolhuff symbols b74a881 vp8: add GStreamer native utilities 2940ac6 add VP8 bitstream parser 2014-04-18 19:16:56 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit d459bc5. d459bc5 h264: set framerate even for interlaced videos c78b82c h264: add support for Recovery Point SEI message 7693bac h264: add support for Frame Packing Arrangement SEI message 31fafa7 h264: add support for Stereo Video Information SEI message 8b113a6 h264: parse seq_parameter_set_mvc_extension() 040f9b8 h264: parse MVC syntax elements cc18ef3 h264: add nal_reader_skip_long() helper 7e76a48 h264: fix slice_header() parsing for MVC caf46d8 h264: add gst_h264_parse_nalu_header() helper f75074e h264: add gst_h264_parse_sps_data() helper 798c397 h264: clean-up gst_h264_parser_parse_sei_message() 4e36737 h264: fix skipping of unsupported SEI messages 5300766 h264: fix SEI buffering_period() parsing 2014-03-21 15:09:14 +0100 Gwenole Beauchesne * ext/codecparsers: * gst-libs/gst/codecparsers/Makefile.am: codecparsers: update to gst-vaapi-branch commit 8fadf40. 8fadf40 h264: Fix multiple SEI messages in one SEI RBSP parsing. 644825f h265: remove trailling 0x00 bytes as the spec doesn't allow them 95f9f0f h264: remove trailling 0x00 bytes as the spec doesn't allow them 766007b h265: Initialize pointer correctly that is never assigned but freed in error cases 8ec5816 h265: Fix segfault when parsing HRD parameter 5b1730f h265: Fix segfault when parsing VPS 983b7f7 h265: prevent to overrun chroma_weight_l0_flag 7ba641d h265: Fix debug output d9f9f9b h264: not all startcodes should have 3-byte 0 prefix 2014-02-04 18:35:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix robustness patch for bytestream format. Fix parser and decoder state to sync at the right locations. This is because we could reset the parser state, while the decoder state was not copied yet, e.g. when parsing several NAL units from multiple frames whereas the current frame was not decoded yet. This is a regression brought in by commit 6fe5496. 2014-02-18 06:56:51 +0100 Gwenole Beauchesne * configure.ac: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-drm.pc.in: * pkgconfig/gstreamer-vaapi-glx.pc.in: * pkgconfig/gstreamer-vaapi-wayland.pc.in: * pkgconfig/gstreamer-vaapi-x11.pc.in: build: fix pkgconfig file names (again). It turns out it is more convenient to have only pkgconfig files named after the installed GStreamer API version (1.0) instead of using all possible subsequent names from that (1.0, 1.2, 1.4). i.e. they conflict altogether anyway, so align pkgconfig file names to that. 2014-02-07 09:43:51 +0100 Gwenole Beauchesne * debian.upstream/libgstvaapi-dev.install.in: * gst-libs/gst/vaapi/Makefile.am: * pkgconfig/gstreamer-vaapi.pc.in: build: fix packaging for GStreamer 1.2. Fix gstreamer-vaapi includedir for GStreamer 1.2 setups. i.e. use the pkgconfig version (1.0) instead of the intended API version (1.2). libgstvaapi1.0-dev and libgstvaapi1.2-dev packages will now conflict, as would core GStreamer 1.0 and GStreamer 1.2 dev packages anyway. 2014-01-24 11:27:30 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2014-01-24 10:55:39 +0100 Gwenole Beauchesne * debian.upstream/control.in: debian: fix trailing whitespace in description. 2014-01-23 23:24:55 +0100 Gwenole Beauchesne * debian.upstream/control.in: * debian.upstream/copyright: debian: fix package description. Try to improve package description for the compiled plug-in elements available in there. e.g. only display vaapidownload and vaapiupload for GStreamer 0.10 builds, display vaapiencode_* elements when VA encoding is enabled, etc. Also increase the copyright notice date. 2014-01-23 22:47:19 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: build: fix warnings on 64-bit platforms. 2014-01-23 22:44:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiutils.c: build: fix for older versions of VA-API (< 0.34.0). Fix build with older versions of VA-API (< 0.34.0), or versions without good enough headers for encoding support for instance. 2014-01-23 19:36:14 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.8. 2014-01-23 19:32:28 +0100 Gwenole Beauchesne * README: README: updates. VA-API up to 0.34.0 is actually supported. Mention new video encoding support. Update copyright years, list of supported Intel HD Graphics hardware. 2014-01-23 19:18:13 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2014-01-20 14:16:56 +0100 Gwenole Beauchesne * tests/test-filter.c: tests: test-filter: fix "deinterlace" option parse. Default to GST_VAAPI_DEINTERLACE_METHOD_NONE if no "deinterlace" option string was provided, i.e. if it remained set to NULL. 2014-01-23 18:41:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiutils_core.c: * gst-libs/gst/vaapi/gstvaapiutils_core.h: libs: factor out usages of vaGetConfigAttributes(). Add gst_vaapi_get_config_attribute() helper function that takes a GstVaapiDisplay and the rest of the arguments with VA types. The aim is to have thread-safe VA helpers by default. 2014-01-23 17:41:02 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: libs: re-indent all source code related to VA utilities. 2014-01-23 17:06:08 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/libgstvaapi_priv_check.h: libs: add missing file (libgstvaapi_priv_check.h). 2014-01-23 15:13:06 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: notify the encoder of the submitted packed headers. Make sure to configure the encoder with the set of packed headers we intend to generate and submit. i.e. make selection of packed headers to submit more robust. 2014-01-23 15:10:11 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: fix and factor out check for supported rate-control modes. Cache the first compatible GstVaapiProfile found if the encoder is not configured yet. Next, factor out the code to check for the supported rate-control modes by moving out vaGetConfigAttributes() to a separate function, while also making sure that the attribute type is actually supported by the encoder. Also fix the default set of supported rate control modes to not the "none" variant. It's totally useless to expose it at this point. 2014-01-23 14:01:33 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: context: move rate-control mode to encoder specific config. Move usage-specific config out of the common GstVaapiContextInfo. Create a specialized config for encoding and move rate-control mode to there. 2014-01-23 13:30:41 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: context: introduce concept of usage. Introduce GstVaapiContextUsage so that to explicitly determine the usage of a VA context. This is useful in view to simplifying the creation of VA context for VPP too. 2014-01-23 11:44:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: context: fix get_attribute() value result. Unknown attributes, or attributes that are not supported for the given profile/entrypoint pair have a return value of VA_ATTRIB_NOT_SUPPORTED. So, return failure in this case. 2014-01-23 10:59:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapicontext_overlay.c: * gst-libs/gst/vaapi/gstvaapicontext_overlay.h: * gst-libs/gst/vaapi/gstvaapisurface.c: context: move overlay composition to separate files. Move GstVideoOverlayComposition handling to separate source files. This helps keeing GstVaapiContext core implementation to the bare minimal, i.e. simpy helpers to create a VA context and handle pool of associated VA surfaces. 2014-01-23 09:41:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.c: context: clean-ups. Strip down APIs. Improve documentation and debug messages. Clean-up APIs, i.e. strip them down to the minimal set of interfaces. They are private, so no need expose getters for instance. 2014-01-23 09:27:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: context: re-indent all GstVaapiContext related source code. 2014-01-23 10:20:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: libs: check that private headers remain private. Make sure that libgstvaapi private headers remain internally used to build libgstvaapi libraries only. All header dependencies were reviewed and checks for IN_LIBGSTVAAPI definition were added accordingly. Also rename GST_VAAPI_CORE definition to IN_LIBGSTVAAPI_CORE to keep consistency. 2014-01-22 19:04:58 +0100 Gwenole Beauchesne * configure.ac: Bump library major version. Bump the library major version due to API/ABI changes that occurred in the imaging API. In particular, GstVaapiDisplay interfaces no longer expose any GstCaps but provide GArray based ones e.g. to determine the set of supported decode/encode profiles. 2014-01-22 18:54:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: * gst-libs/gst/vaapi/gstvaapicodedbufferpool.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapivideometa_texture.c: * tests/simple-decoder.c: legal: update copyright notice dates. 2014-01-22 18:49:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: legal: add per-file authorship information. 2014-01-22 18:11:26 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: fix video codec frame number in standalone mode. Set a valid GstVideoCodecFrame.system_frame_number when decoding a stream in standalone mode. While we are at it, improve the debugging messages to also include that frame number. 2014-01-17 16:56:53 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: decoder: fix crash on invalid pointer for GST_DEBUG(). When decoding failed, or that the frame was dropped, the associated surface proxy is not guaranteed to be present. Thus, the GST_DEBUG() message needs to check whether the proxy is actually present or not. https://bugzilla.gnome.org/show_bug.cgi?id=722403 [fixed gst_vaapi_surface_proxy_get_surface_id() to return VA_INVALID_ID] Signed-off-by: Gwenole Beauchesne 2014-01-22 17:07:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: disable NAL HRD parameters for now. Don't emit NAL HRD parameters for now in the SPS headers because the SEI buffering_period() and picture_timing() messages are not handled yet. Some additional changes are necessary to get it right. https://bugzilla.gnome.org/show_bug.cgi?id=722734 2014-01-21 19:04:41 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: encoder: h264: fix default CPB buffer size. Fix default CPB buffer size to something more reasonable (1500 ms) and that still fits the level limits. This is a non configurable property for now. The initial CPB removal delay is also fixed to 750 ms. https://bugzilla.gnome.org/show_bug.cgi?id=722087 2014-01-22 14:43:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix bitrate encoding for HRD conformance. Round down the calculated, or supplied, bitrate (kbps) into a multiple of the HRD bitrate scale factor. Use a bitrate scale factor of 64 so that to have less losses in precision. Likewise, don't round up because that could be a strict constraint imposed by the user. 2014-01-22 11:25:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix level lookup constraints wrt. bitrate. Fix the level calculation involving bitrate limits. Since we are targetting NAL HRD conformance, the check against MaxBR from the Table A-1 limits shall involve cpbBrNalFactor depending on the active profile. 2014-01-21 18:01:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: submit sequence parameter only once. Submit sequence parameter buffers only once, or when the bitstream was reconfigured in a way that requires such. Always submit packed sequence parameter buffers at I-frame period, if the VA driver needs those. https://bugzilla.gnome.org/show_bug.cgi?id=722737 2014-01-21 18:35:17 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: h264: only submit packed headers when required. Make sure to submit the packed headers only if the underlying VA driver requires those. Currently, only handle packed sequence and picture headers. https://bugzilla.gnome.org/show_bug.cgi?id=722737 2014-01-21 17:35:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix ip_period value in sequence parameter. The VAEncSequenceParameterBuffer.ip_period value reprents the distance between the I-frame and the next P-frame. So, this also accounts for any additional B-frame in the middle of it. This fixes rate control heuristics for certain VA drivers. https://bugzilla.gnome.org/show_bug.cgi?id=722735 2014-01-21 17:04:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix level when bitrate is automatically computed. Fix level characterisation when the bitrate is automatically computed from the active coding tools. i.e. ensure the bitrate once the profile is completely characterized but before the level calculation process. 2014-01-21 16:05:22 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: clean-ups. Document and rename a few functions here and there. Drop code that caps num_bframes variable in reset_properties() since they shall have been checked beforehand, during properties initialization. 2014-01-21 15:28:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: clean-up bitwriter related utilities. Clean-up GstBitWriter related utility functions and simplify notations. While we are at it, also make bitstream writing more robust should an overflow occur. We could later optimize for writing headers capped to their maximum possible size by using the _unchecked() helper variants. 2014-01-21 15:23:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: h264: completely remove private headers. Drop private header since it was originally used to expose internals to the plugin element. The proper interface is now the properties API, thus rendering private headers totally obsolete. 2014-01-15 15:54:32 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix PPS header packing with profile < high. Fix PPS header packing when profile is below High since 8x8 transform mode and scaling lists are High Profile features. 2014-01-15 15:46:19 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: always emit VUI parameters for framerate. Always emit VUI parameters for timing_info, which includes framerate information. 2014-01-15 15:10:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: really fix frame cropping rectangle calculation. Make frame cropping rectangle calculation future proof, i.e. exactly follow the specification (7-18) to (7-21), and subsampling definitions from Table 6-1. https://bugzilla.gnome.org/show_bug.cgi?id=722089 https://bugzilla.gnome.org/show_bug.cgi?id=722238 2014-01-15 12:09:14 +0100 Holger Kaelberer * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: set csc render flags from sinkpad caps. This maps GstVideoColorimetry information in vaapisink's sinkpad caps to GST_VAAPI_COLOR_STANDARD_* flags, if per-buffer information was not available. https://bugzilla.gnome.org/show_bug.cgi?id=722255 [factored out code, added SMPTE240M, handle per-buffer flags] Signed-off-by: Gwenole Beauchesne 2012-03-28 15:05:26 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst/vaapi/gstvaapipostproc.c: surface: rework render flags. Pack render flags per category and provide more flags into the color standard category. In particular, cover for SMPTE-240M. 2013-12-13 04:14:41 +0800 Zhao, Halley * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add support for colorbalance filters. Add support for hue, saturation, brightness and constrat adjustments. Also fix cap info local copy to match the really expected cap subtype of interest. https://bugzilla.gnome.org/show_bug.cgi?id=720376 Signed-off-by: Gwenole Beauchesne 2013-12-12 08:38:12 +0800 Zhao, Halley * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix support for "sharpen" filter. Fix copy/paste error when submitting the "sharpen" value to the GstVaapiFilter instance. https://bugzilla.gnome.org/show_bug.cgi?id=720375 Signed-off-by: Gwenole Beauchesne 2013-12-20 12:05:42 +0000 Lionel Landwerlin * configure.ac: * pkgconfig/gstreamer-vaapi-drm.pc.in: * pkgconfig/gstreamer-vaapi-glx.pc.in: * pkgconfig/gstreamer-vaapi-wayland.pc.in: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: pkgconfig: plugin dir should use PKG version not API version. Fix the pluginsdir and includedir variables in the generated pkgconfig (.pc) files. The location needs to be built with the PKG version in mind instead of the API version. While we are at it, also fix the PKG version for GStreamer >= 1.3. https://bugzilla.gnome.org/show_bug.cgi?id=720820 [additional fixes for includedir and pkg requirements] Signed-off-by: Gwenole Beauchesne 2014-01-15 10:05:45 +0100 Holger Kaelberer * gst/vaapi/gstvaapisink.c: vaapisink: fix display initialization in GstVideoOverlay implementation. When gst_vaapisink_video_overlay_set_window_handle() is called early, before the pipeline has been set to PLAYING, the display has not yet been initialized and _PLUGIN_BASE_DISPLAY_TYPE() is not yet up-to-date. For this reason the foreign XID is not attached. Now _ensure_display() is called earlier. https://bugzilla.gnome.org/show_bug.cgi?id=722244 Signed-off-by: Gwenole Beauchesne 2013-10-09 13:47:54 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: expose the raw video formats in static caps template. Expose all raw video formats in the static caps template since the vaapisink is supporting raw data. We will get the exact set of formats supported by the driver dynamically through the _get_caps() routine. https://bugzilla.gnome.org/show_bug.cgi?id=703271 https://bugzilla.gnome.org/show_bug.cgi?id=720737 Signed-off-by: Gwenole Beauchesne 2013-12-11 18:08:26 +0000 Matthieu Bouron * gst/vaapi/gstvaapidecode.c: vaapidecode: query downstream caps features like GLTextureUploadMeta. Fix vaapidecode to correctly report caps features downstream, when a custom pipeline is built manually. https://bugzilla.gnome.org/show_bug.cgi?id=719372 Signed-off-by: Gwenole Beauchesne 2013-12-17 15:27:10 +0000 Matthieu Bouron * gst/vaapi/gstvaapidecode.c: vaapidecode: add system memory caps to template caps. Since vaapidecode provides buffer that can be mapped as regular memory, those caps should be added to the template caps. That only applies to GStreamer >= 1.2. https://bugzilla.gnome.org/show_bug.cgi?id=720608 Signed-off-by: Gwenole Beauchesne 2013-12-17 10:26:03 +0800 Wind Yuan * gst/vaapi/gstvaapidecode.c: vaapidecode: fix hang on SIGINT. vaapidecode hangs when pipeline is stopped without any EOS, e.g. when +C is pressed, thus causing the srcpad task to keep running and locked. This fixes a deadlock on state change from PAUSED to READY. https://bugzilla.gnome.org/show_bug.cgi?id=720584 Signed-off-by: Gwenole Beauchesne 2013-12-17 04:23:42 -0500 Wind Yuan * gst/vaapi/gstvaapiencode.c: vaapiencode: fix possible hang on SIGINT. vaapiencode might hang when the pipeline is stopped without any EOS, e.g. when +C is pressed, thus causing the srcpad task to keep running and locked. This fixes a possible deadlock on state change from PAUSED to READY. https://bugzilla.gnome.org/show_bug.cgi?id=720584 Signed-off-by: Gwenole Beauchesne 2014-01-14 16:33:04 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: fix typo in error message. Fix incomplete error message in gst_vaapiencode_push_frame(). 2014-01-14 19:08:36 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: plugins: add helpers to create video caps with features. Add gst_vaapi_video_format_new_template_caps_with_features() helper function to add the supplied caps feature string on GStreamer >= 1.2. Add gst_vaapi_find_preferred_caps_feature() helper function to discover the "best" caps feature to use for the supplied pad. In practice, we will always favor memory:VASurface first, then meta:GLTextureUploadMeta, and finally the system memory caps. https://bugzilla.gnome.org/show_bug.cgi?id=719372 2014-01-09 11:54:11 +0000 Matthieu Bouron * gst/vaapi/gstvaapivideometa_texture.c: plugins: don't apply overlay composition in GLTextureUpload function. The GLTextureUpload function is not in charge of doing the overlay composition if any. https://bugzilla.gnome.org/show_bug.cgi?id=721859 Signed-off-by: Gwenole Beauchesne 2014-01-14 13:47:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: encoder: re-order submission of VA objects. Change the submission order of VA objects so that to make that process more logical. i.e. submit sequence parameter first, if any; next the packed headers associated to sequece, picture or slices; and finally the actual picture and associated slices. 2014-01-14 12:01:11 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: encoder: clean-up objects. Various clean-ups to improve consistency and readability: rename some variables, drop unused macro definitions, drop initialization of vars that are zero-initialized from the base class, drop un-necessary casts, allocate GPtrArrays with a destroy function. 2014-01-13 13:41:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: fix frame cropping rectangle calculation. Fix frame cropping rectangle calculation to handle horizontal resolutions that don't match a multiple of 16 pixels, but also the vertical resolution that was incorrectly computed for progressive sequences too. https://bugzilla.gnome.org/show_bug.cgi?id=722089 2014-01-13 11:49:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: improve automatic bitrate calculation. For non "Constant-QP" modes, we could provide more reasonable heuristics for the target bitrate. In general, 48 bits per macroblock with all the useful coding tools enable looks safe enough. Then, this rate is raised by +10% to +15% for each coding tool that is disabled. https://bugzilla.gnome.org/show_bug.cgi?id=719699 2014-01-13 11:11:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: support "high-compression" tuning option. Add support for "high-compression" tuning option. First, determine the largest supported profile by the hardware. Next, check any target limit set by the user. Then, enable each individual coding tool based on the resulting profile_idc value to use. https://bugzilla.gnome.org/show_bug.cgi?id=719696 2014-01-12 22:24:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst/vaapi/gstvaapiencode_h264.c: encoder: h264: allow target decoder constraints. Allow user to precise the largest profile to use for encoding due to target decoder constraints. For instance, if CABAC entropy coding mode is requested by "constrained-baseline" profile only is desired, then an error is returned during codec configuration. Also make sure that the suitable profile we derived actually matches what the HW can cope with. https://bugzilla.gnome.org/show_bug.cgi?id=719694 2014-01-12 22:14:11 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: encoder: h264: refine size of coded buffer. Refine the heuristic to determine the maximum size of a coded buffer to account for the exact number of slices. set_context_info() is the last step during codec reconfiguration, no additional change is done afterwards, so re-using the num_slices field here is fine. https://bugzilla.gnome.org/show_bug.cgi?id=719953 2013-12-13 17:36:08 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: h264: expose more coding tools. Add new H.264 coding tools to improve compression: - "cabac": enable CABAC entropy coding (default: FALSE); - "dct8x8": enable spatial transform 8x8 (default: FALSE). https://bugzilla.gnome.org/show_bug.cgi?id=719693 Signed-off-by: Gwenole Beauchesne 2014-01-10 18:18:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: h264: derive profile and level from active coding tools. Automatically derive the minimum profile and level to be used for encoding, based on the activated coding tools. The encoder will be trying to generate a bitstream that has the best chances to be decoded on most platforms by default. Also change the default profile to "constrained-baseline" so that to ensure maximum compatibility when the stream is decoded. https://bugzilla.gnome.org/show_bug.cgi?id=719691 2014-01-10 17:02:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: h264: fix hardware profile lookup. Fix lookup for a suitable HW profile, as to be used by the underlying hardware, based on heuristics that lead to characterize the SW profile, i.e. the one used by the SW level encoding logic. Also fix constraint_set0_flag (A.2.1) and constraint_set1_flag (A.2.2) as they should respectively match the baseline and main profile. https://bugzilla.gnome.org/show_bug.cgi?id=719827 2014-01-10 14:46:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: h264: support only the byte-stream format. The libgstvaapi core encoders are meant to support raw bitstreams only. Henceforth, we are always producing a stream in "byte-stream" format. However, the "codec-data" buffer which holds SPS and PPS headers is always available. The "lengthSizeMinusOne" field is always set to 3 so that in-place "byte-stream" format to "avc" format conversion could be performed. 2014-01-10 14:05:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst/vaapi/gstvaapiencode_h264.c: encoder: h264: clean-ups. Various clean-ups to improve consistency and readability: rename some variables, drop unused macro definitions, drop initialization of vars that are zero-initialized from the base class, drop un-necessary casts. 2014-01-13 17:11:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: mpeg2: fix hardware profile lookup. Fix lookup for a suitable HW profile, as to be used by the underlying hardware, based on heuristics that lead to characterize the SW profile, i.e. the one used by the SW level encoding logic. 2014-01-13 16:56:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: encoder: mpeg2: derive profile and level from active coding tools. Automatically derive the minimum profile and level to be used for encoding, based on the activated coding tools. Improve lookup for the best suitable level with the new MPEG-2 helper functions. Also change the default profile to "simple" so that to ensure maximum compatibility when the stream is decoded. https://bugzilla.gnome.org/show_bug.cgi?id=719703 2014-01-13 14:41:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: encoder: mpeg2: clean-ups. Various clean-ups to improve consistency and readability: drop unused macro definitions, drop initialization of vars that are zero-initialized from the base class, drop un-necessary casts. 2014-01-13 10:48:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: add tuning options API. Add encoder "tune" option to override the default behaviour that is to favor maximum decoder compatibility at the expense of lower compression ratios. Expected tuning options to be developed are: - "high-compression": improve compression, target best-in-class decoders; - "low-latency": tune for low-latency decoding; - "low-power": tune for encoding in low power / resources conditions. 2014-01-12 23:17:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: fix bitrate units to match kbps. Bitrate is expressed in kilobits per second (kbps). So, this exactly means in multiple of 1000 bits, not 1024 bits. https://bugzilla.gnome.org/show_bug.cgi?id=722086 2014-01-12 21:57:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: clean-ups. Drop obsolete and unused macros. Add a few doc comments. Slightly improve indentation of a few leftovers. 2014-01-12 18:52:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: encoder: filter out the supported set of rate-control properties. Only expose the exact static set of supported rate-control properties to the upper layer. For instance, if the GstVaapiEncoderXXX class does only support CQP rate control, then only add it the the exposed enum type. Add helper macros and functions to build a GType for an enum subset. 2014-01-10 13:23:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: add keyframe period API. Add gst_vaapi_encoder_set_keyframe_period() interface to allow the user control the maximum distance between two keyframes. This new property can only be set prior to gst_vaapi_encoder_set_codec_state(). A value of zero for "keyframe-period" gets it re-evaluated to the actual framerate during encoder reconfiguration. 2014-01-10 12:01:51 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: improve codec reconfiguration. Improve codec reconfiguration to be performed only through a single function. That is, remove the _set_context_info() hook as subclass should not alter the parent GstVaapiContextInfo itself. Besides, the VA context is constructed only at the final stages of reconfigure(). 2014-01-10 11:30:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodedbufferpool.c: * gst-libs/gst/vaapi/gstvaapicodedbufferpool.h: * gst-libs/gst/vaapi/gstvaapiencoder.c: encoder: fix possible memory leak of coded buffer pools. Fix gst_vaapi_encoder_reconfigure_internal() to re-/allocate the coded buffer pool only if the coded buffer size actually changed. 2014-01-10 10:54:22 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: encoder: add video codec-state API. Add interface to communicate the encoder resolution and related info like framerate, interlaced vs. progressive, etc. This new interface supersedes gst_vaapi_encoder_set_format() and doesn't use any GstCaps but rather use GstVideoCodecState. Note that gst_vaapi_encoder_set_codec_state() is also a synchronization point for codec config. This means that the encoder is reconfigured there to match the latest properties. 2014-01-13 17:18:42 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: don't crash on NULL encoder on _finish(). Don't try to destroy an encoder, in GstVideoEncoder::finish() handler, if it was not created in the first place. Return "not-negotiated" error since this means we did not even reach GstVideoEncoder::set_format(), where the encoder could have been created. This fixes a crash when the vaapiencode_* plug-in elements get deallocated and that we failed to negotiate either pad. https://bugzilla.gnome.org/show_bug.cgi?id=719704 2014-01-09 18:20:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: vaapiencode: use more GstVaapiPluginBase facilities. Avoid duplication of pad references or query functions since they are provided through the GstVaapiPluginBase object. 2014-01-09 18:10:35 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: fix negotiation process of output caps. The specified caps in gst_video_encoder_set_output_state() function arguments should not contain any resolution, pixel-aspect-ratio, framerate, codec-data et al. Those rather should be set through the returned GstVideoCodecState. This means that output caps creation could be delayed until before gst_video_encoder_finish_frame() is called. This greatly simplifies the GstVideoEncoder::set_format() callback by the way. 2014-01-08 18:56:23 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: make GstVaapiEncode an abstract type. Make base GstVaapiEncode class an abstract type so that we cannot create an instance from it without going through any of the codec specific derived class. 2014-01-09 10:09:38 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: rename a few member functions. Rename a few member functions to make them more consistent: - alloc_encoder(): now reduced to allocate the encoder object only; - alloc_buffer(): allocate buffer from srcpad, and copy bitstream. 2014-01-08 18:36:46 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: update for new properties API. Update MPEG-2 and H.264 encode elements to cope with the new core libgstvaapi properties API. i.e. all configurable properties are now directly handled at the GstVaapiEncoder level. Besides, this also makes sure to not use or modify the GstVaapiEncoder private definitions directly. Private data need to remain private. https://bugzilla.gnome.org/show_bug.cgi?id=719529 2014-01-06 17:46:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: add properties API. Add interface to communicate configurable properties to the encoder. This covers both the common ones (rate-control, bitrate), and the codec specific properties. https://bugzilla.gnome.org/show_bug.cgi?id=719529 2014-01-06 18:01:33 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: encoder: add bitrate API. Add gst_vaapi_encoder_set_bitrate() interface to allow the user control the bitrate for encoding. Currently, changing this parameter is only valid before the first frame is encoded. Should the value be modified afterwards, then GST_VAAPI_ENCODER_STATUS_ERROR_OPERATION_FAILED is returned. https://bugzilla.gnome.org/show_bug.cgi?id=719529 2014-01-06 15:10:36 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: encoder: add rate control API. Add gst_vaapi_encoder_set_rate_control() interface to request a new rate control mode for encoding. Changing the rate control mode is only valid prior to encoding the very first frame. Afterwards, an error ("operation-failed") is issued. https://bugzilla.gnome.org/show_bug.cgi?id=719529 2014-01-03 16:57:25 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: fix indentation. 2014-01-03 16:57:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst/vaapi/gstvaapiencode.h: encoder: fix indentation. 2014-01-13 16:20:06 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiutils_mpeg2_priv.h: utils: add new MPEG-2 helper functions. Add various helper functions to convert profile, level, chroma formats from gstreamer-vaapi world and the MPEG-2 specification world. 2014-01-10 19:49:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_h264.c: utils: h264: don't use fatal asserts. Replace g_assert() with a g_debug() so that to not make the program abort when an unsupported value is supplied. 2014-01-10 19:37:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: utils: h264: add helpers for profile and level string mappings. Add profile and level helper functions to convert to/from strings. 2014-01-10 18:27:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: * gst-libs/gst/vaapi/gstvaapiutils_h264_priv.h: utils: h264: expose levels in public header. Instal header but only expose the H.264 levels in there. The additional helper functions are meant to be private for now. 2014-01-09 09:27:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: codec: add helper macros to maintain object refcount. Add gst_vaapi_mini_object_{ref,unref,replace}() helper macros so that to avoid explicit casts to GstVaapiMiniObject in all caller sites. 2014-01-09 09:30:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: codec: re-indent decoder objects. 2014-01-09 09:10:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: codec: re-indent base codec objects. 2014-01-03 12:49:05 +0000 Matthieu Bouron * gst/vaapi/gstvaapipluginbase.c: plugins: do not free debug category in finalize method. Fixes a crash when multiple vaapidecode elements are finalized since the debug category is created once in the class init method. This is a regression from git commit 7e58d60. https://bugzilla.gnome.org/show_bug.cgi?id=721390 Signed-off-by: Gwenole Beauchesne 2014-01-02 11:35:30 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * tests/simple-decoder.c: tests: simple-decoder: don't use deprecated g_thread_create(). Use g_thread_try_new() instead of the deprecated g_thread_create() function. Provide compatibility glue for any GLib version < 2.31.2. 2014-01-02 11:17:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst/vaapi/gstvaapiencode.c: Fix printf()-like formats. Fix formts for various GST_DEBUG et al. invocations. More precisely, make size_t arguments use the %zu format specifier accordingly; force XID formats to be a 32-bit unsigned integer; and fix the format used for gst_vaapi_create_surface_with_format() error cases since we have been using strings nowadays. 2013-12-21 07:38:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: utils: format: drop unused helper functions. The following helper functions are no longer used, thus are removed: - gst_vaapi_video_format_from_structure() - gst_vaapi_video_format_from_caps() - gst_vaapi_video_format_to_caps() 2013-12-21 07:29:50 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: utils: re-indent GstVideoFormat related helpers. 2013-12-21 08:27:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidownload.c: download: use GstVideoInfo facilities to build output caps. Use standard GstVideoInfo related functions to build the output caps, thus directly preserving additional fields as needed, instead of manually copying them over through gst_vaapi_append_surface_caps(). Also ensure that the input caps are fixated first. 2013-12-21 10:41:22 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapiuploader.c: plugins: factor out construction of template caps. Add new helper functions to build video template caps. - gst_vaapi_video_format_new_template_caps(): create GstCaps with size, frame rate and PAR to full range - gst_vaapi_video_format_new_template_caps_from_list(): try to create a "simplified" list from the supplied formats 2013-12-21 06:41:34 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: plugins: factor out construction of GValue from GstVideoFormat. Add new helper functions to build GValues from GstVideoFormat: - gst_vaapi_value_set_format(): build a GValue from the supplied video format - gst_vaapi_value_set_format_list(): build a GValue list from the supplied array of video formats 2013-12-21 06:22:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: plugins: re-indent common and video context creation utils. 2013-12-20 15:31:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst/vaapi/gstvaapidecode.c: * tests/test-display.c: display: don't use GstCaps for decode or encode profiles list. Replace gst_vaapi_display_get_{decode,encode}_caps() APIs with more more convenient APIs that return an array of GstVaapiProfile instead of GstCaps: gst_vaapi_display_get_{decode,encode}_profiles(). 2013-12-20 15:15:05 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiuploader.c: * tests/test-display.c: display: don't use GstCaps for image or subpicture formats list. Replace gst_vaapi_display_get_{image,subpicture}_caps() APIs, that returned GstCaps, with more convenient APIs that return an array of GstVideoFormat: gst_vaapi_display_get_{image,subpicture}_formats(). 2013-12-20 14:01:45 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: display: allocate queried resources on-demand. Allocate the set of decoders or encoders on-demand, when they are queried. Likewise for VA display attributes, image and subpicture formats. 2013-12-20 13:27:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: re-indent all GstVaapiDisplay related source code. 2013-12-20 16:04:19 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: utils: add helper functions to get codec or profile name. 2013-12-20 17:08:23 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapiuploader.c: plugins: fix permissions for certain files. Drop the execute bit for gstvaapiuploader.c and gstvaapipostproc.[ch] files. 2013-12-12 17:01:29 +0000 Matthieu Bouron * gst/vaapi/gstvaapivideometa_texture.c: plugins: implement GLTextureUploadMeta user data copy. Makes the copies of a buffer reference their own GLTextureUploadMeta user data and prevent the original buffer accessing already freed memory if its copies has been released and freed. https://bugzilla.gnome.org/show_bug.cgi?id=720336 [Propagate the original meta texture to the copy too] Signed-off-by: Gwenole Beauchesne 2013-12-17 18:52:23 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: plugins: factor out support for raw YUV buffers on sink pads. Factor out propose_allocation() hooks, creation of video buffer pool for the sink pad, conversion from raw YUV buffers to VA surface backed buffers. Update vaapidecode, vaapiencode and vaapipostproc to cope with the new GstVaapiPluginBase abilities. 2013-12-17 18:46:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: factor out pad caps. 2013-12-13 16:03:08 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: factor out video context sharing code. 2013-12-13 13:24:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: factor out GstImplementsInterface. 2013-12-13 12:00:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginutil.c: plugins: check type of display obtained from neighbours. Fix display creation code to check that any display obtained from a neighbour actually has the type we expect. Note: if display type is set to "any", we can then accept any VA display type. 2013-12-13 11:52:47 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.c: plugins: factor out display creation process. Move common VA display creation code to GstVaapiPluginBase, with the default display type remaining "any". Also add a "display-changed" hook so that subclasses could perform additional tasks when/if the VA display changed, due to a new display type request for instance. All plug-ins are updated to cope with the new internal APIs. 2013-12-13 10:24:26 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapipluginbase.c: * gst/vaapi/gstvaapipluginbase.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: plugins: add new base object, store display in there. Introduce a new GstVaapiPluginBase object that will contain all common data structures and perform all common tasks. First step is to have a single place to hold VA displays. While we are at it, also make sure to store and subsequently release the appropriate debug category for the subclasses. 2013-12-11 14:04:27 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: plugins: fix GLTextureUploadMeta to work with different texture ids. The GLTextureUploadMeta implementation assumed that for each upload() sequence, the supplied texture id is always the same as the one that was previously cached into the underlying GstVaapiTexture. Cope with any texture id change the expense to recreate the underlying VA/GLX resources. https://bugzilla.gnome.org/show_bug.cgi?id=719643 2013-12-11 13:25:51 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideometa_texture.c: plugins: allow builds without GLX enabled for GStreamer 1.2. Don't try to build GLTextureUploadMeta related code if GLX is not enabled during GStreamer >= 1.2 builds. 2013-11-20 17:20:07 +0000 Matthieu Bouron * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: plugins: request GLTextureUpload meta on buffers in the buffer pool. Requesting the GLTextureUpload meta on buffers in the bufferpool prevents such metas from being de-allocated when buffers are released in the sink. This is particulary useful in terms of performance when using the GLTextureUploadMeta API since the GstVaapiTexture associated with the target texture is stored in the meta. https://bugzilla.gnome.org/show_bug.cgi?id=712558 Signed-off-by: Gwenole Beauchesne 2013-12-11 10:51:03 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa_texture.c: plugins: robustify GstVideoGLTextureUploadMeta implementation. Make GstVideoGLTextureUploadMeta::upload() implementation more robust when the GstVaapiTexture associated with the supplied texture id could not be created. 2013-12-10 16:14:27 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: improve robustness when packets are missing. Improve robustness when some expected packets where not received yet or that were not correctly decoded. For example, don't try to decode a picture if there was no valid frame headers parsed so far. https://bugs.freedesktop.org/show_bug.cgi?id=57902 2013-12-10 14:20:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix decoding of BA3_SVA_C.264. Conformance test Base_Ext_Main_profiles/BA3_SVA_C.264 complys with extended profile specifications. However, the SPS header has the constraint_set1_flag syntax element set to 1. This means that, if a Main profile compliant decoder is available, then it should be able to decode this stream. This changes makes it possible to fall-back from Extended profile to Main profile if constraint_set1_flag is set to 1. https://bugzilla.gnome.org/show_bug.cgi?id=720190 2013-12-10 11:13:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: utils: h264: add more profiles. Add extended profile (A.2.3), high 4:2:2 profile (A.2.6), high 4:2:2 profiles (A.2.7, A.2.10), scalable profiles (G.10.1.1, G.10.1.2) and multiview profiles (H.10.1.1, H.10.1.2). Document "Constrained Baseline" and "High 10" profiles. 2013-12-10 15:21:51 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit e7d0e18. e7d0e18 h264: complete set of NAL unit types 2013-12-06 15:08:26 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: decoder: h264: add support for constrained baseline profile. Recognize streams marked as conforming to the "Constrained Baseline Profile". If VA driver supports that as is, fine. Otherwise, fallback to baseline, main or high profile. Constrained Baseline Profile conveys coding tools that are common to baseline profile and main profile. https://bugzilla.gnome.org/show_bug.cgi?id=719947 [Added fallbacks to main and high profiles] Signed-off-by: Gwenole Beauchesne 2013-12-09 12:46:45 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: decoder: h264: fix decoding of scaling lists. The GStreamer codecparser layer now parses the scaling lists in zigzag scan order, as expected, so that to match the original bitstream layout and specification. However, further convert the scaling lists into raster scan order to fit the existing practice in most VA drivers. https://bugzilla.gnome.org/show_bug.cgi?id=706406 2013-12-09 12:07:28 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 177c73b. a7e3255 add H.265 (HEVC) bitstream parser 177c73b h264: fix picture level scaling lists derivation (rule B) 14733f1 h264: fix parsing of VCL HRD parameters 59a0b47 h264: store quantization matrices in zig-zag order ffb6e26 h264: add helpers to convert quantization matrices c78a504 mpeg2: also initialize debug category in parse_sequence_header() 719d1b0 mpeg2: turn internal consistency check into a g_assert() 5241d8e all: remove some unused functions 18eb312 all: fix for GST_DISABLE_GST_DEBUG 963c04a all: make warnings more meaningful 2013-12-06 19:05:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: * gst-libs/gst/vaapi/gstvaapiutils_h264.h: utils: add helpers for H.264 levels. - gst_vaapi_utils_h264_get_level(): Returns GstVaapiLevelH264 from H.264 level_idc value - gst_vaapi_utils_h264_get_level_idc(): Returns H.264 level_idc value from GstVaapiLevelH264 - gst_vaapi_utils_h264_get_level_limits(): Returns level limits as specified in Table A-1 of the H.264 standard - gst_vaapi_utils_h264_get_level_limits_table(): Returns the Table A-1 specification 2013-12-06 17:34:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapiutils_h264.c: utils: add new H.264 profiles. Add "Constrained Baseline Profile" and "High 10 Profile" definitions and helper functiions. 2013-12-06 17:21:52 +0100 Gwenole Beauchesne utils: add new H.264 helper functions. * Profiles: - gst_vaapi_utils_h264_get_profile(): Returns GstVaapiProfile from H.264 profile_idc value - gst_vaapi_utils_h264_get_profile_idc(): Returns H.264 profile_idc value from GstVaapiProfile * Chroma formats: - gst_vaapi_utils_h264_get_chroma_type(): Returns GstVaapiChromaType from H.264 chroma_format_idc value - gst_vaapi_utils_h264_get_chroma_format_idc(): Returns H.264 chroma_format_idc value from GstVaapiChromaType 2013-12-03 11:05:17 +0000 Matthieu Bouron * gst-libs/gst/base/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: Fix missing files in distribution tarball. https://bugzilla.gnome.org/show_bug.cgi?id=719776 [Additional fixes and clean-ups] Signed-off-by: Gwenole Beauchesne 2013-12-05 18:13:54 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: fix computation of max coded buffer size (again). The previous fix was only valid to express the maximum size of the macroblock layer, i.e. without any headers. Now, also account for the slice headers and top picture header, but also any other header we might stuff into the VA coded buffer, e.g. sequence headers. 2013-12-04 19:10:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: fix computation of max coded buffer size. Fix coded buffer size for each codec. A generic issue was that the number of macroblocks was incorrectly computed. The second issue was specific to MPEG-2 were the max number of bits per macroblock, and as defined by the standard, was incorrectly mapped to the (lower) H.264 requirement. i.e. 4608 bits vs. 3200 bits limit. 2013-12-04 18:48:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: simplify VA context initialization process. Change get_context_info() into a set_context_info() function that initializes common defaults into the base class, thus allowing the subclasses to specialize the context info further on. The set_context_info() hook is also the location where additional context specific data could be initialized. At this point, we are guaranteed to have valid video resolution size and framerate. i.e. gst_vaapi_encoder_set_format() was called beforehand. 2013-11-26 14:38:23 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: encoder: fix mpeg2 compilation error. https://bugzilla.gnome.org/show_bug.cgi?id=719746 Signed-off-by: Gwenole Beauchesne 2013-12-04 17:55:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: * gst/vaapi/gstvaapiencode.c: encoder: clean-ups and document public APIs. Clean public APIs up so that to better align with the decoder APIs. Most importantly, gst_vaapi_encoder_get_buffer() is changed to only return the VA coded buffer proxy. Also provide useful documentation for the public APIs. 2013-12-04 17:05:17 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: avoid extra allocations of GstVaapiEncoderSyncPic objects. Kill GstVaapiEncoderSyncPic objects that are internally and temporarily allocated. Rather, associate a GstVaapiEncPicture to a coded buffer through GstVaapiCodedBufferProxy user-data facility. Besides, use a GAsyncQueue to maintain a thread-safe queue object of coded buffers. Partial fix for the following report: https://bugzilla.gnome.org/show_bug.cgi?id=719530 2013-12-03 17:04:43 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst/vaapi/gstvaapiencode.c: encoder: refactor status codes. Drop obsolete or unused status codes. Align some status codes with the decoder counterparts. 2013-12-04 11:54:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: encoder: fix subclassing process. Fix the GstVaapiEncoderClass parent class type. Make sure to validate subclass hooks as early as possible, i.e. in gst_vaapi_encoder_init(), thus avoiding useless run-time checks. Also simplify the subclass initialization process to be less error prone. 2013-12-03 16:11:46 +0100 Gwenole Beauchesne encoder: rework GstVaapiCodedBuffer and related proxy. Refactor the GstVaapiCodedBuffer APIs so that to more clearly separate public and private interfaces. Besides, the map/unmap APIs should not be exposed as is but appropriate accessors should be provided instead. * GstVaapiCodedBuffer: VA coded buffer abstraction - gst_vaapi_coded_buffer_get_size(): get coded buffer size. - gst_vaapi_coded_buffer_copy_into(): copy coded buffer into GstBuffer * GstVaapiCodedBufferPool: pool of VA coded buffer objects - gst_vaapi_coded_buffer_pool_new(): create a pool of coded buffers of the specified max size, and bound to the supplied encoder * GstVaapiCodedBufferProxy: pool-allocated VA coded buffer object proxy - gst_vaapi_coded_buffer_proxy_new_from_pool(): create coded buf from pool - gst_vaapi_coded_buffer_proxy_get_buffer(): get underlying coded buffer - gst_vaapi_coded_buffer_proxy_get_buffer_size(): get coded buffer size Rationale: more optimized transfer functions might be provided in the future, thus rendering the map/unmap mechanism obsolete or sub-optimal. https://bugzilla.gnome.org/show_bug.cgi?id=719775 2013-11-29 14:02:52 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: plugins: fix reference leaks of VA display objects. Fix GstElement::set_context() implementation for all plug-in elements to avoid leaking an extra reference to the VA display, thus preventing correct cleanup of VA resources in GStreamer 1.2 builds. 2013-11-29 13:56:12 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: plugins: simplify gst_vaapi_ensure_display(). Return earlier if the creation of a VA display failed. Likewise, simplify gst_vaapi_video_context_propagate() now that we are guaranteed to have a valid VA display. 2013-11-28 19:08:28 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: fix memory leaks through GstVideoMeta maps. When GstVideoMeta maps were used, the supporting functions incorrectly used gst_buffer_get_memory() instead of gst_buffer_peek_memory(), thus always increasing the associated GstMemory reference count and giving zero chance to actually release that, and subsequently the VA display. 2013-11-28 14:15:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiuploader.c: plugins: use G_PARAM_STATIC_STRINGS. This avoids a few string copies during initialization. 2013-11-28 17:28:11 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa.c: plugins: simplify VA video meta to only reference surface proxies. Simplify GstVaapiVideoMeta to only hold a surface proxy, which is now allocated from a surface pool. This also means that the local reference to the VA surface is also gone, as it could be extracted from the associated surface proxy. 2013-11-28 16:51:37 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: plugins: drop obsolete functions. Drop the following functions that are not longer used: - gst_vaapi_video_buffer_new_with_surface() - gst_vaapi_video_meta_new_with_surface() - gst_vaapi_video_meta_set_surface() - gst_vaapi_video_meta_set_surface_from_pool() 2013-11-28 16:37:31 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa.c: plugins: allow VA video meta to be allocated from surface proxy pools. Fix gst_vaapi_video_meta_new_from_pool() to allocate VA surface proxies from surface pools instead of plain VA surfaces. This is to simplify allocations now that surface proxies are created from a surface pool. 2013-11-28 17:25:05 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: surfaceproxy: add copy function. Add gst_vaapi_surface_proxy_copy() function that creates a new surface proxy with the same information from the parent proxy, except that the user-defined destroy notify function is not copied over. The underlying VA surface is pushed back to the video pool only when the last reference to the parent surface proxy is released. 2013-11-28 15:56:53 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst/vaapi/gstvaapiencode.c: vaapiencode: optimize _handle_frame() to avoid extra allocation. Optimize gst_vaapiencode_handle_frame() to avoid extra memory allocation, and in particular the GstVaapiEncObjUserData object. i.e. directly use the VA surface proxy from the source buffer. This also makes the user data attached to the GstVideoCodecFrame more consistent between both the decoder and encoder plug-in elements. 2013-11-28 15:14:43 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: fix memory leaks in _push_frame() on error. Simplify gst_vaapiencode_push_frame(), while also removing the call to gst_video_encoder_negotiate() since this is implicit in _finish() if caps changed. Also fixed memory leaks that occured on error. 2013-11-28 13:57:54 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: additional clean-ups. Constify pointers wherever possible. Drop unused variables, and use consistent variable names. Fix gst_vaapiencode_h264_allocate_buffer() to correctly report errors, especially when in-place conversion from bytestream to avcC format failed. 2013-11-28 13:26:40 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: vaapiencode: move common properties to base class. Move "rate-control" mode and "bitrate" properties to the GstVaapiEncode base class. The actual range of supported rate control modes is currently implemented as a plug-in element hook. This ought to be determined from the GstVaapiEncoder object instead, i.e. from libgstvaapi. 2013-11-28 10:54:36 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: fix plugin description and debug name. Align the plug-in debug category to its actual name. i.e. enable debug logs through vaapiencode_ where is mpeg2, h264, etc. Fix the plug-in element description to make it more consistent with other VA-API plug-ins. 2013-11-27 16:27:31 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/video/Makefile.am: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: add initial support for GStreamer 0.10. 2013-11-27 16:25:59 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: libs: add more GstBuffer compat glue for GStreamer 0.10. Add gst_buffer_new_allocate() and gst_buffer_fill() implementations. Fix gst_buffer_new_wrapped_full() implementation to handle the destroy notify function. 2013-11-27 15:56:51 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/video/Makefile.am: libs: always use built-in videoutils for GStreamer 0.10. GStreamer 0.10.36 is the latest and ultimate version to be released from the GStreamer 0.10 branch. i.e. no further releases are to be made. So, we can safely enable the built-in videoutils replacement now that they are in sync with the 0.10 branch. 2013-11-27 15:47:38 +0100 Gwenole Beauchesne * ext/videoutils: videoutils: update to master commit d4a15a5. d4a15a5 video: fix compiler warning in header with C++11 / clang-3.1 86096cc videodecoder: minor cosmetic changes to align a bit more with master b4b8b52 videodecoder: allow parse function to not use all data on adapter 2145495 videodecoder: warn if frame list gets long 36c3753 videodecoder: Also use the object lock to protect the output_state 518c93d videodecoder: fix seeking again 185fb63 video: Correct usage of the base class stream lock 170e944 videodecoder: Expose _negotiate function 2013-11-26 12:06:07 +0000 Matthieu Bouron * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * tests/Makefile.am: Fix build with GStreamer >= 1.3. http://bugzilla.gnome.org/show_bug.cgi?id=715183 Signed-off-by: Gwenole Beauchesne 2013-11-26 17:56:59 +0100 Gwenole Beauchesne * configure.ac: configure: disable encoders with GStreamer 0.10. Don't try to build video encoders for GStreamer 0.10. Support code is not there yet, and probably will never for such an ancient version. 2013-11-26 17:26:44 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: fix error handling while allocating output buffers. Fix default GstVideoEncoder::allocate_buffer() implementation to properly unmap the coded buffer prior to returning an error. 2013-11-26 17:11:22 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: fix error handling in _finish() hook. Fix GstVideoEncoder::finish() implementation to really return possible errors instead of GST_FLOW_OK. That is, fix check for timeout status. 2013-11-26 16:34:14 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: vaapiencode: minor clean-ups. Add a GST_VAAPIENCODE_CAST() helper to avoid run-time checks against the GObject type system. We are guaranteed to only deal with the same plug-in element object. 2013-11-26 15:31:03 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: fix support for raw YUV sink buffers. Allow vaapiencode plug-in elements to encode from raw YUV buffers. The most efficient way to do so is to let the vaapiencode elements allocate a buffer pool, and subsequently buffers from it. This means that upstream elements are expected to honour downstream pools. If upstream elements insist on providing their own allocated buffers to the vaapiencode elements, then it possibly would be more efficient to insert a vaapipostproc element before the vaapiencode element. This is because vaapipostproc currently has better support than other elements for "foreign" raw YUV buffers. 2013-11-26 15:12:59 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiencode.c: vaapiencode: fix support for GStreamer 1.2. 2013-11-07 17:42:21 +0800 Wind Yuan * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_mpeg2.c: vaapiencode: initial port to GStreamer 1.2. Signed-off-by: Gwenole Beauchesne 2013-11-20 16:21:32 +0800 XuGuangxin * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_mpeg2.c: * gst/vaapi/gstvaapiencode_mpeg2.h: plugins: add mpeg2 encoder element. Add GstVaapiEncodeMPEG2 element object. The actual plug-in element is called "vaapiencode_mpeg2". Valid properties: - rate-control: rate control mode (default: cqp - constant QP) - bitrate: desired bitrate in kbps (default: auto-calculated) - key-period: maximal distance between two key frames (default: 30) - max-bframes: number of B-frames between I and P (default: 2) - quantizer: constant quantizer (default: 8) Signed-off-by: Gwenole Beauchesne 2013-07-29 16:02:56 +0800 Wind Yuan * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiencode_h264.c: * gst/vaapi/gstvaapiencode_h264.h: plugins: add h264 encoder element. Add GstVaapiEncodeH264 element object. The actual plug-in element is called "vaapiencode_h264". Valid properties: - rate-control: rate control mode (default: none) - bitrate: desired bitrate in kbps (default: auto-calculated) - key-period: maximal distance between two key frames (default: 30) - num-slices: number of slices per frame (default: 1) - max-bframes: number of B-frames between I and P (default: 0) - min-qp: minimal quantizer (default: 1) - init-qp: initial quantizer (default: 26) Signed-off-by: Gwenole Beauchesne 2013-07-29 13:44:48 +0800 Wind Yuan * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapiencode.c: * gst/vaapi/gstvaapiencode.h: plugins: add base encoder element. vaapiencode element is based on GstVideoEncoder APIs. Signed-off-by: Gwenole Beauchesne 2013-11-20 16:20:15 +0800 XuGuangxin * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapiencoder_mpeg2_priv.h: encoder: add mpeg2 encoder. Add initial support for MPEG-2 encoding. I/P/B frames are supported. Signed-off-by: Gwenole Beauchesne 2013-07-29 15:46:11 +0800 Wind Yuan * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder_h264.c: * gst-libs/gst/vaapi/gstvaapiencoder_h264.h: * gst-libs/gst/vaapi/gstvaapiencoder_h264_priv.h: encoder: add h264 encoder. Signed-off-by: Gwenole Beauchesne 2013-07-29 13:34:06 +0800 Wind Yuan * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiencoder.c: * gst-libs/gst/vaapi/gstvaapiencoder.h: * gst-libs/gst/vaapi/gstvaapiencoder_objects.c: * gst-libs/gst/vaapi/gstvaapiencoder_objects.h: * gst-libs/gst/vaapi/gstvaapiencoder_priv.h: Add initial infrastructure for video encoding. Add initial API for video encoding: only basic interfaces and small encoder objects are implemented so far. Signed-off-by: Gwenole Beauchesne 2013-07-29 15:41:23 +0800 Wind Yuan * configure.ac: * gst-libs/gst/Makefile.am: * gst-libs/gst/base/Makefile.am: * gst-libs/gst/base/gstbitwriter.c: * gst-libs/gst/base/gstbitwriter.h: * gst-libs/gst/vaapi/Makefile.am: libs: add generic bitstream writer. GstBitWriter provides a bit writer that can write any number of bits to a pre-allocated memory buffer. Helper functions are also provided to write any number of bits from 8, 16, 32 and 64 bit variables. Signed-off-by: Gwenole Beauchesne 2013-07-12 22:07:59 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: libs: add support for rate-control to GstVaapiContext. Extend GstVaapiContextInfo structure to hold the desired rate control mode for encoding purposes. For decoding purposes, this field is not used and it is initialized to GST_VAAPI_RATECONTROL_NONE. Signed-off-by: Gwenole Beauchesne 2013-07-12 21:33:32 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: libs: add rate-control attributes. Add GstVaapiRateControl types and GType values in view to supporting rate controls for encoding. This is meant to be used for instance in GstVaapiContext. Signed-off-by: Gwenole Beauchesne 2013-11-22 11:56:51 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-11-22 11:28:09 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: build: fix for Wayland headers not in standard include dirs. Fix build when Wayland headers don't live in plain system include dirs like /usr/include but rather in /usr/include/wayland for instance. Original patch written by Dominique Leuenberger https://bugzilla.gnome.org/show_bug.cgi?id=712282 2013-11-14 10:58:37 +0000 Ross Burton * gst-libs/gst/vaapi/Makefile.am: build: link libgstvaapi-wayland against videoutils. This library is using symbols that don't exist in GStreamer 0.10 so it needs to link to built-in implementation (libgstvaapi-videoutils). https://bugzilla.gnome.org/show_bug.cgi?id=712282 Signed-off-by: Ross Burton Signed-off-by: Gwenole Beauchesne 2013-11-22 11:15:57 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: * gst/vaapi/gstvaapipostproc.c: vaapostproc: fix memory leaks. Destroy VPP output surface pool on exit. Also avoid a possible crash in double-free situation caused by insufficiently reference counted array of formats returned during initialization. 2013-11-22 10:19:06 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: fix and optimize advanced deinterlacing mode. Fix advanced deinterlacing modes with VPP to track only up to 2 past reference buffers. This used to be 3 past reference buffers but this doesn't fit with the existing decode pipeline that only has 4 extra scratch surfaces. Also optimize references tracking to be only enabled when needed, i.e. when advanced deinterlacing mode is used. This means that we don't need to track past references for basic bob or weave deinterlacing. 2013-11-22 10:04:45 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix "mixed" mode deinterlacing. In "mixed" interlaced streams, the buffer contains additional flags that specify whether the frame contained herein is interlaced or not. This means that we can alternatively get progressive or interlaced frames. Make sure to disable deinterlacing at the VPP level when the source buffer is no longer interlaced. 2013-11-22 09:49:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix memory leaks with advanced deinterlacing. Fix memory leaks with advanced deinterlacing, i.e. when we keep track of past buffers. Completely reset the deinterlace state, thus destroying any buffer currently held, on _start(), _stop() and _destroy(). 2013-11-22 06:59:51 +0100 Gwenole Beauchesne * README: README: updates. - GStreamer 1.2 APIs are supported ; - Video Processing (VA/VPP) features. 2013-11-22 06:45:22 +0100 Gwenole Beauchesne * README: README: update for GStreamer >= 1.0.x and VPP features. 2013-11-22 06:37:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapivideoconverter_glx.h: * tests/image.c: * tests/image.h: * tests/output.h: * tests/test-display.c: * tests/test-jpeg.c: * tests/test-jpeg.h: * tests/test-mpeg4.c: * tests/test-mpeg4.h: * tests/test-surfaces.c: * tests/test-windows.c: legal: update copyright notice dates. 2013-11-22 05:57:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimage_priv.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiparser_frame.c: * gst-libs/gst/vaapi/gstvaapiparser_frame.h: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapipixmap.h: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiworkarounds.h: * gst-libs/gst/vaapi/sysdeps.h: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapiuploader.h: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_glx.h: * gst/vaapi/gstvaapivideoconverter_x11.c: * gst/vaapi/gstvaapivideoconverter_x11.h: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: * tests/codec.c: * tests/codec.h: * tests/decoder.c: * tests/decoder.h: * tests/image.c: * tests/image.h: * tests/output.c: * tests/output.h: * tests/simple-decoder.c: * tests/test-decode.c: * tests/test-decode.h: * tests/test-display.c: * tests/test-filter.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-jpeg.c: * tests/test-jpeg.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-mpeg4.c: * tests/test-mpeg4.h: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-vc1.h: * tests/test-windows.c: legal: add per-file authorship information. Credit original authors on a per-file basis as we cannot expect people to know all country-specific rules, or bother browsing through the git history. 2013-11-21 23:52:43 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.7. 2013-11-21 23:51:59 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-11-21 23:17:59 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.h: decoder: don't include obsolete headers. The header was removed from the public set of APIs. So, don't make public headers (gstvaapidecoder.h) depend on private files. 2013-11-18 16:20:43 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add initial support for GStreamer 1.2. Port vaapipostproc element to GStreamer 1.2. Support is quite minimal right now so that to cope with auto-plugging issues/regressions. e.g. this happens when the correct set of expected caps are being exposed. This means that, currently, the proposed caps are not fully accurate. 2013-11-01 10:22:17 +0800 Halley Zhao * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add support for denoise and sharpen filters. Signed-off-by: Gwenole Beauchesne 2013-11-21 19:52:56 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add support for advanced deinterlacing. Add initial support for advanced deinterlacing. The history buffer size is arbitrarily set to 3 references for now. 2013-11-21 22:32:03 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix deinterlacing with VPP. Fix basic deinterlacing flags provided to gst_vaapi_set_deinterlacing() for the first field. Render flags were supplied instead of the actual deinterlacing flags (deint_flags). 2013-11-21 15:08:55 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix transform caps. Fix GstBaseTransform::transform_caps() implementation to always return the complete set of allowed sink pad caps (unfixated) even if the src pad caps we are getting are fixated. Rationale: there are just so many possible combinations, and it was wrong to provide a unique set anyway. As a side effect, this greatly simplifies the ability to derive src pad caps from fixated sink pad caps. 2013-11-01 10:31:13 +0800 Halley Zhao * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add helper to specify references for deinterlacing. Add gst_vaapi_fitler_set_deinterlacing_references() API to submit the list of surfaces used for forward or backward reference in advanced deinterlacing mode, e.g. Motion-Adaptive, Motion-Compensated. The list of surfaces used as deinterlacing references shall be live until the next call to gst_vaapi_filter_process(). Signed-off-by: Gwenole Beauchesne 2013-11-21 18:44:46 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst/vaapi/gstvaapipostproc.c: * tests/test-filter.c: filter: fix semantics of deinterlacing flags. Fix deinterlacing flags to make more sense. The TFF (top-field-first) flag is meant to specify the organization of reference frames used in advanced deinterlacing modes. Introduce the more explicit flag TOPFIELD to specify that the top-field of the supplied input surface is to be used for deinterlacing. Conversely, if not set, this means that the bottom field of the supplied input surface will be used instead. 2013-11-21 17:20:28 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add helpers to check for supported/active operation. Add a couple of helper functions: - gst_vaapi_filter_has_operation(): checks whether the VA driver advertises support for the supplied operation ; - gst_vaapi_filter_use_operation(): checks whether the supplied operation was already enabled to its non-default value. 2013-11-20 15:10:17 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: libs: fix GstVaapiSurfaceProxy destroy notify call site. The user-defined destroy notify function is meant to be called only when the surface proxy was fully released, i.e. once it actually released the VA surface back to the underlying pool. 2013-08-29 13:44:22 +0800 XuGuangxin * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: libs: make GstVaapiVideoPool thread-safe. https://bugzilla.gnome.org/show_bug.cgi?id=707108 Signed-off-by: Gwenole Beauchesne 2013-08-29 14:04:06 +0800 XuGuangxin * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: libs: robustify decoder objects and surface proxy initialization. Fix GstVaapiPicture, GstVaapiSlice and GstVaapiSurfaceProxy initialization sequences to have the expected default values set beforehand in case of an error raising up further during creation. i.e. make it possible to cleanly destroy those partially initialized objects. https://bugzilla.gnome.org/show_bug.cgi?id=707108 Signed-off-by: Gwenole Beauchesne 2013-11-21 11:01:41 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix decoder flush. There are situations where gst_video_decoder_flush() is called, and this subsequently produces a gst_video_decoder_reset() that kills the currently active GstVideoCodecFrame. This means that it no longer exists by the time we reach GstVideoDecoder::finish() callback, thus possibly resulting in a crash if we assumed spare data was still available for decode (current_frame_size > 0). Try to honour GstVideoDecoder::reset() behaviour from GStreamer 1.0 that means a flush, thus performing the actual operations there like calling gst_video_decoder_have_frame() if pending data is available. 2013-11-20 19:21:05 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: fix dead-locks with decoder task. Review all interactions between the main video decoder stream thread and the decode task to derive a correct sequence of operations for decoding. Also avoid extra atomic operations that become implicit under the GstVideoDecoder stream lock. 2013-08-29 14:12:10 +0800 XuGuangxin * gst/vaapi/gstvaapidecode.c: vaapidecode: fix hard reset for seek cases. Fix hard reset for seek cases by flushing the GstVaapiDecoder queue and completely purge any decoded output frame that may come out from it. At this stage, the GstVaapiDecoder shall be in a complete clean state to start decoding over new buffers. Signed-off-by: Gwenole Beauchesne 2013-08-29 14:12:10 +0800 XuGuangxin * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: drop decode timeout, always wait for a free surface. vaapidecode used to wait up to one second past the expected time of presentation for the last decoded frame. This is not realistic in practice when it comes to video pause/resume. Changed behaviour to unconditionnally wait for a free VA surface prior to continuing the decoding. The decode task will continue pushing the output frames to the downstream element while also reporting errors at the same time to the main thread. https://bugzilla.gnome.org/show_bug.cgi?id=707108 Signed-off-by: Gwenole Beauchesne 2013-11-20 10:56:28 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix srcpad caps for GStreamer 1.2. The srcpad caps exposed for GStreamer 1.2 were missing any useful info like framerate, pixel-aspect-ratio, interlace-mode et al. Not to mention that it relied on possibly un-initialized data. Fix srcpad caps to be initialized from a sanitized copy of GstVideoDecoder output state caps. Note: the correct way to expose the srcpad caps triggers an additional issue in core GStreamer auto-plugging capabilities as the correct caps to be exposed should be format=ENCODED with memory:VASurface caps feature at the minimum. In some situations, we could determine the underlying VA surface format, but this is not always possible. e.g. cases where it is not allowed to expose the underlying VA surface data, or when the VA driver implementation cannot actually provide such information. 2013-11-20 10:45:23 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: plugins: streamline VA formats exposed in caps to a realistic set. Currently, the decoder only supports YUV 4:2:0 output. So, expose the output formats for GStreamer 1.2 in caps to a realistic subset. This means NV12, I420 or YV12 but also ENCODED if we cannot determine the underlying VA surface format, or if it is actually not allowed to get access to the surface contents. 2013-11-20 10:37:36 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: plugins: expose the expected format for GstVideoGLTextureUploadMeta. Fix vaapidecode srcpad caps to only expose RGBA video format for the meta:GstVideoGLTextureUploadMeta feature. That's only what is supported so far. Besides, drop this meta from the vaapisink sinkpad caps since we really don't support that for rendering. https://bugzilla.gnome.org/show_bug.cgi?id=711828 2013-11-18 18:25:21 +0100 Gwenole Beauchesne * configure.ac: configure: automatically detect GStreamer API version. Automatically detect GStreamer API version. The --with-gstreamer-api configure option now defaults to "autodetect" and configure then tries to derive the GStreamer API version from the highest version based on what pkg-config --modversion would report. https://bugzilla.gnome.org/show_bug.cgi?id=711657 2013-11-01 13:43:11 +0800 Wind Yuan * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix support for raw YUV data upload on GStreamer 1.0. Fix raw YUV data uploaded as in the following pipeline: $ gst-launch-1.0 filesrc video.yuv ! videoparse ! vaapipostproc ! vaapisink The main reason why it failed was that the videoparse element simply allocates GstBuffer with raw data chunk'ed off the sink pad without any prior knowledge of the actual frame info. i.e. it basically just calls gst_adapter_take_buffer(). We could avoid the extra copy performed in vaapipostproc if the videoparse element was aware of the downstream pool and bothers copying line by line, for each plane. This means that, for a single frame per buffer, the optimizatin will be to allocate the video buffer downstream, map it, and copy each line that is coming through until we need to fills in the successive planes. Still, optimized raw YUV uploads already worked with the following: $ gst-launch-1.0 videotestsrc ! vaapipostproc ! vaapisink https://bugzilla.gnome.org/show_bug.cgi?id=711250 [clean-ups, fixed error cases to unmap and unref outbuf] Signed-off-by: Gwenole Beauchesne 2013-11-16 07:02:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: try to downgrade deinterlace-method when needed. If the currently selected deinterlacing method is not supported by the underlying hardware, then try to downgrade the method to a supported one. At the minimum, basic bob-deinterlacing shall always be supported. 2013-11-15 19:04:07 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add initial support for deinterlacing with VPP. Allow basic bob-deinterlacing to work when VPP is enabled. Currently, this only covers bob-deinterlacing when the output pixel format is explicitly set. 2013-11-15 17:14:04 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix build on 64-bit platforms with GStreamer 0.10. The size argument for GstBaseTransform::transform_size() hook is a guint in GStreamer 0.10 APIs but a gsize in GStreamer >= 1.0.X APIs. 2013-10-18 18:08:25 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add initial support for scaling. Add initial support for basic scaling with size specified through the "width" and "height" properties. If either user-provided dimension is zero and "force-aspect-ratio" is set to true (the default), then the other dimension is scaled to preserve the aspect ratio. 2013-10-18 18:08:25 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add initial support for color conversion. If VPP is available, we always try to implicitly convert the source buffer to the "native" surface format for the underlying accelerator. This means that no optimization is performed yet to propagate raw YUV buffers to the downstream element as is, if VPP is available. i.e. it will always cause a color conversion. 2013-10-16 11:23:03 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix bug when user disabled deinterlacing. Fix pipeline error / hang when the user disabled deinterlacing through the deinterlace-mode=disabled property setting. 2013-10-16 11:20:50 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: factor out operations to be applied into flags. Even if we only support deinterlacing for now, use flags to specify which filters are to be applied to each frame we receive in transform(). This is preparatory work for integrating new filters. 2013-10-04 15:37:24 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add support for raw YUV video source buffers. Allow video processing from raw YUV buffers coming from the sink pad, while still producing a VA surface for the downstream elements. 2013-10-04 16:00:56 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: add support for "mixed" interlace mode. Add support for "mixed" interlace-mode, whereby the video frame buffer shall be deinterlaced only if its flags mention that's actually an interlaced frame buffer. 2013-10-03 19:04:07 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: vaapipostproc: rework plug-in element. Rewrite the vaapipostproc plug-in element so that it derives from GstBaseTransform, thus simplifying the caps negotiation process. 2013-10-09 17:25:10 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: fix and optimize check for buffer pool allocator params. Reset the buffer pool allocator only if the config caps changed in a sensible way: format or resolution change. i.e. don't bother with other caps like colorimetry et al. as this doesn't affect the way to allocate VA surfaces or images. 2013-10-09 10:33:55 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: enable memory maps for read & write with direct-rendering. Enable read and write mappings only if direct-rendering is supported. Otherwise, this means that we may need to download data from the VA surface first for correctness, even if the VA surface doesn't need to be read at all. i.e. sometimes, READWRITE mappings are meant for surfaces that are written to first, and read afterwards for further processing. https://bugzilla.gnome.org/show_bug.cgi?id=704078 2013-10-09 10:06:40 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: fix check for direct-rendering support. Fix check for direct-rendering if the creation of VA surfaces with an explicit pixel format is not support, e.g. VA-API < 0.34.0, and that we tried to allocate a VA surface based on the corresponding chroma type. i.e. in that particular case, we have to make sure that the derived image has actually the expected format. 2013-10-09 09:47:18 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: fix buffer pool reset_buffer() to reset memory resources. Fix GstVaapiVideoBufferPool::reset_buffer() to reset the underlying memory resources, and more particularly the VA surface proxy. Most importantly, the GstVaapiVideoMeta is retained. Cached surface in memory are released, thus triggering a new allocation the next time we need to map the buffer. 2013-10-09 09:33:56 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: fix GstVaapiVideoMemory to allocate VA surface proxies. Make sure GstVaapiVideoMemory allocates VA surface proxies from a pool stored in the parent VA memory allocator. This fixes the following scenario: - VA video buffer 1 is allocated from a buffer pool - Another video buffer is created, and inherits info from buffer 1 - Buffer 1 is released, thus pushing it back to the buffer pool - New buffer alloc request comes it, this yields buffer 1 back - At this stage, buffers 1 and 2 still share the same underlying VA surface, but buffer 2 was already submitted downstream for further processing, thus conflicting with additional processing we were about to perform on buffer 1. Maybe the core GstBufferPool implementation should have been fixed instead to actually make sure that the returned GstBuffer memory we found from the pool is writable? 2013-10-04 19:34:32 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: plugins: create a proxy for GstVaapiUploader allocated buffers. Always make sure to allocate a VA surface proxy for GstVaapiUploader allocated buffers, i.e. make gst_vaapi_uploader_get_buffer() allocate a proxy surface. This fixes cases where we want to retain the underlying surface longer, instead of releasing it back to the surface pool right away. 2013-10-04 19:30:36 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: plugins: add helper function to disable deinterlacing in caps. Add gst_caps_set_interlaced() helper function that would reset the interlace-mode field to "progressive" for GStreamer >= 1.0, or the interlaced field to "false" for GStreamer 0.10. 2013-10-01 18:26:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: filter: fix memory leak of VPP operations. Fix ensure_operations() to release the VPP operations array if non NULL, prior to returning to the caller. The former function was also renamed to a more meaningful get_operations() since the caller owns the returned array that needs to be released. 2013-09-04 13:53:25 +0800 Zhao Halley * gst-libs/gst/vaapi/gstvaapifilter.c: filter: fix first-time operation lookup. Fix first-time operation lookup through find_operation() if the set of supported operations was not initially determined through the gst_vaapi_filter_get_operations() helper function. Signed-off-by: Gwenole Beauchesne 2013-09-04 13:53:25 +0800 Zhao Halley * gst-libs/gst/vaapi/gstvaapifilter.c: filter: fix colorbalance related subtypes. Fix intiialization of GstVaapiFilterOpData for colorbalance related operations. In particular, fill in the va_subtype field accordingly. Signed-off-by: Gwenole Beauchesne 2013-09-30 17:08:12 +0200 Víctor Manuel Jáquez Leal * gst-libs/gst/vaapi/gstvaapifilter.c: filter: fix VA-API 0.34.0 symbol guards. VASurfaceAttrib and VAProcFilterParameterBufferType are symbols that need to be guarded for libva 0.34 and 0.33, respectively. https://bugzilla.gnome.org/show_bug.cgi?id=709102 Signed-off-by: Gwenole Beauchesne 2013-10-01 17:57:11 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: plugins: hanle the context query in any pad. Also this patch simplifies the code, since now the query is common for the decoder and the sink. https://bugzilla.gnome.org/show_bug.cgi?id=709200 2013-10-01 12:09:44 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapivideocontext.c: plugins: query upstream element for a GstContext. Fix gst_vaapi_video_context_prepare() to also query upstream elements for a valid GstContext. Improve comments regarding the steps used to lookup or build that context, thus conforming to the GstContext API recommendations. https://bugzilla.gnome.org/show_bug.cgi?id=709112 Signed-off-by: Gwenole Beauchesne 2013-09-26 15:21:24 +0200 Gwenole Beauchesne * configure.ac: * debian.upstream/control.in: Fix detection and packaging of GStreamer 1.2.x builds. The GStreamer 1.2.x packages sticked to the naming convention for 1.0.x packages, i.e. -1.0 suffix. However, for gstreamer-vaapi packaging purposes, update the versioning to -1.2 suffix instead. 2013-07-15 13:41:00 +0200 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideometa_texture.c: * gst/vaapi/gstvaapivideometa_texture.h: plugins: add support for GstVideoGLTextureUploadMeta. If the allocation meta GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE is requested, and more specifically under a GLX configuration, then add the GstVideoGLTextureUploadMeta to the output buffer. https://bugzilla.gnome.org/show_bug.cgi?id=703236 Signed-off-by: Gwenole Beauchesne 2013-07-04 11:03:52 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideomemory.h: plugins: add support for GstCaps features. Move VA video buffer memory from "video/x-surface,type=vaapi" format, as expressed in caps, to the more standard use of caps features. i.e. add "memory:VASurface" feature attribute to the associated caps. https://bugzilla.gnome.org/show_bug.cgi?id=703271 Signed-off-by: Gwenole Beauchesne 2013-07-12 12:58:57 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: plugins: improve ::query() debugging messages. Fix gst_vaapidecode_query() to correctly display the query type name, instead of randomly displaying that we shared the underlying display. Also add debug info for the GstVaapiSink::query() handler, i.e. the supplied query type name actually. Signed-off-by: Gwenole Beauchesne 2013-07-12 12:58:57 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: plugins: add support for GstContext API. Add support for the new GstContext API from GStreamer 1.2.x. - implement the GstElement::set_context() hook ; - reply to the `context' query from downstream elements. https://bugzilla.gnome.org/show_bug.cgi?id=703235 Signed-off-by: Gwenole Beauchesne 2013-05-22 12:07:52 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapivideocontext.c: * gst/vaapi/gstvaapivideocontext.h: plugins: add compat layer for GstVideoContext. Add thin compatibility layer for the deprecated GstVideoContext API. For GStreamer API >= 1.2, this involves the following two functions: - gst_vaapi_video_context_prepare(): queries if a context is already set in the pipeline ; - gst_vaapi_video_context_propagate(): propagates the newly-created context to the rest of the pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=703235 Signed-off-by: Gwenole Beauchesne 2013-05-21 12:42:39 -0400 Víctor Manuel Jáquez Leal * configure.ac: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideobuffer.c: plugins: initial port to GStreamer 1.2. Port vaapidecode and vaapisink plugins to GStreamer API >= 1.2. This is rather minimalistic so that to test the basic functionality. Disable vaapipostproc plugin for now as further polishing is needed. Also disable GstVideoContext interface support since this API is now gone in 1.2.x. This is preparatory work for GstContext support. https://bugzilla.gnome.org/show_bug.cgi?id=703235 Signed-off-by: Gwenole Beauchesne 2013-09-24 16:21:11 +0200 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: fix for non-X11 backends. Don't try to create pixmaps if we have not requested that feature. This fixes execution for non-X11 backends, and most specifically DRM video output mode. 2013-09-24 16:22:59 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit b33bd32. b33bd32 jpeg: fix and optimize scan for next marker code 2013-09-23 19:14:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: fix calculation of MCU count. Fix calculation of MCU count for image sizes that are not a multiple of 8 pixels in either dimension, but also for non-common sampling factors like 4:2:2 in non-interleaved mode. 2013-09-23 16:49:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: jpeg: add support for multiscan images. Add support for images with multiple scans per frame. The Huffman table can be updated before SOS, and thus possibly requiring multiple uploads of Huffman tables to the VA driver. So, the latter must be able to cope with multiple VA buffers of type 'huffman-table' and with the correct sequential order. 2013-09-23 11:41:52 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: improve robustness when packets are missing. Improve robustness when some expected packets where not received yet or that were not correctly decoded. For example, don't try to decode a picture if there was no valid frame headers. 2013-09-20 16:46:43 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: minor clean-ups. Improve debugging and error messages. Rename a few variables to fit the existing naming conventions. Change some fatal asserts to non-fatal error codes. 2013-09-20 10:12:08 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: jpeg: rework and optimize parser. Split the input buffer data into decoder units that represent a JPEG segment. Handle scan decoder unit specifically so that it can include both the scan header (SOS) but also any other ECS or RSTi segment. That way, we parse the input buffer stream only once at the gst-vaapi level instead of (i) in gst_vaapi_decoder_jpeg_parse() to split the stream into frames SOI .. EOI and (ii) in decode_buffer() to further determine segment boundaries and decode them. In practice, this is a +15 to +25% performance improvement. 2013-09-17 14:29:54 +0800 Junfeng Xu * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: handle comment segments. Fix decode_buffer() function to gracefully skip comment (COM) segments. This fixes decoding of streams generated by certain cameras, e.g. like the Logitech Pro C920. https://bugzilla.gnome.org/show_bug.cgi?id=708208 Signed-off-by: Junfeng Xu 2013-09-18 17:59:44 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: fix determination of image bounds. Look for the exact image bounds characterised by the and markers. Use the gst_jpeg_parse() codec parser utility function to optimize the lookup for the next marker segment. https://bugzilla.gnome.org/show_bug.cgi?id=707447 2013-09-10 15:46:09 +0800 Junfeng Xu * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: fix calculation of offset to next marker segment. Fix calculation of the offset to the next marker segment since the correction of the codecparser part to match the API specification. i.e. the GstJpegMarkerSegment.size field represents the size in bytes of the segment minus any marker prefix. https://bugzilla.gnome.org/show_bug.cgi?id=707447 Signed-off-by: Junfeng Xu 2013-09-20 18:30:18 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 23c7dde. 23c7dde jpeg: fix calculation of segment size 2013-08-31 16:00:05 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-08-31 15:47:33 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.6. 2013-08-31 15:46:25 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-08-15 17:59:37 +0800 Wind Yuan * configure.ac: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: configure: fix detection of VA/JPEG decoding API. Fix detection of VA/JPEG decoding API with non-standard libva packages. More precisely, some packages were shipping with a header that did not include . https://bugzilla.gnome.org/show_bug.cgi?id=706055 Signed-off-by: Gwenole Beauchesne 2013-04-18 19:49:42 +0800 Zhao Halley * gst/vaapi/gstvaapisink.c: vaapisink: ensure the uploader is setup for upstream allocated buffers. In GStreamer 0.10 builds, make sure that the GstVaapiUploader helper is setup in case upstream elements allocate buffers themselves without honouring our GstVaapiSink::bufer_alloc() hook. In particular, this fixes support for OGG video streams with WebKit. https://bugzilla.gnome.org/show_bug.cgi?id=703934 Signed-off-by: Gwenole Beauchesne 2013-08-29 19:07:34 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: simplify get_render_buffer() for GStreamer 0.10 builds. Implement and use gst_vaapisink_get_render_buffer() for GStreamer 0.10 builds as well. 2013-08-29 18:34:57 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: handle raw buffers not created from VA video buffer pool. Handle raw video buffers that were not created from a VA video buffer pool. Use the generic GstVideo API to copy buffers in GStreamer 1.0.x builds instead of the GstVaapiUploader. https://bugs.freedesktop.org/show_bug.cgi?id=55818 2013-08-29 19:33:02 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: remove extraneous size information from allowed caps. Fix _getcaps() implementation to not report codecs with size information filled in the returned caps. That's totally useless nowadays. Ideally, this is a hint to insert a video parser element, thus allowing future optimizations, but this is not a strict requirement for gstreamer-vaapi, which is able to parse the elementary bitstreams itself. https://bugzilla.gnome.org/show_bug.cgi?id=704734 2013-07-30 14:05:39 +0800 Guangxin.Xu * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: submit the last frame from output adapter to decoder. If there is no frame delimiter at the end of the stream, e.g. no end-of-stream or end-of-sequence marker, and that the current frame was fully parsed correctly, then assume that last frame is complete and submit it to the decoder. https://bugzilla.gnome.org/show_bug.cgi?id=705123 Signed-off-by: Guangxin.Xu Signed-off-by: Gwenole Beauchesne 2013-08-29 11:55:05 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: push all decoded frames from within the task. Make sure to push all decoded frames from the task so that the unlying VA surfaces could all be rendered from the same thread. 2013-08-27 18:24:12 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: render the raw surface if VPP failed. As a last resort, if video processing capabilities (VPP) are not available, or they did not produce anything conclusive enough, then try to fallback to the original rendering code path whereby the whole VA surface is rendered as is, no matter of video cropping or deinterlacing requests. Note: under those conditions, the visual outcome won't be correct but at least, something gets displayed instead of bailing out. 2013-08-27 18:20:08 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: add supporting for video processing. Try to use VA/VPP processing capabilities to handle video cropping and additional rendering flags that may not be directly supported by the underlying hardware when exposing a suitable Wayland buffer for the supplied VA surface. e.g. deinterlacing, different color primaries than BT.601, etc. 2013-08-27 16:26:22 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: add new frame redraw infrastructure. Update the frame redraw infrastructure with a new FrameState stucture holds all the necessary information used to display the next pending surface. While we are at it, delay the sync operation down to when it is actually needed. That way, we keep performing additional tasks meanwhile. 2013-08-27 18:06:10 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: allow specification of render target regions. Add support for rendering the source surface to a particular region within the supplied target surface. The default background color is black. 2013-08-26 17:14:33 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobuffer.c: decode: fix creation of GLX video buffers for GStreamer 0.10. Fix creation of GstVaapiVideoBuffer objects (i) to have that type for real; and (ii) to correctly extract the GstSurfaceConverter from the video buffer object meta. This fixes support for cluttersink with GStreamer 0.10 builds. 2013-08-26 16:15:49 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: disable video cropping as picture_display_extension() is missing. Disable video cropping in MPEG-2 codec because it is partially implemented and actually because nobody implements it that way, and the standard spec does not specify the display process either anyway. Most notably, there are two possible use cases for sequence_display_extension() horizontal_display_size & vertical_display_size: (i) guesstimating the pixel-aspect-ratio, or (ii) implement some kind of span & scan process in conjunction with picture_display_extension() information. https://bugzilla.gnome.org/show_bug.cgi?id=704848 2013-08-16 16:58:58 +0100 Simon Farnsworth * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: allow scaling to ignore aspect ratio. Other GStreamer sinks, like xvimagesink, have a force-aspect-ratio property, which allows you to say that you don't want the sink to respect aspect ratio. Add the same property to vaapisink. http://lists.freedesktop.org/archives/libva/2012-September/001298.html Signed-off-by: Simon Farnsworth 2013-05-14 15:19:04 +0800 Wind Yuan * gst/vaapi/gstvaapisink.c: vaapisink: fix memory leak of GstVaapiUploader instance. Make sure gst_vaapisink_ensure_uploader() checks for the existence of a former GstVaapiUploader instance prior to forcibly creating a new one. https://bugzilla.gnome.org/show_bug.cgi?id=703980 2013-07-31 16:49:20 +0800 Guangxin.Xu * gst/vaapi/gstvaapisink.c: vaapisink: fix get_caps() implementation for GStreamer 1.0. Fix GstBaseSink::get_caps() implementation for GStreamer 1.0.X builds by honouring the filter caps argument. More precisely, this fixes the following pipeline: gst-launch-1.0 videotestsrc ! vaapisink https://bugzilla.gnome.org/show_bug.cgi?id=705192 Signed-off-by: Guangxin.Xu Signed-off-by: Gwenole Beauchesne 2013-08-26 11:31:06 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: fix double definition of GstVaapiDecoderMpeg4Class. This fixes the following issue: CC libgstvaapi_0.10_la-gstvaapidecoder_mpeg4.lo gstvaapidecoder_mpeg4.c:113: error: redefinition of typedef 'GstVaapiDecoderMpeg4Class' gstvaapidecoder_mpeg4.c:44: note: previous declaration of 'GstVaapiDecoderMpeg4Class' was here make[5]: *** [libgstvaapi_0.10_la-gstvaapidecoder_mpeg4.lo] Error 1 make[5]: Leaving directory `/builddir/build/BUILD/gstreamer-vaapi-0.5.5.1/gst-libs/gst/vaapi' https://bugzilla.gnome.org/show_bug.cgi?id=705148 2013-07-30 15:59:40 +0200 Gwenole Beauchesne * tests/test-filter.c: tests: filter: add support for deinterlacing. Add --deinterlace option to enable deinterlacing through explicit VA/VPP deinterlacing filter. However, if --deinterlace option is not set but the --deinterlace-flags option is set with "top-field-first", then the very basic bob deinterlacing filter is set through VA/VPP proc pipeline flags. 2013-07-17 17:29:41 +0800 Zhao Halley * tests/test-filter.c: tests: filter: add support for denoising and sharpening. Add --denoise option to enable noise reduction with the level specified as the option value (float). Likewise, add --sharpen option to enable sharpening. Signed-off-by: Gwenole Beauchesne 2013-07-24 14:31:34 +0200 Gwenole Beauchesne * tests/test-filter.c: tests: filter: add support for frame cropping. Add support for frame cropping through the --crop-rect|-c argument. The format used is either 'x' , with origin at (0,0) ; or full specification with '('? ',' ')'? 'x' . 2013-07-23 18:00:26 +0200 Gwenole Beauchesne * tests/test-filter.c: tests: filter: dump supported operations and formats. 2013-07-08 16:54:55 +0800 Zhao Halley * tests/Makefile.am: * tests/test-filter.c: tests: add initial test for video processing. Add minimal test case for video processing: scaling and color format conversion. Signed-off-by: Gwenole Beauchesne 2013-07-29 09:23:50 +0800 Zhao Halley * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: filter: add initial support for deinterlacing. Add basic deinterlacing support, i.e. bob-deinterlacing whereby only the selected field from the input surface is kept for the target surface. Setting gst_vaapi_filter_set_deinterlacing() method argument to GST_VAAPI_DEINTERLACE_METHOD_NONE means to disable deinterlacing. Also move GstVaapiDeinterlaceMethod definition from vaapipostproc plug-in to libgstvaapi core library. Signed-off-by: Gwenole Beauchesne 2013-07-17 17:40:41 +0800 Zhao Halley * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add support for color balance adjustment. Add ProcAmp (color balance) adjustments for hue, saturation, brightness and contrast. The respective range for each filter shall be the same as for the VA display attributes. Signed-off-by: Gwenole Beauchesne 2013-07-17 17:37:16 +0800 Zhao Halley * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add support for sharpening. Sharpening is configured with a float value. The supported range is -1.0 .. 1.0 with 0.0 being the default, and that means no sharpening operation at all. Signed-off-by: Gwenole Beauchesne 2013-07-17 17:29:41 +0800 Zhao Halley * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add support for denoising. Noise reduction is configured with a float value. The supported range is 0.0 .. 1.0 with 0.0 being the default, and that means no denoise operation at all. Signed-off-by: Gwenole Beauchesne 2013-07-24 14:22:28 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: filter: add support for frame cropping. Frame cropping is defined with a GstVaapiRectangle value. The default behaviour is to treat the source surface as a whole 2013-07-25 13:55:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapifilter.c: filter: add helper functions. Add helper functions to ensure an operation VA buffer is allocated to the right size; that filter caps get parsed and assigned to the right operation too; and that float parameters are correctly scaled to fit the reported range from the VA driver. 2013-07-23 15:52:45 +0200 Gwenole Beauchesne * configure.ac: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapifilter.c: * gst-libs/gst/vaapi/gstvaapifilter.h: Add initial infrastructure for video processing. Add initial API for video processing: only scaling and color format conversion operations are supported. 2013-07-24 11:53:38 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: libs: add gst_vaapi_video_format_from_string() helper. Add gst_vaapi_video_format_from_string() helper function to convert from a video format string representation to a suitable GstVideoFormat. This is just an alias to gst_video_format_from_string() for GStreamer 1.0.x builds, and a proper iteration over all GstVideoFormat string representations otherwise for earlier GStreamer 0.10.x builds. 2013-07-24 11:37:23 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: libs: add gst_vaapi_video_format_from_va_fourcc() helper. Add gst_vaapi_video_format_from_va_fourcc() helper that converts from a VA fourcc value to a suitable GstVideoFormat. 2013-07-24 11:41:05 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: libs: add type definitions for GstVaapiPoint and GstVaapiRectangle. Add helper functions to describe GstVaapiPoint and GstVaapiRectangle structures as a standard GType. This could be useful to have them described as a GValue later on. 2013-07-26 13:57:35 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: libs: drop some public APIs. Don't expose GstVaapiContext APIs and make them totally private to libgstvaapi core library. That API would also tend to disappear in a future revision. Likewise, don't expose GstVaapiDisplayCache API but keep symbols visible so that the various render backends could share a common display cache implementation in libgstvaapi. Try to clean-up the documentation from any stale entry too. 2013-08-23 18:35:42 +0200 Gwenole Beauchesne * tests/image.c: * tests/image.h: tests: image: allow creation of images with interleaved patterns. Add image_generate_full() function to create interleaved color rectangles. If flags is zero, the whole frame is generated with a unique pattern. If flags is non-zero, then each field is handled individually. 2013-08-23 16:25:39 +0200 Gwenole Beauchesne * tests/image.c: tests: image: fix conversion from RGB to YUV. Fix RGB to YUV conversion to preserve full data range. 2013-07-26 13:12:28 +0200 Gwenole Beauchesne * tests/image.c: tests: image: try to upload images through vaDeriveImage() too. On some platforms, vaPutImage() would fail even if it does not involve color format conversion or scaling, whereas copying raw pixels through vaDeriveImage() could work instead. 2013-07-26 10:05:06 +0200 Gwenole Beauchesne * tests/image.c: tests: image: add support for packed YUV formats. Add support for packed YUV 4:2:2 formats, i.e. YUY2 and UYVY. 2013-07-25 18:10:40 +0200 Gwenole Beauchesne * tests/image.c: tests: image: fix generation of I420/YV12 images. U/V planes were reversed, thus producing invalid images. 2013-07-24 13:55:04 +0200 Gwenole Beauchesne * tests/image.c: tests: image: fix string representation for GstVideoFormat. 2013-07-26 12:57:19 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimage_priv.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: image: clean image API up. Don't expose functions that reference a GstVaapiImageRaw, those are meant to be internal only for implementing subpictures sync. Also add a few private definitions to avoid functions calls for retrieving image size and format information. 2013-07-26 11:43:49 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: image: add gst_vaapi_image_copy() helper. Add gst_vaapi_image_copy() helper function to copy images of same format and size. 2013-07-22 14:53:51 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideoconverter_x11.c: plugins: handle video cropping in X11 pixmap converter. Use GstVideoCropMeta in GStreamer 1.0 or any other render rectangle we could decode from the stream. 2013-07-22 11:58:33 +0200 Gwenole Beauchesne * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_x11.c: * gst/vaapi/gstvaapivideoconverter_x11.h: plugins: add support for "x11-pixmap" video converter type. Install a new video converter that supports X11 pixmap targets for X11 backends only, or make the GLX converter creation function chain up to the X11 converter whenever requested. 2013-07-22 09:36:08 +0200 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: add support for pixmap API. Add support for the new render-to-pixmap API. Avoid flickering on platforms supporting video overlay by keeping up to 2 intermediate pixmaps. 2013-07-22 09:12:21 +0200 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: add support for video cropping. Handle video cropping information attached to a VA surface proxy. 2013-07-22 09:03:30 +0200 Gwenole Beauchesne * tests/output.c: * tests/output.h: * tests/test-decode.c: tests: add support for render-to-pixmap. Add --pixmap option to test-decode so that to allow copies of VA surface to an intermediate pixmap and rendering from that pixmap. Only X11 backends are supported for now. 2013-07-22 09:00:38 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: x11: implement pixmap rendering with RENDER extension. Use hardware accelerated XRenderComposite() function, from the RENDER extension, to blit a pixmap to screen. Besides, this can also support cropping and scaling. 2013-07-19 15:05:34 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapipixmap_x11.c: * gst-libs/gst/vaapi/gstvaapipixmap_x11.h: x11: implement pixmap API. Implement the new render-to-pixmap API. The only supported pixmap format that will work is xRGB, with native byte ordering. Others might work but they were not tested. 2013-07-22 10:10:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: x11: update x11_get_geometry() helper function with depth output. Allow x11_get_geometry() utility function to also return the depth assigned to the X drawable. 2013-07-22 10:00:21 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapipixmap.c: * gst-libs/gst/vaapi/gstvaapipixmap.h: * gst-libs/gst/vaapi/gstvaapipixmap_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: Add initial Pixmap API. Add API to transfer VA urfaces to native pixmaps. Also add an API to render a native pixmap, for completeness. In general, rendering to pixmap would only be useful to certain VA drivers and use cases on X11 display servers. e.g. GLX_EXT_texture_from_pixmap (TFP) handled in an upper layer. 2013-07-22 15:15:48 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: libs: add and expose gst_vaapi_video_format_to_string() helper. This is just a wrapper over gst_video_format_to_string() for older GStreamer 0.10 builds. 2013-07-18 02:54:54 -0300 Emilio López * gst/vaapi/gstvaapipluginutil.c: plugins: fix display type comparison in gst_vaapi_create_display(). After the code got moved to create the gst_vaapi_create_display() helper, this comparison was not updated to dereference the newly-created pointer, so the code was comparing the pointer itself to the type, and therefore failing to retrieve the VA display. This fixes the following error (and gets gst-vaapi decoding again): ERROR vaapidecode gstvaapidecode.c:807:gst_vaapidecode_ensure_allowed_caps: failed to retrieve VA display https://bugzilla.gnome.org/show_bug.cgi?id=704410 Signed-off-by: Emilio López 2013-07-17 11:07:39 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-07-15 17:49:31 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: don't output dummy pictures. Mark dummy pictures as output already so that we don't try to submit them to the upper layer since this is purely internal / temporary picture for helping the decoder. 2013-07-15 17:43:34 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: dispose GstVideoCodecFrame earlier. Once the picture was output, it is no longer necessary to keep an extra reference to the underlying GstVideoCodecFrame. So, we can release it earlier, and maybe subsequently release the associate surface proxy earlier. 2013-07-15 14:47:01 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.5. 2013-07-15 14:42:33 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiuploader.c: * tests/image.c: * tests/test-display.c: Fix new video format API. Fix new internal video format API, based on GstVideoFormat, to not clobber with system symbols. So replace the gst_video_format_* prefix with gst_vaapi_video_format_ prefix, even if the format type remains GstVideoFormat. 2013-07-15 14:05:45 +0200 Gwenole Beauchesne * configure.ac: Bump library major version. Bump the library major version due to API/ABI changes that occurred in the imaging API. In particular, GstVaapiImageFormat type was replaced with the standard GstVideoFormat type. All dependent APIs were updated to match this change. 2013-07-15 13:44:43 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-06-11 15:11:34 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: fix memory leak when processing interlaced pictures. Fix memory leak when processing interlaced pictures and that occurs because the first field, represented as a GstVideoCodecFrame, never gets released. i.e. when the picture is completed, this is generally the case when the second field is successfully decoded, we need to propagate the GstVideoCodecFrame of the first field to the original GstVideoDecoder so that it could reclaim memory. Otherwise, we keep accumulating the first fields into GstVideoDecoder private frames list until the end-of-stream is reached. The frames are eventually released there, but too late, i.e. too much memory may have been consumed. https://bugzilla.gnome.org/show_bug.cgi?id=701257 2013-07-15 11:58:31 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: plugins: simlpify gst_vaapi_create_display() helper. Simplify gst_vaapi_create_display() helper as gst_vaapi_display_XXX_new() performs the necessary validation checks for the underlying VA display prior to returning to the caller. So, if an error occurred, then NULL is really returned in that case. 2013-05-24 05:04:01 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: add gst_vaapi_create_display() helper. https://bugzilla.gnome.org/show_bug.cgi?id=703235 Signed-off-by: Gwenole Beauchesne 2013-07-12 17:47:07 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.c: plugins: don't reallocate pool allocator for the same caps. If the video buffer pool config doesn't have new caps, then it's not necessary to reinstantiate the allocator. That could be a costly operation as we could do some extra heavy checking in there. 2013-07-12 17:14:49 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: fix ref counting of GstVaapiVideoMemory allocator. Fix reference counting issue whereby gst_memory_init() does not hold an extra reference to the GstAllocator. So, there could be situations where the last instance of GstVaapiVideoAllocator gets released before a dangling GstVaapiVideoMemory object, thus possibly leading to a crash. 2013-07-12 15:15:07 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: vaapiupload: use implicit color conversion to NV12. Always perform conversion of sources buffers to NV12 since this is the way we tested for this capability in ensure_allowed_caps(). This also saves memory bandwidth for further rendering. However, this may not preserve quality since the YUV buffers are down-sampled to 4:2:0. 2013-07-12 15:01:01 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivideopool.c: pool: fix deallocation of video pools. The queue of free objects to used was deallocated with g_queue_free_full(). However, this convenience function shall only be used if the original queue was allocated with g_queue_new(). This caused memory corruption, eventually leading to a crash. The correct solution is to pair the g_queue_init() with the corresponding g_queue_clear(), while iterating over all free objects to deallocate them. 2013-03-13 17:44:52 +0800 Wind Yuan * gst/vaapi/gstvaapidownload.c: vaapidownload: fix src caps format error. This fixes direct linking of vaapidownload element to xvimagesink with VA drivers supporting vaGetImage() from the native VA surface format to a different VA image format. i.e. color conversion during download. http://bugzilla.gnome.org/show_bug.cgi?id=703937 Signed-off-by: Gwenole Beauchesne 2013-07-11 18:26:37 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidownload.c: vaapidownload: fix debug string for image formats. The image is now expressed as a standard GstVideoFormat, which is not a FOURCC but rather a regular enum value. This is a regression introduced in commit 09397fa. 2013-04-24 10:39:03 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapiimage.c: image: add support for raw YUY2/UYVY image copies. Implement raw image copies for YUY2 format. Add support for UYVY format too, with the same copy function as for YUY2. Even though components ordering differs, copying line strides is essentially the same. https://bugzilla.gnome.org/show_bug.cgi?id=703939 https://bugzilla.gnome.org/show_bug.cgi?id=703940 Signed-off-by: Gwenole Beauchesne 2013-07-10 15:15:11 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: plugins: clean-up video uploader helper. Fix gst_vaapi_uploader_get_buffer() to not assign caps since they were already negotiated beforehand, and they are not used from the buffer in upstream elements. Clean-up gst_vaapi_uploader_ensure_caps() to use the new image caps represented as a GstVideoInfo. 2013-07-10 15:03:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: plugins: use GstVideoInfo in video uploader helper. 2013-07-10 10:34:24 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: allow creation of VA surfaces with explicit pixel format. Adapt GstVaapiVideoMemory allocator to support creation of VA surfaces with an explicit pixel format. This allows for direct rendering to VA surface memory from a software decoder. 2013-07-10 14:20:30 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfacepool.c: surface: fix surface pool creation with an explicit pixel format. Fix creation of surface pool objects to honour explicit pixel format specification. If this operation is not supported, then fallback to the older interface with chroma format. 2013-07-10 13:58:55 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: try to determine the underlying VA surface format. If a VA surface was allocated with the chroma-format interface, try to determine the underlying pixel format on gst_vaapi_surface_get_format(), or return GST_VIDEO_FORMAT_ENCODED if this is not a supported operation. 2013-07-09 19:08:37 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: surface: allow creation with explicit pixel format. Make it possible to create VA surfaces with a specific pixel format. This is a new capability brought in by VA-API >= 0.34.0. If that capability is not built-in (e.g. using VA-API < 0.34.0), then gst_vaapi_surface_new_with_format() will return NULL. 2013-07-10 09:48:40 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: surface: add helper function to get chroma type from GstVideoFormat. Add gst_video_format_get_chroma_type() helper function to determine the GstVaapiChromaType from a standard GStreamer video format. It is possible to reconstruct that from GstVideoFormatInfo but it is much simpler (and faster?) to use the local GstVideoFormatMap table. 2013-07-09 19:13:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: surface: add new chroma formats. Add new chroma formats available with VA-API >= 0.34.0. In particular, this includes "RGB" chroma formats, and more YUV subsampled formats. Also add a new from_GstVaapiChromaType() helper function to convert libgstvaapi chroma type to VA chroma format. 2013-07-10 13:32:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimagepool.c: pool: fix image pool to check for the video format to use. Make gst_vaapi_image_pool_new() succeed, and thus returning a valid image pool object, only if the underlying VA display does support the requested VA image format. 2013-07-10 13:07:37 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiuploader.c: * tests/Makefile.am: * tests/test-surfaces.c: Use GstVideoInfo for video pools. Get rid of GstCaps to create surface/image pool, and use GstVideoInfo structures instead. Those are smaller, and allows for streamlining libgstvaapi more. 2013-07-09 18:03:36 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/video-format.c: Add more video formats. Add new video format mappings to VA image formats: - YUV: packed YUV (YUY2, UYVY), grayscale (Y800) ; - RGB: 32-bit RGB without alpha channel (XRGB, XBGR, RGBX, BGRX). 2013-07-10 15:52:20 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: fix debug message with video format. Fix debug message string with image format expressed with GstVideoFormat instead of the obsolete format that turned out to be a fourcc. This is a regression from git commit e61c5fc. 2013-07-09 15:28:31 +0200 Gwenole Beauchesne * tests/image.c: * tests/image.h: * tests/test-display.c: * tests/test-textures.c: * tests/test-windows.c: tests: port to new video format API. 2013-07-09 15:44:35 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideomemory.c: plugins: port to new video format API. 2013-07-09 16:26:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: libs: use GstVideoInfo wherever possible. In particular, use gst_video_info_from_caps() helper function in VA image for implementating gst_vaapi_image_get_buffer() [vaapidownload] and gst_vaapi_image_update_from_buffer() [subpictures] in GStreamer 0.10 builds. 2013-07-09 16:38:05 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: libs: drop GstVaapiImageFormat helpers. Drop GstVaapiImageFormat helpers since everything was moved to the new GstVideoFormat based API. Don't bother with backwards compatibility and just bump the library major version afterwards. 2013-07-09 14:03:01 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: libs: port to new video format API. 2013-07-09 15:29:59 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/video-format.c: * gst-libs/gst/vaapi/video-format.h: Add new video format API. Leverage GstVideoFormat utilities from core GStreamer to provide an adaptation layer to VA image formats. 2013-07-09 11:13:59 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-07-08 18:32:00 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix creation of GLX texture. Fix creation of GLX texture, to not depend on the GstCaps video size that could be wrong, especially in presence of frame cropping. So, use the size from the source VA surfaces. An optimization could be to reduce the texture size to the actual visible size on screen. i.e. scale down the texture size to match the screen dimensions, while preserving the VA surface aspect ratio. However, some VA drivers don't honour that. 2013-02-18 16:28:27 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: add support for video cropping. If the stream has a sequence_display_extenion, then attach the display_horizontal/display_vertical dimension as the cropping rectangle width/height to the GstVaapiPicture. Signed-off-by: Gwenole Beauchesne 2013-02-18 15:05:37 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: add support for video cropping. If the Advanced profile has display_extension fields, then set the display width/height dimension as cropping rectangle to the GstVaapiPicture. Signed-off-by: Gwenole Beauchesne 2013-02-15 18:50:26 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add support for video cropping. If the encoded stream has the frame_cropping_flag set, then associate the cropping rectangle to GstVaapiPicture. Signed-off-by: Gwenole Beauchesne 2013-07-08 17:01:21 +0200 Gwenole Beauchesne * tests/decoder.c: * tests/decoder.h: * tests/test-decode.c: * tests/test-subpicture.c: tests: add basic support for video cropping. Change generic decoder of sample I-frame to return a GstVaapiSurfaceProxy instead of a plain GstVaapiSurface. This means that we can now retrieve the frame cropping rectangle from the surface proxy, along with additional information if ever needed. 2013-07-08 14:50:42 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideometa.c: plugins: add support for video cropping. Add support for GstVideoCropMeta in GStreamer >= 1.0.x builds and gst-vaapi specific meta information to hold video cropping details. Make the sink support video cropping in X11 and GLX modes. 2013-02-15 18:24:24 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: plugins: add helper functions to set the render rectangle. Some video clips may have a clipping region that needs to propogate to the renderer. These helper functions make it possible to attach that clipping region, as a GstVaapiRectangle, the the video meta associated with the buffer. Signed-off-by: Sreerenj Balachandran signed-off-by: Gwenole Beauchesne 2013-07-08 14:47:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: surfaceproxy: allow for NULL cropping rectangle. Make it possible associate an empty cropping rectangle to the surface proxy, thus resetting any cropping rectangle that was previously set. This allows for returning plain NULL when no cropping rectangle was initially set up to the surface proxy, or if it was reset to defaults. 2013-07-08 11:41:59 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: surfaceproxy: clean-up helper macros. Always use the GST_VAAPI_SURFACE_PROXY() helper macro to cast from a proxy macro argument to a GstVaapiSurfaceProxy pointer. 2013-07-08 11:43:27 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: surface: add simple surface info accessors as helper macros. Add helper macros to retrieve the VA surface information like size (width, height) or chroma type. This is a micro-optimization to avoid useless function calls and NULL pointer re-checks in internal routines. 2013-02-15 18:42:12 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: decoder: add support for video cropping. Add gst_vaapi_picture_set_crop_rect() helper function to copy the video cropping information from raw bitstreams to each picture being decoded. Also add helper function to surface proxy to propagate that information outside of libgstvaapi. e.g. plug-in elements or standalone applications. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2013-07-08 17:30:30 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit f90de0a. f90de0a h264: fix calculation of the frame cropping rectangle 535515c h264: parse the cropping rectangle separately 2013-07-05 19:03:41 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 0f68a71. 0f68a71 mpeg2: fix video packet header size checks 2013-06-07 20:08:43 +0800 Zhong Cong * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: reset quantization matrices on new sequence headers. The MPEG-2 standard specifies (6.3.7) that all quantisation matrices shall be reset to their default values when a Sequence_Header() is decoded. Signed-off-by: Gwenole Beauchesne 2013-07-05 15:49:34 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: cope with latest codecparser changes. Fix build with newer MPEG-2 codecparser where GstMpegVideoPacket are used in individual header parsers. Also use the new slice parsing API. 2013-07-05 17:51:26 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit dddd182. dddd182 mpeg2: add slice header parsing API 94e6228 mpeg2: add sequence scalable extension parsing API 531134f mpeg2: add new API that takes GstMpegVideoPacket arguments 4b135d3 h264: fix the return value type for the SEI palyload parsing methods 2013-06-27 12:25:44 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: expose the raw video formats in static caps template. Expose all raw video formats in the static caps template since the vaapisink is supporting raw data. We will get the exact set of formats supported by the driver dynamically through the _get_caps() routine. This also fixes an inconsistency wrt. GStreamer 0.10 builds. https://bugzilla.gnome.org/show_bug.cgi?id=702178 Signed-off-by: Gwenole Beauchesne 2013-06-27 13:53:46 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add "use-glx" property for OpenGL rendering. Now that VA/GLX capable buffers are generated by default on X11, thus depending on a VA/GLX display, we stil want to use vaPutSurface() for rendering since it is faster. Anyway, OpenGL rendering in vaapisink was only meant for testing and enabling "fancy" effects to play with. This has no real value. So, disable OpenGL rendering by default. 2013-06-06 05:36:03 -0400 Víctor Manuel Jáquez Leal * gst/vaapi/gstvaapipluginutil.c: plugins: try to allocate a GLX display first over an X11 one. If the gstreamer-vaapi plug-in elements are built with GLX support, then try to allocate a GstVaapiDisplayGLX first before resorting to a VA/X11 display next. https://bugzilla.gnome.org/show_bug.cgi?id=701742 2013-04-25 17:07:13 +0100 Lionel Landwerlin * configure.ac: configure: use GST_PLUGIN_PATH_1_0 instead of GST_PLUGIN_PATH for Gst 1.0. jhbuild sets $GST_PLUGIN_PATH_1_0 which overrides $GST_PLUGIN_PATH. https://bugzilla.gnome.org/show_bug.cgi?id=698858 Signed-off-by: Gwenole Beauchesne 2013-04-27 15:15:49 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapiimage.c: image: fix wrong check for rect bounds in copy_image(). 2013-06-14 13:41:14 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-06-14 11:47:50 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.4. 2013-06-14 11:43:46 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-06-14 11:39:54 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/codecparsers/Makefile.am: configure: always build the MPEG-4 parser. Always build the MPEG-4 parser for now as there are also core fixes included in the parser that cannot be tested for with API checks. 2013-06-14 11:32:36 +0200 Gwenole Beauchesne * configure.ac: configure: add --enable-builtin-codecparsers [default="yes"] option. Add flag to have all codecparsers built-in, thus ensuring that the resulting binaries have all the necessary bug fixes and this is what the QA has been testing anyway. Of course, for a completely up-to-date Linux distribution, you could also opt for --disable-builtin-codecparsers and use the system ones. Though, some core fixes could be missing, and those cannot be tested for with API checks. 2013-06-14 11:14:23 +0200 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 843ce3e. 843ce3e jpeg: fix default Huffman tables generation. 8655187 mpeg2: fix the pixel-aspect-ratio calculation 21099dc mpeg2: actually store video bitrate values dd02087 mpeg2: fix picture packet extension size check 25948e9 mpeg2: increase min size for picture coding ext f1f5a40 ensure the debug category is properly initialized 2013-06-12 14:16:17 +0100 Gwenole Beauchesne * debian.upstream/Makefile.am: debian: fix list of generated files for .deb packaging. 2013-06-12 13:48:26 +0100 Gwenole Beauchesne * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: debian: fix libgstvaapi -dev package name. Fix libgstvaapi -dev package name so that to allow installation of both GStreamer 0.10 and 1.0.x based packages. 2013-06-05 17:42:00 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-05-31 11:09:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: fix memory leak of display resources. 2013-06-04 07:14:22 +0800 Zhao Halley * gst/vaapi/gstvaapisink.c: vaapisink: fix build without VA/GLX support. 2013-06-05 11:01:51 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: allow buffer mappings to GstVaapiSurfaceProxy. Allow plain gst_buffer_map() interface to work with gstreamer-vaapi video buffers, i.e. expose the underlying GstVaapiSurfaceProxy to the caller. This is the only sensible enough thing to do in this mode as the underlying surface pixels need to be extracted through an explicit call to the gst_video_frame_map() function instead. A possible use-case of this is to implement a "handoff" signal handler to fakesink or identity element for further processing. 2013-06-03 10:22:44 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: silence check for direct-rendering mode in video memory. Fix gst_vaapi_video_allocator_new() to silently check for direct-rendering mode support, and not trigger fatal-criticals if either test surface or image could not be created. Typical case: pixel format mismatch, e.g. NV12 supported by most hardware vs. I420 supported by most software decoders. 2013-06-03 10:06:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: plugins: improve video memory flags safety checks. On map, ensure we have GST_MAP_WRITE flags since this is only what we support for now. Likewise, on unmap, make sure that the VA image is unmapped for either read or write, while still committing it to the VA surface if write was requested. 2013-05-30 18:17:07 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: fix memory leak through unreleased parent context. Break the circular references between GstVaapiContext and its children GstVaapiSurfaces. Since the VA surfaces held an extra reference to the context, which holds a reference to its VA surfaces, then none of those were released. How does this impact support for subpictures? The only situation when the parent context needs to disappear is when it is replaced with another one because of a resolution change in the video stream for instance, or a normal destroy. In this case, it does not really matter to apply subpictures to the peer surfaces since they are either gone, or those that are left in the pipe can probably bear a reinstantiation of the subpictures for it. So, parent_context is set to NULL when the parent context is destroyed, other VA surfaces can still get subpictures attached to them, individually not as a whole. i.e. subpictures for surface S1 will be created from active composition buffers and associated to S1, subpictures for S2 will be created from the next active composition buffers, etc. We don't try to cache the subpictures in those cases (pending surfaces until EOS is reached, or pending surfaces until new surfaces matching new VA context get to be used instead). 2013-05-27 14:01:48 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix one-time initialization when display property is set. Fix gst_vaapisink_ensure_display() to perform one-time initialization tasks even if the `display' property was explicitly set. 2013-05-27 15:59:08 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: window: fix GLX window initialization. Make sure to create the GLX context once the window object has completed its creation. Since gl_resize() relies on the newly created window size, then we cannot simply overload the GstVaapiWindowClass::create() hook. So, we just call into gst_vaapi_window_glx_ensure_context() once the window object is created in the gst_vaapi_window_glx_new*() functions. 2013-05-27 17:18:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: display: validate display types. 2013-05-27 16:13:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: drop internal NAME_PREFIX, store the real display name. Always store a valid display name/device path, instead of adding a particular prefix. i.e. make it simply a strdup(), or "" if it was initially NULL. 2013-05-27 13:17:31 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: make it possible to lookup the display cache by type. Make it possible to add extra an extra filter to most of display cache lookup functions so that the GstVaapiDisplay instance can really match a compatible and existing display by type, instead of relying on extra string tags (e.g. "X11:" prefix, etc.). 2013-05-24 16:19:23 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: cope with new display cache API. 2013-05-24 16:12:01 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: rework display cache API. Simplify display cache API, while making it more flexible. We can now create custom lookup functions with gst_vaapi_display_cache_lookup_custom(). 2013-05-24 15:05:45 +0200 Gwenole Beauchesne * tests/test-display.c: tests: improve check for display cache. Improve check for display cache infrastructure. In particular, for X11 and GLX backends, we need to make sure that we can create a GstVaapiDisplayX11 from another GstVaapiDisplayGLX, i.e. underlying X11 and VA displays can be shared. Besides, allocating a GstVaapiDisplayGLX while a GstVaapiDisplayX11 already exists will have to generate different VA displays. 2013-05-15 10:33:16 +0800 Zhao Halley * gst/vaapi/gstvaapiuploader.c: uploader: fix memory leak in GStreamer 0.10 builds. In GStreamer 0.10 builds, gst_vaapi_uploader_get_buffer() was used but it exhibited a memory leak because the surface generated for the GstVaapiVideoMeta totally lost its parent video pool. So, it was not possible to release that surface back to the parent pool when the meta gets released, and the memory consumption kept growing. Signed-off-by: Gwenole Beauchesne 2013-05-23 18:56:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa.c: plugins: fix gst_vaapi_video_meta_new_from_pool(). Since GST_VAAPI_IS_xxx_VIDEO_POOL() was only testing for NULL and not the underlying object type, the gst_vaapi_video_meta_new_from_pool() was hereby totally broken. Fixed this regression by using the newly provided gst_vaapi_video_pool_get_object_type() function. 2013-05-23 18:22:50 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: plugins: cope with GST_VAAPI_IS_xxx() macros removal. 2013-05-23 18:19:24 +0200 Gwenole Beauchesne * tests/decoder.c: tests: cope with GST_VAAPI_IS_xxx() macros removal. 2013-05-23 18:45:23 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: libs: add query for GstVaapiVideoPool object types. Add API to identify the underlying GstVaapiVideoPool object type. 2013-05-23 18:15:48 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: libs: drop GST_VAAPI_IS_xxx() helper macros. Drop obsolete GST_VAAPI_IS_xxx() helper macros since we are no longer deriving from GObject and so those were only checking for whether the argument was NULL or not. This is now irrelevant, and even confusing to some extent, because we no longer have type checking. Note: this incurs more type checking (review) but the libgstvaapi is rather small, so this is manageable. 2013-05-07 18:52:28 +0200 Gwenole Beauchesne * configure.ac: Bump library major version. The whole libgstvaapi libraries got a major refresh to get rid of GObject. This is a fundamental change that requires a new SONAME. More changes are underway to streamline the core libraries. So far, the net result is a reduction of .text size (code) by 32KB, i.e. -10%. On one particular test (sintel HD trailer), the total number of executed instruction was reduced by 8%. 2013-05-07 18:37:24 +0200 Gwenole Beauchesne * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.core.types: * docs/reference/libs/libs.glx.types: * docs/reference/libs/libs.x11.types: docs: cope with removed APIs. Some APIs are dead because they are no longer based on GObject. 2013-05-06 14:43:38 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideometa.c: plugins: cope with new GstVaapiMiniObject objects. 2013-05-07 11:45:10 +0200 Gwenole Beauchesne * tests/decoder.c: * tests/image.c: * tests/output.c: * tests/simple-decoder.c: * tests/test-decode.c: * tests/test-display.c: * tests/test-subpicture.c: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-windows.c: tests: cope with new GstVaapiMiniObject objects. 2013-05-07 15:38:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: fix set_synchronous() to lock display. 2013-05-03 19:02:23 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: videopool: simplify creation of video objects pool. 2013-05-07 18:17:10 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitypes.h: libs: simplify GstVaapiID definitions. Make GstVaapiID a gsize instead of guessing an underlying integer large enough to hold all bits of a pointer. Also drop GST_VAAPI_ID_NONE since this is plain zero and that it is no longer passed as varargs. 2013-05-02 16:11:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapi_priv.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: libs: drop obsolete function helpers and objects. Drop obsolete GstVaapiID related function helpers for passing them as GValues. 2013-05-07 11:39:34 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: use GstVaapiMiniObject for display objects. 2013-05-06 14:07:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: libs: use GstVaapiMiniObject for video decoders. Port GstVaapiDecoder and GstVaapiDecoder{MPEG2,MPEG4,JPEG,H264,VC1} to GstVaapiMiniObject. Add gst_vaapi_decoder_set_codec_state_changed_func() helper function to let the user add a callback to a function triggered whenever the codec state (e.g. caps) changes. 2013-05-03 11:01:12 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideopool_priv.h: libs: use GstVaapiMiniObject for video object pools. Port GstVaapiVideoPool, GstVaapiSurfacePool and GstVaapiImagePool to GstVaapiMiniObject. Drop gst_vaapi_video_pool_get_caps() since it was no longer used for a long time. Make object allocators static, i.e. local to the shared library. 2013-04-30 17:22:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: libs: use GstVaapiObject for texture objects. 2013-04-30 17:20:14 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11_priv.h: libs: use GstVaapiObject for window objects. 2013-04-30 17:22:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: use GstVaapiObject for VA objects. 2013-04-30 17:20:46 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: Port GstVaapiObject to GstVaapiMiniObject. 2013-04-30 10:28:30 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: libs: refine GstVaapiMiniObject. Drop support for user-defined data since this capability was not used so far and GstVaapiMiniObject represents the smallest reference counted object type. Add missing GST_VAAPI_MINI_OBJECT_CLASS() helper macro. Besides, since GstVaapiMiniObject is a libgstvaapi internal object, it is also possible to further simplify the layout of the object. i.e. merge GstVaapiMiniObjectBase into GstVaapiMiniObject. 2013-05-07 16:43:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: update picture size from the bitstream. Propagate the picture size from the bitstream to the GstVaapiDecoder, and subsequent user who installed a signal on notify::caps. This fixes decoding of TS streams when the demuxer failed to extract the required information. 2013-04-25 14:16:01 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: fix raw decoding mode. Fix gst_vaapi_decoder_get_surface() to actually transfer ownership of the surface proxy to the caller. 2013-04-25 13:56:18 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst/vaapi/gstvaapidecode.c: decoder: add gst_vaapi_decoder_get_frame_with_timeout(). Add gst_vaapi_decoder_get_frame_with_timeout() helper function that will wait for a frame to be decoded, until the specified timeout in microseconds, prior to returning to the caller. This is a fix to performance regression from 851cc0, whereby the vaapidecode loop executed on the srcpad task was called to often, thus starving all CPU resources. 2013-04-19 14:38:59 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-04-18 19:09:45 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.3. 2013-04-18 19:08:39 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-04-18 15:55:26 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: rework heuristics to detect decode timeout. Rework heuristics to detect when downstream element ran into errors, and thus failing to release any VA surface in due time for the current frame to get decoded. In particular, recalibrate the render time base when the first frame gets submitted downstream, or when there is no timestamp that could be inferred. 2013-04-18 15:50:02 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapidecode.c: vaapidecode: rework GstVideoDecoder::handle_frame() with a task. Rework GstVideoDecoder::handle_frame() to decode the current frame, while possibly waiting for a free surface, and separately submit all decoded frames from a task. This makes it possible to pop and render decoded frames as soon as possible. 2013-04-18 10:06:15 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: use gst_object_unref() wherever applicable. Use gst_object_unref() wherever applicable, e.g. objects derived from GstElement, GstVideoPool, etc. 2013-04-17 14:21:16 +0200 Gwenole Beauchesne * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: docs: drop obsolete plug-ins. Drop documentation for obsolete plug-ins, even for GStreamer 0.10. i.e. vaapiupload and vaapidownload are no longer the recommended plug-ins to use. 2013-04-17 13:17:26 +0200 Gwenole Beauchesne * debian.upstream/rules: debian: fix build of GStreamer 0.10 packages. Fix build of Debian packages to scan the actual GStreamer API version from the generated changelog file. 2013-04-17 10:58:04 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: minor clean-ups. Use g_clear_object() wherever appropriate and remove dead-code. 2013-04-17 10:53:03 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix reference counting buf for passthrough mode. Fix reference counting bug for passthrough mode, whereby the input buffer was propagated as is downstream through gst_pad_push() without increasing its reference count before. The was a problem when gst_pad_push() returns an error and we further decrease the reference count of the input buffer. 2013-04-17 10:18:45 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: port to GStreamer 1.0. Add support for interlaced streams with GStreamer 1.0 too. Basically, this enables vaapipostproc, though it is not auto-plugged yet. We also make sure to reply to CAPS queries, and happily handle CAPS events. 2013-04-17 10:14:55 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: fix GstVideoCodecFrame flags for interlaced contents. Fix support for interlaced contents with GStreamer 0.10. In particular, propagate GstVaapiSurfaceProxy frame flags to GstVideoCodecFrame flags correctly. This is a regression from commit 87e5717. 2013-04-16 13:23:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapiparser_frame.c: * gst-libs/gst/vaapi/gstvaapiparser_frame.h: decoder: rename GstVaapiDecoderFrame to GstVaapiParserFrame. Rename GstVaapiDecoderFrame to GstVaapiParserFrame because this data structure was only useful to parsing and a proper GstvaapiDecoderFrame instance will be created instead. 2013-04-16 19:09:30 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: export presentation timestamp for raw decoding mode. Fix regression from 0.4-branch whereby GstVaapiSurfaceProxy no longer held any information about the expected presentation timestamp, frame duration or additional flags like interlaced or top-field-first. 2013-04-16 18:56:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: use new GstVaapiSurfaceProxy utility functions. Use new GstVaapiSurfaceProxy internal helper functions to propagate the necessary GstVideoCodecFrame flags to vaapidecode (GStreamer 0.10). Also make GstVaapiDecoder push_frame() operate similarly to drop_frame(). i.e. increase the GstVideoCodecFrame reference count in push_frame rather than gst_vaapi_picture_output(). 2013-04-16 18:35:48 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy_priv.h: surfaceproxy: add more attributes for raw decoding modes. Add more attributes for raw decoding modes, i.e. directly through the libgstvaapi helper library. In particular, add presentation timestamp, duration and a couple of flags (interlaced, TFF, RFF, one-field). 2013-04-16 13:48:00 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst/vaapi/gstvaapidecode.c: * tests/simple-decoder.c: surfaceproxy: drop user-data support from GstVaapiSurfaceProxy. Drop user-data support from GstVaapiSurfaceProxy. Rather make it explicit to call some user-provided function when the surface proxy is released. 2013-04-15 12:52:51 +0400 Víctor Manuel Jáquez Leal * configure.ac: * gst-libs/gst/vaapi/Makefile.am: build: link libgstvaapi-glx-1.0.so against libdl. Ensure libgstvaapi-glx*.so builds against libdl since dlsym() is used to resolve glXGetProcAddress() from GLX libraries. This fix builds on Fedora 17. https://bugzilla.gnome.org/show_bug.cgi?id=698046 Signed-off-by: Gwenole Beauchesne 2013-04-15 14:22:57 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: fix gst_vaapi_decoder_get_codec_state(). Fix previous commit whereby gst_vaapi_decoder_get_codec_state() was supposed to make GstVaapiDecoder own the return GstVideoCodecState object. Only comment was updated, not the actual code. 2013-04-15 13:58:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst/vaapi/gstvaapidecode.c: decoder: make gst_vaapi_decoder_get_codec_state() return the original state. Make gst_vaapi_decoder_get_codec_state() return the original codec state, i.e. make the GstVaapiDecoder object own the return state so that callers that want an extra reference to it would just gst_video_codec_state_ref() it before usage. This aligns the behaviour with what we had before with gst_vaapi_decoder_get_caps(). This is an ABI incompatible change, library major version was bumped from previous release (0.5.2). 2013-04-15 13:52:19 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideoconverter_glx.h: plugins: mark a few more functions as internal. Mark the following functions are internal, i.e. private to the vaapi plug-in: - gst_vaapi_video_buffer_pool_get_type() - gst_vaapi_video_converter_glx_get_type() - gst_vaapi_video_converter_glx_new() 2013-04-15 13:48:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobuffer.c: plugins: implement GstSurfaceMeta API. Implement GstSurfaceMeta API for GStreamer 1.0.x. Even though this is an unstable/deprecated API, this makes it possible to support Clutter sink with minimal changes. Tested against clutter-gst 1.9.92. 2013-04-12 17:12:43 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: optimize GstVideoOverlayInterface::expose(). When render-mode is "overlay", then it is not really useful to peek into the GstBaseSink::last_buffer, since we have our own video_buffer already recorded and maintained into GstVaapiSink. 2013-04-12 17:05:06 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix memory leak of GstSample objects. Fix memory leak of GstSample objects in GstVideoOverlayInterface::expose(). This also fixes extra unreferencing of the underlying GstBuffer in the common path afterwards (for both 0.10 or 1.0). 2013-04-12 13:44:52 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapi.c: plugins: fix description for gst-inspect. Fix the name of the plug-in element reported to gst-inspect-1.0. i.e. we need an explicit definition for GStreamer >= 1.0 because the GST_PLUGIN_DEFINE incorrectly uses #name for creating the plug-in name, instead of using macro expansion (and let further expansion of macros) through e.g. G_STRINGIFY(). 2013-04-11 09:24:44 +0200 Gwenole Beauchesne * README: README: updates. Update build requirements for GStreamer 1.0.x support. Add section for ways to report bugs. 2013-04-10 16:54:01 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-04-10 15:31:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: Fix make dist to include all source files, in any case. Fix make dist to allow build for either GStreamer 0.10 or 1.0. i.e. make sure to include all source files in either case while generating source tarballs. 2013-04-10 15:21:57 +0200 Gwenole Beauchesne * configure.ac: Bump library major version. Bump library major version, while preserving a major version of 0 for GStreamer 1.0 based libraries, and a major version of 2 for GStreamer 0.10 based librarieS. 2013-04-10 14:37:42 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: implement direct-rendering mode for raw YUV buffer uploads. Allow direct-rendering (writes) into target VA surfaces. 2013-04-09 16:02:06 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: implement uploads from raw YUV buffers for GStreamer 1.0. Implement GstVideoMeta::{,un}map() to support raw YUV buffer upload when the last component is unmapped. Downloads are not supported yet. The aim was to first support SW decoding + HW accelerated rendering (vaapisink). e.g. for Wayland. 2013-04-03 11:10:41 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: submit all decoded frames before decoding a new one. Make sure to purge all pending frames that were already decoded prior to decoding a new one. This helps release VA surfaces as early as possible. 2013-04-02 16:12:16 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: reply to CAPS queries. Handle GST_QUERY_CAPS, which is the GStreamer 1.0 mechanism to retrieve the set of allowed caps, i.e. it works similar to GstPad::get_caps(). This fixes fallback to SW decoding if no HW decoder is available. 2013-03-20 11:26:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: fix unpaired GstBuffer map/unmaps. This possibly fixes a few memory leaks along the way. 2013-03-20 14:40:57 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiuploader.c: * tests/codec.c: Allow build against either GStreamer API (0.10 or 1.0). Introduce a new configure option --with-gstreamer-api that determines the desired GStreamer API to use. By default, GStreamer 1.0 is selected. Also integrate more compatibility glue into gstcompat.h and plugins. 2012-11-08 16:41:22 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: plugins: use new video buffer pools. Use new GstVaapiVideoBufferPool to maintain video buffers. Implement GstBaseSink::propose_allocation() to expose that pool to upstream elements; and also implement GstVideoDecoder::decide_allocation() to actually use that pool (from downstream), if any, or create one. Signed-off-by: Gwenole Beauchesne 2012-11-08 16:41:22 +0200 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapivideobufferpool.c: * gst/vaapi/gstvaapivideobufferpool.h: * gst/vaapi/gstvaapivideomemory.c: * gst/vaapi/gstvaapivideomemory.h: plugins: add GstVaapiVideoMemory and GstVaapiVideoBufferPool objects. Add initial support for GstVaapiVideoMemory backed buffer pool. The memory object currently holds a reference to GstVaapiVideoMeta. Signed-off-by: Gwenole Beauchesne 2013-04-04 17:36:45 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: plugins: allow copies of GstVaapiVideoMeta objects. Make it possible to copy GstVaapiVideoMeta objects, unless they contain VA objects created from GstVaapiVideoPool. This is mostly useful to clone a GstVaapiVideoMeta object containing a VA surface proxy so that to alter its rendering flags. 2013-04-04 16:16:31 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapivideometa.c: plugins: make it possible to clear VA objects from GstVaapiVideoMeta. Fix GstVaapiVideoMeta to allow VA objects to be destroyed when they are reset to NULL. i.e. make gst_vaapi_video_meta_set_{image,surface}() and gst_vaapi_video_meta_set_surface_proxy() actually clear VA objects when argument is NULL. 2012-09-03 14:00:25 +0300 Sreerenj Balachandran * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: plugins: initial port to GStreamer 1.0. Port vaapidecode and vaapisink plugins to GStreamer API >= 1.0. This is rather minimalistic so that to test the basic functionality. Disable vaapiupload, vaapidownload and vaapipostproc plugins. The latter needs polishing wrt. to GStreamer 1.x functionality and the former are totally phased out in favor of GstVaapiVideoMemory map/unmap facilities, which are yet to be implemented. Signed-off-by: Gwenole Beauchesne 2013-03-21 10:12:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * tests/codec.c: * tests/decoder.c: * tests/simple-decoder.c: * tests/test-subpicture.c: tests: add support for GStreamer 1.0. 2012-09-04 15:12:18 +0300 Sreerenj Balachandran * configure.ac: * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add initial support for GStreamer 1.0. This integrates support for GStreamer API >= 1.0 only in the libgstvaapi core decoding library. The changes are kept rather minimal here so that the library retains as little dependency as possible on core GStreamer functionality. Signed-off-by: Gwenole Beauchesne 2013-04-03 15:58:57 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: improve check for raw YUV format mode. Improve check for raw YUV format modes by avoiding checks against strings ("video/x-raw-yuv") for each new GstBuffer allocation. In the usual case, GstBaseSink::set_caps() is called first and if VA surface format mode is used, then GstBaseSink::buffer_alloc() is not called. If the latter is called before set_caps(), then we just make a full check. This one is pretty rare though, e.g. it usually happens once for custom pipelines. 2013-04-03 15:06:46 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: plugins: don't fail if there is no overlay composition to apply. Fix gst_vaapi_apply_composition() to not fail if no overlay composition was found. i.e. return success (TRUE). This was harmless though extra debug messages are not nice. This is a regression introduced by commit 95b8659. 2013-04-03 14:59:33 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: expose the exact set of supported HW decoders. Don't return static caps that don't mean anything for the underlying codecs that are actually supported for decoding. i.e. always allocate a VA display and retrieve the exact set of HW decoders available. That VA display may be re-used later on during negotiation through GstVideoContext "prepare-context". This fixes fallback to SW decoding if no HW decoder is available. 2013-04-03 13:08:55 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: decoder: drop obsolete functions. Drop the following functions that are now obsolete: - gst_vaapi_context_get_surface() - gst_vaapi_context_put_surface() - gst_vaapi_context_find_surface_by_id() - gst_vaapi_surface_proxy_new() - gst_vaapi_surface_proxy_get_context() - gst_vaapi_surface_proxy_set_context() - gst_vaapi_surface_proxy_set_surface() This is an API change. 2013-04-03 13:14:59 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: delegate surface size check to VA context reset. Now that the surface pool is reference counted in the surface proxy wrapper, we can safely ignore surface size checks in gst_vaapi_decoder_ensure_context(). Besides, this check is already performed in gst_vaapi_context_reset_full(). 2013-04-03 11:37:44 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: decoder: simplify acquisition/release of spare surface. Introduce gst_vaapi_surface_proxy_new_from_pool() to allocate a new surface proxy from the context surface pool. This change also makes sure to retain the parent surface pool in the proxy. Besides, it was also totally useless to attach/detach parent context to VA surface each time we acquire/release it. Since the whole context owns all associated VA surfaces, we can mark this as such only once and for all. 2013-03-29 10:39:37 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-03-28 10:18:51 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.2. 2013-03-28 10:15:53 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-03-26 18:57:00 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: plugins: fix usage of gst_vaapi_reply_to_query(). Make gst_vaapi_reply_to_query() first check whether the query argument is actually a video-context query, i.e. with type GST_QUERY_TYPE_CUSTOM. Then, make sure vaapisink propagates the query to the parent class if it is not a video-context query. 2013-03-26 18:45:53 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: plugins: streamline video buffers. Add new gst_vaapi_video_buffer_new() helper function that allocates a video buffer from a GstVaapiVideoMeta. Also remove obsolete and useless function gst_vaapi_video_buffer_get_meta(). 2013-03-26 10:31:10 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideometa.c: * gst/vaapi/gstvaapivideometa.h: plugins: integrate GstVaapiVideoMeta from libgstvaapi. Move GstVaapiVideoMeta from core libgstvaapi decoding library to the actual plugin elements. That's only useful there. Also inline reference counting code from GstVaapiMiniObject. 2013-03-21 17:17:53 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginbuffer.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: plugins: drop gstvaapipluginbuffer.[ch] helper files. Move all gst_vaapi_video_buffer_new*() helpers from gstvaapipluginbuffer.[ch] to gstvaapivideobuffer.[ch], and drop the obsolete files. 2013-03-21 17:06:43 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.core.types: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapivideobuffer.h: * gst/vaapi/gstvaapivideoconverter_glx.h: plugins: integrate GstVaapiVideoBuffer from libgstvaapi. Move GstVaapiVideoBuffer from core libgstvaapi decoding library to the actual plugin elements. That's only useful there. 2013-03-21 16:32:43 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapivideoconverter_glx.c: plugins: use common helper function to apply compositions. Use common gst_vaapi_apply_composition() helper function to apply compositions attached to a buffer in vaapisink or GstVaapiVideoConverterGLX. 2013-03-21 16:09:42 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapivideoconverter_glx.h: plugins: integrate GstVaapiVideoConverterGLX from libgstvaapi. Make sure libgstvaapi core decoding library doesn't include un-needed dependencies. So, move out GstVaapiVideoConverterGLX to plugins instead. Besides, even if the vaapisink element is not used, we are bound to have a correctly populated GstSurfaceBuffer from vaapidecode. Also clean-up the file along the way. 2013-03-21 13:32:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix use of possibly uninitialized variable. In decode_codec_data(), force initialization of format to zero so that we can catch up cases where codec-data has neither "format" nor "wmvversion" fields, thus making it possible to gracefully fail in this case. 2013-03-21 13:43:46 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: propagate buffer data as a const guchar * pointer (cosmetics). 2013-03-21 14:36:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: sanitize codec-data decoding. Add a new GstVaapiDecoder::decode_codec_data() hook to actually decode codec-data in the decoder sub-class. Provide a common shared helper function to do the actual work and delegating further to the sub-class. 2013-03-21 13:41:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: decoder: get rid of GstVaapiDecoderUnit::buffer field. Drop GstVaapiDecoderUnit buffer field (GstBuffer) since it's totally useless nowadays as creating sub-buffers doesn't bring any value. It actually means more memory allocations. We can't do without that in JPEG and MPEG-4:2 decoders. 2013-03-21 13:28:05 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: sanitize uses of codec frame input buffer (cosmetics). Alias GST_VAAPI_DECODER_CODEC_FRAME(decoder)->input_buffer to a simple "buffer" variable. 2013-03-20 17:34:38 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: add helper function to apply a composition buffer. Simplify application of a composition buffer to a GstVaapiSurface, and all its peers, until that function is eventually promoted to libgstvaapi. 2013-03-20 13:42:15 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix support for raw YUV buffers. If the raw YUV buffer was created from vaapisink, through the buffer_alloc() hook, then it will have a valid GstVaapiVideoMeta object attached to it. However, we previously assumed in that case that it was a "native" VA buffer, thus not calling into GstVaapiUploader::process(). 2013-03-20 18:41:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: use modern GstElement metadata information. Use gst_element_class_set_static_metadata() from GStreamer 1.0, which basically is the same as gst_element_class_set_details_simple() in GStreamer 0.10 context. 2013-03-20 18:04:39 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: move up interfaces (cosmetics). Move GstImplementsInterface and GstVideoContext support functions up so that to keep a clear separation between the plugin element and its interface hooks. 2013-03-20 12:57:18 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiuploader.c: plugins: upgrade to newer APIs (GstVideoInfo based helpers). Use GstVideoInfo and gst_video_info_from_caps() helper wherever possible. Also use the newly added gst_vaapi_image_format_from_structure() helper in GstVaapiUploader::ensure_allowed_caps(). 2013-03-20 14:02:48 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbuffer.c: plugins: fix creation of video buffer from another source buffer. gst_vaapi_video_buffer_new_from_buffer() needs to reference the source buffer video meta since it would be unreference'd from the get_buffer() helper function. For other cases, we still use (steal) the newly created video meta. 2013-03-20 11:57:03 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginutil.c: plugins: include "sysdeps.h" header instead of "config.h". 2013-03-20 18:33:23 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * tests/codec.c: tests: modernize GstTypeFind functions. Use the GstTypeFind hooks from GStreamer 1.0. They look safer and exactly correspond to the expected behaviour. 2013-03-20 11:57:57 +0100 Gwenole Beauchesne * tests/image.c: * tests/image.h: * tests/test-decode.c: * tests/test-display.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-jpeg.c: * tests/test-jpeg.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-mpeg4.c: * tests/test-mpeg4.h: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-vc1.h: * tests/test-windows.c: tests: fix license templates. 2013-03-20 11:53:59 +0100 Gwenole Beauchesne * tests/test-display.c: tests: use gst_vaapi_image_format_from_structure() in test-display. Use gst_vaapi_image_format_from_structure() helper in test-display and then extract a VAImageFormat from it instead of relying on GstCaps for YUV and RGB formats. 2013-03-20 11:50:15 +0100 Gwenole Beauchesne * tests/codec.c: * tests/decoder.c: * tests/output.c: * tests/test-decode.c: * tests/test-display.c: * tests/test-subpicture.c: * tests/test-textures.c: * tests/test-windows.c: tests: include "sysdeps.h" header instead of "config.h". 2013-03-20 18:25:05 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: subpicture: use gst_video_overlay_rectangle_get_pixels_unscaled_raw(). Use newer gst_video_overlay_rectangle_get_pixels_unscaled_raw() helper function with GStreamer 0.10 compatible semantics, or that tries to approach the current meaning. Basically, this is also just about moving the helper to gstcompat.h. 2013-03-20 11:10:31 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: image: add gst_vaapi_image_format_from_structure() helper. Add helper function to convert video formats from a GstStructure to a plain GstVaapiImageFormat. 2013-03-20 18:12:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstcompat.h: * gst-libs/gst/vaapi/sysdeps.h: sysdeps: split out GStreamer API compatibility glue to "gstcompat.h". 2013-03-20 11:56:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/sysdeps.h: sysdeps: add more standard includes by default. 2013-03-20 14:43:46 +0100 Gwenole Beauchesne * configure.ac: configure: improve GStreamer API version checks. 2013-03-20 11:44:10 +0100 Gwenole Beauchesne * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/changelog.in: * debian.upstream/control.in: * debian.upstream/gstreamer-vaapi-doc.install.in: * debian.upstream/libgstvaapi-dev.install.in: * debian.upstream/libgstvaapi-drm.install.in: * debian.upstream/libgstvaapi-glx.install.in: * debian.upstream/libgstvaapi-wayland.install.in: * debian.upstream/libgstvaapi-x11.install.in: * debian.upstream/libgstvaapi.install.in: * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/plugins/Makefile.am: * docs/reference/plugins/plugins-docs.xml.in: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/Makefile.am: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-drm.pc.in: * pkgconfig/gstreamer-vaapi-glx.pc.in: * pkgconfig/gstreamer-vaapi-wayland.pc.in: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: * tests/Makefile.am: configure: rename GST_MAJORMINOR to GST_API_VERSION. 2013-03-20 11:28:06 +0100 Gwenole Beauchesne * configure.ac: configure: improve check for H.264 codecparser. 2013-02-26 00:38:24 +0100 Holger Kaelberer * gst/vaapi/gstvaapiuploader.c: vaapiupload: fix illegal write in ensure_image(). Fix ensure_image() to only zero-initialize the first line of each plane. Properly initializing each plane to their full vertical resolution would require to actually compute it based on the image format. In particular, for NV12 images, the UV plane has half vertical resolution vs. the Y plane. So using the full image height to initialize the UV plane will obviously lead to a buffer overflow. Likewise for other YUV format. Since ensure_image() is only a helper function to initialize something, and not necessarily the whole thing, it is fine to initializ the first line only. Besides, the target surface is not rendered either. Signed-off-by: Gwenole Beauchesne 2013-02-17 16:28:47 +0800 Xiang, Haihao * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/video/Makefile.am: build: fix compiling of local GstVideoDecoder and codecparsers. Generated source files were missing a dependency on the complete set of generated header files. e.g. gstvideodecoder.c requires gstvideoutils.h to build and almost every codec parser source depends on parserutils.h. https://bugs.freedesktop.org/show_bug.cgi?id=59575 Signed-off-by: Xiang, Haihao Signed-off-by: Gwenole Beauchesne 2013-02-08 11:56:54 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: set {luma,chroma}_log2_weight_denom to 0 if no pred_weight_table(). Force luma_log2_weight_denom and chroma_log2_weight_denom to zero if there is no pred_weight_table() that was parsed. This is a workaround for the VA intel-driver on Ivy Bridge. 2013-02-07 15:42:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: use new profile definitions from codecparsers. 2013-02-07 15:29:44 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 500bc02. 500bc02 h264: add profile enums 2013-02-06 15:27:18 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-02-06 15:21:27 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 31b1c57. 8957fb7 mpeg2: add helpers to convert quantization matrices 07c4034 mpeg2: store quantization matrices in zigzag scan order 2013-01-31 11:32:24 +0100 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: fix build on older platforms. Make simple-decoder build and execute correctly on older platforms, and more precisely older versions of glib. 2013-01-31 11:30:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: glibcompat: add replacement for g_async_queue_timeout_pop(). g_async_queue_timeout_pop() appeared in glib 2.31.18. Implement it as g_async_queue_timed_pop() with a GTimeVal as the final time to wait for new data to arrive in the queue. 2013-01-31 11:25:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: glibcompat: add replacement for g_cond_wait(). 2013-01-30 18:38:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix decoding of 4K videos. Account for slice_vertical_position_extension when vertical_size > 2800. 2013-01-30 18:54:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix decoding of sequence_end(). There shall be only one place to call decode_current_picture(), and this is in the end_frame() hook. The EOS unit is processed after end_frame() so this means we cannot have a valid picture to decode/output at this point. 2013-01-30 15:10:06 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: improve robustness when packets are missing. Improve robustness when some expected packets where not received yet or that were not correctly decoded. For example, don't try to decode a picture if there was no valid sequence or picture headers. 2013-01-30 18:58:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: handle decode-only frames in raw API mode. Fix gst_vaapi_decoder_get_surface() to only return frames with a valid surface proxy, i.e. with a valid VA surface. This means that any frame marked as decode-only is simply skipped. 2013-01-30 16:33:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: allow frames to be dropped. If the decoder was not able to decode a frame because insufficient information was available, e.g. missing sequence or picture header, then allow the frame to be gracefully dropped without generating any error. It is also possible that a frame is not meant to be displayed but only used as a reference, so dropping that frame is also a valid operation since GstVideoDecoder base class has extra references to that GstVideoCodecFrame that needs to be released. 2013-01-30 16:26:07 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: handle decode-only frames. Decode-only frames may not have a valid surface proxy. So, simply discard them gracefully, i.e. don't create meta data information. GstVideoDecoder base class will properly handle this case and won't try to push any buffer to downstream elements. 2013-01-24 00:49:17 +0200 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: add support for post-seek semantics reset. Implement GstVideoDecoder::reset() as a destruction of the VA decoder and the creation of a new VA decoder. Signed-off-by: Gwenole Beauchesne 2013-01-30 09:38:07 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-01-30 09:37:38 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.1. 2013-01-24 00:48:26 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: implement GstVaapiDecoder::flush() as a DPB flush. 2013-01-24 17:34:43 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: decoder: fix documentation for GstVaapiDecoderFrame. Drop superfluous reference to prev_slice member. 2013-01-29 16:18:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: assume current frame is complete at end-of-stream. Assume we got a complete frame when the end-of-stream is reached and that the current codec frame contains at least one slice data unit. 2013-01-29 14:14:45 +0100 Gwenole Beauchesne * NEWS: * README: * debian.upstream/copyright: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_frame.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/sysdeps.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginbuffer.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: * tests/output.c: * tests/test-decode.c: * tests/test-subpicture.c: legal: fix year for some copyright notices (2013). 2013-01-29 14:03:27 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.h: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapisink.h: * tests/test-subpicture.c: legal: fix year for some copyright notices (2012). 2013-01-29 14:00:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * tests/test-display.c: * tests/test-surfaces.c: * tests/test-windows.c: legal: add Intel copyright on modified files. 2013-01-29 13:37:41 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-01-28 18:09:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: use a local event queue to avoid lock contention. This improves performance when rendering several surfaces from within the same process. e.g. a tee of vaapidecode'd buffers to vaapisink. 2013-01-28 17:28:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: fix thread-safe issues. The Wayland API is not fully thread-safe and client applications shall perform locking themselves on key functions. Besides, make sure to release the lock if the _render() function fails. 2013-01-28 16:37:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: really wait until the pending redraw completed. Introduce gst_vaapi_window_wayland_sync() helper function to wait for the completion of the redraw request. Use it in _render() function to actually block until the previous draw request is completed. 2013-01-23 10:10:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: fix frame_redraw callback. The redraw callback needs to be attached to the surface prior to the commit. Otherwise, the callback notifies the next surface repaint, which is not the desired behaviour. i.e. we want to be notified for the surface we have just filled. Another isse was the redraw_pending was reset before the actual completion of the frame redraw callback function, thus causing concurrency issues. e.g. the callback could have been called again, but with a NULL buffer. 2013-01-28 14:45:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: fix display sharing. When the Wayland display is shared, we still have to create our own local shell and compositor objects, since they are not propagated from the cache. Likewise, we also need to determine the display size or vaapisink would fail to account for the display aspect ratio, and will try to create a 0x0 window. 2013-01-24 17:38:53 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 21a098e. 21a098e vc1: fix bitplanes decoding (DIFF6 or NORM6) [residual] f8c836a vc1: fix bitplanes decoding (DIFF6 or NORM6) 2013-01-23 16:38:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: handle frames with multiple slices. 2013-01-23 17:01:34 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 3fba492. 3fba492 vc1: add API to parse slice headers 2013-01-23 11:11:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: handle CLOSED_ENTRY. When CLOSED_ENTRY == 0, and if the B pictures that follow an entry-point lack a reference anchor picture, these B pictures shall be discarded. https://bugs.freedesktop.org/show_bug.cgi?id=59505 2013-01-23 10:25:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: cope with latest codecparser changes. Fix build with newer VC-1 codecparser where dqsbedge was renamed to dqbedge, and now represents either DQSBEDGE or DQDBEDGE depending on the actual value of DQPROFILE. 2013-01-23 10:24:04 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 3d2c67c. 3d2c67c vc1: simplify GstVC1VopDquant structure 2013-01-22 10:51:40 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit 5d33da8. 5d33da8 vc1: fix bitplanes decoding 562bdc4 vc1: fix VOPDQUANT parser for DQUANT == 2 0b13d2b vc1: fix calculation of ALTPQUANT ba88e63 vc1: fix parser for DQPROFILE in VOPDQUANT 2013-01-22 15:47:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix size of encapsulated BDU. Fix size of encapsulated BDUs since GstVC1BDU.size actually represents the size of the BDU data, starting from offset, i.e. after any start code is parsed. This fixes a buffer overflow during the unescaping process. 2013-01-11 17:08:00 +0800 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix decoding of WMV3 videos in AVI format. The AVI demuxer (avidemux) does not set a proper "format" attribute to the generated caps. So, try to recover the video codec format from the "wmvversion" property instead. Signed-off-by: Gwenole Beauchesne 2013-01-22 13:28:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: review and report errors accordingly. Use GST_ERROR() to report real errors instead of hiding them into GST_DEBUG(). 2013-01-22 13:50:39 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: don't create GstBuffers for all decoder units. Don't create temporary GstBuffers for all decoder units, even if they are lightweight "sub-buffers", since it is not really necessary to keep the buffer data around. 2013-01-22 16:03:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: implement flush() hook. Make it a simple DPB flush. 2013-01-22 13:44:32 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: implement {start,end}_frame() hooks. Implement GstVaapiDecoder.start_frame() and end_frame() semantics so that to create new VA context earlier and submit VA pictures to the HW for decoding as soon as possible. i.e. don't wait for the next frame to start decoding the previous one. 2013-01-22 09:30:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix next POC for new sequence layers. Fix next POC when a new sequence layer is reached. At this point, we need to reset any previous reference picture, i.e. non B-frame. 2012-08-02 17:15:26 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: port to common GstVaapiDpb interface. Use GstVaapiDpb interface instead of maintaining our own prev and next picture pointers. While doing so, try to derive a sensible POC value. Signed-off-by: Gwenole Beauchesne 2013-01-15 17:10:56 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix decode_sequence_end() to return success, not EOS. 2013-01-18 17:00:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: simplify gst_vaapi_decoder_get_surface(). Avoid extraenous branches, i.e. immediately return with success once we have a decoded frame available. 2013-01-18 16:56:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: optimize and clean decode_step() up. Avoid usage of goto. Simplify decode_step() process to first accumulate all pending buffers into the GstAdapter, and then parse and decode units from that input adapter. Stop the process once a frame is fully decoded or an error occurred. 2013-01-18 14:46:23 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: move "vaapi" debug init to libgstvaapi_init_once(). 2013-01-18 14:17:34 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiversion.h.in: display: dump gstreamer-vaapi version for debugging purposes. 2013-01-18 14:30:48 +0100 Gwenole Beauchesne * tests/Makefile.am: tests: simple-decoder: fix build with built-in videoutils. Fix build with built-in videoutils, i.e. when system GStreamer installation does not know about GstVideoDecoder API. 2013-01-18 10:35:44 +0100 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: flush decoded frames at EOS. Flush the remaining decoded frames when an end-of-stream is reached. 2013-01-18 10:25:14 +0100 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: drop use of GstVaapiVideoMeta. Don't use GstVaapiVideoMeta since that object is not guaranteed to live in libgstvaapi forever. Rather, that'd move to plugin elements at some point. 2013-01-16 13:53:43 +0100 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: add benchmark mode. Add --benchmark option to enable benchmark mode where rendering is not synchronized with presentation timestamps of the decoded surfaces. 2013-01-16 13:29:06 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/simple-decoder.c: tests: simple-decoder: honour framerate from the bitstream. Try to honour the framerate from the bitstream, or cap the playback to 60 fps by default. 2013-01-15 18:49:28 +0100 Gwenole Beauchesne * tests/simple-decoder.c: tests: simple-decoder: set window size to the surface dimensions. Set the window size to the decoded surface dimensions, if the user has not requested the application to run in full-screen mode. Besides, no effort is made to preserve aspect ratio or to center the video within the mapped window. 2013-01-15 17:33:18 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/simple-decoder.c: tests: add simple decoder application. Add simple decoder application to show off decoding capabilities from raw bitstreams, for debugging or performance evaluation purposes. 2013-01-15 17:30:57 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/codec.c: * tests/codec.h: tests: add codec helper utils. Add helper functions to determine the codec type from a specific file or utility functions to convert from codec type to GstCaps or from codec name to codec type. 2013-01-15 17:47:13 +0100 Gwenole Beauchesne * tests/output.c: tests: allow fullscreen mode. Add new --fullscreen|-f option to create new windows in fullscreen mode. 2013-01-17 18:35:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: implement GstVaapiDecoder::flush() as a DPB flush. 2013-01-17 18:07:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: handle end-of-stream NALU. Handle NAL unit to actually flush any pending picture from the DPB. 2013-01-17 18:22:49 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: handle EOS events. Flush all decoded frames to downstream when EOS is received. This is performed by implementing GstVideoDecoder::finish() hook. 2013-01-17 18:19:14 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: split gvd_handle_frame() into decode/push frames. Split GstVideoDecoder::handle_frame() implementation into two functions: (i) one for decoding the provided GstVideoCodecFrame and (ii) another one for purging all decoded frames and submit them downstream. 2013-01-17 18:33:32 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: decoder: add GstVaapiDecoder::flush() hook. 2013-01-15 17:21:50 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: fix check for end-of-stream in raw API mode. Make sure to immediately return GST_VAAPI_DECODER_STATUS_END_OF_STREAM if the end-of-stream was already reached at the previous iteration. 2013-01-15 16:55:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: make decode_step() return once the frame is decoded. Make sure we always have a free surface left to use for decoding the current frame. This means that decode_step() has to return once a frame gets decoded. If the current adapter contains more buffers with valid frames, they will get parsed and decoded on subsequent iterations. 2013-01-17 15:47:17 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-branch commit b47983a. 8840c2d h264: zero-initialize SPS VUI parameters 2013-01-15 09:21:36 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2013-01-15 09:21:08 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.5.0. 2013-01-14 11:48:58 +0100 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: docs: expose new interfaces. 2013-01-14 12:58:20 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2013-01-14 10:58:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: dpb: cosmetics (clean-ups). 2013-01-14 10:46:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: dpb: port to GstVaapiMiniObject. 2013-01-14 10:21:53 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: dpb: drop GstVaapiDpb2 interface, keep only one class. Keep only one DPB interface and rename gst_vaapi_dpb2_get_references() to gst_vaapi_dpb_get_neighbours() so that to retrieve pictures in DPB around the specified picture POC. 2012-08-02 15:56:54 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: dpb: rename GstVaapiDpbMpeg2 to GstVaapiDpb2. Move GstVaapiDpbMpeg2 API to a more generic version that could also be useful to other decoders that require 2 reference pictures, e.g. VC-1. Signed-off-by: Gwenole Beauchesne 2013-01-11 16:04:30 +0100 Gwenole Beauchesne * configure.ac: Bump version for pre-release. 2013-01-11 15:57:09 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-07-20 12:36:33 +0200 Holger Kaelberer * configure.ac: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/sysdeps.h: * tests/test-subpicture.c: overlay: fix build without advanced GstVideoOverlayFormatFlags. Check for global-alpha support in GstVideoOverlayComposition API. Signed-off-by: Gwenole Beauchesne 2013-01-04 10:19:56 +0100 Gwenole Beauchesne * tests/test-subpicture.c: tests: add support for global-alpha subpictures. Add --global-alpha option to test-subpicture. 2013-01-10 13:09:28 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/test-subpicture.c: tests: use GstVideoOverlayComposition API for subpicture test. 2013-01-10 11:26:17 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/test-subpicture.c: tests: use common decoder helpers for subpicture test. Use common decoder helpers for subpicture test, thus allowing to decode sample images in an alternate format. 2013-01-10 11:22:38 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/decoder.c: * tests/decoder.h: * tests/test-decode.c: tests: add decoder helpers. 2013-01-11 15:19:45 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: fix ordering of composition layers. Make sure to maintain the association order of composition layers when GstVideoOverlayRectangle objects are kept around (cached). 2012-05-15 10:24:08 +0200 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: fix support for global-alpha. Fix support for global-alpha subpictures. The previous changes brought the ability to check for GstVideoOverlayRectangle changes by comparing the underlying pixel buffer pointers. If sequence number and pixel data did not change, then this is an indication that only the global-alpha value changed. Now, try to update the underlying VA subpicture global-alpha value. Signed-off-by: Gwenole Beauchesne 2013-01-11 11:53:05 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: detect render-rect changes. Don't re-upload VA subpicture if only the render rectangle changed. Rather deassociate the subpicture and re-associate it with the new render rectangle. 2013-01-11 11:12:26 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: fix check for pixels buffer change. A GstVideoOverlayRectangle is created whenever the underlying pixels data change. However, when global-alpha is supported, it is possible to re-use the same GstVideoOverlayRectangle but with a change to the global-alpha value. This process causes a change of sequence number, so we can no longer check for that. Still, if sequence numbers did not change, then there was no change in global-alpha either. So, we need a way to compare the underlying GstBuffer pointers. There is no API to retrieve the original pixels buffer from a GstVideoOverlayRectangle. So, we use the following heuristics: 1. Use gst_video_overlay_rectangle_get_pixels_unscaled_argb() with the same format flags from which the GstVideoOverlayRectangle was created. This will work if there was no prior consumer of the GstVideoOverlayRectangle with alternate (non-"native") format flags. 2. In overlay_rectangle_has_changed_pixels(), we have to use the same gst_video_overlay_rectangle_get_pixels_unscaled_argb() function but with flags that match the subpicture. This is needed to cope with platforms that don't support global-alpha in HW, so the gst-video layer takes care of that and fixes this up with a possibly new GstBuffer, and hence pixels data (or) in-place by caching the current global-alpha value applied. So we have to determine the rectangle was previously used, based on what previous flags were used to retrieve the ARGB pixels buffer. 2013-01-10 18:42:37 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: optimize cache at the GstVideoOverlayRectangle level. We previously assumed that an overlay composition changed if the number of overlay rectangles in there actually changed, or that the rectangle was updated, and thus its seqnum was also updated. Now, we can cope with cases where the GstVideoOverlayComposition grew by one or a few more overlay rectangles, and the initial overlay rectangles are kept as is. 2013-01-10 13:41:39 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: overlay: simplify caching of GstVideoOverlayComposition objects. Create the GPtrArray once in the _init() function and destroy it only in the _finalize() function. Then use overlay_clear() to remove all subpicture associations for intermediate updates, don't recreate the GPtrArray. Make GstVaapiOverlayRectangle a reference counted object. Also make sure that overlay_rectangle_new() actually creates and associates the VA subpicture. 2012-05-15 10:24:08 +0200 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: overlay: add support for global-alpha. Handle global-alpha from GstVideoOverlayComposition API. Likewise, the same code path could also work for premultiplied-alpha but this was not tested. Signed-off-by: Gwenole Beauchesne 2012-05-15 10:24:08 +0200 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * tests/image.c: * tests/test-subpicture.c: subpicture: add support for global-alpha. Add the necessary helpers in GstVaapiDisplay to determine whether subpictures with global alpha are supported or not. Also add accessors in GstVaapiSubpicture to address this feature. Signed-off-by: Gwenole Beauchesne 2013-01-04 09:41:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: subpicture: add premultiplied-alpha and global-alpha feature flags. Add premultiplied-alpha and global-alpha feature flags, along with converters between VA-API and gstreamer-vaapi definitions. Another round of helpers is also necessary for GstVideoOverlayComposition API. 2013-01-03 18:02:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: allow image/subpicture formats with additional flags. Introduce new GstVaapiFormatInfo to store the actual GstVaapiImageFormat and any additional flags needed. Currently, all flags are set to zero. 2013-01-11 13:34:45 +0100 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/video/Makefile.am: * tests/Makefile.am: libs: fix build of submodule wrappers. Make sure to build codecparsers/ and videoutils/ sources against the newly generated headers when out-of-source builds are used. 2013-01-11 14:11:39 +0100 Gwenole Beauchesne * configure.ac: configure: fix checks for packages installed in non-standard roots. 2013-01-10 10:12:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiminiobject.c: decoder: fix mini object implementation on 64-bit systems. Use GPOINTER_TO_SIZE() instead of GPOINTER_TO_UINT() while manipulating pointers. The latter is meant to be 32-bit only, not uintptr_t like size. Only a gsize can hold all bits of a pointer. Thanks to Ouping Zhang for spotting this error. 2013-01-09 16:05:39 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: optimize scan for the end of the frame. Heuristic: if the second start-code is available, check whether that one marks the start of a new frame because e.g. this is a sequence or picture header. This doesn't save much, since we already cache the results. 2013-01-09 13:44:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: optimize scan for start codes. Accelerate scan for start codes by skipping up to 3 bytes per iteration. A start code prefix is defined by the following bytes: 00 00 01. Thus, for any group of 3 bytes (xx yy zz), we have the following possible cases: 1. If zz != 1, this cannot be a start code, then skip 3 bytes; 2. If yy != 0, this cannot be a start code, then skip 2 bytes; 3. If xx != 0 or zz != 1, this cannot be a start code, then skip 1 byte; 4. xx == 00, yy == 00, zz == 1, we have match! This algorithm requires to peek bytes from the adapter. This increases the amount of bytes copied to a temporary buffer, but this process is much faster than scanning for all the bytes and using shift/masks. So, overall, this is a win. 2013-01-08 16:41:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: drop useless gst_adapter_peek(). Drop useless gst_adapter_peek() since the returned buffer was not used and this could incur superfluous memcpy(). 2013-01-07 16:07:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: cosmetics: move parse_slice() down. 2013-01-07 15:24:51 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: avoid too many allocations of parser info objects. Move parsing back to decoding step, but keep functions separate for now. This is needed for future optimizations that may introduce some meta data for parsed info attached to codec frames. 2013-01-07 14:04:22 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: decoder: decoder units are no longer dynamically allocated objects. 2013-01-07 13:59:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: decoder: optimize pre-allocation of decoder units. Optimize pre-allocation of decoder units, thus avoiding un-necessary memory reallocations. The heuristic used is that we could have around one slice unit per macroblock line. 2013-01-07 13:41:59 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: decoder: use an array of units instead of a single-linked list. Use a GArray to hold decoder units in a frame, instead of a single-linked list. This makes 'append' calls faster, but not that much. At least, this makes things clearer. 2013-01-07 11:13:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: refactor decoder unit API. Allocate decoder unit earlier in the main parse() function and don't delegate this task to derived classes. The ultimate purpose is to get rid of dynamic allocation of decoder units. 2013-01-07 10:48:27 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: introduce parser info instead of MPEG-2 specific decoder unit. Use a new GstVaapiParserInfoMpeg2 data structure instead of deriving from GstVaapiDecoderUnit for MPEG-2 specific parser information. 2013-01-07 10:22:54 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: introduce parser info instead of H.264 specific decoder unit. Use a new GstVaapiParserInfoH264 data structure instead of deriving from GstVaapiDecoderUnit for H.264 specific parser information. 2013-01-05 12:33:06 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: set default values for some header fields. The SPS, PPS and slice headers are not fully zero-initialized in the codecparsers/ library. Rather, the standard upstream behaviour is to initialize only certain syntax elements with some inferred values if they are not present in the bitstream. At the gstreamer-vaapi decoder level, we need to further initialize certain syntax elements with some sensible default values so that to not complicate VA drivers that just pass those verbatim to the HW, and also avoid an memset() of the whole decoder unit. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2013-01-06 19:05:49 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-rebased commit b47983a. b47983a h264: add inferred value for slice_beta_offset_div2 2013-01-05 17:55:47 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginbuffer.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiuploader.c: plugins: cope with new GstVaapiVideoMeta API. Update plugin elements with the new GstVaapiVideoMeta API. This also fixes support for subpictures/overlay because GstVideoDecoder generates a sub-buffer from the GstVaapiVideoBuffer. So, that sub-buffer is marked as read-only. However, when comes in the textoverlay element for example, it checks whether the input buffer is writable. Since that buffer read-only, then a new GstBuffer is created. Since gst_buffer_copy() does not preserve the parent field, the generated buffer in textoverlay is not exploitable because we lost all VA specific information. Now, with GstVaapiVideoMeta information attached to a standard GstBuffer, all information are preserved through gst_buffer_copy() since the latter does copy metadata (qdata in this case). 2013-01-05 17:37:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_priv.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: videobuffer: wrap video meta into a surface buffer. Make GstVaapiVideoBuffer a simple wrapper for video meta. This buffer is no longer necessary but for compatibility with GStreamer 0.10 APIs or users expecting a GstSurfaceBuffer like Clutter. 2013-01-05 08:31:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideometa.c: * gst-libs/gst/vaapi/gstvaapivideometa.h: videobuffer: add video meta information. Add new GstVaapiVideoMeta object that holds all information needed to convey gst-vaapi specific data as a GstBuffer. 2013-01-03 13:10:33 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix calculation of the time-out value. Fix calculation of the time-out value for cases where no VA surface is available for decoding. In this case, we need to wait until downstream sink consumed at least one surface. The time-out was miscalculated as it was always set to + one second, which is not suitable for streams with larger gaps. 2013-01-03 13:05:47 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: always use the calculated presentation timestamp. Use PTS value computed by the decoder, which could also be derived from the GstVideoCodecFrame PTS. This makes it possible to fix up the PTS if the original one was miscomputed or only represented a DTS instead. 2013-01-02 17:33:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: don't create sub-buffer for slice data. 2013-01-03 11:16:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: create new context when encoded resolution changes. Create a new VA context if the encoded surface size changes because we need to keep the underlying surface pool until the last one was released. Otherwise, either of the following cases could have happened: (i) release a VA surface to an inexistent pool, or (ii) release VA surface to an existing surface pool, but with different size. 2013-01-02 17:23:53 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: don't create sub-buffer for slice data. Avoid creating a GstBuffer for slice data. Rather, directly use the codec frame input buffer data. This is possible because the codec frame is valid until end_frame() where we submit the VA buffers for decoding. Anyway, the slice data buffer is copied into the VA buffer when it is created. 2013-01-02 14:45:50 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: minor clean-ups. Drop explicit initialization of most fields that are implicitly set to zero. Remove some useless checks for NULL pointers. 2013-01-02 14:18:31 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: optimize scan for the second start code. Optimize scan for the second start code, on the next parse() call so that to avoid scanning again earlier bytes where we didn't find any start code. 2013-01-02 14:10:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: use sequence_display_extension() to compute PAR. Also compute pixel-aspect-ratio from sequence_display_extension(), should it exist in the bitstream. 2013-01-02 14:02:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: handle sequence_display_extension(). 2012-12-27 15:18:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: implement {start,end}_frame() hooks. Implement GstVaapiDecoder.start_frame() and end_frame() semantics so that to create new VA context earlier and submit VA pictures to the HW for decoding as soon as possible. i.e. don't wait for the next frame to start decoding the previous one. 2012-12-27 14:54:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: parse slice() header earlier. Parse slice() header and first macroblock position earlier in _parse() function instead of waiting for the _decode() stage. This doesn't change anything but readability. 2012-12-27 14:41:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: add codec specific decoder unit. Introduce new GstVaapiDecoderUnitMpeg2 object, which holds the standard GstMpegVideoPacket and additional parsed header info. Besides, we now parse as early as in the _parse() function so that to avoid un-necessary creation of sub-buffers in _decode() for video packets that are not slices. 2012-12-27 18:52:43 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: decoder: introduce lists of units to decode before/after frame. Theory of operations: all units marked as "slice" are moved to the "units" list. Since this list only contains slice data units, the prev_slice pointer was removed. Besides, we now maintain two extra lists of units to be decoded before or after slice data units. In particular, all units in the "pre_units" list will be decoded before GstVaapiDecoder::start_frame() is called and units in the "post_units" list will be decoded after GstVaapiDecoder::end_frame() is called. 2013-01-02 16:06:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: drop useless checks for codec objects. Codec objects are used internally only and they are bound to be created with a valid GstVaapiDecoder object. 2012-12-27 10:35:45 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: use GST_ERROR to print error messages. 2012-12-27 09:55:14 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: avoid double release of frame on error. Don't call gst_video_decoder_drop_frame() if gst_video_decoder_finish_frame() was already called before and it returned an error. In that case, we were releasing the frame again, thus leading to a "double-free" condition. 2012-12-21 14:29:01 +0100 Gwenole Beauchesne * .gitmodules: * autogen.sh: * configure.ac: * ext/Makefile.am: * ext/videoutils: * gst-libs/gst/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/video/Makefile.am: * gst/vaapi/Makefile.am: Add videoutils submodule for GstVideoDecoder APIs. 2012-12-18 16:36:01 +0100 Gwenole Beauchesne * configure.ac: configure: check for GstVideoDecoder API. GstVideoDecoder API is part of an unreleased GStreamer 0.10 stack. In particular, this is only available in git 0.10 branch or GStreamer >= 1.0 stack. Interested parties may either use upstream git 0.10 branch or backport the necessary support for GstVideoDecoder API, thus including helper tools like GstVideoCodecFrame et al. 2012-12-18 16:21:31 +0100 Gwenole Beauchesne * docs/reference/libs/libs.core.types: docs: remove obsolete gst_vaapi_surface_proxy_get_type(). GstVaapiSurfaceProxy is no longer based on the GType system. 2012-12-18 16:17:22 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: docs: fix entries for GstVaapiSurfaceProxy. 2012-12-18 15:29:58 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-12-18 15:15:52 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: Bump library major version. Increase library major so that to cope with API/ABI incompatible changes since 0.4.x series and avoid user issues. 2012-12-13 16:02:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: surfaceproxy: minor clean-ups. 2012-12-13 15:51:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: surfaceproxy: drop accessors to obsolete attributes. Make GstVaapiSurfaceProxy only a thin wrapper around a VA context and a VA surface. i.e. drop any other attribute like timestamp, duration, interlaced or top-field-first. 2012-12-13 15:34:10 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst/vaapi/gstvaapidecode.c: decoder: maintain decoded frames as GstVideoCodecFrame objects. Maintain decoded surfaces as GstVideoCodecFrame objects instead of GstVaapiSurfaceProxy objects. The latter will tend to be reduced to the strict minimum: a context and a surface. 2012-12-13 14:30:18 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: output all decoded frames as soon as possible. Make sure to push all decoded frames downstream as soon as possible. This makes sure we don't need to wait for a new frame to be ready to be decoded before receiving new decoded frames. This also separates the decode process and the output process. The latter could be moved to a specific GstTask later on. 2012-12-13 14:27:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: decoder: add gst_vaapi_decoder_get_frame() API. Add new gst_vaapi_decoder_get_frame() function meant to be used with gst_vaapi_decoder_decode(). The purpose is to return the next decoded frame as a GstVideoCodecFrame and the associated GstVaapiSurfaceProxy as the user-data object. 2012-12-13 15:47:27 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: use GstBuffer flags for TFF. Determine whether the buffer represents the top-field only by checking for the GST_VIDEO_BUFFER_TFF flag instead of relying on the GstVaapiSurfaceProxy flag. Also trust "interlaced" caps to determine whether the input frame is interleaved or not. 2012-12-13 13:27:33 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: handle video sub-buffers. Intermediate elements may produce a sub-buffer from a valid GstVaapiVideoBuffer for non raw YUV cases. Make sure vaapipostproc now understands those buffers. 2012-12-18 14:57:36 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: optimize initialization process of decoder units. Decoder units were zero-initialized, including the SPS/PPS/slice headers. The latter don't require zero-initialization since the codecparsers/ lib will do so for key variables already. This is not a great value per se but at least it makes it possible to check whether the default initialization decisions made in the codecparsers/ lib were right or not. This can be reverted if this exposes too many issues. 2012-12-13 11:48:06 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: minor clean-ups. Drop explicit initialization of most fields that are implicitly set to zero. Drop helper macros for casting to GstVaapiPictureH264 or GstVaapiFrameStore. Also remove some useless checks for NULL pointers. 2012-12-07 17:45:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: drop GstVaapiSliceH264 object. Use standard GstVaapiSlice object from now on since we already have parsed and recorded the slice headers (GstH264SliceHdr decode units). 2012-12-13 10:47:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: detect new pictures from decode-units. Update is_new_picture() to cope with GstVaapiDecoderUnitH264, instead of assuming frame boundaries when first_mb_in_slice is zero. 2012-12-13 10:21:46 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: implement {start,end}_frame() hooks. Implement GstVaapiDecoder.start_frame() and end_frame() semantics so that to create new VA context earlier and submit VA pictures to the HW for decoding as soon as possible. i.e. don't wait for the next frame to start decoding the previous one. 2012-12-12 18:33:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: optimize scan for the second start code. Optimize scan for the second start code, on the next parse() call so that to avoid scanning again earlier bytes where we didn't find any start code. 2012-12-06 17:25:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add codec specific decoder unit. Introduce new GstVaapiDecoderUnitH264 object, which holds the standard NAL unit header (GstH264NalUnit) and additional parsed header info. Besides, we now parse headers as early as in the _parse() function so that to avoid un-necessary creation of sub-buffers in _decode() for NAL units that are not slices. This is a performance win by ~+1.1% only. 2012-12-04 11:01:42 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: handle sub video-buffers. Intermediate elements may produce a sub-buffer from a valid GstVaapiVideoBuffer for non raw YUV cases. Make sure vaapisink now understands those buffers. 2012-12-12 15:22:32 +0100 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: vaapidecode: use gst_vaapi_decoder_get_codec_state(). Directly use the GstVideoCodecState associated with the VA decoder instead of parsing caps again. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2012-12-04 14:53:15 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: use more standard helpers. Use g_clear_object() [glib >= 2.28] and gst_caps_replace() helper functions in more places. 2012-12-04 14:45:29 +0100 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: move to GstVideoDecoder base class. Make vaapidecode derive from the standard GstVideoDecoder base element class. This simplifies the code to the strict minimum for the decoder element and makes it easier to port to GStreamer 1.x API. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2012-12-06 14:02:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: initial port to new GstVaapiDecoder API 2012-12-06 14:02:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: initial port to new GstVaapiDecoder API 2012-12-06 14:02:17 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: initial port to new GstVaapiDecoder API 2012-12-17 09:47:20 -0800 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: initial port to new GstVaapiDecoder API 2012-12-06 14:01:46 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: initial port to new GstVaapiDecoder API. 2012-12-12 15:09:21 +0100 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: decoder: use GstVideoCodecState. Use standard GstVideoCodecState throughout GstVaapiDecoder and expose it with a new gst_vaapi_decoder_get_codec_state() function. This makes it possible to drop picture size (width, height) information, framerate (fps_n, fps_d) information, pixel aspect ratio (par_n, par_d) information, and interlace mode (is_interlaced field). This is a new API with backwards compatibility maintained. In particular, gst_vaapi_decoder_get_caps() is still available. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2012-12-12 13:44:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * tests/test-decode.c: * tests/test-subpicture.c: decoder: update gst_vaapi_decoder_get_surface() semantics. Align gst_vaapi_decoder_get_surface() semantics with the rest of the API. That is, return a GstVaapiDecoderStatus and the decoded surface as a handle to GstVaapiSurfaceProxy in parameter. This is an API/ABI change. 2012-12-07 16:40:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: use standard helper functions. Use g_clear_object(), gst_buffer_replace() and gst_caps_replace() whenever necessary. 2012-11-29 15:06:00 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: expose new parse/decode API. Introduce new decoding process whereby a GstVideoCodecFrame is created first. Next, input stream buffers are accumulated into a GstAdapter, that is then passed to the _parse() function. The GstVaapiDecoder object accumulates all parsed units and when a complete frame or field is detected, that GstVideoCodecFrame is passed to the _decode() function. Ultimately, the caller receives a GstVaapiSurfaceProxy if decoding process was successful. 2012-12-13 10:20:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: decoder: add {start,end}_frame() hooks. The start_frame() hook is called prior to traversing all decode-units for decoding. The unit argument represents the first slice in the frame. Some codecs (e.g. H.264) need to wait for the first slice in order to determine the actual VA context parameters. 2012-12-06 13:57:42 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: add new GstVaapiDecoder API. Split decoding process into two steps: (i) parse incoming bitstreams into simple decoder-units until the frame or field is complete; and (ii) decode the whole frame or field at once. This is an ABI change. 2012-12-05 10:51:41 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_frame.c: * gst-libs/gst/vaapi/gstvaapidecoder_frame.h: decoder: add new "decoder-frame" object. Introduce a new GstVaapiDecoderFrame that is just a list of decoder units (GstVaapiDecoderUnit objects) that constitute a frame. This object is just an extension to GstVideoCodecFrame for VA decoder purposes. It is available as the user-data member element. This is a libgstvaapi internal object. 2012-12-06 09:44:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_unit.c: * gst-libs/gst/vaapi/gstvaapidecoder_unit.h: decoder: add new "decoder-unit" object. Introduce GstVaapiDecoderUnit which represents a fragment of the source stream to be decoded. For instance, a decode-unit will be a NAL unit for H.264 streams, an EBDU for VC-1 streams, and a video packet for MPEG-2 streams. This is a libgstvaapi internal object. 2012-12-03 14:09:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: Port GstVaapiFrameStore to GstVaapiMiniObject. 2012-12-03 11:19:08 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: Port codec objects to GstVaapiMiniObject. 2012-12-03 13:46:28 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginbuffer.c: * tests/test-decode.c: * tests/test-subpicture.c: surfaceproxy: port to GstVaapiMiniObject. GstVaapiSurfaceProxy does not use any particular functionality from GObject. Actually, it only needs a basic object type with reference counting. This is an API and ABI change. 2012-11-30 17:25:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiminiobject.c: * gst-libs/gst/vaapi/gstvaapiminiobject.h: Add GstVaapiMiniObject. Introduce a new reference counted object that is very lightweight and also provides flags and user-data functionalities. Initialization and finalization times are reduced by up to a factor 5x vs GstMiniObject from GStreamer 0.10 stack. This is a libgstvaapi internal object. 2012-12-17 02:51:17 -0800 Gwenole Beauchesne * tests/Makefile.am: * tests/test-decode.c: * tests/test-mpeg4.c: * tests/test-mpeg4.h: tests: add test for MPEG-4:2 decoding. 2012-12-17 04:42:29 -0800 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: initialize VA context before allocating the first slice. Fix decode_slice() to ensure a VA context exists prior to creating a new GstVaapiSliceH264, which invokes vaCreateBuffer() with some VA context ID. i.e. the latter was not initialized, thus causing failures on Cedar Trail for example. 2012-12-05 09:15:32 +0800 Zhao Halley * configure.ac: configure: install plugin elements in GST_PLUGIN_PATH, if set. If GST_PLUGIN_PATH environment variable exists and points to a valid directory, then use it as the system installation path for gst-vaapi plugin elements. Signed-off-by: Gwenole Beauchesne 2012-12-17 14:27:56 +0100 Gwenole Beauchesne * configure.ac: configure: downgrade glib required version to 2.28. 2012-12-17 09:41:24 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * gst/vaapi/gstvaapi.c: libs: fix compatibility with glib 2.28. Always prefer non deprecated APIs by default and provide compatibility glue for older glib versions when necessary. 2012-12-17 10:10:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: libs: use glib >= 2.32 semantics for mutexes. Use glib >= 2.32 semantics for GMutex and GRecMutex wrt. initialization and termination. Basically, the new mutex objects can be used as static mutex objects from the deprecated APIs, e.g. GStaticMutex and GStaticRecMutex. 2012-12-17 04:15:53 -0800 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: libs: only export gst_vaapi_*() symbols. This fixes symbol clashes between the gst-vaapi built-in codecparsers/ library and the system-provided one, mainly used by videoparses/. Now, only symbols with the gst_vaapi_* prefix will be exported, if they are not marked as "hidden" to libgstvaapi. 2012-11-20 18:21:41 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiuploader.c: vaapiupload: reset direct-rendering to zero when changing caps. Make sure to reset direct-rendering flag to zero when caps are changed, and only derive it to one when the next checks succeed. 2012-11-20 14:42:24 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiupload.c: vaapiupload: fix sink caps to report the supported set of YUV caps. Try to allocate the GstVaapiUploader helper object prior to listing the supported image formats. Otherwise, only a single generic caps is output with no particular pixel format referenced in there. 2012-11-20 14:32:40 +0100 Zhao Halley * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: vaapiupload: use new GstVaapiUploader helper. Use GstVaapiUploader helper that automatically handles direct rendering mode, thus making the "direct-rendering" property obsolete and hence it is now removed. The "direct-rendering" level 2, i.e. exposing VA surface buffers, was never really well supported and it could actually trigger degraded performance. Signed-off-by: Gwenole Beauchesne 2012-11-20 15:50:56 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapiuploader.h: vaapisink: compute and expose the supported set of YUV caps. Make vaapisink expose only the set of supported caps for raw YUV buffers. Add gst_vaapi_uploader_get_caps() helper function to determine the set of supported YUV caps as source (for images). This function actually tries to zero and upload each image to a 64x64 test surface. Of course, this relies on VA drivers to not claim success if vaPutImage() is not correctly supported. 2012-11-20 14:28:55 +0100 Gwenole Beauchesne * NEWS: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiuploader.c: * gst/vaapi/gstvaapiuploader.h: vaapisink: add support for raw YUV buffers. Add new GstVaapiUploader helper to upload raw YUV buffers to VA surfaces. It is up to the caller to negotiate source caps (for images) and output caps (for surfaces). gst_vaapi_uploader_has_direct_rendering() is available to help decide between the creation of a GstVaapiVideoBuffer or a regular GstBuffer on sink pads. Signed-off-by: Zhao Halley Signed-off-by: Gwenole Beauchesne 2012-11-20 14:36:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: fix GstVaapiImage map and unmap. Fix gst_vaapi_image_map() to return TRUE and the GstVaapiImageRaw structure correctly filled in if the image was already mapped. Likewise, make gst_vaapi_image_unmap() return TRUE if the image was already unmapped. 2012-10-30 13:15:45 +0800 Wind Yuan * NEWS: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: videobuffer: fix memory leak for surface and image. Fix reference leak of surface and image in GstVaapiVideoBuffer wrapper, thus resulting on actual memory leak of GstVaapiImage when using them for downloads/uploads from VA surfaces and more specifically surfaces when the pipeline is shutdown. i.e. vaTerminate() was never called because the resources were not unreferenced, and thus not deallocated in the end. Signed-off-by: Gwenole Beauchesne 2012-11-19 10:04:52 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-11-16 18:00:10 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix picture size in macroblocks. The picture size signalled by sps->{width,height} is the actual size with cropping applied, not the original size derived from pic_width_in_mbs_minus1 and pic_height_in_map_units_minus1. VA driver expects that original size, uncropped. There is another issue pending: frame cropping information needs to be taken care of. 2012-11-16 16:18:52 +0100 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: codecparsers: always build parserutils first. Fix commit 18245b4 so that to link and build parserutils.[ch] first. This is needed since that's the common dependency for actual codec parsers (gstvc1parser.c for instance). 2012-11-15 17:50:45 +0100 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: codecparsers: always build the VC-1 parser library. ... this is useful to make sure pixel-aspect-ratio and framerate information are correctly parsed since we have no means to detect that at configure time. 2012-11-08 11:40:47 +0200 Sreerenj Balachandran * configure.ac: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix PAR calculation from commit bd11bae. Invoke gst_mpeg_video_finalise_mpeg2_sequence_header() to get the correct PAR values. While doing so, require a newer version of the bitstream parser library. Note: it may be necessary to also parse the Sequence_Display_Extension() header. Signed-off-by: Sreerenj Balachandran Signed-off-by: Gwenole Beauchesne 2012-11-15 15:00:43 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: Fix build with the GNU gold linker. In particular, fix libgstvaapi-glx DSO dependencies to include libgstbase and libgstvideo libs, e.g. for gst_video_buffer_get_overlay_composition(). 2012-11-02 18:18:37 +0000 Rob Bradford * configure.ac: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: port to 1.0 version of the protocol. This patch updates to relect the 1.0 version of the protocol. The main changes are the switch to wl_registry for global object notifications and the way that the event queue and file descriptor is processed. Signed-off-by: Gwenole Beauchesne 2012-11-14 19:22:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix incorrect integration of previous commit (4d31e1e). git am got confused somehow, though the end result doesn't change at all since we require both SPS and PPS to be parsed prior to decoding the first slice. 2012-11-14 18:40:47 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: start decoding slices after first SPS/PPS activation. Only start decoding slices when at least one SPS and PPS got activated. This fixes cases when a source represents a substream of another stream and no SPS and PPS was inserted before the first slice of the generated substream. 2012-11-14 14:25:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix VAPictureParameterBufferH264.ReferenceFrames[] construction. ... for interlaced streams. The short_ref[] and long_ref[] arrays may contain up to 32 fields but VA ReferenceFrames[] array expects up to 16 reference frames, thus including both fields. 2012-11-14 10:27:12 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix interlaced stream decoding with MMCO. Fix decoding of interlaced streams when adaptive_ref_pic_marking_mode_flag is equal to 1, i.e. when memory management control operations are used. In particular, when field_pic_flag is set to 0, the new reference flags shall be applied to both fields. 2012-11-13 17:14:39 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add initial support for interlaced streams. Decoded frames are only output when they are complete, i.e. when both fields are decoded. This also means that the "interlaced" caps is not propagated to vaapipostproc or vaapisink elements. Another limitation is that interlaced bitstreams with MMCO are unlikely to work. 2012-11-13 16:35:30 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: split remove_reference_at() into finer units. Split remove_reference_at() into a function that actually removes the specified entry from the short-term or long-term reference picture array, and a function that sets reference flags to the desired value, possibly zero. The latters marks the picture as "unused for reference". 2012-10-23 14:04:22 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: fix gst_vaapi_picture_new_field() object type. Fix gst_vaapi_picture_new_field() to preserve the original picture type. e.g. gst_vaapi_picture_new_field() with a GstVaapiPictureH264 argument shall generate a GstVaapiPictureH264 object. 2012-11-13 14:04:31 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add picture structure for reference picture marking process. Introduce new `structure' field to the H.264 specific picture structure so that to simplify the reference picture marking process. That local picture structure is derived from the original picture structure, as defined by the syntax elements field_pic_flag and bottom_field_flag. 2012-11-02 15:14:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: introduce new frame store structure. The frame store represents a Decoded Picture Buffer entry, which can hold up to two fields. So far, the frame store is only used to hold full frames. 2012-11-13 10:10:31 +0100 Gwenole Beauchesne * ext/codecparsers: codecparsers: update to gst-vaapi-rebased commit 73d6aab. 73d6aab h264: fix rbsp_more_data() implementation 25d04cf h264: fix error code for invalid size parsed in SPS 84798e5 fix FSF address 2012-10-31 16:37:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: minor clean-ups. Move DPB flush up if the current picture to decode is an IDR. Besides, don't bother to check for IDR pictures in dpb_add() function since an explicit DPB flush was already performed in this case. 2012-10-31 14:24:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: simplify reference picture marking process. ... to build the short_ref[] and long_ref[] lists from the DPB, instead of maintaining them separately. This avoids refs/unrefs while making it possible to generate the list based on the actual picture structure. This also ensures that the list of generated ReferenceFrames[] actually matches what reference frames are available in the DPB. i.e. short_ref[] and long_ref[] entries are implied from the DPB, so there is no risk of having "dangling" references. 2012-10-31 11:52:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: introduce per-field POC in GstVaapiPictureH264. Use the POC member available in the GstVaapiPicture base class and get rid of the dependency on the local VAPictureH264 TopFieldOrderCnt and BottomFieldOrderCnt. Rather, use a simple field_poc[] array initialized to INT_MAX, so that to simplify picture POC calculation for non frame pictures. 2012-10-31 11:45:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: introduce GST_VAAPI_PICTURE_{SHORT,LONG}_TERM_REFERENCE flags. Further get rid of GstVaapiPictureH264-local VAPictureH264.flags for reference bits, thus simplifying the reference picture marking process to only track a single set of reference flags. Also introduce a new long_term_frame_idx member. 2012-10-31 11:33:40 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: introduce GST_VAAPI_PICTURE_FLAG_IDR flag. 2012-10-31 10:56:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fill in GstVaapiPicture structure. ... and get rid of local VAPictureH264.flags fields in GstVaapiPictureH264. 2012-10-31 11:07:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add vaapi_fill_picture() helper. Add vaapi_fill_picture() helper function to convert GstVaapiPictureH264 to VAPictureH264 structure. This is preparatory work to get rid of the local VAPictureH264 member in GstVaapiPictureH264. 2012-10-26 16:12:05 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix activation order of picture and sequence parameters. Delay ensure_context() until we actually need a VA context for allocating new VA surfaces, and then GstVaapiPictures, but also when a real activation of a new picture parameter set occurs, thus also implying an activation of the related sequence parameter set. The most important thing was to drop the global pps and sps pointers since they may not have matched the currently activated picture parameter or sequence parameter sets at the specified decode point. Anoter positive side-effect is that this cleans up all occurrences of decode_current_picture() to only keep those useful in decode_picture(), before a new picture is allocated, or in decode_sequence_end() when an end-of-stream or end-of-sequence condition occurred. 2012-10-26 13:17:43 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix scaling list generation. ... aka fix regression from efaab79. In particular, ScalingList8x8[] array was partially copied to the VAIQMatrixBufferH264. While we are at it, also improve bounds checking and avoid copying 8x8 scaling lists if transform_8x8_mode_flag is set to 0. 2012-10-24 18:23:09 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix detection of picture boundaries. Strictly follow the standard (7.4.1.2.4) to detect the first VCL NAL unit of a primary coded picture. 2012-10-23 14:50:14 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: optimize handling of scaling lists. Don't copy scaling lists twice to an intermediate state. Rather, directly use the scaling lists from GstH264PPS since they would match those provided by SPS header, if necessary. i.e. if PPS-specific scaling lists are not available in the bitstream. 2012-10-23 10:33:50 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: simplify code when MMCO is 5. Remove exit_picture() and exit_picture_poc() since PicOrderCnt(CurrPic) is now updated accordingly to the standard. Besides, MMCO = 5 specific operations are moved up to exec_ref_pic_marking_adaptive_mmco_5(). 2012-10-22 11:52:13 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix MMCO-based reference picture marking process. Fix adaptive memory control decoded reference picture marking process implementation for operations 2 to 6, thus also fixing support for long-term reference pictures. 2012-10-22 10:50:29 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: move MMCO handlers out of the loop (cosmetics). This change only splits each individual MMCO handler into several functions dedicated for each operation. This is needed to perform further work later on. 2012-10-17 15:49:23 +0200 Gwenole Beauchesne * Makefile.am: debian: fix make dist for packaging. bzip2 tarballs are now used, so update the deb.upstream dependencies to include dist-bzip2 instead of plain old dist, and use the correct tar extract options to handle that format. 2012-10-17 15:42:17 +0200 Gwenole Beauchesne * configure.ac: configure: generate bzip2 tarballs in ustar format by default. 2012-10-17 15:38:14 +0200 Gwenole Beauchesne * configure.ac: configure: bump glib required version to 2.31.2. Use new Thread API. In particular, g_mutex_init() and g_cond_init() rather than g_mutex_new() and g_cond_new() respectively. 2012-10-04 17:39:53 +0100 Rob Bradford * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: adopt non-deprecrated glib locking primitive pattern. The use of heap allocated GMutex/GCond is deprecated. Instead place them inside the structure they are locking. These changes switch to use g_mutex_init/g_cond_init rather than the heap allocation functions. Because we cannot test for a NULL pointer for the GMutex/GCond we must initialise inside the GObject _init function and clear inside the _finalize which is guaranteed to only be called once and after the object is no longer in use. 2012-10-17 14:52:35 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix compiler warnings. Don't care of the return value for gst_vaapi_decoder_put_buffer() during destruction of the element. Don't print out (uninitialised) error code when allocation of video buffer failed. 2012-10-16 16:52:04 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add flag to compile with strict DPB ordering mode. Allow build with strict DPB ordering mode whereby evicted entries are replaced by the next entries, in order instead of optimizing it away with the last entry in the DPB. This is only useful for debugging purpose, against a reference SW decoder for example. 2012-10-16 16:46:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: drop extra code covered by built-in codecparsers. GstH264SliceHdr.n_emulation_prevention_bytes is bound to exist now that a newer version of codecparsers/ are used if the system provided one is now recent enough to have those required extensions. 2012-10-16 16:43:43 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: codecparsers: fix generation of symlinks. Try to improve dependencies while generating symlinks to externally maintained copy of codecparsers (derived from upstream git master tree). 2012-10-11 15:04:12 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: use framerate information from bitstream parser. 2012-09-27 18:05:46 +0100 Simon Farnsworth * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: use pixel-aspect-ratio from bitstream parser. Signed-off-by: Simon Farnsworth Signed-off-by: Gwenole Beauchesne 2012-09-27 18:05:46 +0100 Simon Farnsworth * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: use pixel-aspec-ratio information from bitstream parser. Signed-off-by: Simon Farnsworth Signed-off-by: Gwenole Beauchesne 2012-10-11 13:49:14 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/codecparsers/Makefile.am: codecparsers: h264: use submodule sources. Use newer sources from the codecparsers/ submodule for - GstH264SliceHdr.n_emulation_prevention_bytes: EPBs; - GstH264VUIParams.{par_n,par_d}: pixel-aspect-ratio. 2012-10-11 13:23:02 +0200 Gwenole Beauchesne * .gitignore: * configure.ac: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/Makefile.am: codecparsers: jpeg: use submodule sources. 2012-10-11 10:03:14 +0200 Gwenole Beauchesne * .gitmodules: * Makefile.am: * autogen.sh: * configure.ac: * ext/Makefile.am: * ext/codecparsers: Add codecparsers submodule. 2012-10-11 14:17:12 +0200 Gwenole Beauchesne * .gitignore: .gitignore: updates. 2012-10-11 13:40:37 +0200 Gwenole Beauchesne * autogen.sh: autogen: fix check for gtkdocize and autoreconf. If gtkdocize or autoreconf programs were not found, then the autogen.sh script would fail to report that correctly because test -z was not passed any argument (empty string "" in this case). 2012-09-27 18:05:46 +0100 Simon Farnsworth * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: use pixel-aspect-ratio from SPS header. Propagate pixel-aspect-ratio determined by the GStreamer codecparser from the sequence headers. Signed-off-by: Simon Farnsworth Signed-off-by: Gwenole Beauchesne 2012-10-10 10:35:20 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: add decode_nalu() helper function. Split decode_buffer() into the core infrastructure that determines the NAL units contained in the adapter and the actual function that decodes the NAL unit. 2012-10-10 10:31:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix end-of-stream conditions (flush). Decode pending data in the adapter prior to processing the actual code for end-of-stream. 2012-10-10 09:45:03 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: add decode_packet() helper function. Split decode_buffer() into the core infrastructure that determines the packets contained in the adapter and the actual function that decodes the packet data. 2012-10-09 15:34:18 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix end-of-stream conditions (flush). Decode pending data in the adapter prior to processing the actual code for end-of-stream. Initial code from Feng Yuan. 2012-10-09 15:40:49 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix memory leak of empty packets. Fix memory leakage of empty packets, i.e. packets that only contain the start code prefix. In particular, free empty user-data packets. Besides, the codec parser will already fail gracefully if the packet to parse does not have the minimum required size. So, we can also completely drop the block of code that used to handle packets of size 4 (including the start code). 2012-10-09 15:01:38 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix return value for "no-data" conditions. Fix return value when the second scan for start code fails. This means there is not enough data to determine the full extents of the current packet and the function shall return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA in this case, instead of GST_VAAPI_DECODER_STATUS_SUCCESS. 2012-10-09 14:48:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: refine semantics of gst_vaapi_decoder_put_buffer(). Improve the semantics for gst_vaapi_decoder_put_buffer() when an empty buffer is passed on. An empty buffer is a buffer with a NULL data pointer or with a size equals to zero. In this case, that buffer is simply skipped and the function returns TRUE. A NULL buffer argument still marks the end-of-stream. 2012-10-09 14:40:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: drop unused functions. 2012-08-26 22:29:04 -0400 Wind Yuan * gst/vaapi/gstvaapidecode.c: vaapidecode: flush buffers when receiving EOS. Signed-off-by: Gwenole Beauchesne 2012-10-05 13:36:27 +0200 Gwenole Beauchesne * debian.upstream/Makefile.am: debian: fix make dist for packaging. 2012-10-05 12:06:27 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: cosmetics (remove tabs). 2012-10-04 17:39:52 +0100 Rob Bradford * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: add support for windowed mode. Rather than always making the surface fullscreen instead implement the set_fullscreen vfunc on GstVaapiWindow and then set the shell surface fullscreen on not depending on that. Reviewed-by: Joe Konno Signed-off-by: Gwenole Beauchesne 2012-10-01 09:21:03 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-09-28 17:54:03 +0200 Gwenole Beauchesne * README: * configure.ac: Fix and document build dependencies better. 2012-09-28 17:41:42 +0200 Gwenole Beauchesne * debian.upstream/control.in: debian: fix GStreamer build dependencies. 2012-09-28 17:39:43 +0200 Gwenole Beauchesne * configure.ac: * debian.upstream/control.in: debian: fix Wayland build dependencies. 2012-09-28 17:38:17 +0200 Gwenole Beauchesne * debian.upstream/control.in: debian: fix conditional build of packages. Make it still possible to build package even if one of the build dependencies for a specific video backend is not available. 2012-09-27 11:08:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: utils: drop unused GLX helpers. Remove helpers for GL_ARB_fragment_program and GL_ARB_multitexture extensions since they are not used throughout gstreamer-vaapi. 2012-09-27 11:04:24 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.h: utils: fix build with version >= 85. Mesa recently updated the header version to Khronos version 85. This caused the PFNGLMULTITEXCOORD2FPROC definition to be moved out of the GL_VERSION_1_3_DEPRECATED block. However, since also defines GL_VERSION_1_3 to 1, the definitions in are then not enabled, thus leaving PFNGLMULTITEXCOORD2FPROC undefined as well. Provide a PFNGLMULTITEXCOORD2FPROC replacement as an interim solution for newer versions of the header. 2012-09-26 16:33:16 +0200 Gwenole Beauchesne * configure.ac: configure: update VA-API version requirements. VA/DRM and VA/Wayland API are now promoted to VA-API 0.33.0 (libva 1.1.0). 2012-09-21 16:43:38 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: review and report errors accordingly. Use GST_ERROR() to report real errors instead of hiding them into GST_DEBUG(). 2012-09-20 17:58:21 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: exclusively use GstAdapter, drop sub-buffer hack. Maintaining the sub-buffer is rather suboptimal especially since we were also maintaining a GstAdapter. Now, we only use the GstAdapter thus requiring minor extra parsing when receiving avcC buffers. 2012-09-20 16:18:27 +0200 Gwenole Beauchesne * README: README: updates. 2012-09-20 16:02:39 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-09-20 14:38:15 +0200 Gwenole Beauchesne * debian.upstream/gstreamer-vaapi.install.in: debian: fix packaging on recent Ubuntu platforms. Use explicit GStreamer plugins path. 2012-09-17 17:55:43 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs.core.types: docs: fix build for make dist. 2012-09-14 10:30:35 -0400 Kristian Høgsberg * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: set opaque region for YUV surface. This allows the compositor to optimize redraws and cull away changes obscured by the video surface. Signed-off-by: Gwenole Beauchesne 2012-09-14 17:30:19 +0200 Gwenole Beauchesne * configure.ac: configure: fix check for libva-glx and libva-drm. 2012-09-12 13:42:49 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: glibcompat: add replacement for g_cond_wait_until(). 2012-09-12 13:41:47 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: include "sysdeps.h" instead of "config.h". 2012-09-12 10:40:06 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.c: codecparsers: jpeg: add missing includes. 2012-09-11 17:03:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst/vaapi/gstvaapidecode.c: vaapidecode: don't reset decoder if codec type is the same. Reset, i.e. destroy then create, the decoder in _setcaps() handler only if the underlying codec type actually changed. This makes it possible to be more tolerant with certain MPEG-2 streams that get parsed to form caps that are compatible with the previous state but minor changes to "codec-data". 2012-09-11 16:41:32 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: simplify codec lookup from caps. Add new gst_vaapi_codec_from_caps() helper to determine codec type from the specified caps. Don't globally expose this function since this is really trivial and only used in the vaapidecode element. 2012-09-11 15:54:20 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: improve "no free surface" conditions. Previously, vaapidecode would wait up to one second until a free surface is available, or it aborts decoding. Now, vaapidecode waits until the last decoded surface was to be presented, plus one second. Besides, end times are now expressed relative to the monotonic clock. 2012-09-11 10:59:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst/vaapi/gstvaapidecode.c: decoder: propagate buffer duration downstream. 2012-09-11 10:59:10 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: surfaceproxy: add "duration" property. 2012-09-10 18:26:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: cope with new GstVaapiContextInfo based API. Update decoders to report the maximum number of reference frames to use. 2012-09-10 18:17:10 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: context: JPEG codec does not need any reference frame. 2012-09-10 18:15:02 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: context: allow number of reference frames to be set. Make it possible to specify the maximum number of references to use within a single VA context. This helps reducing GPU memory allocations to the useful number of references to be used. 2012-09-07 16:41:16 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipostproc.c: vaapipostproc: fix deinterlace-{mode,method} types definition. 2012-09-07 16:15:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: fix debug info for unsupported profile. 2012-09-07 16:14:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: libs: fix build in strict ISO C mode. 2012-09-07 16:11:12 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: fix build in strict ISO C mode. 2012-09-07 15:31:09 +0200 Gwenole Beauchesne * pkgconfig/gstreamer-vaapi-glx.pc.in: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: pkgconfig: fix dependencies and slightly improve description. Drop @LIBVA_EXTRA_{CFLAGS,LIBS}@ substitutions and slightly improve descriptions with clearer renderer names. 2012-09-04 13:54:19 +0200 Philip Lorenz * gst/vaapi/gstvaapidecode.c: vaapidecode: acquire lock only if the mutex exists. When playback stops the GstVaapiDecode object is reset into a clean state. However, surfaces may still be referenced by library users and unreferencing them after the reset triggers an access to an unset mutex. Signed-off-by: Gwenole Beauchesne 2012-09-07 11:58:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: drop extraneous return for void function. 2012-09-07 11:57:59 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: don't use (void *) pointer arithmetic. 2012-09-04 13:40:04 +0200 Philip Lorenz * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst/vaapi/gstvaapipostproc.h: Do not forward declare enums. Forward declaring enums is not allowed by the C standard and aborts compilation if the header file is included in a C++ project. Signed-off-by: Gwenole Beauchesne 2012-09-07 11:44:44 +0200 Gwenole Beauchesne * configure.ac: configure: fix check for VA/DRM API. 2012-09-04 11:53:18 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix calculation of window size. If either dimension is out-of-bounds, then scale window to fit the display size, even if the output is to be rotated. Use the standard gst_video_sink_center_rect() function to center and scale the window wrt. the outer (display) bounds. 2012-08-28 02:45:22 -0400 Wind Yuan * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: add video rotation support. Signed-off-by: Gwenole Beauchesne 2012-09-06 11:47:40 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.h: pluginutils: add G_PRIMITIVE_SWAP() helper macro. This macro helps swapping variables while maintaining the correct underlying and primitive type. 2012-09-06 11:51:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: fix display aspect ratio when display is rotated. 2012-09-06 11:50:21 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: display: fix physical display size when display is rotated. 2012-08-30 16:27:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivalue.c: display: fix GstVaapiRotation enumeration of values. 2012-08-29 13:18:05 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: vaapisink: drop obsolete GstVaapiVideoSink interface. This interface was deprecated since 0.3.x series when the GstVideoContext interface was added to the main GStreamer APIs. 2012-08-27 18:34:27 +0300 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: automatically detect overlay rendering mode. Retain the VA surface until another surface is to be displayed only if VA display rendering mode is determined to be "overlay" mode. 2012-08-24 16:30:33 +0300 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: retain VA surface until another one is displayed. Keep VA surface proxy associated with the surface that is currently being displayed. This makes sure that surface is not released back to the pool of surfaces free to use for decoding. This is necessary with VA driver implementations that support rendering to an overlay pipe. Otherwise, there could be cases where we are decoding into a surface that is being displayed, hence some flickering. 2012-08-24 14:54:16 +0300 Gwenole Beauchesne * gst/vaapi/gstvaapisink.h: vaapisink: fix build with older toolchains. Don't re-declare GstVaapiTexture if USE_GLX mode is set. 2012-08-29 10:13:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: partially revert 8ebe4d6. Don't try to fix up the initial values, this could make things worse. Simply assume the driver does not support the capability in this case. 2012-08-28 16:08:34 +0200 Gwenole Beauchesne * tests/test-display.c: tests: dump VA display properties. 2012-08-28 18:11:32 +0300 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: fix validation process of properties during discovery. Some VA drivers (e.g. EMGD) can have completely random values for initial display attributes. So, try to improve the discovery process to check the initial display attribute values actually fall within valid bounds. If not, try to reset those to some sensible values like the default value reported through vaQueryDisplayAttributes(). 2012-08-28 13:59:50 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: display: add color balance properties. Add support for hue, saturation, brightness and contrast attributes. 2012-08-28 14:05:16 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: initialize default attribute values. Ensure the display attribute is actually supported by trying to retrieve its current value during GstVaapiDisplay creation. 2012-08-28 11:09:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: raise "notify" for property changes. 2012-08-28 10:55:59 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: display: expose display attributes as GObject properties. Expose VA display "render-mode" and "rotation" attributes as standard GObject properties. 2012-08-28 16:24:15 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: install properties in batch. Use g_object_class_install_properties() to install GstVaapiDisplay properties. It is useful to maintain properties as GParamSpec so that to be able to raise "notify" signals by id instead of by name in the future. 2012-08-27 19:00:37 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: fix gst_vaapi_display_has_property(). Append the "render-mode" and "rotation" properties, should they be supported by the underlying VA driver. 2012-08-22 02:18:11 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: display: add support for rotation modes. Signed-off-by: Gwenole Beauchesne 2012-08-27 18:11:37 +0300 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: display: add support for rendering modes. A rendering mode can be "overlay" or "texture"'ed blit. The former mode implies that a VA surface used for rendering can't be re-used right away for decoding, so the sink shall make provisions to retain the associated surface proxy until the next surface is to be displayed. The latter mode implies that the VA surface is implicitly copied to an intermediate backing store, or back buffer of a frame buffer, so the associated surface proxy can be disposed right away. 2012-08-27 17:02:49 +0300 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: display: add initial support for display attributes. The VA display attributes are mapped to properties so that to maintain the GStreamer terminology. Properties are to be identified by name, but internal functions are available to lookup the property by the actual VA display attribute type. 2012-08-24 11:36:16 +0300 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: fix end-of-image (EOI) handler. decode_current_picture() was converted to return a gboolean instead of a GstVaapiDecoderStatus, so we were not getting out of the decode loop as expected, or could cause an error instead. Signed-off-by: Gwenole Beauchesne 2012-08-24 18:41:47 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: include start code into VA slice data buffer. Integrate the start code prefix in the slice data buffer that is submitted to the hardware. VA-API specifies that slice_data_offset is the offset to the first byte of slice data. And, for MPEG-2, slice() data begins with the slice_start_code. Some VA driver implementations (EMGD) expect this. 2012-06-28 01:08:03 +0900 Javier Jardón * autogen.sh: autogen: fix configure script generation when srcdir != builddir. This patch allows for regenerating the configure script from a build directory that is not the actual source directory. Signed-off-by: Gwenole Beauchesne 2012-06-28 00:22:03 +0900 Javier Jardón * configure.ac: configure: use new libtool syntax. This now requires libtool >= 2.2 to regenerate the configure script. Signed-off-by: Gwenole Beauchesne 2012-08-08 12:50:41 +0900 Javier Jardón * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: use g_object_notify_by_pspec(). Use g_object_notify_by_pspec() instead of g_object_notify() so that to avoid a property name lookup. i.e. this makes notifications faster to the `vaapidecode' element. Signed-off-by: Gwenole Beauchesne 2012-08-06 19:21:03 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: handle de-interlacing flags. VA/Wayland API was updated to allow flags for bob deinterlacing. More elaborated filters will require a complete VA/VPP pipeline. 2012-08-02 18:27:48 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.c: jpeg: fix default quantization tables. Two elements in the luminance quantization table were wrong. So, gst_jpeg_get_default_quantization_tables() now reconstructs tables in zig-zag order from the standard ones (Tables K.1 and K.2). 2012-08-02 15:17:57 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.c: jpeg: compute default Huffman tables. ... instead of having them pre-calculated. This saves around 1.5 KB of data in the DSO but requires gst_jpeg_get_default_huffman_tables() to do more work. Though, the client application may have to call that function at most once, only. 2012-08-01 18:30:27 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: drop VAProfileNone entries from debug messages. 2012-07-31 18:24:14 +0800 Yan Yin * gst-libs/gst/vaapi/gstvaapidisplay.c: display: query for supported display attributes. Signed-off-by: Gwenole Beauchesne 2012-07-31 18:22:48 +0800 Yan Yin * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: utils: add string_of_VADisplayAttributeType() helper. Signed-off-by: Gwenole Beauchesne 2012-08-01 15:46:35 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: handle VA/DRM API. This is not useful in practice but for raw performance evaluation when the sink is invoked with display=drm sync=false. fakesink could also be used though. 2012-08-01 15:46:19 +0200 Gwenole Beauchesne * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginutil.c: plugins: add support for headless pipelines. 2012-08-01 15:44:49 +0200 Gwenole Beauchesne * tests/Makefile.am: * tests/output.c: * tests/test-display.c: * tests/test-windows.c: tests: add support for headless decoding. 2012-08-01 15:44:02 +0200 Gwenole Beauchesne * NEWS: * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: * debian.upstream/libgstvaapi-drm.install.in: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm.c: * gst-libs/gst/vaapi/gstvaapidisplay_drm.h: * gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_drm.c: * gst-libs/gst/vaapi/gstvaapiwindow_drm.h: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-drm.pc.in: Add initial support for VA/DRM. 2012-07-31 17:58:43 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: Fix build without X11 (again). Don't try to build libgstvaapi-x11.so.* if X11 was disabled. Also shuffle files list wrt. x11, glx and wayland backends. 2012-07-31 11:51:57 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: update to the latest VA-API changes (0.32.1+). 2012-07-27 14:27:05 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst/vaapi/gstvaapisink.c: wayland: implement display ::get_size*() hooks. 2012-07-27 10:45:41 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: plugins: prefer X11 rendering over GLX. Prefer X11 display over GLX so that "vaapisink" uses X11, i.e. vaPutSurface(), for rendering instead of texturing. 2012-07-26 09:28:51 -0400 Kristian Høgsberg * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: use scale fullscreen method. This makes the compositor scale the surface to fit and preserves aspect ratio. Signed-off-by: Gwenole Beauchesne 2012-07-26 09:27:47 -0400 Kristian Høgsberg * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: wayland: respond to ping/pong protocol so we're not deemed unresponsive. Signed-off-by: Gwenole Beauchesne 2012-07-25 10:39:04 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: fix double disconnect of display. 2012-07-24 19:58:55 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: wayland: mangle display name for cache lookups. 2012-07-24 15:43:44 +0200 Gwenole Beauchesne * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: * debian.upstream/libgstvaapi-wayland.install.in: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-wayland.pc.in: wayland: add packaging files. 2012-07-24 15:07:48 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: * pkgconfig/Makefile.am: Fix build without X11. 2012-07-24 09:45:25 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapisink.c: plugins: add support for Wayland. 2012-07-23 12:56:33 +0200 Gwenole Beauchesne * tests/Makefile.am: * tests/output.c: * tests/test-display.c: * tests/test-windows.c: tests: add support for Wayland. 2012-07-19 10:27:23 +0200 Sreerenj Balachandran * NEWS: * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.c: * gst-libs/gst/vaapi/gstvaapidisplay_wayland.h: * gst-libs/gst/vaapi/gstvaapidisplay_wayland_priv.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.c: * gst-libs/gst/vaapi/gstvaapiwindow_wayland.h: Add initial support for VA/Wayland. Signed-off-by: Gwenole Beauchesne 2012-07-25 15:11:51 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbuffer.c: plugins: fix creation of video buffer from surface proxy. Fix a regression introduced with commit 8ef490a. 2012-07-25 14:51:28 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginutil.c: plugins: use new display types more. In particular, simplify gst_vaapi_reply_to_query() with display types. Likewise for creating new video buffers. 2012-07-25 10:02:29 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: fix display type selection and propagation. If vaapisink is in the GStreamer pipeline, then we shall allocate a unique GstVaapiDisplay and propagate it upstream. i.e. subsequent queries from vaapidecode shall get a valid answer from vaapisink. 2012-07-25 11:37:26 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: fix destruction of mutex. 2012-07-25 09:16:02 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: display: add display types. Move display types from gstvaapipluginutil.* to gstvaapidisplay.* so that we could simplify characterization of a GstVaapiDisplay. Also rename "auto" type to "any", and add a "display-type" attribute. 2012-07-24 19:43:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: use prefixed display names for cache lookups. This improves display name comparisons by always allocating a valid display name. This also helps to disambiguate lookups by name in the global display cache, should a new backend be implemented. 2012-07-24 16:14:51 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.h: plugins: declare helper functions as internal. 2012-07-24 14:31:25 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginbuffer.c: * gst/vaapi/gstvaapipluginbuffer.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapiupload.c: videobuffer: drop deprecated functions. Move video buffer creation routines to plugin elements. That exclusively uses *_typed_new*() variants. 2012-07-24 14:09:09 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.h: videobuffer: mark video buffer creation routines as deprecated. The vdeo buffer creation routines shall actually be internal to gstreamer-vaapi plugin elements. So deprecate any explicit creation routines that are not the new *_typed_new*() variants. 2012-07-24 13:52:06 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_priv.h: videobuffer: factor out base and GLX implementations. Introduce new typed constructors internal to gstreamer-vaapi plugin elements. This avoids duplication of code, and makes it possible to further implement generic video buffer creation routines that automatically map to base or GLX variants. 2012-07-24 10:58:32 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.c: utils: fix gl_create_context() with parent context set. If GLX window was created from a foreign Display, then that same Display shall be used for subsequent glXMakeCurrent(). This means that gl_create_context() will now use the same Display that the parent, if available. This fixes cluttersink with the Intel GenX VA driver. 2012-07-23 18:37:38 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: pluginutils: improve automatic display type selection. 2012-07-23 18:01:26 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: pluginutils: cosmetics (indentation fixes). 2012-07-23 17:54:58 +0200 Gwenole Beauchesne * configure.ac: configure: simplify video outputs summary. 2012-07-23 17:49:08 +0200 Gwenole Beauchesne * configure.ac: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: configure: drop check for --enable-vaapisink-glx. vaapisink is now built with support for multiple display types, whenever they are enabled. The new "display" attribute is used to select a particular renderer. 2012-07-23 16:15:38 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapiupload.c: * tests/test-display.c: configure: drop check for --enable-vaapi-glx. This flag is obsolete. It was meant to explicitly enable/disable VA/GLX API support, or fallback to TFP+FBO if this API is not found. Now, we check for the VA/GLX API by default if --enable-glx is set. If this API is not found, we now default to use TFP+FBO. Note: TFP+FBO, i.e. using vaPutSurface() is now also a deprecated usage and will be removed in the future. If GLX rendering is requested, then the VA/GLX API shall be used as it covers most usages. e.g. AMD driver can't render to an X pixmap yet. 2012-07-23 15:20:23 +0200 Gwenole Beauchesne * tests/output.c: tests: allow GLX output, if available and selected. 2012-07-23 15:17:03 +0200 Gwenole Beauchesne * tests/Makefile.am: * tests/output.c: * tests/output.h: * tests/test-decode.c: * tests/test-subpicture.c: * tests/test-surfaces.c: tests: use common display and window creation routines. Add new --output option to select the renderer. Use --list-outputs to print a list of supported renderers. 2012-07-23 14:15:42 +0200 Gwenole Beauchesne * tests/Makefile.am: tests: move encoded bitstreams to libutils.la. 2012-07-23 14:11:16 +0200 Gwenole Beauchesne * tests/Makefile.am: tests: build convenience library for common utilities. 2012-07-20 16:37:01 +0200 Gwenole Beauchesne * tests/Makefile.am: * tests/test-display.c: tests: simplify build with various display options. 2012-07-23 13:28:42 +0200 Gwenole Beauchesne * configure.ac: configure: improve checks for X11. 2012-07-20 15:57:26 +0200 Gwenole Beauchesne * tests/Makefile.am: configure: fix previous commit for GLX deps. 2012-07-20 14:44:27 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: configure: improve checks for GLX. 2012-07-20 11:45:15 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiutils.h: Drop support for obsolete VA-API versions < 0.30.4. 2012-07-20 11:16:27 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/Makefile.am: * gst-libs/gst/gstutils_version.h.in: * gst/vaapi/gstvaapisink.c: vaapisink: drop checks for new APIs used by default. GStreamer -base plugins >= 0.10.31 are now required, so the checks for new APIs like GstXOverlay::set_window_handle() and ::set_render_rectangle() are no longer necessary. 2012-07-20 14:05:23 +0200 Gwenole Beauchesne * configure.ac: configure: cosmetics and some minor changes. - Better grouping of feature checks - Sort list of config files to generate 2012-07-19 17:55:00 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: Use standard G_GNUC_INTERNAL keyword instead of attribute_hidden. 2012-07-19 17:41:25 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_tsb.c: * gst-libs/gst/vaapi/gstvaapiutils_tsb.h: Drop obsolete GstVaapiTSB. It has been replaced with a GstAdapter and gst_adapter_prev_pts(). 2012-07-19 17:27:06 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: docs: add missing entries for the JPEG decoder. 2012-07-19 17:16:28 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * tests/test-decode.c: * tests/test-subpicture.c: Drop all references to USE_CODEC_PARSERS. 2012-07-19 17:00:36 +0200 Gwenole Beauchesne * NEWS: * configure.ac: * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.core.types: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * tests/test-decode.c: * tests/test-subpicture.c: Drop FFmpeg-based decoders. GStreamer codecparsers-based decoders are the only supported decoders now. Though, FFmpeg decoders are still available in gstreamer-vaapi 0.3.x series. 2012-07-01 05:55:05 +0900 Javier Jardón * configure.ac: * debian.upstream/control.in: configure: bump glib required version to 2.28. Signed-off-by: Gwenole Beauchesne 2012-06-29 08:45:47 +0900 Javier Jardón * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapipostproc.h: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.h: plugins: declare _get_type() functions as const. Declaring a function as const enables better optimization of calls to the function. Signed-off-by: Gwenole Beauchesne 2012-07-01 05:50:17 +0900 Javier Jardón * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: use g_clear_object() wherever applicable. Signed-off-by: Gwenole Beauchesne 2012-06-29 15:19:51 +0900 Javier Jardón * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.h: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: libs: declare _get_type() functions as const. Declaring a function as const enables better optimization of calls to the function. Signed-off-by: Gwenole Beauchesne 2012-07-01 05:34:15 +0900 Javier Jardón * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: libs: use g_clear_object() wherever applicable. This is a preferred thread-safe version. Also add an inline version of g_clear_object() if compiling with glib < 2.28. Signed-off-by: Gwenole Beauchesne 2012-07-01 06:02:22 +0900 Javier Jardón * .gitignore: * configure.ac: * docs/reference/libs/Makefile.am: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapimarshal.list: * gst-libs/gst/vaapi/gstvaapiobject.c: libs: use generic g_cclosure_marshal_VOID__VOID(). Signed-off-by: Gwenole Beauchesne 2012-07-19 14:29:33 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/glibcompat.h: glibcompat: drop explicit check for g_list_free_full(). 2012-07-19 13:58:31 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-07-19 13:57:05 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/Makefile.am: jpeg: fix make dist. 2012-06-28 00:39:10 +0900 Javier Jardón * autogen.sh: * configure.ac: * docs/Makefile.am: configure: fix build without gtk-doc support. Also do not generate tamplate files as all the documentation is inline. Drop un-needed code in autogen.sh as well. Signed-off-by: Gwenole Beauchesne 2012-06-28 00:27:31 +0900 Javier Jardón * Makefile.am: * autogen.sh: * configure.ac: configure: put m4 macros and autogenerated files into m4/ directory. Signed-off-by: Gwenole Beauchesne 2012-06-28 00:20:12 +0900 Javier Jardón * configure.ac: configure: drop deprecated autoconf macros. Bump autoconf required version to 2.58, needed for AS_HELP_STRING macro. Signed-off-by: Gwenole Beauchesne 2012-06-28 00:04:19 +0900 Javier Jardón * configure.ac: configure: don't use AC_SUBST for some variables. PKG_CHECK_MODULES already does this for us. Signed-off-by: Gwenole Beauchesne 2012-07-19 11:43:03 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapiupload.c: plugins: add support for GstImplementsInterface. 2012-07-01 02:58:36 +0900 Javier Jardón * configure.ac: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: use G_DEFINE_TYPE_* instead of deprecated GST_BOILERPLATE_*. Signed-off-by: Gwenole Beauchesne 2012-07-01 03:57:13 +0900 Javier Jardón * configure.ac: * gst/vaapi/gstvaapisink.c: plugins: do not use deprecated GStreamer -base symbols. Bump GStreamer plugins -base required version to 0.10.31, needed for gst_x_overlay_got_window_handle(). Signed-off-by: Gwenole Beauchesne 2012-07-01 03:57:13 +0900 Javier Jardón * configure.ac: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: do not use deprecated core GStreamer symbols. Bump GStreamer required version to 0.10.14, needed for gst_element_class_set_details_simple(). Signed-off-by: Gwenole Beauchesne 2012-07-19 10:54:33 +0200 Gwenole Beauchesne * tests/test-decode.c: tests: fix build without JPEG decoder support. 2012-07-17 13:44:45 +0200 Gwenole Beauchesne * tests/Makefile.am: * tests/test-decode.c: * tests/test-jpeg.c: * tests/test-jpeg.h: tests: add test for JPEG decoding. 2012-07-17 13:43:32 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: update to match latest parser API. 2012-07-16 17:35:19 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: codecparsers: jpeg: tweak parser API. ... to allow for more consistent parsing API among various codec parsers. In particular, drop use of GList. 2012-07-16 16:24:04 +0200 Gwenole Beauchesne * configure.ac: jpeg: fix configure check for VA/JPEG decoding API. 2012-06-26 15:18:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiprofile.c: jpeg: fix build with VA-API < 0.32.0. 2012-06-26 15:04:58 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-06-26 15:02:44 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-06-26 14:46:40 +0200 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.7. 2012-06-26 13:34:39 +0200 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-06-25 16:07:55 +0800 Yan Yin * gst/vaapi/gstvaapipluginutil.c: vaapiplugin: fix build when compiling without GLX. Signed-off-by: Gwenole Beauchesne 2012-06-26 11:03:25 +0200 Gwenole Beauchesne * configure.ac: configure: disable FFmpeg-based decoders. FFmpeg decoders are still available through the --enable-ffmpeg option but are no longer maintained. 2012-06-25 17:25:44 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: Fix build with recent GStreamer stack. 2012-06-25 17:10:49 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: update to current VA/JPEG decoding API. 2012-06-21 16:06:47 +0200 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: codecparsers: jpeg: track valid quantization and Huffman tables. Add valid flag to GstJpegQuantTable and GstJpegHuffmanTable so that to determine whether a table actually changed since the last user synchronization point. That way, this makes it possible for some hardware accelerated decoding solution to upload only those tables that changed. 2012-06-05 10:10:22 +0800 Wind Yuan * gst-libs/gst/codecparsers/gstjpegparser.c: codecparsers: jpeg: use U_READ_UINT*() wherever possible. Use GstByteReader *_unchecked() variants as much as possible. Signed-off-by: Gwenole Beauchesne 2012-06-04 16:20:13 +0800 Wind Yuan * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: add new GstJpegHuffmanTables structure. Add new GstJpegHuffmanTables helper structure to hold all possible AC/DC Huffman tables available to all components. Signed-off-by: Gwenole Beauchesne 2012-06-04 15:52:19 +0800 Wind Yuan * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: make gst_jpeg_parse() support multiple scans. gst_jpeg_parse() now gathers all scans available in the supplied buffer. A scan comprises of the scan header and any entropy-coded segments or restart marker following it. The size and offset to the associated data (ECS + RST segments) are append to a new GstJpegScanOffsetSize structure. Signed-off-by: Gwenole Beauchesne 2012-04-19 23:50:14 +0800 Wind Yuan * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: jpeg: update to match latest parser API. Signed-off-by: Gwenole Beauchesne 2012-04-13 01:58:39 -0400 Gwenole Beauchesne * gst-libs/gst/codecparsers/gstjpegparser.h: jpeg: simplify and optimize parser API. 2012-04-18 22:30:45 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg: fix picture used to determine backward_reference_vop_coding_type. Complete fix brought by bf9f77b1afb0829b97e2d502057aec973c5fd7f5 but Gwenole did not apply all the bits. Signed-off-by: Gwenole Beauchesne 2012-04-27 04:13:00 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: map Simple_Scalable profile to Advanced_Simple profile. Signed-off-by: Gwenole Beauchesne 2012-04-27 04:10:17 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: handle skipped frames (vop_hdr->coded = 0). Gracefully skip non VOP coded frames. Signed-off-by: Gwenole Beauchesne 2012-04-26 04:00:41 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: fix timestamp issues on too fast playback. Improve generation of presentation timestamps to be less sensitive to input stream errors. In practise, GOP is also a synchronization point for PTS calculation. Signed-off-by: Gwenole Beauchesne 2012-04-16 10:02:29 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: Fix build without JPEG decoder. 2012-04-12 11:48:24 +0200 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: fix VOP coding type of backward reference pictures. Signed-off-by: Gwenole Beauchesne 2012-04-11 23:02:45 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: fix handling of temporal reference distances. TRD and TRB fields are not large enough to hold the difference of PTS expressed with nanosecond resolution. So, compute them from the original VOP info. Signed-off-by: Gwenole Beauchesne 2012-04-12 11:00:22 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: dpb: mpeg2: cosmetics. Define MAX_MPEG2_REFERENCES to 2 and avoid magic numbers all around. 2012-02-10 00:21:04 +0800 Wind Yuan * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_jpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst/vaapi/gstvaapidecode.c: Add initial JPEG decoder. Signed-off-by: Gwenole Beauchesne 2012-02-10 00:21:04 +0800 Wind Yuan * configure.ac: * gst-libs/gst/Makefile.am: * gst-libs/gst/codecparsers/Makefile.am: * gst-libs/gst/codecparsers/gstjpegparser.c: * gst-libs/gst/codecparsers/gstjpegparser.h: * gst-libs/gst/vaapi/Makefile.am: codecparsers: add JPEG parser. Signed-off-by: Gwenole Beauchesne 2012-04-10 13:29:10 +0200 Wind Yuan * gst/vaapi/gstvaapidecode.c: vaapidecode: fix VA display type. Fix typo whereby plain VADisplay type was used instead of the GstVaapiDisplay wrapper. Signed-off-by: Gwenole Beauchesne 2012-04-10 14:28:31 +0200 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix includes when compiling for a single API. 2012-04-02 18:42:12 +0200 Gwenole Beauchesne * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix calculation of macroblock_offset. Fix decoding of streams with extra slice() information before the first macroblock(). e.g. this fixes sony-ct3.bs from conformance test. 2012-04-02 18:09:21 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix interpolation of GOP TSN from new PTS. New GOP TSN base could be mis-calculated. In particular, this fixes decoding of uruseiyatsura.vob from . 2012-04-02 16:07:58 +0200 Gwenole Beauchesne * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: mpeg2: fix decoding of high profile streams. Allow MPEG-2 High profile streams only if the HW supports that profile or no High profile specific bits are used, and thus Main profile could be used instead. i.e. chroma_format is 4:2:0, intra_dc_precision is not set to 11 and no sequence_scalable_extension() was parsed. 2012-04-02 14:51:06 +0200 Gwenole Beauchesne * NEWS: * gst/vaapi/gstvaapidecode.c: vaapidecode: report unsupported codec profiles. Try to gracefully abort when the HW does not support the requested profile. There is no fallback unless profiles are correctly parsed and matched through caps beforehand. 2012-02-07 15:23:22 +0100 Holger Kaelberer * NEWS: * gst/vaapi/gstvaapisink.c: vaapisink: don't resize a 'foreign' X-window. Don't forcibly resize foreign X windows. The user is responsible for their size and vaapisink shall not change this. Signed-off-by: Gwenole Beauchesne 2012-02-07 15:21:05 +0100 Holger Kaelberer * NEWS: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: vaapisink: recalculate render rect only if caps are negotiated. Fix gst_vaapisink_xoverlay_set_window_handle() when it is called before caps got negotiated. Besides, when a foreign window is provided by the user, so should the render rect. Signed-off-by: Gwenole Beauchesne 2012-04-02 13:07:34 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-04-02 10:07:33 +0200 Gwenole Beauchesne * configure.ac: 0.3.6. 2012-04-02 12:52:54 +0200 Gwenole Beauchesne * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapipostproc.c: Fix a few documentation issues. 2012-04-02 10:05:57 +0200 Gwenole Beauchesne * NEWS: * README: Update introduction and changelog. 2012-04-02 11:29:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: allocate dummy picture for first field based I-frame. In P-pictures, prediction shall be made from the two most recently decoded reference fields. However, when the first I-frame is a field, the next field of the current picture could be a P-picture but only a single field was decoded so far. In this case, create a dummy picture with POC = -1 that will be used as reference. Some VA drivers would error out if P-pictures don't have a forward reference picture. This is true in general but not in this very specific initial case. 2012-04-02 10:43:30 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix simple to main profile fallback. Allow fallback from simple to main profile when the HW decoder does not support the former profile and that no sequence_header_extension() is available to point out this. 2012-03-30 03:04:40 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: improve error checking while decoding packets. decode_picture() could return an error when an MPEG-4 profile is not supported for example. In this case, the underlying VA context is not allocated and no other proper action can be taken. Likewise on exit from decode_slice(). Signed-off-by: Gwenole Beauchesne 2012-03-30 17:03:28 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: use POC to maintain the DPB. Introduce a POC field in GstVaapiPicture so that to store simpler sequential numbers. A signed 32-bit integer should be enough for 1 year of continuous video streaming at 60 Hz. Use this new POC value to maintain the DPB, instead of 64-bit timestamps. This also aligns with H.264 that will be migrated to GstVaapiDpb infrastructure. 2012-03-30 16:23:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: rework generation of presentation timestamps. Always prefer PTS from the demuxer layer for GOP times. If this is invalid, i.e. demuxer could not determine the PTS or the generated PTS is lower than max PTS from past pictures, then try to fix it up based on the duration of a frame. For picture PTS, simply use the GOP PTS formerly computed then use TSN to reconstruct a current time. Also now handle wrapped TSN correctly. 2012-03-30 17:07:39 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: ignore empty user-data packets. Fix tcela-8.bits conformance test. 2012-03-29 11:13:20 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: review and report errors accordingly. Use GST_ERROR() to report real errors instead of hiding them into GST_DEBUG(). 2012-03-28 19:15:47 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix invalid interlaced frame in progressive sequence. Some streams, badly constructed, could have signaled an interlaced frame while the sequence was meant to be progressive. Warn and force frame to be progressive in this case. 2012-03-28 16:08:29 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: mpeg2: add support for interlaced streams. Pictures are submitted to the HW for rendering only when both fields are decoded or current picture is a full frame. 2012-03-28 14:36:30 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.c: * gst-libs/gst/vaapi/gstvaapidecoder_dpb.h: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: add new decoded picture buffer infrastructure. Decoded pictures are now maintained into DPB, similarly to H.264. The same mechanism could be re-used for VC-1 and MPEG-4:2 codecs. 2012-03-28 17:50:28 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: add first-field flag to picture. Add first-field (FF) flag to GstVaapiPicture, thus not requiring is_first_field member in each decoder. Rather, when a GstVaapiPicture is created, it is considered as the first field. Any subsequent allocated field will become the second field. 2012-03-28 16:05:58 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: allow pictures to be cloned for field decoding. Add gst_vaapi_picture_new_field() function that clones a picture, while preserving the parent picture surface. i.e. the surface proxy reference count is increased and other fields copied as is. Besides, the picture is reset into a "non-output" mode. 2012-03-28 16:07:44 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: rework picture field flags. Add top-field-first (TFF) and interlaced flags to GstVaapiPicture so they could be propagated to the surface proxy when it is pushed for rendering. Besides, top and bottom fields are now expressed with picture structure flags from GstVaapiSurfaceRenderFlags. 2012-03-28 14:28:26 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: add OUTPUT flag to pictures. Allow pictures to be marked as output gst_vaapi_picture_output(). 2012-03-28 14:24:40 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: fix semantics of SKIPPED pictures. If GstVaapiPicture has flag SKIPPED set, this means gst_vaapi_picture_output() will not push the underlying surface for rendering. Besides, VC-1 skipped P-frame has nothing to do with rendering. This only means that the currently decoded picture is just a copy of its reference picture. 2012-03-28 15:16:17 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst/vaapi/gstvaapipostproc.c: vaapipostproc: get "interlaced" attribute from surface proxy. Add new "interlaced" attribute to GstVaapiSurfaceProxy. Use this in vaapipostproc so that to handles cases where bitstream is interlaced but almost only frame pictures are generated. In this case, we should not be alternating between top/bottom fields. 2012-03-26 14:37:24 +0200 Gwenole Beauchesne * README: * debian.upstream/control.in: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapipostproc.c: * gst/vaapi/gstvaapipostproc.h: vaapipostproc: add new element for video postprocessing. Add vaapipostproc element for video postprocessing. So far, only basic bob deinterlacing is implemented. Interlaced mode is automatically detected based on sink caps ("interlaced" field). 2012-03-26 12:01:36 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapisink.c: videobuffer: add surface render flags. Allow rendering flags, as a combination of GstVaapiSurfaceRenderFlags, to be set to the video buffer. In particular, this is mostly useful for basic deinterlacing. 2012-03-23 17:13:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicompat.h: compat: add compatibility glue with VA-API 0.34+ (WIP). 2012-03-23 17:11:18 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: skip all Filler Data NALs. 2012-03-22 03:28:22 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: mpeg4: check for decoder status prior to decoding packet. Make sure there is a VA surface free prior to decoding the current frame. Signed-off-by: Gwenole Beauchesne 2012-03-15 04:58:04 -0400 Wind Yuan * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: decode: delay NEWSEGMENT event if vaapidecode element was not linked. Rationale: playbin2 links all elements at run-time. Once vaapidecode is created and a NEWSEGMENT event arrives, downstream element may not be ready yet. So, delay this event until next element is chained in, otherwise basesink could output "Received buffer without a new-segment. Assuming timestamps start from 0". Signed-off-by: Gwenole Beauchesne 2012-03-13 20:33:41 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix GOP timestamps when incorrect data is received. Some streams have incorrect GOP timestamps, or nothing set at all. i.e. GOP time is 00:00:00 for all GOPs. Try to recover in this case from demuxer timestamps, which are monotonic. Signed-off-by: Gwenole Beauchesne 2012-03-13 02:03:31 -0400 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: don't decode anything before the first sequence_header(). Skip all pictures prior to the first sequence_header(). Besides, skip all picture_data() if there was no prior picture_header(). Signed-off-by: Gwenole Beauchesne 2012-02-07 15:57:14 +0100 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: ffmpeg: add support for interlaced streams. Evaluate interlaced stream properties. Signed-off-by: Gwenole Beauchesne 2012-02-07 15:54:15 +0100 Holger Kaelberer * gst/vaapi/gstvaapidecode.c: vaapidecode: propagate interlaced and TFF properties downstream. Propagate "interlaced" caps downstream and set "tff" buffer flag appropriately to output buffers for interlaced pictures. Signed-off-by: Gwenole Beauchesne 2012-02-07 15:54:15 +0100 Holger Kaelberer * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: maintain caps for interlaced streams. Extend GstVaapiDecoder base object to maintain caps with "interlaced" property. Signed-off-by: Gwenole Beauchesne 2012-02-07 15:54:15 +0100 Holger Kaelberer * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: surfaceproxy: add TFF property. Add TFF (top-field-first) property to GstVaapiSurfaceProxy. Signed-off-by: Gwenole Beauchesne 2012-03-16 14:21:36 +0100 Gwenole Beauchesne * AUTHORS: AUTHORS: update to match current authors. 2012-02-28 11:58:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix is_first_field calculation. Reset is_first_field for frame pictures. Factor out locations where the flag is updated. 2012-02-24 12:56:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: catch incorrect picture_structure from bitstreams. Assume "frame" picture structure if the syntax element was zero or if progressive_frame is set. 2012-02-24 12:53:30 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix slice_vertical_position calculation (again). VA-API expects slice_vertical_position as the initial position from the bitstream. i.e. the direct slice() information. VA drivers will be fixed accordingly. 2012-03-02 15:03:57 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: Revert "vaapidecode: fix another pad template ref leak" (Holger Kaelberer) This reverts commit 2f127d6af473afd647a2c88f75faafd1cd718437. For gst_element_class_get_pad_template(), no unreferencing is necessary according to the GStreamer documentation. 2012-03-02 13:41:16 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix slice_data_bit_offset calculation. Unlike what VA-API documentation defines, the slice_data_bit_offset represents the offset to the first macroblock in the slice data, minus any emulation prevention bytes in the slice_header(). This fix copes with binary-only VA drivers that won't be fixed any time soon. Besides, this aligns with the current FFmpeg behaviour that was based on those proprietary drivers implementing the API incorrectly. 2012-02-21 02:11:20 -0500 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: skip all Access Unit (AU) NALs. Signed-off-by: Gwenole Beauchesne 2012-02-29 03:08:46 -0500 Wind Yuan * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix modification process of reference picture lists. Construction of RefPicList0/1 could be off by one element. Signed-off-by: Gwenole Beauchesne 2012-02-12 11:21:52 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix size calculation from sequence_extension(). Original values from sequence_header() are 12-bit and the remaining 2 most significant bits are coming from sequence_extension(). Signed-off-by: Gwenole Beauchesne 2012-02-23 16:39:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix slice_vertical_position calculation. Make sure to adjust slice_vertical_position if picture structure is a top or bottom field. 2012-02-23 16:23:27 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: add picture structure flags. 2012-02-23 14:42:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix decoding at end-of-sequence. 2012-02-23 14:17:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix slice_horizontal_position calculation. 2012-02-23 16:14:02 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: drop useless mb_y and mb_height members. 2012-02-23 11:19:48 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix decoding of multiple slices with same slice_vertical_position. 6.3.15 says that "some slices may have the same slice_vertical_position, since slices may start and finish anywhere". So, we can't submit the current picture to the HW right away since subsequent slices would be missing. 2012-02-15 14:08:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: fix source stride in picture copy. 2012-02-13 10:10:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: fix double buffer free with some VA drivers. vaRenderPicture() implicitly disposes VA buffers. Some VA drivers would push the VA buffer object into a list of free buffers to be re-used. However, reference pictures (and data) that was kept would explicitly release the VA buffer object later on, thus possibly destroying a valid (re-used) object. Besides, some other VA drivers don't support correctly the vaRenderPicture() semantics for VA buffers disposal and would leak memory if there is no explicit vaDestroyBuffer(). The temporary workaround is to explcitily destroy VA buffers right after vaRenderPicture(). All VA drivers need to be aligned. 2012-02-08 18:08:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: complete any current picture decoder before SPS / PPS change. This ensures the VA context is clear when the encoded resolution changes. i.e. make sure older picture is decoded with the older VA context before it changes. 2012-02-08 18:07:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: create VA context earlier when SPS is parsed. 2012-02-08 17:57:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: don't allocate too big data structures on stack. 2012-02-07 11:07:15 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: glib: map deprecated API to glib >= 2.32 equivalents. GStaticMutex and GStaticRecMutex are now replaced with GMutex and GRecMutex, which no longer require any prior call to g_thread_init(). 2012-02-07 10:01:01 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: glib: fix includes. 2012-02-07 10:05:53 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: cosmetics: fix warnings (drop unused variables). 2012-02-06 16:11:38 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix another pad template ref leak. 2012-02-06 15:54:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: mpeg2: fix crash when there is no free surface to decode into. 2012-01-31 16:38:58 +0800 Zhao Halley * gst-libs/gst/vaapi/gstvaapidisplay.c: display: skip profiles which have no entrypoints. Signed-off-by: Gwenole Beauchesne 2012-02-05 18:28:51 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiupload.c: vaapiupload: use g_object_unref() for GstVaapiImage. 2012-02-05 18:24:08 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: plugins: fix pad template ref leaks. 2012-02-02 09:23:15 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-02-01 23:34:09 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.4. 2012-02-01 23:32:47 +0100 Gwenole Beauchesne * README: README: updates. Mention codecparsers-based decoders, FFmpeg is now optional. Update list of support HW. 2012-02-01 23:28:23 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-01-31 11:34:17 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: allocate proxy surface earlier. This simplifies gst_vaapi_picture_output() to only update the presentation timestamp and submit the proxy to the decoder for output. 2012-01-31 11:26:37 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: decoder: fix memory leak of VA objects on exit. On sequence end, if the last decoded picture is not output for rendering, then the proxy surface is not created. In this case, the original surface must be released explicitly to the context. 2012-01-31 10:47:36 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: use GstAdapter to track input sequence. This fixes possible memory leaks and improves performance by removing some extra copies. 2012-01-30 18:25:03 +0100 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/glibcompat.h: * gst-libs/gst/vaapi/sysdeps.h: Add glib compatibility glue for older versions. 2012-01-30 18:12:59 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/sysdeps.h: Add header for system-dependent definitions. 2012-01-30 10:15:32 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: decoder: optimize slice data buffers initialization. VA drivers may have a faster means to transfer user buffers to GPU buffers than using memcpy(). In particular, on Intel Gen graphics, we can use pwrite(). This provides for faster upload of bitstream and can help higher bitrates. vaapi_create_buffer() helper function was also updated to allow for un-mapped buffers and pre-initialized data for buffers. 2012-01-27 17:28:50 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: simplify RefPicList reconstruction. 2012-01-27 16:08:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: flush DPB when the end of the sequence is reached. 2012-01-24 15:38:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: handle Decoded Picture Buffer (DPB). 2012-01-24 09:20:25 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix pred_weight_table() reconstruction. Only the explicit pred_weight_table(), possibly with the inferred default values, shall be required. e.g. don't fill in the table if weighted_pred_flag is not set for P/SP slices. 2012-01-23 15:03:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: execute reference picture marking process (MMCO). 2012-01-23 15:20:51 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: fix presentation timestamps. 2012-01-18 13:38:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: execute reference picture marking process (sliding window). 2012-01-17 10:42:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: handle avcC format for decoding buffers. 2011-11-25 14:37:00 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: h264: handle codec-data. Signed-off-by: Gwenole Beauchesne 2011-08-12 17:43:55 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_h264.c: * gst-libs/gst/vaapi/gstvaapidecoder_h264.h: * gst/vaapi/gstvaapidecode.c: * tests/test-decode.c: Add initial H.264 decoder. 2012-01-26 15:28:42 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: decoder: retain proxy surface until the GstVaapiPicture is destroyed. Keep a valid reference to the proxy in GstVaapiPicture so that frames marked as "used for reference" could be kept during the lifetime of the picture. i.e. don't release them too soon as they could be re-used right away. 2012-01-26 15:19:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: properly reference count pictures. This fixes cases where a GstVaapiPicture would be destroyed whereas there is still a valid instance of it in either prev, current or next picture. 2012-01-26 14:54:31 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: simplify output of decoded frames. Drop obsolete gst_vaapi_decoder_push_surface() that was no longer used. Change gst_vaapi_decoder_push_surface_proxy() semantics to assume PTS is already set correctly and reference count increased, if necessary. 2012-01-26 09:48:11 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicodec_objects.c: * gst-libs/gst/vaapi/gstvaapicodec_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.c: * gst-libs/gst/vaapi/gstvaapidecoder_objects.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: decoder: rework the internal VA objects API. The new API simplifies a lot reference counting and makes it more flexible for future additions/changes. The GstVaapiCodecInfo is also gone. Rather, new helper macros are provided to allocate picture, slice and quantization matrix parameter buffers. 2012-01-24 10:21:45 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: allow slices to be attached to pictures later. 2011-11-21 18:39:49 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: add ref_count to GstVaapiPicture. 2012-01-23 11:48:42 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: cap window size to the maximum display size. 2012-01-18 10:23:41 +0100 Zhao Halley * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiworkarounds.h: profile: match video/x-h263 as H.263 Baseline profile. HACK: qtdemux does not report profiles for H.263. So, assume plain "video/x-h263" is H.263 Baseline profile. Signed-off-by: Gwenole Beauchesne 2012-01-18 10:22:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiworkarounds.h: display: report H.263 Baseline profile. HACK: expose GST_VAAPI_PROFILE_H263_BASELINE for decoding if MPEG-4:2 Simple profile (VAProfileMPEG4Simple) is supported. 2012-01-24 10:06:37 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiworkarounds.h: Add template for workarounds. 2012-01-18 10:47:56 +0100 Gwenole Beauchesne * tests/test-decode.c: tests: error out if FFmpeg|codecparsers are not supported. 2012-01-18 10:42:38 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: surface: don't expose gst_vaapi_surface_get_parent_context(). gst_vaapi_surface_get_parent_context() was not meant to be exposed globally. It's just an internal helper function. However, it's still possible to get the parent context through the "parent-context" property. 2012-01-16 14:19:00 +0100 Gwenole Beauchesne * tests/Makefile.am: * tests/test-subpicture.c: tests: fix build without FFmpeg. 2012-01-16 14:09:57 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-01-16 11:05:31 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.3. 2012-01-16 11:03:51 +0100 Gwenole Beauchesne * README: * debian.upstream/copyright: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: * tests/test-decode.c: legal: fix year for some copyright notices. 2012-01-16 10:42:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.h: * tests/test-decode.c: legal: add Intel copyright on modified files. 2012-01-16 10:41:10 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapi_priv.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: * tests/image.c: * tests/image.h: * tests/test-decode.c: * tests/test-decode.h: * tests/test-display.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-vc1.h: * tests/test-windows.c: legal: fix copyright notices to include "Copyright" term. 2011-12-09 16:44:03 +0800 Zhao Halley * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: mpeg4: replace GstVaapiTSB with GstAdapter (gst-plugins-base >= 0.10.24). Signed-off-by: Gwenole Beauchesne 2011-12-09 16:28:11 +0800 Zhao Halley * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.h: * gst/vaapi/gstvaapidecode.c: Add initial MPEG-4 decoder. Signed-off-by: Gwenole Beauchesne 2011-11-18 15:41:40 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: vc1: replace GstVaapiTSB with GstAdapter (gst-plugins-base >= 0.10.24). Signed-off-by: Gwenole Beauchesne 2011-10-07 11:50:20 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix codec-data decoding for WMV3 format. 2011-10-07 11:12:33 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix presentation timestamps. 2011-10-06 15:59:22 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix MV mode packing. 2011-10-05 16:41:57 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: handle codec-data. 2011-10-05 15:56:36 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: handle encapsulated bitstreams. 2011-10-04 17:51:51 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix bitplanes decoding. 2011-10-04 14:15:55 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix BFRACTION reconstruction. 2011-09-30 17:16:23 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: vc1: fix framerate calculation. 2011-09-30 13:40:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.c: * gst-libs/gst/vaapi/gstvaapidecoder_vc1.h: * gst/vaapi/gstvaapidecode.c: * tests/test-decode.c: Add initial VC-1 decoder. 2012-01-09 17:37:34 +0100 Zhao Halley * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix first field detection. Signed-off-by: Gwenole Beauchesne 2012-01-06 16:44:09 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix quantisation matrix construction. 2011-11-18 15:06:07 +0200 Sreerenj Balachandran * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: mpeg2: replace GstVaapiTSB API with GstAdapter (gst-plugins-base >= 0.10.24). Signed-off-by: Gwenole Beauchesne 2011-09-14 18:11:57 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: fix packets spanning over two buffers. 2011-09-12 18:20:00 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: ignore system start codes (PES headers). 2011-09-12 18:02:53 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: mpeg2: handle closed_gop. 2011-08-05 11:55:11 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.c: * gst-libs/gst/vaapi/gstvaapidecoder_mpeg2.h: * gst/vaapi/gstvaapidecode.c: * tests/test-decode.c: Add initial MPEG-2 decoder. 2011-08-12 10:21:19 +0200 Gwenole Beauchesne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst/vaapi/gstvaapidecode.c: * tests/test-decode.c: Allow conditional build of GStreamer/FFmpeg bitstream parsers. 2011-08-05 11:53:50 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Add VA decoder helpers. 2011-08-05 11:52:43 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.h: decoder: add new error codes. GST_VAAPI_DECODER_STATUS_ERROR_UNSUPPORTED_PROFILE: for unsupported profile GST_VAAPI_DECODER_STATUS_ERROR_UNSUPPORTED_CHROMA_FORMAT: for unsupported chroma format 2011-09-12 13:00:59 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_tsb.c: * gst-libs/gst/vaapi/gstvaapiutils_tsb.h: Add timestamp buffer store helper utils. 2011-08-04 17:29:41 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: Add VA buffer helpers. 2012-01-13 15:03:38 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.c: utils: slight improvements to gl_bind_texture(). 2012-01-13 14:13:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.c: utils: pretty-print output of gl_get_error_string(). 2012-01-13 14:03:29 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_glx.c: utils: rewrite gl_perspective() as per OpenGL FAQ 9.085. 2012-01-13 12:09:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils.c: utils: simplify string of VAProfile/VAEntrypoint. 2012-01-13 11:46:55 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: utils: drop string_of_FOURCC() in favor of standard GST_FOURCC_* helpers. 2012-01-12 17:18:47 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-01-12 15:34:59 +0100 Gwenole Beauchesne * tests/test-decode.c: tests: check for shared VA displays (display cache). 2012-01-12 15:30:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: always free VA display cache if it is empty. 2012-01-12 15:03:04 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: display: use VA display cache for X11 and GLX winsys. 2012-01-12 12:46:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplaycache.c: * gst-libs/gst/vaapi/gstvaapidisplaycache.h: display: implement a VA display cache. 2012-01-11 14:13:06 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: vaapiplugin: fix gst_vaapi_ensure_display() to use system defaults. This ensures the display name provided to gst_vaapi_display_*_new() maps to the system defaults, instead of forcing "" that could be different from the current DISPLAY name. 2011-08-26 15:44:25 -0400 Nicolas Dufresne * gst/vaapi/gstvaapiupload.c: vaapiupload: only set caps on newly created buffers. Signed-off-by: Gwenole Beauchesne 2012-01-11 14:11:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: ensure VA display in GstBaseSink::start() hook. This ensures a VA display is ready by the time upstream elements request for it. 2011-08-26 15:44:46 -0400 Nicolas Dufresne * gst/vaapi/gstvaapisink.c: vaapisink: don't leak GL texture. Signed-off-by: Gwenole Beauchesne 2012-01-09 16:51:35 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: fix calculation of render region. 2012-01-09 11:23:39 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: automatically fit video to window. 2012-01-09 10:37:30 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: implement GstXOverlay::set_render_rectangle(). 2012-01-09 11:04:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiwindow.c: window: always check geometry when the window is mapped. 2012-01-06 17:51:59 +0100 Zhao Halley * gst-libs/gst/vaapi/gstvaapiutils.c: Add missing profiles from VA-API 0.32.0. Signed-off-by: Gwenole Beauchesne 2012-01-06 16:48:15 +0100 Gwenole Beauchesne * .gitignore: .gitignore: add test-subpicture. 2012-01-06 11:23:21 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-01-06 11:20:48 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.2. 2012-01-06 11:18:55 +0100 Gwenole Beauchesne * tests/Makefile.am: tests: fix make dist (ship with test-subpicture-data.h). 2012-01-05 17:35:12 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2012-01-05 17:09:35 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: fix possible leak of VA surfaces. Under some circumstances, we could have leaked a surface, thus not releasing it to the pool of available surfaces in the VA context. The strategy is now to use a proxy earlier and automatically ref/unref whenever necessary. In particular, during the lifetime needed for FFmpeg. 2012-01-05 16:59:57 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: surfaceproxy: add helper to retrieve the VA surface ID. 2012-01-05 16:44:44 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: surfaceproxy: simplify destruction. Also make sure to always make sure to release the surface back to the pool of surfaces in the associated VA context, if any. 2012-01-05 16:26:49 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapidecode.c: vaapidecode: fix deinitialization order. 2012-01-05 14:50:26 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapicontext.c: context: avoid self reference loops with surfaces. 2012-01-05 11:23:01 +0100 Gwenole Beauchesne * debian.upstream/control.in: debian: update control.in description for new plugins. 2012-01-05 11:01:56 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiupload.c: vaapiupload: use new gst_vaapi_append_surface_caps() helper. This also fixes extra structures, beyond the one at index 0, to hold the right additional values. 2012-01-05 10:55:34 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiupload.c: vaapiupload: fix sink (YUV) caps to not report type and opengl fields. 2012-01-05 10:50:59 +0100 Gwenole Beauchesne * README: * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapidownload.c: * gst/vaapi/gstvaapidownload.h: vaapidownload: add new plugin to download pixels from VA surfaces. 2012-01-05 11:00:39 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: vaapipluingutils: add helper to append surface caps to YUV caps. 2012-01-05 10:29:48 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: image: add helpers to extract pixels to user buffers. 2012-01-04 11:34:34 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: simplify initialization of raw images from video buffers. 2012-01-04 11:29:11 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: image: fix update from NV12 buffers. 2012-01-03 18:16:35 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiupload.c: vaapiupload: fix memory leak in _init() function. 2012-01-03 14:34:09 +0100 Gwenole Beauchesne * NEWS: * README: * debian.upstream/control.in: * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiupload.c: * gst/vaapi/gstvaapiupload.h: Rename vaapiconvert element to vaapiupload. 2012-01-03 13:54:03 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2012-01-03 13:42:12 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.1. 2011-12-14 15:22:24 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2011-12-14 14:40:37 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapisink.c: surface: apply composition to the parent context, if requested. 2011-12-14 14:35:13 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: context: make it possible to apply composition globally. 2011-12-14 14:13:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: fix associate subpicture to not report deassociation errors. 2011-12-14 13:46:26 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: fix typo in debug message. 2011-12-14 13:16:21 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: subpicture: add helper to create subpicture from GstVideoOverlayRectangle. 2011-12-13 16:53:15 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurface_priv.h: surface: record parent context. 2011-12-13 15:59:02 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: Fix warnings. 2011-12-13 15:51:58 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst/vaapi/gstvaapisink.c: Rename gst_vaapi_surface_update_composition() to gst_vaapi_surface_set_subpictures_from_composition(). 2011-12-13 13:40:55 +0100 Gwenole Beauchesne * configure.ac: configure: check for GstVideoOverlayComposition. 2011-12-12 18:42:44 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2011-11-25 15:00:25 -0500 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: converter: add support for GstVideoOverlayComposition planes. Signed-off-by: Gwenole Beauchesne 2011-11-23 16:45:46 -0300 Thibault Saunier * gst/vaapi/gstvaapisink.c: vaapisink: handle GstVideoOverlayComposition planes. Signed-off-by: Gwenole Beauchesne 2011-12-12 18:27:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: use unscaled overlay rectangle for blending. 2011-12-12 18:37:13 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.c: surface: fix VA image leak when an error occurred. 2011-11-25 14:59:56 -0500 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: surface: add helper to handle GstVideoOverlayComposition. This helper resets the subpictures to reflect the current composition layers provided with the buffers. Signed-off-by: Gwenole Beauchesne 2011-12-12 18:13:19 +0100 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst/vaapi/gstvaapiconvert.c: image: add gst_vaapi_image_format_from_video() helper. 2011-12-12 16:34:07 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: image: allow updates from GstVaapiImageRaw. 2011-12-12 14:34:03 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst/vaapi/gstvaapiconvert.c: * tests/test-subpicture.c: image: allow partial updates. 2011-12-12 15:31:52 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisubpicture.c: subpicture: fix doc for gst_vaapi_subpicture_set_image(). 2011-12-12 13:39:20 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: fix has_image_format() to check against subpicture formats. 2011-10-17 18:43:15 +0200 Gwenole Beauchesne * tests/test-subpicture.c: tests: fix subpicture test. 2011-10-14 13:00:12 -0300 Thibault Saunier * tests/Makefile.am: * tests/test-subpicture-data.c: * tests/test-subpicture-data.h: * tests/test-subpicture.c: tests: add test for subpictures. Signed-off-by: Gwenole Beauchesne 2011-11-25 12:28:04 -0500 Nicolas Dufresne * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapidecode.c: Add missing video context queries. Signed-off-by: Gwenole Beauchesne 2011-12-12 13:22:07 +0100 Gwenole Beauchesne * configure.ac: Bump version for development. 2011-12-12 10:04:32 +0100 Gwenole Beauchesne * gst-libs/gst/video/Makefile.am: * gst-libs/gst/video/gstbasevideocodec.c: * gst-libs/gst/video/gstbasevideocodec.h: * gst-libs/gst/video/gstbasevideodecoder.c: * gst-libs/gst/video/gstbasevideodecoder.h: * gst-libs/gst/video/gstbasevideoutils.c: * gst-libs/gst/video/gstbasevideoutils.h: Drop unused copy of GstBaseVideoDecoder. 2011-12-09 11:46:45 +0100 Gwenole Beauchesne * NEWS: * configure.ac: 0.3.0. 2011-12-09 11:38:43 +0100 Gwenole Beauchesne * README: README: update dependencies. 2011-12-09 11:38:34 +0100 Gwenole Beauchesne * NEWS: NEWS: updates. 2011-12-09 11:20:04 +0100 Gwenole Beauchesne * configure.ac: configure: check for GstBaseSink 'query' vfunc. 2011-12-09 10:45:20 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: vaapiplugin: include local build dir to CFLAGS for generated files. 2011-12-09 10:44:52 +0100 Gwenole Beauchesne * autogen.sh: autogen: don't configure if NO_CONFIGURE variable is set. 2011-12-08 11:54:59 +0100 Sreerenj Balachandran * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: vaapidecode: return sink caps template if decoder is in NULL state. Otherwise, the decoder would always create its own X display instead of probing it from the downstream element, which is not reliable. e.g. DISPLAY is not :0 or when running on Wayland. Signed-off-by: Gwenole Beauchesne 2011-12-08 15:44:09 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapidecode.c: vaapiplugin: properly set surface type to "vaapi" in caps. 2011-12-08 15:16:14 +0100 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: decoder: drop unused headers. 2011-11-04 19:47:25 -0400 Nicolas Dufresne * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapidecode.c: vaapiplugin: properly set opengl support in caps. Signed-off-by: Gwenole Beauchesne 2011-11-04 20:07:52 -0400 Nicolas Dufresne * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapidecode.c: vaapiplugin: allocate GLX buffers when supported. Signed-off-by: Gwenole Beauchesne 2011-11-04 19:47:09 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.c: * gst-libs/gst/vaapi/gstvaapivideobuffer_glx.h: * gst-libs/gst/vaapi/gstvaapivideobuffer_priv.h: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.c: * gst-libs/gst/vaapi/gstvaapivideoconverter_glx.h: videobuffer: add GLX buffer support. Signed-off-by: Gwenole Beauchesne 2011-10-06 16:06:15 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Port to GstSurfaceBuffer interface. Signed-off-by: Gwenole Beauchesne 2011-10-06 16:04:37 -0400 Nicolas Dufresne * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapisink.c: Don't use downstream buffer allocation. With the new video/x-surface abstraction, we can't rely on having a VA specific sink downstream. Also, there was no particular reason to do that. Signed-off-by: Gwenole Beauchesne 2011-11-04 17:16:23 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapisink.c: * tests/Makefile.am: * tests/test-surfaces.c: Change caps to use new video/x-surface generic type. Signed-off-by: Gwenole Beauchesne 2011-11-04 16:50:15 -0400 Nicolas Dufresne * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_gst.c: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapipluginutil.c: * gst/vaapi/gstvaapipluginutil.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: Port to GstVideoContext interface. This new interface allows for upstream and downstream display sharing that works in both static and dynamic pipelines. Signed-off-by: Gwenole Beauchesne 2011-12-08 14:57:36 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: use GST_ERROR to print error messages. 2011-12-08 13:30:51 +0100 Gwenole Beauchesne * gst/vaapi/Makefile.am: vaapiplugin: link against VA/GLX when enabled. 2011-12-07 19:09:55 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapisink.c: Add Intel copyright information. 2011-12-07 19:04:09 +0100 Gwenole Beauchesne * gst/vaapi/gstvaapisink.c: vaapisink: allow compatibility with gst-plugins-base < 0.10.31. 2011-12-07 18:40:35 +0100 Gwenole Beauchesne * .gitignore: * configure.ac: * gst-libs/gst/Makefile.am: * gst-libs/gst/gstutils_version.h.in: Add new GStreamer version check utilities. 2011-07-28 11:14:49 +0300 Sreerenj Balachandran * gst/vaapi/gstvaapisink.c: vaapisink: replace the deprecated xoverlay API with the new one. Signed-off-by: Gwenole Beauchesne 2011-12-07 17:31:09 +0100 Gwenole Beauchesne * configure.ac: configure: allow for pre-releases. 2011-10-13 17:08:13 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: destroy display on creation failure. This allows element to detect that the display creation has actually failed. Signed-off-by: Gwenole Beauchesne 2011-10-13 17:07:35 -0400 Nicolas Dufresne * gst-libs/gst/vaapi/gstvaapidisplay.c: display: don't crash when config is empty. Signed-off-by: Gwenole Beauchesne 2011-12-07 14:42:14 +0100 Gwenole Beauchesne * README: * debian.upstream/copyright: doc: mention Collabora copyrights. 2011-12-07 14:40:20 +0100 Gwenole Beauchesne * .gitignore: .gitignore: refine for generated docs. 2011-09-14 15:12:41 -0400 Nicolas Dufresne * configure.ac: * docs/reference/plugins/Makefile.am: * gst/Makefile.am: * gst/vaapi/Makefile.am: * gst/vaapi/gstvaapi.c: * gst/vaapi/gstvaapiconvert.c: * gst/vaapi/gstvaapiconvert.h: * gst/vaapi/gstvaapidecode.c: * gst/vaapi/gstvaapidecode.h: * gst/vaapi/gstvaapisink.c: * gst/vaapi/gstvaapisink.h: * gst/vaapiconvert/Makefile.am: * gst/vaapidecode/Makefile.am: Group all plugins into the same bundle Signed-off-by: Gwenole Beauchesne 2011-07-21 14:31:30 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2011-12-07 14:17:32 +0100 Gwenole Beauchesne * configure.ac: * debian.upstream/control.in: debian: build against upstream libva packages. 2011-12-07 13:52:17 +0100 Gwenole Beauchesne * docs/reference/libs/Makefile.am: * docs/reference/plugins/Makefile.am: * tests/Makefile.am: Fix build on Ubuntu 11.10 (Oneric). 2011-12-07 13:14:28 +0100 Gwenole Beauchesne * NEWS: 0.2.7. 2011-09-12 16:20:16 -0400 Nicolas Dufresne * .gitignore: Adding ignore file Signed-off-by: Gwenole Beauchesne 2011-10-24 16:18:16 -0400 Nicolas Dufresne * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Update license in plugin definition Signed-off-by: Gwenole Beauchesne 2011-10-12 14:00:50 +0200 Gwenole Beauchesne * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder.c: decoder: fix use of invalid data at the end-of-stream. 2011-10-19 14:47:31 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: fix some warnings. 2011-10-19 14:43:56 +0200 Gwenole Beauchesne * configure.ac: * debian.upstream/changelog.in: * debian.upstream/control.in: * debian.upstream/copyright: * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Update with my current e-mail address. 2011-10-19 14:39:21 +0200 Gwenole Beauchesne * NEWS: * README: Splitted-Desktop systems relicensed plugins and tests to LGPL v2.1+. 2011-10-18 09:18:20 +0200 warly * tests/image.c: * tests/image.h: * tests/test-decode.c: * tests/test-decode.h: * tests/test-display.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-vc1.h: * tests/test-windows.c: switch tests licence to LGPL v2.1+ 2011-10-18 09:06:52 +0200 warly * COPYING: * README: * debian.upstream/copyright: * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapiconvert/gstvaapiconvert.h: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: * gst/vaapisink/gstvaapisink.c: * gst/vaapisink/gstvaapisink.h: move plugins to LGPL v2.1+ 2011-09-14 13:07:18 +0200 Gwenole Beauchesne * gst/vaapidecode/gstvaapidecode.c: vaapidecode: fix sink caps to not expose size information. This fixes this particular issue: GStreamer-WARNING **: pad vaapidecode0:sink returned caps which are not a real subset of its template caps 2011-09-14 11:34:05 +0200 Gwenole Beauchesne * NEWS: * gst/vaapidecode/gstvaapidecode.c: vaapidecode: fix decoding of MPEG-2 PS files. 2011-09-12 13:00:04 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/Makefile.am: Cosmetics (sort source files). 2011-09-08 14:50:24 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapiconvert/gstvaapiconvert.h: vaapiconvert: fix direct-rendering caps detection. 2011-09-08 14:40:08 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapiimage.c: Fix gst_vaapi_image_new_with_image(). 2011-09-08 13:09:17 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: warn when surface failed to be updated with image. 2011-09-06 18:34:33 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: fix autodetection for vaDeriveImage() support. 2011-09-06 17:47:10 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: fix memory leak (VA surface image). 2011-09-05 16:20:20 +0200 Gwenole Beauchesne * NEWS: * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: fix direct-rendering mode. 2011-09-06 16:49:43 +0200 Gwenole Beauchesne * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Add gst_vaapi_video_buffer_new_from_buffer(). Add helper function to bind a foreign buffer into a GstVaapiVideoBuffer. Any image, surface or surface proxy will be inherited from the source buffer if it is a GstVaapiVideoBuffer. 2011-09-05 17:23:05 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: protect access to direct_rendering. 2011-09-05 16:18:14 +0200 Gwenole Beauchesne * gst/vaapiconvert/gstvaapiconvert.c: vaapiconvert: use gst_vaapi_display_lookup_downstream() helper to get a VA display. 2011-08-01 14:15:39 +0200 Gwenole Beauchesne * NEWS: * README: * debian.upstream/copyright: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Add Intel copyright information. 2011-07-22 15:59:00 +0200 Gwenole Beauchesne * NEWS: Updates. 2011-07-22 15:55:47 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix build with newer FFmpeg versions. 2011-07-22 15:39:51 +0200 Gwenole Beauchesne * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Fix decoding of MPEG-2 TS files. 2011-07-22 15:34:48 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapidecoder.c: Report caps update only once per video resolution change. 2011-07-22 15:33:13 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapisurface.h: Add canonical form (type name) of VA surface caps. 2011-07-22 15:42:16 +0200 Gwenole Beauchesne * configure.ac: Bump version for development. 2011-07-19 17:38:40 +0200 Gwenole Beauchesne * configure.ac: Use pretty build output with automake >= 1.11. 2011-07-15 16:08:08 +0200 Gwenole Beauchesne * gst/vaapiconvert/Makefile.am: * gst/vaapidecode/Makefile.am: * gst/vaapisink/Makefile.am: * tests/Makefile.am: Fix build with libva headers not in a standard include dir. 2011-06-14 15:59:08 +0200 Gwenole Beauchesne * configure.ac: 0.2.6. 2011-06-14 13:52:56 +0200 Gwenole Beauchesne * gst-libs/gst/vaapi/gstvaapi_priv.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_gst.c: * gst-libs/gst/vaapi/gstvaapiutils_gst.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapiconvert/gstvaapiconvert.h: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: * gst/vaapisink/gstvaapisink.c: * gst/vaapisink/gstvaapisink.h: * tests/image.c: * tests/image.h: * tests/test-decode.c: * tests/test-decode.h: * tests/test-display.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-surfaces.c: * tests/test-textures.c: * tests/test-vc1.c: * tests/test-vc1.h: * tests/test-windows.c: Update copyright notice. 2011-06-14 13:51:41 +0200 Gwenole Beauchesne * NEWS: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapivalue.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Fix licensing terms. 2010-07-20 11:23:16 +0000 gb * NEWS: 0.2.5. 2010-07-20 11:21:37 +0000 gb * debian.upstream/copyright: Fix license terms... 2010-07-01 13:19:29 +0000 gb * gst/vaapisink/gstvaapisink.c: Render pretty background only in use-reflection=true mode. 2010-07-01 11:43:22 +0000 gb * NEWS: Updates. 2010-07-01 11:41:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Drop the GLX 1.3 requirement. 2010-07-01 11:38:28 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Call the GLX/Pixmap related functions through the vtable. 2010-07-01 11:11:18 +0000 gb * NEWS: * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Drop dependency on libavformat. 2010-06-22 15:15:46 +0000 gb * gst-libs/gst/video/gstbasevideodecoder.c: * gst-libs/gst/video/gstbasevideodecoder.h: Add gst_base_video_decoder_update_src_caps(). Don't forcibly set "interlaced" field if upstream elements did not have any. 2010-06-22 14:06:25 +0000 gb * gst-libs/gst/video/gstbasevideodecoder.c: * gst-libs/gst/video/gstbasevideoutils.c: * gst-libs/gst/video/gstbasevideoutils.h: Drop superfluous functions. 2010-06-22 13:57:33 +0000 gb * gst-libs/gst/video/gstbasevideodecoder.c: Really drop any dependency on libgstvideo. i.e. inline the helpers. 2010-06-22 13:48:30 +0000 gb * gst-libs/gst/video/gstbasevideodecoder.c: Further drop dependency on libgstvideo. 2010-06-22 12:57:06 +0000 gb * gst-libs/gst/video/Makefile.am: * gst-libs/gst/video/gstbasevideocodec.c: * gst-libs/gst/video/gstbasevideocodec.h: * gst-libs/gst/video/gstbasevideodecoder.c: * gst-libs/gst/video/gstbasevideodecoder.h: * gst-libs/gst/video/gstbasevideoutils.c: * gst-libs/gst/video/gstbasevideoutils.h: Add GstBaseVideoDecoder from gst-plugins-bad git. 2010-06-15 12:36:16 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Fix GLX version check. 2010-06-14 14:46:41 +0000 gb * NEWS: * configure.ac: Bump version for development. 2010-06-14 14:14:42 +0000 gb * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix decoding of some H.264 streams. e.g. Ice Age 2 trailer. 2010-06-14 12:58:22 +0000 gb * NEWS: Update changelog. 2010-06-14 09:20:37 +0000 gb * gst-libs/gst/vaapi/gstvaapicompat.h: Fix build with older VA-API 0.29-sds. 2010-05-18 11:22:54 +0000 gb * gst/vaapisink/gstvaapisink.c: * gst/vaapisink/gstvaapisink.h: Fix upscaling in foreign window (Totem). 2010-05-17 12:32:34 +0000 gb * gst/vaapisink/gstvaapisink.c: Soft validate caps since we only care about video/x-vaapi-surface as input. _setcaps() will check for other fields. 2010-05-17 08:55:51 +0000 gb * NEWS: * gst/vaapisink/gstvaapisink.c: Fix video rendering rect within an embedder window (Totem). 2010-05-17 08:28:28 +0000 gb * NEWS: * gst/vaapisink/gstvaapisink.c: Disable GLX rendering when vaapisink uses a foreign X window. 2010-05-17 08:24:42 +0000 gb * gst/vaapisink/gstvaapisink.c: Simplify GLX rendering code. 2010-05-17 07:32:10 +0000 gb * configure.ac: Bump version for development. 2010-05-16 21:44:17 +0000 gb * NEWS: 0.2.3. 2010-05-16 21:35:14 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Wait for at most one second for a VA surface to become available. 2010-05-16 21:18:37 +0000 gb * README: * configure.ac: Build-Requires: gstreamer0.10 >= 0.10.10 for gst_caps_merge(). 2010-05-16 21:17:49 +0000 gb * NEWS: * README: * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix decoder caps to report codec aliases. 2010-05-16 21:04:32 +0000 gb * NEWS: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Fix VC-1 decoding through the playbin2 pipeline. 2010-05-15 15:33:20 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Regularly update and expose decoder caps. 2010-05-15 09:43:28 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Add mechanism to reinsert buffer leftovers into the queue. 2010-05-15 06:59:54 +0000 gb * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder.c: Fix memory leak of encoded buffers. 2010-05-15 05:36:15 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: Check for out-of-free-surfaces condition. 2010-05-15 04:35:00 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.h: Change GST_VAAPI_DECODER_STATUS_ERROR_UNKNOWN value to something more generic (-1). 2010-05-15 04:25:32 +0000 gb * gst/vaapisink/gstvaapisink.c: Improve debug info for gst_vaapisink_ensure_render_rect(). 2010-05-14 05:02:05 +0000 gb * configure.ac: Bump version for development. 2010-05-13 21:52:22 +0000 gb * NEWS: 0.2.2. 2010-05-13 21:39:58 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Improve previous fix. 2010-05-13 21:27:43 +0000 gb * NEWS: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix a crash in the FFmpeg decoder on close. 2010-05-13 16:41:55 +0000 gb * README: Sort platforms by name. 2010-05-13 09:40:52 +0000 gb * NEWS: * configure.ac: Bump version for development. 2010-05-13 09:38:47 +0000 gb * gst/vaapisink/gstvaapisink.c: Add debug info for _show_frame(). 2010-05-13 07:19:46 +0000 gb * Makefile.am: Nuke older build dir. 2010-05-13 07:19:21 +0000 gb * debian.upstream/control.in: Fix packaging deps. 2010-05-13 06:12:37 +0000 gb * NEWS: Cosmetics. 2010-05-13 06:11:42 +0000 gb * NEWS: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Fix OpenGL texture internal format (Clutter). 2010-05-13 04:40:40 +0000 gb * NEWS: Respin release. 2010-05-13 04:27:44 +0000 gb * gst/vaapisink/gstvaapisink.c: Debug video & display PARs. 2010-05-13 04:22:31 +0000 gb * gst/vaapisink/gstvaapisink.c: Use XGetGeometry() to retrieve the window size. 2010-05-12 19:40:30 +0000 gb * gst/vaapisink/gstvaapisink.c: Move code around. 2010-05-12 19:35:45 +0000 gb * gst/vaapisink/gstvaapisink.c: Ensure VA display is created prior to initializing the window from a specific XID. Also move code down. 2010-05-12 19:18:04 +0000 gb * README: Drop obsolete comment. 2010-05-12 19:14:59 +0000 gb * NEWS: 0.2.1. 2010-05-12 19:14:35 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Fix GstVaapiDisplay refcounting in vaapidecode. 2010-05-12 14:10:38 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_gst.c: Fix comment. 2010-05-12 12:58:53 +0000 gb * gst/vaapisink/gstvaapisink.c: * gst/vaapisink/gstvaapisink.h: Fix render rect when the foreign window size changes. 2010-05-12 11:43:50 +0000 gb * NEWS: * configure.ac: * gst/vaapisink/Makefile.am: * gst/vaapisink/gstvaapisink.c: Add GstXOverlay interface to vaapisink (e.g. for Totem). 2010-05-12 10:51:21 +0000 gb * README: Update deps to match configure.ac versions. 2010-05-12 09:34:37 +0000 gb * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Cosmetics. 2010-05-12 09:22:49 +0000 gb * NEWS: * gst/vaapidecode/Makefile.am: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Fix vaapidecode to expose the HW supported caps only. 2010-05-12 08:32:34 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Initialize decoder earlier. 2010-05-12 08:02:45 +0000 gb * NEWS: * README: * gst/vaapidecode/gstvaapidecode.c: Fix integration within the playbin2 pipeline. 2010-05-12 08:02:19 +0000 gb * docs/reference/libs/Makefile.am: Exclude gstvaapiutils_gst.h from docs for now. 2010-05-12 08:00:09 +0000 gb * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Raise VA-API plugins ranks. 2010-05-12 07:57:55 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_gst.c: * gst-libs/gst/vaapi/gstvaapiutils_gst.h: Add gst_vaapi_display_lookup_downstream() helper. 2010-05-11 16:23:17 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Use fixed caps on the src pad, they are not meant to change from video/x-vaapi-surface. 2010-05-11 16:19:30 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst/vaapisink/gstvaapisink.c: Expose VA display through GstVaapiVideoBuffer. 2010-05-11 16:09:49 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Simplify gst_vaapidecode_set_caps() and fix memory leak. 2010-05-11 12:06:59 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: Expose video pool display. 2010-05-11 12:03:13 +0000 gb * gst-libs/gst/vaapi/gstvaapivideosink.c: Stop iteration if there is no more element to examine. 2010-05-10 09:32:47 +0000 gb * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Improve plugin details. 2010-05-07 06:35:31 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.h: * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Factor out VA surface caps. 2010-05-05 15:36:25 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Add gst_vaapidecode_ensure_display() helper for set-caps. 2010-05-05 12:57:59 +0000 gb * configure.ac: Bump version for development. 2010-05-05 12:29:28 +0000 gb * NEWS: Really make it 0.2.0. 2010-05-05 12:28:59 +0000 gb * README: More docs. 2010-05-05 11:48:31 +0000 gb * docs/reference/libs/Makefile.am: Don't exclude GstVaapiParamSpecs. 2010-05-05 11:44:06 +0000 gb * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: Fix docs. 2010-05-05 06:06:02 +0000 gb * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapisink/gstvaapisink.c: Lower plugins rank for now since playbin2 auto-plugging is not working properly. User applications will have to create their own pipeline or with some hacks around playbin2. 2010-05-04 15:03:47 +0000 gb * gst-libs/gst/vaapi/Makefile.am: Really link all helper libraries with libtool -no-undefined. 2010-05-04 15:02:29 +0000 gb * gst-libs/gst/vaapi/Makefile.am: Link helper libraries with libtool -no-undefined. 2010-05-04 14:59:27 +0000 gb * configure.ac: * debian.upstream/gstreamer-vaapi.install.in: * gst/vaapiconvert/Makefile.am: * gst/vaapidecode/Makefile.am: * gst/vaapisink/Makefile.am: Don't build plugins with SONAME. Make them plain *.so. 2010-05-04 08:59:27 +0000 gb * README: Improve documentation for release. 2010-05-03 22:50:56 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix build with older VA-API 0.29. 2010-05-03 22:43:01 +0000 gb * NEWS: 0.2.0. 2010-05-03 22:42:46 +0000 gb * tests/Makefile.am: Fix make dist. 2010-05-03 22:36:34 +0000 gb * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.core.types: * docs/reference/plugins/Makefile.am: * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: Add missing docs. 2010-05-03 22:34:53 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix doc. 2010-05-03 22:28:02 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst/vaapidecode/gstvaapidecode.c: * tests/test-decode.c: Rename gst_vaapi_decoder_ffmpeg_new_from_caps() to plain gst_vaapi_decoder_ffmpeg_new(). 2010-05-03 22:02:41 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Extract framerate information from caps. 2010-05-03 21:49:35 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Move caps initialization to parent class. 2010-05-03 21:25:46 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: Simplify. 2010-05-03 21:25:26 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix doc. 2010-05-03 21:14:01 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: More simplifications. 2010-05-03 20:55:17 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * tests/test-decode.c: Simplify GstVaapiDecoder API. 2010-05-03 20:40:27 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.h: Drop obsolete defs. 2010-05-03 20:34:57 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.h: Drop obsolete decls. 2010-05-03 17:36:01 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst/vaapidecode/gstvaapidecode.c: Add more aliases for MPEG-4 decoding. 2010-05-03 17:04:00 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Use avctx->coded_{width,height} info to create the VA context. 2010-05-03 16:54:23 +0000 gb * tests/test-decode.c: * tests/test-decode.h: Use gst_vaapi_decoder_ffmpeg_new_from_caps(). 2010-05-03 16:41:13 +0000 gb * tests/test-decode.c: * tests/test-decode.h: * tests/test-h264.c: * tests/test-h264.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-vc1.c: * tests/test-vc1.h: Simplify tests info. 2010-05-03 16:17:51 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Try to improve heuristics to use an AVCodecContextParser. 2010-05-03 15:35:22 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix VC-1 decoding, it does not require any specific parser. 2010-05-03 15:34:22 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix VC-1 detection with older gstreamer libs (no "fourcc" field, but a "format" one). 2010-05-03 15:29:18 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Use size information from the demuxer, whenever available. i.e. fix WMV3 decoding. 2010-05-03 15:11:32 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Add gst_vaapi_decoder_ffmpeg_new_from_caps() helper. 2010-05-03 14:53:18 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: Improve WMV3 detection yet further. 2010-05-03 13:44:41 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix detection of plain old WMV3 contents. 2010-05-03 12:25:07 +0000 gb * tests/test-vc1.c: Add End-of-Sequence start code. 2010-05-03 11:44:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst/vaapidecode/gstvaapidecode.c: Fix VC-1 detection. 2010-05-03 08:51:28 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: Fix build with older gstreamer libs where gst_buffer_unref() is not a plain function. 2010-05-03 08:34:57 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Drop obsolete (and wrong) code. 2010-05-03 08:33:23 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Cosmetics (spelling). 2010-05-03 08:32:46 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Try to fix timestamps (step 1). Looks OK on H55. 2010-05-03 07:10:04 +0000 gb * debian.upstream/Makefile.am: Ship with COPYING.LIB. 2010-05-03 07:07:27 +0000 gb * COPYING.LIB: * NEWS: * README: * gst-libs/gst/vaapi/gstvaapi_priv.h: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapivalue.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Relicense gst-libs/ code to LGPL v2.1+. 2010-05-03 06:49:43 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Drop extraneous comma. 2010-05-03 06:49:19 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Drop variant=itu field to help codec detection. 2010-04-30 15:50:19 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Decode as many surfaces as possible in gst_vaapidecode_step(). 2010-04-30 15:37:28 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: * tests/test-decode.c: Drop excessive threading that over-complicates synchronisation. MPEG-2 & H.264 videos now play but there are other problems (timestamps). 2010-04-30 13:13:50 +0000 gb * configure.ac: 0.2.0. 2010-04-30 12:04:12 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Move VA context reset to AVCodecContext.get_context() as the surface sizes can change. 2010-04-30 09:52:29 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: Fix gst_vaapi_display_has_{decoder,encoder}() to check for the entrypoint too. 2010-04-30 09:48:41 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: Add GST_VAAPI_ENTRYPOINT_SLICE_ENCODE. 2010-04-30 08:18:07 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Document H.264 / AVC1 format case better. 2010-04-29 23:09:07 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix H.264 decoding with AVC1 format bitstreams. 2010-04-29 22:00:37 +0000 gb * gst/vaapidecode/gstvaapidecode.c: Complete initialization of the GstVaapiVideoBuffer. Some frames start to show up. 2010-04-29 21:59:14 +0000 gb * gst/vaapisink/gstvaapisink.c: Add missing GstBaseSink::buffer_alloc() override. i.e. make sure to allocate a GstVaapiVideoBuffer instead of a plain GstBuffer from the peer pad. 2010-04-29 21:56:10 +0000 gb * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Export gst_vaapi_video_buffer_new(). 2010-04-29 21:12:30 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix gst_vaapi_profile_get_caps() to include the "profile" field. 2010-04-29 17:56:42 +0000 gb * configure.ac: Fix comment. 2010-04-29 17:55:58 +0000 gb * NEWS: * configure.ac: * gst/Makefile.am: * gst/vaapidecode/Makefile.am: * gst/vaapidecode/gstvaapidecode.c: * gst/vaapidecode/gstvaapidecode.h: Add FFmpeg/VAAPI decoder for the new `vaapidecode' element. 2010-04-29 17:51:57 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: Add gst_vaapi_decoder_pause(). 2010-04-29 17:11:32 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Use a GstTask with start/stop semantics for the decoder thread. 2010-04-29 16:08:46 +0000 gb * gst-libs/gst/vaapi/gstvaapivideobuffer.c: Drop extraneous var. 2010-04-29 15:45:44 +0000 gb * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Add support for GstVaapiSurfaceProxy to GstVaapiVideoBuffer. 2010-04-29 14:58:45 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: Fix gst_vaapi_decoder_get_surface() status. 2010-04-29 14:28:43 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Try to set correct timestamps to the decoded surface proxy. 2010-04-29 12:52:27 +0000 gb * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: * tests/test-decode.c: Add timestamps to GstVaapiSurfaceProxy. 2010-04-29 09:43:40 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: Fix GstVaapiDecoder::destroy(): GASyncQueue is not a GObject, likewise for GstBuffer. 2010-04-29 09:40:38 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix destructor, av_parser_close() does destroy the struct already, unliker avcodec_close()... 2010-04-29 09:35:54 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Prefer profile from codec-data if any was found there. 2010-04-29 09:34:54 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Improve heuristics to find the best profile. Use the highest one if no explicit match on "profile" field. 2010-04-28 23:09:52 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: Make sure gst_vaapi_decoder_get_surface() gets unblocked on error. 2010-04-28 22:30:50 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Fix VC-1 codec initialization, it really needs an extradata buffer. 2010-04-28 22:16:10 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Split decoder creation with actual resources allocation and codec setup (probe). This fixes a memory leak (avctx, pctx) on destroy and most interestingly makes it possible to detect unsupported codecs. 2010-04-28 21:58:58 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Move gst_vaapi_decoder_ffmpeg_create() call to object constructor. 2010-04-28 21:50:44 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * tests/test-decode.c: Add "codec-data" property for additional codec data. e.g. VC-1 sequence headers for elementary streams. 2010-04-28 21:20:19 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Cosmetics (weird indentation). 2010-04-28 21:15:55 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Cosmetics (extraneous variable, debug message). 2010-04-28 09:07:45 +0000 gb * configure.ac: Fix check for VA-API enabled FFmpeg. 2010-04-27 15:26:19 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: - Add PTS and framerate information. - Simplify parsing with an AVCodeParserContext. 2010-04-27 11:59:23 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: Add more error codes. Fix documentation. 2010-04-26 13:30:27 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: Fix gst_vaapi_profile_get_codec(). Improve gst_vaapi_profile_from_caps() for H.264 & caps with "codec-data". 2010-04-26 11:44:32 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: * tests/test-decode.c: Handle user end-of-streams. Add gst_vaapi_decoder_{start,stop}() helpers. 2010-04-26 11:36:12 +0000 gb * tests/test-vc1.c: Drop useless End-of-Sequence marker. 2010-04-26 08:53:18 +0000 gb * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: Flush stream only if avcodec_decode_video() read something. Otherwise, we might still have to seek into the stream. i.e. keep the data longer. 2010-04-26 08:40:27 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: Use a recursive mutex so that a single thread can lock several times. This fixes decoding of MPEG-2 and H.264 because those created a GstVaapiContext later through avcodec_decode_video() that was a protected call. 2010-04-26 08:15:58 +0000 gb * tests/test-h264.c: * tests/test-vc1.c: Regenerate correct clips. 2010-04-23 16:11:55 +0000 gb * tests/Makefile.am: * tests/test-decode.c: * tests/test-h264.c: * tests/test-h264.h: * tests/test-mpeg2.c: * tests/test-mpeg2.h: * tests/test-vc1.c: * tests/test-vc1.h: Add decoder demos. Use -c (mpeg2|h264|vc1) to select the codec. XXX: only VC-1 decoding works at this time because of awful bugs left in GstVaapiDecoderFfmpeg et al. 2010-04-23 16:05:58 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidecoder.c: * gst-libs/gst/vaapi/gstvaapidecoder.h: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.c: * gst-libs/gst/vaapi/gstvaapidecoder_ffmpeg.h: * gst-libs/gst/vaapi/gstvaapidecoder_priv.h: Add initial (multithreaded) decoder based on FFmpeg. There are tons of bugs left: - Decoder API not nice enough with error conditions - FFmpeg parser is sometimes broken - Packets queue can be lost 2010-04-23 16:00:50 +0000 gb * gst-libs/gst/vaapi/gstvaapisurfaceproxy.c: * gst-libs/gst/vaapi/gstvaapisurfaceproxy.h: Add surface proxy that holds a reference to the parent surface and that returns the surface to that context on destruction. 2010-04-23 15:59:31 +0000 gb * gst-libs/gst/vaapi/gstvaapicontext.c: * gst-libs/gst/vaapi/gstvaapicontext.h: Add VA context abstraction. 2010-04-23 10:58:19 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.h: Fix VA profiles definitions for gst_vaapi_profile_get_codec() to work. 2010-04-21 15:03:31 +0000 gb * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: Add a means to cap the number of objects allocated in the pool. 2010-04-21 15:02:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: Add VA entrypoint abstraction. 2010-04-20 13:36:04 +0000 gb * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapiprofile.c: * gst-libs/gst/vaapi/gstvaapiprofile.h: * tests/test-display.c: Add VA profile abstraction. 2010-04-20 07:51:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Fix OpenGL rendering on G45 systems. 2010-04-16 13:47:30 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Fix gl_create_context() to find a GLXFBConfig compatible with the parent GL context. 2010-04-02 11:27:23 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Fix TFP logic and simplify the FBO model. i.e. it's not necessary to create another texture (and storage) for the TFP, simply a new texture name. 2010-04-01 16:11:54 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: Fix get-out conditions. 2010-04-01 15:38:59 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: The shared GL context in GstVaapiTexture is only useful for cases where TFP+FBO are used, thus avoiding the need fully preserve the states and call into glGet*() functions that need synchronization. 2010-04-01 13:55:19 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Shorter structs. 2010-04-01 13:41:24 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11_priv.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * tests/test-windows.c: Make more helpers internal, thus reducing .text size further. Add gst_vaapi_display_x11_get_screen() helper along the way. 2010-04-01 09:47:59 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapi_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_priv.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Move GST_VAAPI_DISPLAY_VADISPLAY() and GST_VAAPI_DISPLAY_{LOCK,UNLOCK}() to gstvaapidisplay_priv.h. 2010-03-31 15:25:19 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: Improve handling of GL contexts. 2010-03-30 16:41:21 +0000 gb * configure.ac: Simplify summary. 2010-03-30 13:33:12 +0000 gb * configure.ac: Bump version for development. 2010-03-30 13:29:34 +0000 gb * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: Rename -dev package to libgstvaapi-dev. 2010-03-30 13:17:12 +0000 gb * NEWS: * README: Updates. 2010-03-30 13:05:31 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils.c: Fix build with VA-API < 0.30. 2010-03-30 13:01:34 +0000 gb * configure.ac: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapitexture.c: * tests/test-display.c: Enable build without VA/GLX extensions. i.e. fallback to TFP + FBO. 2010-03-30 12:59:15 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Add TFP and FBO helpers. 2010-03-30 12:55:27 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: Cosmetics. Make vaapi_check_status() use GST_DEBUG() for error messages. 2010-03-30 08:13:34 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Use a shorter function name. 2010-03-30 08:11:50 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: Add gst_vaapi_surface_query_status() wrapper. 2010-03-30 07:50:11 +0000 gb * docs/reference/plugins/Makefile.am: Fix leftover during migration. 2010-03-30 07:46:47 +0000 gb * Makefile.am: * configure.ac: * docs/reference/plugins/Makefile.am: * gst/Makefile.am: * gst/vaapiconvert/Makefile.am: * gst/vaapiconvert/gstvaapiconvert.c: * gst/vaapiconvert/gstvaapiconvert.h: * gst/vaapisink/Makefile.am: * gst/vaapisink/gstvaapisink.c: * gst/vaapisink/gstvaapisink.h: Rename to gst/ as sys/ was too vague. 2010-03-30 07:39:16 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Try to not reference VA-API types directly. 2010-03-29 16:24:37 +0000 gb * sys/vaapisink/gstvaapisink.c: Fix reflection code to preserve aspect ratio. 2010-03-29 16:17:38 +0000 gb * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Fix fullscreen mode. 2010-03-29 15:59:44 +0000 gb * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Add OpenGL reflection effect ("use-reflection"). 2010-03-29 15:51:54 +0000 gb * configure.ac: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: Use a projection suitable for rotation around the Y axis. 2010-03-29 15:03:30 +0000 gb * configure.ac: * sys/vaapisink/Makefile.am: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Don't build vaapisink/gl by default. However, if this is enabled, use the GL renderer by default. 2010-03-29 14:50:52 +0000 gb * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/control.in: * debian.upstream/libgstvaapi-glx.install.in: Add libgstvaapi-glx-0 package. 2010-03-29 14:47:49 +0000 gb * pkgconfig/Makefile.am: Really fix make distclean. 2010-03-29 14:43:22 +0000 gb * docs/reference/libs/Makefile.am: Fix make dist. 2010-03-29 14:42:57 +0000 gb * pkgconfig/Makefile.am: Fix make distclean. 2010-03-29 14:40:26 +0000 gb * tests/Makefile.am: Fix make dist. 2010-03-29 14:31:17 +0000 gb * docs/reference/libs/Makefile.am: * docs/reference/libs/libs.core.types: * docs/reference/libs/libs.glx.types: * docs/reference/libs/libs.x11.types: Fix doc build. 2010-03-29 14:21:51 +0000 gb * sys/vaapisink/gstvaapisink.h: Fix build without GLX. 2010-03-29 14:13:55 +0000 gb * NEWS: 0.1.2. 2010-03-29 14:13:26 +0000 gb * sys/vaapisink/Makefile.am: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Add VA/GLX support to vaapisink. 2010-03-29 13:40:27 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: Add glXSwapBuffers() workaround for NVIDIA. 2010-03-29 13:27:16 +0000 gb * tests/Makefile.am: * tests/test-textures.c: Improve VA/GLX textures test. 2010-03-29 12:51:38 +0000 gb * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Fix texture rendering. 2010-03-29 11:25:20 +0000 gb * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapitexture.c: Fix documentation. 2010-03-29 10:40:26 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: Add gst_vaapi_window_glx_put_texture() helper. 2010-03-29 09:09:30 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: Fix typos. 2010-03-26 17:00:45 +0000 gb * tests/image.c: * tests/image.h: * tests/test-windows.c: Move code around. 2010-03-26 16:52:07 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapitexture.c: * gst-libs/gst/vaapi/gstvaapitexture.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: Add initial VA/GLX texture abstraction though the API is not good enough yet. 2010-03-26 15:22:00 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: Add gst_vaapi_object_{,un}lock_display() helpers. 2010-03-26 15:16:01 +0000 gb * tests/Makefile.am: * tests/image.c: * tests/image.h: * tests/test-windows.c: Factor out image utilities. 2010-03-26 11:54:43 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: MT-Safe: lock display. 2010-03-26 11:50:31 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: Make sure window resize completed prior to resizing the GL viewport. 2010-03-26 11:39:20 +0000 gb * gst-libs/gst/vaapi/Makefile.am: gstvaapicompat.h is a private header, don't install it. 2010-03-26 11:35:20 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: Add gst_vaapi_display_{sync,flush}() helpers. 2010-03-26 11:30:54 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Add "synchronous" mode. 2010-03-26 11:02:12 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: Only add _display suffix to open & close members because they could be #define to some arbitrary value. lock/unlock are safe names. 2010-03-26 10:09:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: Restore GLX context only if there is one. 2010-03-26 09:41:12 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: Add gst_vaapi_window_glx_make_current(). Handle X11 window size changes and reset the GL viewport. 2010-03-26 08:35:24 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: Check GstVaapiWindow::render() is available prior to calling it. 2010-03-26 08:10:23 +0000 gb * tests/Makefile.am: * tests/test-display.c: * tests/test-textures.c: Add VA/GLX display tests. 2010-03-26 08:00:32 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: Fix compile flags. 2010-03-25 17:39:06 +0000 gb * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.types: Add missing API documentation. 2010-03-25 17:28:49 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay_glx.c: * gst-libs/gst/vaapi/gstvaapidisplay_glx.h: * gst-libs/gst/vaapi/gstvaapiutils_glx.c: * gst-libs/gst/vaapi/gstvaapiutils_glx.h: * gst-libs/gst/vaapi/gstvaapiwindow_glx.c: * gst-libs/gst/vaapi/gstvaapiwindow_glx.h: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-glx.pc.in: * tests/Makefile.am: * tests/test-textures.c: Add initial VA/GLX support. 2010-03-25 17:21:56 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Add missing includes (for vaapi_check_status()). 2010-03-25 17:21:13 +0000 gb * gst-libs/gst/vaapi/gstvaapidebug.h: Only enable GST_DEBUG() if DEBUG is defined. Drop old D(bug()) stuff. 2010-03-25 17:18:36 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Add gst_vaapi_window_x11_is_foreign_xid() helper. 2010-03-25 17:18:06 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Allow derived classes to specify custom Visual and Colormap. 2010-03-25 13:54:06 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Allow window creation with a specific visual (e.g. for GLX support). 2010-03-25 13:21:19 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Fix return value on error (though it's the same in the end). 2010-03-25 12:39:54 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: Simplify initialization of VADisplay. 2010-03-25 10:04:39 +0000 gb * configure.ac: Move __attribute__((visibility("hidden"))) check down. 2010-03-25 09:49:17 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * tests/test-surfaces.c: Restore the gst_vaapi_{surface,image,subpicture}_get_id() interfaces. 2010-03-25 09:39:17 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Use the parent display object, no need to maintain another one. In the end, libgstvaapi-x11 reduced by 1 KB in .text vs. 0.1.1. 2010-03-25 09:37:40 +0000 gb * gst-libs/gst/vaapi/gstvaapiobject_priv.h: Add more internal helpers. 2010-03-24 17:40:19 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Rename to GST_VAAPI_OBJECT_DISPLAY(). 2010-03-24 17:38:23 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: All GstVaapiID are initialized to GST_VAAPI_ID_NONE by default. Besides, all GstVaapiObject derived class shall initialize "id" to a valid value. 2010-03-24 17:22:18 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Make GstVaapiWindow* derive from GstVaapiObject. 2010-03-24 16:37:35 +0000 gb * configure.ac: Factor out use gstreamer-vaapi (PACKAGE name). 2010-03-24 16:35:36 +0000 gb * configure.ac: Improve versioning summary. 2010-03-24 16:27:36 +0000 gb * gst-libs/gst/vaapi/Makefile.am: gstvaapicompat.h is now a private header (not installed). 2010-03-24 16:25:56 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Include gstvaapicompat.h in source files only, not headers. 2010-03-24 16:21:20 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * sys/vaapiconvert/Makefile.am: * sys/vaapisink/Makefile.am: * tests/Makefile.am: Drop tedious LIBVA_EXTRA_{CFLAGS,LIBS} definitions in Makefile.am. Override CFLAGS & LIBS instead. 2010-03-24 16:17:49 +0000 gb * NEWS: * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapicompat.h: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: * sys/vaapiconvert/Makefile.am: * sys/vaapisink/Makefile.am: * tests/Makefile.am: Add compatibility with the original VA-API 0.29. 2010-03-24 15:18:33 +0000 gb * gst-libs/gst/vaapi/gstvaapivalue.h: Add missing file (gstvaapivalue.h). 2010-03-24 15:12:56 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: Fix g_warning() invocation. 2010-03-24 15:11:26 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: Deassociate subpictures while destroying the surface. 2010-03-24 14:57:33 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: Fix destruction order of subpictures. They should be destroyed first. 2010-03-24 14:46:33 +0000 gb * NEWS: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * tests/test-windows.c: Add support for AYUV format. 2010-03-24 14:36:39 +0000 gb * tests/test-windows.c: Simplify upload process and fallback to subpictures. 2010-03-24 13:44:01 +0000 gb * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: Fix documentation. 2010-03-24 13:37:38 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapivalue.c: Move GValue specific stuff to a dedicated file. 2010-03-24 13:22:25 +0000 gb * tests/test-surfaces.c: Cosmetics (lowercase for consistency). 2010-03-24 13:21:54 +0000 gb * gst-libs/gst/vaapi/gstvaapiobject.c: Cosmetics (vertical alignment). 2010-03-24 13:20:34 +0000 gb * gst-libs/gst/vaapi/gstvaapiobject.c: Fix return value on error. 2010-03-24 13:19:58 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * tests/test-surfaces.c: Move "id" down to the GstVaapiObject base. 2010-03-24 12:59:22 +0000 gb * gst-libs/gst/vaapi/gstvaapitypes.c: Cosmetics (drop extraneous empty line). 2010-03-24 12:57:54 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiparamspecs.c: * gst-libs/gst/vaapi/gstvaapiparamspecs.h: Add GParamSpecs for GstVaapiID. 2010-03-24 12:54:52 +0000 gb * docs/reference/libs/libs.types: Drop gst_vaapi_id_get_type(). 2010-03-24 12:38:40 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapitypes.h: Add GST_VAAPI_ID_FORMAT() and GST_VAAPI_ID_ARGS() helpers. 2010-03-24 09:52:43 +0000 gb * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.types: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapitypes.c: * gst-libs/gst/vaapi/gstvaapitypes.h: Add GstVaapiID abstraction. 2010-03-24 09:22:00 +0000 gb * docs/reference/libs/libs.types: Sort types. 2010-03-24 08:35:27 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: Drop useless include (). 2010-03-24 08:34:11 +0000 gb * gst-libs/gst/vaapi/gstvaapiobject_priv.h: Optimize GST_VAAPI_OBJECT_GET_DISPLAY to avoid a run-time check. 2010-03-24 08:32:12 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapiobject_priv.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Move private definitions and accessors to gstvaapiobject_priv.h. 2010-03-24 08:16:32 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Fix short descriptions. 2010-03-23 18:45:09 +0000 gb * Makefile.am: * configure.ac: * debian.upstream/Makefile.am: * debian.upstream/changelog.in: * debian.upstream/compat: * debian.upstream/control.in: * debian.upstream/copyright: * debian.upstream/gstreamer-vaapi-doc.install.in: * debian.upstream/gstreamer-vaapi.install.in: * debian.upstream/libgstvaapi-dev.install.in: * debian.upstream/libgstvaapi-x11.install.in: * debian.upstream/libgstvaapi.install.in: * debian.upstream/rules: Generate upstream packages through make deb.upstream. 2010-03-23 17:40:03 +0000 gb * configure.ac: Bump version for development. 2010-03-23 17:29:47 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_x11.c: Use a black background for new windows. 2010-03-23 17:18:35 +0000 gb * NEWS: 0.1.1. 2010-03-23 17:12:40 +0000 gb * configure.ac: * docs/reference/libs/libs.types: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapimarshal.list: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * tests/test-surfaces.c: Add "destroy" signal. 2010-03-23 16:25:20 +0000 gb * docs/reference/libs/libs-docs.xml.in: Improve gst-plugins-vaapi Library reference template. 2010-03-23 16:21:28 +0000 gb * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiobject.c: * gst-libs/gst/vaapi/gstvaapiobject.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Make GstVaapi{Surface,Image,Subpicture} derive from a GstVaapiObject. 2010-03-23 16:11:21 +0000 gb * sys/vaapisink/gstvaapisink.c: Fix return value. 2010-03-23 15:34:51 +0000 gb * sys/vaapisink/gstvaapisink.c: Make sure VA display is valid when created with an explicit "display" name. 2010-03-23 15:28:50 +0000 gb * sys/vaapisink/gstvaapisink.c: Use plain "display" property for the X11 display name. 2010-03-23 15:22:47 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapisink/gstvaapisink.c: Document vaapiconvert & vaapisink plugins. 2010-03-23 14:19:21 +0000 gb * configure.ac: * docs/reference/Makefile.am: * docs/reference/plugins/Makefile.am: * docs/reference/plugins/plugins-docs.xml.in: * docs/reference/plugins/plugins-overrides.txt: * docs/reference/plugins/plugins-sections.txt: * docs/reference/plugins/plugins.types: Add plugins documentation template. 2010-03-23 14:06:42 +0000 gb * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Don't export gst_vaapisink_get_display(). 2010-03-23 13:32:36 +0000 gb * configure.ac: * docs/reference/libs/libs-docs.xml.in: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: Drop introspection annotations since they require gtk-doc >= 1.12. 2010-03-23 10:51:35 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: Add note about the fact that the surface holds an extra reference to the subpicture. 2010-03-23 10:49:33 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: Improve debugging messages. 2010-03-23 10:48:58 +0000 gb * tests/test-windows.c: Unref subpicture earlier as the surface is supposed to hold a reference to it. 2010-03-23 10:36:20 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * tests/test-windows.c: Add gst_vaapi_surface_{,de}associate_subpicture() API. 2010-03-23 08:13:37 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Wait for MapNotify or UnmapNotify events on foreign windows too. 2010-03-23 07:42:05 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Check whether the foreign XID is mapped at binding time. 2010-03-23 07:34:15 +0000 gb * sys/vaapisink/gstvaapisink.c: Add missing includes. 2010-03-23 07:31:04 +0000 gb * configure.ac: * debian/Makefile.am: * debian/control.in: * debian/gstreamer-vaapi-doc.install.in: * debian/rules: Add -doc package. 2010-03-23 06:41:29 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Fix warnings (drop extraneous var). 2010-03-23 06:40:27 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Add GST_VAAPI_WINDOW_XWINDOW() helper macro. 2010-03-22 16:59:29 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: Shorten condition. 2010-03-22 16:57:20 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Try to improve switch to fullscreen mode. 2010-03-22 16:01:34 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Improve display locking and rework X event wait functions. 2010-03-22 13:06:41 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: Move _GstVaapiWindowPrivate declaration to gstvaapiwindow_priv.h. 2010-03-22 13:05:05 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_priv.h: Add private API to set window size & fullscreen modes without triggering any notification or virtual functions. This is useful for derived class to fix up sizes whenever appropriate. 2010-03-22 12:47:13 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: Add gst_vaapi_window_get_fullscreen() helper and "fullscreen" property. 2010-03-22 12:39:02 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Add gst_vaapi_window_get_display() to base. 2010-03-22 12:16:47 +0000 gb * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapitypes.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Add GstVaapiPoint & GstVaapiRectangle data structures. 2010-03-22 12:05:11 +0000 gb * NEWS: 0.1.1. 2010-03-22 12:03:26 +0000 gb * NEWS: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Allow `vaapisink` to render videos in fullscreen mode. 2010-03-22 10:51:49 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Add gst_vaapi_window_set_fullscreen() API. 2010-03-22 10:03:24 +0000 gb * sys/vaapisink/gstvaapisink.c: Size window so that to respect the video and pixel aspect ratio. 2010-03-22 09:32:01 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * tests/test-display.c: Add gst_vaapi_display_get_pixel_aspect_ratio(). 2010-03-22 08:45:03 +0000 gb * docs/reference/libs/libs-sections.txt: Updates. 2010-03-22 08:44:38 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * tests/test-display.c: Add display size accessors. 2010-03-22 08:03:12 +0000 gb * configure.ac: * debian/control.in: Build-Requires: gstreamer-plugins-base >= 0.10.16. 2010-03-21 08:45:09 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: * gst-libs/gst/vaapi/gstvaapivideopool.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Fix documentation of *Class'es. 2010-03-21 08:38:17 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Move GstVaapiSurfaceRenderFlags conversion to get_PutSurface_flags_from_GstVaapiSurfaceRenderFlags(). 2010-03-21 08:22:46 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapiwindow.h: Move GstVaapiSurfaceRenderFlags to gstvaapisurface.h since this will also be useful for e.g. a gstvaapitexture.h. 2010-03-21 08:12:52 +0000 gb * docs/reference/libs/libs-sections.txt: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * sys/vaapisink/gstvaapisink.c: * tests/test-windows.c: Rename gst_vaapi_window_put_surface_full() to plain gst_vaapi_window_put_surface(). 2010-03-19 17:15:16 +0000 gb * docs/reference/libs/Makefile.am: Fix make dist for --enable-gtk-doc builds. 2010-03-19 17:13:59 +0000 gb * autogen.sh: Improve autogen.sh. 2010-03-19 17:11:20 +0000 gb * Makefile.am: * autogen.sh: Generate gtk-doc.make from gtkdocize. 2010-03-19 17:04:51 +0000 gb * Makefile.am: * NEWS: * configure.ac: * docs/Makefile.am: * docs/reference/Makefile.am: * docs/reference/libs/Makefile.am: * docs/reference/libs/libs-docs.xml.in: * docs/reference/libs/libs-overrides.txt: * docs/reference/libs/libs-sections.txt: * docs/reference/libs/libs.types: Document public API for libgstvaapi-*.so.*. 2010-03-19 16:41:52 +0000 gb * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Document GstVaapiVideoBuffer. 2010-03-19 16:08:48 +0000 gb * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: Document surface & image pools. Drop obsolete gst_vaapi_video_pool_new() function. 2010-03-19 15:45:21 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapivideosink.h: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: Add tedious documentation. 2010-03-19 10:42:11 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: Beautify append_formats(). 2010-03-19 10:38:45 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: Simplify GstVaapiDisplay (use GArray). 2010-03-19 08:42:51 +0000 gb * NEWS: * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Factor out direct-rendering infrastructure. 2010-03-18 16:18:17 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Allow user to specify inout-buffers & derive-image optimizations. 2010-03-18 15:58:28 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: Reduce number of debug messaged printed out. 2010-03-18 15:53:50 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Add vaDeriveImage() optimization. 2010-03-18 15:52:20 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Fix gst_vaapi_image_create() from a foreign VA image. 2010-03-18 15:28:59 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add gst_vaapi_surface_derive_image() API. 2010-03-18 13:49:50 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Make it possible to bin an X11 window to GstVaapiWindowX11 with plain g_object_new() and "xid" property. i.e. get foreign window size in gst_vaapi_window_x11_create(). 2010-03-18 13:08:17 +0000 gb * tests/test-windows.c: Try YV12 & I420 image formats too. 2010-03-18 12:59:55 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Split map/unmap functions into internal functions that don't check preconditions. 2010-03-18 12:56:53 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Improve gst_vaapi_image_new() sanity checks. 2010-03-18 12:52:58 +0000 gb * tests/test-windows.c: Fix typo. 2010-03-18 08:45:57 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: Check if our inout buffer is still alive or default to a separate output buffer. 2010-03-18 08:16:59 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Factor out buffers negotiation and optimization checks. 2010-03-18 08:02:25 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * sys/vaapiconvert/gstvaapiconvert.h: Use gtypes. 2010-03-17 10:43:02 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Optimize gst_vaapi_image_is_linear() and simplify gst_vaapi_image_update_from_buffer(). 2010-03-17 07:59:31 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Add VA display locking utilities. 2010-03-17 07:20:19 +0000 gb * sys/vaapisink/gstvaapisink.c: Initialize the X window in a ::set_caps() handler. Also fix build with GStreamer < 0.10.25. i.e. use preroll/render hooks. 2010-03-17 07:17:17 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * tests/test-windows.c: Don't show window by default during creation. 2010-03-17 06:49:27 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Fix gst_vaapi_window_x11_destroy(). 2010-03-16 17:57:57 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Alias sink & src pad buffers whenever possible. 2010-03-16 17:57:23 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: Extend GstVaapiImage API with *_get_image(), *_is_linear(), *_get_data_size(). 2010-03-16 17:10:02 +0000 gb * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Make GstVaapiVideoBuffer handle two pools. i.e. both image & surface at the same time. 2010-03-16 14:37:47 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: Fix image & surface size cache. 2010-03-16 14:12:40 +0000 gb * configure.ac: Move gstreamer-vaapi package versioning to the top. 2010-03-16 14:11:46 +0000 gb * configure.ac: Bump version for development. 2010-03-16 14:07:53 +0000 gb * configure.ac: Cosmetics (shorten lines). 2010-03-16 13:58:43 +0000 gb * NEWS: * README: Update docs. 2010-03-16 13:53:54 +0000 gb * debian/Makefile.am: * debian/changelog.in: * debian/compat: * debian/control.in: * debian/copyright: * debian/gstreamer-vaapi.install.in: * debian/libgstvaapi-dev.install.in: * debian/libgstvaapi-x11.install.in: * debian/libgstvaapi.install.in: * debian/rules: Add debian packaging. 2010-03-16 13:53:09 +0000 gb * Makefile.am: * configure.ac: Add debian packaging. 2010-03-16 10:13:36 +0000 gb * pkgconfig/Makefile.am: Silence GNU make extensions warning. 2010-03-16 09:59:03 +0000 gb * configure.ac: Add AM_PROG_CC_C_O, thus fixing this warning: tests/Makefile.am:16: compiling `test-display.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac' 2010-03-16 09:57:25 +0000 gb * Makefile.am: * configure.ac: * pkgconfig/Makefile.am: * pkgconfig/gstreamer-vaapi-x11.pc.in: * pkgconfig/gstreamer-vaapi.pc.in: Add pkgconfig files. 2010-03-16 09:39:07 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * sys/vaapisink/Makefile.am: * tests/Makefile.am: Split X11 support to libgstvaapi-x11-*.so.* 2010-03-16 09:21:15 +0000 gb * gst-libs/gst/vaapi/Makefile.am: Don't install private headers. 2010-03-16 09:18:57 +0000 gb * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: Fix header guards. 2010-03-16 09:17:41 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidebug.h: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Rename vaapi_debug.h to gstvaapidebug.h. 2010-03-16 09:15:48 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapiutils.c: * gst-libs/gst/vaapi/gstvaapiutils.h: * gst-libs/gst/vaapi/vaapi_debug.h: Move vaapi_utils.* to gstvaapiutils.* 2010-03-16 09:13:16 +0000 gb * gst-libs/gst/vaapi/gstvaapiutils_x11.h: Cosmetics (remove an extra line). 2010-03-16 09:12:47 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiutils_x11.c: * gst-libs/gst/vaapi/gstvaapiutils_x11.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Move X11 utilties to gstvaapiutils_x11.[ch]. 2010-03-16 09:03:10 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideosink.c: * gst-libs/gst/vaapi/gstvaapivideosink.h: * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapisink/gstvaapisink.c: Rename GstVaapiSinkBase to GstVaapiVideoSink. 2010-03-16 08:49:16 +0000 gb * configure.ac: * tests/Makefile.am: * tests/examples/Makefile.am: * tests/examples/generic/Makefile.am: * tests/test-display.c: * tests/test-surfaces.c: * tests/test-windows.c: Move tests to top-level tests/ directory. 2010-03-16 08:43:16 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Handle I420 formats internally in GstVaapiImage. 2010-03-15 17:44:35 +0000 gb * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Implement I420 (resp. YV12) with YV12 (resp. I420) if the driver does not. 2010-03-15 17:43:29 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Implement I420 and YV12 if the underlying implementation does not. 2010-03-15 17:10:56 +0000 gb * sys/vaapiconvert/Makefile.am: * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: Add initial vaapiconvert plugin. 2010-03-15 17:09:12 +0000 gb * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Display frames. 2010-03-15 16:57:37 +0000 gb * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: Factor out. 2010-03-15 16:57:01 +0000 gb * tests/examples/generic/test-windows.c: Generate R/G/B rects. 2010-03-15 16:13:51 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add gst_vaapi_surface_sync(). 2010-03-15 16:13:37 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Cosmetics (reverse args order). 2010-03-15 15:55:20 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisurface.c: Cosmetics. 2010-03-15 15:12:27 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiwindow.c: * gst-libs/gst/vaapi/gstvaapiwindow.h: * gst-libs/gst/vaapi/gstvaapiwindow_x11.c: * gst-libs/gst/vaapi/gstvaapiwindow_x11.h: * tests/examples/generic/Makefile.am: * tests/examples/generic/test-windows.c: Add VA/X11 window abstraction. 2010-03-15 14:57:57 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: Add VA and X11 display accessors. 2010-03-15 14:57:30 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: Fix preconditions. 2010-03-15 13:32:37 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: Cosmetics. 2010-03-15 11:49:03 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add gst_vaapi_{get,put}_image() API. 2010-03-15 10:27:10 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: Add gst_vaapi_image_update_from_buffer() helper. 2010-03-12 23:53:48 +0000 gb * sys/vaapisink/Makefile.am: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Implement GstVaapiSinkBase interface and integrate with GST_DEBUG better. 2010-03-12 23:50:09 +0000 gb * tests/examples/generic/Makefile.am: * tests/examples/generic/test-surfaces.c: Add surface tests. 2010-03-12 23:48:50 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapivideobuffer.c: * gst-libs/gst/vaapi/gstvaapivideobuffer.h: Add basic GstVaapiVideoBuffer. 2010-03-12 23:47:47 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimagepool.c: * gst-libs/gst/vaapi/gstvaapiimagepool.h: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: * gst-libs/gst/vaapi/gstvaapivideopool.c: * gst-libs/gst/vaapi/gstvaapivideopool.h: Add GstVaapiImagePool and factor out GstVaapiSurfacePool from a base GstVaapiVideoPool. 2010-03-12 22:32:35 +0000 gb * gst-libs/gst/vaapi/gstvaapiimageformat.c: Simplify format conversion code. 2010-03-12 22:28:01 +0000 gb * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: Add gst_vaapi_image_format_from_caps() helper. 2010-03-12 17:45:18 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapisurfacepool.c: * gst-libs/gst/vaapi/gstvaapisurfacepool.h: Add VA surface pool (lazy allocator). 2010-03-12 17:39:11 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add gst_vaapi_surface_get_size() helper. 2010-03-12 10:52:08 +0000 gb * gst-libs/gst/vaapi/gstvaapiimageformat.c: Avoid use of GstStaticCaps since older gstreamer versions (0.10.22) write to it. 2010-03-11 15:35:43 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: Reset display-name if the user provided his own X11 display. 2010-03-11 15:21:43 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * tests/examples/generic/test-display.c: Add gst_vaapi_display_x11_new_with_display() API. 2010-03-11 15:04:18 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapisubpicture.h: * gst-libs/gst/vaapi/gstvaapisurface.h: Fix *_GET_CLASS() definitions... 2010-03-11 15:01:00 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * tests/examples/generic/test-display.c: API change: gst_vaapi_display_x11_new() now takes an X11 display name. 2010-03-11 13:58:32 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Use GstVaapiChromaType abstraction. 2010-03-11 12:30:12 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: New refcounting policy. All getters return a reference, not a copy. So the user shall reference the object itself, should he wish so. 2010-03-11 12:14:10 +0000 gb * gst-libs/gst/vaapi/gstvaapiimageformat.c: Don't warn on failure, just return an appropriate error or value. 2010-03-11 12:11:36 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: Filter out any format that is not supported by the library (libgstvaapi). Also sort the formats by HW preference. 2010-03-11 10:50:27 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapisinkbase.c: * gst-libs/gst/vaapi/gstvaapisinkbase.h: Add helper interface that all VA-API sinks must implement. e.g. vaapisink. 2010-03-10 13:13:51 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/vaapi_debug.h: Use GST_DEBUG. 2010-03-10 13:10:59 +0000 gb * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapisubpicture.c: Fix GstVaapiImage and GstVaapiSubpicture initialization. 2010-03-10 13:02:45 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: Fix GstVaapiSurface initialization, override constructed() method, not constructor(). GObject C is awful... 2010-03-10 12:25:38 +0000 gb * tests/examples/generic/test-display.c: Dump caps. 2010-03-10 12:25:19 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: Fix GstVaapiDisplay initialization. 2010-03-10 10:43:31 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: Get VA image & subpicture formats as GstCaps. 2010-03-10 10:41:12 +0000 gb * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: Add helper to convert from GstVaapiImageFormat to GstCaps. 2010-03-09 12:00:32 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapisurface.c: Cosmetics (drop unused variables). 2010-03-05 17:11:52 +0000 gb * configure.ac: * sys/vaapiconvert/Makefile.am: * sys/vaapiconvert/gstvaapiconvert.c: * sys/vaapiconvert/gstvaapiconvert.h: * sys/vaapisink/Makefile.am: * sys/vaapisink/gstvaapisink.c: * sys/vaapisink/gstvaapisink.h: Add boilerplate for vaapiconvert and vaapisink elements. 2010-03-05 15:29:04 +0000 gb * configure.ac: * sys/Makefile.am: * sys/vaapiconvert/Makefile.am: Add vaapiconvert element hierarchy. 2010-03-05 15:26:36 +0000 gb * sys/vaapisink/Makefile.am: Rename to vaapisink. 2010-03-05 10:07:22 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: Shorter code (and more correct). 2010-03-05 10:04:55 +0000 gb * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add helper to get GstVaapiDisplay from a surface. 2010-03-05 08:52:20 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: Fix subpicture formats list length. 2010-03-04 17:41:34 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: Add utilities to check whether a VA-API driver supports specific image or subpicture format. Likewise for VA profile. 2010-03-04 17:40:47 +0000 gb * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: Cosmetics (more checks, includes). 2010-03-04 17:39:58 +0000 gb * gst-libs/gst/vaapi/gstvaapisubpicture.c: * gst-libs/gst/vaapi/gstvaapisubpicture.h: Really add VA subpicture abstraction. 2010-03-04 17:39:01 +0000 gb * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapiimage.c: * gst-libs/gst/vaapi/gstvaapiimage.h: * gst-libs/gst/vaapi/gstvaapiimageformat.c: * gst-libs/gst/vaapi/gstvaapiimageformat.h: * gst-libs/gst/vaapi/gstvaapisurface.c: * gst-libs/gst/vaapi/gstvaapisurface.h: Add VA surface, image, subpicture abstractions. Ported over from Gnash. 2010-01-25 16:15:01 +0000 gb * configure.ac: * gst-libs/gst/vaapi/Makefile.am: * gst-libs/gst/vaapi/gstvaapidisplay.c: * gst-libs/gst/vaapi/gstvaapidisplay.h: * gst-libs/gst/vaapi/gstvaapidisplay_x11.c: * gst-libs/gst/vaapi/gstvaapidisplay_x11.h: * gst-libs/gst/vaapi/vaapi_debug.h: * gst-libs/gst/vaapi/vaapi_utils.c: * gst-libs/gst/vaapi/vaapi_utils.h: * tests/examples/generic/Makefile.am: * tests/examples/generic/test-display.c: Add initial VA display abstraction. 2010-01-25 15:04:10 +0000 gb * Makefile.am: * configure.ac: * tests/Makefile.am: * tests/examples/Makefile.am: * tests/examples/generic/Makefile.am: Add tests infrastructure. 2010-01-25 14:59:37 +0000 gb * configure.ac: Clean up VA-API checks. 2010-01-25 13:49:55 +0000 gb * configure.ac: Check for __attribute__((visibility("hidden"))).