Sebastian Dröge
6a84be95be
gstutils: Fix violations of strict-aliasing rules in gst_util_uint64_scale()
2009-08-13 16:32:27 +02:00
Kipp Cannon
3d359729af
gstutils: Refactor gst_util_uint64_scale()
...
This will later make it possible to provide rounding versions
of it without much code duplication.
Partially fixes bug #590919 .
2009-08-13 16:32:27 +02:00
Jonas Holmberg
824a0b5f5f
bufferlist: update doc string
2009-08-11 15:21:33 +02:00
Sebastian Dröge
276a55fd24
gstsegment: Actually start==stop==segment_start is inside the segment
...
Still the old code was wrong as it claimed that start==stop<segment_start
would be inside the segment and returned insane clipping differences.
2009-08-11 13:21:35 +02:00
Sebastian Dröge
868538945b
gstsegment: Fix unit test and add an additional test
...
The previous test assumed that start=stop=segment_start will
be inside the segment but this is wrong.
2009-08-11 13:03:03 +02:00
Sebastian Dröge
ca8a0376c5
gstsegment: Clipping should detect start=stop<segment_start as outside the segment
...
Before it returned that [start,stop] is inside the segment and that the
difference between segment_start and start needs to be clipped. If the
clipping is done on a buffer (like in baseaudiosink) this will result
in the data pointer being at a invalid memory position.
Fixes bug #589849 .
2009-08-11 12:59:13 +02:00
Sebastian Dröge
46b2a5a34e
gstbus: Unref pipeline after usage in test_custom_main_context unit test
...
This makes the core unit tests valgrind clean again.
2009-08-11 05:48:22 +02:00
Edward Hervey
adb16ca162
docs: add Edward's git plugin moving howto to moving-plugins document
2009-08-11 02:54:55 +01:00
Tim-Philipp Müller
60a962dcb8
checks: don't forget to include config.h in the GstObject unit test
2009-08-10 14:30:34 +01:00
Tim-Philipp Müller
657c68fc99
checks: try to fix GstObject unit test on OSX
...
Seems like we get SIGBUS instead of SIGSEGV here when GLib crashes
where it shouldn't crash (and we even have a unit test for that!).
2009-08-10 13:05:57 +01:00
Tim-Philipp Müller
3bf19f0a45
checks: set pipelines to NULL state in parse-launch unit test
...
Fixes timeouts in gst_task_cleanup_all().
2009-08-10 12:01:48 +01:00
Tim-Philipp Müller
a6c84b2ae6
checks: set pipeline back to NULL state in GstBus unit test
...
Fixes timeout in gst_task_cleanup_all().
2009-08-10 11:55:52 +01:00
Tim-Philipp Müller
7e6966faf6
check: add some logging before calling gst_task_cleanup_all()
2009-08-10 11:55:35 +01:00
Sebastian Dröge
d465851cb7
check: Call gst_task_cleanup_all() in GST_END_TEST
...
This fixes many unit tests under valgrind that shows
leaking GstTasks that are not really leaked but just
not unreffed by the task thread before the unit test
stopped.
Fixes bug #591045 .
2009-08-08 22:29:03 +02:00
Edward Hervey
8eb9d55627
basesink: Remove dead assignments
2009-08-08 14:47:57 +02:00
Edward Hervey
51bc185f7f
gst: Remove dead assignments
2009-08-08 14:47:40 +02:00
Tim-Philipp Müller
699539a331
gitignore: ignore new queue-error test
2009-08-07 02:36:29 +01:00
Tim-Philipp Müller
e398ad07f8
check: add internal-check.h to BUILT_SOURCES in attempt to fix the build
...
For some people the build of libgstcheck was broken because the make
target that creates the internal-check.h file wasn't executed for
some reason. This should hopefully fix this.
2009-08-06 20:43:55 +01:00
Tim-Philipp Müller
a2a23800bf
autogen.sh: older aclocals don't like -I. so use -I . instead
2009-08-06 18:38:16 +01:00
Wim Taymans
aa33db85cc
gstbuffer: add additional checking for writability
...
Check for metadata writability when setting caps on buffer or when copying
metadata flags. Only enable these extra assertions in git versions.
This should help us find bad elements.
2009-08-06 18:47:32 +02:00
Tim-Philipp Müller
06cc1d1d58
check: disable unit test support on win32 for now
...
Until we make the internal libcheck work on windows.
2009-08-06 17:35:13 +01:00
Tim-Philipp Müller
2d42fd4a2f
check: fix symbol exporting
2009-08-06 17:27:25 +01:00
Tim-Philipp Müller
572b213b79
check: fix issues with 'make distcheck'
...
Seems to work now, at least on *nix. One of the configure checks
caused these weird issues - but which one?
2009-08-06 17:27:24 +01:00
Tim-Philipp Müller
ecbea36d39
check: use private copy of check for libgstcheck
...
See #577275 . Seems to work fine, but doesn't distcheck yet.
2009-08-06 17:27:12 +01:00
Tim-Philipp Müller
a209779f1c
check: add internal copy of check-0.9.6
...
Not hooked up yet. See #577275 .
2009-08-06 14:26:32 +01:00
Tim-Philipp Müller
459c2b9c79
docs: fix Since: tag for new gst_caps_can_intersect() function
2009-08-06 14:11:46 +01:00
Stefan Kost
50fbc34f3f
utils: use new _caps_can_intersect()
2009-08-06 15:30:34 +03:00
Stefan Kost
aee208ff30
pad: use new _caps_can_intersect()
2009-08-06 15:30:33 +03:00
Stefan Kost
04470fc794
basetransform: use new _caps_can_intersect()
2009-08-06 15:30:33 +03:00
Stefan Kost
568202cb47
caps: add gst_caps_can_intersect()
...
Often we don't need the result of the intersection. Add a variant that only
tries to intersect. It can break out earlier and does less GValue copying.
API: gst_caps_can_intersect()
2009-08-06 15:30:33 +03:00
Stefan Kost
cfacd2cbb3
basetransform: only check caps_is_fixed() if they changed
...
The previous code could call gst_caps_is_fixed() for the same caps many times.
2009-08-06 15:30:33 +03:00
Stefan Kost
baaf7e5319
caps: split callback for structure intersect into two functions
...
We call this separately. there is no much benefit in reusing the callback.
Splitting is let us remove a branch also.
2009-08-06 15:30:33 +03:00
Stefan Kost
f5314ecae1
logging: log if we copy caps to be able to track it
2009-08-06 15:30:33 +03:00
Stefan Kost
24517c8975
caps: add comments about g_ptr_array size behaviour
...
Just explain the behaviour to avoid that someone else is wasting time trying to
improve this too.
2009-08-06 15:30:33 +03:00
Stefan Kost
89cefd8b59
example: unref the clock id
2009-08-06 15:30:32 +03:00
Stefan Kost
12f9b39fac
pad: use correct variable in test
2009-08-06 15:30:32 +03:00
Stefan Kost
e4ee7831e3
registry: add filename to debug message, like elsewhere
2009-08-06 15:30:32 +03:00
Stefan Kost
b01fb4d230
bin: fix compiler warning about unused var when disabling debug logging
2009-08-06 15:13:36 +03:00
Mark Nauwelaerts
3352c5d970
queue: post error message when pausing task
...
If downstream returns error and upstream has already delivered
everything (including EOS) and will no longer be around to find
out that we paused (and why), post error message. Fixes #589991 .
2009-08-06 13:42:25 +02:00
Mark Nauwelaerts
3f0e4bd6f6
queue: add unit test
...
Make a downstream element return an error after upstream has already
put all data into queue (including EOS). As such, upstream
will not be around to pick up the error, so it is up to queue to
act appropriately. See #589991 .
Note there may be downstream fatal errors (e.g. negotiation) that do
not warrant an error message already having been posted.
2009-08-06 13:40:18 +02:00
Wim Taymans
a2a973eafd
basetransform: clarify _caps_is_equal()
2009-08-06 10:53:25 +02:00
Wim Taymans
ec4d259b67
basetransform: refactor metadata modifications
...
Check when we need to touch the metadata of the output buffer after selecting
the output buffer so that we have everything in one place.
Also take flags and timestamp modifications into account.
2009-08-06 10:53:22 +02:00
Wim Taymans
2f5ed9e29d
capsfilter: only set caps when different
...
When we have an input buffer with caps and when those caps are different from
the caps we want, only then make a writable copy of the input buffer as the
output buffer and set the caps on that output buffer. This avoids some cases
where we took a subbuffer for setting caps that were the same.
2009-08-06 10:53:12 +02:00
Wim Taymans
db6ce33e3a
basetransform: enable optimisation
...
When we have the same input as output caps, reuse the input caps object. After
the caps refcounting has been sorted out now, we can finally enable this
optimisation.
2009-08-06 10:53:07 +02:00
Wim Taymans
96e342b686
tests: don't set caps on unwritable buffers
...
Take the ref after setting the caps on a buffer because else the buffer is
techinically not writable.
2009-08-06 10:53:01 +02:00
Wim Taymans
49f24e2044
queue: get caps after making writable
...
Get the caps of the buffer after we made the buffer writable. This did not
cause any problems but it's nicer this way.
2009-08-06 10:52:56 +02:00
Wim Taymans
04f3f096c3
capsfilter: fix refcounting problem
...
Make sure the metadata is writable before setting the caps on a buffer.
2009-08-06 10:52:45 +02:00
Wim Taymans
6cf64beb79
basetransform: fix refcounting problem
...
Add some more debug info.
Make sure that the output buffer has writable metadata before we attempt to set
caps on it.
fixes #583999
2009-08-06 10:52:34 +02:00
Wim Taymans
950c70c8bb
caps: add some more debugging in _replace
2009-08-06 10:52:12 +02:00
Wim Taymans
4146fa2eed
pad: Add some more debugging
2009-08-06 10:52:05 +02:00