Commit graph

113095 commits

Author SHA1 Message Date
Rafał Dzięgiel
18b5806ab9 assrender: Do not iterate over mimetypes without filename
No point spending time on iterating and comparing strings if we
are going to reject the value due to missing filename anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>
2021-10-21 22:21:40 +00:00
Rafał Dzięgiel
e6ff71f8e7 assrender: Fix mimetype detection
Previously gst_structure_has_name was used to get a string to compare with supported mimetypes.
This is incorrect as above function returns a user defined structure name which is
not the structure mimetype value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>
2021-10-21 22:21:40 +00:00
Rafał Dzięgiel
b57a7c3de7 matroska: Set image/attachment structure mimetype
Set structure mimetype to fix data detection by mimetype in other plugins.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>
2021-10-21 21:42:00 +00:00
Rafał Dzięgiel
0ba65a00c9 matroska: Treat non-image structure as attachment
Otherwise each structure is named as GstTagImageInfo even if
it does not contain any images which is misleading.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>
2021-10-21 21:42:00 +00:00
Matthew Waters
8c35850f23 rtpbin: fix leak of pad when a fec encoder and aux sender a created
The ghost sink pad retrieved by rtpbin from the aux sender was not freed
when there was a previous element (fec encoder) in the chain.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1222>
2021-10-21 13:46:03 +00:00
Stéphane Cerveau
47a4c74e9b ci: gstreamer-full: remove static build
The gstreamer-full jobs act as
static builds,  no need to perform it twice.

gstreamer-full-minimal can be nodebug.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1215>
2021-10-21 13:10:36 +00:00
Seungha Yang
7c3ce9c70d README: Remove outdated Windows ARM64 related comment
We bumped required meson version which contains the mentioned
meson patch already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1221>
2021-10-21 12:53:17 +00:00
Matthew Waters
9f79ab8b0b vulkan/swapper: add some debug logging for surface size and present modes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1219>
2021-10-21 11:32:04 +00:00
Jan Alexander Steffens (heftig)
be3c60eb1f interlace: Replace custom lock with object lock
The object lock is sufficient for the task of protecting against
object property data races.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>
2021-10-21 10:50:17 +00:00
Jan Alexander Steffens (heftig)
2bf6e2a20e interlace: Protect all properties with the lock
Avoid blatant data races here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>
2021-10-21 10:50:17 +00:00
Jan Alexander Steffens (heftig)
683680f6e5 interlace: Reset src_fps_d together with src_fps_n
These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>
2021-10-21 10:50:17 +00:00
Jan Alexander Steffens (heftig)
342763a158 interlace: Clear stored_fields together with stored_frame
These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>
2021-10-21 10:50:17 +00:00
Jan Alexander Steffens (heftig)
fcaf5b0f0b interlace: Reset after changing state to READY
Trying to reset before the pads have been deactivated races with the
streaming thread. There was also a buggy buffer clear leaving a dangling
`stored_frame` pointer around. Use `gst_interlace_reset` so this happens
properly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>
2021-10-21 10:50:17 +00:00
Mathieu Duponchelle
2f8030d98b nvh264enc: add constrained-baseline to the caps profiles
In practice, when baseline is requested from the encoder it
produces constrained baseline, and it is already reflected
in the profile-iop flags.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1213>
2021-10-21 09:06:08 +00:00
Seungha Yang
8b6c3e030b mediafoundation: Fix for UWP build
We don't support D3D11 interop for UWP because some APIs
(specifically MFTEnum2) are desktop application only.
However, the code for symbol loading is commonly used by both UWP and WIN32.
Just link GModule unconditionally which is UWP compatible, and simply don't
try to load any library/symbol dynamically when D3D11 interop is unavailable.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1216>
2021-10-21 05:11:40 +00:00
Thibault Saunier
ba34f6a113 Revert "ci: Split base and core valgrind on different runners"
Those job are not the ones that take most time in normal run (they
where when running with --n-runs) and that leads to using more runners
which might be a problem at this point.

This reverts commit 4ad22b05a1.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1212>
2021-10-20 22:35:27 +00:00
Tim-Philipp Müller
89ec0beeb5 docs: remove mms plugin from symbol index
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>
2021-10-20 17:05:34 +00:00
Tim-Philipp Müller
9a4651e387 mms: remove mmssrc plugin
Doubtful that anyone still needs that or there are even
any streams left out there.

MMS was deprecated in 2003 (in favour of RTSP) and support for
it was dropped with Microsoft Media Services 2008.

https://en.wikipedia.org/wiki/Microsoft_Media_Server
https://sdp.ppona.com/news2008.html

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/821

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>
2021-10-20 17:05:34 +00:00
Guillaume Desmottes
47445980a9 streamsynchronizer: set running time offset on events
It's cleaner and more generic than overriding the qos events.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1210>
2021-10-20 14:27:58 +00:00
Guillaume Desmottes
3ef2cacdd4 concat: fix qos event handling
We were shadowing the sinkpad variable resulting in:
- the QoS event to be send to all sink pads instead of the active one
- the pad to be leaked

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1208>
2021-10-20 13:39:03 +00:00
Brad Hards
f0de5a39c1 doc: update meson version in README.md
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1209>
2021-10-20 13:22:25 +00:00
Tim-Philipp Müller
e0f336c1b4 meson: va, msdk: simplify dep.get_variable() use
With recent Meson versions we can just write dep.get_variable('foo')
instead of dep.get_variable(pkgconfig: 'driverdir', internal: 'driverdir').

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Tim-Philipp Müller
081cada7cb meson: fix use of deprecated meson api external_program.path()
Just using .full_path() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Tim-Philipp Müller
c5bc0bd7c4 meson: fix use of deprecated meson api meson.has_exe_wrapper()
Use meson.can_run_host_binaries() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Tim-Philipp Müller
8dfab0b08c meson: update for meson.build_root() and .build_source() deprecation
-> use meson.project_build_root() or .global_build_root() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Tim-Philipp Müller
f1bb2c76c6 meson: update for dep.get_pkgconfig_variable() deprecation
... in favour of dep.get_variable('foo', ..) which in some
cases allows for further cleanups in future since we can
extract variables from pkg-config dependencies as well as
internal dependencies using this mechanism.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Tim-Philipp Müller
531aa4064a meson: clean up conditional paths after version bump
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>
2021-10-20 11:20:44 +00:00
Rafał Dzięgiel
c016bed943 assrender: fix smooth scaling by disabling hinting
When ass hinting value is set to anything other than NONE,
subtitles cannot use smooth scaling, thus all animations will jitter.

The libass author warns about possibility of breaking some scripts when it is enabled,
so lets do what is recommended and disable it to get the smooth scaling working.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1201>
2021-10-20 09:57:43 +00:00
Thibault Saunier
95c1f67d69 discoverer: Set number to stream infos
The idea is that we can reference to streams using this unique number,
within the context of that discoverer info. That number should always
be usable to reference the streams for a specific stream.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/897>
2021-10-20 09:16:38 +00:00
Edward Hervey
879526b2e2 discoverer: Don't ref NULL taglist
Fixes warning introduced in 064f7bbbfa

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1200>
2021-10-20 09:47:29 +02:00
Edward Hervey
b23148fa31 integration/ges: Ignore GstStream for validate tests
Requires the ges runner to be configured in such a way that the resulting
stream-id is consistent (and therefore can be checked)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>
2021-10-20 05:53:20 +00:00
Edward Hervey
08dc5d2961 stream: Set the object name to the stream id
Makes it more meaningful in debug logs (instead of streamNNNNN)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>
2021-10-20 05:53:20 +00:00
Tim-Philipp Müller
c95a7ab1ca docs: remove mention of mms from docs and mmssrc from tutorials
Prerequisite for our removing it from the cerbero build, see
https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/760

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1199>
2021-10-20 00:40:22 +00:00
Olivier Crête
0dbe0e21fe rtphdrext-clientaudiolevel: Rename RFC 6464 element
Multiplying elements named after RFC numbers is confusing,
so let's give them meaningful names.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1125>
2021-10-20 00:03:09 +00:00
Stéphane Cerveau
58caa8af62 ci: gstreamer-full: reenable build
The gstreamer-full job should be run
during the integrate stage always.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1190>
2021-10-19 18:26:03 +00:00
Seungha Yang
3e9800a513 subprojects: Update ogg and vorbis wraps
... to 1.3.5-2 and 1.3.7-2, respectively. Specifically to fix
ogg/vorbis plugin loading on Windows devenv environment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1196>
2021-10-19 17:42:21 +00:00
Xavier Claessens
2a10311ef5 Revert "meson: Link to objects instea of static helper library"
This reverts commit b19de413b9.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>
2021-10-19 16:56:35 +00:00
Xavier Claessens
eb072600a6 Revert "audio: Merge simd libs into the main one"
This reverts commit 4d3a200358.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>
2021-10-19 16:56:35 +00:00
Xavier Claessens
14115b714f Add initial meson devenv support
There is still a few things missing compared to gst-env.py, but it is
functional.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1162>
2021-10-19 16:18:43 +00:00
Sebastian Dröge
7cb2dff830 video-overlay-composition: Fix constructor guard to actually allow NULL as parameter
And don't use a NULL rectangle later.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1195>
2021-10-19 14:13:24 +00:00
Matthew Waters
d495154068 gl/eagl: fix eagl display creation
The GstGLDisplayType of the display was win32 instead of the required eagl.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1188>
2021-10-19 09:34:43 +00:00
Jan Schmidt
6cada5b064 qtdemux: Add support for wvtt (WebVTT) subtitles.
WebVTT in ISO MP4 is specified in ISO 14496-30,
and needed for DASH support. It's stored in an
mp4 specific format. To handle it compatibly,
the wvtt boxes are converted back into WebVTT text
and pushed as application/x-subtitle-vtt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>
2021-10-19 08:56:58 +00:00
Jan Schmidt
41d6f47f2b isomp4: Split buffer process functions.
Split the different handling for closed captions, VobSub subpicture
and timed text samples into separate simplified process functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>
2021-10-19 08:56:58 +00:00
Jan Schmidt
c47c6b4c2b isomp4: Use a function pointer for buffer splitting.
Swap the `need_process` boolean check on qtdemux streams
for a direct function pointer to the splitting function,
so we can stop adding extra cases to the single growing
`gst_qtdemux_process_buffer()` function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>
2021-10-19 08:56:58 +00:00
Jan Alexander Steffens (heftig)
df403df2ca srt: Plug leak of headers
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1040>
2021-10-19 07:19:41 +00:00
Matthew Waters
49af6a831d tests/rtp/payload: add test for shrinking extension data
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>
2021-10-19 03:26:57 +00:00
Matthew Waters
b7d4d371f9 rtp: also support shrinking the extension data
Currently the extension data length specified in the RTP header would
say it was shorter then the data serialised to a packet. When
combining the resulting buffer, the underlying memory would still
contain the extra (now 0-filled) padding data.

This would mean that parsing the resulting RTP packet would potentially
start with a number of 0-filled bytes which many RTP formats are not
expecting.

Such usage is found by e.g. RTP header extension when allocating the
maximum buffer (which may be larger than the written size) and shrinking
to the required size the data once all the rtp header extension data has
been written.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>
2021-10-19 03:26:57 +00:00
Jan Alexander Steffens (heftig)
320bc6362b mpegtsmux: Avoid crash when best pad gets flushed
The 'best' pad might receive a flush event between us picking it and us
popping the buffer. In this case, the buffer will be missing.

Similar to https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/711

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1042>
2021-10-19 01:46:19 +00:00
Tim-Philipp Müller
bb19b5aa96 vorbisdec: don't emit g_warning() on malformed input data
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>
2021-10-19 00:12:25 +00:00
Tim-Philipp Müller
2a2d6f7efe theoradec: don't emit g_warning() on malformed input stream
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>
2021-10-19 00:12:25 +00:00