Olivier Crête
dad9d252bc
Revert "validate-utils: simplify _read_builtin ()"
...
This breaks the fast_forward scenario parsing.
This reverts commit 0cfff156b1
.
2015-06-02 16:46:15 -04:00
Luis de Bethencourt
ab65b1e743
validate-utils: clean error handling in _file_get_lines ()
2015-05-29 17:40:26 +01:00
Luis de Bethencourt
0cfff156b1
validate-utils: simplify _read_builtin ()
2015-05-29 16:47:48 +01:00
Vineeth T M
1e3084aa95
validate-utils: sqrt(-1.0) leads to undefined result
...
Using sqrt of -1 is not valid and leads to undefined results.
When comparing the return value of the fucntion in validate-scenario,
it is being checked with ret == -1, so it makes sense to just return -1 in error case.
https://bugzilla.gnome.org/show_bug.cgi?id=748389
2015-05-29 15:40:55 +01:00
Thibault Saunier
e832785604
validate:scenario: Make sure to actually test position to execute actions
2015-05-20 14:16:14 +02:00
Thibault Saunier
4829e44147
validate:gtk: Use event->type directly
...
gdk_event_get_event_type was introduced in Gtk 3.10 only
https://bugzilla.gnome.org/show_bug.cgi?id=749421
2015-05-18 10:15:33 +02:00
Thibault Saunier
817ef82bb0
validate: overrides: Allow using regex for named overrides
...
Summary:
And minor fixes
Depends on D172
Reviewers: Mathieu_Du, gdesmott
Differential Revision: http://phabricator.freedesktop.org/D173
2015-05-14 15:56:57 +02:00
Thibault Saunier
d90f17a5b1
validate:scenario: Handle action execution after pipeline destruction
...
Summary:
It is possible to keep executing actions after the pipeline
has been destroyed.
API:
GST_VALIDATE_ACTION_TYPE_DOESNT_NEED_PIPELINE
Depends on D171
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D172
2015-05-14 15:56:56 +02:00
Thibault Saunier
92732c9f24
validate:scenario: Add a macro to get ActionType from an Action
...
Summary: Depends on D170
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D171
2015-05-14 15:56:56 +02:00
Thibault Saunier
53628bd7f2
validate:scenario: Factor out code to check position
...
Summary:
Making simpler to follow the execute_next_action function.
Depends on D169
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D170
2015-05-14 15:56:56 +02:00
Thibault Saunier
0f1f1db171
validate:pipeline-monitor: Stop printing position when not possible
...
Summary:
If from anything >= PAUSED to anything <= READY we can not query
pipeline position, so do not try to.
Depends on D168
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D169
2015-05-14 15:56:56 +02:00
Thibault Saunier
2ccae6e500
validate:scenario: Rename 'get_position_id' to 'execute_actions_source_id'
...
Summary: Depends on D167
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D168
2015-05-14 15:56:56 +02:00
Thibault Saunier
319e86c81c
validate: Do not unref twice the same list
...
Summary: Depends on D166
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D167
2015-05-14 15:56:56 +02:00
Thibault Saunier
2e8552eff0
validate:scenario: Add a way to specify the pipeline on which a scenario applies
...
Summary:
From within the scenario itself.
Depends on D165
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D166
2015-05-14 15:56:56 +02:00
Thibault Saunier
2548eafd11
validate: Avoid depending on Gst 1.4
...
Summary: Depends on D117
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D165
2015-05-14 15:56:56 +02:00
Thibault Saunier
b5d3622b31
validate: Add a gtk plugins that implements action types relative to Gtk
...
Summary:
Currently the only supported action is gtk-put-event allowing press and
release keyboard keys.
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D117
2015-05-14 15:56:56 +02:00
Guillaume Desmottes
4927c65710
validate: disable QOS features when running with valgrind
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D156
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
b54a22c9bc
validate: move element_has_klass() to utils
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D163
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
2760da33a3
validate: allow to pass more than one file to GST_VALIDATE_CONFIG
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D161
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
e5e7afd86f
validate: gst_validate_plugin_get_config() return 'core' conf if plugin is NULL
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D160
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
92fa2b5681
validate: add gst_validate_deinit()
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D159
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
596daaed74
validate: don't leak not maching config structures
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D158
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
c2fef15266
validate: factor out create_config()
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D157
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
63ca026b03
validate: display debug info when stopping because EOS
...
Summary:
Useful to know if we are executing the 'stop' command provided by the scenario
or not.
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D155
2015-05-11 21:55:24 +02:00
Guillaume Desmottes
0417e47e50
validate: unref last_caps when destroying pad monitor
...
Reviewers: thiblahute
Reviewed By: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D150
2015-05-07 11:19:57 +02:00
Guillaume Desmottes
c2128e45af
validate: initialize position
...
Summary: Fix invalid read when executing without having the actual position.
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D147
2015-05-06 11:32:30 +02:00
Guillaume Desmottes
4a8d4ddbf6
validate: add 'target-element-klass' property on set-property action
...
Summary:
This allows us to set a property on all the elements of the pipeline matching
a specific klass name.
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D140
2015-05-04 14:13:45 +02:00
Guillaume Desmottes
316a7bb74d
validate: add 'optional' action keyword
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D139
2015-05-04 13:24:21 +02:00
Guillaume Desmottes
d0a02df6e5
validate: scenario: call _element_added_cb() on existing children
...
Summary:
We want to have a chance to set property on all the elements of the pipelines,
including the existing children when the element is added.
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D138
2015-05-04 13:24:21 +02:00
Guillaume Desmottes
db366e0a37
Fix 'stoped' typo
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D137
2015-05-01 18:19:39 +02:00
Thibault Saunier
9bba59d9ba
validate:scenario: Fix 'duration' property of the pause action
...
We preparse it into and set it as GstClockTime in the
structures so make sure to use them as such.
2015-04-29 13:22:11 +02:00
Guillaume Desmottes
8c4a3de701
move scenarios to data/scenarios
...
Differential Revision: http://phabricator.freedesktop.org/D115
2015-04-20 15:31:26 +02:00
Guillaume Desmottes
60498f73b3
validate: scenario: fix structure and action leak
2015-04-20 08:35:58 +02:00
Guillaume Desmottes
308fa194a7
validate: report: fix GString leak when early returning
2015-04-20 08:35:58 +02:00
Thibault Saunier
848d660603
validate:pipelinemonitor: Print position only when in state >= PAUSED
...
Reviewers: Mathieu_Du
Reviewed By: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D86
2015-04-19 11:58:01 +02:00
Thibault Saunier
86efbffa32
validate:scenario: Stop scenario execution on stop action
...
And document it properly.
Summary:
The stop action was defined as "setting state to NULL" but
its actual goal is to stop the execution of the scenario. Make sure
that the scenario will not try to execute other actions when that
one has been executed.
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D103
2015-04-17 19:31:07 +02:00
Thibault Saunier
5d6fcb5727
validate: Gracefully handle absence of TAG on streams
...
Summary: And do not segfault when it happens!
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D99
2015-04-16 13:43:33 +02:00
Guillaume Desmottes
abb9e0ff2a
validate: don't pass NULL to gst_caps_copy()
2015-04-16 12:41:25 +02:00
Guillaume Desmottes
36e69f305a
validate: use GstMediaDescriptorWriter as log handler
...
Allow us to catch warnings when running gst-validate-media-check-1.0.
2015-04-16 12:41:25 +02:00
Guillaume Desmottes
2133207113
validate: media-descriptor-writer: fix string leaks
2015-04-16 12:41:25 +02:00
Ramiro Polla
6bb04c037c
validate:scenario: Add support for waiting on signals and messages
...
Reviewers: Mathieu_Du
Differential Revision:
http://phabricator.freedesktop.org/D88
2015-04-13 11:27:02 +02:00
Thibault Saunier
774dbf9346
validate:scenario: Report disabling plugin issues
...
Summary:
+ typedef GstValidateActionReturn so it can be used in the introspection
+ Add GST_VALIDATE_EXECUTE_ACTION_ERROR_REPORTED which should be used
to tell Validate that something wrong happened so the sub action
won't be executed, but that it should not report an error itself
as it has already been handled in the action function.
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D81
2015-04-10 16:53:41 +02:00
Thibault Saunier
69ca5c69cc
validate:scenario: Allow execution of disable-plugin as a config action
...
Summary:
And fix a bug where config actions were added to the list of action even
if they had already been executed
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D80
2015-04-10 16:53:41 +02:00
Thibault Saunier
5d7403a6a5
validate: Add a method to easily get plugin configuration
...
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D77
2015-04-10 16:53:41 +02:00
Thibault Saunier
4dce5054de
validate:plugins: Add support to all GApplication as a test apps
...
Summary:
Add a very simple plugin that will allow any GApplication to easily be
used with GstValidate using the LD_PRELOAD feature
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D75
2015-04-10 16:53:41 +02:00
Mathieu Duponchelle
23bb7dfdcc
validate: let structs_from_filename be exported.
...
Summary: It is useful for plugins too
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D74
2015-04-10 16:53:41 +02:00
Thibault Saunier
0159c96ab0
validate:scenario: Update Action.repeat field when needed
...
Summary: And print the current repeat value of the action that have such a field
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D73
2015-04-10 16:53:41 +02:00
Thibault Saunier
1e6b188d78
validate:scenario: Alway execute a 'quit' action on EOS
...
Summary: Making scenario more usable with LD_PRELOAD
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D72
2015-04-10 16:53:41 +02:00
Thibault Saunier
460bf61345
validate:scenario: Set the main action structure in fill_structure
...
Reviewers: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D71
2015-04-10 16:53:40 +02:00
Guillaume Desmottes
2f643bde2c
validate: scenario: fix caps leak
2015-03-31 09:45:06 +02:00
Guillaume Desmottes
37d0ea4335
validate: media-descriptor: fix filenode->caps leak
2015-03-31 09:45:06 +02:00
Guillaume Desmottes
c8e6b90f4b
validate: pad-monitor: fix caps leak
...
Don't create othercaps when early returning.
2015-03-31 09:45:06 +02:00
Guillaume Desmottes
625fe7b5df
validate: media-descriptor-writer: don't leak info and streaminfo
2015-03-26 15:42:11 +01:00
Guillaume Desmottes
32eac4db44
validate: media-descriptor: fix caps leak
...
gst_pad_get_current_caps() returns a reffed caps.
2015-03-26 10:32:09 +01:00
Guillaume Desmottes
a35614d108
validate: call gst_bus_remove_signal_watch()
...
We are supposed to call gst_bus_remove_signal_watch() for each gst_bus_add_signal_watch() call to prevent leaks.
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
6e776b8f0f
validate: media-descriptor-parser: fix string leak
...
_set_content() doesn't actually consume @content so the caller is responsible
freeing it.
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
d9a13b5563
validate: pad-monitor: fix buffers list leak
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
3f0cb5fedf
validate: pad-monitor: fix caps leak
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
81a33d5f6a
validate: fix a bunch of GstBus leaks
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
2aeaa1b279
validate: report: fix invalid read when destroying Report
...
Summary:
@report was invalid when we were trying to clear the mutex.
validate: scenario: remove weak pointer when destroying action
Free an invalid read when the scenario is destroyed after the action.
Differential Revision: http://phabricator.freedesktop.org/D44
2015-03-20 15:13:30 +01:00
Guillaume Desmottes
7aa5f85ccd
validate: report: fix invalid read when destroying Report
...
@report was invalid when we were trying to clear the mutex.
2015-03-20 14:49:24 +01:00
Guillaume Desmottes
ba175368d1
validate: scenario: don't borrow @structure in _fill_action()
...
@structure was borrowed in some code path and wasn't in some other. Make it
clearer, and fix a leak, by always copying it.
2015-03-20 11:39:32 +01:00
Guillaume Desmottes
9691136887
validate: override-registry: fix structs list leak
...
The list returned by _lines_get_strutures() needs to be deeply freed.
2015-03-20 11:33:01 +01:00
Guillaume Desmottes
a99c13da4b
validate: scenario: fix scenarios leak
2015-03-20 11:27:29 +01:00
Guillaume Desmottes
38342dfe2e
validate: reporter: fix message leak
2015-03-20 11:25:39 +01:00
Guillaume Desmottes
e9aeca28a8
validate: report: don't shadow the GString variable
...
We were leaking the GString as it's freed outside of the block.
2015-03-20 11:24:27 +01:00
Guillaume Desmottes
3a275d2212
validate: report: fix GStrv leak
2015-03-20 11:24:04 +01:00
Guillaume Desmottes
7373286968
validate: report: fix GStrv leak
...
We borrow the content of the GStrv but were leaking the array itself.
2015-03-20 11:23:29 +01:00
Guillaume Desmottes
2778e501c4
validate: move scenarios to validate/scenarios/
...
https://bugzilla.gnome.org/show_bug.cgi?id=746465
2015-03-20 10:34:48 +01:00
Thibault Saunier
b8c085b319
validate: keep executing actions even after linking up following execution
...
When linking actions execution without waiting on execution context, then
idle callback should keep being called so following action keep being
executed.
2015-03-13 18:04:42 +00:00
Thibault Saunier
49b2ed5d7a
validate:scenario: Rename get_position to execute_next_action
...
That function was wrongly called and did not correspond to what it
actually does.
2015-03-10 11:32:15 +01:00
Vincent Penquerc'h
3bb6ecd6fa
Revert "validate: add non flushing seek support"
...
This reverts commit 3ff55dcc31
.
Regressions on the test server, apparently linked to this patchset.
2015-03-09 18:26:37 +00:00
Vincent Penquerc'h
09988a97bf
Revert "validate: use segments to detect success of flushing seeks too"
...
This reverts commit c47cc7ba90
.
Regressions on the test server, apparently linked to this patchset.
2015-03-09 18:26:33 +00:00
Vincent Penquerc'h
d78c20322f
Revert "validate: expect a buffer with discontinuity after a seek"
...
This reverts commit 87064b6994
.
Regressions on the test server, apparently linked to this patchset.
2015-03-09 18:26:06 +00:00
Vincent Penquerc'h
87064b6994
validate: expect a buffer with discontinuity after a seek
...
https://bugzilla.gnome.org/show_bug.cgi?id=744783
2015-03-09 10:06:34 +00:00
Vincent Penquerc'h
c47cc7ba90
validate: use segments to detect success of flushing seeks too
...
https://bugzilla.gnome.org/show_bug.cgi?id=744783
2015-03-09 10:06:34 +00:00
Vincent Penquerc'h
3ff55dcc31
validate: add non flushing seek support
...
and a couple scenarios using them
https://bugzilla.gnome.org/show_bug.cgi?id=744783
2015-03-09 10:06:34 +00:00
Thibault Saunier
d5ddeaf8c2
validate:scenario: Handle not mandatory action types
...
Summary:
There is currently no way to handle the fact that action types
might be handled only by a specific application but not handling
this action types would not cause any difference for the good execution
of the scenario as a whole
Differential Revision: http://phabricator.freedesktop.org/D33
2015-03-05 14:55:39 +01:00
Thibault Saunier
88da04e0a0
validate:report: Allow registering of issue types through the introspection
...
Fixing annotations and make GstValidateIssue refcounted
We break the ABI in that commit but I do not expect anyone to register
issue type outside GstValidate yet.
Add padding in the structures so we can avoid breaking the ABI again later.
2015-03-04 17:28:50 +01:00
Thibault Saunier
433c8676dc
validate:monitor: Do not requiere a GstObject as target
...
We can work with any GObject and that allows applications to write
monitors for other aspects too
2015-03-04 17:24:52 +01:00
Thibault Saunier
8b261599e4
validate:scenario: Alway execute sub action on action running SYNC
...
Move methods around to avoid needing on top prototypes
2015-03-03 12:31:37 +01:00
Thibault Saunier
34394b0c7a
validate:scenario: Do not execute last sub action twice when ASYNC
2015-03-03 11:33:06 +01:00
Thibault Saunier
7888293f8f
validate:scenario: Properly print sub action as if they were main actions
2015-03-03 10:39:52 +01:00
Thibault Saunier
ec27b86fa9
validate: Build the preload so when possible
2015-02-26 11:09:23 +01:00
Thibault Saunier
f3adc999f1
validate:scenario: Fix GstValidateAction ABI adding a private structure
...
This way we can easily extend the structure and avoid needing using
a union and such
2015-02-19 13:57:30 +01:00
Thibault Saunier
3b6f187d85
validate: Properly notify user about missing plugins
...
This way it is clear in gst-validate-launcher that the failure is due
to a missing plugin
2015-02-18 10:07:17 +01:00
Thibault Saunier
f0511cc3a2
validate: Fix wrong sizeof usage
...
sizeof(int) is always <= sizeof(gpointer)
2015-02-17 18:22:12 +01:00
Thibault Saunier
08afce235c
validate: Print actions directly from the scenario
...
Avoiding user to have to print them in each and every action type
implementation.
This requires adding some API to prepare actions before printing them.
Preparing action in that case mean parsing the values contained in the
GstStructure parsing equations and setting back the actual value
afterward
API:
* GstValidatePrepateAction
* gst_validate_action_type_set_prepare_function
2015-02-17 17:11:51 +01:00
Thibault Saunier
8b6c521bb1
validate: Fix build on windows
...
Check where libgstvalidate.dll is installed and use that base folder to
figure out where GstValidate plugins are installed
2015-02-17 09:23:27 +01:00
Thibault Saunier
62a0db232c
validate: Do not forget to dist _full variant of scrubing scenarios
2015-02-16 20:56:49 +01:00
Thibault Saunier
8e5b495c62
validate: Create a gst-validate-types.h header where we define types
...
And include it from validate.h.
This way we avoid to need to typedef GstValidateAction twice, which is
a C11 feature
2015-02-16 19:52:12 +01:00
Edward Hervey
a1da4cd733
validate-report: Fix valist usage
...
a va_list always 'exists' (it's a struct). It therefore can't be NULL
(and can't be tested)
Just use the regular print variant where appropriate.
2015-02-16 19:24:23 +01:00
Thibault Saunier
3d83370770
validate:scenario: Document locking
2015-02-16 17:18:37 +01:00
Thibault Saunier
89e2855964
validate:scenario: Make get_position happen on idle
...
Summary:
- Add a way to force action to be executed in their own GSource dispatch, disabling chain action execution
API:
GstValidateScenario::execute-on-idle property
2015-02-16 17:18:32 +01:00
Thibault Saunier
51593df323
validate:scenario: Add a method to retrieve all remaining actions
...
Not only the next one as it was not making much sense!
API:
- gst_validate_scenario_get_next_action
+ gst_validate_scenario_get_actions
2015-02-16 17:18:31 +01:00
Thibault Saunier
16f97e3df6
validate:utils: Fix some annotations
2015-02-16 17:18:31 +01:00
Thibault Saunier
a69af22ca9
validate:scenario: Allow link up of action executions for overriden types
...
Exposing a GstValidateActionType.overriden_type field
And properly expose gst_validate_execute_action
2015-02-16 17:18:31 +01:00
Thibault Saunier
19f9172586
validate:reporter: Always print reports in the Gst debug system
2015-02-16 17:18:31 +01:00
Thibault Saunier
6181f7763d
validate: Misc fixes
2015-02-16 17:18:21 +01:00
Thibault Saunier
f4c6ed368e
validate: Properly annotate gst_validate_register_action_type*
...
It does not return any reference to the type
2015-02-14 16:32:12 +01:00