Commit graph

2974 commits

Author SHA1 Message Date
Thomas Vander Stichele
fb0e748c50 sys/v4l/: add more debugging send a discont at start
Original commit message from CVS:
* sys/v4l/gstv4lsrc.c: (gst_v4lsrc_get), (gst_v4lsrc_change_state):
* sys/v4l/gstv4lsrc.h:
* sys/v4l/v4lmjpegsink_calls.c: (gst_v4lmjpegsink_playback_init):
* sys/v4l/v4lmjpegsrc_calls.c: (gst_v4lmjpegsrc_capture_init):
* sys/v4l/v4lsrc_calls.c: (gst_v4lsrc_capture_init),
(gst_v4lsrc_grab_frame):
add more debugging
send a discont at start
2004-05-13 10:13:41 +00:00
Colin Walters
0349083d6d Avoid inflooping
Original commit message from CVS:
Avoid inflooping
2004-05-13 00:59:19 +00:00
Jan Schmidt
92db02143f ext/audiofile/gstafsrc.c: Remove old debug output
Original commit message from CVS:
* ext/audiofile/gstafsrc.c: (gst_afsrc_get):
Remove old debug output
* ext/dv/gstdvdec.c: (gst_dvdec_quality_get_type),
(gst_dvdec_class_init), (gst_dvdec_loop), (gst_dvdec_change_state),
(gst_dvdec_set_property), (gst_dvdec_get_property):
Change the quality setting to an enum, so it works from gst-launch
Don't renegotiate a non-linked pad. Allows audio only decoding.
* gst/deinterlace/gstdeinterlace.c: (gst_deinterlace_getcaps),
(gst_deinterlace_link), (gst_deinterlace_init):
* gst/videodrop/gstvideodrop.c: (gst_videodrop_getcaps),
(gst_videodrop_link):
Some caps negotiation fixes
2004-05-12 14:53:57 +00:00
Stéphane Loeuillet
b3448b344a ext/tarkin/gsttarkin.c: - Change RANK from NONE to PRIMARY (decoder)
Original commit message from CVS:
* ext/tarkin/gsttarkin.c :
- Change RANK from NONE to PRIMARY (decoder)
* ext/gdk_pixbuf/gstgdkpixbuf.c :
- Change RANK from NONE to MARGINAL (decoder)
* ext/divx/gstdivxenc.c :
- Change RANK from PRIMARY to NONE (encoder/spider issue)
2004-05-12 10:19:19 +00:00
Thomas Vander Stichele
8b74d078b1 copy this function until we really need > 1.0 of vorbis
Original commit message from CVS:
copy this function until we really need > 1.0 of vorbis
2004-05-12 07:18:03 +00:00
Benjamin Otte
3d48de4043 configure.ac: enable shout2 by default
Original commit message from CVS:
* configure.ac:
enable shout2 by default
* ext/shout2/gstshout2.c: (gst_shout2send_protocol_get_type),
(gst_shout2send_base_init), (gst_shout2send_init),
(gst_shout2send_connect), (gst_shout2send_change_state):
* ext/shout2/gstshout2.h:
make this work again. Based on a patch by Zaheer Merali (fixes
#142262)
* ext/theora/theora.c: (plugin_init):
don't set rank on encoders
2004-05-12 02:35:56 +00:00
Stéphane Loeuillet
216e8fb07f gst/auparse/gstauparse.c: - Document all audio encoding we can encounter from Solaris 9 headers and libsndfile inform...
Original commit message from CVS:
* gst/auparse/gstauparse.c :
- Document all audio encoding we can encounter from Solaris 9
headers and libsndfile information.
- Increase max. rate from 48000 to 192000 (to match other elements)
- Don't try to play junk data between header and samples
2004-05-11 22:55:35 +00:00
Stéphane Loeuillet
0d95b0d8f9 gst/cdxaparse/gstcdxaparse.c: Add mpegversion to CAPS to make it link
Original commit message from CVS:
* gst/cdxaparse/gstcdxaparse.c :
Add mpegversion to CAPS to make it link
Rank is as GST_RANK_SECONDARY instead of NONE
2004-05-11 16:59:44 +00:00
Jeremy Simon
c3ea7c414d gst/asfdemux/gstasfdemux.c: Use codec_data property instead of flag1 and flag2 for wma
Original commit message from CVS:
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_audio_caps):
Use codec_data property instead of flag1 and flag2 for wma
2004-05-11 16:25:03 +00:00
Benjamin Otte
a5f5f9a77b ext/libvisual/visual.c: use the right caps depending on endianness (I hope)
Original commit message from CVS:
* ext/libvisual/visual.c: (gst_visual_getcaps):
use the right caps depending on endianness (I hope)
* ext/ogg/gstoggmux.c: (gst_ogg_mux_plugin_init):
use GST_RANK_NONE for all non-decoding elements or spider gets
mighty confused
2004-05-11 15:31:36 +00:00
Thomas Vander Stichele
590a756a84 make plugin_init static
Original commit message from CVS:
make plugin_init static
2004-05-11 14:00:35 +00:00
Ronald S. Bultje
9c92a958ec gst/asfdemux/gstasfdemux.c: Fix some odd cases and fix BE metadata parsing of unicode16 text.
Original commit message from CVS:
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_process_comment):
Fix some odd cases and fix BE metadata parsing of unicode16 text.
2004-05-11 04:33:48 +00:00
Benjamin Otte
b22da0b4e2 gst/switch/gstswitch.c: whoever that was: DO NOT IMPORT PRIVATE SYMBOLS THAT ARE NOT IN
Original commit message from CVS:
* gst/switch/gstswitch.c: (gst_switch_release_pad),
(gst_switch_request_new_pad), (gst_switch_poll_sinkpads),
(gst_switch_loop), (gst_switch_get_type):
whoever that was: DO NOT IMPORT PRIVATE SYMBOLS THAT ARE NOT IN
HEADERS. Had to be said.
2004-05-11 03:56:19 +00:00
David Schleef
b47ac926dc configure.ac: Add prototype Dirac support.
Original commit message from CVS:
* configure.ac: Add prototype Dirac support.
* ext/Makefile.am:
* ext/dirac/Makefile.am:
* ext/dirac/gstdirac.cc:
* ext/dirac/gstdiracdec.cc:
2004-05-11 02:30:16 +00:00
Ronald S. Bultje
494b419c60 gst/auparse/gstauparse.c: Hack around spider. Remove me some day please.
Original commit message from CVS:
* gst/auparse/gstauparse.c: (gst_auparse_class_init),
(gst_auparse_init), (gst_auparse_chain),
(gst_auparse_change_state):
Hack around spider. Remove me some day please.
2004-05-11 00:20:02 +00:00
Ronald S. Bultje
b9e332e13f gst/auparse/gstauparse.c: Fix for some uninitialized variables in previous patch, also makes it work. Fixes #142286 w...
Original commit message from CVS:
* gst/auparse/gstauparse.c: (gst_auparse_chain):
Fix for some uninitialized variables in previous patch, also
makes it work. Fixes #142286 while we're at it.
2004-05-11 00:07:57 +00:00
Stéphane Loeuillet
2800919549 gst/auparse/gstauparse.c: eee (32, 64) only unsupported formats are ADPCM/CCITT G.72x
Original commit message from CVS:
* gst/auparse/gstauparse.c:
fixes a-law, adds mu-law, linear pcm (8,16,24,32), ieee (32, 64)
only unsupported formats are ADPCM/CCITT G.72x
reviewed by Ronald
* gst-libs/gst/audio/audio.h:
adds 24bit depth to PCM (x-raw-int)
2004-05-10 23:55:17 +00:00
Wim Taymans
dcfc49c40b ext/vorbis/: Added a raw vorbis encoder to be used with the oggmuxer.
Original commit message from CVS:
* ext/vorbis/Makefile.am:
* ext/vorbis/README:
* ext/vorbis/oggvorbisenc.c: (gst_oggvorbisenc_get_formats),
(oggvorbisenc_get_type), (vorbis_caps_factory), (raw_caps_factory),
(gst_oggvorbisenc_base_init), (gst_oggvorbisenc_class_init),
(gst_oggvorbisenc_sinkconnect), (gst_oggvorbisenc_convert_src),
(gst_oggvorbisenc_convert_sink),
(gst_oggvorbisenc_get_query_types), (gst_oggvorbisenc_src_query),
(gst_oggvorbisenc_init), (gst_oggvorbisenc_get_tag_value),
(gst_oggvorbisenc_metadata_set1), (gst_oggvorbisenc_set_metadata),
(get_constraints_string), (update_start_message),
(gst_oggvorbisenc_setup), (gst_oggvorbisenc_write_page),
(gst_oggvorbisenc_chain), (gst_oggvorbisenc_get_property),
(gst_oggvorbisenc_set_property), (gst_oggvorbisenc_change_state):
* ext/vorbis/oggvorbisenc.h:
* ext/vorbis/vorbis.c: (plugin_init):
* ext/vorbis/vorbisenc.c: (vorbis_caps_factory),
(raw_caps_factory), (gst_vorbisenc_class_init),
(gst_vorbisenc_init), (gst_vorbisenc_setup),
(gst_vorbisenc_push_packet), (gst_vorbisenc_chain),
(gst_vorbisenc_get_property), (gst_vorbisenc_set_property):
* ext/vorbis/vorbisenc.h:
Added a raw vorbis encoder to be used with the oggmuxer.
We still need the old encoder for some gnome applications,
read the README to find out how that works.
The raw encoder is called "rawvorbisenc" until 0.9.
2004-05-10 17:44:07 +00:00
Stéphane Loeuillet
179ae54751 someone ported wavparse to riff-lib, remove it from TODO
Original commit message from CVS:
someone ported wavparse to riff-lib, remove it from TODO
2004-05-10 15:02:01 +00:00
Stéphane Loeuillet
a41358c454 offmux => oggmux, sorry :)
Original commit message from CVS:
offmux => oggmux, sorry :)
2004-05-10 14:35:48 +00:00
Stéphane Loeuillet
3236dab92c ext/ogg/Makefile.am: should fix ogg[de]mux compilation
Original commit message from CVS:
* ext/ogg/Makefile.am : should fix ogg[de]mux compilation
2004-05-10 14:25:40 +00:00
Wim Taymans
a694bd08f9 ext/ogg/: Added an ogg muxer.
Original commit message from CVS:
* ext/ogg/gstogg.c: (plugin_init):
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_plugin_init),
(gst_ogg_print):
* ext/ogg/gstoggmux.c: (gst_ogg_mux_get_type),
(gst_ogg_mux_base_init), (gst_ogg_mux_class_init),
(gst_ogg_mux_get_sink_event_masks), (gst_ogg_mux_init),
(gst_ogg_mux_sinkconnect), (gst_ogg_mux_pad_link),
(gst_ogg_mux_pad_unlink), (gst_ogg_mux_request_new_pad),
(gst_ogg_mux_handle_src_event), (gst_ogg_mux_next_buffer),
(gst_ogg_mux_push_page), (gst_ogg_mux_compare_pads),
(gst_ogg_mux_queue_pads), (gst_ogg_mux_loop),
(gst_ogg_mux_get_property), (gst_ogg_mux_set_property),
(gst_ogg_mux_change_state), (gst_ogg_mux_plugin_init):
Added an ogg muxer.
Small typo fixes in the demuxer.
2004-05-10 13:34:57 +00:00
Wim Taymans
299b599bd1 ext/theora/theoraenc.c: Mark the last packet with an EOS flag which is not really needed in gstreamer.
Original commit message from CVS:
* ext/theora/theoraenc.c: (gst_theora_enc_class_init),
(theora_enc_sink_link), (theora_push_packet), (theora_enc_chain),
(theora_enc_change_state), (theora_enc_set_property),
(theora_enc_get_property):
Mark the last packet with an EOS flag which is not really needed
in gstreamer.
Do some better video framerate initialisation.
Update the buffer timestamp.
2004-05-10 13:32:11 +00:00
Stéphane Loeuillet
27dc0d1677 ext/theora/theoradec.c: "Filter/Decoder/Video" => "Codec/Decoder/Video"
Original commit message from CVS:
* ext/theora/theoradec.c : "Filter/Decoder/Video" => "Codec/Decoder/Video"
* ext/theora/theoraenc.c : "Filter/Encoder/Video" => "Codec/Encoder/Video"
* ext/xine/xineaudiodec.c : "Filter/Decoder/Audio" =>"Codec/Decoder/Audio"
2004-05-10 12:22:05 +00:00
Jan Schmidt
0fde173414 Return the result of the parent state change call
Original commit message from CVS:
Return the result of the parent state change call
2004-05-10 12:19:02 +00:00
Stéphane Loeuillet
7b18553546 ext/a52dec/gsta52dec.c: mark audio/a52, audio/ac3 as deprecated in a comment
Original commit message from CVS:
* ext/a52dec/gsta52dec.c : mark audio/a52, audio/ac3 as deprecated in a comment
* gst/ac3parse/gstac3parse.c : audio/ac3 => audio/x-ac3
* gst/realmedia/rmdemux.c : audio/a52 => audio/x-ac3
2004-05-10 00:27:36 +00:00
Stéphane Loeuillet
ba7195e818 gst/law/alaw-decode.c: put audio/x-alaw on pads, instead of audio/x-mulaw
Original commit message from CVS:
* gst/law/alaw-decode.c : put audio/x-alaw on pads, instead of audio/x-mulaw
* gst/law/alaw-encode.c : (idem)
2004-05-09 22:56:56 +00:00
Stéphane Loeuillet
8bbaf7acbf gst/law/alaw.c: alawdec should be registered with type ALAWDEC, not ALAWENC
Original commit message from CVS:
* gst/law/alaw.c : alawdec should be registered with type ALAWDEC, not ALAWENC
2004-05-09 22:46:06 +00:00
Benjamin Otte
f1479afe49 ext/alsa/gstalsasrc.c: don't use a fixed buffer size when writing variable length data to it. Fixes memory corruption...
Original commit message from CVS:
* ext/alsa/gstalsasrc.c: (gst_alsa_src_loop):
don't use a fixed buffer size when writing variable length data to
it. Fixes memory corruption and makes alsasrc work
2004-05-09 17:25:16 +00:00
Ronald S. Bultje
9e9573ff1f ext/gnomevfs/gstgnomevfssink.c: Run glib's default signal handler (??) in RUN_CLEANUP rather than
Original commit message from CVS:
* ext/gnomevfs/gstgnomevfssink.c:
(_gst_boolean_allow_overwrite_accumulator),
(gst_gnomevfssink_class_init), (gst_gnomevfssink_open_file):
Run glib's default signal handler (??) in RUN_CLEANUP rather than
RUN_LAST, and don't use that to set the accumulator value because
then it's always FALSE.
2004-05-09 16:48:42 +00:00
Ronald S. Bultje
7180b58bb3 gst-libs/gst/riff/: Fix for unaligned RIFF files (i.e. where all the chunks together in a LIST chunk are not of the s...
Original commit message from CVS:
* gst-libs/gst/riff/riff-media.c:
(gst_riff_create_video_caps_with_data),
(gst_riff_create_audio_caps),
(gst_riff_create_audio_template_caps):
* gst-libs/gst/riff/riff-read.c: (gst_riff_peek_head):
Fix for unaligned RIFF files (i.e. where all the chunks together
in a LIST chunk are not of the same size as the size given in
the LIST chunk header). Fixes several odd WAVE files. Also fix
ADPCM (block_align property) in audio, so that wavparse based
on this works now as it used to stand-alone.
2004-05-09 15:49:25 +00:00
Benjamin Otte
5dc93f5e7b ext/: \1/Codec, (fixes #142193)
Original commit message from CVS:
reviewed by Benjamin Otte  <otte@gnome.org>
* ext/a52dec/gsta52dec.c:
* ext/divx/gstdivxdec.c:
* ext/divx/gstdivxenc.c:
* ext/dts/gstdtsdec.c: (gst_dtsdec_base_init):
* ext/faac/gstfaac.c: (gst_faac_base_init):
* ext/faad/gstfaad.c: (gst_faad_base_init):
* ext/ivorbis/vorbisfile.c:
* ext/lame/gstlame.c:
* ext/libfame/gstlibfame.c:
* ext/mpeg2enc/gstmpeg2enc.cc:
* ext/musicbrainz/gsttrm.c: (gst_musicbrainz_base_init):
* ext/sidplay/gstsiddec.cc:
* ext/speex/gstspeexdec.c:
* ext/speex/gstspeexenc.c:
* ext/xvid/gstxviddec.c:
* ext/xvid/gstxvidenc.c:
correct klasses. Mostly s,Codec/(Audio|Video),\1/Codec,
(fixes #142193)
2004-05-09 14:37:14 +00:00
Ronald S. Bultje
94d9342dc9 ext/alsa/: Fix alsa oddness in mixer after the combination of using mixer in source/sink elements and using hw:x,y in...
Original commit message from CVS:
* ext/alsa/gstalsa.c: (device_list),
(gst_alsa_class_probe_devices):
* ext/alsa/gstalsamixer.c: (gst_alsa_mixer_open):
Fix alsa oddness in mixer after the combination of using mixer
in source/sink elements and using hw:x,y instead of just hw:x.
2004-05-09 00:30:06 +00:00
Benjamin Otte
5d568b25ce gst/wavparse/gstwavparse.c: make PAUSED=>READY=>PAUSED=READY work by not destroying NULL sourcepads
Original commit message from CVS:
* gst/wavparse/gstwavparse.c: (gst_wavparse_destroy_sourcepad),
(gst_wavparse_create_sourcepad):
make PAUSED=>READY=>PAUSED=READY work by not destroying NULL
sourcepads
2004-05-09 00:13:39 +00:00
Benjamin Otte
12ca207b30 ext/alsa/gstalsasink.c: allow discont events before caps nego
Original commit message from CVS:
* ext/alsa/gstalsasink.c: (gst_alsa_sink_check_event):
allow discont events before caps nego
2004-05-09 00:02:26 +00:00
Benjamin Otte
98e395d53e ext/vorbis/vorbisdec.c: don't leak events
Original commit message from CVS:
* ext/vorbis/vorbisdec.c: (vorbis_dec_event):
don't leak events
2004-05-08 16:30:03 +00:00
Benjamin Otte
f79bab2955 gst/level/gstlevel.*: figure out if we're initialized directly instead of keeping a variable that's wrong in 90% of c...
Original commit message from CVS:
* gst/level/gstlevel.c: (gst_level_link), (gst_level_chain),
(gst_level_change_state), (gst_level_init):
* gst/level/gstlevel.h:
figure out if we're initialized directly instead of keeping a
variable that's wrong in 90% of cases
don't initialize pads and then leak them and use a new unitialized
pad. (fixes #142084)
these were bugs so n00bish I didn't find them for an hour :/
2004-05-08 13:03:59 +00:00
Iain Holmes
935969b8c1 Rewrote wavparse to use riff-read instead of doing bytestream stuff by hand.
Original commit message from CVS:
Rewrote wavparse to use riff-read instead of doing bytestream stuff by hand.
Made some useful functions in riff-read non-static.
2004-05-08 00:33:39 +00:00
David Schleef
bcd67755b5 ext/faad/gstfaad.c: HACK to correct signed char assumption in faad.h.
Original commit message from CVS:
* ext/faad/gstfaad.c: (gst_faad_sinkconnect): HACK to correct
signed char assumption in faad.h.
2004-05-08 00:20:18 +00:00
Ronald S. Bultje
fbbf25b293 sys/v4l2/gstv4l2src.c:
Original commit message from CVS:
* sys/v4l2/gstv4l2src.c: (gst_v4l2src_v4l2fourcc_to_caps):
Missing break, detected by Daniel Gazard <daniel.gazard@free.fr>.
2004-05-07 23:47:00 +00:00
Colin Walters
9ecad5ee01 fix a number of memleaks
Original commit message from CVS:
fix a number of memleaks
2004-05-07 20:26:47 +00:00
Jan Schmidt
67757ba250 ext/dv/gstdvdec.c: Fix caps nego and pad templates. RGB mode caps should work now.
Original commit message from CVS:
* ext/dv/gstdvdec.c: (gst_dvdec_video_link):
Fix caps nego and pad templates. RGB mode caps should
work now.
* ext/dvdnav/gst-dvd:
Move mpeg2dec inside the thread because otherwise the
queue rejects cap changes mid-stream
* ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_get_type),
(gst_mpeg2dec_flush_decoder):
For mpeg2dec > 0.4.0, call the flush function instead of
manually extracting all in-flight frames.
* ext/raw1394/gstdv1394src.c: (gst_dv1394src_factory),
(gst_dv1394src_init), (gst_dv1394src_iso_receive):
Change mime type video/dv go video/x-dv to match the
rest of gst-plugins
2004-05-07 16:17:25 +00:00
Ronald S. Bultje
7fa3cd3b18 ext/alsa/: Make alsasink/src a subclass of alsamixer so that mixer stuff shows up in gst-rec. Needs some finetuning.
Original commit message from CVS:
* ext/alsa/gstalsamixer.c: (gst_alsa_mixer_build_list):
* ext/alsa/gstalsasink.c: (gst_alsa_sink_get_type),
(gst_alsa_sink_class_init):
* ext/alsa/gstalsasink.h:
* ext/alsa/gstalsasrc.c: (gst_alsa_src_get_type),
(gst_alsa_src_class_init):
* ext/alsa/gstalsasrc.h:
Make alsasink/src a subclass of alsamixer so that mixer stuff
shows up in gst-rec. Needs some finetuning.
2004-05-07 04:56:56 +00:00
Benjamin Otte
07974d8869 cvs commit: warning: file 'ChangeLog' seems to still contain conflict indicators
Original commit message from CVS:
cvs commit: warning: file 'ChangeLog' seems to still contain conflict indicators
2004-05-07 00:45:12 +00:00
Benjamin Otte
b581588127 ext/lame/gstlame.c: simplify
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_chain):
simplify
* ext/mad/gstmad.c: (gst_mad_handle_event):
fix event leak
* gst/typefind/gsttypefindfunctions.c: (mp3_type_find):
be able to detect mp3 files < 4096 bytes
2004-05-07 00:43:50 +00:00
Wim Taymans
bb396483ac ext/theora/theoraenc.c: Also encode the first frame, cleanup some code.
Original commit message from CVS:
* ext/theora/theoraenc.c: (gst_theora_enc_class_init),
(theora_enc_sink_link), (theora_push_packet), (theora_enc_chain),
(theora_enc_set_property), (theora_enc_get_property):
Also encode the first frame, cleanup some code.
2004-05-06 14:32:14 +00:00
Wim Taymans
35eb307d93 ext/mpeg2enc/gstmpeg2enc.cc: Forward events first before deciding that negotiation was not performed.
Original commit message from CVS:
* ext/mpeg2enc/gstmpeg2enc.cc:
Forward events first before deciding that negotiation was
not performed.
2004-05-06 09:21:24 +00:00
Wim Taymans
6a07206b05 gst/wavenc/gstwavenc.c: First process the events before deciding that negotiation was not performed.
Original commit message from CVS:
* gst/wavenc/gstwavenc.c: (gst_wavenc_chain):
First process the events before deciding that negotiation
was not performed.
2004-05-06 09:14:28 +00:00
Wim Taymans
3060b5e9f8 ext/theora/: Added a theora encoder, grouped the encoder and decoder into the same plugin.
Original commit message from CVS:
* ext/theora/Makefile.am:
* ext/theora/theora.c: (plugin_init):
* ext/theora/theoradec.c: (theora_dec_change_state):
* ext/theora/theoraenc.c: (gst_theora_enc_base_init),
(gst_theora_enc_class_init), (gst_theora_enc_init),
(theora_enc_sink_link), (theora_enc_event), (theora_push_packet),
(theora_enc_chain), (theora_enc_change_state),
(theora_enc_set_property), (theora_enc_get_property):
Added a theora encoder, grouped the encoder and decoder into the
same plugin.
2004-05-06 09:10:31 +00:00
Thomas Vander Stichele
9dc7089430 ext/jpeg/gstjpegenc.c: fix DURATION on outgoing buffers
Original commit message from CVS:
* ext/jpeg/gstjpegenc.c: (gst_jpegenc_get_type),
(gst_jpegenc_chain):
fix DURATION on outgoing buffers
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_handle_sink_event):
debug using time formats
* sys/ximage/ximagesink.c: (gst_ximagesink_xcontext_get):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_get_xv_support),
(gst_xvimagesink_sink_link):
windows with width/height 0 generate X errors, so don't allow them
2004-05-05 11:29:49 +00:00