From ffeb09e4abe73d3b9e8909996816f0288e307e22 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Thu, 8 Feb 2018 15:25:22 +1100 Subject: [PATCH] webrtc: bail on invalid rtpbin names If we fail parsing rtpbin pad names, someone has screwed up so critical and return. CID #1429142 --- ext/webrtc/gstwebrtcbin.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index a834a22c59..453fb26d0d 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -2791,7 +2791,10 @@ on_rtpbin_pad_added (GstElement * rtpbin, GstPad * new_pad, TransportStream *stream; GstWebRTCBinPad *pad; - sscanf (new_pad_name, "recv_rtp_src_%u_%u_%u", &session_id, &ssrc, &pt); + if (sscanf (new_pad_name, "recv_rtp_src_%u_%u_%u", &session_id, &ssrc, &pt)) { + g_critical ("Invalid rtpbin pad name \'%s\'", new_pad_name); + return; + } stream = _find_transport_for_session (webrtc, session_id); if (!stream)