From fe73c3b0f32e9f1b67f82d60d5c26856d2b41876 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Sat, 11 Apr 2020 00:35:16 +0900 Subject: [PATCH] splitmuxsink: Post error when requested timecode interval is invalid In case we cannot rely on max-size-timecode for split decision, post error instead of crashing --- gst/multifile/gstsplitmuxsink.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gst/multifile/gstsplitmuxsink.c b/gst/multifile/gstsplitmuxsink.c index ff78b83e21..5645f1a94d 100644 --- a/gst/multifile/gstsplitmuxsink.c +++ b/gst/multifile/gstsplitmuxsink.c @@ -1293,6 +1293,11 @@ calculate_next_max_timecode (GstSplitMuxSink * splitmux, return GST_CLOCK_TIME_NONE; target_tc = gst_video_time_code_add_interval (cur_tc, splitmux->tc_interval); + if (!target_tc) { + GST_ELEMENT_ERROR (splitmux, + STREAM, FAILED, (NULL), ("Couldn't calculate target timecode")); + return GST_CLOCK_TIME_NONE; + } /* Convert to ns */ target_tc_time = gst_video_time_code_nsec_since_daily_jam (target_tc);