mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

x264enc: add FIXME note for future configuration cleanup

Browse source
This commit is contained in:
Mark Nauwelaerts 2017-08-09 19:31:56 +02:00
parent 861cff5da1
commit fc826ac6dc
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ext/x264/gstx264enc.c
View file

@ -1692,6 +1692,14 @@ gst_x264_enc_init_encoder (GstX264Enc * encoder)
encoder->x264param.analyse.b_psnr = 0; encoder->x264param.analyse.b_psnr = 0;
/* FIXME 2.0 make configuration more sane and consistent with x264 cmdline:
* + split pass property into a pass property (pass1/2/3 enum) and rc-method
* + bitrate property should only be used in case of CBR method
* + vbv bitrate/buffer should have separate configuration that is then
* applied independently of the mode:
* + either using properties (new) vbv-maxrate and (renamed) vbv-bufsize
* + or dropping vbv-buf-capacity altogether and simply using option-string
*/
switch (encoder->pass) { switch (encoder->pass) {
case GST_X264_ENC_PASS_QUANT: case GST_X264_ENC_PASS_QUANT:
encoder->x264param.rc.i_rc_method = X264_RC_CQP; encoder->x264param.rc.i_rc_method = X264_RC_CQP;