From fc038f1f4e45c5c3eb9ba8261c4e0210dd125821 Mon Sep 17 00:00:00 2001 From: Alex O'Konski Date: Fri, 17 Apr 2015 06:51:46 +0000 Subject: [PATCH] icydemux: Fix segfault if metadata-interval is 0 Prevents an extra unref of GstBuffer when passing a non-icy stream through icydemux with metadata-interval set to 0. Reproducible with: gst-launch-1.0 filesrc location=~/testsong.mp3 ! \ 'application/x-icy,metadata-interval=(int)0' ! icydemux ! decodebin ! wavenc ! \ filesink location=~/testsong.wav https://bugzilla.gnome.org/show_bug.cgi?id=748024 --- gst/icydemux/gsticydemux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gst/icydemux/gsticydemux.c b/gst/icydemux/gsticydemux.c index cdcb5edeb7..dade21bd68 100644 --- a/gst/icydemux/gsticydemux.c +++ b/gst/icydemux/gsticydemux.c @@ -551,6 +551,7 @@ gst_icydemux_chain (GstPad * pad, GstObject * parent, GstBuffer * buf) if (icydemux->meta_interval == 0) { ret = gst_icydemux_typefind_or_forward (icydemux, buf); + buf = NULL; goto done; }