From f84ebbd95f7bf7067ac517cd1442bab95992fd42 Mon Sep 17 00:00:00 2001 From: Roman Shpuntov Date: Wed, 30 Oct 2019 14:56:41 +0700 Subject: [PATCH] vtdec: fix leak of CMFormatDescription There was consideration for replacing the CMFormatDescription used on format changes in `set_format()` however on shutdown, we were leaking the CMFormatDescription at the end of processing. 'https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1106' --- sys/applemedia/vtdec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/applemedia/vtdec.c b/sys/applemedia/vtdec.c index 5e1bb055d3..705a70d4b3 100644 --- a/sys/applemedia/vtdec.c +++ b/sys/applemedia/vtdec.c @@ -205,6 +205,10 @@ gst_vtdec_stop (GstVideoDecoder * decoder) gst_gl_context_helper_free (vtdec->ctxh); vtdec->ctxh = NULL; + if (vtdec->format_description) + CFRelease (vtdec->format_description); + vtdec->format_description = NULL; + GST_DEBUG_OBJECT (vtdec, "stop"); return TRUE;